On Wed, 14 Aug 2024 13:00:21 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Alan's suggestion > > src/java.base/share/classes/java/net/DatagramSocket.java line 426: > >> 424: * >> 425: * <p> If this socket is already connected, then this method will >> attempt to >> 426: * connect to the passed address and if the connect fails then the >> state of > > A small suggestion is to say "given address" rather than "passed address" and > I think break at this point so that "If this connect fails ..." is a new > sentence. Done. I've updated the PR with this change. I'll now create the CSR for review. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20543#discussion_r1716897687
