On Fri, 10 May 2024 01:22:17 GMT, SendaoYan wrote:
>> Hi,
>> The testcase TcpNoDelayNotRequired.java run timeout with -Xcomp jvm
>> options. With -Xcomp jvm options, the jvm consumes a lot of time to compile
>> the java code, but the timeout value is set to 5 second.
>>
>> I think it has 3
On Thu, 9 May 2024 12:49:09 GMT, Nizar Benalla wrote:
>> Passes Tier 1-3
>> Please review this change that aims to fix a bug when parsing the client's
>> request.
>>
>> RFC 9110 states
>>
>>> 11. HTTP Authentication 11.1. Authentication Scheme
>> HTTP provides a general framework for access c
On Fri, 10 May 2024 07:46:41 GMT, Jaikiran Pai wrote:
> The change looks OK to me. With the latest state of this PR, does the test
> now pass on the setup where this was previously failing?
Thanks for the review and approved.
The GHA test runner intermittent
[failure](https://github.com/senda
Can I please get a review of this change which proposes to address
https://bugs.openjdk.org/browse/JDK-8332020?
`jwebserver` when it is launched prints a URL where the server is accessible.
When launched using an IPv6 bind address, the printed URL doesn't enclose the
IPv6 literal in `[` `]` thu
On Fri, 10 May 2024 03:53:12 GMT, Nizar Benalla wrote:
>> Please review this simple change, aiming to fix current uses of `@since` in
>> the source code
>> -The constructor
>> BasicAuthenticator(java.lang.String,java.nio.charset.Charset) needs an
>> `@since 14` instead of 9.
>> -com.sun.net.ht
On Thu, 9 May 2024 12:49:09 GMT, Nizar Benalla wrote:
>> Passes Tier 1-3
>> Please review this change that aims to fix a bug when parsing the client's
>> request.
>>
>> RFC 9110 states
>>
>>> 11. HTTP Authentication 11.1. Authentication Scheme
>> HTTP provides a general framework for access c
On Fri, 10 May 2024 09:21:15 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible.
> When launched using an IPv6 bind address
On Fri, 10 May 2024 01:22:17 GMT, SendaoYan wrote:
>> Hi,
>> The testcase TcpNoDelayNotRequired.java run timeout with -Xcomp jvm
>> options. With -Xcomp jvm options, the jvm consumes a lot of time to compile
>> the java code, but the timeout value is set to 5 second.
>>
>> I think it has 3
On Fri, 10 May 2024 10:00:57 GMT, Daniel Fuchs wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Thu, 9 May 2024 16:44:23 GMT, SendaoYan wrote:
> Hi,
> The testcase TcpNoDelayNotRequired.java run timeout with -Xcomp jvm
> options. With -Xcomp jvm options, the jvm consumes a lot of time to compile
> the java code, but the timeout value is set to 5 second.
>
> I think it has 3 method
On Fri, 10 May 2024 10:05:07 GMT, Jaikiran Pai wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/SimpleFileServerImpl.java
>> line 185:
>>
>>> 183:
>>> writer.println(ResourceBundleHelper.getMessage("msg.start.anylocal", root,
>>> port, url));
>>> 184:
On Fri, 10 May 2024 10:14:13 GMT, Daniel Fuchs wrote:
> My concern here is potentially backporting this change - where we would need
> to make sure that all resource bundles in all possible languages that are
> supported are correctly updated.
I hadn't considered that. Given that, I think it's
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible.
> When launched using an IPv6 bind address, the printed URL doesn't enclose the
> IPv6 literal in
On Fri, 10 May 2024 10:16:10 GMT, Jaikiran Pai wrote:
>> Oh - I see... Hmmm - good question. I'd say it should be OK, since it's only
>> a log message.
>> My concern here is potentially backporting this change - where we would need
>> to make sure that all resource bundles in all possible langu
On Fri, 10 May 2024 10:31:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Fri, 10 May 2024 03:53:12 GMT, Nizar Benalla wrote:
>> Please review this simple change, aiming to fix current uses of `@since` in
>> the source code
>> -The constructor
>> BasicAuthenticator(java.lang.String,java.nio.charset.Charset) needs an
>> `@since 14` instead of 9.
>> -com.sun.net.ht
On Fri, 10 May 2024 07:53:07 GMT, Jaikiran Pai wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Declare `ServerAuthenticator.invoked` as volatile
>
> test/jdk/com/sun/net/httpserver/BasicAuthToken.java line 28:
>
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible.
> When launched using an IPv6 bind address, the printed URL doesn't enclose the
> IPv6 literal in
On Fri, 10 May 2024 10:53:36 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Daniel's suggestion - don't change resource bundle messages
>
> test/jdk/com/sun/net/httpserver/simpleserver/jwebserver
On Fri, 10 May 2024 09:46:44 GMT, Daniel Fuchs wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Declare `ServerAuthenticator.invoked` as volatile
>
> test/jdk/com/sun/net/httpserver/BasicAuthToken.java line 24:
>
On Fri, 10 May 2024 12:02:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
> Passes Tier 1-3
> Please review this change that aims to fix a bug when parsing the client's
> request.
>
> RFC 9110 states
>
>> 11. HTTP Authentication 11.1. Authentication Scheme
> HTTP provides a general framework for access control and authentication, via
> an extensible set of challenge
On Fri, 10 May 2024 07:56:38 GMT, Jaikiran Pai wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Declare `ServerAuthenticator.invoked` as volatile
>
> test/jdk/com/sun/net/httpserver/BasicAuthToken.java line 94:
>
On Fri, 10 May 2024 13:58:58 GMT, Nizar Benalla wrote:
>> Passes Tier 1-3
>> Please review this change that aims to fix a bug when parsing the client's
>> request.
>>
>> RFC 9110 states
>>
>>> 11. HTTP Authentication 11.1. Authentication Scheme
>> HTTP provides a general framework for access
On Fri, 10 May 2024 13:58:58 GMT, Nizar Benalla wrote:
>> Passes Tier 1-3
>> Please review this change that aims to fix a bug when parsing the client's
>> request.
>>
>> RFC 9110 states
>>
>>> 11. HTTP Authentication 11.1. Authentication Scheme
>> HTTP provides a general framework for access
On Fri, 10 May 2024 12:02:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Fri, 10 May 2024 13:58:58 GMT, Nizar Benalla wrote:
>> Passes Tier 1-3
>> Please review this change that aims to fix a bug when parsing the client's
>> request.
>>
>> RFC 9110 states
>>
>>> 11. HTTP Authentication 11.1. Authentication Scheme
>> HTTP provides a general framework for access
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible.
> When launched using an IPv6 bind address, the printed URL doesn't enclose the
> IPv6 literal in
On Fri, 10 May 2024 14:46:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Fri, 10 May 2024 01:22:17 GMT, SendaoYan wrote:
>> Hi,
>> The testcase TcpNoDelayNotRequired.java run timeout with -Xcomp jvm
>> options. With -Xcomp jvm options, the jvm consumes a lot of time to compile
>> the java code, but the timeout value is set to 5 second.
>>
>> I think it has 3
On Fri, 10 May 2024 13:58:58 GMT, Nizar Benalla wrote:
>> Passes Tier 1-3
>> Please review this change that aims to fix a bug when parsing the client's
>> request.
>>
>> RFC 9110 states
>>
>>> 11. HTTP Authentication 11.1. Authentication Scheme
>> HTTP provides a general framework for access
On Wed, 8 May 2024 04:23:47 GMT, Nizar Benalla wrote:
> Passes Tier 1-3
> Please review this change that aims to fix a bug when parsing the client's
> request.
>
> RFC 9110 states
>
>> 11. HTTP Authentication 11.1. Authentication Scheme
> HTTP provides a general framework for access control a
On Fri, 10 May 2024 14:46:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Fri, 10 May 2024 09:21:15 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible.
> When launched using an IPv6 bind address
34 matches
Mail list logo
