On Fri, 10 May 2024 01:22:17 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi, >> The testcase TcpNoDelayNotRequired.java run timeout with -Xcomp jvm >> options. With -Xcomp jvm options, the jvm consumes a lot of time to compile >> the java code, but the timeout value is set to 5 second. >> >> I think it has 3 methods to solve this timeout issue. >> >> 1. Change timeout value from 5 to 60 or more. >> 2. Problemlist this testcase in `test/hotspot/jtreg/ProblemList-Xcomp.txt` >> 3. Set this testcase `@requires vm.compMode != "Xcomp"`, so this testcase >> will be skiped when set jvm options -`Xcomp` or `-Xcomp >> -XX:TieredStopAtLevel=1` >> >> Maybe the 3rd method seems more reasonable. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > change "@requires vm.flagless" to "@requires vm.compMode != \"Xcomp\"" > /sponsor Thinks all for the review, approve and sponsor. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19159#issuecomment-2104790740
