On Fri, 10 May 2024 07:53:07 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Declare `ServerAuthenticator.invoked` as volatile > > test/jdk/com/sun/net/httpserver/BasicAuthToken.java line 28: > >> 26: * @bug 8144100 >> 27: * @summary checking token sent by client should be done in >> case-insensitive manner >> 28: * @run main/othervm BasicAuthToken > > Hello Nizar, I couldn't spot anything in the test that forces the use of > "othervm". Is the othervm intentional? If not, I would recommend changing it > to just "main". Sure, I thought `othervm` was used by convention as it was in most tests I saw ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19133#discussion_r1596633192
