On Fri, 10 May 2024 13:58:58 GMT, Nizar Benalla <d...@openjdk.org> wrote:
>> Passes Tier 1-3 >> Please review this change that aims to fix a bug when parsing the client's >> request. >> >> RFC 9110 states >> >>> 11. HTTP Authentication 11.1. Authentication Scheme >> HTTP provides a general framework for access control and authentication, via >> an extensible set of challenge-response authentication schemes, which can be >> used by a server to challenge a client request and by a client to provide >> authentication information. It uses a **case-insensitive** token to identify >> the authentication scheme: >> ```auth-scheme = token``` >> >> But in `BasicAuthenticator#authenticate` it was done in a case sensitive >> manner >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > added suggestions by daniel and jaikiran The changes look good to me and I don't have any more review comments. Thank you for the updates as well as fixing this issue. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19133#pullrequestreview-2050160633
