On Wed, 1 May 2024 20:45:27 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Wed, 1 May 2024 20:45:27 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Tue, 7 May 2024 06:17:22 GMT, Christian Stein wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java
>> line 269:
>>
>>> 267: var bytes = stream.readAllBytes();
>>> 268: respHdrs.set("Content-Type", "image/x-icon");
>>> 269:
On Tue, 7 May 2024 07:45:35 GMT, Daniel Jeliński wrote:
>> Using Java's birthday `"Mon, 23 May 1995 11:11:11 GMT"` for the time being.
>
> [java.version.date](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/System.html#java.version.date)
> could be a reasonable alternative
On Thu, 25 Apr 2024 17:01:52 GMT, robert engels wrote:
>> fix bug JDK-B6968351 by avoiding flush after response headers
>
> robert engels has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update copyright date
LGTM. In order to proceed, use
> While working in that area I found some potential for cleanup of a few tests.
>
> Most notably:
>
> B5045306.java:
> - does not need to run in othervm
> - the executor service that it uses should be shut down eventually to free
> resources
>
> B8291637.java:
> - use just one instead of two te
On Tue, 7 May 2024 07:08:55 GMT, Jaikiran Pai wrote:
> Hello Christoph, the latest changes look fine to me. I've added a trivial
> comment about reading the inputstream in one of the test, but you can leave
> it in its current form if you prefer to. Please run `tier2` tests once before
> integ
On Tue, 16 Apr 2024 22:38:57 GMT, Aleksei Efimov wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/net/Inet4Address.java
>>
>>Co-authored-by: Daniel Fuchs <67001
On Tue, 16 Apr 2024 22:38:57 GMT, Aleksei Efimov wrote:
>> Sergey Chernyshev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/net/Inet4Address.java
>>
>>Co-authored-by: Daniel Fuchs <67001
On Thu, 25 Apr 2024 17:01:52 GMT, robert engels wrote:
>> fix bug JDK-B6968351 by avoiding flush after response headers
>
> robert engels has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update copyright date
Marked as reviewed by jpai (Rev
On Mon, 6 May 2024 05:36:10 GMT, Jaikiran Pai wrote:
>> Can I get a review of this test-only fix which addresses the intermittent
>> failrues in `com/sun/net/httpserver/HttpsParametersClientAuthTest.java` on
>> Windows?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8331334, the test re
On Tue, 7 May 2024 11:35:17 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> don't check for exception message (which can be localized)
>
> test/jdk/com/sun/net/httpserver/HttpsParametersClientAuth
Please review this mechanical change to man pages. This PR should be integrated
after https://github.com/openjdk/jdk/pull/18787.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/19119/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19119&range=
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
This PR is standalone as opposed to dependent because the
https://github.com/openjdk/jdk/pull/18787 dependenc
On Thu, 25 Apr 2024 17:01:52 GMT, robert engels wrote:
>> fix bug JDK-B6968351 by avoiding flush after response headers
>
> robert engels has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update copyright date
Tests were green. Please integr
On Sat, 6 Apr 2024 23:35:48 GMT, robert engels wrote:
> fix bug JDK-B6968351 by avoiding flush after response headers
This pull request has now been integrated.
Changeset: 02c95a6d
Author:robertengels
Committer: Daniel Fuchs
URL:
https://git.openjdk.org/jdk/commit/02c95a6d7eb77ed17
On Mon, 6 May 2024 05:36:10 GMT, Jaikiran Pai wrote:
>> Can I get a review of this test-only fix which addresses the intermittent
>> failrues in `com/sun/net/httpserver/HttpsParametersClientAuthTest.java` on
>> Windows?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8331334, the test re
On Tue, 7 May 2024 08:43:09 GMT, Christoph Langer wrote:
>> While working in that area I found some potential for cleanup of a few tests.
>>
>> Most notably:
>>
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free
On Tue, 30 Apr 2024 11:23:01 GMT, Christian Stein wrote:
> Please pre-review this draft pull request adding a default for response for
> the `/favicon.ico` path to the Simple Web Server introduced by [JEP
> 408](https://openjdk.org/jeps/408). The image in this PR is a copy of
> https://inside.
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
Marked as reviewed by darcy (Reviewer).
> This PR is standalone as opposed to dependent because the #18787 de
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
Thanks for reviewing it Joe, I'm now delegating integration of this PR to
@JesperIRL, you, or anyone who will
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
Marked as reviewed by jjg (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19119#pullre
On Mon, 6 May 2024 05:36:10 GMT, Jaikiran Pai wrote:
>> Can I get a review of this test-only fix which addresses the intermittent
>> failrues in `com/sun/net/httpserver/HttpsParametersClientAuthTest.java` on
>> Windows?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8331334, the test re
On Sun, 5 May 2024 07:13:35 GMT, Jaikiran Pai wrote:
> Can I get a review of this test-only fix which addresses the intermittent
> failrues in `com/sun/net/httpserver/HttpsParametersClientAuthTest.java` on
> Windows?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8331334, the test relies
On Tue, 30 Apr 2024 11:23:01 GMT, Christian Stein wrote:
> Please pre-review this draft pull request adding a default for response for
> the `/favicon.ico` path to the Simple Web Server introduced by [JEP
> 408](https://openjdk.org/jeps/408). The image in this PR is a copy of
> https://inside.
25 matches
Mail list logo
