On Tue, 7 May 2024 06:17:22 GMT, Christian Stein <cst...@openjdk.org> wrote:

>> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java
>>  line 269:
>> 
>>> 267:             var bytes = stream.readAllBytes();
>>> 268:             respHdrs.set("Content-Type", "image/x-icon");
>>> 269:             // TODO respHdrs.set("Last-Modified", 
>>> getLastModified(...));
>> 
>> Is there a canonical way to retrieve a stable timestamp for the built-in 
>> `favicon.ico` here?
>
> Using Java's birthday `"Mon, 23 May 1995 11:11:11 GMT"` for the time being.

[java.version.date](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/System.html#java.version.date)
 could be a reasonable alternative

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19020#discussion_r1591966186

Reply via email to