On 09/11/18 14:33, Pavel Rappo wrote:
Alan, Chris,
Thanks for reviewing this change. However, before the push I tested it again and
found out that there is a small number of Linux machines on which both tests
fail. The only thing I found to be in common between these machines was the
version of
Michael,
On 09/11/18 15:48, Michael McMahon wrote:
Could i get the following small change reviewed please?
http://cr.openjdk.java.net/~michaelm/8213616/webrev.1/
The change looks ok to me. Just a few comments:
1) The specification already mentions that "any query or
fragment components of
Hello,
Please review the following change:
http://cr.openjdk.java.net/~prappo/8213490/webrev.00
This change is all about typos in javadoc, variables' names and comments. Once
again, not only does this change addresses aesthetic issues, it also helps with
searches.
As always with this type of
Hi Pavel,
The typos fixes look OK to me - I'll let Michael/Chris?
who have more knowledge on the history of the Inet6Address
impl to validate the new link - though I suspect that's OK.
best regards,
-- daniel
On 12/11/2018 16:27, Pavel Rappo wrote:
Hello,
Please review the following change:
Hi Chris,
I agree with your comments. A small spec change would make it crystal clear.
I'd like to structure it so that it's clearer that the query and
fragment are ignored though.
Updated webrev at
http://cr.openjdk.java.net/~michaelm/8213616/webrev.2/index.html
Thanks,
Michael
On 12/11/201
On 12/11/2018 17:30, Daniel Fuchs wrote:
Hi Pavel,
The typos fixes look OK to me - I'll let Michael/Chris?
who have more knowledge on the history of the Inet6Address
impl to validate the new link - though I suspect that's OK.
It will need a CSR because it changes Inet6Address to specify that
> On 12 Nov 2018, at 18:14, Alan Bateman wrote:
>
> It will need a CSR because it changes Inet6Address to specify that it can be
> extended with scoped addresses described by RFC 4007. It might need analysis
> to understand the differences between the draft and RFC 4007 (just in case it
> brin
See also
https://bugs.openjdk.java.net/browse/JDK-8213218
https://bugs.openjdk.java.net/browse/JDK-8213220
On Mon, Nov 12, 2018 at 10:29 AM, Pavel Rappo
wrote:
> > On 12 Nov 2018, at 18:14, Alan Bateman wrote:
> >
> > It will need a CSR because it changes Inet6Address to specify that it
> can b
Daniel, Alan,
I excluded the update from the draft to the RFC and created a separate bug
for it:
[P5] 8213757: Investigate the possibility of updating the reference to the
spec in java.net.Inet6Address
I added the changes to the URI class from JDK-8213490, which then effectively
became a du
Hi Pavel!
All looks good to me!
Do you want to change ie. -> i.e. here as well:
src/java.base/windows/native/libnet/net_util_md.c
- * 2. If the reqeusted port is 0 (*ie*. any port) then we try to bind
in v4 space
+ * 2. If the requested port is 0 (*ie*. any port) then we try to bind
in v4
I'm scanning a file and downloading links inside:
lines.flapMap(x -> Stream.ofNullable(findURIFrom(x)))
.map(l -> download(c, l))
.forEach(f -> f.join());
CompletableFuture> download(HttpClient c, URI link) {
return c.sendAsync(HttpRequest.newBuilder(link).build(),
HttpR
> On 13 Nov 2018, at 00:35, Ivan Gerasimov wrote:
>
> Do you want to change ie. -> i.e. here as well:
>
> src/java.base/windows/native/libnet/net_util_md.c
>
> - * 2. If the reqeusted port is 0 (ie. any port) then we try to bind in v4
> space
> + * 2. If the requested port is 0 (ie. any port
> On 13 Nov 2018, at 02:35, Weijun Wang wrote:
>
> I'm scanning a file and downloading links inside:
>
> lines.flapMap(x -> Stream.ofNullable(findURIFrom(x)))
> .map(l -> download(c, l))
> .forEach(f -> f.join());
>
> CompletableFuture> download(HttpClient c, URI link) {
>return c.s
> On Nov 13, 2018, at 11:09 AM, Pavel Rappo wrote:
>
>> On 13 Nov 2018, at 02:35, Weijun Wang wrote:
>>
>> I'm scanning a file and downloading links inside:
>>
>> lines.flapMap(x -> Stream.ofNullable(findURIFrom(x)))
>>.map(l -> download(c, l))
>>.forEach(f -> f.join());
>>
>> Comp
> On 13 Nov 2018, at 10:35 AM, Weijun Wang wrote:
>
> I'm scanning a file and downloading links inside:
>
> lines.flapMap(x -> Stream.ofNullable(findURIFrom(x)))
> .map(l -> download(c, l))
> .forEach(f -> f.join());
>
> CompletableFuture> download(HttpClient c, URI link) {
>retur
> On Nov 13, 2018, at 11:41 AM, Chris Yin wrote:
>
>>
>> On 13 Nov 2018, at 10:35 AM, Weijun Wang wrote:
>>
>> I'm scanning a file and downloading links inside:
>>
>> lines.flapMap(x -> Stream.ofNullable(findURIFrom(x)))
>>.map(l -> download(c, l))
>>.forEach(f -> f.join());
>>
>>
16 matches
Mail list logo
