Vladimir,
I think we should create some documentation for this socket option.
In JDK-8243099 you mention tests done with Apache Kafka so I assume that
somebody has already modified Kafka to use this feature and maybe it
would useful to document what was done and use that as a basis for
someth
Hi Vladimir,
The tests came back green :-)
You're good to go for JDK-8245569.
best regards,
-- daniel
On 21/05/2020 20:38, Daniel Fuchs wrote:
Hi Vladimir,
That looks good. Give me time to send that to our test system
and I'll report back.
best regards,
-- daniel
On 21/05/2020 18:07, Iva
Hi Vladimir,
That looks good. Give me time to send that to our test system
and I'll report back.
best regards,
-- daniel
On 21/05/2020 18:07, Ivanov, Vladimir A wrote:
Thanks Daniel,
the exception was updated. Could you please review:
Bug ID:https://bugs.openjdk.java.net/browse/JDK-8245569
We
21, 2020 8:59 AM
To: Daniel Fuchs ; Ivanov, Vladimir A
; Patrick Concannon
; Alan Bateman ; OpenJDK
Network Dev list
Subject: RE: RFR 15 8243099: SO_INCOMING_NAPI_ID support
Hi Daniel,
Vladimir just pointed our that I missed pushing the SO_INCOMING_NAPI_ID tests
(forgot to do hg add).
I will
Fuchs
Sent: Thursday, May 21, 2020 2:39 AM
To: Ivanov, Vladimir A ; Patrick Concannon
; Alan Bateman ; OpenJDK
Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
Hi Vladimir,
On 14/05/2020 22:50, Ivanov, Vladimir A wrote:
> Thanks a lot Daniel! I missed these double che
Hi Vladimir,
On 14/05/2020 22:50, Ivanov, Vladimir A wrote:
Thanks a lot Daniel! I missed these double checks.
Updated webrev may be reviewed as http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.14
I use only one condition for the 'if' in the 'startup' method while kernel shoul
,
Sandhya
Sent: Friday, May 15, 2020 10:07 AM
To: Alan Bateman ; OpenJDK Network Dev list
Subject: RE: RFR 15 8243099: SO_INCOMING_NAPI_ID support
The CSR has been reviewed by Joe Darcy and is now marked as Provisional with
the following comment:
https://bugs.openjdk.java.net/browse/JDK-8244858
, Vladimir A ; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 07/05/2020 19:51, Ivanov, Vladimir A wrote:
> In my case for 2 servers with RHEL8.1 the NapiId was non-zero for the
> DatagramSocket after the 'receive' call.
>
Thanks for ch
Thanks Vladimir!
The tests look good to me now.
best regards,
-- daniel
On 14/05/2020 22:50, Ivanov, Vladimir A wrote:
Thanks a lot Daniel! I missed these double checks.
Updated webrev may be reviewed ashttp://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.14
I use only one cond
s together.
Thanks, Vladimir
-Original Message-
From: Daniel Fuchs
Sent: Thursday, May 14, 2020 2:37 AM
To: Ivanov, Vladimir A ; Patrick Concannon
; Alan Bateman ; OpenJDK
Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
Hi Vladimir, Patrick,
The new tests loo
ay, May 12, 2020 3:14 PM
To: Alan Bateman ; Ivanov, Vladimir A
; OpenJDK Network Dev list
Subject: RE: RFR 15 8243099: SO_INCOMING_NAPI_ID support
I have created the following draft CSR:
https://bugs.openjdk.java.net/browse/JDK-8244858
Please review and let me know if I can move it to propo
Hi Vladimir, Patrick,
The new tests look very good. There's just a small issue I noticed.
It's present in all the new tests - here is an example on
AsynchronousSocketChannelNAPITest.java:
This code in @BeforeTest:
63 try (var s = AsynchronousSocketChannel.open()) {
64
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
Great, thanks Valdimir
Also, it might be worthwhile adding a check to ensure the NAPI ID remains
consistent across multiple send/receives read/writes, and to test similar
socket types e.g. AsynchronousSocketChannel
For example:
http
: Patrick Concannon
Sent: Monday, May 11, 2020 11:11 AM
To: Ivanov, Vladimir A ; Alan Bateman
; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
Hi Vladamir,
Just a few observations with your test, ExtOptionNAPITest: I don't think the
static class TestThre
, Vladimir A ; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 07/05/2020 19:51, Ivanov, Vladimir A wrote:
> In my case for 2 servers with RHEL8.1 the NapiId was non-zero for the
> DatagramSocket after the 'receive' call.
>
Thanks for ch
Thanks for the clarification Alan. I think, i missed some part of
discussion.
Vyom
On Tue, May 12, 2020 at 1:20 PM Alan Bateman
wrote:
> On 12/05/2020 08:34, Vyom Tiwari wrote:
>
> Hi Vladimir,
>
> Latest changes looks good to me, but i am not 100% sure if we need to
> distinguish between "read
On 12/05/2020 08:34, Vyom Tiwari wrote:
Hi Vladimir,
Latest changes looks good to me, but i am not 100% sure if we need to
distinguish between "read only socket option" and "socket option not
supported" as below
if (!incomingNapiIdOptSupported)
+ throw new UnsupportedOperationException("Atte
8243099/webrev.12
>
> Thanks, Vladimir
>
> -Original Message-
> From: Patrick Concannon
> Sent: Monday, May 11, 2020 11:11 AM
> To: Ivanov, Vladimir A ; Alan Bateman <
> alan.bate...@oracle.com>; OpenJDK Network Dev list <
> net-dev@openjdk.java.net>
; Alan Bateman
; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
Hi Vladamir,
Just a few observations with your test, ExtOptionNAPITest: I don't think the
static class TestThread is needed for what you're trying to check and I think
you can remove i
han/Vladimir/8243099/webrev.10/
If no other comments the CSR will be crated on the next week.
Thanks, Vladimir
-Original Message-
From: Alan Bateman
Sent: Friday, May 8, 2020 12:10 AM
To: Ivanov, Vladimir A ; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_I
; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 07/05/2020 19:51, Ivanov, Vladimir A wrote:
> In my case for 2 servers with RHEL8.1 the NapiId was non-zero for the
> DatagramSocket after the 'receive' call.
>
Thanks for checking. I trie
On 07/05/2020 19:51, Ivanov, Vladimir A wrote:
In my case for 2 servers with RHEL8.1 the NapiId was non-zero for the
DatagramSocket after the 'receive' call.
Thanks for checking. I tried the equivalent of RHEL7.6 and it
consistently returns 0 for UDP sockets so they may be kernel differences
Original Message-
From: Alan Bateman
Sent: Thursday, May 7, 2020 11:42 AM
To: Ivanov, Vladimir A ; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 07/05/2020 17:53, Ivanov, Vladimir A wrote:
> Thanks.
> The Javadoc was updated:
> http://cr.openj
On 07/05/2020 17:53, Ivanov, Vladimir A wrote:
Thanks.
The Javadoc was updated:
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.09/
Also test was updated. Now it have no client/server architecture but looks more
easy to maintain.
Do you have any update on UDP sockets? I haven'
, 2020 11:52 PM
To: Ivanov, Vladimir A ; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 06/05/2020 00:36, Ivanov, Vladimir A wrote:
> I was failed to get non-zero value for the ServerSocket and according to
> clarification from the network experts:
&g
11:52 PM
To: Ivanov, Vladimir A ; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 06/05/2020 00:36, Ivanov, Vladimir A wrote:
> I was failed to get non-zero value for the ServerSocket and according to
> clarification from the network experts:
> &quo
On 07/05/2020 03:39, Ivanov, Vladimir A wrote:
The socket option SO_INCOMING_NAPI_ID returns the integer value that is
associated with the hardware queue of the device the last packet is received
on. This is true for UDP Datagram sockets as well. In case the socket is
receiving the packets fro
today.
Thanks, Vladimir
-Original Message-
From: Daniel Fuchs
Sent: Wednesday, May 6, 2020 2:37 AM
To: Ivanov, Vladimir A ; Alan Bateman
; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
Hi Vladimir,
On 06/05/2020 00:36, Ivanov, Vladimir A wrote:
>
Hi Vladimir,
On 06/05/2020 00:36, Ivanov, Vladimir A wrote:
I was failed to get non-zero value for the ServerSocket and according to
clarification from the network experts:
" NAPI IDs is not marked on listening sockets. A listening socket can accept
multiple connections coming on different que
On 06/05/2020 00:36, Ivanov, Vladimir A wrote:
I was failed to get non-zero value for the ServerSocket and according to
clarification from the network experts:
" NAPI IDs is not marked on listening sockets. A listening socket can accept
multiple connections coming on different queues. So even i
nov, Vladimir A ; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 05/05/2020 19:04, Ivanov, Vladimir A wrote:
> Thanks for your review.
> yes, the SocketException looks better here than the IOE. The updated
> webrev available as
> http://cr.ope
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 05/05/2020 19:04, Ivanov, Vladimir A wrote:
> Thanks for your review.
> yes, the SocketException looks better here than the IOE. The updated
> webrev available as
> http://cr.openjdk.java.net/~sviswanathan/Vladimir/82430
On 05/05/2020 19:04, Ivanov, Vladimir A wrote:
Thanks for your review.
yes, the SocketException looks better here than the IOE. The updated webrev
available as
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.08/
Also 'positive' was added to Javadoc to describe napi id.
Thanks.
e easily extended to channels. The server/client testing
require special classes that increase the testing size and reduce
maintainability.
Thanks, Vladimir
-Original Message-
From: Alan Bateman
Sent: Tuesday, May 5, 2020 1:08 AM
To: Ivanov, Vladimir A ; OpenJDK Network Dev list
Subject
On 04/05/2020 22:21, Ivanov, Vladimir A wrote:
Thanks for your comments.
Updated version of the patch available as
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.07/
The exception part for the setOption method was updated
+} else if (option == SO_INCOMING_NAPI_
Ivanov, Vladimir A ; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 01/05/2020 19:44, Ivanov, Vladimir A wrote:
> Thanks for your comments.
> The patch with updated doc available as:
> http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev
lifetime it should be constant.
Thanks, Vladimir
-Original Message-
From: Chris Hegarty
Sent: Friday, May 1, 2020 6:19 AM
To: Ivanov, Vladimir A ; OpenJDK Network Dev list
Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
> On 30 Apr 2020, at 22:20, Ivanov, Vladimir A
&
On 01/05/2020 19:44, Ivanov, Vladimir A wrote:
Thanks for your comments.
The patch with updated doc available as:
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.06/
I think the javadoc is in good shape now but we do need to address
Chris's point that the exception thrown when
: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support
On 30/04/2020 22:20, Ivanov, Vladimir A wrote:
> One more update at
> http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.05/
> The @apiNote section was updated a little bit to concentrate on
> SO_INCOMING_NAPI_ID.
>
On 01/05/2020 14:19, Chris Hegarty wrote:
:
Has any consideration been given to restricting the set of allowable
integer values that may be set for this option - say, to none? Which
would then lead to an IllegalArgumentException if `setOption` is
invoked in an attempt to set this socket option -
> On 30 Apr 2020, at 22:20, Ivanov, Vladimir A
> wrote:
>
> One more update at
> http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.05/
> The @apiNote section was updated a little bit to concentrate on
> SO_INCOMING_NAPI_ID.
I have not seen much discussion relating to possible
On 30/04/2020 22:20, Ivanov, Vladimir A wrote:
One more update at
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.05/
The @apiNote section was updated a little bit to concentrate on
SO_INCOMING_NAPI_ID.
I think this is getting better but it switches from "receive queue" to
"d
One more update at
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.05/
The @apiNote section was updated a little bit to concentrate on
SO_INCOMING_NAPI_ID.
Thanks, Vladimir
-Original Message-
From: Ivanov, Vladimir A
Sent: Thursday, April 30, 2020 10:14 AM
To: Alan Ba
43 matches
Mail list logo
