On 01/05/2020 19:44, Ivanov, Vladimir A wrote:
Thanks for your comments.
The patch with updated doc available as:
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.06/
I think the javadoc is in good shape now but we do need to address
Chris's point that the exception thrown when attempting to set this
socket option shouldn't UOE (as the option will be in the set returned
by supportedOptions). I think this reduces the choice down to just
IOException. Not ideal but there are several examples where IOE is
thrown when a socket option can't be set. For the API docs this means
changing it to say that IOException is thrown. For the implementation is
means that IOE is thrown when incomingNapiIdSupported is true and UOE
when it is false. If we can get agreement on this in the next few days
then I think it should be create to submit the CSR.
-Alan
