Thanks Daniel, the exception was updated. Could you please review: Bug ID: https://bugs.openjdk.java.net/browse/JDK-8245569 Webrev: http://cr.openjdk.java.net/~sviswanathan/Vladimir/8245569/webrev.00/
Thanks, Vladimir -----Original Message----- From: Viswanathan, Sandhya <sandhya.viswanat...@intel.com> Sent: Thursday, May 21, 2020 8:59 AM To: Daniel Fuchs <daniel.fu...@oracle.com>; Ivanov, Vladimir A <vladimir.a.iva...@intel.com>; Patrick Concannon <patrick.concan...@oracle.com>; Alan Bateman <alan.bate...@oracle.com>; OpenJDK Network Dev list <net-dev@openjdk.java.net> Subject: RE: RFR 15 8243099: SO_INCOMING_NAPI_ID support Hi Daniel, Vladimir just pointed our that I missed pushing the SO_INCOMING_NAPI_ID tests (forgot to do hg add). I will create a separate JBS entry for tests. Vladimir could do this change as part of that. Best Regards, Sandhya -----Original Message----- From: net-dev <net-dev-boun...@openjdk.java.net> On Behalf Of Daniel Fuchs Sent: Thursday, May 21, 2020 2:39 AM To: Ivanov, Vladimir A <vladimir.a.iva...@intel.com>; Patrick Concannon <patrick.concan...@oracle.com>; Alan Bateman <alan.bate...@oracle.com>; OpenJDK Network Dev list <net-dev@openjdk.java.net> Subject: Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support Hi Vladimir, On 14/05/2020 22:50, Ivanov, Vladimir A wrote: > Thanks a lot Daniel! I missed these double checks. > Updated webrev may be reviewed as > http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.14 > I use only one condition for the 'if' in the 'startup' method while kernel > should support or not both types of sockets together. Still one small mistake I missed in my previous review - sorry about that. For the new tests under jdk/net/ExtendedSocketOption/ these are testng tests. They should be throwing `org.testng.SkipException` not `jtreg.SkippedException` in their @BeforeTest method, that is what the testng machinery expects. - import jtreg.SkippedException; + import org.testng.SkippedException; ... - throw new SkippedException("NAPI ID not supported on this system"); + throw new SkipException("NAPI ID not supported on this system"); best regards, -- daniel
