Hi Vladimir,
On 14/05/2020 22:50, Ivanov, Vladimir A wrote:
Thanks a lot Daniel! I missed these double checks.
Updated webrev may be reviewed as http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.14
I use only one condition for the 'if' in the 'startup' method while kernel should support or not both types of sockets together.
Still one small mistake I missed in my previous review - sorry
about that.
For the new tests under jdk/net/ExtendedSocketOption/ these are
testng tests. They should be throwing `org.testng.SkipException`
not `jtreg.SkippedException` in their @BeforeTest method, that
is what the testng machinery expects.
- import jtreg.SkippedException;
+ import org.testng.SkippedException;
...
- throw new SkippedException("NAPI ID not supported on this system");
+ throw new SkipException("NAPI ID not supported on this system");
best regards,
-- daniel
