Unfortunately, this train has already gone. However, we can always create a new
issue.
> On 14 Nov 2018, at 01:03, Ivan Gerasimov wrote:
>
> Also, in
>
> src/java.base/windows/classes/sun/net/dns/ResolverConfigurationImpl.java
>
> -// Addreses have changed
> +// Addresses have changed
Also, in
src/java.base/windows/classes/sun/net/dns/ResolverConfigurationImpl.java
-// Addreses have changed
+// Addresses have changed
Wasn't it meant to be singular? I.e. "Address has changed"
And the same thing on the line 84.
src/java.base/windows/native/libnet/net_util_md.c
+ *
Thanks Pavel, looks good!
*src/java.base/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java*
I wonder if 'I' needs to be capitalized, as it starts a sentence:
* Authenticator for a particular realm is single threaded.
- * ie. if multiple threads need to get credentials fr
On 12/11/2018 23:51, Pavel Rappo wrote:
Daniel, Alan,
I excluded the update from the draft to the RFC and created a separate bug
for it:
[P5] 8213757: Investigate the possibility of updating the reference to the
spec in java.net.Inet6Address
I added the changes to the URI class from JDK-
On 13/11/2018 11:13, Chris Hegarty wrote:
On 13 Nov 2018, at 02:45, Pavel Rappo wrote:
...
http://cr.openjdk.java.net/~prappo/8213490/webrev.02/
Looks fine.
I concur.
best regards,
-- daniel
-Chris.
> On 13 Nov 2018, at 02:45, Pavel Rappo wrote:
> ...
> http://cr.openjdk.java.net/~prappo/8213490/webrev.02/
Looks fine.
-Chris.
> On 13 Nov 2018, at 00:35, Ivan Gerasimov wrote:
>
> Do you want to change ie. -> i.e. here as well:
>
> src/java.base/windows/native/libnet/net_util_md.c
>
> - * 2. If the reqeusted port is 0 (ie. any port) then we try to bind in v4
> space
> + * 2. If the requested port is 0 (ie. any port
Hi Pavel!
All looks good to me!
Do you want to change ie. -> i.e. here as well:
src/java.base/windows/native/libnet/net_util_md.c
- * 2. If the reqeusted port is 0 (*ie*. any port) then we try to bind
in v4 space
+ * 2. If the requested port is 0 (*ie*. any port) then we try to bind
in v4
Daniel, Alan,
I excluded the update from the draft to the RFC and created a separate bug
for it:
[P5] 8213757: Investigate the possibility of updating the reference to the
spec in java.net.Inet6Address
I added the changes to the URI class from JDK-8213490, which then effectively
became a du
See also
https://bugs.openjdk.java.net/browse/JDK-8213218
https://bugs.openjdk.java.net/browse/JDK-8213220
On Mon, Nov 12, 2018 at 10:29 AM, Pavel Rappo
wrote:
> > On 12 Nov 2018, at 18:14, Alan Bateman wrote:
> >
> > It will need a CSR because it changes Inet6Address to specify that it
> can b
> On 12 Nov 2018, at 18:14, Alan Bateman wrote:
>
> It will need a CSR because it changes Inet6Address to specify that it can be
> extended with scoped addresses described by RFC 4007. It might need analysis
> to understand the differences between the draft and RFC 4007 (just in case it
> brin
On 12/11/2018 17:30, Daniel Fuchs wrote:
Hi Pavel,
The typos fixes look OK to me - I'll let Michael/Chris?
who have more knowledge on the history of the Inet6Address
impl to validate the new link - though I suspect that's OK.
It will need a CSR because it changes Inet6Address to specify that
Hi Pavel,
The typos fixes look OK to me - I'll let Michael/Chris?
who have more knowledge on the history of the Inet6Address
impl to validate the new link - though I suspect that's OK.
best regards,
-- daniel
On 12/11/2018 16:27, Pavel Rappo wrote:
Hello,
Please review the following change:
Hello,
Please review the following change:
http://cr.openjdk.java.net/~prappo/8213490/webrev.00
This change is all about typos in javadoc, variables' names and comments. Once
again, not only does this change addresses aesthetic issues, it also helps with
searches.
As always with this type of
14 matches
Mail list logo
