Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

2019-05-24 Thread Sean Mullan
On 5/24/19 4:56 PM, Sean Mullan wrote: On 5/23/19 8:14 PM, Arthur Eubanks wrote: Ping on a review from security-dev. On Fri, May 17, 2019 at 9:53 AM Chris Hegarty mailto:chris.hega...@oracle.com>> wrote:     Arthur,     On 17 May 2019, at 17:50, Arthur Eubanks mailto:aeuba...@google.com>>

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

2019-05-24 Thread Arthur Eubanks
On Fri, May 24, 2019 at 1:56 PM Sean Mullan wrote: > On 5/23/19 8:14 PM, Arthur Eubanks wrote: > > Ping on a review from security-dev. > > > > On Fri, May 17, 2019 at 9:53 AM Chris Hegarty > > wrote: > > > > Arthur, > > > >> On 17 May 2019, at 17:50, Arth

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

2019-05-24 Thread Sean Mullan
On 5/23/19 8:14 PM, Arthur Eubanks wrote: Ping on a review from security-dev. On Fri, May 17, 2019 at 9:53 AM Chris Hegarty > wrote: Arthur, On 17 May 2019, at 17:50, Arthur Eubanks mailto:aeuba...@google.com>> wrote: Looks good. Tri

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

2019-05-17 Thread Chris Hegarty
Arthur, > On 17 May 2019, at 17:50, Arthur Eubanks wrote: > > Looks good. > > Trivially, maybe amend the comment to be more explicit > >86 // SOCKS V4 ( requires IPv4 ) > > -Chris. > Done > http://cr.openjdk.java.net/~aeubanks/8224081/webrev.02/ >

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

2019-05-17 Thread Chris Hegarty
Arthur, On 17/05/2019 06:57, Arthur Eubanks wrote: On Thu, May 16, 2019 at 7:44 PM Vyom Tiwari > wrote: Hi Arthur, do we need "Integer.toString(4)" to convert int to string in SocksProxyVersion ? Thanks, Vyom Fixed. http://cr.openjdk.java.net/~

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

2019-05-17 Thread Vyom Tiwari
+1 On Fri, May 17, 2019 at 3:29 PM Daniel Fuchs wrote: > Hi Arthur, > > On 17/05/2019 00:16, Arthur Eubanks wrote: > > bug: https://bugs.openjdk.java.net/browse/JDK-8224081 > > webrev: > http://cr.openjdk.java.net/~aeubanks/8224081/webrev.00/index.html > > > > Tests that try to use SOCKS v4 will

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

2019-05-17 Thread Daniel Fuchs
Hi Arthur, On 17/05/2019 00:16, Arthur Eubanks wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8224081 webrev: http://cr.openjdk.java.net/~aeubanks/8224081/webrev.00/index.html Tests that try to use SOCKS v4 will fail in an IPv6 only environment since SOCKS v4 does not support IPv6. SOCKS

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

2019-05-16 Thread Vyom Tiwari
Hi Arthur, do we need "Integer.toString(4)" to convert int to string in SocksProxyVersion ? Thanks, Vyom On Fri, May 17, 2019 at 4:46 AM Arthur Eubanks wrote: > bug: https://bugs.openjdk.java.net/browse/JDK-8224081 > webrev: http://cr.openjdk.java.net/~aeubanks/8224081/webrev.00/index.html > > T