Arthur, On 17/05/2019 06:57, Arthur Eubanks wrote:
On Thu, May 16, 2019 at 7:44 PM Vyom Tiwari <vyomm...@gmail.com <mailto:vyomm...@gmail.com>> wrote:Hi Arthur, do we need "Integer.toString(4)" to convert int to string in SocksProxyVersion ? Thanks, Vyom Fixed. http://cr.openjdk.java.net/~aeubanks/8224081/webrev.01/index.html
Looks good. Trivially, maybe amend the comment to be more explicit 86 // SOCKS V4 ( requires IPv4 ) -Chris.
