Arthur, > On 17 May 2019, at 17:50, Arthur Eubanks <aeuba...@google.com> wrote: > > Looks good. > > Trivially, maybe amend the comment to be more explicit > > 86 // SOCKS V4 ( requires IPv4 ) > > -Chris. > Done > http://cr.openjdk.java.net/~aeubanks/8224081/webrev.02/ > <http://cr.openjdk.java.net/~aeubanks/8224081/webrev.02/> > > I will wait for another review from security-dev.
You have my Review ( conditional on a Reviewer for the test in the security area ). -Chris.