On 5/24/19 4:56 PM, Sean Mullan wrote:
On 5/23/19 8:14 PM, Arthur Eubanks wrote:
Ping on a review from security-dev.
On Fri, May 17, 2019 at 9:53 AM Chris Hegarty
<chris.hega...@oracle.com <mailto:chris.hega...@oracle.com>> wrote:
Arthur,
On 17 May 2019, at 17:50, Arthur Eubanks <aeuba...@google.com
<mailto:aeuba...@google.com>> wrote:
Looks good.
Trivially, maybe amend the comment to be more explicit
86 // SOCKS V4 ( requires IPv4 )
-Chris.
Done
http://cr.openjdk.java.net/~aeubanks/8224081/webrev.02/
I will wait for another review from security-dev.
You have my Review ( conditional on a Reviewer for the test in the
security area ).
It seems ok but given that this area is a bit unpredictable I would
recommend you be available/online to monitor CI results after you push
the fix in case something breaks.
I should add that I would recommend not pushing this until Tuesday
after the US Memorial Day weekend as many folks probably won't be online.
--Sean
