On Fri, 4 Dec 2020 09:59:11 GMT, Daniel Fuchs wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Throw UIOE when stream throws IOE
>
> Hi Yasumasa,
>
> Thanks for filing the issue and providing a fix.
>
> Befo
> `InputStream` from `BodyPublishers.ofInputStream()` is usually closed when
> the stream reaches EOF. However IOE handler returns without closing.
>
> I confirmed this problem in `BodyPublishers.ofInputStream()`, but I think
> `BodyPublishers.ofFile()`has same problem because it also use
> `St
> `InputStream` from `BodyPublishers.ofInputStream()` is usually closed when
> the stream reaches EOF. However IOE handler returns without closing.
>
> I confirmed this problem in `BodyPublishers.ofInputStream()`, but I think
> `BodyPublishers.ofFile()`has same problem because it also use
> `St
On Fri, 4 Dec 2020 19:44:33 GMT, Mahendra Chhipa
wrote:
> jaxp.library.SimpleHttpServer
> https://bugs.openjdk.java.net/browse/JDK-8212035
Changes requested by dfuchs (Reviewer).
test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java line 80:
> 78: creator.buildSignedMult
On Fri, 4 Dec 2020 20:32:02 GMT, Daniel Fuchs wrote:
>> jaxp.library.SimpleHttpServer
>> https://bugs.openjdk.java.net/browse/JDK-8212035
>
> test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java line 80:
>
>> 78: creator.buildSignedMultiReleaseJar();
>> 79:
>> 80:
jaxp.library.SimpleHttpServer
https://bugs.openjdk.java.net/browse/JDK-8212035
-
Commit messages:
- JDK-8212035 merge jdk.test.lib.util.SimpleHttpServer with
Changes: https://git.openjdk.java.net/jdk/pull/1632/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1632&range=0
The timeout tests extending AbstractConnectTimeout have been relaxed to accept a
ConnectException wrapping NoRouteToHostException.
These test have been observed failing intermittently with ConnectException
wrapping
java.nio.channels.UnresolvedAddressException instead - presumably a transient
netw
> Hi,
>
> Please find below a fix that fixes an issue in Http2TestServerConnection -
> where the
> connection will be closed by the test server if the test server receives a
> RESET from the client
> after the stream has been closed.
>
> This issue has made the ThrowingPushPromisesAsStringCust
On Fri, 4 Dec 2020 13:25:30 GMT, Michael McMahon wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in
>> GET_BODY"
>>
>> Ammended fix to t
On Sat, 21 Nov 2020 11:45:42 GMT, Kartik Ohri
wrote:
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
This pull request has now
On Fri, 4 Dec 2020 14:32:37 GMT, Yasumasa Suenaga wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/RequestPublishers.java
>> line 422:
>>
>>> 420: } catch (IOException ex) {
>>> 421: need2Read = false;
>>> 422: haveNext = false;
>>
>>
On Fri, 4 Dec 2020 14:32:41 GMT, Yasumasa Suenaga wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/RequestPublishers.java
>> line 426:
>>
>>> 424: is.close();
>>> 425: } catch (IOException ex2) {}
>>> 426: return -1;
>>
>> } ca
On Fri, 4 Dec 2020 09:53:00 GMT, Daniel Fuchs wrote:
>> `InputStream` from `BodyPublishers.ofInputStream()` is usually closed when
>> the stream reaches EOF. However IOE handler returns without closing.
>>
>> I confirmed this problem in `BodyPublishers.ofInputStream()`, but I think
>> `BodyPub
On Fri, 4 Dec 2020 11:22:34 GMT, Kartik Ohri
wrote:
> @pconcannon, If everything is in order, can you please approve the changes on
> Github. I'll then issue the integrate command. Thanks.
Hi @amCap1712, you will have to /integrate first, and then afterwards I will
sponsor
-
PR:
On Wed, 2 Dec 2020 17:21:08 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find below a fix that fixes an issue in Http2TestServerConnection -
>> where the
>> connection will be closed by the test server if the test server receives a
>> RESET from the client
>> after the stream has been closed.
On Fri, 4 Dec 2020 10:14:19 GMT, Daniel Fuchs wrote:
>> @dfuch, are you still good with this? Please submit your formal review here
>> :)
>
> Thanks for running the tests Andrei. I will sponsor.
Few tests failed with `make test-tier2`:
==
Test summary
===
On Wed, 2 Dec 2020 16:35:24 GMT, Daniel Fuchs wrote:
>> Kartik Ohri has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Align -> and remove trailing whitespace
>
> Marked as reviewed by dfuchs (Reviewer).
@pconcannon, If everything is in or
On Sat, 28 Nov 2020 19:42:01 GMT, Andrey Turbanov
wrote:
> Incorrect format string was found by IntelliJ IDEA inspection `Java |
> Probable bugs | Malformed format string`
This pull request has now been integrated.
Changeset: c6f93ec9
Author:Andrey Turbanov
Committer: Daniel Fuchs
URL:
On Fri, 4 Dec 2020 08:47:16 GMT, Aleksey Shipilev wrote:
>> Looks good to me.
>
> @dfuch, are you still good with this? Please submit your formal review here :)
Thanks for running the tests Andrei. I will sponsor.
-
PR: https://git.openjdk.java.net/jdk/pull/1495
On Fri, 4 Dec 2020 00:47:51 GMT, Yasumasa Suenaga wrote:
> `InputStream` from `BodyPublishers.ofInputStream()` is usually closed when
> the stream reaches EOF. However IOE handler returns without closing.
>
> I confirmed this problem in `BodyPublishers.ofInputStream()`, but I think
> `BodyPubl
On Fri, 4 Dec 2020 00:47:51 GMT, Yasumasa Suenaga wrote:
> `InputStream` from `BodyPublishers.ofInputStream()` is usually closed when
> the stream reaches EOF. However IOE handler returns without closing.
>
> I confirmed this problem in `BodyPublishers.ofInputStream()`, but I think
> `BodyPubl
On Fri, 4 Dec 2020 08:36:36 GMT, Aleksey Shipilev wrote:
>> Incorrect format string was found by IntelliJ IDEA inspection `Java |
>> Probable bugs | Malformed format string`
>
> Looks good to me.
@dfuch, are you still good with this? Please submit your formal review here :)
-
PR:
On Sat, 28 Nov 2020 19:42:01 GMT, Andrey Turbanov
wrote:
> Incorrect format string was found by IntelliJ IDEA inspection `Java |
> Probable bugs | Malformed format string`
Looks good to me.
-
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1495
23 matches
Mail list logo
