On Fri, 4 Dec 2020 13:25:30 GMT, Michael McMahon <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in
>> GET_BODY"
>>
>> Ammended fix to take into account reset frames received on either server
>> streams
>> or client streams.
>
> test/jdk/java/net/httpclient/http2/server/Http2TestServerConnection.java line
> 785:
>
>> 783: System.err.println("TestServer:
>> received ResetFrame on closed push stream: " + stream);
>> 784: System.err.println(frame);
>> 785: } else {
>
> For clarity, I'd suggest adding static methods for testing if a streamid is
> client or server.
> Otherwise, the change looks fine.
Thanks Michael. Done!
-------------
PR: https://git.openjdk.java.net/jdk/pull/1567
