Re: NeoMutt[2/4] - Bug Fixes

Am 08.03.2016 um 02:34 schrieb Derek Martin: > On Mon, Mar 07, 2016 at 04:30:29PM +, Richard Russon wrote: >> This "feature" is small collection of bug fixes. >> Some are from Karel Zak's Notmuch repository; the others are mine. > > Are the changes implemented in the patches documented anywher

Re: #3832: Cannot connect to IMAP4 mail server

Am 21.04.2016 um 19:29 schrieb Brendan Cully: > On Thursday, 21 April 2016 at 10:06, Kevin J. McCarthy wrote: >> On Thu, Apr 21, 2016 at 05:19:00PM +0100, Arnt Gulbrandsen wrote: >> >>> One workaround is to send the three commands separately, not at the same >>> time. I don't like that, it slows do

Re: OSX OpenSSL

Am 06.12.2016 um 20:35 schrieb Will Yardley: > On Sun, Dec 04, 2016 at 06:25:38PM -0800, Kevin J. McCarthy wrote: >> Please note that as part of the OpenSSL fixes, versions less than >> 0.9.6 are no longer supported. > I get a problem with OpenSSL 0.9.8zh on OSX 10.11.6. > > I created https://dev.m

Re: Starting on 1.8 release

Am 10.02.2017 um 03:07 schrieb Kevin J. McCarthy: > I will take a closer look tomorrow, but honestly I find the behavior with > the expired imap.google.com in your cert filed very strange. If I can't > figure anything out, I will revert the patch for the 1.8 release. I object to reverting the pat

[PATCH] also present SHA1 fp in interactive cert check (was: Starting on 1.8 release)

nssl without options shows SHA1). The attached patch should add the SHA1 fingerprint below the MD5 fingerprint in the menu. To be applied with "hg import" on top of 7c97a8af8718, on the default branch. exporting patch: # HG changeset patch # User Matthias Andree # Date 1486857933 -3600 #

Re: [PATCH] also present SHA1 fp in interactive cert check

Am 12.02.2017 um 01:09 schrieb Matthias Andree: > Am 09.02.2017 um 00:52 schrieb isdtor: >> [...] Comparing the updated certificate file with a pre-update copy, >> there was one certificate added, and openssl x509 confirms that this >> is the certificate mutt presented above

Re: [PATCH] filter expired certs from $certificate_file for OpenSSL verification

Am 12.02.2017 um 00:04 schrieb Kevin J. McCarthy: > On Thu, Feb 09, 2017 at 10:56:36PM +, isdtor wrote: >>> What I hear you saying is that *with* the expired imap.google.com >>> certificate, you are getting a prompt for an expired Google G2 cert >>> (the 2nd in the chain). But without the expi

PATCH: plug memory leaks in new code to filter expired certs from $certificate_file for OpenSSL verification

Am 12.02.2017 um 13:23 schrieb Matthias Andree: > All this certificate handling apparently introduces memory leaks. I > first tried to get a hold of them with clang's address sanitizer, which > seems somehow handicapped on Ubuntu 16.04, but valgrind seems useful > enough eve

Re: PATCH: plug memory leaks in new code to filter expired certs from $certificate_file for OpenSSL verification

u'll clobber the old value of 'cert' the moment PEM_read_X509 returns NULL, and then you've trashed the only pointer you hold to cert, leaking memory again. The attached patch, incremental to my earlier one, achieves this. exporting patch: # HG

Re: more findings in interactive cert check

Am 12.02.2017 um 17:49 schrieb Kevin J. McCarthy: > > Actually, since this loop, has no break inside, it doesn't make sense to > have the X509_free() after the loop. Let me see if I can make sure the > PEM_read_X509() frees the cert even on EOF, and if so we can just pull > the X509_free() complet

Re: PATCH: plug memory leaks in new code to filter expired certs from $certificate_file for OpenSSL verification

Am 12.02.2017 um 18:54 schrieb Kevin J. McCarthy: > On Sun, Feb 12, 2017 at 06:31:59PM +0100, Matthias Andree wrote: >> Am 12.02.2017 um 17:35 schrieb Kevin J. McCarthy: >>> - while ((cert = PEM_read_X509 (fp, NULL, NULL, NULL)) != NULL) >>> + while ((cert = PEM_read_

Re: mutt: Add 1.8.0 entries to the UPDATING file.

Am 19.02.2017 um 00:16 schrieb Brendan Cully: > changeset: 6941:e4a5d1913e42 > user: Kevin McCarthy > date: Sat Feb 18 15:15:01 2017 -0800 > link: http://dev.mutt.org/hg/mutt/rev/e4a5d1913e42 > > Add 1.8.0 entries to the UPDATING file. > > diffs (52 lines): > > diff -r 943b281abfbb

Re: mutt: Add 1.8.0 entries to the UPDATING file.

Am 19.02.2017 um 06:31 schrieb Kevin J. McCarthy: > Well, I thought the second sentence would peak interest, leading them to > look at the manual. > https://dev.mutt.org/doc/manual.html#display-munging provides the > details. ...and the manual is very clear IMO. Thanks for the pointer. Perhaps wort

Re: [Mutt] #3916: Mutt 1.8: TOFU approach bails out on first fail or reject, not offering higher links of the cert' chain

Note that I have edited https://dev.mutt.org/trac/ticket/3916#comment:47 quite a bit since I've filed it, so look at it online for more links, specifically, a discussion on the curl-library@ list about the X509_V_FLAG_PARTIAL_CHAIN which I find rather elucidating.

version 1.8.0 not selectable in bug tracker, please add (no message body text)

Re: pkg-config usage for sqlite3

On 12.08.19 18:15, Kevin J. McCarthy wrote: It looks like building a static binary doesn't work with the sqlite3 option, due to a couple extra dependencies needed in that case. One common, and increasingly prevalent, solution is to use pkg-config and the related autoconf macros (e.g. PKG_CHECK_M

Re: [PATCH] Change Message-ID generation to be more unique and leak less information

Am 18.04.20 um 19:47 schrieb Kevin J. McCarthy: > On Sat, Apr 18, 2020 at 08:41:47AM -0400, Remco Rijnders wrote: >> On Fri, Apr 17, 2020 at 07:14:02PM -0700, Kevin wrote: >>> I would also note that the current message id generation algorithm >>> is deterministic.  It's easy to understand how it ge

Re: [PATCH] Change Message-ID generation to be more unique and leak less information

Am 20.04.20 um 15:51 schrieb Kevin J. McCarthy: > On Mon, Apr 20, 2020 at 11:35:08AM +0200, Matthias Andree wrote: >>> If there were a *real* threat model, Derek and I would take this more >>> seriously.  But I'm not going to backtrack on the generator >>>

Re: mutt 1.14.1 released

Am 16.05.20 um 21:17 schrieb Kevin J. McCarthy: > Hello Mutt Users, > > I've just released version 1.14.1.  Instructions for downloading are > available at , or the tarball can > be directly downloaded from .  Please > take the time

current mutt on Cygwin fails to compile.

t for Cygwin to provide interfaces? Implement portability later? Thanks & best regards MA [1] http://dev.mutt.org/trac/changeset/3e850c6e43fd by Rocco to fix ticket #3033, Aug 2008 [2] http://www.cygwin.com/ml/cygwin-announce/2008-12/msg00023.html -- Matthias Andree

Re: MAPI support

davmail.sourceforge.net/>? I saw ravings [1] about that stuff (seems to be a proxy) on the Gnus (the Emacs Lisp Mail/News reader) mailing list, but haven't checked it. [1] http://thread.gmane.org/gmane.emacs.gnus.general/68504/focus=68540 -- Matthias Andree

[PATCH 2 of 2] GNU-make based VPATH builds work

# HG changeset patch # User Matthias Andree # Date 1246956592 -7200 # Branch HEAD # Node ID aea9cea3d77ce1135a4f04a687fa4ec0924d5a2b # Parent df6da65f67bcdf828409a5aea194d4fa60406b5a GNU-make based VPATH builds work. diff -r df6da65f67bc -r aea9cea3d77c INSTALL --- a/INSTALL Tue Jul 07 10:49

[PATCH 1 of 2] Remove generated file from repository

# HG changeset patch # User Matthias Andree # Date 1246956550 -7200 # Branch HEAD # Node ID df6da65f67bcdf828409a5aea194d4fa60406b5a # Parent ccab6c56b5576debd6e9e9207e2d5b1305763aa4 Remove generated file from repository. diff -r ccab6c56b557 -r df6da65f67bc mkinstalldirs --- a/mkinstalldirs

[PATCH 0 of 2] minor build and INSTALL fixes

Patch 1 removes a file from the repo that is installed by autoreconf as part of prepare. Patch 2 updates the VPATH information in INSTALL. I have been using VPATH (i. e. mkdir build ; cd build ; ../configure ...) for quite a while with the repository versions. No ill effects observed with a recent

[PATCH] Remove generated file from repository

# HG changeset patch # User Matthias Andree # Date 1246956550 -7200 # Branch HEAD # Node ID 2bb92f12f40ecd620574ea165966c941caca473f # Parent d5e03a46518c96ab3aa9f89114160be34631baf0 Remove generated file from repository. diff -r d5e03a46518c -r 2bb92f12f40e mkinstalldirs --- a/mkinstalldirs

Re: [PATCH 0 of 2] minor build and INSTALL fixes

Am 07.07.2009, 13:56 Uhr, schrieb Rocco Rutte : Hi, * Matthias Andree wrote: Patch 1 removes a file from the repo that is installed by autoreconf as part of prepare. Not for me. Neither on OS X nor on Debian squeeze. On OSX I have autoconf 2.63 and automake 1.10.2, and on Debian 2.63/1.9.6

Re: [PATCH 0 of 2] minor build and INSTALL fixes

Rocco Rutte schrieb: > Hi, > > * Matthias Andree wrote: >>> * Matthias Andree wrote: > >>>> Patch 1 removes a file from the repo that is installed by autoreconf >>>> as part of prepare. > >>> Not for me. Neither on OS X nor on Debian squ

Re: [PATCH] Remove generated file from repository

Matthias Andree schrieb: > # HG changeset patch > # User Matthias Andree > # Date 1246956550 -7200 > # Branch HEAD > # Node ID 2bb92f12f40ecd620574ea165966c941caca473f > # Parent d5e03a46518c96ab3aa9f89114160be34631baf0 > Remove generated file from repository. > &

Re: [PATCH 0 of 2] minor build and INSTALL fixes

Am 07.07.2009, 15:48 Uhr, schrieb Matthias Andree : Rocco Rutte schrieb: Hi, * Matthias Andree wrote: * Matthias Andree wrote: Patch 1 removes a file from the repo that is installed by autoreconf as part of prepare. Not for me. Neither on OS X nor on Debian squeeze. On OSX I have

Re: [PATCH 0 of 2] minor build and INSTALL fixes

Am 07.07.2009, 22:39 Uhr, schrieb Rocco Rutte : On Tue, Jul 07, 2009 at 10:33:19PM +0200, Matthias Andree wrote: Does any of the core maintainers NOT having GNU gettext 0.17 installed? Me. fink/unstable on OS X only has 0.14.5 as the latest. Ok. -- Matthias Andree

[PATCH] If --with-docdir isn't given, fall back to --docdir. Else warn

# HG changeset patch # User Matthias Andree # Date 1247006816 -7200 # Branch fixdocdir # Node ID 4d82291772f4e23fe2cee472eb8a383d9b27a203 # Parent d5e03a46518c96ab3aa9f89114160be34631baf0 If --with-docdir isn't given, fall back to --docdir. Else warn. Fixes #3282. diff -r d5e03a4651

[PATCH 0 of 2] mkinstalldir deprecation

Remove mkinstalldir (2nd version), replaces all users by install-sh -d.

[PATCH 1 of 2] Fix 'make distclean' complaint about po/mutt.pot

# HG changeset patch # User Matthias Andree # Date 1247000124 -7200 # Branch HEAD # Node ID 79480ef7658cc3bb64c1add23ef2b9a9e4c06ab8 # Parent d5e03a46518c96ab3aa9f89114160be34631baf0 Fix 'make distclean' complaint about po/mutt.pot. diff -r d5e03a46518c -r 79480ef7658c po/Makefile.i

[PATCH 2 of 2] Drop mkinstalldirs, use install-sh -d instead

# HG changeset patch # User Matthias Andree # Date 1247005293 -7200 # Branch HEAD # Node ID 0db1e3f4e875d07f0d663023f631f43d6b1cd1f9 # Parent 79480ef7658cc3bb64c1add23ef2b9a9e4c06ab8 Drop mkinstalldirs, use install-sh -d instead. This requires that we use autoconf 2.60 and automake 1.10 or

Re: [PATCH 2 of 2] Drop mkinstalldirs, use install-sh -d instead

Am 08.07.2009, 17:59 Uhr, schrieb Patrick Welche : On Tue, Jul 07, 2009 at 10:48:07PM -, Matthias Andree wrote: Drop mkinstalldirs, use install-sh -d instead. This requires that we use autoconf 2.60 and automake 1.10 or newer to avoid race conditions in older versions of mkinstalldirs and

[PATCH] If --with-docdir isn't given, fall back to --docdir. Else warn

# HG changeset patch # User Matthias Andree # Date 1247006816 -7200 # Branch HEAD # Node ID 6fb746b71758dfe7eda021a119d45b0d7e262f72 # Parent a3c4b605cfada5be4c9234cbdaa4424206b06fa5 If --with-docdir isn't given, fall back to --docdir. Else warn. Fixes #3282. diff -r a3c4b605cf

[PATCH] If --with-docdir isn't given, fall back to --docdir. Else warn

# HG changeset patch # User Matthias Andree # Date 1247006816 -7200 # Branch HEAD # Node ID 6fb746b71758dfe7eda021a119d45b0d7e262f72 # Parent a3c4b605cfada5be4c9234cbdaa4424206b06fa5 If --with-docdir isn't given, fall back to --docdir. Else warn. Fixes #3282. diff -r a3c4b605cf

Re: [PATCH] If --with-docdir isn't given, fall back to --docdir. Else

[sorry for the dupes, I mistyped Rocco's email address on the first attempt; this PATCH is against HEAD, rather than in my private branch] -- Matthias Andree

[PATCH 1 of 2] Use proper prototype for mutt_get_default_charset(), fix fallout

# HG changeset patch # User Matthias Andree # Date 1248385890 -7200 # Branch HEAD # Node ID 02a82e1ae8cbfaae70e10554198441c150ba1648 # Parent 713a18794bb777570935780758e6a3e963116e61 Use proper prototype for mutt_get_default_charset(), fix fallout. diff -r 713a18794bb7 -r 02a82e1ae8cb charset.h

[PATCH 2 of 2] Fix two warnings "the address of 'foo' will always evaluate as 'true'"

# HG changeset patch # User Matthias Andree # Date 1248385934 -7200 # Branch HEAD # Node ID fc00838d5734ea560ac013565226c000fe7e4df4 # Parent 02a82e1ae8cbfaae70e10554198441c150ba1648 Fix two warnings "the address of 'foo' will always evaluate as 'true'". diff -

[PATCH 0 of 2] Fix several compiler warnings.

These are minor cleanups to fix a few compiler warnings. Two will remain: - one about mktemp() (but I haven't investigated if the workaround is portable; mktemp is used as input for mkdir, so it's safe in spite of the warning) - another about a longish copyright string literal in main.c that

Re: [PATCH] If --with-docdir isn't given, fall back to --docdir. Else

Am 24.07.2009, 12:49 Uhr, schrieb Rocco Rutte : Hi, * Matthias Andree wrote: # HG changeset patch # User Matthias Andree # Date 1247006816 -7200 # Branch HEAD # Node ID 6fb746b71758dfe7eda021a119d45b0d7e262f72 # Parent a3c4b605cfada5be4c9234cbdaa4424206b06fa5 If --with-docdir isn't

Re: [PATCH] If --with-docdir isn't given, fall back to --docdir. Else

Am 24.07.2009, 14:14 Uhr, schrieb Rocco Rutte : Hi, * Matthias Andree wrote: You wouldn't be telling this to users, but to developers. Only those checking out from Mercurial will need to run autoconf. Hmm, right. For developers, we can bump AC_PREREQ([2.54]) to AC_PREREQ([2.60]) so

Re: [PATCH 1 of 2] Use proper prototype for

Am 23.07.2009, 23:55 Uhr, schrieb Matthias Andree : # HG changeset patch # User Matthias Andree # Date 1248385890 -7200 # Branch HEAD # Node ID 02a82e1ae8cbfaae70e10554198441c150ba1648 # Parent 713a18794bb777570935780758e6a3e963116e61 Use proper prototype for mutt_get_default_charset(), fix

[PATCH] Support --docdir, complain if that conflicts with --with-docdir

# HG changeset patch # User Matthias Andree # Date 1248733349 -7200 # Branch HEAD # Node ID 9949607b3f3d35121459cb34416ba3c1e54599bb # Parent 86e066a206ac9d0eb2df5ce67eed22fda4287846 Support --docdir, complain if that conflicts with --with-docdir. Fixes #3282. Note that this relies on the

Re: [PATCH] If --with-docdir isn't given, fall back to --docdir. Else

laint * accepts --docdir if that variable is set * gives an error if _both_ docdir and with-docdir are set. A somewhat close patch is following up as a new thread. I don't like it much, but it's the best I can do. -- Matthias Andree

Re: [PATCH] Support --docdir, complain if that conflicts with

Am 28.07.2009, 05:51 Uhr, schrieb Brendan Cully : On Monday, 27 July 2009 at 22:22, Matthias Andree wrote: # HG changeset patch # User Matthias Andree # Date 1248733349 -7200 # Branch HEAD # Node ID 9949607b3f3d35121459cb34416ba3c1e54599bb # Parent 86e066a206ac9d0eb2df5ce67eed22fda4287846

Re: [PATCH] Support --docdir, complain if that conflicts with

Am 29.07.2009, 08:48 Uhr, schrieb Rocco Rutte : Hi, * Brendan Cully wrote: [...] Just a note: doc/devel-notes.txt says we require 2.59. No it doesn't, it says "- autoconf (versions less than 2.59 are unsupported)" That's "you can use it as long as it works for you". -- Matthias Andree

Re: [PATCH] Support --docdir, complain if that conflicts with

when testing is particularly valuable, because for whatever reason their environment isn't completely up to date. Makes perfect sense. Thank you. -- Matthias Andree

Re: Corrupt time in From_

tt-1.5.20-7.2.x86_64 on openSUSE 11.3alpha |and on openSUSE 11.2 | Oh, I've seen it for months as well, but only reported it today. :-) Which only makes things harder to track... for developer versions, report regressions as soon as reasonably possible. -- Matthias Andree

Re: Prevent "Re: " prepending to subject when replying (patch

There is no situation where deviation from IETF standards would be acceptable. Local hacks aren't for public consumption. -- Matthias Andree

Re: Prevent "Re: " prepending to subject when replying (patch

. If the subject is empty, the msg *should* be trashed. An email client should segfault when attempting to send/post an email with an empty subject header. Some spam filters take care of that already }:-> -- Matthias Andree

[PATCH] Fix hcache build on systems with $(EXEEXT), include it in mutt_md5

# HG changeset patch # User Matthias Andree # Date 1263406353 -3600 # Branch HEAD # Node ID e2c60de29015c0b8e4978b9fa3f009884deae419 # Parent 31881f38ca1e2df8392d7cb7d9ed7e3e6e71d6bb Fix hcache build on systems with $(EXEEXT), include it in mutt_md5. diff -r 31881f38ca1e -r e2c60de29015

Re: [Mutt] #3410: Mutt crashes when two instances open the same mailbox

d be a bit more promising IMO. In need, try dmalloc or efence, or export MALLOC_CHECK_=2 on GNU libc systems - and be sure you can dump core. -- Matthias Andree

[PATCH 1 of 2] Update for new autoconf

# HG changeset patch # User Matthias Andree # Date 1250600058 -7200 # Branch HEAD # Node ID a979f8e21063d62e686af37d73976290d07816f0 # Parent bc5fb152e2baa218a5f5941dc52fee493c767219 Update for new autoconf. diff --git a/configure.ac b/configure.ac --- a/configure.ac +++ b/configure.ac @@ -3,9

[PATCH 2 of 2] Unbreak X.509 SubjAltName checks,

# HG changeset patch # User Matthias Andree # Date 1281081481 -7200 # Branch HEAD # Node ID b757803be9260e0152098ee2a2be856a416d085e # Parent a979f8e21063d62e686af37d73976290d07816f0 Unbreak X.509 SubjAltName checks, regression in 6016:dc09812e63a3 that calls strlen on an SSL sk rather than its

Re: [Mutt] #3426: certificate validation fails with openssl

break subject alternative name matching. Mutt, with Thomas Hoger's patch, mistakenly compares the strlen of the SSL structure (which is ill-defined and bogus) against the payload ->length. I've just sent a new hg patch to mutt-dev@ -- Matthias Andree

[PATCH 0 of 2] Assorted minor mutt configure and SSL/TLS fixes

In this series there are two patches: - one to update configure.ac to rid ourselves of some obsolete constructs - RECOMMENDED - one to fix a serious bug in SubjAltName X.509 (SSL/TLS) certificate matching broken since the embedded NUL-workaround in rev 6016. REQUIRED, fixes Ticket #3426. P

RFC: PATCH: fix size_t/int confusion in mutt_socket_readln_d

nd 64-bit size_t. How about the attached patch to prevent integer overflow? Or should this make the iterator an ssize_t and make sure it doesn't wrap? Best regards -- Matthias Andree patch-mutt_socket_readln_d.diff Description: Binary data

[PATCH] Drop declaration for unused argv/argc parameters

# HG changeset patch # User Matthias Andree # Date 1281122572 -7200 # Branch HEAD # Node ID 221f5024197fde2c43f5e83ecad562b2fb0796d2 # Parent 317338b0d4908fe45c9ef8c07ea3b5ef81f11bf8 Drop declaration for unused argv/argc parameters. Fixes GCC warning with -Wextra. diff --git a/md5.c b/md5.c

[PATCH 0 of 9] Series of minor warning fixes for -Wextra

I've picked out a few warnings and fixed them, often type confusion around size_t vs. int, size_t vs. long, or unsigned vs. int.

[PATCH 7 of 9] Fix comparison signedness warning

# HG changeset patch # User Matthias Andree # Date 1281124734 -7200 # Branch HEAD # Node ID 4bc65ed599ef817bb754e4edfeaadffda857e3f9 # Parent 73dd65f57f103c5f1fba175b4ee1ed8541ad5081 Fix comparison signedness warning. diff --git a/pop_lib.c b/pop_lib.c --- a/pop_lib.c +++ b/pop_lib.c @@ -498,7

[PATCH 6 of 9] Ignore backup files ending in a tilde character

# HG changeset patch # User Matthias Andree # Date 1281124626 -7200 # Branch HEAD # Node ID 73dd65f57f103c5f1fba175b4ee1ed8541ad5081 # Parent 55eac87c65e021bf663875e931f2868491251d07 Ignore backup files ending in a tilde character. diff --git a/.hgignore b/.hgignore --- a/.hgignore +++ b

[PATCH 8 of 9] Fix comparison signedness warning

# HG changeset patch # User Matthias Andree # Date 1281124790 -7200 # Branch HEAD # Node ID 55667d213995788784043ab889d8ac1995fd2b37 # Parent 4bc65ed599ef817bb754e4edfeaadffda857e3f9 Fix comparison signedness warning. diff --git a/gnupgparse.c b/gnupgparse.c --- a/gnupgparse.c +++ b

[PATCH 5 of 9] Fix comparison signedness warnings

# HG changeset patch # User Matthias Andree # Date 1281124462 -7200 # Branch HEAD # Node ID 55eac87c65e021bf663875e931f2868491251d07 # Parent 151598faceaeab3c37f1de4274fc8324a88f27f5 Fix comparison signedness warnings. diff --git a/pop_auth.c b/pop_auth.c --- a/pop_auth.c +++ b/pop_auth.c

[PATCH 3 of 9] Resolve if/else empty body ambiguity/warnings when compiling without DEBUG

# HG changeset patch # User Matthias Andree # Date 1281124356 -7200 # Branch HEAD # Node ID fa6b3ce69655b50e1e8146dce3d4b83f040052fc # Parent 38a8fa1d1b69727de8b8f4cba49b9cb949032691 Resolve if/else empty body ambiguity/warnings when compiling without DEBUG. diff --git a/lib.h b/lib.h --- a

[PATCH 9 of 9] Fix comparison signedness warnings

# HG changeset patch # User Matthias Andree # Date 1281124898 -7200 # Branch HEAD # Node ID 8bf3c2dac4545c2bfcdd411806c1f2b2442ac035 # Parent 55667d213995788784043ab889d8ac1995fd2b37 Fix comparison signedness warnings. diff --git a/url.c b/url.c --- a/url.c +++ b/url.c @@ -81,7 +81,7 @@ if

[PATCH 2 of 9] Fix comparison signedness warnings

# HG changeset patch # User Matthias Andree # Date 1281124305 -7200 # Branch HEAD # Node ID 38a8fa1d1b69727de8b8f4cba49b9cb949032691 # Parent caf6c2da0ec8a20b83bb951730ff53bfeffa0af2 Fix comparison signedness warnings. diff --git a/mutt_ssl.c b/mutt_ssl.c --- a/mutt_ssl.c +++ b/mutt_ssl.c

[PATCH 1 of 9] Fix signedness warning

# HG changeset patch # User Matthias Andree # Date 1281124286 -7200 # Branch HEAD # Node ID caf6c2da0ec8a20b83bb951730ff53bfeffa0af2 # Parent bf13863e682ebab57683147787bd074844322218 Fix signedness warning. diff --git a/status.c b/status.c --- a/status.c +++ b/status.c @@ -209,7 +209,7

[PATCH 4 of 9] Fix comparison signedness warnings

# HG changeset patch # User Matthias Andree # Date 1281124373 -7200 # Branch HEAD # Node ID 151598faceaeab3c37f1de4274fc8324a88f27f5 # Parent fa6b3ce69655b50e1e8146dce3d4b83f040052fc Fix comparison signedness warnings. diff --git a/buffy.c b/buffy.c --- a/buffy.c +++ b/buffy.c @@ -456,7 +456,7

Re: [PATCH 7 of 9] Fix comparison signedness warning

On Fri, Aug 06, 2010 at 11:49:24PM +0200, Vincent Lefevre wrote: On 2010-08-06 23:33:29 +0200, Matthias Andree wrote: -if (chunk >= sizeof (buf)) +if ((size_t)chunk >= sizeof (buf)) I would say that a signedness warning would be here a compiler bug since with a simple variable

Re: [PATCH 4 of 9] Fix comparison signedness warnings

Am 07.08.2010, 07:46 Uhr, schrieb Michael Elkins: Alternate version with addition check to make sure cast is safe. # HG changeset patch # User Matthias Andree # Date 1281124373 -7200 # Branch HEAD # Node ID f6590ddfaf4f1317b85345156a62397f1b530213 # Parent

Re: [PATCH 2 of 9] Fix comparison signedness warnings

Am 07.08.2010, 07:33 Uhr, schrieb Michael Elkins: Alternate version of this patch to ensure the cast is safe. Looks good to me. -- Matthias Andree

Check the copyright years in main.c :-)

...still mentioning "-2009" for Brendan Cully and Michael Elkins, among others. These may warrant updating :-) -- Matthias Andree

Re: [Mutt] #3518: IDNA2008 support by libidn2 usage in mutt

in once libidn2 is stable. -- Matthias Andree

Re: Compatibility with Outlook threading

Am 27.05.2011 23:01, schrieb Bob Bell: > > I can pull this off with some muttrc-hackery, though it's not exacly > clean. I'd be willing to refresh my knowledge of the mutt sources and > craft a patch to do this automatically (either 100% of the time based on > the presence of Thread-Index, or if

Re: [Mutt] #3528: version.sh not compatible with sort from coreutils 6.12

> legitimate bug. That's why I'm fixing it. :) But it's hard to break 20 > years of shell-script habit. Like underquoting variable expansions and using `...` backticks rather than $(...) for command expansion? I'd say breaking with old habits is hard but worthwhile. SCNR.

Re: Berkeley DB 5.3? (was: mutt: 9 new changesets)

Am 20.12.2012 09:00, schrieb Brendan Cully: > http://dev.mutt.org/hg/mutt/rev/fd2d94a0eb20 > changeset: 6245:fd2d94a0eb20 > branch: HEAD > user:Michael Elkins > date:Wed Dec 19 14:40:24 2012 -0800 > summary: detect newer BDB versions up to 5.2 How about 5.3? FreeBSD m

[PATCH] configure.ac cleanup + FreeBSD regression fixes (was: Berkeley DB 5.3?)

Am 20.12.2012 16:20, schrieb Michael Elkins: > On Thu, Dec 20, 2012 at 09:09:15AM +0100, Matthias Andree wrote: >> How about 5.3? FreeBSD may have the 5.3 version installed as the sole >> and only Berkeley DB version. >> >> <http://www.oracle.com/technetwork

Re: [PATCH] configure.ac cleanup + FreeBSD regression fixes

Am 20.12.2012 20:25, schrieb Michael Elkins: > On Thu, Dec 20, 2012 at 06:17:58PM +0100, Fabian Groffen wrote: >> On 20-12-2012 18:06:10 +0100, Matthias Andree wrote: >>> HOWEVER: I seem to recall that you will still get Solaris breakage by >>> defining the macros quo

[PATCH 2 of 2] Fix 'make distcheck': missing txt2c* and po/mutt.pot cleanup

Patch subject is complete summary. # HG changeset patch # User Matthias Andree # Date 1356046692 -3600 # Branch HEAD # Node ID 777ccb612fe69e04476319ee28b9f89e68af8568 # Parent eb278cf8a0ed80d4de5092f89afcd413af956572 Fix 'make distcheck': missing txt2c* and po/mutt.pot cleanup di

[PATCH 0 of 2] clean up automake quirks and fix make distcheck

Currently automake 1.12 on FreeBSD complains that the two/three-argument forms of AM_INIT_AUTOMAKE are going away; also, "make distcheck" fails to ship txt2c. The attached patches fix both of these problems. Please apply. Matthias

Re: [PATCH] configure.ac cleanup + FreeBSD regression fixes

Am 21.12.2012 00:08, schrieb Michael Elkins: > On Thu, Dec 20, 2012 at 06:06:10PM +0100, Matthias Andree wrote: >> Am 20.12.2012 16:20, schrieb Michael Elkins: >>> 1.1 --- a/configure.acThu Jul 22 20:06:33 2010 +0200 >>> 1.2 +++ b/configure.acWed

Re: [PATCH 0 of 2] clean up automake quirks and fix make distcheck

Am 21.12.2012 01:16, schrieb Michael Elkins: > On Fri, Dec 21, 2012 at 12:58:55AM +0100, Matthias Andree wrote: >> Currently automake 1.12 on FreeBSD complains that the two/three-argument >> forms of AM_INIT_AUTOMAKE are going away; also, "make distcheck" fails >> to

Re: [PATCH] configure.ac cleanup + FreeBSD regression fixes

Am 21.12.2012 01:56, schrieb Michael Elkins: > On Fri, Dec 21, 2012 at 01:42:34AM +0100, Matthias Andree wrote: >> It is not FreeBSD specific - Ubuntu Linux and openSUSE Linux permit >> multiple DB packages, and NetBSD does, too. > > Ubuntu 12.04 allows you to install mul

[PATCH 1 of 2] Fix immediate automake complaint and automake 1.13 incompatibility

Patch subject is complete summary. # HG changeset patch # User Matthias Andree # Date 1356045604 -3600 # Branch HEAD # Node ID eb278cf8a0ed80d4de5092f89afcd413af956572 # Parent f8774119c433822bc177e58e91fe8147c55de57d Fix immediate automake complaint and automake 1.13 incompatibility. diff

[PATCH] Fix immediate automake complaint and automake 1.13 incompatibility

Patch subject is complete summary. # HG changeset patch # User Matthias Andree # Date 1356045604 -3600 # Branch HEAD # Node ID 25dc5fbab4c0cc8e409547fdca02f59a59d11970 # Parent 0703095bf52d902198f3930a74fa55dbd67b9e17 Fix immediate automake complaint and automake 1.13 incompatibility. diff

Re: [PATCH 0 of 2] clean up automake quirks and fix make distcheck

Am 21.12.2012 06:04, schrieb Michael Elkins: > On Fri, Dec 21, 2012 at 01:51:38AM +0100, Matthias Andree wrote: >> There be dragons... they eat mail. Not sure if things are throttled, or >> lost, or delayed... we'll see. > > FYI, I did eventually receive it. Looks

[PATCH 1 of 3] Add more development tools to 'make dist'

Patch subject is complete summary. Makefile.am |2 +- mkinstalldirs | 112 +- 2 Dateien verändert, 2 Zeilen hinzugefügt(+), 112 Zeilen entfernt(-) # HG changeset patch # User Matthias Andree # Date 1356084306 -3600 # Branch HEAD

[PATCH 2 of 3] Fix VPATH build outside Mercurial repositories

Patch subject is complete summary. version.sh | 3 ++- 1 Dateien verändert, 2 Zeilen hinzugefügt(+), 1 Zeilen entfernt(-) # HG changeset patch # User Matthias Andree # Date 1356084433 -3600 # Branch HEAD # Node ID c460d4fd06e35879ffcfcce507562db5c750588a # Parent

[PATCH 3 of 3] Fix VPATH-based generation of non-hg-mq based patchlists

Note: Makefile.am runs patchlist.sh with $(srcdir)/PATCHES provided on stdin. patchlist.sh | 2 +- 1 Dateien verändert, 1 Zeilen hinzugefügt(+), 1 Zeilen entfernt(-) # HG changeset patch # User Matthias Andree # Date 1356085061 -3600 # Branch HEAD # Node ID

[PATCH 0 of 3] assorted VPATH and 'make dist[dir]' fixes

These are several fixes I found necessary when building from a "make distdir" generated directory. Makefile.am |2 +- mkinstalldirs | 112 +- version.sh|3 +- patchlist.sh |2 +- 4 Dateien verändert, 5 Zeilen hinzugefügt(

Re: [PATCH] configure.ac cleanup + FreeBSD regression fixes

Am 21.12.2012 06:01, schrieb Michael Elkins: > On Fri, Dec 21, 2012 at 02:18:46AM +0100, Matthias Andree wrote: >> Regarding the other patch, you seem to have merged most of it, but not >> the switch from AC_GNU_SOURCE to AC_USE_SYSTEM_EXTENSIONS. The former is >> obsolete and

Re: [PATCH 1 of 3] Add more development tools to 'make dist'

Am 21.12.2012 11:18, schrieb Matthias Andree: > Patch subject is complete summary. > > > Makefile.am |2 +- > mkinstalldirs | 112 > +- > 2 Dateien verändert, 2 Zeilen hinzugefügt(+), 112 Zeilen entfernt(-

Re: [Mutt] #3613: Commit #d07c9ee9a92b causes ./configure to fail on OSX 10.5.8.

Am 28.12.2012 16:00, schrieb Mutt: > #3613: Commit #d07c9ee9a92b causes ./configure to fail on OSX 10.5.8. > -+-- > Reporter: balderdash | Owner: me > Type: defect | Status: closed > Priority:

Re: policy on minimum requirements for building from mercurial vs dist

Am 29.12.2012 07:51, schrieb Michael Elkins: > Bugs http://dev.mutt.org/trac/ticket/3613 and > http://dev.mutt.org/trac/ticket/3614 bring up the question of what the > policy should be for minimum requirements of software required to build > from the mercurial repository. Note that this is differe

Re: [PATCH 4/4] version.sh: Get detailed version info from git

Am 15.12.2012 01:10, schrieb David Champion: > This is good to add support for, but note that the ${a#b} and ${a%b} > family of parameter expressions is nonportable. These are commonly > accepted bashisms that also work in zsh, but not in xpg4 shells. > > Can you redo with seds, or something? Co

Re: [PATCH 4/4] version.sh: Get detailed version info from git

Am 15.12.2012 15:27, schrieb David Champion: > * On 15 Dec 2012, Oswald Buddenhagen wrote: >> On Fri, Dec 14, 2012 at 06:10:21PM -0600, David Champion wrote: >>> [...] note that the ${a#b} and ${a%b} family of parameter expressions >>> is nonportable. These are commonly accepted bashisms [...] >>

Re: [PATCH 4/4] version.sh: Get detailed version info from git

Am 30.12.2012 15:55, schrieb Fabian Groffen: > On 30-12-2012 15:45:30 +0100, Matthias Andree wrote: >> This is bogofilter's configure.ac code, and for reference, check >> Solaris's standards(5) manual page. Actually, we should be tweaking PATH >> to read >> >

Re: [PATCH 4/4] version.sh: Get detailed version info from git

Am 30.12.2012 16:23, schrieb Fabian Groffen: > On 30-12-2012 16:18:27 +0100, Matthias Andree wrote: >> Am 30.12.2012 15:55, schrieb Fabian Groffen: >>> On 30-12-2012 15:45:30 +0100, Matthias Andree wrote: >>>> This is bogofilter's configure.ac code, and

  1   2   >