Re: Updating gettext autoconf macros to 0.21

2021-02-22 Thread Vincent Lefevre
On 2021-02-21 14:58:06 -0800, Kevin J. McCarthy wrote: > On Sat, Feb 20, 2021 at 03:16:17PM -0800, Kevin J. McCarthy wrote: > > I'll merge the branch into master tomorrow, but if anyone has the time > > please give it a test. > > I've merged the branch into master. As before, please let me know i

Re: Updating gettext autoconf macros to 0.21

2021-02-22 Thread Vincent Lefevre
On 2021-02-21 09:50:06 +0100, Rene Kita wrote: > On Sat, Feb 20, 2021 at 06:51:44PM +0100, Vincent Lefevre wrote: > > I don't understand how you can get the same gmo file since in > > ccc18061, the dependency on the OPS* file is gone. > Because I diffed the _output_ of the help text you get after p

Re: Updating gettext autoconf macros to 0.21

2021-02-21 Thread Kevin J. McCarthy
On Sat, Feb 20, 2021 at 03:16:17PM -0800, Kevin J. McCarthy wrote: I'll merge the branch into master tomorrow, but if anyone has the time please give it a test. I've merged the branch into master. As before, please let me know if you find any problems. Thank you. -- Kevin J. McCarthy GPG F

Re: Updating gettext autoconf macros to 0.21

2021-02-21 Thread Kevin J. McCarthy
On Sun, Feb 21, 2021 at 10:06:32AM +0100, Rene Kita wrote: On Sat, Feb 20, 2021 at 03:16:17PM -0800, Kevin J. McCarthy wrote: I've help menu fixes to branch 'kevin/gettext-bugs-v2' on gitlab. (NOTE: this is a different branch from before.) [...] I'll merge the branch into master tomorrow, but

Re: Updating gettext autoconf macros to 0.21

2021-02-21 Thread Rene Kita
On Sat, Feb 20, 2021 at 03:16:17PM -0800, Kevin J. McCarthy wrote: > I've help menu fixes to branch 'kevin/gettext-bugs-v2' on gitlab. (NOTE: > this is a different branch from before.) [...] > I'll merge the branch into master tomorrow, but if anyone has the time > please give it a test. After gett

Re: Updating gettext autoconf macros to 0.21

2021-02-21 Thread Rene Kita
On Sat, Feb 20, 2021 at 06:51:44PM +0100, Vincent Lefevre wrote: > On 2021-02-20 12:48:33 +0100, Rene Kita wrote: > > On Thu, Feb 18, 2021 at 11:28:02PM +0100, Vincent Lefevre wrote: > > > The messages in the help are no longer translated, e.g. previously: > > > > > > [...] > > > ^N next-

Re: Updating gettext autoconf macros to 0.21

2021-02-20 Thread Kevin J. McCarthy
I've help menu fixes to branch 'kevin/gettext-bugs-v2' on gitlab. (NOTE: this is a different branch from before.) This branch generates the help menu translation strings directly from the OPS files. I recommend performing a 'make maintainer-clean' and then running './prepare [your options]' t

Re: Updating gettext autoconf macros to 0.21

2021-02-20 Thread Kevin J. McCarthy
On Sat, Feb 20, 2021 at 06:51:44PM +0100, Vincent Lefevre wrote: I don't understand how you can get the same gmo file since in ccc18061, the dependency on the OPS* file is gone. As an update, I'm working on a fix to directly generate the translation strings from the OPS* files. I should have

Re: Updating gettext autoconf macros to 0.21

2021-02-20 Thread Vincent Lefevre
On 2021-02-20 12:48:33 +0100, Rene Kita wrote: > On Thu, Feb 18, 2021 at 11:28:02PM +0100, Vincent Lefevre wrote: > > The messages in the help are no longer translated, e.g. previously: > > > > [...] > > ^N next-threadaller à la discussion suivante > > ^P previous-thr

Re: Updating gettext autoconf macros to 0.21

2021-02-20 Thread Rene Kita
On Thu, Feb 18, 2021 at 11:28:02PM +0100, Vincent Lefevre wrote: > The messages in the help are no longer translated, e.g. previously: > > [...] > ^N next-threadaller à la discussion suivante > ^P previous-threadaller à la discussion précédente > [...] I canno

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Kevin J. McCarthy
On Fri, Feb 19, 2021 at 02:00:51AM +0100, Vincent Lefevre wrote: An important change is: diff --git a/po/POTFILES.in b/po/POTFILES.in index c7fdd935..62329627 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -44,6 +44,7 @@ imap/util.c init.c init.h keymap.c +keymap_alldefs.h lib.c listmenu.c

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Vincent Lefevre
On 2021-02-18 16:27:26 -0800, Kevin J. McCarthy wrote: > On Thu, Feb 18, 2021 at 03:54:17PM -0800, Kevin J. McCarthy wrote: > > I'm still working on the help screen issue. The dependency was a > > problem, and I believe I've worked around that. However, I'm still > > getting the missing translati

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Vincent Lefevre
On 2021-02-18 16:27:26 -0800, Kevin J. McCarthy wrote: > The problem went away when I force rebuilt everything, including > po/mutt.pot. I still need to investigate more what's going on, because I > think something it not right. > > I've pushed a branch to 'kevin/gettext-bugs' with two work-in-pr

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Kevin J. McCarthy
On Thu, Feb 18, 2021 at 03:54:17PM -0800, Kevin J. McCarthy wrote: I'm still working on the help screen issue. The dependency was a problem, and I believe I've worked around that. However, I'm still getting the missing translation problem. I will work on it more tonight and see what I can fi

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Vincent Lefevre
On 2021-02-19 00:38:11 +0100, Vincent Lefevre wrote: > I've reverted the change. With 0.21 as the version, this makes > autoreconf fail on Debian stable because gettext is too old. > But gettext 0.21 isn't really required. Lowering the version > e.g. to 0.19 makes autopoint fail with both gettext 0

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Kevin J. McCarthy
On Fri, Feb 19, 2021 at 12:38:11AM +0100, Vincent Lefevre wrote: On 2021-02-19 00:04:20 +0100, Vincent Lefevre wrote: I've just pushed a commit that does that (with 0.21 as the version): the warning has disappeared. I've reverted the change. With 0.21 as the version, this makes autoreconf fail

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Vincent Lefevre
On 2021-02-19 00:04:20 +0100, Vincent Lefevre wrote: > I've just pushed a commit that does that (with 0.21 as the version): > the warning has disappeared. I've reverted the change. With 0.21 as the version, this makes autoreconf fail on Debian stable because gettext is too old. But gettext 0.21 is

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Vincent Lefevre
On 2021-02-18 14:53:24 -0800, Kevin J. McCarthy wrote: > On Thu, Feb 18, 2021 at 11:28:02PM +0100, Vincent Lefevre wrote: > > A minor issue: autoreconf gives: > > > > autoreconf: configure.ac: AM_GNU_GETTEXT is used, but not > > AM_GNU_GETTEXT_VERSION > > I did see that, but I'm not sure what to

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Kevin J. McCarthy
On Thu, Feb 18, 2021 at 11:28:02PM +0100, Vincent Lefevre wrote: The messages in the help are no longer translated, e.g. previously: Ah. I missed that! Sorry I'll work on rebuilding that functionality. A minor issue: autoreconf gives: autoreconf: configure.ac: AM_GNU_GETTEXT is used, but n

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Vincent Lefevre
On 2021-02-18 23:28:02 +0100, Vincent Lefevre wrote: > The messages in the help are no longer translated, e.g. previously: > > [...] > ^N next-threadaller à la discussion suivante > ^P previous-threadaller à la discussion précédente > [...] > Aide pour index (

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Vincent Lefevre
Hi, On 2021-02-18 13:37:17 -0800, Kevin J. McCarthy wrote: > On Wed, Feb 17, 2021 at 04:00:19PM -0800, Kevin J. McCarthy wrote: > > I'm going to merge and push the branch up to master tomorrow. Please > > let me know if you see any problems (either before or after the merge). > > I've merged thi

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Kevin J. McCarthy
On Wed, Feb 17, 2021 at 04:00:19PM -0800, Kevin J. McCarthy wrote: I'm going to merge and push the branch up to master tomorrow. Please let me know if you see any problems (either before or after the merge). I've merged this into master. Thank you Dave and Rene for helping test it out. Aga

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread Rene Kita
On Sun, Feb 14, 2021 at 06:57:29PM +0100, Rene Kita wrote: > On Sun, Feb 14, 2021 at 09:47:40AM -0800, Kevin J. McCarthy wrote: > > On Sun, Feb 14, 2021 at 05:34:23PM +0100, Rene Kita wrote: > > > Does is make sense to test this with locale "en_US.UTF-8"? > > > > It helps to build with any locale,

Re: Updating gettext autoconf macros to 0.21

2021-02-18 Thread David J. Weller-Fahy
* Kevin J. McCarthy [2021-02-12 12:48 -0500]: On Thu, Feb 11, 2021 at 07:27:00PM -0500, David J. Weller-Fahy wrote: I've successfully configured/made the branch, and will run it for a few days to see if I get anything wonky. :) Thank you Dave. No issues here so far - I've been running it si

Re: Updating gettext autoconf macros to 0.21

2021-02-17 Thread Kevin J. McCarthy
On Thu, Feb 11, 2021 at 03:10:57PM -0800, Kevin J. McCarthy wrote: TL;DR: I've had on my todo list for a while to dig into the gettext autoconf stuff and see if I could upgrade it. I've pushed the result to branch 'kevin/gettext-update' on gitlab (or sr.ht). If you have a chance, please give

Re: Updating gettext autoconf macros to 0.21

2021-02-14 Thread Kevin J. McCarthy
On Sun, Feb 14, 2021 at 06:57:29PM +0100, Rene Kita wrote: Including this commit I still got one untracked file 'po/remove-potcdate.sed', but no changed tracked files. Thanks! I noticed that too, but unfortunately after I sent the email. I've added it to the gitignore file in another commit.

Re: Updating gettext autoconf macros to 0.21

2021-02-14 Thread Rene Kita
On Sun, Feb 14, 2021 at 09:47:40AM -0800, Kevin J. McCarthy wrote: > On Sun, Feb 14, 2021 at 05:34:23PM +0100, Rene Kita wrote: > > Does is make sense to test this with locale "en_US.UTF-8"? > > It helps to build with any locale, and at least make sure it runs. Testing > with another locale is of

Re: Updating gettext autoconf macros to 0.21

2021-02-14 Thread Kevin J. McCarthy
On Sun, Feb 14, 2021 at 05:34:23PM +0100, Rene Kita wrote: Does is make sense to test this with locale "en_US.UTF-8"? It helps to build with any locale, and at least make sure it runs. Testing with another locale is of course also helpful. I quickly tried another one, but since I don't regul

Re: Updating gettext autoconf macros to 0.21

2021-02-14 Thread Rene Kita
On Thu, Feb 11, 2021 at 03:10:57PM -0800, Kevin J. McCarthy wrote: > Hi Everyone, Hi Kevin! > TL;DR: > I've had on my todo list for a while to dig into the gettext autoconf stuff > and see if I could upgrade it. I've pushed the result to branch > 'kevin/gettext-update' on gitlab (or sr.ht). If y

Re: Updating gettext autoconf macros to 0.21

2021-02-12 Thread Kevin J. McCarthy
On Thu, Feb 11, 2021 at 07:27:00PM -0500, David J. Weller-Fahy wrote: I've successfully configured/made the branch, and will run it for a few days to see if I get anything wonky. :) Thank you Dave. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA signa

Re: Updating gettext autoconf macros to 0.21

2021-02-11 Thread David J. Weller-Fahy
* Kevin J. McCarthy [2021-02-11 18:11 -0500]: Hi Everyone, TL;DR: I've had on my todo list for a while to dig into the gettext autoconf stuff and see if I could upgrade it. I've pushed the result to branch 'kevin/gettext-update' on gitlab (or sr.ht). If you have a chance, please give the b

Updating gettext autoconf macros to 0.21

2021-02-11 Thread Kevin J. McCarthy
Hi Everyone, TL;DR: I've had on my todo list for a while to dig into the gettext autoconf stuff and see if I could upgrade it. I've pushed the result to branch 'kevin/gettext-update' on gitlab (or sr.ht). If you have a chance, please give the branch a test. Details: The update is the resul