On Mon, Jan 18, 2021 at 04:05:14PM -0800, Kevin wrote in
:
This is an ncurses question, but if I'm lucky Thomas Dickey might see
it here. :-)
Anyway, I'm wondering if 'keypad (stdscr, TRUE);' is technically
required to be called again after an (temporary) endwin()?
Mutt does this is a couple
Hi Eric,
On Sat, Jan 09, 2021 at 10:54:28PM +, Eric wrote in
<20210109225428.GA27462@dcvr>:
So I'm looking at 9da4e6e11e7037668d0ca7e8f5d6773d26e379ac
(I noticed this in mutt 2.0.2 on FreeBSD)
Encoding mmddHHMMSS into the Message-ID doesn't hurt users
privacy in cases where mutt is gen
On 10-11-2020 22:10, Paul Keusemann wrote:
Hello,
I just downloaded mutt-2.0.0 and attempted to build it on Solaris 10
(SPARC and i86) and ran into the following problem:
mutt_random.c:32: error: syntax error before 'z'
mutt_random.c:32: warning: type defaults to 'int' in declaration of 'z
points,
does it? You made your point, time to move on.
Sincerely,
Remco
On Tue, Jul 28, 2020 at 01:12:24PM -0700, Kevin wrote in
<20200728201224.ga148...@afu.lan>:
Just a heads-up that I'm going to take a few weeks off from Mutt
development. It's been consuming a large amount of my time, and I
need some counterbalance to regain my perspective and get my
motivation
On Thu, Jul 23, 2020 at 09:44:18AM -0700, Kevin wrote in
<20200723164418.gb235...@afu.lan>:
On Thu, Jul 23, 2020 at 07:15:11PM +0300, Maxim Tarasov wrote:
This affects prefilled subject of a reply to an email with an empty
subject.
---
-env->subject = safe_strdup ("Re: your mail");
+env
On Fri, May 29, 2020 at 01:38:48PM -0700, Kevin wrote in
<20200529203848.gd2...@afu.lan>:
This also removes the check for RAND_egd, which we still want.
Thank you for your patience Kevin, I know I am trying it!
Remco
From 07b1d1af4b431b26d32addd9a8ee2597cb7190a4 Mon Sep 17 00:00:00 200
On Mon, May 25, 2020 at 09:28:30AM -0700, Kevin wrote in
<20200525162830.gd1...@afu.lan>:
Remco, sorry I missed a few of those issues. In general you'll want
to follow the pattern of other files:
...
Got it (I hope)!
I have made the necessary changes in message
<2020052919
nt main (int argc, char **argv, char **environ)
mutt_error = mutt_nocurses_error;
mutt_message = mutt_nocurses_error;
- SRAND (time (NULL));
umask (077);
memset (Options, 0, sizeof (Options));
diff --git a/mutt_random.c b/mutt_random.c
new file mode 100644
index ..3b0ea98d
The current code provides a workaround for the absence of RAND_status in
OpenSSL versions before 0.9.5. The comments in the code indicate these
versions have to be supported, but as these versions are now more than
20 years old, this no longer applies. Removing this support simplifies the
code and
rocess, unless the system has ASLR enabled (i have no idea what
percentage of systems enable user space ASLR).
Thanks Oswald,
I was not aware of this and thought this would be unique between
instances. Another day, another lesson learned!
Remco
/* offset where the actual data begins
*/
| ^~
I haven't quite figured out yet how to address this.
Regards,
Remco
rcing
it and being able to find the seeds used or the current internal state
of the algorithm.
Kind regards,
Remco
On Sun, May 24, 2020 at 06:49:03PM -0700, Kevin wrote in
<20200525014903.ga1...@afu.lan>:
On Sun, May 24, 2020 at 04:59:24PM -0400, Remco Rijnders wrote:
By implementing the LFSR113 function by Pierre L'Ecuyer mutt gets a fast
and high quality PRNG that, given the same seeds, results
Makefile.am | 3 ++-
configure.ac | 1 -
Please note that I am not comfortable enough with autotools to be
certain if I did this the correct way (configure.ac) and also my
change to the Makefile might be sub optimal, I am not sure.
Cheers,
Remco
A Message-ID should be globally unique. Currently mutt generates this ID
based on the current date and time, followed by ".G", followed by a letter
A to Z (A for the 1st and 27th email sent, Z for the 26th, etc.), followed
by the pid of the active mutt process, followed by "@" and the configured
fq
A Message-ID should be globally unique. Currently mutt generates this ID
based on the current date and time, followed by ".G", followed by a letter
A to Z (A for the 1st and 27th email sent, Z for the 26th, etc.), followed
by the pid of the active mutt process, followed by "@" and the configured
fq
A Message-ID should be globally unique. Currently mutt generates this ID
based on the current date and time, followed by ".G", followed by a letter
A to Z (A for the 1st and 27th email sent, Z for the 26th, etc.), followed
by the pid of the active mutt process, followed by "@" and the configured
fq
echnical)
concerns about the proposed patches, I'd be more than happy to receive
those.
Stay healthy all,
Remco
---
sendlib.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sendlib.c b/sendlib.c
index f5389d8b..77c14e8f 100644
--- a/sendlib.c
+++ b/sendlib.c
@@ -516,13 +516,8 @@ int mutt_write_mime_body (BODY *a, FILE *f)
void mutt_generate_boundary (PARAMETER **parm)
{
char
The current code provides a workaround for the absence of RAND_status in
OpenSSL versions before 0.9.5. The comments in the code indicate these
versions have to be supported, but as these versions are now more than
20 years old, this no longer applies. Removing this support simplifies the
code and
s_error;
mutt_message = mutt_nocurses_error;
- SRAND (time (NULL));
umask (077);
memset (Options, 0, sizeof (Options));
diff --git a/mutt_random.c b/mutt_random.c
new file mode 100644
index ..ab0e6a84
--- /dev/null
+++ b/mutt_random.c
@@ -0,0 +1,64 @@
+/*
+ * Copyright (C) 2020 Remco Rijnd
From: Remco Rijnders
---
init.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/init.h b/init.h
index dc4832b6..6fd1ddc6 100644
--- a/init.h
+++ b/init.h
@@ -3396,7 +3396,7 @@ struct option_t MuttVars[] = {
{ "sidebar_sort_method", DT_SORT|DT_SORT_SIDEBAR,
th possible security implications. If
not already done so, the original reporter might want to open a report
for this with the opensmtpd team.
Regards,
Remco
On Fri, May 08, 2020 at 06:42:57AM +0200, Claus wrote in
<20200508044257.ga20...@kiel.esmtp.org>:
On Thu, May 07, 2020, Remco Rijnders wrote:
- dprint (1, (debugfile, "WEED is %s\n", (flags & CH_WEED) ? "Set" : "Not"));
+ dprint (1, (debugfile,
---
recvcmd.c | 4
1 file changed, 4 deletions(-)
diff --git a/recvcmd.c b/recvcmd.c
index e6fd0e67..d7e18319 100644
--- a/recvcmd.c
+++ b/recvcmd.c
@@ -648,7 +648,6 @@ static void attach_forward_msgs (FILE * fp, HEADER * hdr,
if (cur)
{
- /* mutt_message_hook (cur->hdr, MUT
---
copy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/copy.c b/copy.c
index 5e84b717..b6c9d781 100644
--- a/copy.c
+++ b/copy.c
@@ -141,7 +141,7 @@ mutt_copy_hdr (FILE *in, FILE *out, LOFF_T off_start,
LOFF_T off_end, int flags,
}
}
- dprint (1, (debugfile, "WE
On Mon, Apr 20, 2020 at 11:18:55AM +0200, Oswald wrote in
<20200420091855.GA283365@ugly>:
+ r = rand_uint64();
+
+ rbuf[0] = r & 0xFF;
+ rbuf[1] = (r >> 8) & 0xFF;
+ rbuf[2] = (r >> 16) & 0xFF;
+ rbuf[3] = (r >> 24) & 0xFF;
+ rbuf[4] = (r >> 32) & 0xFF;
+ rbuf[5] = (r >> 40) & 0xF
On Mon, Apr 20, 2020 at 04:52:13PM +0200, Vincent wrote in
<20200420145213.gb726...@zira.vinc17.org>:
Since you're interested only in a 64-bit unsigned number, this
should be:
r = r * ((uint64_t) RAND_MAX + (uint64_t) 1) + (uint64_t) random();
Thanks, I will incorporate this in the patch!
x27;t feel too strong about either way.
Kind regards,
Remco
g generated by someone sending
an email.
Kind regards,
Remco
On Mon, Apr 20, 2020 at 01:14:40PM -0700, Kevin wrote in
<20200420201440.gg17...@afu.lan>:
On Mon, Apr 20, 2020 at 08:20:08PM +0100, Steve Karmeinsky wrote:
I’d agree with that sentiment
Thank you ilf and Steve.
But the phrase "standing on the shoulders of giants" is very true in
this case.
On Thu, Apr 23, 2020 at 12:58:04AM +0200, Vincent wrote in
<2020045804.ga1081...@zira.vinc17.org>:
> BTW: I use --enable-exact-address as otherwise mutt shows addresses
> in a "nice" format that doesn't match reality and caused me grief
> several times when I copied those addresses into a fil
/amend the patch as desired. If you would like
me to make any further changes to it, I'm also happy to do this.
Warm regards,
Remco
A Message-ID should be globally unique. Currently mutt generates this ID
based on the current date and time, followed by ".G", followed by a letter
On Sun, Apr 19, 2020 at 02:20:33PM -0700, Kevin wrote in
<20200419212033.gk29...@afu.lan>:
On Sun, Apr 19, 2020 at 04:28:02PM -0400, Remco Rijnders wrote:
When converting binary values to Base 64 encoding, we go from a 8 bit
representation to a 6 bit representation. As a result, we need
I ran into this while trying to figure out why a very short binary value I
was trying to Base 64 encode came back short. With this change, the code
runs as expected for me. Nonetheless, I would appreciate it if someone can
check if there is no error in my reasoning when I changed this value.
When converting binary values to Base 64 encoding, we go from a 8 bit
representation to a 6 bit representation. As a result, we need extra space
to store the result compared to the input value being converted.
In the current implementation, the requirements on the size of the output
buffer are too
On Sat, Apr 18, 2020 at 06:54:36PM -0700, Kevin wrote in
<20200419015436.gi29...@afu.lan>:
On Sat, Apr 18, 2020 at 08:00:24PM -0400, Remco Rijnders wrote:
These might all seem far fetched, but the point is, information is
being disclosed that is of no value to be included in the Mess
tions being made on their email behaviour?
And when they are confronted with a more observant, skilled, and obsessed
person than me?
This is not about people doing shady things. It is about people divulging
information about themselves (unknowingly) that they'd rather not divulge
given the choice.
Cheers,
Remco
o think this
is something that I feel could (should?) be addressed; Not as an item of
the highest priority, but something to at least keep in mind. I do like
the suggestion to use or include a hashed value instead of the pid and the
GA counter.
Cheers,
Remco
egards,
Remco
---
INSTALL | 5 +
1 file changed, 5 insertions(+)
diff --git a/INSTALL b/INSTALL
index dc410d54..fc41ac40 100644
--- a/INSTALL
+++ b/INSTALL
@@ -92,6 +92,11 @@ to ``configure'' to help it out, or change the default
behavior:
--enable-imap
enable IMAP support
+--enable-sidebar
+
rmation being
leaked even when these concerns might be considered tiny or pointless by
you/Derek/some/most. The random() function is already seeded in s_init.c
anyways.
Kind regards,
Remco Rijnders (*over and out*)
On Fri, Apr 17, 2020 at 07:59:01PM -0500, Derek wrote in
<20200418005901.gb19...@bladeshadow.org>:
This is utterly pointless. This may come off as harsh but please
understand that's not intended. I just want to be completely clear
hee so there is no misunderstanding or equivocation.
Well, poi
The Message-ID that mutt generates is supposed to be unique. Up till now
mutt would generate this ID based on the current date and time, followed by
".G". followed by a letter A to Z (A for the 1st and 27th email sent, Z for
the 26th, etc.), followed by the pid of the active mutt process, followed
Hi,
All pages on trac I try to visit (http://dev.mutt.org/trac/) are returned
an error message:
=-=-=
Error
TracError: The Trac Environment needs to be upgraded.
Run "trac-admin /home/mutt/trac upgrade"
=-=-=
Anyone around who can do just that?
pgpxDR347sAR1.pgp
Description: PGP signature
eems silly that almost every
distribution ships the development version as the stable version, while
the official stable version is so outdated that hardly anyone uses it
anymore.
Best,
Remco
pgp7utj1oDH65.pgp
Description: PGP signature
eral IP in their
> editor, mutt will say "No recipients are specified!" when trying to send.
>
> Remco Rijnders informed me that it should be
> "anyth...@[ipv6:2001:470::::1]", but even then it has the same
> error (it malforms when mutt puts it
On Sat, Sep 11, 2010 at 04:01:27PM +0200, Remco Rijnders wrote:
> I'm hoping to use an S/MIME certificate issued by StartSSL to sign and
> encrypt my mail. When trying to add the certificate I get the following
> error:
>
> re...@silvertown:~$ smime_keys add_p12 startssl.cert
d
> patch to clean up that function. The 'cert_num' variable was
> supposed to be the count of the number of certs, but it counts
> lines, where the loop only bumps the counter when the line matches a
> valid format.
>
> I would appreciate it if you can double check the change.
Hi Michael,
mutt no longer crashes with your patch. Thanks!
Remco
.
I realise the fix is a trivial one, but hopefully it'll still be of some
use to you.
Sincerely,
Remco
# HG changeset patch
# User Remco Rijnders
# Date 1284268564 -7200
# Branch HEAD
# Node ID 10069d5277ad29b73764cebc3bbe53eea55286c8
# Parent 0f962f1a6bbba4684f8ca0d29916b54be852421b
51 matches
Mail list logo
