On Wed, Nov 18, 2015 at 3:47 PM, Matt Turner wrote:
>
> On Wed, Nov 18, 2015 at 3:01 PM, Nanley Chery
wrote:
> > From: Nanley Chery
> >
> > Make it easier to determine where to add new extensions.
> > Performed with the vim sort command.
>
> Well, I think
From: Nanley Chery
Enable developers to know if the table's alphabetical sorting
is maintained or lost.
v2: Move "*" next to pointer name (Matt)
Include extensions_table.h instead of extensions.h (Ian)
Remove extra " *" in comment (Ian)
Signed-off-by: Na
On Thu, Nov 19, 2015 at 12:13 PM, Brian Paul wrote:
> Hi Nanley,
>
>
Hi Brian,
> Maybe you can fix an issue I have with the new extension code.
>
> Previously, I could do something like export
> MESA_EXTENSION_OVERRIDE="-ARB_clear_buffer_object" and I would no longer
> see it in the GL_EXTENSIO
On Fri, Nov 20, 2015 at 8:49 AM, Brian Paul wrote:
> On Thu, Nov 19, 2015 at 7:04 PM, Ian Romanick wrote:
>
>> On 11/19/2015 05:40 PM, Nanley Chery wrote:
>> >
>> > On Thu, Nov 19, 2015 at 12:13 PM, Brian Paul > > <mailto:bri...@vmware.com>> wrot
On Fri, Nov 20, 2015 at 3:38 PM, Chad Versace
wrote:
> On Fri 20 Nov 2015, Nanley Chery wrote:
> > On Fri, Nov 20, 2015 at 8:49 AM, Brian Paul
> wrote:
> >
> > > On Thu, Nov 19, 2015 at 7:04 PM, Ian Romanick
> wrote:
>
> > >> I think #2 might be
From: Nanley Chery
Provide the ability to prevent any permanently enabled extension
from appearing in the string returned by glGetString[i]().
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions.c | 64 +-
1 file changed, 24 insertions(+), 40
On Fri, Nov 20, 2015 at 3:38 PM, Chad Versace
wrote:
> On Fri 20 Nov 2015, Nanley Chery wrote:
> > On Fri, Nov 20, 2015 at 8:49 AM, Brian Paul
> wrote:
> >
> > > On Thu, Nov 19, 2015 at 7:04 PM, Ian Romanick
> wrote:
>
> > >> I think #2 might be
On Fri, Nov 20, 2015 at 5:05 PM, Emil Velikov
wrote:
> On 21 November 2015 at 00:31, Nanley Chery wrote:
> > On Fri, Nov 20, 2015 at 3:38 PM, Chad Versace
> > wrote:
> >>
> >> On Fri 20 Nov 2015, Nanley Chery wrote:
> >> > On Fri, Nov
On Sat, Nov 21, 2015 at 2:46 PM, Ilia Mirkin wrote:
> Just ran into this myself and spent a bunch of time investigating...
> Any reason this wasn't already reviewed/checked in?
>
>
None that I know of. I just pushed it though.
> On Wed, Oct 28, 2015 at 5:50 PM, Nanley Cher
On Tue, Dec 01, 2015 at 04:03:22PM +, Lofstedt, Marta wrote:
> > -Original Message-
> > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
> > Behalf Of Lofstedt, Marta
> > Sent: Tuesday, December 1, 2015 4:48 PM
> > To: Emil Velikov; Marta Lofstedt
> > Cc: ML mesa-dev
>
On Tue, Dec 01, 2015 at 04:41:22PM +, Emil Velikov wrote:
> On 1 December 2015 at 16:03, Lofstedt, Marta wrote:
>
> >> > > - return _mesa_is_desktop_gl(ctx) && ctx->Version >= 32;
> >> > > + return (_mesa_is_gles31(ctx) &&
> >> > > + ctx->Extensions.OES_geometry_shader) ||
> >> >
> >> > P
From: Nanley Chery
Commit a16ffb743ced9fde80b2485dfc2d86ae74e86f25, which introduced
gl_extensions::Version, updates the field when the context version
is computed and when entering/exiting meta. Update this field when
the version is overridden as well.
Cc: Marta Lofstedt
Cc: Emil Velikov
On Tue, Dec 01, 2015 at 10:44:43AM -0800, Nanley Chery wrote:
From: Nanley Chery
Commit a16ffb743ced9fde80b2485dfc2d86ae74e86f25, which introduced
gl_extensions::Version, updates the field when the context version
is computed and when entering/exiting meta. Update this field when
the version is
On Thu, Dec 3, 2015 at 10:58 AM, Emil Velikov
wrote:
> On 1 December 2015 at 20:21, Nanley Chery wrote:
> > On Tue, Dec 01, 2015 at 10:44:43AM -0800, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Commit a16ffb743ced9fde80b2485dfc2d86ae74e86f25, which introduced
faces and it was derferencing the NULL pointer.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93257
> Cc: Nanley Chery
> Cc: "11.1"
> ---
Thanks for the fix! I'll be able to give this a better look next week, so
feel free to push if you receive a
On Thu, Dec 10, 2015 at 01:08:37PM -0800, Nanley Chery wrote:
> On Tue, Dec 08, 2015 at 04:35:57PM +, Neil Roberts wrote:
> > If EGL_KHR_surfaceless_context is used then glViewport can be called
> > with NULL for the draw and read surfaces. This was previously causing
> >
From: Nanley Chery
Commit 64880d073ab21ae1abad0c049ea2d6a1169a3cfa consolidated two
DIV_ROUND_UP() definitions to one, but chose the more
compute-intensive version in the process. Use the simpler version
instead. Reduces .text size by 1360 bytes.
Output of `size lib/i965_dri.so`:
text
On Thu, Dec 17, 2015 at 12:05:46PM +0100, Glenn Kennard wrote:
> On Wed, 16 Dec 2015 20:57:51 +0100, Nanley Chery
> wrote:
>
> >From: Nanley Chery
> >
> >Commit 64880d073ab21ae1abad0c049ea2d6a1169a3cfa consolidated two
> >DIV_ROUND_UP() definitions to o
On Thu, Dec 17, 2015 at 11:25 AM, Matt Turner wrote:
> On Thu, Dec 17, 2015 at 11:04 AM, Nanley Chery
> wrote:
> > On Thu, Dec 17, 2015 at 12:05:46PM +0100, Glenn Kennard wrote:
> >> On Wed, 16 Dec 2015 20:57:51 +0100, Nanley Chery
> wrote:
> >>
> >>
On Thu, Dec 17, 2015 at 11:53:03AM -0800, Nanley Chery wrote:
> On Thu, Dec 17, 2015 at 11:25 AM, Matt Turner wrote:
>
> > On Thu, Dec 17, 2015 at 11:04 AM, Nanley Chery
> > wrote:
> > > On Thu, Dec 17, 2015 at 12:05:46PM +0100, Glenn Kennard wrote:
> > >
mesa/drivers/dri/i965/gen6_depth_state.c | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
;
This patch is
Reviewed-by: Nanley Chery
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, May 18, 2017 at 06:38:04PM +0100, Emil Velikov wrote:
> On 18 May 2017 at 18:32, Emil Velikov wrote:
> > Hi Nanley,
> >
> > Has the patch need superseded by any chance or it's lacking review?
> >
> I'm blind - of course it is (alongside v3 2/2).
>
> At the same time neither of the two has
+Ken
On Tue, May 16, 2017 at 10:17:11AM -0700, Nanley Chery wrote:
> The procedure for decompressing an opaque BC1 Vulkan format is dependant on
> the
> comparison of two colors stored in the first 32 bits of the compressed block.
> Here's the specified OpenGL (and Vulkan) behav
This platform passes the following GLES3 tests:
ES3-CTS.functional.texture.compressed.astc.endpoint_value_hdr_cem_*
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/intel_extensions.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b
Signed-off-by: Nanley Chery
---
src/intel/isl/isl.h | 14 ++
src/intel/isl/isl_format.c | 32 ++--
src/intel/isl/isl_format_layout.csv | 14 ++
3 files changed, 58 insertions(+), 2 deletions(-)
diff --git a/src/intel
On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote:
> From: Ian Romanick
>
> The previous code handled everything with the general case. I noticed
> that every time I converted an open-coded check to use a
> _mesa_has_EXT_foo() function, the text size of the driver increased.
>
> Almo
On Fri, May 19, 2017 at 10:41:22AM -0700, Anuj Phogat wrote:
> On Thu, May 18, 2017 at 3:53 PM, Nanley Chery wrote:
> > This platform passes the following GLES3 tests:
> > ES3-CTS.functional.texture.compressed.astc.endpoint_value_hdr_cem_*
> >
> We've hdr tests
Cc: Anuj Phogat
Signed-off-by: Nanley Chery
---
docs/features.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/features.txt b/docs/features.txt
index e18bf54a48..05d776be08 100644
--- a/docs/features.txt
+++ b/docs/features.txt
@@ -306,8 +306,8 @@ Khronos, ARB
On Thu, May 18, 2017 at 02:00:50PM -0700, Jason Ekstrand wrote:
> This causes dEQP-VK.api.copy_and_blit.resolve_image.partial.* to start
> failing due to test bugs. See CL 1031 for a test fix.
> ---
> src/intel/vulkan/anv_blorp.c | 40
> ++
> src/intel/v
On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_image.c | 12 ++--
> src/intel/vulkan/genX_cmd_buffer.c | 9 +
> 2 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/
On Fri, May 19, 2017 at 05:32:07PM -0700, Ian Romanick wrote:
> On 05/19/2017 05:07 PM, Ilia Mirkin wrote:
> > On Fri, May 19, 2017 at 7:29 PM, Ian Romanick wrote:
> >> I missed that glsl_parser_extras.cpp has its own implementation of the
> >> has_XXX_foo() functions that take the API and version
On Fri, May 19, 2017 at 05:18:12PM -0700, Jason Ekstrand wrote:
> On Fri, May 19, 2017 at 4:51 PM, Nanley Chery wrote:
>
> > On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote:
> > > ---
> > > src/intel/vulkan/anv_image.c | 12 ++
On Fri, May 19, 2017 at 06:09:49PM -0700, Nanley Chery wrote:
> On Fri, May 19, 2017 at 05:18:12PM -0700, Jason Ekstrand wrote:
> > On Fri, May 19, 2017 at 4:51 PM, Nanley Chery wrote:
> >
> > > On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote:
> > >
On Fri, May 19, 2017 at 04:29:16PM -0700, Ian Romanick wrote:
> On 05/19/2017 10:28 AM, Nanley Chery wrote:
> > On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote:
> >> From: Ian Romanick
> >>
> >> The previous code handled everything with the gene
device.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
This patch is
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 50486b6..b80715f 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/in
_device.c | 12 ++--
> src/intel/vulkan/anv_private.h | 2 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
Patches 7 and 8 are
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 523d40e..4a0115e 100644
> --
On Thu, May 18, 2017 at 02:00:57PM -0700, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_device.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_d
On Thu, May 18, 2017 at 02:00:58PM -0700, Jason Ekstrand wrote:
> The idea behind doing this was to make it easier to set various flags.
> However, we have enough custom flag settings floating around the driver
> that this is more of a nuisance than a help.
> ---
> src/intel/vulkan/anv_allocator.c
insertions(+), 36 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index bb02378..6ea8dfe 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -112,42 +112
On Fri, May 19, 2017 at 10:53:12AM -0700, Jason Ekstrand wrote:
> On Thu, May 18, 2017 at 2:01 PM, Jason Ekstrand
> wrote:
>
> > ---
> > src/intel/vulkan/anv_device.c | 42 ++
> > ++--
> > 1 file changed, 36 insertions(+), 6 deletions(-)
> >
> > diff --git a/s
ve 8 GiB
> > of
> > > + * video memory and so carving off 2 GiB for the 32-bit heap
> > should be
> > > + * reasonable.
> > > + */
> > > + const uint32_t heap_size_32bit = 2ull * (1ull << 30);
> > > + const
On Thu, May 18, 2017 at 02:00:59PM -0700, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_device.c | 6 --
> src/intel/vulkan/anv_private.h | 11 ++-
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git
On Thu, May 18, 2017 at 02:01:02PM -0700, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_device.c | 12
> 1 file changed, 12 insertions(+)
>
Patches 9 and 15 are
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_d
d a CCS surface and render to it. Who knows what
> will
> +* happen to caching at that point. It's probably best if we don't let
> +* this happen at the same time as other rendering. Flush the render
> cache
> +* and stall prior to this operation.
&
--
> src/intel/vulkan/anv_image.c | 28
> 1 file changed, 28 deletions(-)
>
I'm glad that we're fixing this. This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
> index d65ef47..3510186 1006
On Fri, May 12, 2017 at 04:38:09PM -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/intel/genxml/genX_pack.h | 2 ++
> 1 file changed, 2 insertions(+)
>
Patches 4-5 are
Reviewed-by: Nanley Chery
> diff --git a/src/intel/genxml/genX_pack.h b/src/intel/
On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote:
> This enum describes all of the states that a auxiliary compressed
^
an
> surface can have. All of the states as well as normative language for
On Fri, Jun 02, 2017 at 01:05:47PM -0700, Jason Ekstrand wrote:
> On Fri, Jun 2, 2017 at 12:57 PM, Nanley Chery wrote:
>
> > On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote:
> > > This enum describes all of the states that a
On Fri, May 26, 2017 at 04:30:19PM -0700, Jason Ekstrand wrote:
> This commit adds a new unified interface for doing resolves. The basic
> format is that, prior to any surface access such as texturing or
> rendering, you call intel_miptree_prepare_access. If the surface was
> written, you call in
Make the function take in an image instead of an image view. This
enables us to record relocations for surfaces states created outside of
the anv_CreateImageView path.
v2 (Jason Ekstrand):
- Use image->offset instead of surf_offset in aux_offset calculation.
Signed-off-by: Nanley Chery
---
v2:
- Check for aux levels in layer helper (Jason Ekstrand)
- Don't assert aux is present, return 0 if it isn't.
- Use the helpers.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 4
src/intel/vulkan/anv_private.h | 39 ++
v2:
- Do layered resolves.
(Jason Ekstrand):
- Replace "bt" suffix with "attachment".
- Rename helper function to prepare_ccs_resolve.
- Move blorp_params_init() into helper function.
Signed-off-by: Nanley Chery
---
Looks like layered CCS resolves actually do work. I must
v2: Omit the commit message.
Reviewed-by: Jason Ekstrand (v1)
Signed-off-by: Nanley Chery
---
src/intel/isl/isl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index b593e153dc..ccc8e16824 100644
--- a/src/intel/isl/isl.c
+++ b
Signed-off-by: Nanley Chery
---
src/intel/isl/isl.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 860fc28b27..b593e153dc 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -1714,14 +1714,19
t CTS tests. Instead, unify the behaviour in both
scenarios, and wait for the CTS tests to catch up. See CL for the
test fix.
On SKL+, this causes 3 test failures under:
dEQP-VK.pipeline.render_to_image.3d.*
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 8
1 file chang
This series implements refactors and behavioral changes to make the
follow-on series which implements layout-based CCS resolves a lot
clearer.
Cc: Jason Ekstrand
Nanley Chery (13):
intel/blorp: Assert on subresource in surface_info_init
intel/blorp: Assert on gen7 fast-cleared subresource
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/intel/blorp/blorp.c b/src/intel/blorp/blorp.c
index 9c88658e8a..993b42fa85 100644
--- a/src/intel/blorp/blorp.c
+++ b/src/intel/blorp/blorp.c
@@ -66,6 +66,8
Splitting out these fields will make the color buffer transitioning
function simpler when it gains more features.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 33
src/intel/vulkan/anv_private.h | 4 ++--
src/intel/vulkan
This will be used in the next patch.
v2:
- Omit BLORP_BATCH_NO_EMIT_DEPTH_STENCIL (Jason Ekstrand)
- Update commit message.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 41 +
src/intel/vulkan/anv_private.h | 6 ++
2 files changed
Reflect the fact that an image view or subresource range with the color
aspect cannot have any other aspect.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src
A GPU memcpy function could alternatively be implemented using MI_*
commands. Provide more detail into how this one operates in case another
memcpy function is created.
v2: Update the commit message.
Suggested-by: Jason Ekstrand
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_genX.h
In the future, we plan on using this method to resolve images whose
surface state fast-clear value is dynamically updated during command
buffer execution. Start using it now for testing and to reduce churn
later on.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 29
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp_clear.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c
index 3d5c41cc71..f43d05ad19 100644
--- a/src/intel/blorp/blorp_clear.c
+++ b/src/intel/blorp/blorp_clear.c
On Tue, Jun 13, 2017 at 05:49:59PM +0300, Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 29
> +--
> 1 file changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipma
On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> b/src/mesa/dr
On Wed, Jun 14, 2017 at 10:36:16AM +0300, Pohjolainen, Topi wrote:
> On Tue, Jun 13, 2017 at 05:26:52PM -0700, Nanley Chery wrote:
> > On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote:
> > > Signed-off-by: Topi Pohjolainen
> > > ---
>
On Wed, Jun 14, 2017 at 09:32:22AM +0200, Iago Toral wrote:
> On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote:
> > For 3D image subresources undergoing a layout transition via
> > PipelineBarrier, we increase the number of fast-cleared layers to
> > match
> >
On Wed, Jun 14, 2017 at 09:45:46PM +0300, Pohjolainen, Topi wrote:
> On Tue, Jun 13, 2017 at 04:31:26PM -0700, Nanley Chery wrote:
> > On Tue, Jun 13, 2017 at 05:49:59PM +0300, Topi Pohjolainen wrote:
> > > Signed-off-by: Topi Pohjolainen
> > > ---
>
On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> b/src/mesa/dr
On Tue, Jun 13, 2017 at 05:50:02PM +0300, Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 46
> ++-
> 1 file changed, 38 insertions(+), 8 deletions(-)
>
Patches 2-4 are
Reviewed-by: Nan
nables the
driver to pass the arb_texture_view-rendering-formats piglit test.
Cc:
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 28 +--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tre
CannonLake additionally supports R11G11B10_FLOAT and four 10-10-10-2
formats with CCS_E. None of these formats fit within the current
blorp_copy framework so disable them until support is added.
Signed-off-by: Nanley Chery
Cc: Jason Ekstrand
---
Jason, do you think we modify blorp instead of
On Fri, Oct 27, 2017 at 12:52:30PM -0700, Jason Ekstrand wrote:
> On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery
> wrote:
>
> > Only use CCS_E to render to a texture that is CCS_E-compatible with the
> > original texture's miptree (linear) format. This prevents render
&
On Fri, Oct 27, 2017 at 12:50:45PM -0700, Jason Ekstrand wrote:
> Thanks for doing this in isl_format_supports_ccs_e instead of changing the
> table!
>
> Reviewed-by: Jason Ekstrand
>
Thank you for the review!
> On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery
> wro
On Fri, Oct 27, 2017 at 05:14:16PM -0700, Jason Ekstrand wrote:
> On Fri, Oct 27, 2017 at 3:16 PM, Nanley Chery wrote:
>
> > On Fri, Oct 27, 2017 at 12:52:30PM -0700, Jason Ekstrand wrote:
> > > On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery
> > > wrote:
> >
On Mon, Oct 02, 2017 at 04:07:59PM -0700, Anuj Phogat wrote:
> This optimization is enabled for previous generations too.
> See Mesa commit c17e214a6b
> On CNL this bit is moved to 3DSTATE_3D_MODE.
Is this true? Looking at the HW docs, I actually found this bit to exist
in CACHE_MODE_SS. Bit 9 of
On Mon, Oct 02, 2017 at 04:08:00PM -0700, Anuj Phogat wrote:
> Cc: mesa-sta...@lists.freedesktop.org
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/dri/i965/brw_state_upload.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Assuming my comment in patch 3 is correct, we n
On Mon, Oct 30, 2017 at 12:28:53PM -0700, Anuj Phogat wrote:
> On Mon, Oct 30, 2017 at 11:08 AM, Nanley Chery wrote:
> > On Mon, Oct 02, 2017 at 04:08:00PM -0700, Anuj Phogat wrote:
> >> Cc: mesa-sta...@lists.freedesktop.org
> >> Signed-off-by: Anuj Phogat
> >
On Mon, Oct 02, 2017 at 04:07:58PM -0700, Anuj Phogat wrote:
> Cc: mesa-sta...@lists.freedesktop.org
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/dri/i965/brw_pipe_control.c | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_pipe_
On Fri, Oct 06, 2017 at 04:30:47PM -0700, Anuj Phogat wrote:
> There are few other (duplicate) workarounds which have similar
> recommendations:
> WaFlushHangWhenNonPipelineStateAndMarkerStalled
> WaCSStallBefore3DSamplePattern
> WaPipeControlBefore3DStateSamplePattern
>
> WaPipeControlBefore3DSt
On Mon, Oct 30, 2017 at 05:24:10PM -0700, Nanley Chery wrote:
> On Fri, Oct 06, 2017 at 04:30:47PM -0700, Anuj Phogat wrote:
> > There are few other (duplicate) workarounds which have similar
> > recommendations:
> > WaFlushHangWhenNonPipeline
On Tue, Oct 31, 2017 at 02:15:43PM -0700, Jason Ekstrand wrote:
> On Mon, Oct 30, 2017 at 10:37 AM, Nanley Chery
> wrote:
>
> > On Fri, Oct 27, 2017 at 05:14:16PM -0700, Jason Ekstrand wrote:
> > > On Fri, Oct 27, 2017 at 3:16 PM, Nanley Chery
> > wrote:
> >
On Tue, Oct 31, 2017 at 08:01:05PM -0700, Jason Ekstrand wrote:
> This function is a bit more accurate because it lets us sample from sRGB
> textures if sRGB decode is off. This should improve performance in
^ ^
missing "with C
On Wed, Nov 01, 2017 at 10:58:03AM -0700, Jason Ekstrand wrote:
> On Wed, Nov 1, 2017 at 10:46 AM, Nanley Chery wrote:
>
> > On Tue, Oct 31, 2017 at 08:01:05PM -0700, Jason Ekstrand wrote:
> > > This function is a bit more accurate because it lets us sample from sRGB
&
on CNL. But it might be fixing something we haven't tested yet.
>
> V2: Use brw_load_register_imm32() to program CACHE_MODE_0.
> Get rid of brw_flush_gpu_caches().
>
> Cc: Nanley Chery
> Signed-off-by: Anuj Phogat
> Reviewed-by: Rafael Antognolli
> ---
> src/
L. But it might be fixing something we haven't tested yet.
>
> Cc: Nanley Chery
> Signed-off-by: Anuj Phogat
> Reviewed-by: Rafael Antognolli
> ---
> src/mesa/drivers/dri/i965/brw_pipe_control.c | 21 +
> 1 file changed, 21 insertions(+)
>
>
CNL.
>
I haven't seen this format in the git logs before..
> Cc: Nanley Chery
> Cc: Jason Ekstrand
> Signed-off-by: Anuj Phogat
> Reviewed-by: Rafael Antognolli
> ---
> src/mesa/drivers/dri/i965/brw_defines.h | 2 ++
> src/mesa/drivers/dri/i965/brw_state_upl
On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote:
> This optimization is enabled for previous generations too.
> See Mesa commit c17e214a6b
> On CNL this bit has been moved to CACHE_MODE_SS register.
>
> Cc: Nanley Chery
> Signed-off-by: Anuj Phogat
> ---
> s
On Thu, Nov 02, 2017 at 06:13:43PM -0700, Matt Turner wrote:
> On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote:
> > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote:
> >> V2: Remove the bits enabling Float blend optimization. It is
> >> enabled thr
On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote:
> On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote:
> > This optimization is enabled for previous generations too.
> > See Mesa commit c17e214a6b
> > On CNL this bit has been moved to CACHE_MODE_SS
On Fri, Nov 03, 2017 at 09:50:41AM -0700, Nanley Chery wrote:
> On Thu, Nov 02, 2017 at 06:13:43PM -0700, Matt Turner wrote:
> > On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote:
> > > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote:
> > >> V2: Remove
On Fri, Nov 03, 2017 at 11:39:34AM -0700, Anuj Phogat wrote:
> On Fri, Nov 3, 2017 at 9:46 AM, Nanley Chery wrote:
> > On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote:
> >> This optimization is enabled for previous generations too.
> >> See Mesa commit c17e
On Fri, Nov 03, 2017 at 11:50:44AM -0700, Anuj Phogat wrote:
> On Fri, Nov 3, 2017 at 11:05 AM, Nanley Chery wrote:
> > On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote:
> >> On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote:
> >> > This optimi
On Mon, Jul 10, 2017 at 10:14:21AM -0700, Jason Ekstrand wrote:
> On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote:
>
> > v2: Expound on comment for the pipe controls (Jason Ekstrand).
> >
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/vulkan/anv_b
On Mon, Jul 17, 2017 at 02:41:32PM -0700, Jason Ekstrand wrote:
> On Fri, Jul 14, 2017 at 2:42 AM, Nanley Chery wrote:
>
> > On Mon, Jul 10, 2017 at 10:14:21AM -0700, Jason Ekstrand wrote:
> > > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery
> > wrote:
> > >
Cc:
Suggested-by: Jason Ekstrand
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 8
src/intel/vulkan/anv_private.h | 8
src/intel/vulkan/genX_cmd_buffer.c | 25 +++--
3 files changed, 23 insertions(+), 18 deletions(-)
diff --git
v2: Update comments, function signatures, and add assertions.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 78 ++
src/intel/vulkan/anv_private.h | 12 +++
2 files changed, 90 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 4f0057c952..f33a445d1d 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
bpass resolves with multisampled images ignored CCS_D.
* the Haswell boxes in jenkins start to GPU hang, but the don't do so
on my local machine.
Nanley Chery (18):
anv: Transition MCS buffers from the undefined layout
intel/isl: Add surface state clear value information
anv/image: Disable
601 - 700 of 1409 matches
Mail list logo