Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

2015-11-18 Thread Nanley Chery
On Wed, Nov 18, 2015 at 3:47 PM, Matt Turner wrote: > > On Wed, Nov 18, 2015 at 3:01 PM, Nanley Chery wrote: > > From: Nanley Chery > > > > Make it easier to determine where to add new extensions. > > Performed with the vim sort command. > > Well, I think

[Mesa-dev] [PATCH] mesa: Add test for sorted extension table

2015-11-19 Thread Nanley Chery
From: Nanley Chery Enable developers to know if the table's alphabetical sorting is maintained or lost. v2: Move "*" next to pointer name (Matt) Include extensions_table.h instead of extensions.h (Ian) Remove extra " *" in comment (Ian) Signed-off-by: Na

Re: [Mesa-dev] MESA_EXTENSION_OVERRIDE problem

2015-11-19 Thread Nanley Chery
On Thu, Nov 19, 2015 at 12:13 PM, Brian Paul wrote: > Hi Nanley, > > Hi Brian, > Maybe you can fix an issue I have with the new extension code. > > Previously, I could do something like export > MESA_EXTENSION_OVERRIDE="-ARB_clear_buffer_object" and I would no longer > see it in the GL_EXTENSIO

Re: [Mesa-dev] MESA_EXTENSION_OVERRIDE problem

2015-11-20 Thread Nanley Chery
On Fri, Nov 20, 2015 at 8:49 AM, Brian Paul wrote: > On Thu, Nov 19, 2015 at 7:04 PM, Ian Romanick wrote: > >> On 11/19/2015 05:40 PM, Nanley Chery wrote: >> > >> > On Thu, Nov 19, 2015 at 12:13 PM, Brian Paul > > <mailto:bri...@vmware.com>> wrot

Re: [Mesa-dev] MESA_EXTENSION_OVERRIDE problem

2015-11-20 Thread Nanley Chery
On Fri, Nov 20, 2015 at 3:38 PM, Chad Versace wrote: > On Fri 20 Nov 2015, Nanley Chery wrote: > > On Fri, Nov 20, 2015 at 8:49 AM, Brian Paul > wrote: > > > > > On Thu, Nov 19, 2015 at 7:04 PM, Ian Romanick > wrote: > > > >> I think #2 might be

[Mesa-dev] [PATCH] mesa/extensions: Enable overriding permanently enabled extensions

2015-11-20 Thread Nanley Chery
From: Nanley Chery Provide the ability to prevent any permanently enabled extension from appearing in the string returned by glGetString[i](). Signed-off-by: Nanley Chery --- src/mesa/main/extensions.c | 64 +- 1 file changed, 24 insertions(+), 40

Re: [Mesa-dev] MESA_EXTENSION_OVERRIDE problem

2015-11-20 Thread Nanley Chery
On Fri, Nov 20, 2015 at 3:38 PM, Chad Versace wrote: > On Fri 20 Nov 2015, Nanley Chery wrote: > > On Fri, Nov 20, 2015 at 8:49 AM, Brian Paul > wrote: > > > > > On Thu, Nov 19, 2015 at 7:04 PM, Ian Romanick > wrote: > > > >> I think #2 might be

Re: [Mesa-dev] MESA_EXTENSION_OVERRIDE problem

2015-11-20 Thread Nanley Chery
On Fri, Nov 20, 2015 at 5:05 PM, Emil Velikov wrote: > On 21 November 2015 at 00:31, Nanley Chery wrote: > > On Fri, Nov 20, 2015 at 3:38 PM, Chad Versace > > wrote: > >> > >> On Fri 20 Nov 2015, Nanley Chery wrote: > >> > On Fri, Nov

Re: [Mesa-dev] [PATCH v2] mesa/teximage: Fix S3TC regression due to ASTC interaction

2015-11-22 Thread Nanley Chery
On Sat, Nov 21, 2015 at 2:46 PM, Ilia Mirkin wrote: > Just ran into this myself and spent a bunch of time investigating... > Any reason this wasn't already reviewed/checked in? > > None that I know of. I just pushed it though. > On Wed, Oct 28, 2015 at 5:50 PM, Nanley Cher

Re: [Mesa-dev] [PATCH v2 5/6] mesa: Update _mesa_has_geometry_shaders

2015-12-01 Thread Nanley Chery
On Tue, Dec 01, 2015 at 04:03:22PM +, Lofstedt, Marta wrote: > > -Original Message- > > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > > Behalf Of Lofstedt, Marta > > Sent: Tuesday, December 1, 2015 4:48 PM > > To: Emil Velikov; Marta Lofstedt > > Cc: ML mesa-dev >

Re: [Mesa-dev] [PATCH v2 5/6] mesa: Update _mesa_has_geometry_shaders

2015-12-01 Thread Nanley Chery
On Tue, Dec 01, 2015 at 04:41:22PM +, Emil Velikov wrote: > On 1 December 2015 at 16:03, Lofstedt, Marta wrote: > > >> > > - return _mesa_is_desktop_gl(ctx) && ctx->Version >= 32; > >> > > + return (_mesa_is_gles31(ctx) && > >> > > + ctx->Extensions.OES_geometry_shader) || > >> > > >> > P

[Mesa-dev] [PATCH] mesa/version: Update gl_extensions::Version during version override

2015-12-01 Thread Nanley Chery
From: Nanley Chery Commit a16ffb743ced9fde80b2485dfc2d86ae74e86f25, which introduced gl_extensions::Version, updates the field when the context version is computed and when entering/exiting meta. Update this field when the version is overridden as well. Cc: Marta Lofstedt Cc: Emil Velikov

[Mesa-dev] [PATCH v2] mesa/version: Update gl_extensions::Version during version override

2015-12-01 Thread Nanley Chery
On Tue, Dec 01, 2015 at 10:44:43AM -0800, Nanley Chery wrote: From: Nanley Chery Commit a16ffb743ced9fde80b2485dfc2d86ae74e86f25, which introduced gl_extensions::Version, updates the field when the context version is computed and when entering/exiting meta. Update this field when the version is

Re: [Mesa-dev] [PATCH v2] mesa/version: Update gl_extensions::Version during version override

2015-12-03 Thread Nanley Chery
On Thu, Dec 3, 2015 at 10:58 AM, Emil Velikov wrote: > On 1 December 2015 at 20:21, Nanley Chery wrote: > > On Tue, Dec 01, 2015 at 10:44:43AM -0800, Nanley Chery wrote: > > From: Nanley Chery > > > > Commit a16ffb743ced9fde80b2485dfc2d86ae74e86f25, which introduced

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-10 Thread Nanley Chery
faces and it was derferencing the NULL pointer. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93257 > Cc: Nanley Chery > Cc: "11.1" > --- Thanks for the fix! I'll be able to give this a better look next week, so feel free to push if you receive a

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-14 Thread Nanley Chery
On Thu, Dec 10, 2015 at 01:08:37PM -0800, Nanley Chery wrote: > On Tue, Dec 08, 2015 at 04:35:57PM +, Neil Roberts wrote: > > If EGL_KHR_surfaceless_context is used then glViewport can be called > > with NULL for the draw and read surfaces. This was previously causing > >

[Mesa-dev] [PATCH] util/macros: Simplify DIV_ROUND_UP() definition

2015-12-16 Thread Nanley Chery
From: Nanley Chery Commit 64880d073ab21ae1abad0c049ea2d6a1169a3cfa consolidated two DIV_ROUND_UP() definitions to one, but chose the more compute-intensive version in the process. Use the simpler version instead. Reduces .text size by 1360 bytes. Output of `size lib/i965_dri.so`: text

Re: [Mesa-dev] [PATCH] util/macros: Simplify DIV_ROUND_UP() definition

2015-12-17 Thread Nanley Chery
On Thu, Dec 17, 2015 at 12:05:46PM +0100, Glenn Kennard wrote: > On Wed, 16 Dec 2015 20:57:51 +0100, Nanley Chery > wrote: > > >From: Nanley Chery > > > >Commit 64880d073ab21ae1abad0c049ea2d6a1169a3cfa consolidated two > >DIV_ROUND_UP() definitions to o

Re: [Mesa-dev] [PATCH] util/macros: Simplify DIV_ROUND_UP() definition

2015-12-17 Thread Nanley Chery
On Thu, Dec 17, 2015 at 11:25 AM, Matt Turner wrote: > On Thu, Dec 17, 2015 at 11:04 AM, Nanley Chery > wrote: > > On Thu, Dec 17, 2015 at 12:05:46PM +0100, Glenn Kennard wrote: > >> On Wed, 16 Dec 2015 20:57:51 +0100, Nanley Chery > wrote: > >> > >>

Re: [Mesa-dev] [PATCH] util/macros: Simplify DIV_ROUND_UP() definition

2015-12-17 Thread Nanley Chery
On Thu, Dec 17, 2015 at 11:53:03AM -0800, Nanley Chery wrote: > On Thu, Dec 17, 2015 at 11:25 AM, Matt Turner wrote: > > > On Thu, Dec 17, 2015 at 11:04 AM, Nanley Chery > > wrote: > > > On Thu, Dec 17, 2015 at 12:05:46PM +0100, Glenn Kennard wrote: > > >

Re: [Mesa-dev] [v2 02/39] i965/gen6: Remove dead code in hiz surface setup

2017-05-17 Thread Nanley Chery
mesa/drivers/dri/i965/gen6_depth_state.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > This patch is Reviewed-by: Nanley Chery ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [v3 04/19] intel/isl/gen6: Allow arrayed stencil

2017-05-17 Thread Nanley Chery
; This patch is Reviewed-by: Nanley Chery ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] anv/formats: Update the BC1_RGB mappings

2017-05-18 Thread Nanley Chery
On Thu, May 18, 2017 at 06:38:04PM +0100, Emil Velikov wrote: > On 18 May 2017 at 18:32, Emil Velikov wrote: > > Hi Nanley, > > > > Has the patch need superseded by any chance or it's lacking review? > > > I'm blind - of course it is (alongside v3 2/2). > > At the same time neither of the two has

Re: [Mesa-dev] [PATCH v3 1/2] anv/formats: Update the three-channel BC1 mappings

2017-05-18 Thread Nanley Chery
+Ken On Tue, May 16, 2017 at 10:17:11AM -0700, Nanley Chery wrote: > The procedure for decompressing an opaque BC1 Vulkan format is dependant on > the > comparison of two colors stored in the first 32 bits of the compressed block. > Here's the specified OpenGL (and Vulkan) behav

[Mesa-dev] [PATCH 2/2] i965: Enable ASTC HDR for Broxton

2017-05-18 Thread Nanley Chery
This platform passes the following GLES3 tests: ES3-CTS.functional.texture.compressed.astc.endpoint_value_hdr_cem_* Signed-off-by: Nanley Chery --- src/mesa/drivers/dri/i965/intel_extensions.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b

[Mesa-dev] [PATCH 1/2] intel/isl: Add ASTC HDR to format lists and helpers

2017-05-18 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/isl/isl.h | 14 ++ src/intel/isl/isl_format.c | 32 ++-- src/intel/isl/isl_format_layout.csv | 14 ++ 3 files changed, 58 insertions(+), 2 deletions(-) diff --git a/src/intel

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

2017-05-19 Thread Nanley Chery
On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: > From: Ian Romanick > > The previous code handled everything with the general case. I noticed > that every time I converted an open-coded check to use a > _mesa_has_EXT_foo() function, the text size of the driver increased. > > Almo

Re: [Mesa-dev] [PATCH 2/2] i965: Enable ASTC HDR for Broxton

2017-05-19 Thread Nanley Chery
On Fri, May 19, 2017 at 10:41:22AM -0700, Anuj Phogat wrote: > On Thu, May 18, 2017 at 3:53 PM, Nanley Chery wrote: > > This platform passes the following GLES3 tests: > > ES3-CTS.functional.texture.compressed.astc.endpoint_value_hdr_cem_* > > > We've hdr tests

[Mesa-dev] [PATCH] docs: Document ASTC extension support for SKL and BXT

2017-05-19 Thread Nanley Chery
Cc: Anuj Phogat Signed-off-by: Nanley Chery --- docs/features.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index e18bf54a48..05d776be08 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -306,8 +306,8 @@ Khronos, ARB

Re: [Mesa-dev] [PATCH 03/16] anv: Handle color layout transitions from the UNINITIALIZED layout

2017-05-19 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:50PM -0700, Jason Ekstrand wrote: > This causes dEQP-VK.api.copy_and_blit.resolve_image.partial.* to start > failing due to test bugs. See CL 1031 for a test fix. > --- > src/intel/vulkan/anv_blorp.c | 40 > ++ > src/intel/v

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

2017-05-19 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 12 ++-- > src/intel/vulkan/genX_cmd_buffer.c | 9 + > 2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

2017-05-19 Thread Nanley Chery
On Fri, May 19, 2017 at 05:32:07PM -0700, Ian Romanick wrote: > On 05/19/2017 05:07 PM, Ilia Mirkin wrote: > > On Fri, May 19, 2017 at 7:29 PM, Ian Romanick wrote: > >> I missed that glsl_parser_extras.cpp has its own implementation of the > >> has_XXX_foo() functions that take the API and version

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

2017-05-19 Thread Nanley Chery
On Fri, May 19, 2017 at 05:18:12PM -0700, Jason Ekstrand wrote: > On Fri, May 19, 2017 at 4:51 PM, Nanley Chery wrote: > > > On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/anv_image.c | 12 ++

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

2017-05-22 Thread Nanley Chery
On Fri, May 19, 2017 at 06:09:49PM -0700, Nanley Chery wrote: > On Fri, May 19, 2017 at 05:18:12PM -0700, Jason Ekstrand wrote: > > On Fri, May 19, 2017 at 4:51 PM, Nanley Chery wrote: > > > > > On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote: > > >

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

2017-05-22 Thread Nanley Chery
On Fri, May 19, 2017 at 04:29:16PM -0700, Ian Romanick wrote: > On 05/19/2017 10:28 AM, Nanley Chery wrote: > > On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> The previous code handled everything with the gene

Re: [Mesa-dev] [PATCH 06/16] anv: Predicate 48bit support on gen >= 8

2017-05-23 Thread Nanley Chery
device.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) This patch is Reviewed-by: Nanley Chery > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 50486b6..b80715f 100644 > --- a/src/intel/vulkan/anv_device.c > +++ b/src/in

Re: [Mesa-dev] [PATCH 08/16] anv: Determine the type of mapping based on type metadata

2017-05-23 Thread Nanley Chery
_device.c | 12 ++-- > src/intel/vulkan/anv_private.h | 2 +- > 2 files changed, 7 insertions(+), 7 deletions(-) > Patches 7 and 8 are Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 523d40e..4a0115e 100644 > --

Re: [Mesa-dev] [PATCH 10/16] anv: Set image memory types based on the type count

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:57PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_d

Re: [Mesa-dev] [PATCH 11/16] anv: Stop setting BO flags in bo_init_new

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:58PM -0700, Jason Ekstrand wrote: > The idea behind doing this was to make it easier to set various flags. > However, we have enough custom flag settings floating around the driver > that this is more of a nuisance than a help. > --- > src/intel/vulkan/anv_allocator.c

Re: [Mesa-dev] [PATCH 13/16] anv: Refactor memory type setup

2017-05-23 Thread Nanley Chery
insertions(+), 36 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index bb02378..6ea8dfe 100644 > --- a/src/intel/vulkan/anv_device.c > +++ b/src/intel/vulkan/anv_device.c > @@ -112,42 +112

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

2017-05-23 Thread Nanley Chery
On Fri, May 19, 2017 at 10:53:12AM -0700, Jason Ekstrand wrote: > On Thu, May 18, 2017 at 2:01 PM, Jason Ekstrand > wrote: > > > --- > > src/intel/vulkan/anv_device.c | 42 ++ > > ++-- > > 1 file changed, 36 insertions(+), 6 deletions(-) > > > > diff --git a/s

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

2017-05-23 Thread Nanley Chery
ve 8 GiB > > of > > > + * video memory and so carving off 2 GiB for the 32-bit heap > > should be > > > + * reasonable. > > > + */ > > > + const uint32_t heap_size_32bit = 2ull * (1ull << 30); > > > + const

Re: [Mesa-dev] [PATCH 12/16] anv: Make supports_48bit_addresses a heap property

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:59PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 6 -- > src/intel/vulkan/anv_private.h | 11 ++- > 2 files changed, 14 insertions(+), 3 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git

Re: [Mesa-dev] [PATCH 15/16] anv: Require vertex buffers to come from a 32-bit heap

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:01:02PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 12 > 1 file changed, 12 insertions(+) > Patches 9 and 15 are Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_d

Re: [Mesa-dev] [PATCH v2 4/16] anv: Handle color layout transitions from the UNINITIALIZED layout

2017-05-23 Thread Nanley Chery
d a CCS surface and render to it. Who knows what > will > +* happen to caching at that point. It's probably best if we don't let > +* this happen at the same time as other rendering. Flush the render > cache > +* and stall prior to this operation. &

Re: [Mesa-dev] [PATCH 05/16] anv/image: Get rid of the memset(aux, 0, sizeof(aux)) hack

2017-05-23 Thread Nanley Chery
-- > src/intel/vulkan/anv_image.c | 28 > 1 file changed, 28 deletions(-) > I'm glad that we're fixing this. This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c > index d65ef47..3510186 1006

Re: [Mesa-dev] [PATCH 05/24] i965/cnl: Include gen10_pack.h

2017-05-30 Thread Nanley Chery
On Fri, May 12, 2017 at 04:38:09PM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/genX_pack.h | 2 ++ > 1 file changed, 2 insertions(+) > Patches 4-5 are Reviewed-by: Nanley Chery > diff --git a/src/intel/genxml/genX_pack.h b/src/intel/

Re: [Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

2017-06-02 Thread Nanley Chery
On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote: > This enum describes all of the states that a auxiliary compressed ^ an > surface can have. All of the states as well as normative language for

Re: [Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

2017-06-02 Thread Nanley Chery
On Fri, Jun 02, 2017 at 01:05:47PM -0700, Jason Ekstrand wrote: > On Fri, Jun 2, 2017 at 12:57 PM, Nanley Chery wrote: > > > On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote: > > > This enum describes all of the states that a

Re: [Mesa-dev] [PATCH 15/30] i965/miptree: Add new entrypoints for resolve management

2017-06-02 Thread Nanley Chery
On Fri, May 26, 2017 at 04:30:19PM -0700, Jason Ekstrand wrote: > This commit adds a new unified interface for doing resolves. The basic > format is that, prior to any surface access such as texturing or > rendering, you call intel_miptree_prepare_access. If the surface was > written, you call in

[Mesa-dev] [PATCH 09/13] anv/cmd_buffer: Adjust the image view reloc function

2017-06-13 Thread Nanley Chery
Make the function take in an image instead of an image view. This enables us to record relocations for surfaces states created outside of the anv_CreateImageView path. v2 (Jason Ekstrand): - Use image->offset instead of surf_offset in aux_offset calculation. Signed-off-by: Nanley Chery ---

[Mesa-dev] [PATCH 05/13] anv: Add and use color auxiliary buffer helpers

2017-06-13 Thread Nanley Chery
v2: - Check for aux levels in layer helper (Jason Ekstrand) - Don't assert aux is present, return 0 if it isn't. - Use the helpers. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 4 src/intel/vulkan/anv_private.h | 39 ++

[Mesa-dev] [PATCH 10/13] blorp/clear: Add a binding-table-based CCS resolve function

2017-06-13 Thread Nanley Chery
v2: - Do layered resolves. (Jason Ekstrand): - Replace "bt" suffix with "attachment". - Rename helper function to prepare_ccs_resolve. - Move blorp_params_init() into helper function. Signed-off-by: Nanley Chery --- Looks like layered CCS resolves actually do work. I must

[Mesa-dev] [PATCH 04/13] intel/isl: Only create a CCS buffer if the image supports rendering

2017-06-13 Thread Nanley Chery
v2: Omit the commit message. Reviewed-by: Jason Ekstrand (v1) Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index b593e153dc..ccc8e16824 100644 --- a/src/intel/isl/isl.c +++ b

[Mesa-dev] [PATCH 03/13] intel/isl: Limit CCS to one subresource on gen7

2017-06-13 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 860fc28b27..b593e153dc 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1714,14 +1714,19

[Mesa-dev] [PATCH 07/13] anv/blorp: Remove 3D subresource transition workaround

2017-06-13 Thread Nanley Chery
t CTS tests. Instead, unify the behaviour in both scenarios, and wait for the CTS tests to catch up. See CL for the test fix. On SKL+, this causes 3 test failures under: dEQP-VK.pipeline.render_to_image.3d.* Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 8 1 file chang

[Mesa-dev] [PATCH 00/13] anv: Prep-work for layout-based CCS resolves

2017-06-13 Thread Nanley Chery
This series implements refactors and behavioral changes to make the follow-on series which implements layout-based CCS resolves a lot clearer. Cc: Jason Ekstrand Nanley Chery (13): intel/blorp: Assert on subresource in surface_info_init intel/blorp: Assert on gen7 fast-cleared subresource

[Mesa-dev] [PATCH 01/13] intel/blorp: Assert on subresource in surface_info_init

2017-06-13 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/blorp/blorp.c b/src/intel/blorp/blorp.c index 9c88658e8a..993b42fa85 100644 --- a/src/intel/blorp/blorp.c +++ b/src/intel/blorp/blorp.c @@ -66,6 +66,8

[Mesa-dev] [PATCH 08/13] anv: Adjust params of color buffer transitioning functions

2017-06-13 Thread Nanley Chery
Splitting out these fields will make the color buffer transitioning function simpler when it gains more features. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 33 src/intel/vulkan/anv_private.h | 4 ++-- src/intel/vulkan

[Mesa-dev] [PATCH 11/13] anv/blorp: Add a surface-state-based CCS resolve function

2017-06-13 Thread Nanley Chery
This will be used in the next patch. v2: - Omit BLORP_BATCH_NO_EMIT_DEPTH_STENCIL (Jason Ekstrand) - Update commit message. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 41 + src/intel/vulkan/anv_private.h | 6 ++ 2 files changed

[Mesa-dev] [PATCH 06/13] anv/cmd_buffer: Adjust layout transition aspect checking

2017-06-13 Thread Nanley Chery
Reflect the fact that an image view or subresource range with the color aspect cannot have any other aspect. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src

[Mesa-dev] [PATCH 13/13] anv/gpu_memcpy: Rename the gpu_memcpy function

2017-06-13 Thread Nanley Chery
A GPU memcpy function could alternatively be implemented using MI_* commands. Provide more detail into how this one operates in case another memcpy function is created. v2: Update the commit message. Suggested-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_genX.h

[Mesa-dev] [PATCH 12/13] anv/blorp: Provide surface states for CCS resolves

2017-06-13 Thread Nanley Chery
In the future, we plan on using this method to resolve images whose surface state fast-clear value is dynamically updated during command buffer execution. Start using it now for testing and to reduce churn later on. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 29

[Mesa-dev] [PATCH 02/13] intel/blorp: Assert on gen7 fast-cleared subresource

2017-06-13 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/blorp/blorp_clear.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index 3d5c41cc71..f43d05ad19 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/src/intel/blorp/blorp_clear.c

Re: [Mesa-dev] [PATCH 01/15] i965/miptree: Refactor mapping table alloc

2017-06-13 Thread Nanley Chery
On Tue, Jun 13, 2017 at 05:49:59PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 29 > +-- > 1 file changed, 27 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipma

Re: [Mesa-dev] [PATCH 06/15] i965: Prepare slice validator for isl based miptrees

2017-06-13 Thread Nanley Chery
On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h > b/src/mesa/dr

Re: [Mesa-dev] [PATCH 06/15] i965: Prepare slice validator for isl based miptrees

2017-06-14 Thread Nanley Chery
On Wed, Jun 14, 2017 at 10:36:16AM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 13, 2017 at 05:26:52PM -0700, Nanley Chery wrote: > > On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- >

Re: [Mesa-dev] [PATCH 07/13] anv/blorp: Remove 3D subresource transition workaround

2017-06-14 Thread Nanley Chery
On Wed, Jun 14, 2017 at 09:32:22AM +0200, Iago Toral wrote: > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote: > > For 3D image subresources undergoing a layout transition via > > PipelineBarrier, we increase the number of fast-cleared layers to > > match > >

Re: [Mesa-dev] [PATCH 01/15] i965/miptree: Refactor mapping table alloc

2017-06-14 Thread Nanley Chery
On Wed, Jun 14, 2017 at 09:45:46PM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 13, 2017 at 04:31:26PM -0700, Nanley Chery wrote: > > On Tue, Jun 13, 2017 at 05:49:59PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- >

Re: [Mesa-dev] [PATCH 06/15] i965: Prepare slice validator for isl based miptrees

2017-06-14 Thread Nanley Chery
On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h > b/src/mesa/dr

Re: [Mesa-dev] [PATCH 04/15] i965: Prepare up/downsampling for isl based miptrees

2017-06-14 Thread Nanley Chery
On Tue, Jun 13, 2017 at 05:50:02PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 46 > ++- > 1 file changed, 38 insertions(+), 8 deletions(-) > Patches 2-4 are Reviewed-by: Nan

[Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

2017-10-27 Thread Nanley Chery
nables the driver to pass the arb_texture_view-rendering-formats piglit test. Cc: Signed-off-by: Nanley Chery --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 28 +-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tre

[Mesa-dev] [RFC 1/2] intel/isl: Disable some gen10 CCS_E formats for now

2017-10-27 Thread Nanley Chery
CannonLake additionally supports R11G11B10_FLOAT and four 10-10-10-2 formats with CCS_E. None of these formats fit within the current blorp_copy framework so disable them until support is added. Signed-off-by: Nanley Chery Cc: Jason Ekstrand --- Jason, do you think we modify blorp instead of

Re: [Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

2017-10-27 Thread Nanley Chery
On Fri, Oct 27, 2017 at 12:52:30PM -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery > wrote: > > > Only use CCS_E to render to a texture that is CCS_E-compatible with the > > original texture's miptree (linear) format. This prevents render &

Re: [Mesa-dev] [RFC 1/2] intel/isl: Disable some gen10 CCS_E formats for now

2017-10-27 Thread Nanley Chery
On Fri, Oct 27, 2017 at 12:50:45PM -0700, Jason Ekstrand wrote: > Thanks for doing this in isl_format_supports_ccs_e instead of changing the > table! > > Reviewed-by: Jason Ekstrand > Thank you for the review! > On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery > wro

Re: [Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

2017-10-30 Thread Nanley Chery
On Fri, Oct 27, 2017 at 05:14:16PM -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 3:16 PM, Nanley Chery wrote: > > > On Fri, Oct 27, 2017 at 12:52:30PM -0700, Jason Ekstrand wrote: > > > On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery > > > wrote: > >

Re: [Mesa-dev] [PATCH 3/4] i965/gen10: Enable float blend optimization

2017-10-30 Thread Nanley Chery
On Mon, Oct 02, 2017 at 04:07:59PM -0700, Anuj Phogat wrote: > This optimization is enabled for previous generations too. > See Mesa commit c17e214a6b > On CNL this bit is moved to 3DSTATE_3D_MODE. Is this true? Looking at the HW docs, I actually found this bit to exist in CACHE_MODE_SS. Bit 9 of

Re: [Mesa-dev] [PATCH 4/4] i965/gen10: Implement Wa3DStateMode

2017-10-30 Thread Nanley Chery
On Mon, Oct 02, 2017 at 04:08:00PM -0700, Anuj Phogat wrote: > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_state_upload.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Assuming my comment in patch 3 is correct, we n

Re: [Mesa-dev] [PATCH 4/4] i965/gen10: Implement Wa3DStateMode

2017-10-30 Thread Nanley Chery
On Mon, Oct 30, 2017 at 12:28:53PM -0700, Anuj Phogat wrote: > On Mon, Oct 30, 2017 at 11:08 AM, Nanley Chery wrote: > > On Mon, Oct 02, 2017 at 04:08:00PM -0700, Anuj Phogat wrote: > >> Cc: mesa-sta...@lists.freedesktop.org > >> Signed-off-by: Anuj Phogat > >

Re: [Mesa-dev] [PATCH 2/4] i965/gen10: Implement WaForceRCPFEHangWorkaround

2017-10-30 Thread Nanley Chery
On Mon, Oct 02, 2017 at 04:07:58PM -0700, Anuj Phogat wrote: > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_pipe_control.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_pipe_

Re: [Mesa-dev] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-10-30 Thread Nanley Chery
On Fri, Oct 06, 2017 at 04:30:47PM -0700, Anuj Phogat wrote: > There are few other (duplicate) workarounds which have similar > recommendations: > WaFlushHangWhenNonPipelineStateAndMarkerStalled > WaCSStallBefore3DSamplePattern > WaPipeControlBefore3DStateSamplePattern > > WaPipeControlBefore3DSt

Re: [Mesa-dev] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-10-31 Thread Nanley Chery
On Mon, Oct 30, 2017 at 05:24:10PM -0700, Nanley Chery wrote: > On Fri, Oct 06, 2017 at 04:30:47PM -0700, Anuj Phogat wrote: > > There are few other (duplicate) workarounds which have similar > > recommendations: > > WaFlushHangWhenNonPipeline

Re: [Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

2017-10-31 Thread Nanley Chery
On Tue, Oct 31, 2017 at 02:15:43PM -0700, Jason Ekstrand wrote: > On Mon, Oct 30, 2017 at 10:37 AM, Nanley Chery > wrote: > > > On Fri, Oct 27, 2017 at 05:14:16PM -0700, Jason Ekstrand wrote: > > > On Fri, Oct 27, 2017 at 3:16 PM, Nanley Chery > > wrote: > >

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use format_ccs_compat_with_miptree for textures

2017-11-01 Thread Nanley Chery
On Tue, Oct 31, 2017 at 08:01:05PM -0700, Jason Ekstrand wrote: > This function is a bit more accurate because it lets us sample from sRGB > textures if sRGB decode is off. This should improve performance in ^ ^ missing "with C

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use format_ccs_compat_with_miptree for textures

2017-11-01 Thread Nanley Chery
On Wed, Nov 01, 2017 at 10:58:03AM -0700, Jason Ekstrand wrote: > On Wed, Nov 1, 2017 at 10:46 AM, Nanley Chery wrote: > > > On Tue, Oct 31, 2017 at 08:01:05PM -0700, Jason Ekstrand wrote: > > > This function is a bit more accurate because it lets us sample from sRGB &

Re: [Mesa-dev] [PATCH v2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-11-02 Thread Nanley Chery
on CNL. But it might be fixing something we haven't tested yet. > > V2: Use brw_load_register_imm32() to program CACHE_MODE_0. > Get rid of brw_flush_gpu_caches(). > > Cc: Nanley Chery > Signed-off-by: Anuj Phogat > Reviewed-by: Rafael Antognolli > --- > src/

Re: [Mesa-dev] [PATCH v2 2/4] i965/gen10: Implement WaForceRCPFEHangWorkaround

2017-11-02 Thread Nanley Chery
L. But it might be fixing something we haven't tested yet. > > Cc: Nanley Chery > Signed-off-by: Anuj Phogat > Reviewed-by: Rafael Antognolli > --- > src/mesa/drivers/dri/i965/brw_pipe_control.c | 21 + > 1 file changed, 21 insertions(+) > >

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

2017-11-02 Thread Nanley Chery
CNL. > I haven't seen this format in the git logs before.. > Cc: Nanley Chery > Cc: Jason Ekstrand > Signed-off-by: Anuj Phogat > Reviewed-by: Rafael Antognolli > --- > src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ > src/mesa/drivers/dri/i965/brw_state_upl

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Nanley Chery
On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > This optimization is enabled for previous generations too. > See Mesa commit c17e214a6b > On CNL this bit has been moved to CACHE_MODE_SS register. > > Cc: Nanley Chery > Signed-off-by: Anuj Phogat > --- > s

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

2017-11-03 Thread Nanley Chery
On Thu, Nov 02, 2017 at 06:13:43PM -0700, Matt Turner wrote: > On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote: > > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: > >> V2: Remove the bits enabling Float blend optimization. It is > >> enabled thr

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Nanley Chery
On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote: > On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > > This optimization is enabled for previous generations too. > > See Mesa commit c17e214a6b > > On CNL this bit has been moved to CACHE_MODE_SS

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

2017-11-03 Thread Nanley Chery
On Fri, Nov 03, 2017 at 09:50:41AM -0700, Nanley Chery wrote: > On Thu, Nov 02, 2017 at 06:13:43PM -0700, Matt Turner wrote: > > On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote: > > > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: > > >> V2: Remove

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Nanley Chery
On Fri, Nov 03, 2017 at 11:39:34AM -0700, Anuj Phogat wrote: > On Fri, Nov 3, 2017 at 9:46 AM, Nanley Chery wrote: > > On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > >> This optimization is enabled for previous generations too. > >> See Mesa commit c17e

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Nanley Chery
On Fri, Nov 03, 2017 at 11:50:44AM -0700, Anuj Phogat wrote: > On Fri, Nov 3, 2017 at 11:05 AM, Nanley Chery wrote: > > On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote: > >> On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > >> > This optimi

Re: [Mesa-dev] [PATCH v3 08/16] anv: Transition more color buffer layouts

2017-07-14 Thread Nanley Chery
On Mon, Jul 10, 2017 at 10:14:21AM -0700, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > > > v2: Expound on comment for the pipe controls (Jason Ekstrand). > > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_b

Re: [Mesa-dev] [PATCH v3 08/16] anv: Transition more color buffer layouts

2017-07-18 Thread Nanley Chery
On Mon, Jul 17, 2017 at 02:41:32PM -0700, Jason Ekstrand wrote: > On Fri, Jul 14, 2017 at 2:42 AM, Nanley Chery wrote: > > > On Mon, Jul 10, 2017 at 10:14:21AM -0700, Jason Ekstrand wrote: > > > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery > > wrote: > > >

[Mesa-dev] [PATCH v4 01/18] anv: Transition MCS buffers from the undefined layout

2017-07-19 Thread Nanley Chery
Cc: Suggested-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 8 src/intel/vulkan/anv_private.h | 8 src/intel/vulkan/genX_cmd_buffer.c | 25 +++-- 3 files changed, 23 insertions(+), 18 deletions(-) diff --git

[Mesa-dev] [PATCH v4 04/18] anv/image: Append CCS/MCS with a fast-clear state buffer

2017-07-19 Thread Nanley Chery
v2: Update comments, function signatures, and add assertions. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 78 ++ src/intel/vulkan/anv_private.h | 12 +++ 2 files changed, 90 insertions(+) diff --git a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH v4 03/18] anv/image: Disable CCS if the image doesn't support rendering

2017-07-19 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 4f0057c952..f33a445d1d 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH v4 00/18] anv: Do CCS resolves at layout transitions

2017-07-19 Thread Nanley Chery
bpass resolves with multisampled images ignored CCS_D. * the Haswell boxes in jenkins start to GPU hang, but the don't do so on my local machine. Nanley Chery (18): anv: Transition MCS buffers from the undefined layout intel/isl: Add surface state clear value information anv/image: Disable

<    2   3   4   5   6   7   8   9   10   11   >