On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote:
> On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote:
> > This optimization is enabled for previous generations too.
> > See Mesa commit c17e214a6b
> > On CNL this bit has been moved to CACHE_MODE_SS register.
> >
> > Cc: Nanley Chery <nanley.g.ch...@intel.com>
> > Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com>
> > ---
> > src/mesa/drivers/dri/i965/brw_defines.h | 3 +++
> > src/mesa/drivers/dri/i965/brw_state_upload.c | 6 ++++++
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_defines.h
> > b/src/mesa/drivers/dri/i965/brw_defines.h
> > index 270cdf29db..3008a1b8a7 100644
> > --- a/src/mesa/drivers/dri/i965/brw_defines.h
> > +++ b/src/mesa/drivers/dri/i965/brw_defines.h
> > @@ -1688,6 +1688,9 @@ enum brw_pixel_shader_coverage_mask_mode {
> > # define GEN8_L3CNTLREG_ALL_ALLOC_SHIFT 25
> > # define GEN8_L3CNTLREG_ALL_ALLOC_MASK INTEL_MASK(31, 25)
> >
> > +#define GEN10_CACHE_MODE_SS 0x0e420
> > +# define GEN10_FLOAT_BLEND_OPTIMIZATION_ENABLE (1 << 4)
> ^
> extra space
> > +
>
> GEN10_FLOAT_BLEND_OPTIMIZATION_ENABLE has the same value as
> GEN9_FLOAT_BLEND_OPTIMIZATION_ENABLE. This seems like something we'd
> normally reeuse.
>
> > #define INSTPM 0x20c0
> > # define INSTPM_CONSTANT_BUFFER_ADDRESS_OFFSET_DISABLE (1 << 6)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c
> > b/src/mesa/drivers/dri/i965/brw_state_upload.c
> > index 23e4ebda25..7df06a6e4d 100644
> > --- a/src/mesa/drivers/dri/i965/brw_state_upload.c
> > +++ b/src/mesa/drivers/dri/i965/brw_state_upload.c
> > @@ -85,6 +85,12 @@ brw_upload_initial_gpu_state(struct brw_context *brw)
> > }
> > }
> >
> > + if (devinfo->gen == 10) {
> > + brw_load_register_imm32(brw, GEN10_CACHE_MODE_SS,
> > +
> > REG_MASK(GEN10_FLOAT_BLEND_OPTIMIZATION_ENABLE) |
> > + GEN10_FLOAT_BLEND_OPTIMIZATION_ENABLE);
> > + }
> > +
I forgot to send this bit of feedback: Maybe move this hunk above the
gen9 hunk? This function seems to be ordered in reverse chronological
order as much as possible.
> > if (devinfo->gen >= 8) {
> > gen8_emit_3dstate_sample_pattern(brw);
> >
> > --
> > 2.13.5
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
