From: Nanley Chery
Combine the adjacent cases which have the same GL type in the switch statemnt.
Signed-off-by: Nanley Chery
---
src/mesa/main/formats.c | 152 ++--
1 file changed, 17 insertions(+), 135 deletions(-)
diff --git a/src/mesa/main
From: Nanley Chery
Only uncompressed formats have a non-void type and actual components per pixel.
Rename _mesa_format_to_type_and_comps to
_mesa_uncompressed_format_to_type_and_comps and require callers to check if
the format is not compressed.
Cc: Jason Ekstrand
Signed-off-by: Nanley Chery
From: Nanley Chery
In agreement with the ASTC spec, this makes calls to TexImage*D unsuccessful.
Implied by the spec, Generate[Texture]Mipmap and [Copy]TexSubImage*D calls
must be unsuccessful as well.
v2. actually force attempts to compress online to fail.
Signed-off-by: Nanley Chery
From: Nanley Chery
The ASTC spec was revised as follows:
Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to
commands accepting ASTC format tokens in the New Tokens section [...].
Support only exists in the HDR submode:
Add a second new column "3D Tex." whic
On Tue, Aug 11, 2015 at 4:16 PM, Ilia Mirkin wrote:
> On Tue, Aug 11, 2015 at 7:07 PM, Nanley Chery
> wrote:
> > From: Nanley Chery
> >
> > Add the classes of compressed formats as layouts. This will make
> determining if
> > a texture is an ASTC format si
From: Nanley Chery
Add the classes of compressed formats as layouts. This will make determining if
a texture is an ASTC format simpler.
v2. simplify layout name construction (Ilia).
Cc: Jason Ekstrand
Signed-off-by: Nanley Chery
---
src/mesa/main/format_info.py | 10 +-
src/mesa
From: Nanley Chery
In agreement with the ASTC spec, this makes calls to TexImage*D unsuccessful.
Implied by the spec, Generate[Texture]Mipmap and [Copy]TexSubImage*D calls
must be unsuccessful as well.
v2. actually force attempts to compress online to fail.
v3. indentation (Matt).
Signed-off
This patch is a followup on this:
http://lists.freedesktop.org/archives/mesa-dev/2015-June/087055.html
On Tue, Aug 11, 2015 at 4:54 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> In agreement with the ASTC spec, this makes calls to TexImage*D
> unsuccessful.
> Implied by the
From: Nanley Chery
This function would always report that a dimension or size error occurred
in glTexImage even when it was called from glCompressedTexImage. Replace
the static string with the dynamically determined caller name.
Signed-off-by: Nanley Chery
---
src/mesa/main/teximage.c | 8
ue, Aug 11, 2015 at 4:53 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> Add the classes of compressed formats as layouts. This will make
> determining if
> a texture is an ASTC format simpler.
>
> v2. simplify layout name construction (Ilia).
>
> Cc: Jason Ek
From: Nanley Chery
This function's cases for non-generic compressed formats duplicate
the GL to MESA translation in _mesa_glenum_to_compressed_format().
This patch replaces the switch cases with a call to the translation
function. There are no behavioral changes except for the RGB[A]4 fo
From: Nanley Chery
The ASTC spec was revised as follows:
Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to
commands accepting ASTC format tokens in the New Tokens section [...].
Support only exists in the HDR submode:
Add a second new column "3D Tex." whic
The last line of the commit message should say:
GL_RGBA4_S3TC (0x83A3) -> COMPRESSED_RGBA_S3TC_DXT5_EXT (0x83F3)
On Wed, Aug 12, 2015 at 4:19 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> This function's cases for non-generic compressed formats duplicate
> the GL
On Fri, Aug 14, 2015 at 4:00 PM, Chad Versace
wrote:
> On Tue 11 Aug 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Only uncompressed formats have a non-void type and actual components per
> pixel.
> > Rename _me
Cc'ing Brian.
I'm planning to make a patch to implement the first (3-step) solution.
On Mon, Aug 17, 2015 at 3:45 PM, Nanley Chery wrote:
>
> On Fri, Aug 14, 2015 at 4:00 PM, Chad Versace
> wrote:
>
>> On Tue 11 Aug 2015, Nanley Chery wrote:
>> &g
From: Nanley Chery
Only uncompressed formats have a non-void type and actual components per pixel.
Rename _mesa_format_to_type_and_comps to
_mesa_uncompressed_format_to_type_and_comps and require callers to check if
the format is not compressed.
v2. include compressed format cases to avoid gcc
From: Nanley Chery
We currently check that our format info table is sane during context
initialization in debug builds. Perform this check during
`make check` instead. This enables format testing in release builds
and removes the requirement of an exhuastive switch for
From: Nanley Chery
All compressed formats return GL_FALSE and there isn't any evidence to
support that this behaviour would change. Remove all switch cases for
compressed formats.
v2. Since the exhaustive switch is removed, add a gtest to ensure
all formats are handled.
Cc: Brian Pau
On Fri, Aug 14, 2015 at 4:09 PM, Chad Versace
wrote:
> On Tue 11 Aug 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Combine the adjacent cases which have the same GL type in the switch
> statemnt.
> >
> > Signed-off-by: Nanley Chery
> &
Agreed. I've updated the patch. Thanks.
On Mon, Aug 17, 2015 at 11:39 AM, Chad Versace
wrote:
> On Tue 11 Aug 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > In agreement with the ASTC spec, this makes calls to TexImage*D
> unsuccessful.
> > Im
On Mon, Aug 17, 2015 at 11:54 AM, Chad Versace
wrote:
> On Tue 28 Jul 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > According to the spec, Tex*Storage* commands are supported if the GL
> > implementation has support for immutable textures.
> >
From: Nanley Chery
All compressed formats return GL_FALSE and there isn't any evidence to
support that this behaviour would change. Remove all switch cases for
compressed formats.
v2. Since the exhaustive switch is removed, add a gtest to ensure
all formats are handled.
v3. Ensure
On Thu, Aug 20, 2015 at 11:34 AM, Emil Velikov
wrote:
> 2015-08-12 0:07 GMT+01:00 Nanley Chery :
> > From: Nanley Chery
> >
> > Combine the adjacent cases which have the same GL type in the switch
> statemnt.
> >
> > Signed-off-by: Nanley Chery
> &
On Fri, Aug 21, 2015 at 2:12 PM, Chad Versace
wrote:
> On Wed 19 Aug 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > We currently check that our format info table is sane during context
> > initialization in debug builds. Perform this check during
> > `
Thanks for pointing out these errors. I'll fix them in the next version.
On Fri, Aug 21, 2015 at 2:34 PM, Chad Versace
wrote:
> On Wed 19 Aug 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > All compressed formats return GL_FALSE and there isn't any ev
From: Nanley Chery
We currently check that our format info table is sane during context
initialization in debug builds. Perform this check during
`make check` instead. This enables format testing in release builds
and removes the requirement of an exhuastive switch for
From: Nanley Chery
All compressed formats return GL_FALSE and there isn't any evidence to
support that this behaviour would change. Remove all switch cases for
compressed formats.
v2. Since the exhaustive switch is removed, add a gtest to ensure
all formats are handled.
v3. Ensure
On Thu, Aug 20, 2015 at 3:52 PM, Nanley Chery wrote:
> On Thu, Aug 20, 2015 at 11:34 AM, Emil Velikov
> wrote:
>
>> 2015-08-12 0:07 GMT+01:00 Nanley Chery :
>> > From: Nanley Chery
>> >
>> > Combine the adjacent cases which have the same GL type in th
On Tue, Aug 25, 2015 at 7:42 AM, Emil Velikov
wrote:
> Hi Nanley,
>
> On 24 August 2015 at 23:49, Nanley Chery wrote:
> > On Thu, Aug 20, 2015 at 3:52 PM, Nanley Chery
> wrote:
> >>
> >> On Thu, Aug 20, 2015 at 11:34 AM, Emil Velikov <
> emil.l.veli.
From: Nanley Chery
The ASTC spec was revised as follows:
Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to
commands accepting ASTC format tokens in the New Tokens section [...].
Support only exists in the HDR submode:
Add a second new column "3D Tex." whic
From: Nanley Chery
Enables _mesa_target_can_be_compressed to return the appropriate GL error
depending on it's inputs. Use the parameter to return the appropriate GL error
for ETC2 formats on GLES3.
Suggested-by: Chad Versace
Signed-off-by: Nanley Chery
---
src/mesa/main/teximage.c
I'm planning to send out a v6 to fix an issue w/ a not-yet-upstreamed
piglit test I've developed for ASTC.
On Tue, Aug 25, 2015 at 1:00 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> The ASTC spec was revised as follows:
>
>Revision 2, April 28, 2015 - added Comp
From: Nanley Chery
The ASTC spec was revised as follows:
Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to
commands accepting ASTC format tokens in the New Tokens section [...].
Support only exists in the HDR submode:
Add a second new column "3D Tex." whic
On Tue, Aug 25, 2015 at 5:38 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> commit 26c549e69d12e44e2e36c09764ce2cceab262a1b
> Author: Nanley Chery
> Date: Fri Jul 31 10:26:36 2015 -0700
>
> mesa/formats: remove compressed formats from matching function
>
> ca
On Tue, Aug 25, 2015 at 8:38 PM, Nanley Chery wrote:
>
>
> On Tue, Aug 25, 2015 at 5:38 PM, Dave Airlie wrote:
>
>> From: Dave Airlie
>>
>> commit 26c549e69d12e44e2e36c09764ce2cceab262a1b
>> Author: Nanley Chery
>> Date: Fri Jul 31 10:26:36
On Tue, Aug 25, 2015 at 4:19 PM, Chad Versace
wrote:
> On Sun 16 Aug 2015, Nanley Chery wrote:
> > The last line of the commit message should say:
> >
> >GL_RGBA4_S3TC (0x83A3) -> COMPRESSED_RGBA_S3TC_DXT5_EXT (0x83F3)
>
> There's another weird line t
From: Nanley Chery
This function's cases for non-generic compressed formats duplicate
the GL to MESA translation in _mesa_glenum_to_compressed_format().
This patch replaces the switch cases with a call to the translation
function.
Cc: Brian Paul
Cc: Chad Versace
Cc: Ian Romanick
Signe
From: Nanley Chery
MESA_FORMAT_RGBA_DXT5 should actually be reserved for GL_RGBA[4]_DXT5_S3TC.
Also, Gallium and other dri drivers (radeon and nouveau) follow this mapping
scheme.
Cc: Brian Paul
Cc: Chad Versace
Cc: Ian Romanick
Signed-off-by: Nanley Chery
---
src/mesa/main/texcompress.c
I should add that this patch enables this function to handle ASTC formats.
This in turn enables such formats to be used for GL calls such as
Tex*Storage*.
- Nanley
On Wed, Aug 26, 2015 at 2:38 PM, Nanley Chery wrote:
> From: Nanley Chery
>
> This function's cases for non-gene
From: Nanley Chery
According to the extensions table and our glext headers, these
extensions are only supported in the core and compatibility
profiles of desktop GL.
Signed-off-by: Nanley Chery
---
src/mesa/main/glformats.c | 4 ++--
src/mesa/main/teximage.c | 6 --
2 files changed, 6
From: Nanley Chery
This enables us to predicate statments on a compressed format being
a type of LATC format. Also, remove the comment that lists the enum
(which was getting a tad long).
Signed-off-by: Nanley Chery
---
src/mesa/main/format_info.py | 2 +-
src/mesa/main/formats.c | 11
From: Nanley Chery
Instead of case statements, use _mesa_get_format_layout() to
determine if a GL format is part of a family of compressed formats.
Signed-off-by: Nanley Chery
---
src/mesa/main/glformats.c | 119 --
1 file changed, 40 insertions
From: Nanley Chery
Reuse utility functions instead of reimplementing the same logic.
* _mesa_is_compressed_format() performs the required checking to
determine format support in the current context.
* _mesa_gl_compressed_format_base_format() returns the base format.
Signed-off-by: Nanley
From: Nanley Chery
According to the extensions table and our glext headers,
OES_compressed_ETC1_RGB8_texture is only supported in
GLES1 and GLES2.
Signed-off-by: Nanley Chery
---
src/mesa/main/teximage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main
From: Nanley Chery
Adds S3TC and PALETTE formats.
Signed-off-by: Nanley Chery
---
src/mesa/main/texcompress.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/mesa/main/texcompress.c b/src/mesa/main/texcompress.c
index e0294a8..84973d3 100644
--- a/src/mesa/main
From: Nanley Chery
Catches all specific, non-palettized compressed formats as color
formats. This enables ASTC to be recognized as one such format type.
Signed-off-by: Nanley Chery
---
src/mesa/main/glformats.c | 44 +---
1 file changed, 5 insertions
From: Nanley Chery
Determines if a compressed format is non-palettized and specific.
Signed-off-by: Nanley Chery
---
src/mesa/main/texcompress.c | 10 ++
src/mesa/main/texcompress.h | 3 +++
2 files changed, 13 insertions(+)
diff --git a/src/mesa/main/texcompress.c b/src/mesa/main
From: Nanley Chery
Add modifications necessary to get ASTC functional on Cherryview.
Cc: Chad Versace
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/brw_defines.h| 1 +
src/mesa/drivers/dri/i965/brw_tex_layout.c | 55 +++---
src/mesa/drivers/dri
On Mon, Aug 31, 2015 at 4:58 PM, Matt Turner wrote:
> On Mon, Aug 31, 2015 at 4:45 PM, Nanley Chery
> wrote:
> > From: Nanley Chery
> >
> > Add modifications necessary to get ASTC functional on Cherryview.
> >
> > Cc: Chad Versace
> > Signed-off-by: N
On Mon, Aug 31, 2015 at 5:16 PM, Matt Turner wrote:
> On Mon, Aug 31, 2015 at 5:02 PM, Nanley Chery
> wrote:
> > On Mon, Aug 31, 2015 at 4:58 PM, Matt Turner wrote:
> >> (what's this patch against? I don't have this in my tree)
> >
> >
> >
On Wed, Sep 07, 2016 at 03:51:14PM -0700, Chad Versace wrote:
> On Wed 07 Sep 2016, Nanley Chery wrote:
> > On Fri, Sep 02, 2016 at 11:42:24AM -0700, Chad Versace wrote:
> > > On Thu 01 Sep 2016, Jason Ekstrand wrote:
> > > > On Wed, Aug 31, 2016 at 8:29 PM
On Mon, Sep 12, 2016 at 05:58:20PM -0700, Jason Ekstrand wrote:
> Compressed 1-D textures are a well-defined thing in both GL and Vulkan.
> ---
> src/intel/isl/isl.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index a75
On Fri, Sep 02, 2016 at 05:01:28PM -0700, Jason Ekstrand wrote:
> On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote:
>
> > From: Jason Ekstrand
> >
>
> First off, this is your patch not mine. The patch of mine you based this
> on was little more than a skeleton t
On Fri, Sep 02, 2016 at 05:12:58PM -0700, Jason Ekstrand wrote:
> On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote:
>
> > Provides an FPS increase of ~30% on the Sascha triangle and multisampling
> > demos.
> >
> > Clears that happen within a render pass via
On Fri, Sep 02, 2016 at 03:16:21PM -0700, Chad Versace wrote:
> On Wed 31 Aug 2016, Nanley Chery wrote:
> > From: Chad Versace
> >
> > Nanley Chery:
> > (rebase)
> > - Resolve conflicts with new anv_batch_emit macro
> > (amend)
> > - Remove
On Fri, Sep 02, 2016 at 05:27:11PM -0700, Jason Ekstrand wrote:
> On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote:
>
> > This series enables Hierarchical depth buffer rendering and fast depth
> > clears
> > for render passes with a single subpass running on platf
On Fri, Sep 02, 2016 at 12:46:30PM -0700, Chad Versace wrote:
> On Thu 01 Sep 2016, Jason Ekstrand wrote:
> >
> >
> > On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote:
> >
> > From: Jason Ekstrand
> >
> > Nanley Chery (amend):
>
Is this to avoid needless computation?
If an app copies such an image, that's likely an app bug right?
On Wed, Sep 21, 2016 at 11:17:08AM -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/intel/vulkan/anv_blorp.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp.c | 8
src/intel/blorp/blorp.h | 9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/intel/blorp/blorp.c b/src/intel/blorp/blorp.c
index 1c8fd55..e5dcf0a 100644
--- a/src/intel/blorp/blorp.c
+++ b/src
Use the vertex positions described in the PRMs. This has no effect on
rendering but quiets the simulator warnings seen when the vertices
appear out of order.
Signed-off-by: Nanley Chery
Cc: Jason Ekstrand
Cc: Marek Olšák
---
src/intel/blorp/blorp_genX_exec.h | 6 +++---
1 file changed, 3
Change SUFFACE to SURFACE.
Signed-off-by: Nanley Chery
---
src/intel/isl/isl_surface_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl_surface_state.c
b/src/intel/isl/isl_surface_state.c
index e18fa50..4ed177a 100644
--- a/src/intel/isl
On Wed, Sep 21, 2016 at 10:31:05PM -0700, Kenneth Graunke wrote:
> Needed for user clip plane enables. Brkoen since this code was
^^
Broken
-Nanley
> introduced.
>
> Cc: mesa-sta...@lists.freedesktop.org
> Signed-of
On Wed, Sep 14, 2016 at 01:28:23PM -0700, Jason Ekstrand wrote:
> Compressed 1-D textures are a well-defined thing in both GL and Vulkan.
Could you provide a reference? I could not find any documentation on 1D
compressed textures. Instead I found that OpenGL disallows them and
Vulkan does not expl
On Thu, Sep 22, 2016 at 02:12:08PM -0700, Jason Ekstrand wrote:
> On Sep 22, 2016 11:11 PM, "Nanley Chery" wrote:
> >
> > On Wed, Sep 14, 2016 at 01:28:23PM -0700, Jason Ekstrand wrote:
> > > Compressed 1-D textures are a well-defined thing in both GL and V
Signed-off-by: Nanley Chery
---
src/intel/isl/isl_gen7.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c
index 4f1cc9d..36a3401 100644
--- a/src/intel/isl/isl_gen7.c
+++ b/src/intel/isl/isl_gen7.c
@@ -231,6 +231,12
This series prevents invalid compressed textures from being created in
the Vulkan driver. There aren't any Vulkan CTS tests for 1D compressed
textures, so no change has been observed in that test suite.
Nanley Chery (3):
isl: Only allow Y-tiling for ASTC textures
anv/formats: Disallow l
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_formats.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index 701add5..accf45c 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/src/intel/vulkan/anv_formats.c
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_formats.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index ff59f47..701add5 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/src/intel/vulkan/anv_formats.c
@@ -408,6
On Fri, Sep 23, 2016 at 12:17:19AM -0700, Jason Ekstrand wrote:
> Compressed 1-D textures are not well-defined thing in either GL or Vulkan.
> However, auxiliary surfaces are treated as compressed textures in ISL and
> we can do HiZ and CCS with 1-D so we need to be able to create them. In
> order
On Mon, Sep 12, 2016 at 05:58:18PM -0700, Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand
> Reviewed-by: Chad Versace
> ---
This patch is,
Reviewed-by: Nanley Chery
> src/intel/isl/isl.h| 2 ++
> src/intel/isl/isl_format.c | 28
&
nt
> to assert that it has a block size of 1x1 since we do nothing with the
> block size in the phys_level0_sa assignment.
>
> Signed-off-by: Jason Ekstrand
> Reviewed-by: Topi Pohjolainen
> Reviewed-by: Chad Versace
> ---
This patch is,
Reviewed-by: Nanley Chery
> sr
On Mon, Sep 12, 2016 at 05:58:21PM -0700, Jason Ekstrand wrote:
> HiZ buffers can be multisampled and, on BDW+, simply using interleaved
As stated in your comment in the second-to-last hunk, this is actually
true for all platforms pre-SKL.
> multisampling with a compression block size of 8x4 samp
causing us to
> outright reject multisampled HiZ surfaces which wasn't intended.
>
> Signed-off-by: Jason Ekstrand
> Reviewed-by: Chad Versace
> ---
This patch is,
Reviewed-by: Nanley Chery
> src/intel/isl/isl_gen7.c | 10 +++---
> src/intel/isl/isl_gen8.c | 11 -
we just handle them
> directly.
>
> Signed-off-by: Jason Ekstrand
> Reviewed-by: Topi Pohjolainen
> Reviewed-by: Chad Versace
> ---
This patch is,
Reviewed-by: Nanley Chery
> src/intel/isl/isl.c | 18 --
> src/intel/isl/isl_gen7.c | 14
On Mon, Sep 26, 2016 at 10:22:43AM -0700, Anuj Phogat wrote:
> V2: Move the check from copy_buffer_to_image() to blorp_copy(). (Nanley)
>
> Signed-off-by: Anuj Phogat
> Cc: Nanley Chery
> ---
This patch is
Reviewed-by: Nanley Chery
> src/intel/blorp/blorp_blit.c | 5 -
On Sun, Sep 25, 2016 at 09:59:00AM -0700, Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand
> ---
> src/intel/vulkan/anv_blorp.c | 106 +
> src/intel/vulkan/anv_meta_clear.c | 120
> --
> 2 files changed, 96 insertions(
-
> 1 file changed, 28 insertions(+), 56 deletions(-)
This patch is
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/vulkan/anv_meta_clear.c
> b/src/intel/vulkan/anv_meta_clear.c
> index 5579454..11b471f 100644
> --- a/src/intel/vulkan/anv_meta_clear.c
> +++ b/src/intel/
These values are the same. Avoid the extra computation.
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp_blit.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c
index af46389..1c878e8 100644
--- a/src
On Mon, Sep 26, 2016 at 12:12:32PM -0700, Jason Ekstrand wrote:
> On Sep 26, 2016 11:16 AM, "Nanley Chery" wrote:
> >
> > On Sun, Sep 25, 2016 at 09:59:00AM -0700, Jason Ekstrand wrote:
> > > Signed-off-by: Jason Ekstrand
> > > ---
>
From: Nanley Chery
These values are the same. Avoid the extra computation.
Signed-off-by: Nanley Chery
---
v2: Add a sample count assertion (Jason)
src/intel/blorp/blorp_blit.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/intel/blorp/blorp_blit.c b/src
On Mon, Sep 19, 2016 at 01:49:09PM -0700, Nanley Chery wrote:
> On Fri, Sep 02, 2016 at 03:16:21PM -0700, Chad Versace wrote:
> > On Wed 31 Aug 2016, Nanley Chery wrote:
> > > From: Chad Versace
> > >
> > > Nanley Chery:
> > > (rebase)
> > &
tch is
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index ee5330e..749d228 100644
> --- a/src/intel/isl/isl.c
> +++ b/src/intel/isl/isl.c
> @@ -1288,6 +1288,63 @@ isl_surf_get_hiz_surf(const struct isl_device *dev,
> assert(su
From: Nanley Chery
HiZ is not a color surface, but an auxiliary depth surface.
Signed-off-by: Nanley Chery
Reviewed-by: Chad Versace
Reviewed-by: Jason Ekstrand
---
src/intel/isl/isl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl.h b/src/intel/isl
From: Chad Versace
Unused.
Signed-off-by: Nanley Chery
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/anv_private.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 443c31f..7e08786 100644
--- a/src/intel/vulkan
anv_image::hiz_surface
anv: Add func anv_image_has_hiz()
anv: Allocate hiz surface
genX/cmd_buffer: Enable rendering to HiZ
Jason Ekstrand (2):
anv: Move BindImageMemory to anv_image.c
anv/image: Memset hiz surfaces to 0 when binding memory
Nanley Chery (5):
isl: Correct a comment in the
From: Nanley Chery
Modify extents and dimensions to match the PRMs more closely. Along with
being able to create the correct 3D surface this enables us to avoid working
with multisampled compressed textures.
Signed-off-by: Nanley Chery
Reviewed-by: Chad Versace
---
Note: This patch will have
From: Chad Versace
Nanley Chery:
(rebase)
- Resolve conflicts with new anv_batch_emit macro
(amend)
- Handle a QPitch TODO
- Emit 3DSTATE_HIER_DEPTH_BUFFER on pre-BDW systems
- Only use HiZ for single-subpass renderpasses
- Emit the HiZ instruction before the stencil instruction to follow
Create a function that performs one of three HiZ operations -
depth/stencil clears, HiZ resolve, and depth resolves.
Signed-off-by: Nanley Chery
---
v2. Add documentation
Fix the alignment check
Don't minify clear rectangle (Jason)
Use blorp enums (Jason)
Enable depth s
From: Chad Versace
Nanley Chery:
(rebase)
- Use isl_surf_get_hiz_surf()
(amend)
- Only add a HiZ surface onto a depth/stencil attachment
- Add comment above HiZ surface addition
- Hide HiZ behind INTEL_VK_HIZ prior to BDW
- Disable HiZ for untested cases
- Remove DISABLE_AUX_BIT instead of
From: Nanley Chery
Signed-off-by: Nanley Chery
---
v2. Add untested HiZ cases
src/intel/vulkan/TODO | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO
index 8fac370..9ac63eb 100644
--- a/src/intel/vulkan/TODO
+++ b/src/intel
From: Chad Versace
Signed-off-by: Nanley Chery
Reviewed-by: Jason Ekstrand
---
v2. Check aspect instead of usage (Chad, Jason)
src/intel/vulkan/anv_private.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
From: Jason Ekstrand
Nanley Chery (amend):
- Change memset value from 0xff to 0 (a defined value for HiZ).
Signed-off-by: Nanley Chery
---
v2. Add asserts (Jason)
Handle NULL return value of the mmap
src/intel/vulkan/anv_image.c | 31 ++-
1 file changed, 30
From: Jason Ekstrand
Signed-off-by: Nanley Chery
Reviewed-by: Chad Versace
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/anv_device.c | 20
src/intel/vulkan/anv_image.c | 20
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/src
From: Nanley Chery
Provides an FPS increase of ~30% on the Sascha triangle and multisampling
demos.
Clears that happen within a render pass via vkCmdClearAttachments are safe
even if the clear color changes. This is because the meta implementation does
not use LOAD_OP_CLEAR which avoids any
+), 3 deletions(-)
This patch is
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index a75fddf..185984d 100644
> --- a/src/intel/isl/isl.c
> +++ b/src/intel/isl/isl.c
> @@ -518,7 +518,6 @@ isl_calc_phys_level0_extent_sa(const struct is
ce
> ---
> src/intel/isl/isl.c| 4 +++-
> src/intel/isl/isl_format.c | 11 +--
> 2 files changed, 12 insertions(+), 3 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index 185984d..33d7079 100644
&g
On Tue, Sep 27, 2016 at 09:22:05AM -0700, Jason Ekstrand wrote:
> ---
> src/intel/isl/isl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index 749d228..9735
On Tue, Sep 27, 2016 at 11:00:06AM -0700, Chad Versace wrote:
> On Mon 26 Sep 2016, Nanley Chery wrote:
> > From: Chad Versace
> >
> > Nanley Chery:
> > (rebase)
> > - Resolve conflicts with new anv_batch_emit macro
> > (amend)
> > - Handle a QPit
On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote:
> On Mon 26 Sep 2016, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Provides an FPS increase of ~30% on the Sascha triangle and multisampling
> > demos.
> >
> > Clears that happen within
On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote:
> On Tue 27 Sep 2016, Nanley Chery wrote:
> > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote:
>
> > > As a consequence of that reasoning, we should set
> > > 3DSTATE_CLEAR_PARAMS.DepthClear
201 - 300 of 1409 matches
Mail list logo
