Re: [Mesa-dev] Gallium ARB_get_program_binary support

2017-12-12 Thread Mike Lothian
Game works fine, not sure if it's using the extension or not On Mon, 11 Dec 2017 at 23:21 Mike Lothian wrote: > I'll check that when I'm next home > > On Mon, 11 Dec 2017 at 21:19 Timothy Arceri wrote: > >> On 12/12/17 08:13, Mike Lothian wrote: >> &g

Re: [Mesa-dev] Initial release of AMD Open Source Driver for Vulkan

2017-12-22 Thread Mike Lothian
Congratulations on getting this out the door It didn't compile for me without these changes: In pal: diff --git a/src/util/math.cpp b/src/util/math.cpp index 46e9ede..3af4259 100644 --- a/src/util/math.cpp +++ b/src/util/math.cpp @@ -54,7 +54,7 @@ static uint32 Float32ToFloatN(float f, const NBi

Re: [Mesa-dev] Initial release of AMD Open Source Driver for Vulkan

2017-12-22 Thread Mike Lothian
rds, > David > > > On Dec 22, 2017, at 9:48 PM, Mike Lothian wrote: > > Congratulations on getting this out the door > > It didn't compile for me without these changes: > > In pal: > > diff --git a/src/util/math.cpp b/src/util/math.cpp > index 46e9ede.

Re: [Mesa-dev] Vulkan extensions

2017-09-17 Thread Mike Lothian
Maybe you could use the hardware feature list and have an extra option of unsupported, for the hardware that cannot do that feature and not include that in the percentages On Fri, 15 Sep 2017, 12:19 am Bas Nieuwenhuizen wrote: > On Fri, Sep 15, 2017 at 1:18 AM, Dave Airlie wrote: > > On 15 Sept

Re: [Mesa-dev] [PATCH 00/16] RadeonSI micro-optimizations

2017-10-13 Thread Mike Lothian
Hi Have you ran any benchmarks against these? Cheers Mike On Fri, 13 Oct 2017 at 13:04 Marek Olšák wrote: > Hi, > > This series: > - switches IB placement to GTT WC > - uses SPI_SHADER_USER_DATA_COMMON on GFX9 > - combines setting of 2 per-stage descriptor pointers into 1 SET_SH_REG > packet

Re: [Mesa-dev] [PATCH 123/140] radeonsi/gfx9: set/validate GFX9 BO metadata

2017-03-30 Thread Mike Lothian
This patch gives me a warning /var/tmp/portage/media-libs/mesa-/work/mesa-/src/gallium/drivers/radeon/r600_texture.c: In function ‘r600_texture_from_handle’: /var/tmp/portage/media-libs/mesa-/work/mesa-/src/gallium/drivers/radeon/r600_texture.c:1441:28: warning: unused variable ‘gf

Re: [Mesa-dev] [PATCH 000/140] RadeonSI: Initial Vega10 support

2017-03-30 Thread Mike Lothian
I get warnings with patch 058/140 /var/tmp/portage/media-libs/mesa-/work/mesa-/src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h:39:7: warning: type 'union GB_ADDR_CONFIG' violates the C++ One Definition Rule [-Wodr] union GB_ADDR_CONFIG { ^ /var/tmp/portage/media-libs/mesa-/work/mes

Re: [Mesa-dev] [RFC] radv initial tessellation support

2017-03-30 Thread Mike Lothian
I tried running the tessellation demo from Sacha Williams on my Tonga and I got the following error: vulkantessellation: /var/tmp/portage/sys-devel/llvm-/work/llvm-/include/llvm/Support/Casting.h:95: static bool llvm::isa_impl_cl::doit(const From *) [To = llvm::Constant, From = const llvm:

Re: [Mesa-dev] [PATCH 1/2] intel: genxml: compress all gen files into one

2017-03-30 Thread Mike Lothian
This prevents me building master PYTHONPATH=/var/tmp/portage/media-libs/mesa-/work/mesa-/src/compiler/nir /usr/bin/python2.7 /var/tmp/portage/media-libs/mesa-/work/mesa-/src/intel/compiler/brw_nir_trig_workarounds.py > compiler/brw_nir_trig_workarounds.c || (rm -f compi ler/brw_n

Re: [Mesa-dev] [rfc] radv missing tesseellation patches

2017-03-30 Thread Mike Lothian
That gets both tessellation and terraintessellation demos working for me Feel free to add my tested by for the series On Fri, 31 Mar 2017 at 01:45 Dave Airlie wrote: > I somehow in my rebasing lost two patches, not sure where I ate them. > > Anyways slot these in as patch 24.1 and 24.2 before t

Re: [Mesa-dev] [PATCH 00/15] Clang compiler warning fixes

2017-04-11 Thread Mike Lothian
When trying to test these I notice that even without the patches clover isn't compiling /var/tmp/portage/media-libs/mesa-/work/mesa-/src/gallium/state_trackers/clover/llvm/codegen/common.cpp:132:54: error: ‘Offset’ is not a member of ‘clang::LangAS’

[Mesa-dev] [PATCH 2/2] radv/meta: Fix nir_builder.h include

2017-04-18 Thread Mike Lothian
This fixes the build after: commit 399ebd2a84a133bd2ca3da388a059fd3bafe33f5 Author: Dave Airlie Date: Wed Apr 19 06:18:23 2017 +1000 radv/meta: add common shader vertex generation function Signed-off-by: Mike Lothian --- src/amd/vulkan/radv_meta.h | 2 +- 1 file changed, 1 insertion

[Mesa-dev] [PATCH 1/2] radv/ac: Fix nir.h include

2017-04-18 Thread Mike Lothian
This fixes the build after: commit 224cf2906a8f38ce47411afc93a223ac0e41795f Author: Dave Airlie Date: Mon Apr 17 13:01:52 2017 +1000 radv/ac: add initial pre-pass for shader info gathering Signed-off-by: Mike Lothian --- src/amd/common/ac_shader_info.c | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH v2] ac: fix build after LLVM 5.0 SVN r300718

2017-04-20 Thread Mike Lothian
Thanks for this Tested-and-reviewed-by: Mike Lothian On Thu, 20 Apr 2017 at 09:48 Nicolai Hähnle wrote: > On 20.04.2017 10:34, Christoph Haag wrote: > > v2: previously getWithDereferenceableBytes() exists, but addAttr() > doesn't take that type > > > >

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-07 Thread Mike Lothian
Hi Is it possible to get all 3 gears lined up under the points of the "M" and have the 3rd gear go under the "e" if need be Cheers Mike On Thu, 7 Jun 2018 at 10:02 Erik Faye-Lund wrote: > Just as a fun toy, I decided to give an animated SVG "variation" of > this a go myself: > > https://codep

[Mesa-dev] [PATCH] meson: allow x86 asm on x86_64 cross compiles

2018-06-07 Thread Mike Lothian
This patch allows building asm for x86 on x86_64 cross compiles Fixes: 2d62fc064652 ("meson: disable x86 asm in fewer cases.") Signed-off-by: Mike Lothian --- If you're happy with this change, please can you commit it as I don't have access --- meson.build | 2 +- 1 file

Re: [Mesa-dev] [PATCH 1/2] mesa: remove drirc workarounds for Worms, Tropico 5 and Crookz

2018-06-22 Thread Mike Lothian
Hi Does the whole of mesa support that or just radeonsi? Cheers Mike On Fri, 22 Jun 2018 at 14:10 Samuel Pitoiset wrote: > Since mesa now exposes OpenGL 3.3 compat, we no longer need > those workarounds. > > Signed-off-by: Samuel Pitoiset > --- > src/util/drirc | 12 > 1 file c

Re: [Mesa-dev] [PATCH 1/2] mesa: remove drirc workarounds for Worms, Tropico 5 and Crookz

2018-06-22 Thread Mike Lothian
rsion: 1.1 Max GLES[23] profile version: 3.1 On Fri, 22 Jun 2018 at 14:28 Mike Lothian wrote: > Hi > > Does the whole of mesa support that or just radeonsi? > > Cheers > > Mike > > On Fri, 22 Jun 2018 at 14:10 Samuel Pitoiset > wrote: > >> Since mesa

Re: [Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-22 Thread Mike Lothian
I think you forgot to bump PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY to 430 On Fri, 22 Jun 2018 at 09:48 Timothy Arceri wrote: > I've send all of these patches out already. The only change is to the > first 2 patches which fixes things so we store a double as 2 unsigned ints > rather than 2 floa

Re: [Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-25 Thread Mike Lothian
I'll test these tonight, Dying Light in particular required an override - hopefully that won't be necessary any more On Mon, 25 Jun 2018 at 12:26 Timothy Arceri wrote: > Please note I've fixed up make check where is was broken when enabling > some of these extensions. You can see all of the late

Re: [Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-25 Thread Mike Lothian
Hi I can confirm I no longer need to pass MESA_GL_VERSION_OVERRIDE to Dying Light Tested-by: Mike Lothian Cheers Mike On Tue, 26 Jun 2018 at 04:41 Dieter Nützel wrote: > Am 25.06.2018 13:26, schrieb Timothy Arceri: > > Please note I've fixed up make check where is was broken

Re: [Mesa-dev] Radeonsi OpenGL 4.4 compat profile support

2018-06-28 Thread Mike Lothian
he other 2 games that have this option set) Tested-by: Mike Lothian Thanks again for this On Thu, 28 Jun 2018 at 07:47 Timothy Arceri wrote: > Sorry to keep spamming the list with this stuff, but Dave helped > out with ARB_vertex_attrib_64bit support and the spec bug I > submitted f

[Mesa-dev] [PATCH] meson: Build st_tests_common with gtest

2018-04-19 Thread Mike Lothian
Fixes: 34cb4d0ebc1 ("meson: build tests for gallium mesa state tracker") Signed-off-by: Mike Lothian --- src/mesa/state_tracker/tests/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/tests/meson.build b/src/mesa/state_tra

Re: [Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables

2018-04-24 Thread Mike Lothian
Can you also add radeon to the amd one? That works on autotools On Wed, 25 Apr 2018 at 02:16 Jordan Justen wrote: > Fixes: 5608d0a2cee "meson: use array type options" > Cc: Dylan Baker > Signed-off-by: Jordan Justen > --- > meson.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi Mario Again thanks for looking into this issue :D Tested-by: Mike Lothian I'll give the other patch a whirl now Cheers Mike On 4 May 2018 at 14:45, Mario Kleiner wrote: > Before destroying the loader_dri3_drawable, make sure all pending > swaps for it have completed. This gui

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi I'm still seeing the freeze in the Steam client with this patch Just about to test the other one Mike On 4 May 2018 at 17:17, Mike Lothian wrote: > Hi Mario > > Again thanks for looking into this issue :D > > Tested-by: Mike Lothian > > I'll give the oth

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi The first hunk doesn't apply, the other 3 gives this with GCC 8.1 ../mesa-/src/loader/loader_dri3_helper.c: In function ‘dri3_handle_present_event’: ../mesa-/src/loader/loader_dri3_helper.c:376:13: error: implicit declaration of function ‘printf’ [-Werror=implicit-function-declaration

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi Yes I've not seen any freezes with Plasmashell, so a big improvement Had issues with patch 2 Cheers Mike On 4 May 2018 at 17:36, Mario Kleiner wrote: > On Fri, May 4, 2018 at 6:31 PM, Mike Lothian wrote: >> Hi >> >> I'm still seeing the freeze in t

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
d eid %d\n", draw->width, draw->height, draw->drawable, draw->eid); } dri3_flush_present_events(draw); mtx_unlock(&draw->mtx); -- 2.17.0 On 4 May 2018 at 17:54, Mario Kleiner wrote: > On Fri, May 4, 2018 at 6:45 PM, Mike Lothian wrote: >> H

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mike Lothian
ay 5, 2018 at 4:08 AM, Mike Lothian wrote: > > I definately saw the steam bug with patch 1 but not with plasmashell, > > I started seeing it with patch 2 but it seemed to fix itself > > > > I had two hangs of kwin_x11 within the last 6 hours when alt-tabbing &g

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mike Lothian
Which is: VK_ERROR_OUT_OF_DATE_KHR = -101004, On Sat, 5 May 2018 at 10:15 Mike Lothian wrote: > Out of interest can you try running the vulkan smoketest, I'm seeing this: > > smoketest > terminate called after throwing an instance of 'std::runtime_error' >

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mike Lothian
Thank you for the clarification. On Sat, 5 May 2018 at 14:31 Daniel Stone wrote: > On 5 May 2018 at 10:15, Mike Lothian wrote: > > Out of interest can you try running the vulkan smoketest, I'm seeing > this: > > > > smoketest > > terminate called

Re: [Mesa-dev] [PATCH] glx/dri: Take an extra reference on our own GLX drawables

2018-05-09 Thread Mike Lothian
ution, but in the > meantime this is effectively not a memory leak for any real scenario, > and fixes a real bug. > > Signed-off-by: Adam Jackson > Cc: Michel Dänzer > Cc: Mike Lothian > Cc: Mario Kleiner > Cc: Tobias Klausmann > Bugzilla: https://bugs.freedesktop.o

Re: [Mesa-dev] [PATCH] glx/dri: Take an extra reference on our own GLX drawables

2018-05-09 Thread Mike Lothian
With Michel's suggestion I've not seen a freeze in Plasmashell or Steam so far Tested-by: Mike Lothian On Wed, 9 May 2018 at 21:47 Mike Lothian wrote: > On Tue, 8 May 2018 at 20:47 Adam Jackson wrote: > >> dri*_bind_context, when switching current drawables, will drop t

Re: [Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

2018-05-16 Thread Mike Lothian
Can this be added to stable too? On Wed, 16 May 2018 at 10:33 Michel Dänzer wrote: > On 2018-05-16 11:14 AM, Axel Davy wrote: > > Hi, > > > > Shouldn't this be fixed on the xserver or the ddx side, rather than in > > Mesa ? > No, it's a Mesa bug, the X server is doing what it's asked. (This wasn

Re: [Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

2018-05-19 Thread Mike Lothian
I had hoped this would land in 18.1.0 Any signs of a review and can we get this backported asap? On Wed, 16 May 2018, 15:49 Michel Dänzer, wrote: > On 2018-05-16 01:39 PM, Mike Lothian wrote: > > Can this be added to stable too? > > Right, I meant add that but forgot, thanks f

Re: [Mesa-dev] [PATCH 4/5] egl/wayland: Allow client->server format conversion for PRIME offload.

2018-05-23 Thread Mike Lothian
Hi Mario Can you explain how I can test this? I'll test it out on an Intel+AMD system Cheers Mike On Wed, 23 May 2018 at 05:51 Mario Kleiner wrote: > On Mon, May 21, 2018 at 4:42 PM, Eric Engestrom > wrote: > > On Saturday, 2018-05-19 05:32:41 +0200, Mario Kleiner wrote: > >> Support PRIME r

Re: [Mesa-dev] [PATCH 1/2] loader/dri3: Only wait for back buffer fences in dri3_get_buffer

2018-09-11 Thread Mike Lothian
Hi If this is prime related I can test it tonight for you Cheers Mike On Tue, 11 Sep 2018 at 14:06 Thomas Hellstrom wrote: > > On 09/11/2018 02:41 PM, Michel Dänzer wrote: > > Any feedback on this patch? Without negative feedback, I'll push it > > later this week. > Hi, Michel, > > This looks

Re: [Mesa-dev] [PATCH] docs/features: add EXT_direct_state_access features

2018-09-18 Thread Mike Lothian
You might want to remove the " we DO NOT WANT implementations of these extensions for Mesa" if you're planning on implementing them On Tue, 18 Sep 2018 at 10:48 Timothy Arceri wrote: > Acked-by: Timothy Arceri > > On 18/9/18 1:31 pm, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > d

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-26 Thread Mike Lothian
Hi What's GDS and IB stand for? Thanks Mike On Tue, 27 Nov 2018, 01:57 Marek Olšák, wrote: > From: Marek Olšák > > --- > .../drivers/radeonsi/si_compute_blit.c| 4 +- > src/gallium/drivers/radeonsi/si_cp_dma.c | 49 ++- > src/gallium/drivers/radeonsi/si_pipe.h

Re: [Mesa-dev] [PATCH 2/3] winsys/amdgpu: add support for allocating GDS and OA resources

2018-11-26 Thread Mike Lothian
Same for OA Cheers Mike On Tue, 27 Nov 2018, 01:57 Marek Olšák, wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/radeon_winsys.h | 4 +- > src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 55 +- > 2 files changed, 36 insertions(+), 23 deletions(-) > > diff --g

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Mike Lothian
This doesn't show as default and seems to be tucked away under GL_ARB_transform_feedback3 GL_ARB_transform_feedback3: GL_MAX_TRANSFORM_FEEDBACK_BUFFERS = 4 GL_MAX_VERTEX_STREAMS = 4 GL_NUM_SHADING_LANGUAGE_VERSIONS = 16 450 440 430 420 410

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Mike Lothian
It also seems to have an off by one error On Wed, 21 Feb 2018 at 16:41 Mike Lothian wrote: > This doesn't show as default and seems to be tucked away > under GL_ARB_transform_feedback3 > > GL_ARB_transform_feedback3: > GL_MAX_TRANSFORM_FEEDBACK_BUFFERS = 4 > GL

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-23 Thread Mike Lothian
This still looks wrong, there's now two 4.3 sections: 4.3: GL_MAX_ELEMENT_INDEX = 2147483647 GL_MAX_COMPUTE_UNIFORM_BLOCKS = 14 GL_MAX_COMPUTE_TEXTURE_IMAGE_UNITS = 32 GL_MAX_COMPUTE_IMAGE_UNIFORMS = 32 GL_MAX_COMPUTE_SHARED_MEMORY_SIZE = 65536 GL_MAX_COMPUTE_UNIFORM_COMP

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-23 Thread Mike Lothian
The OCD side of me says it doesn't look right :P The lazy side of me says it's fine Either way it doesn't make much difference, it's only exposed with the extended output anyway On Fri, 23 Feb 2018 at 16:32 Brian Paul wrote: > On 02/23/2018 03:06 AM, Mike Lothian wrot

Re: [Mesa-dev] [PATCH] disk cache: Link with -latomic if necessary

2018-02-26 Thread Mike Lothian
On Fri, 23 Feb 2018 at 13:18 Thierry Reding wrote: > From: Thierry Reding > > The disk cache implementation uses 64-bit atomic operations. For some > architectures, such as 32-bit ARM, GCC will not be able to translate > these operations into lock-free instructions and will instead rely on > the

Re: [Mesa-dev] [PATCH] disk cache: Link with -latomic if necessary

2018-03-03 Thread Mike Lothian
Hi Sorry to be a pain again I've just tested this with clang and the 32bit build still fails without -latomic libtool: link: /bin/true glsl/.libs/libstandalone.a libtool: link: rm -fr glsl/.libs/libstandalone.lax glsl/.libs/libstandalone.lax libtool: link: ( cd "glsl/.libs" && rm -f "libstandalo

[Mesa-dev] Few issues with Meson

2018-03-05 Thread Mike Lothian
Hi I've been trying to get a Gentoo ebuild ready for meson I've had to fudge the llvm-config for cross compiling a 32bit mesa on a 64bit machine I notice that -Dvulkan-drivers= doesn't accept intel,radeon like autotools used to, it also seems as long as one value is correct the other is ignored

Re: [Mesa-dev] Few issues with Meson

2018-03-06 Thread Mike Lothian
Hi When compiling wine I also noticed that the d3d.pc files didn't have moduledir set, so wine couldn't find it configure: error: pkg-config couldn't find Gallium Nine module Regards Mike On Tue, 6 Mar 2018 at 02:17 Mike Lothian wrote: > Hi > > I've been trying

Re: [Mesa-dev] Few issues with Meson

2018-03-12 Thread Mike Lothian
ng is used - I'll look into that sometime Regards Mike On Fri, 9 Mar 2018 at 16:37 Dylan Baker wrote: > Quoting Mike Lothian (2018-03-06 05:07:34) > > Hi > > > > When compiling wine I also noticed that the d3d.pc files didn't have > moduledir > > set, so w

Re: [Mesa-dev] [PATCH 2/2] configure.ac: require libdrm_amdgpu 2.4.91

2018-03-13 Thread Mike Lothian
Did you mean to remove the blacklist you added in the previous patch? On Wed, 14 Mar 2018 at 01:03 Marek Olšák wrote: > From: Marek Olšák > > Since 2.4.90 might not work, just ask for the next version. > --- > configure.ac | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > dif

Re: [Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

2018-02-14 Thread Mike Lothian
pack_es31a I'm not aware of anything that uses OpenGL 3.1 Compat or the ARB_compatability extension, but if you know of anything I'll test it directly Should i965 show the extra extensions or a higher compat version as well as the bump to the GLSL version? My games continue to w

Re: [Mesa-dev] [PATCH] amd/common: Fix build with new ac_add_function_attr()

2017-03-01 Thread Mike Lothian
I can confirm this fixes the build for me But I still get warnings: /var/tmp/portage/media-libs/mesa-/work/mesa-/src/amd/common/ ac_nir_to_llvm.c: In function ‘visit_interp’: /var/tmp/portage/media-libs/mesa-/work/mesa-/src/amd/common/ ac_nir_to_llvm.c:3022:11: warning: ‘location’

Re: [Mesa-dev] [PATCH 2/2] gallivm, ac: add function attributes at call sites instead of declarations

2017-03-01 Thread Mike Lothian
Hi I think this patch is causing build problems for me /var/tmp/portage/media-libs/mesa-/work/mesa-/src/amd/common/ac_nir_to_llvm.c: In function ‘create_llvm_function’: /var/tmp/portage/media-libs/mesa-/work/mesa-/src/amd/common/ac_nir_to_llvm.c:265:4: error: implicit declaration

Re: [Mesa-dev] [PATCH 1/2] util/disk_cache: support caches for multiple architectures

2017-03-02 Thread Mike Lothian
Is this because the 32bit and 64bit versions have slightly different time stamps used in the cache directory name? I was under the impression that the cache itself could be shared between 32bit & 64bit? I guess this only matters for the few games that offer both a 32bit and 64bit binary, producing

Re: [Mesa-dev] [PATCH 1/2] util/disk_cache: support caches for multiple architectures

2017-03-02 Thread Mike Lothian
I'm guessing when the code runs the 32bit and 64bit have different build times so invalidate the cache and create a new one On Thu, 2 Mar 2017 at 16:25 Marek Olšák wrote: > On Thu, Mar 2, 2017 at 3:03 PM, Mike Lothian wrote: > > Is this because the 32bit and 64bit versions

Re: [Mesa-dev] [PATCH 1/2] util/disk_cache: support caches for multiple architectures

2017-03-02 Thread Mike Lothian
Could the solution be keeping X number of cache's and delete the oldest ones, I guess we'd need at least 2 On Thu, 2 Mar 2017 at 16:36 Mike Lothian wrote: > I'm guessing when the code runs the 32bit and 64bit have different build > times so invalidate the cache and create

Re: [Mesa-dev] [PATCH] ralloc: don't leave out the alignment factor

2017-03-03 Thread Mike Lothian
I've spent the whole night tracking down this bug I thought it was an issue with a recent upgrade of binutils Please add my: Tested by: Mike Lothian On Sat, 4 Mar 2017 at 00:49 Grazvydas Ignotas wrote: > Experimentation shows that without alignment factor gcc and clang choose >

Re: [Mesa-dev] Initial version of threaded GL dispatch V2

2017-03-09 Thread Mike Lothian
Hi I've been testing this patch series along with patchwork series https://patchwork.freedesktop.org/series/20872/ & https://patchwork.freedesktop.org/series/20873/ It's been working well with the games I've tested on so far - I had one crash in the Shadow of Mordor benchmark, but I've reproduced

Re: [Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

2017-03-10 Thread Mike Lothian
This isn't applying cleanly for me, I think I'm missing some patches I've applied Series 20989, 20872, 20873 (rev1 with patches 6,7 applied manually - patchwork was being weird) on top of master Do you have a branch somewhere? On Fri, 10 Mar 2017 at 02:29 Timothy Arceri wrote: > This series wa

Re: [Mesa-dev] [PATCH 4/4] gallium/util: move u_queue.{c, h} to src/util

2017-03-10 Thread Mike Lothian
Does that include patches 5, 6 & 7? On Fri, 10 Mar 2017 at 10:57 Marek Olšák wrote: > For the series: > > Reviewed-by: Marek Olšák > > Marek > > On Wed, Mar 8, 2017 at 5:36 AM, Timothy Arceri > wrote: > > This will allow us to use it outside of gallium for things like > > compressing shader ca

Re: [Mesa-dev] [PATCH v3 0/6] Use drmDevice2 API, take ... final

2017-03-10 Thread Mike Lothian
Does this mean my dGPU will stop being woken up when I play videos or open Chromium? On Fri, 10 Mar 2017 at 12:32 Emil Velikov wrote: > Hi all, > > Here is hopefully the final round of using drmDevice2. > > As a brief reminder - probing devices via drmDevice or directly opening > the device node

Re: [Mesa-dev] [PATCH v3 0/6] Use drmDevice2 API, take ... final

2017-03-10 Thread Mike Lothian
Works great - tested remotely passing DISPLAY=:0 now only when I pass DRI_PRIME=1 does the card fire up Thanks Mike On Fri, 10 Mar 2017 at 13:56 Emil Velikov wrote: > On 10 March 2017 at 13:35, Mike Lothian wrote: > > Does this mean my dGPU will stop being woken up when I play

Re: [Mesa-dev] [PATCH] util/disk_cache: fix zlib linking with LTO build

2017-03-12 Thread Mike Lothian
For what its worth I compile Mesa using LTO with the gold linker so I don't need to specify -fuse-linker-plugin - everything works fine here CFLAGS="-O3 -march=skylake -pipe -flto=8" CXXFLAGS="${CFLAGS}" LDFLAGS="-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-flto=8" AR="gcc-ar" NM="gcc-nm" RA

Re: [Mesa-dev] Lets try that again. Proposal for merging GL dispatch (aka glthread)

2017-03-15 Thread Mike Lothian
Feel free to add my tested by I've been running with this since it was posted On Tue, 14 Mar 2017 at 03:43 Timothy Arceri wrote: > Hi all, > > There hasn't been any major comments on V2 of the series [1] so I'll > assume that's a good thing. > > It seemed the biggest objection to not merging V1

Re: [Mesa-dev] [PATCH 7/7] gallium/radeon: disable the shader cache if dumping shaders

2017-03-15 Thread Mike Lothian
Feel free to add my tested by to this I've been using it in conjunction with https://patchwork.freedesktop.org/series/20816/ On Sun, 12 Mar 2017 at 22:06 Timothy Arceri wrote: > Patches 2, 3 & 7 are: > > Reviewed-by: Timothy Arceri > > I'd need some more time to understand the others can take

Re: [Mesa-dev] [PATCH] util: move string_to_uint_map to glsl

2017-08-29 Thread Mike Lothian
Feel free to add my tested by for this Thanks for the fix On Sat, 26 Aug 2017 at 17:35 Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > On Fri, Aug 25, 2017 at 7:10 PM, Jason Ekstrand > wrote: > >> Ack. Not a review though. >> >> >> >> On August 25, 2017 6:38:46 PM Emil Velikov >> wr

Re: [Mesa-dev] [PATCH mesa] mesa/st: remove unwanted backup file

2017-08-30 Thread Mike Lothian
LOL didn't even spot this sorry It might be a good idea to pop *.orig and *.rej into the gitignore file On Wed, 30 Aug 2017 at 14:17 Emil Velikov wrote: > On 30 August 2017 at 14:11, Eric Engestrom wrote: > > Fixes: 0ac78dc92582a59d4319 "util: move string_to_uint_map to glsl" > > Cc: Emil Veli

Re: [Mesa-dev] [PATCH] loader/dri3: Also wait for front buffer fence if we triggered it

2018-10-11 Thread Mike Lothian
Do you think this why I've been seeing lots of weird flashing in Chrome recently? I'll test this patch out tonight and give you my tested by if you like On Thu, 11 Oct 2018 at 09:27 Michel Dänzer wrote: > > Any feedback? Without negative feedback, I'll push this fix tomorrow. > > > On 2018-10-0

Re: [Mesa-dev] [PATCH] loader/dri3: Also wait for front buffer fence if we triggered it

2018-10-11 Thread Mike Lothian
I'm still seeing weird graphical corruptions in chrome and sometimes when playing video It's especially noticeable when in inbox.google.com I might be suffering from a different issue however On Thu, 11 Oct 2018 at 11:43 Mike Lothian wrote: > Do you think this why I've b

[Mesa-dev] Broken Tags

2018-07-17 Thread Mike Lothian
Hi Is there any change the following tags could be deleted (and recreated if required) from the git repo: R300_DRIVER_0 before_upgrade_03_01_05 blended_fountain embedded-1-20030120 embedded-1-20030224 embedded-1-20030305 embedded-1-20030324 embedded-1-20030417 embedded-1-20030502 gliding_penguin

Re: [Mesa-dev] [PATCH 0/7] ASTC texture compression for all Gallium drivers

2018-07-25 Thread Mike Lothian
Feel free to add my tested by: Tested-by: Mike Lothian Cheers Mike On Tue, 24 Jul 2018 at 00:52 Marek Olšák wrote: > Hi, > > This series enables ASTC texture compression for all Gallium drivers > that don't support it in hardware. The works the same as the ETC2 &g

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
Hi It would be helpful if you posted the failure output, without it its difficult to diagnose I'm not seeing any issues with the master branch on the meson build Is this your first time building mesa, or has something suddenly stopped working? Cheers Mike On Thu, 2 Aug 2018 at 16:46 Guang Bai

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
Which distro are you using? On Thu, 2 Aug 2018 at 17:35 Guang Bai wrote: > This is the reason for me to look for helps from our mesa-dev community. > Thanks, > Guang > > On Thu, 2 Aug 2018 17:10:16 +0100 > Mike Lothian wrote: > > > Yeah the lease stuff was added

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
might have what you're after On Thu, 2 Aug 2018 at 18:00 Guang Bai wrote: > On Thu, 2 Aug 2018 17:55:21 +0100 > Mike Lothian wrote: > > > Which distro are you using? > > uBuntu-14.045 & uBuntu-16.04 > Thanks, > Guang > > > > > On Thu, 2 Aug 2018

[Mesa-dev] libdrm: Fix amdgpu build failure

2018-08-07 Thread Mike Lothian
Hi I'm not sure if this is the right mailing list or not but the following patch gets things building with meson again Signed-of-by: Mike Lothian diff --git a/amdgpu/meson.build b/amdgpu/meson.build index f39d7bf6..d9d7de2d 100644 --- a/amdgpu/meson.build +++ b/amdgpu/meson.build @@

Re: [Mesa-dev] [PATCH] radv: add Doom workaround

2018-08-15 Thread Mike Lothian
Do you need the game name here, isn't that set in driconf? On Wed, 15 Aug 2018 at 12:12 Timothy Arceri wrote: > Cc: > --- > src/amd/vulkan/radv_device.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > index 33f24b9d302..

Re: [Mesa-dev] [PATCH 00/14] vl dri3 support for vaapi and vdpau

2016-05-11 Thread Mike Lothian
Hi Axel Is the thread_submit=true only for nine or does it work with all of DRI3? I'm keen to get rid of the tearing on my Skylake/Tonga setup Thanks Mike On Wed, 11 May 2016 at 16:57 Axel Davy wrote: > Hi, > > Do you have some local branch to review all at once (it is a bit hard to > follow

Re: [Mesa-dev] [PATCH] gallium/radeon: add the kernel version into the renderer string

2016-05-24 Thread Mike Lothian
Do you need the DRM version number if you'll be displaying the kernel version anyway? On Wed, 25 May 2016 at 00:09 Marek Olšák wrote: > From: Marek Olšák > > Example: > Gallium 0.4 on AMD TONGA (DRM 3.2.0 / 4.5.0, LLVM 3.9.0) > > My kernel version is pretty long already (4.5.0-amd-01025-g32791c

[Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-29 Thread Mike Lothian
Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h Signed-of-by: Mike Lothian --- I don't have git commit rights If you're happy with this patch please can you commit it Cheers Mike --- src/amd/vulkan/radv_nir

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-29 Thread Mike Lothian
On Fri, 30 Mar 2018, 01:42 Dylan Baker, wrote: > Quoting Mike Lothian (2018-03-29 16:56:28) > > Include llvm-c/Transforms/Utils.h with the newest LLVM 7 > > > > Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h > > I have no comment on the patch itself. >

Re: [Mesa-dev] [radv] compilation error with 'latest' LLVM (#4e45b963bcd)

2018-03-30 Thread Mike Lothian
I've submitted a patch for this, it was a change in the llvm-c includes On Fri, 30 Mar 2018 at 08:43 Dieter Nützel wrote: > make[4]: Verzeichnis „/opt/mesa/src/amd/vulkan“ wird betreten >CC radv_nir_to_llvm.lo > radv_nir_to_llvm.c: In function ‘ac_llvm_finalize_module’: > radv_nir_to_l

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
On Sat, 31 Mar 2018 at 00:54 Dylan Baker wrote: > > Quoting Mike Lothian (2018-03-29 17:49:30) > > > > > > On Fri, 30 Mar 2018, 01:42 Dylan Baker, wrote: > > > > Quoting Mike Lothian (2018-03-29 16:56:28) > > > Include llv

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
On 1 April 2018 at 00:03, Vinson Lee wrote: > > A similar change is needed in > src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp. > > Vinson Hi I'm not convinced that it does Utils.h defines two functions LLVMAddLowerSwitchPass & LLVMAddPromoteMemoryToRegisterPass. Whilst jit_pch.hpp does

[Mesa-dev] [PATCH 1/3] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Signed-of-by: Mike Lothian Reviewed-by: Samuel Pitoiset Tested-by: Dieter Nützel --- src/amd/vulkan/radv_nir_to_llvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan

[Mesa-dev] [PATCH 0/3] Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
Hi I've split this into three patches, one for each area affected I think I've got the right prefixes now I've also removed the fixes line and included the testing and reviewed by tags Hope that's OK and again if you're happy with this please can you commit as I don't have git rights Thanks M

[Mesa-dev] [PATCH 2/3] radeonsi: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Signed-of-by: Mike Lothian Reviewed-by: Samuel Pitoiset Tested-by: Dieter Nützel --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 3/3] gallivm: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Signed-of-by: Mike Lothian Reviewed-by: Samuel Pitoiset Tested-by: Dieter Nützel --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c b/src

[Mesa-dev] [PATCH 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-01 Thread Mike Lothian
Include llvm/Transforms/Utils.h with the newest LLVM 7 Signed-of-by: Mike Lothian --- src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp b/src/gallium/drivers/swr/rasterizer/jitter

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-04-01 Thread Mike Lothian
Thanks for pointing that out I've sent a 4th patch, I've never compiled swr before, would you mind testing to see if it fixes things for you, it's using the llvm include rather than the llvm-c include On Sun, 1 Apr 2018 at 06:15 Vinson Lee wrote: > On Sat, Mar 31, 2018 at 5:0

[Mesa-dev] [PATCH v2 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-01 Thread Mike Lothian
Include llvm/Transforms/Utils.h with the newest LLVM 7 v2: Include with " " rather than < > Signed-of-by: Mike Lothian Tested-by: Vinson Lee --- src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/driver

[Mesa-dev] [PATCH v3 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-04 Thread Mike Lothian
Include llvm/Transforms/Utils.h with the newest LLVM 7 v2: Include with " " rather than < > (Vinson Lee) v3: Use LLVM_VERSION_MAJOR rather than HAVE_LLVM (George Kyriazis) Signed-of-by: Mike Lothian Tested-by: Vinson Lee --- src/gallium/drivers/swr/rasterizer/jitter/jit_pc

Re: [Mesa-dev] [PATCH v3 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-04 Thread Mike Lothian
Are you able to push this for me on my behalf? On Wed, 4 Apr 2018 at 15:04 Kyriazis, George wrote: > Thank you! > > Reviewed-By: George Kyriazis > > On Apr 4, 2018, at 3:22 AM, Mike Lothian wrote: > > Include llvm/Transforms/Utils.h with the newest LLVM 7 > > v2: I

Re: [Mesa-dev] [PATCH 0/7] panfrost: GLES3 textures (and primitive restart)

2019-06-27 Thread Mike Lothian
Hi Are there plans to add Panfrost to docs/features.txt? Cheers Mike On Thu, 27 Jun 2019 at 14:13, Alyssa Rosenzweig wrote: > > Just a bit of potpourrie of low-hanging fruit for GLES3 features, e.g. > floating-point textures and ES-class primitive restart. > > Alyssa Rosenzweig (7): > panfro

[Mesa-dev] [PATCH] meson: Always include 'coroutines' in llvm optional modules

2019-09-07 Thread Mike Lothian
Without this I get build failures: error: undefined reference to 'LLVMAddCoroEarlyPass' error: undefined reference to 'LLVMAddCoroSplitPass' error: undefined reference to 'LLVMAddCoroElidePass' error: undefined reference to 'LLVMAddCoroCleanupPass' Cc:

Re: [Mesa-dev] Rename "master" branch to "main"?

2020-08-03 Thread Mike Lothian
On Mon, 3 Aug 2020 at 18:42, Erik Faye-Lund wrote: > > On Mon, 2020-08-03 at 10:30 -0500, Jason Ekstrand wrote: > > All, > > > > I'm sure by now you've all seen the articles, LKML mails, and other > > chatter around inclusive language in software. While mesa doesn't > > provide a whole lot of doc

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-18 Thread Mike Lothian
This patch is causing strange behaviour for me (and someone else on IRC) on my Raven system May 18 15:31:43 quark kwin_x11[607]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 2825, resource id: 37748896, major code: 18 (ChangeProperty), minor code: 0 May 18 15:31:44 quark systems

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-20 Thread Mike Lothian
I managed to trigger the bug remotely using that branch :( On Mon, 20 May 2019 at 09:03, Juan A. Suarez Romero wrote: > > On Sat, 2019-05-18 at 15:52 +0100, Mike Lothian wrote: > > This patch is causing strange behaviour for me (and someone else on > > IRC) on my Raven syst

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-21 Thread Mike Lothian
Can someone with access revert from master until this is fixed? It's been broken for 3 days now On Tue, 21 May 2019 at 09:01, Juan A. Suarez Romero wrote: > > On Tue, 2019-05-21 at 09:36 +0200, Gert Wollny wrote: > > Hi Marek, > > > > it seems that this patch is causing a few issues [1], any idea

Re: [Mesa-dev] [PATCH] glxinfo: add support for creating/querying core-profile contexts (v2.1)

2013-01-15 Thread Mike Lothian
Silly question but what does: OpenGL context flags: (none) OpenGL core profile context flags: (none) Actually mean? Also could we print the core profile first? On 12 January 2013 22:15, Dave Airlie wrote: > From: Brian Paul > > [airlied: Based on Brian's patch, I've fixed it up to always re

<    1   2   3   >