Re: [Mesa-dev] [PATCH] mesa: fix _mesa_error() compiler warnings in shaderapi.c

2015-07-23 Thread Kai Wasserbäch
ctx, GL_INVALID_OPERATION, api_name); >^ > > Ideally, many of these error messages should be improved to indicate > which argument is incorrect as we do in other parts of Mesa. Reviewed-by: Kai Wasserbäch Tested-by: Kai Wasserbäch Thanks, this broke my build (with a -Werror=

Re: [Mesa-dev] [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers

2015-11-13 Thread Kai Wasserbäch
Hi Emil, Emil Velikov wrote on 12.11.2015 18:45: > On 12 November 2015 at 15:36, Samuel Iglesias Gonsálvez > wrote: >> On 12/11/15 15:28, Timothy Arceri wrote: >>> On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez" >>> wrote: 'shared' was added in ARB_uniform_buffer_object an

[Mesa-dev] OT: Phabricator? (was: Re: [PATCH 1/2] glsl: enable 'shared' keyword also for layout qualifiers)

2015-11-13 Thread Kai Wasserbäch
Hi Emil, Emil Velikov wrote on 13.11.2015 13:58: > On 13 November 2015 at 09:14, Kai Wasserbäch > wrote: >> Emil Velikov wrote on 12.11.2015 18:45: >>> On 12 November 2015 at 15:36, Samuel Iglesias Gonsálvez >>> wrote: >>>> On 12/11/15 15:28, Timothy

Re: [Mesa-dev] [PATCH] util: move etc shared code to util library

2015-02-03 Thread Kai Wasserbäch
Dave Airlie wrote on 03.02.2015 05:48: > From: Dave Airlie > > Like the RGTC code sharing this could be done nicer in the util lib. > > This slighty increase i965_dri.so size by ~100 bytes, > but it decreases the combined gallium driver by over 1k, > and its just nicer to avoid TAG(). > > Signe

Re: [Mesa-dev] [PATCH 2/2 v2] add visibility hidden to tls entry points

2015-02-17 Thread Kai Wasserbäch
Marc Dietrich wrote on 17.02.2015 10:05: > Avoid redefined symbol errors in clang. Based on a suggestion from > Rafael Ávila de Espíndola in Whoever commits this, might want to fix Rafael's name in the commit message before doing so. It should be: Rafael Ávila de Espíndola (according to the ref

Re: [Mesa-dev] [PATCH 2/2 v2] add visibility hidden to tls entrypoints

2015-02-17 Thread Kai Wasserbäch
Marc Dietrich wrote on 17.02.2015 15:58: > Am Dienstag, 17. Februar 2015, 15:51:38 schrieb Kai Wasserbäch: >> Marc Dietrich wrote on 17.02.2015 10:05: >>> Avoid redefined symbol errors in clang. Based on a suggestion from >>> Rafael Ávila de Espíndola in >> &g

Re: [Mesa-dev] [PATCH] osmesa: add gallium include dirs to Makefile.am

2015-02-23 Thread Kai Wasserbäch
Thanks Brian, this fixes the build for me. You can have my Tested-by: Kai Wasserbäch for this patch. Brian Paul wrote on 23.02.2015 16:39: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89260 > --- > src/mesa/drivers/osmesa/Makefile.am | 2 ++ > 1 file changed,

Re: [Mesa-dev] [PATCH 3/3] radeonsi/compute: Enable PIPE_SHADER_CAP_DOUBLES

2015-02-27 Thread Kai Wasserbäch
PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE: { > uint64_t max_const_buffer_size; > pscreen->get_compute_param(pscreen, > -- Kai Wasserbäch (Kai Wasserbaech) E-Mail: k...@dev.carbon-project.org signature.asc Description: OpenPGP digital si

Re: [Mesa-dev] [PATCH] configure: ax_check_python_mako_module.m4 sets output variable

2015-03-03 Thread Kai Wasserbäch
Samuel Iglesias Gonsalvez wrote on 03.03.2015 08:56: > This output variables gives more flexibility for future changes > in autoconf to detect if it is needed to auto-generate files and > check for the auto-generation dependencies. > > It is still returning error when Python is not installed. > >

Re: [Mesa-dev] [PATCH] configure: ax_check_python_mako_module.m4 sets output variable

2015-03-04 Thread Kai Wasserbäch
Samuel Iglesias Gonsálvez wrote on 04.03.2015 07:54: > On Tue, 2015-03-03 at 16:50 +0100, Kai Wasserbäch wrote: >> Samuel Iglesias Gonsalvez wrote on 03.03.2015 08:56: >>> This output variables gives more flexibility for future changes >>> in autoconf to detect if it

Re: [Mesa-dev] GLSL IR & TGSI on-disk shader cache

2017-02-11 Thread Kai Wasserbäch
Hey, Pierre-Loup A. Griffais wrote on 11.02.2017 03:44: > On 02/10/2017 04:01 AM, Nicolai Hähnle wrote: >> On 10.02.2017 12:46, Timothy Arceri wrote: >>> On 10/02/17 21:35, Nicolai Hähnle wrote: >>> [...] >>> It's not even clear to me how they intend to load those precompiled binaries int

Re: [Mesa-dev] [PATCH 2/2] vdpau: skip vlVdpOutputSurfacePutBitsNative with a zero-area rectangle

2017-02-12 Thread Kai Wasserbäch
urce_pitches, 0); > pipe_mutex_unlock(vlsurface->device->mutex); > > return VDP_STATUS_OK; > } > > /** > * Copy image data from application memory in a specific indexed format to In any case, this series is: Tested-by: Kai Wasserbäch Reviewed-by: Kai

Re: [Mesa-dev] radv cik fixes

2017-02-14 Thread Kai Wasserbäch
irm, that this series resolves fdo#99692 for me (<https://bugs.freedesktop.org/show_bug.cgi?id=99692#c9>). The Talos Principle is finally up and running with radv and no more visual corruption or VM faults either! You can have my Tested-by: Kai Wasserbäch Thank you so much for

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Kai Wasserbäch
RI3 support detected - required for > presentation\n"); > - fprintf(stderr, "Note: Buggy applications may crash, if they do please > report to vendor\n"); > + if (!wsi_x11_check_for_dri3(wsi_conn)) >return false; > - } > > unsigned visual_dept

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-18 Thread Kai Wasserbäch
= xcb_query_extension_reply(conn, pres_cookie, NULL); > - if (dri3_reply == NULL || pres_reply == NULL) { > + amd_reply = xcb_query_extension_reply(conn, amd_cookie, NULL); > + nv_reply = xcb_query_extension_reply(conn, nv_cookie, NULL); > + if (!dri3_reply || !pres_reply || !amd

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-19 Thread Kai Wasserbäch
Jason Ekstrand wrote on 19.02.2017 06:01: > On Feb 18, 2017 12:37 PM, "Kai Wasserbäch" > wrote: > > Hey Jacob, > sorry for not spotting this the first time, but I have an additional > comment. > Please see below. > > Jacob Lifshay wrote on 18.02.2017 18:

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-26 Thread Kai Wasserbäch
Not from my side. But I can't commit the patch for you. Jason? Jacob Lifshay wrote on 26.02.2017 03:17: > Just to double check, is there anything else I need to do to have this > patch committed? > Jacob Lifshay > > On Feb 19, 2017 02:08, "Kai Wasserbäch" wrote:

Re: [Mesa-dev] [PATCH 01/18] gallium/util: clear up that debug_get_flags_option returns a 64-bit mask

2015-07-28 Thread Kai Wasserbäch
eceiving variables in the callers should probably be fixed up as well, right? Most of them seem to be unsigned long or just unsigned. (E.g. in debug_flags in r600_common_screen is an unsigned) But maybe that can be ignored? Though somebody with deeper knowledge of the code should giv

Re: [Mesa-dev] [PATCH 01/18] gallium/util: clear up that debug_get_flags_option returns a 64-bit mask

2015-07-28 Thread Kai Wasserbäch
Brian Paul wrote on 28.07.2015 18:40: > On 07/28/2015 10:35 AM, Kai Wasserbäch wrote: >> Marek Olšák wrote on 28.07.2015 12:05: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/auxiliary/util/u_debug.c | 8 >>> src/gallium/auxili

Re: [Mesa-dev] [PATCH 01/18] gallium/util: clear up that debug_get_flags_option returns a 64-bit mask

2015-07-29 Thread Kai Wasserbäch
Marek Olšák wrote on 28.07.2015 21:42: > On Tue, Jul 28, 2015 at 6:35 PM, Kai Wasserbäch > wrote: >> Marek Olšák wrote on 28.07.2015 12:05: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/auxiliary/util/u_debug.c | 8 >>> src

[Mesa-dev] [PATCH] docs: trivial cleanup of GL3.txt, remove redundant radeonsi entries.

2015-07-30 Thread Kai Wasserbäch
Follow-up to 1b2b0e42ce47bfd1fcb5513ed2c23b9bb7a5a5b8 Signed-off-by: Kai Wasserbäch --- Please commit this for me, if this is accepted. Thanks. docs/GL3.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 0220f24..8124383 100644 --- a

[Mesa-dev] [PATCH] glsl: check if return_deref in lower_subroutine_visitor::visit_leave isn't NULL

2015-08-14 Thread Kai Wasserbäch
Fixes a crash in Piglit's spec@arb_shader_subroutine@lin...@no-mutual-recursion.vert for me. Signed-off-by: Kai Wasserbäch --- Hey everyone, I ran the Piglit quick test suite afterwards and haven't observed any regressions over my previous quick run, but the crash went away. The t

Re: [Mesa-dev] Problem with RX 480 on Alien: Isolation and Dota 2

2016-09-13 Thread Kai Wasserbäch
Marek Olšák wrote on 13.09.2016 19:53: > LLVM 64-bit: > > mkdir -p build > cd build > cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=/usr/llvm/x86_64-linux-gnu > -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" -DLLVM_ENABLE_ASSERTIONS=O > -DCMAKE_BUILD_TYPE=RelWithDebInfo > -DLLVM_BUILD_LLVM_DYLI

Re: [Mesa-dev] mesamatrix.net summary problem

2016-10-08 Thread Kai Wasserbäch
You're probably overlooking GL_ARB_shader_group_vote. Boszormenyi Zoltan wrote on 08.10.2016 17:53: > Hi, > > I just skimmed through the list of supported extensions by > both nvc0 and radeonsi on mesamatrix and the number > at the top of the page should be equal for them. > > nvc0 supports GL_A

Re: [Mesa-dev] [PATCH 2/2] radv: Use new image load/store intrinsic signatures

2016-10-13 Thread Kai Wasserbäch
ms[7] = slc; > + } else { > + LLVMValueRef lwe = i1false; > + params[4] = glc; > + params[5] = slc; > + params[6] = lwe; > + params[7] = da; > + } > &

Re: [Mesa-dev] [PATCH 2/2] radv: Use new image load/store intrinsic signatures

2016-10-13 Thread Kai Wasserbäch
Disregard this, the mbox file only contained the second patch. Sorry for the noise. Kai Wasserbäch wrote on 13.10.2016 19:20: > Dear Tom, > just FYI: this fails to apply on top of master > (761388a0eb586b1dcaec063ee561056ed132dc1a). git am chokes on the > visit_image_store()

[Mesa-dev] [PATCH 2/2] st/va: Remove unused variable coded_size from vlVaEndPicture()

2016-08-20 Thread Kai Wasserbäch
Removes the following GCC warning: ../../../../../src/gallium/state_trackers/va/picture.c:542:17: warning: unused variable 'coded_size' [-Wunused-variable] unsigned int coded_size; ^~ Signed-off-by: Kai Wasserbäch --- src/gallium/state_trackers/va/pic

[Mesa-dev] [PATCH 0/2] st/va: minor clean-ups

2016-08-20 Thread Kai Wasserbäch
f this "series" gets accepted, please commit it for me, since I do not have commit access. Kai Wasserbäch (3): st/va: Remove else case in vlVaEndPicture() made superfluous by c59628d11b st/va: Remove unused variable coded_size from vlVaEndPicture() src/gallium/state_trackers/

[Mesa-dev] [PATCH 1/2] st/va: Remove else case in vlVaEndPicture() made superfluous by c59628d11b

2016-08-20 Thread Kai Wasserbäch
Commit c59628d11b134fc016388a170880f7646e100d6f made the else statement and duplication of the context->decoder->end_frame() call superfluous. Cc: Boyuan Zhang Signed-off-by: Kai Wasserbäch --- src/gallium/state_trackers/va/picture.c | 4 +--- 1 file changed, 1 insertion(+), 3 del

Re: [Mesa-dev] [PATCH 0/2] st/va: minor clean-ups

2016-08-23 Thread Kai Wasserbäch
ostscript in the cover letter: either of you needs to commit these changes since I do not have commit access. Thanks again, Kai > -Original Message----- > From: Kai Wasserbäch [mailto:k...@dev.carbon-project.org] > Sent: August-20-16 12:15 PM > To: mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH] radeonsi: add support for cull distances.

2016-08-23 Thread Kai Wasserbäch
Hey Dave, Dave Airlie wrote on 23.08.2016 03:28: > From: Dave Airlie > > This should be all that is required for cull distances to work > on radeonsi. in case this is indeed enough to enable ARB_cull_distance, mind adding that to GL3.txt and the release notes? > Signed-off-by: Dave Airlie > --

[Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Kai Wasserbäch
Cc: Brian Paul Signed-off-by: Kai Wasserbäch --- Hi Brian, is this what you had in mind? If so, I was wondering whether virgl_encode.c would need to be updated as well. Doesn't seem like it, since the functions there map everything to uint32_t or some other standard type. Another point ar

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Kai Wasserbäch
Hey Brian, Brian Paul wrote on 26.08.2016 14:50: > On 08/26/2016 05:58 AM, Kai Wasserbäch wrote: >> Cc: Brian Paul >> Signed-off-by: Kai Wasserbäch >> --- >> >> Hi Brian, >> is this what you had in mind? If so, I was wondering whether virgl_encode.c >&

[Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states() (v2)

2016-08-26 Thread Kai Wasserbäch
v1 → v2: - Fixed indentation (noted by Brian Paul) - Removed second assert from nouveau's switch statements (suggested by Brian Paul) Signed-off-by: Kai Wasserbäch --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 --- src/gallium/auxiliary/cso_cache/cso_context.h

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Kai Wasserbäch
Hey Samuel, Samuel Pitoiset wrote on 26.08.2016 15:54: > On 08/26/2016 01:58 PM, Kai Wasserbäch wrote: >> [...] >> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_texture.c >> b/src/gallium/drivers/nouveau/nv30/nv30_texture.c >> index 4f4f87e..dc1a476 100644 >>

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-26 Thread Kai Wasserbäch
Hey Eric, Eric Engestrom wrote on 26.08.2016 15:49: > On Fri, Aug 26, 2016 at 03:14:57PM +0200, Kai Wasserbäch wrote: >> Brian Paul wrote on 26.08.2016 14:50: >>> On 08/26/2016 05:58 AM, Kai Wasserbäch wrote: >>>> Cc: Brian Paul >>>> Signed-off-by: K

[Mesa-dev] [PATCH 4/4] gallium: Use enum pipe_shader_type in set_shader_images()

2016-08-27 Thread Kai Wasserbäch
Signed-off-by: Kai Wasserbäch --- src/gallium/auxiliary/cso_cache/cso_context.c | 3 ++- src/gallium/auxiliary/cso_cache/cso_context.h | 3 ++- src/gallium/drivers/ddebug/dd_context.c | 3 ++- src/gallium/drivers/ilo/ilo_state.c | 2 +- src/gallium/drivers/nouveau/nvc0

[Mesa-dev] [PATCH 2/4] gallium: Use enum pipe_shader_type in set_sampler_views()

2016-08-27 Thread Kai Wasserbäch
Signed-off-by: Kai Wasserbäch --- src/gallium/auxiliary/cso_cache/cso_context.c | 2 +- src/gallium/auxiliary/cso_cache/cso_context.h | 2 +- src/gallium/auxiliary/draw/draw_context.c | 4 ++-- src/gallium/auxiliary/draw/draw_context.h | 4 ++-- src/gallium/auxiliary/draw

[Mesa-dev] [PATCH 3/4] gallium: Use enum pipe_shader_type in set_shader_buffers()

2016-08-27 Thread Kai Wasserbäch
Signed-off-by: Kai Wasserbäch --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 2 +- src/gallium/drivers/radeonsi/si_descriptors.c | 8 +--- src/gallium/drivers/softpipe/sp_state_image.c | 2 +- src/gallium/drivers/trace/tr_context.c| 2 +- src/gallium/include/pipe/p_context.h

[Mesa-dev] [PATCH 0/4] gallium clean-up (unsigned to enum pipe_shader_type)

2016-08-27 Thread Kai Wasserbäch
R-b by Samuel. All patches survived a compile run and 3D is still working on my radeonsi-powered ASIC. ;-) Cheers, Kai P.S.: By the way: there some other functions like get_shader_param, which also could use this treatment. Not sure if I get around to this soon. Kai Wasserbäch (4):

[Mesa-dev] [PATCH 1/4] gallium: Use enum pipe_shader_type in bind_sampler_states() (v2)

2016-08-27 Thread Kai Wasserbäch
v1 → v2: - Fixed indentation (noted by Brian Paul) - Removed second assert from nouveau's switch statements (suggested by Brian Paul) Reviewed-by: Samuel Pitoiset Signed-off-by: Kai Wasserbäch --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 --- src/gallium/auxi

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-27 Thread Kai Wasserbäch
Hey Samuel, Samuel Pitoiset wrote on 26.08.2016 20:22: > On 08/26/2016 04:17 PM, Kai Wasserbäch wrote: >> Hey Samuel, >> Samuel Pitoiset wrote on 26.08.2016 15:54: >>> On 08/26/2016 01:58 PM, Kai Wasserbäch wrote: >>>> [...] >>>> diff --git a/src/ga

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states() (v2)

2016-08-27 Thread Kai Wasserbäch
Hey Michael, Michael Schellenberger wrote on 26.08.2016 20:19: > Am 26.08.2016 um 15:23 schrieb Kai Wasserbäch: >> [...] >> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_texture.c >> b/src/gallium/drivers/nouveau/nv30/nv30_texture.c >> index 4f4f87e..e5d3db3

Re: [Mesa-dev] [ANNOUNCE] mesa 13.0.0-rc1

2016-10-19 Thread Kai Wasserbäch
5 Haixia Shi > 8 Hans de Goede > 12 Iago Toral Quiroga >139 Ian Romanick >139 Ilia Mirkin > 3 Indrajit Das > 2 Jakob Sinclair > 1 James Legg > 9 Jan Vesely > 5 Jan Ziak >506 Jason Ekstrand > 1 Jimmy Berry > 4

Re: [Mesa-dev] [ANNOUNCE] mesa 13.0.0-rc1

2016-10-20 Thread Kai Wasserbäch
, 2016 at 12:16 PM, Emil Velikov >>>> >>>> wrote: >>>>> >>>>> On 19 October 2016 at 19:50, Kai Wasserbäch >>>>> >>>>> wrote: >>>>>> Hey Emil, >>>>>> just curious why you did the reve

Re: [Mesa-dev] Stable release process

2016-11-18 Thread Kai Wasserbäch
Hi everybody, Nicolai Hähnle wrote on 18.11.2016 17:48: > On 18.11.2016 16:56, Emil Velikov wrote: >> On 18 November 2016 at 12:34, Marek Olšák wrote: >>> On Fri, Nov 18, 2016 at 12:49 PM, Emil Velikov >>> wrote: >>> [...] Speaking of patchwork, mostly I'm fine with it. There are some

Re: [Mesa-dev] [PATCH] mesa: Clamp negative values in glGetUniformuiv

2016-12-10 Thread Kai Wasserbäch
Nicolai Hähnle wrote on 10.12.2016 14:54: > From: Nicolai Hähnle > > Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 > (Compatibility Profile) spec says: > > "If a value is so large in magnitude that it cannot be represented by the > returned data type, then

Re: [Mesa-dev] [PATCH] mesa: Clamp negative values in glGetUniformuiv

2016-12-10 Thread Kai Wasserbäch
Nicolai Hähnle wrote on 10.12.2016 19:12: > On 10.12.2016 18:19, Kai Wasserbäch wrote: >> Nicolai Hähnle wrote on 10.12.2016 14:54: >>> From: Nicolai Hähnle >>> >>> Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 >>> (Compat

[Mesa-dev] [PATCH] Ensure we find the linker scripts in out-of-tree builds.

2013-10-26 Thread Kai Wasserbäch
Signed-off-by: Kai Wasserbäch Cc: thomas.stell...@amd.com --- Hi Tom, the patches you sent seem to work, but only for in-tree builds. If you push them out, please also fold the following patch into that series, that ensures out-of-tree builds work as well. If ran a full out-of-tree build in a

[Mesa-dev] [PATCH] radeonsi: Allow longer intrinsic names

2013-10-27 Thread Kai Wasserbäch
Fixes a boat load of Piglit tests for me, which crashed like fdo#70913 before. Thanks to Michel Dänzer for the tip. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70913 Signed-off-by: Kai Wasserbäch --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 2 +- 1 file changed, 1 insertion

Re: [Mesa-dev] [PATCH] radeonsi: Allow longer intrinsic names

2013-10-29 Thread Kai Wasserbäch
Tom Stellard schrieb am 29.10.2013 17:48: > On Sun, Oct 27, 2013 at 07:36:07PM +0100, Kai Wasserbäch wrote: >> Fixes a boat load of Piglit tests for me, which crashed like fdo#70913 >> before. >> >> Thanks to Michel Dänzer for the tip. >> >> Bugzilla: https

Re: [Mesa-dev] Fix crashes with static LLVM

2013-11-06 Thread Kai Wasserbäch
Dear Tom, Tom Stellard schrieb am 06.11.2013 01:24: > On Wed, Oct 23, 2013 at 04:26:18PM -0400, Tom Stellard wrote: >> The attached patches introduce linker scripts to the pipe-loader and >> egl-static targets. The linker scripts prevents these targets from >> exporting LLVM (and other) symbols th

Re: [Mesa-dev] libxatracker: automake and spurious symbols

2014-04-05 Thread Kai Wasserbäch
Dear Emil, Emil Velikov schrieb am 05.04.2014 04:10: > On 01/04/14 01:32, Emil Velikov wrote: >> On 29/03/14 14:24, Kai Wasserbäch wrote: >>> Emil Velikov schrieb am 29.03.2014 14:21: >>>> On 29/03/14 12:37, Kai Wasserbäch wrote: >>>>> I tried a versi

Re: [Mesa-dev] [PIGLIT,radeonsi] crash in spec/glsl-1.50/execution/geometry/max-input-components – who's bug is it?

2014-04-16 Thread Kai Wasserbäch
Michel Dänzer schrieb am 15.04.2014 09:27: > On 23.03.2014 04:53, Kai Wasserbäch wrote: >> Dear Mesa devs, >> I'm not sure whether this is a bug in Mesa, LLVM or in eglibc. The crash >> happens >> in _int_malloc, but since that is certainly one of the more ofte

Re: [Mesa-dev] [PIGLIT,radeonsi] crash in spec/glsl-1.50/execution/geometry/max-input-components fixed (was: crash in spec/glsl-1.50/execution/geometry/max-input-components – who's bug is it?)

2014-04-18 Thread Kai Wasserbäch
Hi there, Tom Stellard schrieb am 16.04.2014 17:07: > On Wed, Apr 16, 2014 at 02:36:19PM +0200, Kai Wasserbäch wrote: >> Michel Dänzer schrieb am 15.04.2014 09:27: >>> On 23.03.2014 04:53, Kai Wasserbäch wrote: >>>> Dear Mesa devs, >>>> I'm not sure w

Re: [Mesa-dev] [PIGLIT, radeonsi] crash in spec/glsl-1.50/execution/geometry/max-input-components fixed

2014-04-19 Thread Kai Wasserbäch
Hello Tom, Tom Stellard schrieb am 19.04.2014 06:37: > On Fri, Apr 18, 2014 at 06:59:37PM +0200, Kai Wasserbäch wrote: >> Tom Stellard schrieb am 16.04.2014 17:07: >>> Here is the branch: >>> http://cgit.freedesktop.org/~tstellar/llvm/log/?h=si-spill-fixes I noti

Re: [Mesa-dev] libxatracker: automake and spurious symbols

2014-04-27 Thread Kai Wasserbäch
o have been an issue with LLVM. I need to try a build with your branch on top again. I'll try that in the coming week. Cheers, Kai -- Kai Wasserbäch (Kai Wasserbaech) E-Mail: k...@dev.carbon-project.org signature.asc Description: OpenPGP digital signature ___

Re: [Mesa-dev] [PATCHES 0/9] Draw Indirect and Cube Map Arrays for RadeonSI

2014-04-27 Thread Kai Wasserbäch
eonsi: use an SGPR instead of VGT_INDX_OFFSET > radeonsi: don't add info->start to the index buffer offset > radeonsi: implement ARB_draw_indirect > > Marek > ___ > mesa-dev mailing list > mesa-dev@lists.freedeskto

[Mesa-dev] [PATCH] targets/opencl: Fix (static) linking with LLVM

2014-05-18 Thread Kai Wasserbäch
that), I need a radeonsi which carries its own LLVM within and doesn't care about what the runtime sets. Signed-off-by: Kai Wasserbäch --- src/gallium/targets/opencl/Makefile.am |2 ++ 1 file changed, 2 insertions(+) --- a/src/gallium/targets/opencl/Makefile.am +++ b/src/gallium/targ

[Mesa-dev] [PATCH] targets/opencl: Fix (static) linking with LLVM (v2)

2014-05-19 Thread Kai Wasserbäch
S off that), I need a radeonsi which carries its own LLVM within and doesn't care about what the runtime sets. This means linking Mesa statically. v1 → v2: Move logic to configure.ac Signed-off-by: Kai Wasserbäch --- Dear Emil, I hope this is the right place for adding the two additional mo

Re: [Mesa-dev] [PATCH] targets/opencl: Fix (static) linking with LLVM

2014-05-19 Thread Kai Wasserbäch
Michel Dänzer schrieb am 19.05.2014 04:12: > On 18.05.2014 18:37, Kai Wasserbäch wrote: >> >> And instead of just not starting, my X starts crashing, whenever >> libGL fails to load a (32 bit) driver. > > FWIW, some potential alternatives for avoiding the X crashes: &g

Re: [Mesa-dev] [PATCH] targets/opencl: Fix (static) linking with LLVM

2014-05-28 Thread Kai Wasserbäch
gain IIRC, that problem came up a while back for me). Cheers, Kai -- Kai Wasserbäch (Kai Wasserbaech) E-Mail: k...@dev.carbon-project.org signature.asc Description: OpenPGP digital signature ___ mesa-dev mailing list mesa-dev@lists.freed

[Mesa-dev] [PATCH] build: Fix FTBFS bug introduced by ee55500c22

2014-02-19 Thread Kai Wasserbäch
The referenced commit set the with_dri_drivers variable to "yes" in the auto case, which is an unknown classic DRI driver and leads to a FTBFS. CC: Emil Velikov Signed-off-by: Kai Wasserbäch --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf

Re: [Mesa-dev] [PIGLIT,radeonsi] crash in spec/glsl-1.50/execution/geometry/max-input-components – who's bug is it?

2014-03-25 Thread Kai Wasserbäch
Brian Paul schrieb am 24.03.2014 15:45: > On 03/22/2014 01:53 PM, Kai Wasserbäch wrote: >> Dear Mesa devs, >> I'm not sure whether this is a bug in Mesa, LLVM or in eglibc. The crash >> happens >> in _int_malloc, but since that is certainly one of the more ofte

Re: [Mesa-dev] libxatracker: automake and spurious symbols

2014-03-29 Thread Kai Wasserbäch
Hi Emil, Emil Velikov schrieb am 29.03.2014 14:21: > On 29/03/14 12:37, Kai Wasserbäch wrote: >> I saw one of your patches currently in review touching the Makefile.am of >> libxatracker. Can you squeeze in another patch, that ensures, that the >> library >> only expo

[Mesa-dev] autotools/meson transition: meson uses hardcoded list of llvm-config binaries, FTBFS with new upstream LLVM (development) versions

2019-01-19 Thread Kai Wasserbäch
Hey, I just discovered that meson hardcodes the list of llvm-config binary names to try in mesonbuild/dependencies/dev.py, line 214ff ([0]). This is breaking now since LLVM upstream switched to version 9 and branched version 8 of to become a stable release soon. See [1] for the upstream ticket I fi

[Mesa-dev] [PATCH] Fix commit f9caabe8f1bff86d19b53d9ecba5c72b238d9e23

2015-09-12 Thread Kai Wasserbäch
One place in r600_llvm.c was forgotten when replacing R600_UCP_CONST_BUFFER with R600_BUFFER_INFO_CONST_BUFFER. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91985 CC: Dave Airlie Signed-off-by: Kai Wasserbäch --- Hi, this fixes a FTBFS after the commit mentioned above. If you accept

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Kai Wasserbäch
Ilia Mirkin wrote on 27.09.2015 08:33: > Signed-off-by: Ilia Mirkin > --- > src/mesa/Makefile.sources| 1 + > src/mesa/program/ir_to_mesa.cpp | 4 +- > src/mesa/state_tracker/st_atom.c | 5 + > src/mesa/state_tracker/st_atom.h | 5 +

Re: [Mesa-dev] [PATCH 4/4] st/mesa: enable AoA for gallium drivers reporting GLSL 1.30

2016-02-05 Thread Kai Wasserbäch
Hey Dave, can you mention Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92059 A large part of the problems with Middle-earth: Shadow of Mordor stem from radeonsi not having AoA, which should be fixed by this, right? Cheers, Kai Dave Airlie wrote on 05.02.2016 04:40: > From: Dave Airl

Re: [Mesa-dev] [PATCH] mesa/extensions: Fix NVX_gpu_memory_info lexicographical order.

2016-02-06 Thread Kai Wasserbäch
Hey Vinson, I would say the test is wrong. If I sort as a human, "NV_" comes before "NVX_". And running this through sort (the tool), it agrees: $ echo -e "NVX_gpu_memory_info\nNV_blend_square" | sort -d NV_blend_square NVX_gpu_memory_info From src/mesa/main/tests/mesa_extensions.cpp I'm seeing

[Mesa-dev] [PATCH] i965/build: Fix FTBFS due to incorrect variable initialisation

2016-04-21 Thread Kai Wasserbäch
Broken since b27c85c4c089109339fc37135d0a4d2574024632 Cc: Rob Herring Cc: Emil Velikov Signed-off-by: Kai Wasserbäch --- Hi, without this I'm getting error during autoreconf: src/mesa/drivers/dri/i965/Makefile.am:57: error: BUILT_SOURCES must be set with '=' before using

Re: [Mesa-dev] [PATCH 5/5] clover: Add environment variables for dumping kernel code v2

2014-10-09 Thread Kai Wasserbäch
Tom Stellard wrote on 09.10.2014 17:07: > There are two debug variables: > > CLOVER_DEBUG which you can set to any combination of llvm,clc,asm > (separated by commas) to dump llvm IR, OpenCL C, and native assembly. > > CLOVER_DEBUG_FILE which you can set to a file name for dumping output > instea

Re: [Mesa-dev] [PATCH 00/14] [v2] Famous Gallium Nine

2014-10-21 Thread Kai Wasserbäch
Hello, according to DRI3 is mandatory. But AFAICT you only enforce "has Gallium3D drivers" in the configure checks introduced in . I would find it better, if configure died, in case I'm try

Re: [Mesa-dev] [PATCH 00/14] [v2] Famous Gallium Nine

2014-10-23 Thread Kai Wasserbäch
Axel Davy wrote on 22.10.2014 07:41: > On 21/10/2014 18:30, Kai Wasserbäch wrote : >> Hello, >> according to <https://wiki.ixit.cz/d3d9> DRI3 is mandatory. But AFAICT you >> only >> enforce "has Gallium3D drivers" in the configure checks introduced in

Re: [Mesa-dev] [PATCH RFC 1/1] configure: Drop LLVM_COMPONENTS

2014-10-23 Thread Kai Wasserbäch
You can have my Tested-by: Kai Wasserbäch for that, since it is essentially the same as attachment 108315 from bug 85380. Please add a reference to that bug report. And now I abuse this to send a ping for the fix for bug 70410 (there should be a patch for this on the list): can we add "--s

Re: [Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-10-24 Thread Kai Wasserbäch
Hi Jan, Jan Vesely wrote on 24.10.2014 19:03: > -Wl,--exclude-libs prevents automatic export of symbols > > > CC: Kai Wasserbach > CC: Emil Velikov > Signed-off-by: Jan Vesely > --- > > Kai, > can you try this patch with your setup, and check whether LLVM symbols are > exported from mesa libr

Re: [Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-10-26 Thread Kai Wasserbäch
Hi Jan, Jan Vesely wrote on 24.10.2014 23:30: > On Fri, 2014-10-24 at 22:42 +0200, Kai Wasserbäch wrote: >> Jan Vesely wrote on 24.10.2014 19:03: >>> -Wl,--exclude-libs prevents automatic export of symbols >>> >>> >>> CC: Kai Wasserbach >&g

Re: [Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-10-27 Thread Kai Wasserbäch
ch (attempts to) resolve :( > > you are right. I don't know why I thought it was still a problem. > In that case the attached patch should fix compiling with llvm static > libs (#70410) this patch on top of attachment 108315 from bug 85380 gives a successful build with current Git

Re: [Mesa-dev] tinderbox build regression

2014-11-16 Thread Kai Wasserbäch
Dear Dave, Dave Airlie wrote on 16.11.2014 06:20: > no idea but I'm picking Emil as the culprit! I've seen the same failure, but a more recent LLVM 3.6 fixed it for me. I can report LLVM SVN r222082 as working. Cheers, Kai signature.asc Description: OpenPGP digital signature __

Re: [Mesa-dev] tinderbox build regression

2014-11-16 Thread Kai Wasserbäch
Kai Wasserbäch wrote on 16.11.2014 11:49: > Dear Dave, > Dave Airlie wrote on 16.11.2014 06:20: >> no idea but I'm picking Emil as the culprit! > > I've seen the same failure, but a more recent LLVM 3.6 fixed it for me. I can > report LLVM SVN r222082 as working.

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Kai Wasserbäch
Michel Dänzer wrote on 12.03.2015 08:15: > On 11.03.2015 05:07, Vivek Dasmohapatra wrote: >> Hi - As you probably already know, there can only be one version of >> libstdc++.so in your runtime link chain - This is usually not a problem, >> but when things are linked against the Steam runtime (for e

Re: [Mesa-dev] [PATCH] gallium/swr: explicity use llvm legacy FunctionPassManager

2016-03-03 Thread Kai Wasserbäch
Tim Rowley wrote on 03.03.2016 18:20: > swr uses the legacy FunctionPassManager for llvm-3.6 compatibility, > but a change to llvm headers in 3.9 includes the new version as well. > Explicity use the legacy version to prevent ambiguity. > --- > src/gallium/drivers/swr/rasterizer/jitter/JitManager.

Re: [Mesa-dev] [PATCH 17/17] GL3.txt: Mark ARB_framebuffer_no_attachments as done

2016-03-19 Thread Kai Wasserbäch
Edward O'Callaghan wrote on 19.03.2016 07:41: > Signed-off-by: Edward O'Callaghan > --- > docs/GL3.txt | 2 +- > docs/relnotes/11.3.0.html | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index 3058996..b9fc86b 100644 > --- a/do

Re: [Mesa-dev] [PATCH 1/4] automake: loader: rework the CPPFLAGS

2015-11-19 Thread Kai Wasserbäch
Hey Emil, you can have my Tested-by: Kai Wasserbäch for the series. I just did a build (amd64 and i386) and didn't see the additional symbols show up again. Thanks for taking care of this! Cheers, Kai Emil Velikov wrote on 19.11.2015 17:33: > From: Emil Velikov > &g

Re: [Mesa-dev] [PATCH 01/20] glapi: add ARB_gpu_shader_fp64 (v2)

2014-09-04 Thread Kai Wasserbäch
40, -1 }, > + { "glUniformMatrix3dv", 40, -1 }, > + { "glUniformMatrix4dv", 40, -1 }, > + { "glUniformMatrix2x3dv", 40, -1 }, > + { "glUniformMatrix2x4dv", 40, -1 }, > + { "glUniformMatrix3x2dv", 40, -1 }, > + { "g

Re: [Mesa-dev] Bug in 17.1.0-rc4 source packaging for swr?

2017-05-18 Thread Kai Wasserbäch
Hey, Emil Velikov wrote on 18.05.2017 18:17: > On 18 May 2017 at 16:34, Rowley, Timothy O wrote: >> We could use a gen_builder.h generated from llvm-3.9 for all current >> versions of llvm at this time (as the changes are now just llvm IR >> additions), but I’m not sure how to enforce that the per

Re: [Mesa-dev] [PATCH v2 3/3] drirc: Add allow_glsl_builtin_variable_redeclaration for Dying Light and Dead Island Definitive Edition

2017-05-20 Thread Kai Wasserbäch
Hey, John Brooks wrote on 15.05.2017 07:47: > This fixes the long-standing problem with Dying Light where the game would > produce a black screen when running under Mesa. This happened because the > game's vertex shaders redeclare gl_VertexID, which is a GLSL builtin. > Mesa's GLSL compiler is a li

[Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

2017-10-17 Thread Kai Wasserbäch
driver has nothing to do with that kernel interface and is rather a Mesa internal versioning of an interface. See eg. the thread beginning at <https://lists.freedesktop.org/archives/amd-gfx/2017-October/014544.html> for an example. Signed-off-by: Kai Wasserbäch --- src/egl/drivers/dri2/

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

2017-10-17 Thread Kai Wasserbäch
Michel Dänzer wrote on 17.10.2017 17:42: > On 17/10/17 05:26 PM, Kai Wasserbäch wrote: >> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver >> name. This causes confusion, because there is a kernel interface by the >> same name w

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

2017-10-17 Thread Kai Wasserbäch
Hey Eric, Eric Engestrom wrote on 17.10.2017 18:31: > On Tuesday, 2017-10-17 15:26:00 +0000, Kai Wasserbäch wrote: >> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver >> name. This causes confusion, because there is a kernel interface by

[Mesa-dev] [PATCH] egl/dri2: disambiguate driver name (v2)

2017-10-17 Thread Kai Wasserbäch
ober/014544.html> for the exchange that sparked this patch. v2: - Fix commit message. (Michel Dänzer) - Don't capitalise "Mesa" in the driver name. (Eric Engestrom) Signed-off-by: Kai Wasserbäch --- src/egl/drivers/dri2/egl_dri2.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

2017-10-18 Thread Kai Wasserbäch
Hey Eric, Eric Engestrom wrote on 17.10.2017 19:48: > On Tuesday, 2017-10-17 17:20:13 +, Emil Velikov wrote: >> [...] >> Yes name is a bit misleading, so I'm wondering if any of the following >> won't be better >> - s/DRI2/DRI/ - might be tad confusing >> - emit the corresponding DRI2 vs DRI3

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] disk_cache: reduce default cache size to 5% of filesystem

2017-04-29 Thread Kai Wasserbäch
Hey, Marek Olšák wrote on 29.04.2017 12:49: > On Apr 29, 2017 11:27 AM, "Timothy Arceri" wrote: > On 29/04/17 18:44, Marek Olšák wrote: >> [...] >> >> That's a good point. I didn't think of that. Still, if one game evicts all >> entries, the cache may be almost as good as disabled. >> > > I'm hap

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN >= r302589

2017-05-10 Thread Kai Wasserbäch
Michel Dänzer wrote on 10.05.2017 10:27: > From: Michel Dänzer > > deregisterEHFrames doesn't take any parameters anymore. > > Signed-off-by: Michel Dänzer LGTM, CC stable? > --- > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions

Re: [Mesa-dev] Has anyone stressed radeonsi memory?

2017-11-15 Thread Kai Wasserbäch
Hey Matias, Matias N. Goldberg wrote on 15.11.2017 16:51: >> Why, doesn't your distro have LLVM development packages? > They aren't as up to date. Keeping up-to-date with everything mesa needs is > exhausting. > I started compiling LLVM from source when I needed to test an LLVM patch to > fix a G

Re: [Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

2017-11-15 Thread Kai Wasserbäch
2" name was reported as confusing when printing EGL infos (one > user reported thinking DRI3 was not working on his X server), and the > only alternative is Haiku, which can only be used on a Haiku machine. > > The name therefore doesn't add any information that the user wouldn'

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Kai Wasserbäch
Doesn't the meson.build file need the same change? Nicolai Hähnle wrote on 15.11.2017 12:55: > From: Nicolai Hähnle > > It is required for LLVM anyway. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 > Fixes: 7f33e94e43a6 ("amd/addrlib: update to latest version") > --- > src/

[Mesa-dev] [PATCH] docs: Point to apt.llvm.org for development snapshot packages

2017-11-16 Thread Kai Wasserbäch
Cc: Eric Engestrom Signed-off-by: Kai Wasserbäch --- docs/llvmpipe.html | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index e4676920ed..12dccb5eae 100644 --- a/docs/llvmpipe.html +++ b/docs/llvmpipe.html @@ -50,6 +50,12 @@ It's the fa

Re: [Mesa-dev] [PATCH] docs: Point to apt.llvm.org for development snapshot packages

2017-11-16 Thread Kai Wasserbäch
Can you push for me? I don't have access. Eric Engestrom wrote on 16.11.2017 13:04: > On Thursday, 2017-11-16 12:58:50 +0100, Kai Wasserbäch wrote: >> Cc: Eric Engestrom > > Thanks! > Reviewed-by: Eric Engestrom > >> Signed-off-by: Kai Wasserbäch &

Re: [Mesa-dev] [PATCH] radeonsi: try flushing unflushed fences in si_fence_finish even when timeout == 0

2017-11-25 Thread Kai Wasserbäch
uring loading without this fix. > > Fixes: bc65dcab3bc4 ("radeonsi: avoid syncing the driver thread in > si_fence_finish") Tested-by: Kai Wasserbäch Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103902 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10390

  1   2   3   >