Re: [Mesa-dev] [PATCH 3/3] mesa: implement mipmap generation for compressed 2D array textures

2013-07-24 Thread Jose Fonseca
Series looks alright AFAICT. Jose - Original Message - > We weren't looping over all the slices in the array. The updated > code should also correctly handle 3D compressed textures too, whenever > we have that feature. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66850 >

Re: [Mesa-dev] [PATCH] draw: fix vertex id computation

2013-07-25 Thread Jose Fonseca
Looks good. Thanks. Jose - Original Message - > vertex id has to be unaffected by the start index (i.e. when calling > draw arrays with start_index = 5, the first vertex_id has to still > be 0, not 5) and it has to be equal to the index when performing > indexed rendering (in which case i

Re: [Mesa-dev] [PATCH] gallivm: Remove NoFramePointerElimNonLeaf for LLVM >= 3.4.

2013-07-25 Thread Jose Fonseca
> ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] SNORM conversion equation woes

2013-07-27 Thread Jose Fonseca
D3D10 specifies equation 2.3 (and I'm sure so that D3D9). So probably all hardware can handle it. I'm surprised that formula 2.2 even exists, and that OpenGL could have been so lax about it. Jose - Original Message - > Hello all, > > I've been looking at https://bugs.freedesktop.org/s

Re: [Mesa-dev] [PATCH] mesa: improve free() cleanup in generate_mipmap_compressed()

2013-07-27 Thread Jose Fonseca
> GLenum target, >} > } /* loop over mipmap levels */ > > +end: > free(temp_src); > free(temp_dst); > free(temp_src_slices); > -- > 1.7.10.4 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] tgsi: handle texel swizzles correctly for d3d10-style sample opcodes

2013-07-27 Thread Jose Fonseca
Series looks good to me. You should add a mention of this in src/gallium/docs/source/tgsi.rst too as it is not an obvious feature. Jose - Original Message - > From: Roland Scheidegger > > Same as for gallivm (though these don't quite work correctly in softpipe, > so untested). > --- >

Re: [Mesa-dev] [PATCH 2/2] gallivm: fix float->SNORM conversion

2013-07-27 Thread Jose Fonseca
Series looks alright AFAICT. Jose - Original Message - > From: Roland Scheidegger > > Just like the UNORM case we need to use round to nearest, not trunc. > (There's also another problem, we're using the formula for SNORM->float > which will produce a value below -1.0 for the most negat

Re: [Mesa-dev] [PATCH] gallivm: obey clarified shift behavior

2013-07-31 Thread Jose Fonseca
- Original Message - > > From: Roland Scheidegger > > > > llvm shifts are undefined for shift counts exceeding (or matching) bit > > width, > > so need to apply a mask for the tgsi shift instructions. > > > > v2: only use mask for the tgsi shift instructions, not for the build shift >

Re: [Mesa-dev] [PATCH] tgsi: add ucmp to the list of opcodes

2013-07-31 Thread Jose Fonseca
LE_POS) > OP12(SAMPLE_INFO) > > +OP13(UCMP) > + > > #undef OP00 > #undef OP01 > -- > 1.7.10.4 > Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices

2013-07-31 Thread Jose Fonseca
- Original Message - > On Tue, Jul 30, 2013 at 8:46 PM, Paul Berry wrote: > > On 29 July 2013 11:09, Zack Rusin wrote: > >> > >> That looks wrong to me. We already account for the "other fields" in the > >> vertex_size. > > > > > > This patch came from Bryan Cain's original geometry shade

Re: [Mesa-dev] [PATCH 1/2] llvmpipe: make the front-face behavior match the gallium spec

2013-08-01 Thread Jose Fonseca
ldFSub(builder, a0_0f, > + lp_build_const_float(gallivm, 0.5), > + ""); > + LLVMValueRef a0 = vec4f(gallivm, face_val, zero, zero, zero, "facing"); > LLVMValueRef zerovec = vec4f_from_scalar(gallivm

Re: [Mesa-dev] [PATCH 2/2] draw: inject frontface info into wireframe outputs

2013-08-01 Thread Jose Fonseca
- Original Message - > > > +   if (draw_will_inject_frontface(lp_context->draw) && > > I think it's annoying you have to do these calls to determine if there's > > a valid frontface here for each line instead of just per draw call but > > it doesn't seem easy to avoid it. > > Yea, there'

Re: [Mesa-dev] [PATCH] gallivm: do clamping of border color correctly for all formats

2013-08-19 Thread Jose Fonseca
Looks alright to me. I just wonder if it would be possible to factor this logic into a separate function somehow. Jose - Original Message - > From: Roland Scheidegger > > Turns out it is actually very complicated to figure out what a format really > is wrt range, as using channel info

Re: [Mesa-dev] [PATCH 3/3] util: add avx2 and xop detection to cpu detection code

2013-08-20 Thread Jose Fonseca
Series looks good to me. Jose - Original Message - > From: Roland Scheidegger > > Going to need this soon (not going to bother with avx2 intrinsics at this > time > but don't want to do workarounds for true vector shifts if llvm itself can > use > them just fine and won't need the gazil

Re: [Mesa-dev] [PATCH 2/2] gallivm: add comment for bogus min/mag filter selection with nearest mip filter

2013-08-21 Thread Jose Fonseca
Series looks good. You might want to promote XXX to FIXME. Fixing wouldn't be hard -- just need to pass some additional parameters to this function, so that we can check that MIN/MAG filter are same. Jose - Original Message - > From: Roland Scheidegger > > Detected this hunting some

Re: [Mesa-dev] [PATCH 1/2] gallivm: (trivial) fix linear aos sampling of 3d compressed formats

2013-08-22 Thread Jose Fonseca
Great catch! Jose - Original Message - > From: Roland Scheidegger > > block size depth is always 1 even for compressed formats (unless someone > invents true 3d compressed formats at least which we can't represent). > Nearest (and soa) path had it right. > --- > src/gallium/auxiliary/g

Re: [Mesa-dev] tgsi dump and parsing

2013-08-27 Thread Jose Fonseca
- Original Message - > On 08/26/2013 02:38 AM, Dave Airlie wrote: > > Hi TGSI guys mostly :-) > > > > So I'm wondering how circular and perfect tgsi->text->tgsi roundabouts > > should be, > > Ideally, they should be consistent. > > > > currently the TGSI dump code uses .4f in one place

Re: [Mesa-dev] tgsi dump and parsing

2013-08-28 Thread Jose Fonseca
- Original Message - > On Wed, Aug 28, 2013 at 3:32 PM, Dave Airlie wrote: > >>> IMM[0] FLT32 { 0x, 0x, 0x, 0x } # 1.0, 3.0, 2.0, 4.0 > >> > >> If you use "%.9g" instead of "%.4f" then floating point numbers will be > >> preserved without loss of precision. > >> > > > > I

Re: [Mesa-dev] [PATCH] draw: fix segfaults with aaline and aapoint stages disabled

2013-08-28 Thread Jose Fonseca
draw_aaline_prepare_outputs(draw, draw->pipeline.aaline); > } > > /** > -- > 1.8.1.2 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] tgsi dump and parsing

2013-08-28 Thread Jose Fonseca
reak them. > > Marek > > On Wed, Aug 28, 2013 at 3:57 PM, Jose Fonseca wrote: > > - Original Message - > >> On Wed, Aug 28, 2013 at 3:32 PM, Dave Airlie wrote: > >> >>> IMM[0] FLT32 { 0x, 0x, 0x, 0x } # 1.0, 3.0, 2.0, 4.0 &g

Re: [Mesa-dev] [PATCH 1/2] gallivm: refactor num_lods handling

2013-08-28 Thread Jose Fonseca
LGTM. Jose - Original Message - > From: Roland Scheidegger > > This is just preparation for per-pixel (or per-quad in case of multiple > quads) > min/mag filter since some assumptions about number of miplevels being equal > to number of lods no longer holds true. > This change does not

Re: [Mesa-dev] [PATCH 2/2] gallivm: (trivial) don't pass sampler_unit variable down to filtering funcs

2013-08-30 Thread Jose Fonseca
Series looks good to me. Jose - Original Message - > From: Roland Scheidegger > > The only reason this was needed was because the fetch texel function had to > get the (dynamic) border color, but this is now done much earlier. > --- > src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c |

Re: [Mesa-dev] [PATCH 3/3] gallivm: handle unbound textures in texture sampling / texture queries

2013-08-30 Thread Jose Fonseca
Series LGTM. Jose - Original Message - > From: Roland Scheidegger > > Turns out we don't need to do much extra work for detecting this case, > since we are guaranteed to get a empty static texture state in this case, > hence just rely on format being 0 and return all zero then. > Previo

Re: [Mesa-dev] [PATCH] llvmpipe: Remove the special path for TGSI_OPCODE_EXP.

2013-09-11 Thread Jose Fonseca
Replying privately. See also http://bugzilla.eng.vmware.com/show_bug.cgi?id=999655#c5 Jose - Original Message - > Hmm sure it is rarely used (for arb_vp and d3d9 vs 1.1 (2.0 too maybe > though the semantics are different there even if the precision required > is the same)? > The proble

Re: [Mesa-dev] [PATCH] llvmpipe: Remove the special path for TGSI_OPCODE_EXP.

2013-09-11 Thread Jose Fonseca
GLSL does not use it. vs_2_0 does not use it either http://msdn.microsoft.com/en-us/library/windows/desktop/bb173373(v=vs.85).aspx D3D10 doesn't have similar thing neither. It just didn't seem worth to keep this special path. And it seemed hard to fix it without breaking NaN/Inf correctness.

Re: [Mesa-dev] [PATCH] gallivm: some bits of seamless cube filtering implementation

2013-09-17 Thread Jose Fonseca
LGTM. Jose - Original Message - > From: Roland Scheidegger > > Simply adjust wrap mode to clamp_to_edge. This is all that's needed for a > correct implementation for nearest filtering, and it's way better than > using repeat wrap for instance for linear filtering (though obviously this

Re: [Mesa-dev] [PATCH 3/3] util/u_blit: Implement util_blit_pixels via pipe_context::blit.

2013-09-18 Thread Jose Fonseca
- Original Message - > Isn't u_blit a candidate for removal considering it has no user in Mesa? u_blit still has users outside mesa. And it provides features that pipe_context::blit does not: - util_blit_pixels() will call pipe_context::resource_copy for non-stretch blits, which is pote

Re: [Mesa-dev] [PATCH 2/3] util/u_blit: Support blits from cubemaps.

2013-09-18 Thread Jose Fonseca
- Original Message - > Am 17.09.2013 20:32, schrieb jfons...@vmware.com: > > From: José Fonseca > > > > By calling util_map_texcoords2d_onto_cubemap. > > > > A new parameter for util_blit_pixels_tex is necessary, as > > pipe_sampler_view::first_layer is always supposed to point to the fi

Re: [Mesa-dev] [PATCH] gallivm: adjust wrap mode to CLAMP_TO_EDGE always for cube maps.

2013-09-19 Thread Jose Fonseca
Sounds good to me. Thanks. Jose - Original Message - > From: Roland Scheidegger > > Technically without seamless filtering enabled GL allows any wrap mode, which > made sense when supporting true borders (can get seamless effect with border > and CLAMP_TO_BORDER), but gallium doesn't su

Re: [Mesa-dev] [PATCH 2/3] draw/clip: don't emit so many empty triangles

2013-09-20 Thread Jose Fonseca
- Original Message - > Am 19.09.2013 20:43, schrieb Zack Rusin: > > Compress empty triangles (don't emit more than one in a row) and > > never emit empty triangles if we already generated a triangle > > covering a non-null area. We can't skip all null-triangles > > because c_primitives ex

Re: [Mesa-dev] [PATCH] llvmpipe: we need to subdivide if fb is bigger in either direction

2013-09-25 Thread Jose Fonseca
- Original Message - > Am 24.09.2013 22:26, schrieb Zack Rusin: > > We need to subdivide triangles if either of the dimensions is > > larger than the max edge length, not when both of them are larger. > > > > Signed-off-by: Zack Rusin > > --- > > src/gallium/drivers/llvmpipe/lp_setup.c

Re: [Mesa-dev] [PATCH 1/3] gallivm: DIV shouldn't be deprecated.

2013-02-15 Thread Jose Fonseca
case TGSI_OPCODE_BRA: > - case TGSI_OPCODE_DIV: > case TGSI_OPCODE_PUSHA: > case TGSI_OPCODE_POPA: > case TGSI_OPCODE_SAD: > -- > 1.7.9.5 > Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] gallivm: fix src modifier fetching with non-float types.

2013-02-15 Thread Jose Fonseca
se. > + */ > + res = lp_build_negate( &bld_base->int_bld, res ); > + break; > + case TGSI_TYPE_VOID: > + default: > + /* dunno how that should work if legal just ignore? */ > + assert(0); > + break; >

Re: [Mesa-dev] [PATCH] gallivm/tgsi: fix src modifier fetching with non-float types.

2013-02-15 Thread Jose Fonseca
I think that we should probably allow signed everywhere. The operation and result may be unsigned, but the arguments may need to be negated to become unsigned. Imagine: int a = -1; unsigned b = 10 / (unsigned)-a; That is MOV TEMP[0], INT IMM{-1} UDIV TEMP[1], UINT IMM{10}, -TEMP

Re: [Mesa-dev] [PATCH] gallivm/tgsi: fix src modifier fetching with non-float types.

2013-02-15 Thread Jose Fonseca
; that rare) which should rather be explicit. > > Roland > > > Am 15.02.2013 16:32, schrieb Jose Fonseca: > > I think that we should probably allow signed everywhere. > > > > The operation and result may be unsigned, but the arguments may need to be > > negated t

Re: [Mesa-dev] [PATCH 2/2] trace: add context pointer sanity checking

2013-02-15 Thread Jose Fonseca
Both patches look great to me. Reviewed-by: Jose Fonseca - Original Message - > To help catch mixed up context pointer bugs in the future, add a > trace_context_check() function and some new assertions. > --- > src/gallium/drivers/trace/tr_context.c | 15 ++

Re: [Mesa-dev] [PATCH] llvmpipe: fix lp_resource_copy using more than one 3d slice

2013-02-19 Thread Jose Fonseca
Thanks for fixing this Roland. This is definitely an improvement. I'd recommend a few tweaks (it could even be as a follow on change): - Calling llvmpipe_flush_resource() in a loop is overkill (it will call llvmpipe_flush() to be called many times needlessly). Please refactor llvmpipe_flush_re

Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-19 Thread Jose Fonseca
There may be more vertex elements that used in the shader. But why should the key contain those elements? Won't this cause needless recompilations (e.g., in situations where the state tracker leaves unneeded elements from previous draw?)? That is, it seems to be that the key should have the num

Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-19 Thread Jose Fonseca
- Original Message - > Am 19.02.2013 15:57, schrieb Jose Fonseca: > > There may be more vertex elements that used in the shader. But why should > > the key contain those elements? Won't this cause needless recompilations > > (e.g., in situations where the sta

Re: [Mesa-dev] [PATCH] llvmpipe: lp_resource_copy cleanup

2013-02-19 Thread Jose Fonseca
igned int > llvmpipe_is_resource_referenced( struct pipe_context *pipe, > struct pipe_resource *presource, > - unsigned level, int layer) > + unsigned level) > { > struct llvmpipe_context *llvmpipe = llvm

Re: [Mesa-dev] [PATCH] st/mesa: fix trimming of GL_QUAD_STRIP

2013-02-20 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > We sometimes convert GL_QUAD_STRIP prims into GL_TRIANGLE_STRIP, but > that changes the results of the u_trim_pipe_prim() call. We need to > pass the original primitive type to the trim function. > > Note that OpenGL's GL_x prim type values

Re: [Mesa-dev] [PATCH] gallivm: fix indirect src register fetches requiring bitcast

2013-02-20 Thread Jose Fonseca
Good catch Roland. Reviewed-by: Jose Fonseca Jose - Original Message - > From: Roland Scheidegger > > For constant and temporary register fetches, the bitcasts weren't done > correctly for the indirect case, leading to crashes due to type mismatches. > Simply d

Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-21 Thread Jose Fonseca
Looks perfect. Thanks Roland. Jose - Original Message - > From: Roland Scheidegger > > Some parts calculated key size by using shader information, others by using > the pipe_vertex_element information. Since it is perfectly valid to have more > vertex_elements set than the vertex shade

Re: [Mesa-dev] [PATCH 1/2] gallium/docs: improve text about resources a bit.

2013-02-21 Thread Jose Fonseca
ly seamless if a driver supports it > (PIPE_CAP_SEAMLESS_CUBE_MAP), > +resulting in filtering taking samples from multiple surfaces near to the > edge. > > - Width and height must be equal > - If PIPE_CAP_NPOT_TEXTURES is not supported, > @@ -170,7 +175,6 @@ D3D11: 2D array textures with the > D3D11_RESOURCE_MISC_TEXTURECUBE flag > > - PIPE_CAP_NPOT_TEXTURES is equivalent to D3D_FEATURE_LEVEL_10_0 > - Cube map arrays require D3D_FEATURE_LEVEL_10_1 > -- TODO: are (non)seamless cube maps supported in D3D11? how? > > Surfaces > > -- > 1.7.9.5 > Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/4] llvmpipe: rename polygon offset fields to something more specific

2013-02-21 Thread Jose Fonseca
Series is Reviewed-by: Jose Fonseca - Original Message - > --- > src/gallium/drivers/llvmpipe/lp_state_setup.c | 15 +-- > src/gallium/drivers/llvmpipe/lp_state_setup.h |4 ++-- > 2 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/s

Re: [Mesa-dev] [PATCH] llvmpipe/build: add DLOPEN_LIBS and PTHREAD_LIBS to the lp_test_* targets

2013-02-22 Thread Jose Fonseca
a ../../auxiliary/libgallium.la > $(LLVM_LIBS) > +lp_test_printf_LDADD = $(TEST_LIBS) > nodist_EXTRA_lp_test_printf_SOURCES = dummy.cpp > > -- > 1.7.10.4 > > _______ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/me

Re: [Mesa-dev] [PATCH] llvmpipe: Fix rendering into PIPE_FORMAT_X8B8G8R8_UNORM.

2013-02-22 Thread Jose Fonseca
Roland found a better fix. Please ignore. Jose - Original Message - > From: José Fonseca > > Weird format, which Mesa state tracker recently started using. > > Fixes segfault in > > ./bin/texture-packed-formats -auto > > because swizzle[foo] was 0xff for padding channel (X). It sti

Re: [Mesa-dev] GL_ARB_debug_output from drivers

2013-02-23 Thread Jose Fonseca
- Original Message - > One of the features Valve asked for, that they expected after using other > drivers, is that they can easily get information about performance traps > (and other important stuff) from drivers. We wrote INTEL_DEBUG=perf this > summer as a quick fix, but it's not how

Re: [Mesa-dev] [PATCH] llvmpipe: Fix creation of shared and scanout textures.

2013-02-23 Thread Jose Fonseca
Pushed now. - Original Message - > I'd still like to have this applied. > > On Tue, Dec 18, 2012 at 3:16 PM, John Kåre Alsaker > wrote: > > On Tue, Dec 18, 2012 at 11:20 AM, Jose Fonseca wrote: > >> Looks fine. > >> > >> I'm curio

Re: [Mesa-dev] [PATCH] draw: make sure pipeline is revalidated when sampler views or samplers change.

2013-02-25 Thread Jose Fonseca
p_sampler_static_texture_state(struct > lp_static_texture_state *state, > state->level_zero_only = !view->u.tex.last_level; > > /* > -* FIXME: Handle the remainder of pipe_sampler_view. > +* the layer / element / level parameters are all either dynamic > +

Re: [Mesa-dev] [PATCH] mesa: flush current state when querying GL_EDGE_FLAG

2013-02-25 Thread Jose Fonseca
[ "EDGE_FLAG", "LOC_CUSTOM, TYPE_BOOLEAN, 0, extra_flush_current" ], >[ "FEEDBACK_BUFFER_SIZE", "CONTEXT_INT(Feedback.BufferSize), NO_EXTRA" ], >[ "FEEDBACK_BUFFER_TYPE", "CONTEXT_ENUM(Feedback.Type), NO_EXTRA" ], >

Re: [Mesa-dev] [PATCH] texobj: add verbose api trace messages to several routines

2013-02-27 Thread Jose Fonseca
- Original Message - > Jordan Justen writes: > > > Motivated by wanting to see if GenTextures was called by an > > application while debugging another Steam overlay issue. > > Making a systematic MESA_DEBUG=api using dispatch tables and code > generation seems like it would be nice inste

Re: [Mesa-dev] [PATCH] llvmpipe: support rendering to buffer render targets.

2013-02-27 Thread Jose Fonseca
- Original Message - > What is this good for? Is it for UAVs? (unordered access views) No, it is just a standard D3D10 feature: http://msdn.microsoft.com/en-gb/library/windows/desktop/bb204897.aspx Not sure if there's a particular use case for it (e.g, maybe DirectCompute uses this exte

Re: [Mesa-dev] [PATCH] llvmpipe: support rendering to buffer render targets.

2013-02-27 Thread Jose Fonseca
Looks good. I think the u_surface change could go in separately though. BTW, now that we can render/sampler from buffers, llvmpipe_is_resource_referenced needs to be updated: buffer may be referenced if they have BIND_SAMPLER/RENDERTARGET. Weshould do something like if !BIND_SAMPLER/RENDERTARG

Re: [Mesa-dev] [PATCH] texobj: add verbose api trace messages to several routines

2013-02-27 Thread Jose Fonseca
- Original Message - > On Wed, Feb 27, 2013 at 1:21 AM, Jose Fonseca wrote: > > - Original Message - > >> Jordan Justen writes: > >> > >> > Motivated by wanting to see if GenTextures was called by an > >> > application while debu

Re: [Mesa-dev] [MESA][PATCH] tgsi: fix mis-matching AOS instruction emission

2013-02-27 Thread Jose Fonseca
Good catch. Thanks! Jose - Original Message - > Catched this that morning > > > From e50374e62254e7532c695bebb3e608242638bb73 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= < maxence.led...@gmail.com > > Date: Wed, 27 Feb 2013 10:24:10 +0100 > Subject: [PATCH] tgs

Re: [Mesa-dev] RFC: enforcing gallium resource bind flags

2013-03-01 Thread Jose Fonseca
- Original Message - > On Fri, Mar 1, 2013 at 12:31 AM, Roland Scheidegger > wrote: > > Hi, > > > > there is some sloppy usage of bind flags in the opengl state tracker > > (that is, resources get used for things which they didn't have the bind > > flag set). > > We'd really like to enforc

Re: [Mesa-dev] RFC: enforcing gallium resource bind flags

2013-03-01 Thread Jose Fonseca
- Original Message - > On 01.03.2013 11:30, Jose Fonseca wrote: > > - Original Message - > >> On Fri, Mar 1, 2013 at 12:31 AM, Roland Scheidegger > >> wrote: > >>> Hi, > >>> > >>> there is some sloppy usage of bind

Re: [Mesa-dev] [PATCH] texobj: add verbose api trace messages to several routines

2013-03-05 Thread Jose Fonseca
I expected that when one sets TRACE_LIBGL env var with the path for the true libGL.so.1, then apitrace wouldn't be picking up symbols the overlay -- it would be taking symbols only from the true libGL.so, there avoiding infinite recursion. Jose - Original Message ----- > Jose

Re: [Mesa-dev] [PATCH] texobj: add verbose api trace messages to several routines

2013-03-05 Thread Jose Fonseca
- Original Message - > > > On Mon, 4 Mar 2013, Carl Worth wrote: > > > I don't think it should be too hard to get this to work, (though it > > may require a source change to the Steam overlay). I'll do some more > > experiments tomorrow and see if I can't make a concrete recommendation

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: tweak CMD_BLOCK_MAX and LP_SCENE_MAX_SIZE

2013-03-06 Thread Jose Fonseca
Looks good. Thanks for fine tuning these parameters! Jose - Original Message - > We advertise a max texture/surfaces size of 8K x 8K but the old values > for these limits didn't actually allow us to handle that surface size. > > For 8K x 8K we'll have 16384 bins.  Each bin needs at least

Re: [Mesa-dev] [PATCH] llvmpipe: remove the power of two sizeof(struct cmd_block) assertion

2013-03-07 Thread Jose Fonseca
> -- > 1.7.3.4 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] draw/gs: Correctly iterate the emitted primitives

2013-03-08 Thread Jose Fonseca
er, >} > } > *p_output = output; > - shader->emitted_primitives += num_primitives; > + shader->emitted_primitives += num_primitives; > } > > /*#define DEBUG_INPUTS 1*/ > -- > 1.7.10.4 > Series looks great Zack Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] tgsi: emit code for SVIEWINFO and SAMPLE_I

2013-03-08 Thread Jose Fonseca
Patches 1-2 look good to me. Still going through patch 3. Jose - Original Message - > From: Roland Scheidegger > > Can handle them since the single sampler interface was introduced. > --- > src/gallium/auxiliary/tgsi/tgsi_exec.c | 18 +- > 1 file changed, 13 insertion

Re: [Mesa-dev] [PATCH 3/3] softpipe: don't use samplers with prebaked sampler and sampler_view state

2013-03-08 Thread Jose Fonseca
- Original Message - > From: Roland Scheidegger > > This is needed for handling the dx10-style sample opcodes. > This also simplifies the logic by getting rid of sampler variants > completely (sampler_views though OTOH have sort of variants because > some of their state is different depen

Re: [Mesa-dev] [PATCH 3/3] softpipe: don't use samplers with prebaked sampler and sampler_view state

2013-03-08 Thread Jose Fonseca
- Original Message - > Am 08.03.2013 21:03, schrieb Jose Fonseca: > > - Original Message - > >> From: Roland Scheidegger > >> > >> This is needed for handling the dx10-style sample opcodes. > >> This also simplifies the logic by ge

Re: [Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

2013-03-09 Thread Jose Fonseca
Looks a sensible thing to do. Reviewed-by: Jose Fonseca Any insight how the caller can be fixed so that this doesn't happen? Jose - Original Message - > With the current code, the sampler count can become higher than > PIPE_MAX_SAMPLERS and once it gets to the driver this

Re: [Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

2013-03-09 Thread Jose Fonseca
- Original Message - > On Sat, Mar 9, 2013 at 12:30 PM, Jose Fonseca wrote: > > Looks a sensible thing to do. > > > > Reviewed-by: Jose Fonseca > > > > Thanks for the review. > > > Any insight how the caller can be fixed so that this doesn

[Mesa-dev] [PATCH 1/2] d3d1x: Remove.

2013-03-11 Thread Jose Fonseca
First email was too long, so re-sending just the interesting bits) From: José Fonseca Unused/unmaintained. --- configure.ac | 21 - src/gallium/docs/source/context.rst|2 +- src/gallium/state_trackers/d3d1x/.gitignore| 20 -

Re: [Mesa-dev] [PATCH 1/2] d3d1x: Remove.

2013-03-11 Thread Jose Fonseca
- Original Message - > On 11.03.2013 11:26, Jose Fonseca wrote: > > First email was too long, so re-sending just the interesting bits) > > Please tell me removing this came to mind because you're going to > release a better D3D9,10/11 state tracker :) > (Nah I

Re: [Mesa-dev] [PATCH 7/7] tgsi: use separate structure for indirect address

2013-03-11 Thread Jose Fonseca
Christian, I didn't comment on the previous threads, but the approach mentioned in http://lists.freedesktop.org/archives/mesa-dev/2012-November/030476.html seems sensible to me. I think after the first round we should have this in a branch to allow drivers to catch up with the interface change

Re: [Mesa-dev] [PATCH 2/2] mesa: Speedup the xrgb -> argb special case in fast_read_rgba_pixels_memcpy

2013-03-11 Thread Jose Fonseca
I'm surprised this is is faster. In particular, for big things we'll be touching memory twice. Did you measure the speed up? Jose - Original Message - > --- > src/mesa/main/readpix.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/readpix.c

Re: [Mesa-dev] [PATCH 08/18] build: Move src/mapi/mapi/* to src/mapi/

2013-03-11 Thread Jose Fonseca
- Original Message - > hot to build mesa > in > windows > use > mingw scons ? > > if use `scons platform=windows toolchain=crossmingw machine=x86 build=release > mesagdi libgl-gdi` > > will happan > > [build\windows-x86\mesa\libmesa.a] Error 1 > > without any tips Surely there must be

Re: [Mesa-dev] [PATCH] gallivm: clean up passing derivatives around

2013-03-11 Thread Jose Fonseca
I only skimmed, but looks good in principle. Jose - Original Message - > From: Roland Scheidegger > > Previously, the derivatives were calculated and passed in a packed form > to the sample code (for implicit derivatives, explicit derivatives were > packed to the same format). > There's

Re: [Mesa-dev] [PATCH 2/2] mesa: Speedup the xrgb -> argb special case in fast_read_rgba_pixels_memcpy

2013-03-11 Thread Jose Fonseca
- Original Message - > On 03/11/2013 07:56 AM, Jose Fonseca wrote: > > I'm surprised this is is faster. > > > > In particular, for big things we'll be touching memory twice. > > > > Did you measure the speed up? > > The second hit is cache

Re: [Mesa-dev] [PATCH 2/2] mesa: Speedup the xrgb -> argb special case in fast_read_rgba_pixels_memcpy

2013-03-11 Thread Jose Fonseca
- Original Message - > On 03/11/2013 11:30 AM, Jose Fonseca wrote: > > - Original Message - > >> On 03/11/2013 07:56 AM, Jose Fonseca wrote: > >>> I'm surprised this is is faster. > >>> > >>> In particular, for big

Re: [Mesa-dev] [PATCH 7/7] tgsi: use separate structure for indirect address

2013-03-11 Thread Jose Fonseca
- Original Message - > Am 11.03.2013 15:52, schrieb Jose Fonseca: > > Christian, > > > > I didn't comment on the previous threads, but the approach mentioned in > > http://lists.freedesktop.org/archives/mesa-dev/2012-November/030476.html > > seems

Re: [Mesa-dev] [PATCH 1/3] scons: Allows choosing VS 10 or 11.

2013-03-12 Thread Jose Fonseca
- Original Message - > On 03/12/2013 02:49 PM, Brian Paul wrote: > > On 03/12/2013 02:39 PM, jfons...@vmware.com wrote: > >> From: José Fonseca > >> > >> --- > >> common.py | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/common.py b/common.py > >> index 6ff9

Re: [Mesa-dev] [RFC] Solving the TGSI indirect addressing optimization problem

2013-03-12 Thread Jose Fonseca
- Original Message - > On Tue, Mar 12, 2013 at 10:31 AM, Christian König > wrote: > > Am 12.03.2013 02:48, schrieb Marek Olšák: > > > >> On Mon, Mar 11, 2013 at 1:44 PM, Christian König > >> wrote: > >>> > >>> Hi everybody, > >>> > >>> this problem has been open for quite some time now,

Re: [Mesa-dev] [PATCH] draw/so: Fix stream output with geometry shaders

2013-03-12 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > If geometry shader is present its stream output info should > be used instead of the vs and we shouldn't use the pre-clipped > corrdinates. > > Signed-off-by: Zack Rusin > --- > .../draw/draw_pt_fetch_shade_pipeline_llvm.c |2 +- >

Re: [Mesa-dev] [PATCH 2/7] st/osmesa: new OSMesa gallium state tracker

2013-03-12 Thread Jose Fonseca
This patch has some #if near the end. It's not clear if it should be removed or completed. Otherwise the series looks good AFAICT. Jose - Original Message - > --- > src/gallium/state_trackers/osmesa/osmesa.c | 828 > > 1 files changed, 828 insertions

Re: [Mesa-dev] Mesa (master): mesa, gallium, egl, mapi: One definition of C99 inline/ __func__ to rule them all.

2013-03-13 Thread Jose Fonseca
ck'. > > On 03/12/2013 03:07 PM, Jose Fonseca wrote: > > Module: Mesa > > Branch: master > > Commit: 70fe7c6d3e1c7534f6598c4616bebf672f42668b > > URL: > > https://urldefense.proofpoint.com/v1/url?u=http://cgit.freedesktop.org/mesa/mesa/commit/?id%3D70fe7c6d3

Re: [Mesa-dev] Mesa (master): mesa, gallium, egl, mapi: One definition of C99 inline/ __func__ to rule them all.

2013-03-13 Thread Jose Fonseca
busted with the recent autotools changes. > > Jose > > - Original Message - > > I'm pretty sure this commit broke 'make check'. > > > > On 03/12/2013 03:07 PM, Jose Fonseca wrote: > > > Module: Mesa > > > Branch:

Re: [Mesa-dev] Mesa (master): mesa, gallium, egl, mapi: One definition of C99 inline/ __func__ to rule them all.

2013-03-13 Thread Jose Fonseca
- Original Message - > On 03/13/2013 01:14 AM, Jose Fonseca wrote: > > Sorry. I'll look into it. I did try running make locally, but it was not > > representative because it didn't have everything enabled. > > > > BTW, scons is also busted with the rece

Re: [Mesa-dev] [PATCH] gallium: add TGSI_SEMANTIC_TEXCOORD,PCOORD

2013-03-13 Thread Jose Fonseca
- Original Message - > Second attempt, 2 years ago no one replied or cared ... > > We really need to know about these on nvc0 because there are only 8 > fixed hardware locations that can be overwritten by sprite coordinates, > and one location that represents gl_PointCoord and unconditiona

Re: [Mesa-dev] [PATCH 3/3] tgsi: fix sample_d emit for arrays

2013-03-13 Thread Jose Fonseca
Series looks good to me. Reviewed-by: Jose Fonseca - Original Message - > From: Roland Scheidegger > > Those cases were apparently forgotten. > --- > src/gallium/auxiliary/tgsi/tgsi_exec.c | 30 +++--- > 1 file changed, 11 insertion

Re: [Mesa-dev] [PATCH] softpipe: fix up NUM_ENTRIES confusion

2013-03-14 Thread Jose Fonseca
Looks good. Thanks. I saw this warning transiently, but then couldn't see it again -- completely forgot that I needed to rebuild in order to force a recompile. Jose - Original Message - > There were two different NUM_ENTRIES #defines for the framebuffer > tile cache and the texture tile

[Mesa-dev] RFC: C11 threads.h

2013-03-14 Thread Jose Fonseca
Mesa source tree currently has 4 abstraction of threading primitives (in gallium, glapi, mapi, and egl components). I'd like to unify all them, and since now the C11 standard introduced a threads.h header, I'd like to use that as model. So for I've imported a C11 threads.h implementation from

Re: [Mesa-dev] RFC: C11 threads.h

2013-03-15 Thread Jose Fonseca
- Original Message - > On 03/14/2013 05:10 PM, Jose Fonseca wrote: > > Mesa source tree currently has 4 abstraction of threading primitives (in > > gallium, glapi, mapi, and egl components). > > > > I'd like to unify all them, and since now the C11 sta

Re: [Mesa-dev] [PATCH] gallivm: fix return opcode handling in main function of a shader

2013-03-18 Thread Jose Fonseca
Looks good to me.  Please add all necessary test cases to cover all these code paths. Good stuff guys. Very subtle code indeed. Jose - Original Message - > From: Roland Scheidegger > > If we're in some conditional or loop we must not return, or the code > after the condition is never

Re: [Mesa-dev] Error while compiling the MAPI directory

2013-03-18 Thread Jose Fonseca
- Original Message - > > > Hi, > > I am receiving the following error while compiling the code in the mapi > directory. I am using mesa 7.5. If you're compiling with MSVC I'd recommend using a recent Mesa release and save your self a world of trouble. It's known to build well there. I

Re: [Mesa-dev] [PATCH 1/2] gallium/sw: allow for negative strides in some places

2013-03-19 Thread Jose Fonseca
I think this is fine in principle, but I believe it's better to be exhaustive now than to waste time debugging unsigned/signed stride mismatches later. Especially all src/gallium/auxiliary/util modules should be updated: - src/gallium/auxiliary/util/u_format_* - src/gallium/auxiliary/util/u_surf

Re: [Mesa-dev] [PATCH 2/2] gallium: add texture update hook to screen

2013-03-19 Thread Jose Fonseca
- Original Message - > On Tue, Mar 19, 2013 at 8:29 AM, Dave Airlie wrote: > >> Errr, what about using flush_frontbuffer, it seems todo > >> the exact same thing. > > Hmm I wonder if I could overload it actually I hadn't considered that, > > its not exactly the same thing, > > but its pret

Re: [Mesa-dev] [RFC] preparation for qxl sw wrapper driver

2013-03-19 Thread Jose Fonseca
- Original Message - > So we have this virtual GPU with nothing approaching a 3D engine, > so we are currently running llvmpipe with drisw on it. However > this incurs some overheads that now that we have a kernel driver, > I believe we can remove. > > The main overheads are putimage for a

Re: [Mesa-dev] [PATCH] winsys/svga: improve error/debug message output

2013-03-19 Thread Jose Fonseca
LGTM. Jose - Original Message - > Use vmw_printf() just for extra debugging info (off by default). > Use vmw_error() for real errors/failures/etc that we definitely > want to report. > --- > src/gallium/winsys/svga/drm/vmw_context.h | 10 +++ > src/gallium/winsys/svga/drm/vmw_

Re: [Mesa-dev] [PATCH] tgsi: fix uninitialized declaration array fields

2013-03-19 Thread Jose Fonseca
> + full_declaration.Array = tgsi_default_declaration_array(); > > return full_declaration; > } > -- > 1.7.3.4 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Error while compiling the MAPI directory

2013-03-20 Thread Jose Fonseca
stant included? > #include MAPI_ABI_HEADER > > Thanks, > Ritvik > > -----Original Message- > From: Jose Fonseca [mailto:jfons...@vmware.com] > Sent: Monday, March 18, 2013 11:29 PM > To: Sharma, Ritvik > Cc: mesa-dev@lists.freedesktop.org > Subje

Re: [Mesa-dev] Error while compiling the MAPI directory

2013-03-20 Thread Jose Fonseca
t; makefilesand not the makefiles given in the mesa kit. Could this be a reason > for why I am getting the errors? >How are the python functions initializing the C constants? > > Thanks, > Ritvik > > -Original Message- > From: Jose Fonseca [mailto:jfons...@vmw

Re: [Mesa-dev] [PATCH] llvmpipe: add EXT_packed_float render target format support

2013-03-22 Thread Jose Fonseca
- Original Message - > From: Roland Scheidegger > > New conversion code to handle conversion from/to r11g11b10 AoS to/from > SoA floats, and also add code for conversion from rgb9e5 AoS to float SoA > (which works pretty much the same as r11g11b10 except for the packing). > (This code sho

Re: [Mesa-dev] [PATCH] llvmpipe: add EXT_packed_float render target format support

2013-03-22 Thread Jose Fonseca
- Original Message - > Am 22.03.2013 13:28, schrieb Jose Fonseca: > >> @@ -1009,6 +1020,17 @@ lp_blend_type_from_format_desc(const struct > >> util_format_description *format_desc > >> unsigned i; > >> unsigned chan;

<    1   2   3   4   5   6   7   8   9   10   >