ions
*/
-#define BITSET_WORDS(bits) (ALIGN(bits, BITSET_WORDBITS) / BITSET_WORDBITS)
+#define BITSET_WORDS(bits) ((bits + BITSET_WORDBITS - 1) / BITSET_WORDBITS)
bits -> (bits)
just in case...
#define BITSET_DECLARE(name, bits) BITSET_WORD name[BITSET_WORDS(bits)]
/* bi
On 13/02/15 00:49, Eric Anholt wrote:
Jose Fonseca writes:
Thanks for doing this. I appreciate it.
I have no objection with the series. I'm happy to see more reuse. We
can always move things around later, and it will be much easier when
then are less entangled/duplicated.
We'
Series looks good to me. It's a nice cleanup on its own right.
Reviewed-by: Jose Fonseca
Jose
On 23/02/15 04:31, Matt Turner wrote:
---
This series is attempting to make some progress towards moving u_math.h
to src/util.
include/c99_compat.h
Reviewed-by: Jose Fonseca
On 23/02/15 15:39, Brian Paul wrote:
Bugzilla:
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D89260&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVL
For series
Reviewed-by: Jose Fonseca
23/02/15 15:59, Brian Paul wrote:
Also, wrapping the array in #ifdef DEBUG / #endif doesn't seem necessary.
---
src/gallium/auxiliary/util/u_debug.c | 45 +---
1 file changed, 21 insertions(+), 24 deletions(-)
On 24/02/15 23:30, Brian Paul wrote:
---
src/mesa/main/imports.h | 8
src/mesa/main/light.c| 2 +-
src/mesa/math/m_matrix.c | 4 ++--
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h
index 356f0e1..d886427 100644
On 26/02/15 09:19, Erik Faye-Lund wrote:
On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund wrote:
On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner wrote:
On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote:
Should be defined in math.h. If not, we can add them to c99_math.h
And FWIW, the MSDN pa
lude "glsl_types.h"
#include "ir.h"
Series looks good AFAICT. Nice seeing all these cleanups!
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
MSVC 2008 (shipped with Windows SDK 7.0.7600) is the oldest we
need to support. At least on llvmpipe, gallium/auxiliary, and util
modules. For the remaining modules (particular all OpenGL specific
code) can be built with MSVC 2013.
---
include/c99_compat.h| 11 +++---
include/c99
On 26/02/15 00:06, Brian Paul wrote:
Just to keep things consistent.
---
src/gallium/include/pipe/p_defines.h | 66
1 file changed, 36 insertions(+), 30 deletions(-)
diff --git a/src/gallium/include/pipe/p_defines.h
b/src/gallium/include/pipe/p_defines.h
ed-by: Jose Fonseca
which switched over a bunch of preprocessor checks around __builtin*
calls to use the macros defined by autotools.
So I think cleaning it up to use __builtin_ffs* first #ifdef
HAVE___BUILTIN_* can go forward now.
Yes but there is no HAVE_FFSLL for constructs like
#if !de
On 26/02/15 13:42, Jose Fonseca wrote:
On 26/02/15 03:55, Jonathan Gray wrote:
On Wed, Feb 25, 2015 at 07:09:26PM -0800, Matt Turner wrote:
On Wed, Feb 25, 2015 at 7:03 PM, Jonathan Gray wrote:
On Wed, Feb 25, 2015 at 06:53:14PM -0800, Matt Turner wrote:
On Wed, Feb 25, 2015 at 5:37 PM
On 26/02/15 15:39, Brian Paul wrote:
On 02/26/2015 05:07 AM, Jose Fonseca wrote:
On 26/02/15 09:19, Erik Faye-Lund wrote:
On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund
wrote:
On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner
wrote:
On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote:
Should
This is to enable the code to build with -Werror=vla in the short term,
and enable the code to build with MSVC2013 soon after.
---
include/c99_alloca.h | 45
src/glsl/nir/nir_from_ssa.c | 19 +++
src/glsl/nir/nir_live_variab
The main objective of this change is to enable Linux developers to use
more of C99 throughout Mesa, with confidence that the portions that need
to be built with MSVC -- and only those portions --, stay portable.
This is achieved by using the appropriate -Werror= options only on the
places they nee
On 26/02/15 15:27, Emil Velikov wrote:
On 26/02/15 12:09, Jose Fonseca wrote:
MSVC 2008 (shipped with Windows SDK 7.0.7600) is the oldest we
need to support. At least on llvmpipe, gallium/auxiliary, and util
modules. For the remaining modules (particular all OpenGL specific
code) can be built
+/* This is to ensure that we get M_PI, etc. definitions */
+#if defined(_MSC_VER) && !defined(_USE_MATH_DEFINES)
+#error _USE_MATH_DEFINES define required when building with MSVC
+#endif
Thanks. It could be moved inside the `#if defined(_MSC_VER)` too.
Either way
Reviewed-by: Jose Fo
On 26/02/15 18:07, Brian Paul wrote:
On 02/26/2015 09:51 AM, Jose Fonseca wrote:
This is to enable the code to build with -Werror=vla in the short term,
and enable the code to build with MSVC2013 soon after.
---
include/c99_alloca.h | 45
It's unmaintained, and most likely broken: I use trace driver every now
and then, and everytime I do I need to fix it up.
It's also unused: identity_screen_create is never called.
Above all, it's dead weight: if identity driver had the infrastructure
for other pass-through drivers (like trace and
As we're gaining momentum cleanup Mesa code, I think it would help if we
also removed some stale components.
What do people feel about removing:
- src/mesa/drivers/windows/gdi -- the old SW rasterizer for Windows -- I
haven't used in a very long time, and given that the old SW rasterizer
is s
reviews too as soon as I can.
Jose
From: Tom Stellard
Sent: 27 February 2015 16:21
To: Jose Fonseca
Cc: mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to
enable safe use of C99 features where p
I think this is fine now.
We need to update SCons to be less pedantic about the
-Wdeclaration-after-statement / -Wpointer-arith this on a per-directory-basis,
like my recent configure.ac change.
Jose
From: mesa-dev on behalf of Brian Paul
Sent: 27 F
Thanks!
From: mesa-dev on behalf of Matt
Turner
Sent: 27 February 2015 19:48
To: mesa-dev@lists.freedesktop.org
Subject: [Mesa-dev] [PATCH] mapi: Don't rely on GNU void pointer arithmetic.
Commit 79daa510c added -Werror=pointer-arith to CFLAGS, which mak
On 28/02/15 00:25, Kenneth Graunke wrote:
On Friday, February 27, 2015 09:58:51 PM Jose Fonseca wrote:
Sorry, this didn't pop up when I built it here. And I'm afraid I won't have
time to look into this today, and possibly the weekend.
If there's not an obvious fix feel f
On 27/02/15 22:50, Jason Ekstrand wrote:
On Fri, Feb 27, 2015 at 6:04 AM, Jose Fonseca mailto:jfons...@vmware.com>> wrote:
On 26/02/15 18:07, Brian Paul wrote:
On 02/26/2015 09:51 AM, Jose Fonseca wrote:
This is to enable the code to build with -Werror=vla
On 27/02/15 16:15, Brian Paul wrote:
On 02/27/2015 09:10 AM, Ian Romanick wrote:
On 02/26/2015 10:07 AM, Brian Paul wrote:
On 02/26/2015 09:51 AM, Jose Fonseca wrote:
This is to enable the code to build with -Werror=vla in the short term,
and enable the code to build with MSVC2013 soon after
On 27/02/15 15:59, Ian Romanick wrote:
I like the idea as it should prevent future thrash. There are a couple
comments below.
On 02/26/2015 08:51 AM, Jose Fonseca wrote:
The main objective of this change is to enable Linux developers to use
more of C99 throughout Mesa, with confidence that
On 28/02/15 00:24, Rob Clark wrote:
On Fri, Feb 27, 2015 at 5:05 PM, Emil Velikov wrote:
- src/gallium/drivers/rbug: -- do people use it? does it work? it
predates apitrace GL + GUI, which sort of enables a lot of the same
things, but without the issue of having to hit moving target, which is
On 02/03/15 19:42, Kenneth Graunke wrote:
On Monday, March 02, 2015 03:24:18 PM Jose Fonseca wrote:
On 28/02/15 00:25, Kenneth Graunke wrote:
On Friday, February 27, 2015 09:58:51 PM Jose Fonseca wrote:
Sorry, this didn't pop up when I built it here. And I'm afraid I won't hav
On 03/03/15 11:59, Emil Velikov wrote:
On 3 March 2015 at 09:36, Jose Fonseca wrote:
On 28/02/15 00:24, Rob Clark wrote:
On Fri, Feb 27, 2015 at 5:05 PM, Emil Velikov
wrote:
- src/gallium/drivers/rbug: -- do people use it? does it work? it
predates apitrace GL + GUI, which sort of
On 27/02/15 15:16, Jose Fonseca wrote:
As we're gaining momentum cleanup Mesa code, I think it would help if we
also removed some stale components.
What do people feel about removing:
- src/mesa/drivers/windows/gdi -- the old SW rasterizer for Windows -- I
haven't used in a very long
v2:
- Single statement, by using memset return value as suggested by Ian
Romanick.
- No internal declaration, as suggested by Jason Ekstrand.
- Move macros to a header.
---
src/glsl/nir/nir_from_ssa.c | 23 ++-
src/glsl/nir/nir_live_variables.c| 4 +--
src/glsl/nir/nir_lo
On 02/03/15 20:03, Jason Ekstrand wrote:
On Mon, Mar 2, 2015 at 8:02 AM, Jose Fonseca mailto:jfons...@vmware.com>> wrote:
On 27/02/15 16:15, Brian Paul wrote:
On 02/27/2015 09:10 AM, Ian Romanick wrote:
On 02/26/2015 10:07 AM, Brian Paul wrote:
On 03/03/15 15:57, Brian Paul wrote:
We're using both of these in Mesa/gallium. It would be nice to
consistently just use C99's __func__ everywhere. This would be any easy
task for someone looking for something simple to do.
We could then get rid of this (broken) chunk seen in both compiler.h
On 03/03/15 12:31, Jose Fonseca wrote:
On 27/02/15 15:16, Jose Fonseca wrote:
As we're gaining momentum cleanup Mesa code, I think it would help if we
also removed some stale components.
What do people feel about removing:
- src/mesa/drivers/windows/gdi -- the old SW rasterizer for Wi
On 03/03/15 20:56, Jan Vesely wrote:
On Tue, 2015-03-03 at 10:07 -0700, Brian Paul wrote:
On 03/03/2015 09:56 AM, Jose Fonseca wrote:
On 03/03/15 15:57, Brian Paul wrote:
We're using both of these in Mesa/gallium. It would be nice to
consistently just use C99's __func__ everywh
On 03/03/15 18:39, Emil Velikov wrote:
On 3 March 2015 at 17:16, Jose Fonseca wrote:
...
I've prototyped this in
https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_-7Ejrfonseca_mesa_log_-3Fh-3Dremove-2Dst-2Degl&d=AwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
On 04/03/15 00:24, Emil Velikov wrote:
On 03/03/15 22:04, Jose Fonseca wrote:
On 03/03/15 18:39, Emil Velikov wrote:
On 3 March 2015 at 17:16, Jose Fonseca wrote:
...
I've prototyped this in
https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_-7Ejrfonseca_mesa
On 04/03/15 02:00, Emil Velikov wrote:
On 27 February 2015 at 23:28, Sedat Dilek wrote:
On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov wrote:
On 07/02/15 21:44, Sedat Dilek wrote:
Hi,
I was building mesa v10.4.4 with my llvm-toolchain v3.6.0rc2.
My build breaks like this...
...
Please cher
On 04/03/15 04:20, Matt Turner wrote:
On Tue, Mar 3, 2015 at 8:07 PM, Brian Paul wrote:
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
b/src/gallium/auxiliary/gallivm/lp_bld_
On 04/03/15 12:58, Jose Fonseca wrote:
On 04/03/15 04:20, Matt Turner wrote:
On Tue, Mar 3, 2015 at 8:07 PM, Brian Paul wrote:
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
---
scons/gallium.py | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/scons/gallium.py b/scons/gallium.py
index f839758..7533f06 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -369,20 +369,16 @@ def generate(env):
'HAVE___BUILTIN
Matching what we already do with autotools builds.
---
scons/gallium.py| 27 ---
src/egl/main/SConscript | 2 ++
src/gallium/auxiliary/SConscript| 4
src/gallium/drivers/llvmpipe/SConscript | 2 ++
src/glsl/SConscript
/u_thread.h
@@ -44,7 +44,7 @@
#include
#include
-#include "u_compiler.h"
+#include "c99_compat.h"
#include "c11/threads.h"
Series looks good to me.
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Although we don't deploy these, we need to use them for debugging.
---
src/gallium/drivers/softpipe/Makefile.am | 3 ++-
src/gallium/drivers/softpipe/SConscript | 1 +
src/gallium/drivers/trace/Makefile.am| 3 ++-
src/gallium/drivers/trace/SConscript | 2 ++
4 files changed, 7 insertions(
---
src/gallium/drivers/svga/Makefile.am | 3 ++-
src/gallium/drivers/svga/SConscript | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/svga/Makefile.am
b/src/gallium/drivers/svga/Makefile.am
index 50d44cf..e0a8cad 100644
--- a/src/gallium/drivers/svga/Mak
Reviewed-by: Jose Fonseca
On 04/03/15 17:49, Mark Janes wrote:
Due to recent #include changes, `make check` fails on glx-test. The
target requires a standard include path to find util/macros.h.
---
src/glx/tests/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glx/tests
t_table;
#endif
}
diff --git a/src/mapi/u_execmem.c b/src/mapi/u_execmem.c
index ad6427b..89d5c1d 100644
--- a/src/mapi/u_execmem.c
+++ b/src/mapi/u_execmem.c
@@ -33,7 +33,7 @@
#include "c99_compat.h"
-#include "u_thread.h"
+#include "c11/threads.h"
#include "u_execmem.h"
Nice cleanup. Series is
Reviewed-by: Jose Fonseca
Jose
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
/osmesa.c
@@ -33,6 +33,7 @@
*/
+#include
#include "main/glheader.h"
#include "GL/osmesa.h"
#include "main/api_exec.h"
Series is
Reviewed-by: Jose Fonseca
Jose
___
mesa-dev mailing list
mesa-
Thanks for doing this. It looks great.
Reviewed-by: Jose Fonseca
Feel free to push my patch or I'll push it after you push this one.
Jose
On 05/03/15 00:37, Mark Janes wrote:
System headers may contain C++ declarations, which cannot be given C
linkage. For this reason, in
On 06/03/15 00:11, Mark Janes wrote:
Matt Turner writes:
On Thu, Mar 5, 2015 at 4:54 AM, Jose Fonseca wrote:
Thanks for doing this. It looks great.
Reviewed-by: Jose Fonseca
Feel free to push my patch or I'll push it after you push this one.
Thanks José. I've just
On 06/03/15 14:26, Brian Paul wrote:
On 03/06/2015 05:34 AM, Emil Velikov wrote:
Replace the _MSC_VER >= 1200 with defined (_MSC_VER) and compact if/else
statements. We require MSVC 2008 or later with commit 46110c5d564.
Signed-off-by: Emil Velikov
---
src/util/macros.h | 8 +++-
1 file
uot;C"
+#endif
+
#endif
Series looks good to me too. Thanks.
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 06/03/15 18:26, Brian Paul wrote:
On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote:
Used for aligned_alloc and other C11 functions missing from the header.
Signed-off-by: Emil Velikov mailto:emil.l.veli...@gmail.com>>
---
include/c11_stdl
On 07/03/15 07:23, Jose Fonseca wrote:
On 06/03/15 18:26, Brian Paul wrote:
On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote:
Used for aligned_alloc and other C11 functions missing from the
header.
Signed-off-by: Emil Velikov mailto:emil.
On 07/03/15 19:38, Emil Velikov wrote:
On 07/03/15 07:23, Jose Fonseca wrote:
...
we still
didn't eliminate the use of non-portable _MTX_INITIALIZER_NP from Mesa
tree gave me pause.
The only way I can think about resolving this, is to use call_once() to
initialize the mutex,
Yes, I
GSI_OPCODE_BGNSUB:
+ TXT( " :" );
+ UID( inst->Label.Label );
+ break;
+ }
}
/* update indentation */
LGTM.
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 23/02/17 21:54, Adam Jackson wrote:
On Thu, 2017-02-23 at 21:59 +0100, Roland Scheidegger wrote:
So, what does the failing test do?
Not much, curiously. There are five that fail and they're all fairly
trivial, although the xts harness makes that hard to see.
XClearArea/6 and XClearWindow/
On 20/02/17 20:28, Roland Scheidegger wrote:
Am 20.02.2017 um 20:56 schrieb Marek Olšák:
On Mon, Feb 20, 2017 at 8:29 PM, Axel Davy wrote:
On 20/02/2017 20:11, Ilia Mirkin wrote:
On Mon, Feb 20, 2017 at 2:01 PM, Marek Olšák wrote:
Hi,
I'd like to remove pipe_context::set_index_buffer. It
On 23/07/15 17:06, Jose Fonseca wrote:
On 20/07/15 21:39, Jose Fonseca wrote:
On 20/07/15 18:35, Tom Stellard wrote:
All LLVM API calls that require an ostream object have been removed from
the disassemble() function, so we don't need to use this class to wrap
_debug_printf() we can just
On 29/07/15 13:35, Tom Stellard wrote:
On Wed, Jul 29, 2015 at 09:54:05AM +0100, Jose Fonseca wrote:
On 23/07/15 17:06, Jose Fonseca wrote:
On 20/07/15 21:39, Jose Fonseca wrote:
On 20/07/15 18:35, Tom Stellard wrote:
All LLVM API calls that require an ostream object have been removed from
That's correct. We should use the inttypes.h PRI*PTR specifiers for
portability.
Unfortunately there's no such format specificier for size_t or ssize_t,
but I believe intptr_t should match on all platforms we support.
Jose
On 30/07/15 00:53, Ilia Mirkin wrote:
I assume that you mean the C
To avoid collission with windows.h's PURE macro.
We could consider eventually renaming to __pure, but that would require
further care, so it's left to the future.
---
src/util/macros.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/macros.h b/src/util/macros.h
in
---
src/util/SConscript | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/util/SConscript b/src/util/SConscript
index 9e4d481..3dbe70a 100644
--- a/src/util/SConscript
+++ b/src/util/SConscript
@@ -54,3 +54,10 @@ u_atomic_test = env.Program(
)
alias = env.Alias("u_atomic_test", u_at
Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a problem as
it doesn't define __x86_64__ macro (it's GCC specific.)
However on Windows long type is guaranteed to be 32bits.
Also add an #error, as GCC will just warn, not throw any error, when no
value is returned.
Trivial.
---
s
As currently only GCC x86_64 builds where using it.
---
src/util/rounding.h | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/src/util/rounding.h b/src/util/rounding.h
index ec31b47..38c1c2f 100644
--- a/src/util/rounding.h
+++ b/src/util/rounding.h
@@ -27,7 +27
On 09/08/15 17:47, Matt Turner wrote:
On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote:
Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a problem as
it doesn't define __x86_64__ macro (it's GCC specific.)
However on Windows long type is guaranteed to be 32bits.
A
On 09/08/15 17:47, Matt Turner wrote:
On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote:
As currently only GCC x86_64 builds where using it.
---
src/util/rounding.h | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/src/util/rounding.h b/src/util
On 09/08/15 19:08, Jose Fonseca wrote:
On 09/08/15 17:47, Matt Turner wrote:
On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote:
Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a
problem as
it doesn't define __x86_64__ macro (it's GCC specific.)
However on Windows
On 09/08/15 21:21, Roland Scheidegger wrote:
Am 09.08.2015 um 20:08 schrieb Jose Fonseca:
On 09/08/15 17:47, Matt Turner wrote:
On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote:
Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a
problem as
it doesn't define __x86_64__
On 09/08/15 21:30, Jose Fonseca wrote:
On 09/08/15 21:21, Roland Scheidegger wrote:
Am 09.08.2015 um 20:08 schrieb Jose Fonseca:
On 09/08/15 17:47, Matt Turner wrote:
On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca
wrote:
Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a
More portable. Based on Roland Scheidegger's idea.
Tested with roundevent_test on Linux, MinGW, and MSVC.
https://bugs.freedesktop.org/show_bug.cgi?id=91591
---
src/util/rounding.h | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/util/rounding.h b/src/uti
eviewed-by: Roland Scheidegger
Am 09.08.2015 um 23:40 schrieb Jose Fonseca:
More portable. Based on Roland Scheidegger's idea.
Tested with roundevent_test on Linux, MinGW, and MSVC.
https://bugs.freedesktop.org/show_bug.cgi?id=91591
---
src/util/rounding.h | 15 +++
1 f
On 09/08/15 23:30, Matt Turner wrote:
On Sun, Aug 9, 2015 at 2:40 PM, Jose Fonseca wrote:
More portable. Based on Roland Scheidegger's idea.
Tested with roundevent_test on Linux, MinGW, and MSVC.
https://bugs.freedesktop.org/show_bug.cgi?id=91591
---
src/util/rounding.h
On 17/08/15 18:14, Matt Turner wrote:
On Mon, Aug 17, 2015 at 9:46 AM, Francisco Jerez wrote:
This is basically just the same atomic functions exposed by
ARB_shader_image_load_store, with one exception:
"highp float imageAtomicExchange(
coherent IMAGE_PARAMS,
float dat
On 13/09/16 16:22, Steven Toth wrote:
AppVeyor is failing to build today (my github master - pulled from
mesa master this morning), its getting a 404 attempting to wget
win_flex_bison-2.4.5.zip from sourceforge during initialization.
To be fair, this is the first time I've ever used appveyor, an
On 13/09/16 17:44, Jose Fonseca wrote:
On 13/09/16 16:22, Steven Toth wrote:
AppVeyor is failing to build today (my github master - pulled from
mesa master this morning), its getting a 404 attempting to wget
win_flex_bison-2.4.5.zip from sourceforge during initialization.
To be fair, this is
const struct util_format_description *dst_desc)
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
This seems to have broke Windows builds.
It seems this is not only exporting symbols on GLESv2.so but everywhere.
It's not obvious how to fix it without basically revering this commit.
It's really easy to repro: just install your distro MinGW cross
compilers and do:
scons platform=window
On 23/09/16 18:26, Dylan Baker wrote:
Quoting Jose Fonseca (2016-09-23 05:01:12)
This seems to have broke Windows builds.
It seems this is not only exporting symbols on GLESv2.so but everywhere.
It's not obvious how to fix it without basically revering this commit.
It's really eas
On 23/09/16 20:17, Dylan Baker wrote:
Quoting Jose Fonseca (2016-09-23 11:11:18)
On 23/09/16 18:26, Dylan Baker wrote:
Quoting Jose Fonseca (2016-09-23 05:01:12)
This seems to have broke Windows builds.
It seems this is not only exporting symbols on GLESv2.so but everywhere.
It'
{
+ for (i = 0; i < TGSI_NUM_CHANNELS; i++) {
+inputs[j][i] = lp_build_zero(gallivm, vs_type);
+ }
+ }
+
for (i = 0; i < vector_length; ++i) {
LLVMValueRef vert_index =
LLVMBuildAdd(build
On 12/10/16 19:30, Emil Velikov wrote:
On 12 October 2016 at 19:14, Tobias Droste wrote:
Am Mittwoch, 12. Oktober 2016, 10:42:19 CEST schrieb Emil Velikov:
On 12 October 2016 at 00:02, Tobias Droste wrote:
gallium_require_llvm() {
-if test "x$MESA_LLVM" = x0; then
-case "$host
+ LLVMGetValueName(func), time_msec);
+ }
+
return jit_func;
}
Looks OK otherwise.
Reviewed-by: Brian Paul
Reviewed-by: Jose Fonseca
Jose
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Looks great to me!
Reviewed-by: José Fonseca
From: Roland Scheidegger
Sent: Friday, 14 October, 02:21
Subject: [PATCH] draw: improved handling of undefined inputs
To: Jose Fonseca, ML mesa-dev
Cc: Roland Scheidegger
From: Roland Scheidegger Previous attempts to zero initialize all inputs
se {
- min_depth = viewports[i].translate[2];
- max_depth = min_depth + viewports[i].scale[2];
- }
+ util_viewport_zmin_zmax(&viewports[i], lp->rasterizer->clip_halfz,
+ &min_depth, &max_depth);
if (setup->view
_layer + 1;
+ }
+ else {
+ zslice = surf->u.tex.first_layer;
+ layer = 0;
+ }
+
SVGA_DBG(DEBUG_VIEWS,
"svga: Surface propagate: tex %p, level %u, from %p\n",
tex, surf->u.tex.level, surf);
Series also looks good
On 29/08/16 22:30, Eric Engestrom wrote:
A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files
to try and enforce the formatting of the code, to which Michel Dänzer
suggested [1] we start by importing the existing .dir-locals.el
settings. The first draft was discussed in the RFC
Thanks for the update.
Reviewed-by: Jose Fonseca
If you need and there's no outstanding objections, I can push this
change for you.
Jose
On 30/08/16 21:02, Eric Engestrom wrote:
A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files
to try and enforce the formatting o
We're internally building and shipping Mesa compiled with GCC 4.4 (more
specifically 4.4.3).
It's fine if you require GCC 4.8 on automake, but please leave support
for GCC 4.4.x in SCons.
Jose
On 07/09/16 05:28, Timothy Arceri wrote:
The last time this was bumped we settled on 4.2.0 because
pe src_type,
+ struct lp_type dst_type,
+ LLVMValueRef lo,
+ LLVMValueRef hi);
+
+
+LLVMValueRef
lp_build_pack(struct gallivm_state *gallivm,
struct lp_type src_type,
struct lp_type dst_type,
Looks great!
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
wo integers and
* reports overflow if detected.
*
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit_overflow.h
b/src/gallium/auxiliary/gallivm/lp_bld_arit_overflow.h
index 8c35a04..34ce00e 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_arit_overflow.h
+++ b/src/gallium/auxiliary/
On 19/10/16 18:35, Matt Turner wrote:
On Wed, Oct 19, 2016 at 9:54 AM, Marek Olšák wrote:
On Wed, Oct 19, 2016 at 6:06 PM, Emil Velikov wrote:
On 19 October 2016 at 15:55, Marek Olšák wrote:
On Wed, Oct 19, 2016 at 12:47 PM, Emil Velikov wrote:
On 19 October 2016 at 11:35, Grigori Goronzy
On 19/10/16 20:38, Marek Olšák wrote:
On Wed, Oct 19, 2016 at 9:17 PM, Jose Fonseca wrote:
On 19/10/16 18:35, Matt Turner wrote:
On Wed, Oct 19, 2016 at 9:54 AM, Marek Olšák wrote:
On Wed, Oct 19, 2016 at 6:06 PM, Emil Velikov
wrote:
On 19 October 2016 at 15:55, Marek Olšák wrote
On 19/10/16 20:59, Jose Fonseca wrote:
On 19/10/16 20:38, Marek Olšák wrote:
On Wed, Oct 19, 2016 at 9:17 PM, Jose Fonseca
wrote:
On 19/10/16 18:35, Matt Turner wrote:
On Wed, Oct 19, 2016 at 9:54 AM, Marek Olšák wrote:
On Wed, Oct 19, 2016 at 6:06 PM, Emil Velikov
wrote:
On 19
On 19/10/16 21:00, Jose Fonseca wrote:
On 19/10/16 20:59, Jose Fonseca wrote:
On 19/10/16 20:38, Marek Olšák wrote:
On Wed, Oct 19, 2016 at 9:17 PM, Jose Fonseca
wrote:
On 19/10/16 18:35, Matt Turner wrote:
On Wed, Oct 19, 2016 at 9:54 AM, Marek Olšák wrote:
On Wed, Oct 19, 2016 at 6:06
Patch 1 looks good to me. Yes, not using compilation key is a recipe for
problems.
Regarding patch 2, I need a bit more time to review. I'd also like the new
lp_build_umul... function to be added to lp_bld_arit: there is a single caller
note, but that might change in the future, so might as we
src1, "");
- dst64 = LLVMBuildLShr(
-builder, dst64,
-lp_build_const_vec(bld_base->base.gallivm, type, 32), "");
- type.width = 32;
- typeRef = lp_build_vec_type(bld_base->base.gallivm, type);
- emit
On 07/11/16 19:09, Roland Scheidegger wrote:
Am 06.11.2016 um 16:50 schrieb Jose Fonseca:
On 04/11/16 04:14, srol...@vmware.com wrote:
From: Roland Scheidegger
This is used by shader umul_hi/imul_hi functions (and soon by draw).
It's actually useful separating this out on its own, ho
On 19/10/16 23:14, Marek Olšák wrote:
From: Marek Olšák
radeonsi needs these.
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 21 +
src/gallium/auxiliary/gallivm/lp_bld_misc.h | 6 ++
2 files changed, 27 insertions(+)
diff --git a/src/gallium/auxiliary/gallivm/l
101 - 200 of 2351 matches
Mail list logo
