On Mon, Apr 14, 2014 at 03:04:12PM -0700, Kenneth Graunke wrote:
> On 04/14/2014 06:30 AM, Chia-I Wu wrote:
> > On Mon, Apr 14, 2014 at 1:04 PM, Kenneth Graunke
> > wrote:
> >> We originally thought that GL 3.0 required GL_DEPTH_COMPONENT16 to map
> >> exactly to Z16. However, we misread the spe
On Mon, Apr 21, 2014 at 02:08:49PM -0700, Kenneth Graunke wrote:
> HiZ operations make the depth/render caches out of sync with the sampler
> caches. We need to arrange for a TC flush to happen before the target
> buffer is used by the sampler. Calling brw_render_cache_set_add_bo
> makes that hap
On Mon, Mar 24, 2014 at 09:07:32AM +1000, Dave Airlie wrote:
> On Sat, Mar 8, 2014 at 12:13 AM, Pohjolainen, Topi
> wrote:
> > On Mon, Mar 03, 2014 at 01:19:48PM +1000, Dave Airlie wrote:
> >> There is a comment and two checks in the i965 dma-buf importer,
> >>
> >> * Images originating via EGL_EX
This patch looks good to me.
Reviewed-by: Chad Versace
On Thu, Apr 24, 2014 at 04:32:08PM -0700, Sarah Sharp wrote:
> Chromium defined a new GL extension (that isn't registered with Khronos).
> We need to add an EGL extension for it, so we can migrate ChromeOS on
> Intel syst
it's totally broken.
Looks like a partial copy-paste error to me.
The Mesa header still needs an include guard even if upstream's header
is broken.
I replaced the trailing problematic #define with
#endif // GPU_EGL_EGLEXTCHROMIUM_H_
and that worked for me. Do that and this patch is
Rev
On Tue, Apr 29, 2014 at 01:21:11PM -0700, Eric Anholt wrote:
> Chad Versace writes:
>
> > On Mon, Mar 24, 2014 at 09:07:32AM +1000, Dave Airlie wrote:
> >> On Sat, Mar 8, 2014 at 12:13 AM, Pohjolainen, Topi
> >> wrote:
> >> > On Mon, Mar 03, 2
Patches 1-3 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
masks are set to 0.
> + */
But whatever.
Patch 4 is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
..
> + int cpp = mt->region->cpp;
I'm waiting for this ^ to die in the finale mega patch.
Patches up to here are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
of how
intel_bufferobj_alloc_buffer() performed its allocation.
I never feel comfortable with hidden knowledge dependencies like that. And this
patch removes the dependency.
Ditto for do_blit_readpixels() and try_pbo_upload().
Patches up to here are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
}
> -
> - *name = region->name;
> -
> - return true;
> -}
> -
Functions like intel_region_flink() make me sad. Good to see it die.
Patches up to here are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed, Apr 30, 2014 at 11:25:27PM -0700, Chad Versace wrote:
> On Tue, Apr 29, 2014 at 04:34:33PM -0700, Eric Anholt wrote:
> > Once a buffer has been named, drm_intel_bo_flink() is just a getter.
>
> Yep. Surprising but true. (Well, it surprised me).
>
> > diff --gi
ke code I wrote in my early days
in Mesa. Umm... I hope it wasn't really me that wrote that mess.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
ht to me. Embedding the bo directly into the image, me and you
discussed that long ago (late 2012?) and agreed it made sense.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
educed to use of an
> existing field in the __DRIimageRec, but I want this to be as mechanical
> of a change as possible.
Patches up to here are
Reviewed-by: Chad Versace
I'm done reviewing today. I want to finish reviewing the series tomorrow
on the
fer is never a stencil buffer nor multisampled in those
functions.
Add some assurance to the commit message and this patch is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Apr 29, 2014 at 04:34:41PM -0700, Eric Anholt wrote:
> src/mesa/drivers/dri/i965/intel_regions.c | 198
> --
Whoo! Patches up to here are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
me
In file included from brw_context.h:51:0,
from intel_batchbuffer.h:6,
from intel_screen.c:95:
/usr/include/libdrm/intel_bufmgr.h:123:6: note: expected 'struct
drm_intel_bo *' but argument is of type 'struct drm_intel_bo **'
void dr
e @file comment is now bogus. Kill it or replace it, and this patch is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
accessed by loader extensions
> + * (mostly located in intel_screen.c).
> */
Oops... I should've finished reading the series before replying to patch
17.
Patch 17 and 18 are now
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Apr 29, 2014 at 04:34:25PM -0700, Eric Anholt wrote:
> Here's the series for removing struct intel_region from the i965 driver.
> I think it's worth it for the code savings and reduced steps in allocating
> a miptree. Plus, it gave me a chance to rewrite some comments about the
> driver.
>
On Thu, May 01, 2014 at 02:12:00PM -0700, Eric Anholt wrote:
> Chad Versace writes:
>
> > On Tue, Apr 29, 2014 at 04:34:25PM -0700, Eric Anholt wrote:
> >> Here's the series for removing struct intel_region from the i965 driver.
> >> I think it's worth i
On Thu, May 01, 2014 at 02:10:39PM -0700, Eric Anholt wrote:
> Chad Versace writes:
>
> >> On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote:
> >
> >> > - intel_region_release(&intelBuffer->region);
> >> > + drm_intel_bo_unrefe
7;s ack on this.
When i965 still programmed the x/y offset in 3DSTATE_DEPTH_BUFFER to
trick the hardware into rendering to a specific miptree slice, then
hiz-enablement was per-slice. But that ceased being the case as of
20799c11eb8fbdd9adf0baf1d4d5a77c0deb68f3. (DISCLAIMER: I didn't review
207999c myself,
On Thu, May 08, 2014 at 11:06:01AM -0700, Kristian Høgsberg wrote:
> On Thu, May 8, 2014 at 8:49 AM, Emil Velikov wrote:
> > Cc: Kristian Høgsberg
> > Cc: Chad Versace
> > Signed-off-by: Emil Velikov
> > ---
> > src/egl/drivers/dri2/egl_dri2.c | 5 +++--
> &
ium header to
> change the last line from a #define to a #endif, which makes the header
> actually compile.
>
> Signed-off-by: Sarah Sharp
> Reviewed-by: Chad Versace
> Cc: Jamey Sharp
> Cc: Ian Romanick
> Cc: Stéphane Marchesin
> ---
>
> v3: Add an incl
On Tue, May 20, 2014 at 10:18:50AM -0700, Stéphane Marchesin wrote:
>
>
>
> On Tue, May 20, 2014 at 9:14 AM, Brian Paul wrote:
>
> It seems unusual for a new extension to be defined in its own header file
> rather than the eglext.h file.
>
> Is there a particular reason for that?
Beren, I committed this to master. Thanks for the fix.
On Thu, Mar 20, 2014 at 08:36:34AM +0100, Beren Minor wrote:
> EGL 1.4 Specification says that
> eglMakeCurrent(display, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT)
> can be used to release the current thread's ownership on the surfaces
>
ot;(git-xxx)".
This patch implements supports MESA_VERSION_STRING_EXTRA only for Android.
Other build systems are left as an excercise.
CC: Matt Turner
CC: Tapani Pälli
Signed-off-by: Chad Versace
---
src/mesa/Android.libmesa_dricore.mk | 4
src/mesa/main/version.c
On 04/23/2013 06:19 AM, Ian Romanick wrote:
On 04/23/2013 03:28 AM, Chad Versace wrote:
This allows maintainers/packagers/testers to tag the build with
information that will be reported by GL_VERSION.
If the environemt variable or make variable MESA_VERSION_STRING_EXTRA is
id=63447
Tested-by: Lu Hua
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/egl_dri2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 06a21d7..1011f27 100644
--- a/src/egl/drivers/dri2/egl_dri2.c
On 04/23/2013 09:19 PM, Eric Anholt wrote:
Chad Versace writes:
On 04/23/2013 06:19 AM, Ian Romanick wrote:
On 04/23/2013 03:28 AM, Chad Versace wrote:
This allows maintainers/packagers/testers to tag the build with
information that will be reported by GL_VERSION.
If the environemt
Patch is pushed. It sat on the list for 24 hours, and
without it all the glesconform suites segfault.
On 04/23/2013 09:47 AM, Chad Versace wrote:
The commit below exposed a bug in dri2_add_config.
commit 3998f8c6b5da1a223926249755e54d8f701f81ab
Author: Ralf Jung
Date: Tue Apr
Wayland pixmaps were removed by commit wayland-e20a0f1 before the release
of wayland-1.0. Support was dropped from mesa-9.0.1 by commit
mesa-009d452.
This patch removes a vestigial remnant of Wayland pixmaps: a declaration
in eglplatform.h.
Signed-off-by: Chad Versace
---
include/EGL
rk/Ice Storm for Android.
NOTE: This is a candidate for stable branches.
Cc: Tapani Pälli
Cc: Ian Romanick
Signed-off-by: Kenneth Graunke
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
t_level].width,
- mt->level[depth_irb->mt_level].height);
- return false;
- }
-
uint32_t depth_clear_value;
switch (mt->format) {
case MESA_FORMAT_Z32_FLOAT_X24S8:
Would be worth regression testing on Gen6.
Really glad to see
until it's been regression tested.
This series lives on my "mocs" branch.
Chad Versace (2):
i965/gen7: Add defines for Memory Object Control State
i965/hsw: Set MOCS for surfaces
src/mesa/drivers/dri/i965/brw_context.c | 31 +++
src/mesa/drive
0.2435% +/- 0.821163%, n = 5, 95% confidence
CC: Stéphane Marchesin
CC: Kenneth Graunke
CC: Eric Anholt
CC: Matt Turner
Signed-off-by: Chad Versace
---
src/mesa/drivers/dri/i965/brw_context.c | 31 +++
src/mesa/drivers/dri/i965/brw_context.h | 13 +
CC: Stéphane Marchesin
CC: Kenneth Graunke
CC: Eric Anholt
CC: Matt Turner
Signed-off-by: Chad Versace
---
src/mesa/drivers/dri/i965/brw_defines.h | 20
1 file changed, 20 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_defines.h
b/src/mesa/drivers/dri/i965
On 05/04/2013 03:20 PM, Matt Turner wrote:
On Sat, May 4, 2013 at 12:14 AM, Matt Turner wrote:
On Fri, May 3, 2013 at 10:42 PM, Chad Versace
wrote:
+32% on GLBenchmark 2.5 Egypt Offscreen DXT1. Tested on Harris Beach GT3 with
Android.
Please please please, someone run Piglit on this series
the stable branches.
CC: Tapani Pälli
Signed-off-by: Chad Versace
---
src/egl/drivers/dri2/platform_android.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_android.c
b/src/egl/drivers/dri2/platform_android.c
index cee4035
On 05/07/2013 05:56 AM, Divick Kishore wrote:
Hi,
I have compiled mesa with the following options:
.././configure --prefix=~/lib/mesa/swrast/ --build=x86_64-linux-gnu
--with-gallium-drivers= --with-driver=xlib --enable-egl --enable-gles1
--enable-gles2 --with-egl-platforms="x11" CFLAGS="-Wa
On 05/07/2013 01:19 AM, Chia-I Wu wrote:
On Tue, May 7, 2013 at 3:49 PM, Pohjolainen, Topi
wrote:
On Mon, May 06, 2013 at 02:23:52PM -0700, Chad Versace wrote:
Emit EGL_BAD_CONTEXT if the user passes a context to
eglCreateImageKHR(type=EGL_ANDROID_image_native_buffer).
From the
On 05/06/2013 09:02 PM, Eric Anholt wrote:
The constant packets for gen6 are too small for gen7, and while IVB seems
happy with them HSW blows up. Just restore the HSW path to what it was
before the gen6 change, by making gen7-specific functions to set up these
stages.
---
The alternative here
Haswell has been broken on master for a surprisingly long time, since commit
1dfea559c3 (Thu May 2 11:27:37 2013 -0700). Reverting that commit fixed it
for me.
If it doesn't get properly fixed by the 7th day, I'd like to see the guilty
patch reverted. A full week is too long for a platform under
On 05/07/2013 04:08 PM, Eric Anholt wrote:
Chad Versace writes:
Haswell has been broken on master for a surprisingly long time, since commit
1dfea559c3 (Thu May 2 11:27:37 2013 -0700). Reverting that commit fixed it
for me.
If it doesn't get properly fixed by the 7th day, I'd like
for the stable branches.
---
src/mesa/drivers/dri/i965/gen7_blorp.cpp | 103 ++-
1 file changed, 101 insertions(+), 2 deletions(-)
Tested on Haswell.
Reviewed-and-tested-by: Chad Versace
___
mesa-dev mailing list
mesa-dev
ES 1.1.12 and OpenGL ES 2.0.25.
Signed-off-by: Chad Versace
---
src/mesa/main/extensions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index 8b67fca..8eb45ff 100644
--- a/src/mesa/main/extensions.c
+++ b/src/mesa/main
On 05/08/2013 09:57 AM, Eric Anholt wrote:
Dave Airlie writes:
Haswell has been broken on master for a surprisingly long time, since
commit
1dfea559c3 (Thu May 2 11:27:37 2013 -0700). Reverting that commit fixed
it
for me.
If it doesn't get properly fixed by the 7th day, I'd like to see the
On 05/08/2013 10:05 AM, Kenneth Graunke wrote:
On 05/08/2013 09:48 AM, Chad Versace wrote:
Mesa's extension table incorrectly lists this GL_OES_texture_npot as
ES2-only. It's also an ES1 extension. This patch adds ES1 to the
extensions API mask.
From the GL_OES_texture_npot spec:
Tested-by: Matt Turner
Signed-off-by: Chad Versace
---
src/mesa/drivers/dri/i965/brw_defines.h | 20
1 file changed, 20 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_defines.h
b/src/mesa/drivers/dri/i965/brw_defines.h
index 6517f24..f574cb7 100644
--- a/src
0.2435% +/- 0.821163%, n = 5, 95% confidence
Tested-by: Matt Turner
Signed-off-by: Chad Versace
---
This branch lives on my 'mocs' branch.
src/mesa/drivers/dri/i965/brw_context.c | 31 +++
src/mesa/drivers/dri/i965/brw_context.h | 13
On 05/07/2013 10:55 PM, Kenneth Graunke wrote:
On 04/17/2013 05:30 PM, Kenneth Graunke wrote:
We can't include shaderobj.h from the standalone utilities, so we
unfortunately have to copy this function.
Signed-off-by: Kenneth Graunke
---
src/glsl/standalone_scaffolding.h | 17
On 05/10/2013 10:16 AM, Eric Anholt wrote:
Chad Versace writes:
The drivers was setting MOCS (Memory Object Control State) to 0 for all
objects. This patch sets it as following:
renderbuffer, depthbuffer => LLC uncacheable, L3 cacheable
texture, stencil, hiz => LLC cacheab
tests to skip.
Enables 76 GLES tests on my system.
CC: Eric Anholt
Signed-off-by: Chad Versace
---
tests/util/piglit-framework-gl/piglit_fbo_framework.c| 2 +-
tests/util/piglit-framework-gl/piglit_wfl_framework.c| 10 +-
tests/util/piglit-framework-gl/piglit_wfl_framework.h
This was intended for the Piglit list.
Please ignore, (or better yet, go review it on the proper list).
On 05/15/2013 01:27 PM, Chad Versace wrote:
Change default waffle platform from GLX to XEGL for GLES tests.
The default platform was GLX for all GL tests (GL and GLES). But not all
GLX
On 05/02/2013 12:08 AM, Topi Pohjolainen wrote:
No functional change in preparation for supporting multiple planes
per image each having its own region.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/intel/intel_fbo.c | 6 +--
src/mesa/drivers/dri/intel/intel_regions.h |
On 05/23/2013 09:33 AM, Paul Berry wrote:
On 22 May 2013 12:18, Ian Romanick wrote:
On 05/21/2013 04:52 PM, Paul Berry wrote:
This patch ifdefs out intel_mipmap_tree::mcs_mt when building the i915
(pre-Gen4) driver (MCS buffers aren't supported until Gen7, so there
is no need for this field
When touching the src/egl/drivers/dri2 directory, use a commit subject
that looks like "egl/dri2: STUFF", not "egl: dri2: STUFF".
On 05/02/2013 12:08 AM, Topi Pohjolainen wrote:
v2:
- upon success close the given file descriptors
v3:
- use specific entry for dma buffers instead of the b
On 05/02/2013 12:08 AM, Topi Pohjolainen wrote:
As specified in:
http://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_image_dma_buf_import.txt
Checking for the valid fourcc values is left for drivers avoiding
dependency to drm header files here.
v2:
- enforce EGL_NO_CONTEXT
v3:
On 05/02/2013 12:08 AM, Topi Pohjolainen wrote:
v2 (as advised by Eric):
- use ARRAY_SIZE
- re-use 'image_destroy' for cleaning up after failure
- check directly the region pointer instead of the buffer object
when determining if a region exists
Signed-off-by: Topi Pohjolainen
On 05/21/2013 11:17 PM, Pohjolainen, Topi wrote:
On Tue, May 21, 2013 at 10:11:17PM -0700, Chad Versace wrote:
On 05/02/2013 12:08 AM, Topi Pohjolainen wrote:
No functional change in preparation for supporting multiple planes
per image each having its own region.
Signed-off-by: Topi
On 05/23/2013 10:15 PM, Pohjolainen, Topi wrote:
On Thu, May 23, 2013 at 09:39:30PM -0700, Chad Versace wrote:
When touching the src/egl/drivers/dri2 directory, use a commit subject
that looks like "egl/dri2: STUFF", not "egl: dri2: STUFF".
[snip]
+/**
+ * The sp
(v1)
Reviewed-by: Kenneth Graunke (v1)
---
This patch is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 05/24/2013 01:56 PM, Eric Anholt wrote:
If the hw is pre-gen5 and can't blit depth, it'll cleanly error out.
Did you mean pre-gen6? If I read the code correctly, it is this snippet in
intelEmitCopyBlit
that is responsible for cleanly erroring out.
if (dst_tiling != I915_TILING_NONE) {
On 05/24/2013 01:56 PM, Eric Anholt wrote:
I had previously asserted that it was hard to write a useful, simpler
blit function, but I think this might be it.
This has the side effect of extending the 32k pitch check to a few more
places that were missing it.
---
src/mesa/drivers/dri/intel/inte
On 05/28/2013 01:54 PM, Eric Anholt wrote:
Marek Olšák writes:
CopyTexSubImage can be called on a multisample renderbuffer if the
renderbuffer is part of the window-system framebuffer (i.e. comes from
the visual).
IIRC, the game Cogs uses it if both MSAA and Post Filters are enabled.
Good t
For patches 1 2 3 5 6: Reviewed-by.
For patches 4 and 7, with the comments fixed: Reviewed-by.
Patch 8, I don't agree with it.
Patch 9, I gave an r-b for v2.
Patch 10-17: I have to walk away now. I plan to finish review this evening.
On 05/24/2013 01:56 PM, Eric Anholt wrote:
For a blit-uploade
| 2 +-
src/mesa/drivers/dri/intel/intel_tex_subimage.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 05/30/2013 12:16 PM, Eric Anholt wrote:
Fixes assertion failure in piglit copyteximage.
---
src/mesa/drivers/common/meta.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
Reviewed-by: Chad Versace
___
mesa-dev
L ES".
Fixes assertion failure in mesa-demos/src/egl/opengles1/tri_x11 on Haswell
and Ivybridge:
brw_draw_upload.c:287: get_surface_type: Assertion `0' failed.
No Piglit regressions on Haswell.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42182
Issue: AXIA-2954
Signed-of
On 05/30/2013 01:20 AM, Daniel Vetter wrote:
On Thu, May 30, 2013 at 9:49 AM, Pohjolainen, Topi
wrote:
On Tue, May 28, 2013 at 01:33:18PM -0700, Eric Anholt wrote:
Topi Pohjolainen writes:
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/intel/intel_fbo.c | 4
1 file change
On 05/31/2013 03:01 PM, Paul Berry wrote:
The EGL 1.4 spec
leaves some wiggle room about whether front buffer rendering is allowed, to
accommodate window systems that don't permit front buffer rendering.
However, since X11 supports front buffer rendering, it seems to me that
Mesa-EGL-X11 ought t
On 06/03/2013 01:02 PM, Eric Anholt wrote:
Chad Versace writes:
When a gl_client_array is created with glColorPointer,
gl_client_array::Normalized is true. This caused the translation from the
gl_client_array's type to a BRW_SURFACEFORMAT to assertion fail.
Fixes the spinning cube'
On 06/02/2013 11:21 PM, Chad Versace wrote:
On 05/30/2013 01:20 AM, Daniel Vetter wrote:
On Thu, May 30, 2013 at 9:49 AM, Pohjolainen, Topi
wrote:
On Tue, May 28, 2013 at 01:33:18PM -0700, Eric Anholt wrote:
Topi Pohjolainen writes:
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers
Patches 7-9 need to be reworked a little bit.
First, the "dri" and "egl/dri2" commit have intermingled changes to the
intel driver. The changes to the intel driver should be pulled out into a
separate final commit.
Second, the commit subjects are imprecise and difficult to understand. If I
were
On 05/28/2013 02:17 AM, Topi Pohjolainen wrote:
v2:
- upon success close the given file descriptors
v3:
- use specific entry for dma buffers instead of the basic for
primes, and enable the extension based on the availability
of the hook
v4 (Chad):
- use ARRAY_SIZE
-
Patches 1-5 are
Reviewed-by: Chad Versace
I'm still looking at the other ones.
On 05/28/2013 02:17 AM, Topi Pohjolainen wrote:
Otherwise 'intel_set_texture_image_region()' won't have enough
details to work with.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/
On 05/28/2013 02:17 AM, Topi Pohjolainen wrote:
No functional change in preparation for supporting multiple planes
per image each having its own region.
v2 (Chad): Clarify how valid regions are detected. Originally I
thought one could also support cases where one region
i
On 05/29/2013 07:17 AM, Brian Paul wrote:
On 05/29/2013 12:56 AM, Divick Kishore wrote:
Hi Brian,
thanks for your reply.
On Tue, May 28, 2013 at 9:33 PM, Brian Paul wrote:
I took at look at eglCreateContext(). It's basically:
EGLContext
eglCreateContext(EGLDisplay dpy, EGLConfi
doing so" seems incomplete and I don't
understand its intent.
Other than that, these two patches are
Reviewed-by: Chad Versace
---
src/mesa/drivers/dri/intel/intel_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/intel/intel_con
On 06/05/2013 10:40 AM, Paul Berry wrote:
On 5 June 2013 10:37, Chad Versace wrote:
On 05/30/2013 07:44 AM, Paul Berry wrote:
The sentence that begins with "In doing so" seems incomplete and I don't
understand its intent.
Sorry about that. I appear to have experienced s
getTexture2DOES. Otherwise, GL_INVALID_ENUM
does not get emitted on non-GLES contexts.
With that change, this is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
order. Many (arguably buggy) applications
depend on this behavior, and it matches what nearly all other drivers
do.
Fixes the (new) piglit test attrib-assignments.
NOTE: This is a candidate for stable release branches.
Signed-off-by: Ian Romanick
Cc: Chad Versace
---
src/glsl/ast_to_hir.cpp
On 06/11/2013 01:39 PM, Ian Romanick wrote:
On 06/11/2013 01:27 PM, Chad Versace wrote:
On 06/08/2013 01:05 PM, Ian Romanick wrote:
From: Ian Romanick
This has the (intended!) side effect that vertex shader inputs and
fragment shader outputs will appear in the IR in the same order that
they
gles2conform at 64x64 and fixes 3D Bowling.
Reviewed-and-tested-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 06/11/2013 01:57 PM, Chad Versace wrote:
On 06/11/2013 01:39 PM, Ian Romanick wrote:
On 06/11/2013 01:27 PM, Chad Versace wrote:
On 06/08/2013 01:05 PM, Ian Romanick wrote:
From: Ian Romanick
This has the (intended!) side effect that vertex shader inputs and
fragment shader outputs will
On 06/21/2013 10:09 PM, Kenneth Graunke wrote:
On 06/21/2013 11:29 AM, Eric Anholt wrote:
Long ago, when porting FBO and memory management support to i965, I
merged a bunch of code between the i915 and i965 drivers and put it in
the intel directory. I think it served us well for a long time, as
If allocation fails in intel_miptree_create_layout(), don't proceed to
dereference the miptree. Return an early NULL.
Fixes static analysis error reported by Klocwork.
Note: This is a candidate for the 9.1 branch.
Signed-off-by: Chad Versace
---
src/mesa/drivers/dri/i915/intel_mipmap_t
On 06/26/2013 02:57 PM, Ian Romanick wrote:
On 06/26/2013 02:42 PM, Chad Versace wrote:
If allocation fails in intel_miptree_create_layout(), don't proceed to
dereference the miptree. Return an early NULL.
Fixes static analysis error reported by Klocwork.
Note: This is a candidate for th
appy and adds only epsilon additional
cycles.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 06/27/2013 10:40 PM, Vinson Lee wrote:
Fixes "Uninitialized scalar field" defect reported by Coverity.
Signed-off-by: Vinson Lee
---
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
Thanks, committed to master.
___
On 06/27/2013 07:04 AM, Brian Paul wrote:
On 06/27/2013 05:35 AM, Ross Burton wrote:
In the generic Unix case use the "unsigned long" type instead of 32-bit
integers so that the type sizes are consistant on 64-bit machines between X11
and not-X11.
Signed-off-by: Ross Burton
---
include/EGL/e
On 07/01/2013 07:58 AM, Brian Paul wrote:
No need to test array->Enabled != 0 since the Enabled field can
only be 0 or 1.
---
src/mesa/main/enable.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
Reviewed-by: Chad Vers
Patches 1-3 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
and star2,
like /* List of 'ast_declaration*' */
With such a clarification,
Reviewed-by: Chad Versace
exec_list declarations;
/**
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/lis
On 06/29/2013 07:43 PM, Matt Turner wrote:
---
src/glsl/ast.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index 13c5e6b..0b70bb7 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -453,6 +453,13 @@ class ast_declarator_list;
class ast_struct_s
I second Marek's concern. Having intel_context defined differently
in two locations will cause nightmares in editors. It's possible,
but with much pain, to workaround that nightmare in Eclipse, but I'd
rather avoid it.
I dislike brw_context, because it doesn't match all the other naming
conventi
For the series,
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
701 - 800 of 2787 matches
Mail list logo
