On Tue, Apr 29, 2014 at 04:34:37PM -0700, Eric Anholt wrote: > Note: region->width used to reflect the total_width/height padding of > separate stencil, and mt->total_width doesn't.
The note scares me. It tells me the patch has a known, potential bug regarding stencil buffers... but after some digging I convinced myself that there's no stencil bug. Please provide some assurance in the commit message that there is no bug. I think it's sufficient to explain that, in the patch, each substitution of region->width with rb->Width is safe because the renderbuffer is never a stencil buffer nor multisampled in those functions. Add some assurance to the commit message and this patch is Reviewed-by: Chad Versace <chad.vers...@linux.intel.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
