We need vulkan and gl to produce the same UUIDs. Therefore we should
keep the mechanism to compute these in a common location to guarantee
they are updated in lockstep.
Signed-off-by: Andres Rodriguez
---
src/amd/common/ac_gpu_info.c | 27 +++
src/amd/common
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeon/r600_pipe_common.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c
b/src/gallium/drivers/radeon/r600_pipe_common.c
index fd67d9a..c14d4eb 100644
--- a/src/gallium
These are just basic implementations.
Signed-off-by: Andres Rodriguez
---
src/mesa/main/formatquery.c | 17 +
src/mesa/main/mtypes.h | 3 +++
src/mesa/main/texparam.c| 27 +++
3 files changed, 47 insertions(+)
diff --git a/src/mesa/main
We have a few UUIDs, so lets be more specific.
Signed-off-by: Andres Rodriguez
---
src/amd/vulkan/radv_device.c | 4 ++--
src/amd/vulkan/radv_pipeline_cache.c | 4 ++--
src/amd/vulkan/radv_private.h| 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/amd
This is required for interop use cases. The same device must report
identical UUIDs through the GL and Vulkan APIs so that users can
identify when it is safe to perform a memory object import.
v2: use ac helpers to calculate the uuid
Signed-off-by: Andres Rodriguez
---
src/amd/vulkan
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/ddebug/dd_screen.c | 17 +
src/gallium/include/pipe/p_defines.h | 1 +
src/gallium/include/pipe/p_screen.h| 13 +
3 files changed, 31 insertions(+)
diff --git a/src/gallium/drivers/ddebug/dd_screen.c
b
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/r600/r600_pipe.c | 2 +-
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_pipe.c
b/src/gallium/drivers/r600/r600_pipe.c
index e3abc10..078f12b
These need to match for interop compatibility queries.
Signed-off-by: Andres Rodriguez
---
src/amd/vulkan/radv_device.c | 9 -
src/amd/vulkan/radv_private.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
v2: fix an indentation error
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/r600/r600_pipe.c | 2 +-
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_pipe.c
b/src/gallium/drivers/r600
Thanks Ilia, I'll get that fixed up.
Regards,
Andres
On 2017-07-07 09:53 AM, Ilia Mirkin wrote:
This is missing the docs addition for what this cap does
(gallium/docs/source/screen.rst).
On Fri, Jul 7, 2017 at 12:24 AM, Andres Rodriguez wrote:
This can be used to guard suppor
This can be used to guard support for EXT_memory_object and related
extensions.
v2: update gallium docs
Signed-off-by: Andres Rodriguez
---
src/gallium/docs/source/screen.rst | 1 +
src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 +
src/gallium/drivers/freedreno
On 2017-07-11 02:31 PM, Marek Olšák wrote:
On Sat, Jul 1, 2017 at 1:03 AM, Andres Rodriguez wrote:
From: Dave Airlie
Instead of allocating memory to back a texture, use the provided memory
object.
Signed-off-by: Andres Rodriguez
---
src/mesa/main/mtypes.h | 2 +
src
revision:
mesa/st: factor out st_AllocTextureStorage into a helper
radeonsi: factor out metadata import
Series available at:
https://github.com/lostgoat/mesa.git (wip-mem-obj-v3)
Andres Rodriguez (23):
mapi: add EXT_external_objects and EXT_external_objects_fd
mesa: add support for
Used by EXT_external_objects and EXT_external_objects_fd
Signed-off-by: Andres Rodriguez
---
src/mesa/drivers/common/driverfuncs.c | 4 +
src/mesa/main/dd.h| 36 +
src/mesa/main/externalobjects.c | 145 +-
src/mesa/main
From: Dave Airlie
v2: fix comment regarding fd ownership, define pipe_memory_object
---
src/gallium/drivers/ddebug/dd_screen.c | 40 ++
src/gallium/include/pipe/p_screen.h| 36 ++
src/gallium/include/pipe/p_state.h | 8 +++
Includes implementation stubs.
Signed-off-by: Andres Rodriguez
---
src/mapi/glapi/gen/EXT_external_objects.xml| 234 +
src/mapi/glapi/gen/EXT_external_objects_fd.xml | 28 +++
src/mapi/glapi/gen/Makefile.am | 2 +
src/mapi/glapi/gen/gl_API.xml
Signed-off-by: Andres Rodriguez
---
src/mesa/main/externalobjects.c | 54 -
src/mesa/main/mtypes.h | 5 +++-
2 files changed, 57 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/externalobjects.c b/src/mesa/main/externalobjects.c
index
Signed-off-by: Andres Rodriguez
---
src/mesa/main/dd.h | 9
src/mesa/main/externalobjects.c | 93 -
src/mesa/main/texstorage.c | 76 -
src/mesa/main/texstorage.h | 13 +-
4 files changed, 160
From: Dave Airlie
v2: pass dedicated flag
Signed-off-by: Andres Rodriguez
---
src/mesa/Makefile.sources| 2 +
src/mesa/state_tracker/st_cb_memoryobjects.c | 66
src/mesa/state_tracker/st_cb_memoryobjects.h | 25 +++
src/mesa
Plumbing for importing memobj backed textures.
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeon/r600_texture.c | 63 ++-
1 file changed, 36 insertions(+), 27 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_texture.c
b/src/gallium/drivers
From: Dave Airlie
Instead of allocating memory to back a texture, use the provided memory
object.
v2: split off extension exposure logic
v3: de-duplicate code with st_AllocTextureStorage
Signed-off-by: Andres Rodriguez
---
src/mesa/state_tracker/st_cb_texture.c | 116
From: Dave Airlie
v2: also consider gfx9 metadata
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeon/r600_pipe_common.h | 7 ++
src/gallium/drivers/radeon/r600_texture.c | 102 ++
2 files changed, 109 insertions(+)
diff --git a/src/gallium/drivers
No changes, just re-indent.
Signed-off-by: Andres Rodriguez
---
src/mesa/state_tracker/st_cb_bufferobjects.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c
b/src/mesa/state_tracker
Signed-off-by: Andres Rodriguez
---
src/mesa/main/externalobjects.c | 53
src/mesa/main/teximage.c| 76 +
src/mesa/main/teximage.h| 10 ++
3 files changed, 110 insertions(+), 29 deletions(-)
diff --git a
Use a memory object instead of user memory.
Signed-off-by: Andres Rodriguez
---
src/mesa/main/dd.h | 12 +
src/mesa/state_tracker/st_cb_bufferobjects.c | 66 +---
2 files changed, 61 insertions(+), 17 deletions(-)
diff --git a/src/mesa/main
This can be used to guard support for EXT_memory_object and related
extensions.
v2: update gallium docs
Signed-off-by: Andres Rodriguez
---
src/gallium/docs/source/screen.rst | 1 +
src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 +
src/gallium/drivers/freedreno
Plumbing for using memory objects as texture storage.
Signed-off-by: Andres Rodriguez
---
src/mesa/state_tracker/st_cb_texture.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_texture.c
b/src/mesa/state_tracker
Include no_error variants as well.
Signed-off-by: Andres Rodriguez
---
src/mapi/glapi/gen/EXT_external_objects.xml | 4 +-
src/mesa/main/bufferobj.c | 80 +++--
src/mesa/main/bufferobj.h | 16 +-
src/mesa/main/externalobjects.c
v2: respective changes for new gallium interface
v3: fix UUID size asserts
Signed-off-by: Andres Rodriguez
---
src/mesa/main/dd.h | 15 +++
src/mesa/main/get.c | 17 +
src/mesa/main/version.c | 13 +
src/mesa
We need vulkan and gl to produce the same UUIDs. Therefore we should
keep the mechanism to compute these in a common location to guarantee
they are updated in lockstep.
Signed-off-by: Andres Rodriguez
---
src/amd/common/ac_gpu_info.c | 27 +++
src/amd/common
v2: use PIPE_CAP_MEMOBJ to guard the extension
Signed-off-by: Andres Rodriguez
---
src/mesa/main/extensions_table.h | 2 ++
src/mesa/main/mtypes.h | 2 ++
src/mesa/state_tracker/st_extensions.c | 5 +
3 files changed, 9 insertions(+)
diff --git a/src/mesa/main
v2: remove unnecessary returns
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/ddebug/dd_screen.c | 17 +
src/gallium/include/pipe/p_defines.h | 1 +
src/gallium/include/pipe/p_screen.h| 13 +
3 files changed, 31 insertions(+)
diff --git a/src/gallium
These are used by EXT_external_objects to present UUIDs for the device
and the driver.
Signed-off-by: Andres Rodriguez
---
src/mesa/main/get.c | 177
1 file changed, 177 insertions(+)
diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
Signed-off-by: Andres Rodriguez
---
src/mesa/main/externalobjects.c | 63 +
1 file changed, 51 insertions(+), 12 deletions(-)
diff --git a/src/mesa/main/externalobjects.c b/src/mesa/main/externalobjects.c
index 919a81c..73c9d4b 100644
--- a/src/mesa/main
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeon/r600_pipe_common.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c
b/src/gallium/drivers/radeon/r600_pipe_common.c
index fd67d9a..c14d4eb 100644
--- a/src/gallium
We have a few UUIDs, so lets be more specific.
Signed-off-by: Andres Rodriguez
---
src/amd/vulkan/radv_device.c | 4 ++--
src/amd/vulkan/radv_pipeline_cache.c | 4 ++--
src/amd/vulkan/radv_private.h| 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/amd
These are just basic implementations.
Signed-off-by: Andres Rodriguez
---
src/mesa/main/formatquery.c | 17 +
src/mesa/main/mtypes.h | 3 +++
src/mesa/main/texparam.c| 27 +++
3 files changed, 47 insertions(+)
diff --git a/src/mesa/main
This is required for interop use cases. The same device must report
identical UUIDs through the GL and Vulkan APIs so that users can
identify when it is safe to perform a memory object import.
v2: use ac helpers to calculate the uuid
Signed-off-by: Andres Rodriguez
---
src/amd/vulkan
These need to match for interop compatibility queries.
Signed-off-by: Andres Rodriguez
---
src/amd/vulkan/radv_device.c | 9 -
src/amd/vulkan/radv_private.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
v2: fix an indentation error
v3: don't enable for r600
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/radeonsi/si_pipe.c
index bc
v2: move from r600_common to radeonsi
Signed-off-by: Andres Rodriguez
---
This fixes a build error reported by haagch on #radeon.
I've updated the series on my repo to wip-mem-obj-v4
src/gallium/drivers/radeonsi/si_pipe.c | 14 ++
1 file changed, 14 insertions(+)
diff --
- Moved the flush from gallium into the radeonsi pipe
- Added tests (on piglit mailing list)
- Some fixups for bugs found with the tests are at the end of the series
Thanks for taking the time to review.
Kind Regards,
Andres
Andres Rodriguez (22):
gallium: add type parameter to
Kept separate from the symbol renames for review purposes.
Signed-off-by: Andres Rodriguez
---
src/gallium/docs/source/context.rst| 34 +++---
src/gallium/include/pipe/p_context.h | 33 +++--
src/gallium/include/pipe/p_screen.h
Protects semaphore signaling functionality required by GL_EXT_semaphore.
Signed-off-by: Andres Rodriguez
---
src/gallium/docs/source/screen.rst | 2 ++
src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 +
src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
src/gallium
Signed-off-by: Andres Rodriguez
---
src/gallium/auxiliary/util/u_threaded_context.c | 20
.../auxiliary/util/u_threaded_context_calls.h| 1 +
2 files changed, 21 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_threaded_context.c
b/src/gallium
Used by EXT_semmaphore and EXT_semaphore_fd
v2: Removed unnecessary dummy callback initialization
Signed-off-by: Andres Rodriguez
---
src/mesa/main/dd.h | 34 ++
src/mesa/main/externalobjects.c | 133 +++-
src/mesa/main
Add basic semaphore object operations.
Signed-off-by: Andres Rodriguez
---
src/mesa/Makefile.sources | 2 +
src/mesa/meson.build| 2 +
src/mesa/state_tracker/st_cb_semaphoreobjects.c | 55 +
src/mesa/state_tracker
Calling this function will emit a semaphore signal operation into the
GPU's command stream.
Signed-off-by: Andres Rodriguez
---
src/gallium/docs/source/context.rst | 31 +++
src/gallium/include/pipe/p_context.h | 6 ++
2 files changed, 37 insertions(+)
An fd can potentially have different types of objects backing it.
Specifying the type helps us make sure we treat the FD correctly.
This is in preparation to allow importing syncobj fence FDs in addition
to native sync FDs.
Signed-off-by: Andres Rodriguez
---
src/gallium/auxiliary/util
EXT_semaphore and EXT_semaphore_fd define no pnames. Therefore there
isn't much to do besides determining the correct error code.
v2: removed useless return
Signed-off-by: Andres Rodriguez
---
src/mesa/main/externalobjects.c | 22 ++
1 file changed, 22 insertions(+)
the fence dependency.
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeonsi/si_fence.c | 49 +
1 file changed, 25 insertions(+), 24 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_fence.c
b/src/gallium/drivers/radeonsi/si_fence.c
index
Syncobj based waits or signals only happen at submission boundaries. In
order to guarantee that the requested signal event will occur when the
state tracker requested it, we must issue a flush.
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeonsi/si_fence.c | 37
Add the ability to signal a syncobj when a cs completes execution.
v2: corresponding changes for gallium fence->semaphore rename
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeon/radeon_winsys.h | 12 +
src/gallium/winsys/amdgpu/drm/amdgpu_cs.c |
Memory synchronization is left for a future patch.
v2: flush vertices/bitmaps moved to mesa/main
Signed-off-by: Andres Rodriguez
---
src/mesa/main/dd.h | 14 ++
src/mesa/main/externalobjects.c | 38 ++
2 files changed, 52 insertions
This allows the client to actually query the enums specified in the
ext_external_objects spec.
Signed-off-by: Andres Rodriguez
---
src/mesa/main/get.c | 3 +++
src/mesa/main/get_hash_params.py | 5 +
2 files changed, 8 insertions(+)
diff --git a/src/mesa/main/get.c b/src/mesa
This fixes the following piglit tests:
spec/ext_semaphore_fd/api-errors/import-semaphore-fd-bad-enum
spec/ext_memory_object_fd/api-errors/import-memory-fd-bad-enum
Signed-off-by: Andres Rodriguez
---
src/mesa/main/externalobjects.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Denotes that a fd is backed by a synobj. For example, radv shared
semaphores.
Signed-off-by: Andres Rodriguez
---
src/gallium/include/pipe/p_defines.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/include/pipe/p_defines.h
b/src/gallium/include/pipe/p_defines.h
index e2e07ac
Expose the feature only when we have syncobj support available
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeonsi/si_get.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_get.c
b/src/gallium/drivers/radeonsi/si_get.c
index
Make sure memory is accessible to the external client, for the specified
memory object, before the signal/after the wait.
v2: fixed flush order with respect to wait/signal emission
Signed-off-by: Andres Rodriguez
---
src/mesa/main/dd.h | 14 ++-
src/mesa/main
Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject
v2:
- corresponding changes for gallium fence->semaphore rename
- flushing moved to mesa/main
Signed-off-by: Andres Rodriguez
---
src/mesa/state_tracker/st_cb_semaphoreobjects.c | 27 +
1 f
Guarded by PIPE_CAP_SEMAPHORE_SIGNAL
v2: corresponding changes for PIPE_CAP_SEMAPHORE_SIGNAL rename
Signed-off-by: Andres Rodriguez
---
src/mesa/main/extensions_table.h | 2 ++
src/mesa/main/mtypes.h | 2 ++
src/mesa/state_tracker/st_extensions.c | 2 ++
3 files changed
This fixes the piglit test:
spec/ext_semaphore/api-errors/usigned-byte-i-v-bad-value
Signed-off-by: Andres Rodriguez
---
src/mesa/main/get.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
index 34970b8..302cece 100644
--- a/src/mesa/main/get.c
Hook up importing semaphores of type PIPE_FD_TYPE_SYNCOBJ
Signed-off-by: Andres Rodriguez
---
src/gallium/drivers/radeonsi/si_fence.c | 26 --
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_fence.c
b/src/gallium/drivers
roval.
The reason it is being held:
Message body is too big: 271096 bytes with a limit of 128 KB
[snip]
On 2017-12-21 07:41 PM, Andres Rodriguez wrote:
Sorry for the long time to get this v2 out, past month has been
a bit hectic.
This incorporates the feedback I received from mareko and nha o
On 2017-12-22 10:56 AM, Roland Scheidegger wrote:
Am 22.12.2017 um 01:41 schrieb Andres Rodriguez:
Calling this function will emit a semaphore signal operation into the
GPU's command stream.
Signed-off-by: Andres Rodriguez
---
src/gallium/docs/source/context.rst
x27;m fine with either
approach.
Marek
On Fri, Dec 22, 2017 at 1:41 AM, Andres Rodriguez wrote:
Rename fences -> semaphores in preparation for upgrading fence
functionality.
This series renames the following symbols:
- pipe_fence_handle -> pipe_semaphore_handle
On 2018-01-17 08:01 AM, Nicolai Hähnle wrote:
On 04.01.2018 18:37, Andres Rodriguez wrote:
On 2018-01-04 12:33 PM, Marek Olšák wrote:
Is the renaming necessary? It looks like everything would be fine if
we used the "fence" name for semaphores.
The rename was requested by nha
On 2018-01-17 06:35 PM, Marek Olšák wrote:
On Wed, Jan 17, 2018 at 8:22 PM, Andres Rodriguez wrote:
On 2018-01-17 08:01 AM, Nicolai Hähnle wrote:
On 04.01.2018 18:37, Andres Rodriguez wrote:
On 2018-01-04 12:33 PM, Marek Olšák wrote:
Is the renaming necessary? It looks like
Hi,
A small piece of feedback from those of us watching remotely. It would
be nice to have a simple to access index for the long livestream videos.
I think the XDC 2017 wiki page would be a good place for this
information. A brief example:
Presentation Title | Presenter Name | Link with tim
This should be good for radeonsi to implement the feature as well.
FWIW:
Reviewed-by: Andres Rodriguez
Little bikeshed comment.
I'm a little iffy about using a mask instead of an enum for priority
values. It limits the flexibility on the number of levels drastically.
Since you can
On 2017-10-05 11:29 AM, Nicolai Hähnle wrote:
On 04.10.2017 23:02, Rob Clark wrote:
On Wed, Oct 4, 2017 at 3:33 PM, Roland Scheidegger
wrote:
Am 04.10.2017 um 17:44 schrieb Rob Clark:
Signed-off-by: Rob Clark
---
src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 +
src/gallium/dr
Queues are independent execution streams. The vulkan spec provides no
ordering guarantees for different queues.
By using a single context for all queues, we are forcing all commands
into an unecessary FIFO ordering.
This change is a preparation step to allow our-of-ordering scheduling of
certain
This patch series implements VK_EXT_queue_global_priority, a vulkan extension
that focuses on providing scheduling guarantees.
For further information on the use case refer to:
https://lists.freedesktop.org/archives/amd-gfx/2016-December/004068.html
For some perf data on this initial implementati
on [1].
+
+Contributors
+
+Andres Rodriguez, Valve Software
+Pierre-Loup Griffais, Valve Software
+
+Contact
+
+Andres Rodriguez, Valve Software
+
+Overview
+
+In Vulkan 1.0.32 users can specify device-scope queue priorities. In
+ some cases it may be useful to extend this concept to a s
mesa3d.org/devinfo.html
Although some of them seen to not apply anymore (radv code was tabs instead of
3 spaces).
Thanks for taking the time to review :)
Regards,
Andres
From: mesa-dev [mesa-dev-boun...@lists.freedesktop.org] on behalf of Andres
Rodrig
r thing is that you'll need to increase the amdgpu driver DRM
version in the kernel, and then check against it in radv, to see if we
can support the feature.
On Wed, Jan 4, 2017 at 3:27 AM, Andres Rodriguez wrote:
Add a new extension VK_EXT_queue_global_priority, which allows the
caller
Hey Everyone,
I started a small project called gputool to help me debug issues on AMD
platforms. I think it may be useful to other driver devs, so I've made
it available on github:
https://github.com/lostgoat/gputool
Mainly I wanted something that could read and decode registers, so that
is
All extension arrays are global, but only one of them refers to instance
extensions.
The device extension array refers to extensions that are common across
all physical devices. This disctinction will be more imporant once we
have dynamic extension support for devices.
Signed-off-by: Andres
work tasks.
As a side effect, vkQueueWaitIdle will be marginally faster. Previously
due to the shared context, vkQueueWaitIdle was equivalent to
vkDeviceWaitIdle.
Signed-off-by: Andres Rodriguez
---
src/amd/vulkan/radv_device.c | 34 --
src/amd/vulkan
Each physical may have different extensions than one another.
Furthermore, depending on the software stack, some extensions may not be
accessible.
If an extension is conditional, it can be registered only when
necessary.
Signed-off-by: Andres Rodriguez
---
src/amd/vulkan/radv_device.c | 196
Following are a subset of patches from my wip-high-priority branch that
may be useful outside that context.
The HW priority debugging may take a little while, so I wanted to make some
of the more generic bits to be available on master as other work could benefit
from it.
_
On 2017-01-13 06:04 PM, Bas Nieuwenhuizen wrote:
On Fri, Jan 13, 2017 at 11:06 PM, Andres Rodriguez wrote:
Each physical may have different extensions than one another.
Furthermore, depending on the software stack, some extensions may not be
accessible.
If an extension is conditional, it
On 2017-01-13 06:30 PM, Bas Nieuwenhuizen wrote:
On Sat, Jan 14, 2017 at 12:20 AM, Andres Rodriguez wrote:
On 2017-01-13 06:04 PM, Bas Nieuwenhuizen wrote:
On Fri, Jan 13, 2017 at 11:06 PM, Andres Rodriguez
wrote:
Each physical may have different extensions than one another.
Furthermore
work tasks.
v2: Fix a rebase error with radv_QueueSubmit() and trace_bo
Signed-off-by: Andres Rodriguez
---
src/amd/vulkan/radv_device.c | 39 ---
src/amd/vulkan/radv_private.h | 2 +-
src/amd/vulkan/radv_wsi.c | 2 +-
3 files changed, 22 insertions
All extension arrays are global, but only one of them refers to instance
extensions.
The device extension array refers to extensions that are common across
all physical devices. This disctinction will be more imporant once we
have dynamic extension support for devices.
Signed-off-by: Andres
Following are a subset of patches from my wip-high-priority branch that
may be useful outside that context.
The HW priority debugging may take a little while, so I wanted to make some
of the more generic bits to be available on master as other work could benefit
from it.
v2: Fixed a rebasing mist
: Andres Rodriguez
---
src/amd/vulkan/radv_device.c | 189 +++---
src/amd/vulkan/radv_private.h | 6 ++
2 files changed, 130 insertions(+), 65 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index e0991d4..08a1bf3 100644
On Fri, Jan 13, 2017 at 8:13 PM, Emil Velikov
wrote:
> On 13 January 2017 at 23:44, Andres Rodriguez wrote:
> > All extension arrays are global, but only one of them refers to instance
> > extensions.
> >
> > The device extension array refers to extensions tha
Small comments inline for a bit of extra error handling. Still digesting
radv and vulkan, so the feedback might be a bit incorrect.
On 2017-01-16 02:59 PM, Bas Nieuwenhuizen wrote:
Pretty straightforward. Also deleted the big comment block as it
is a pretty standard pattern for filling in arra
On 2017-01-16 03:34 PM, Bas Nieuwenhuizen wrote:
On Mon, Jan 16, 2017 at 9:30 PM, Andres Rodriguez wrote:
Small comments inline for a bit of extra error handling. Still digesting
radv and vulkan, so the feedback might be a bit incorrect.
On 2017-01-16 02:59 PM, Bas Nieuwenhuizen wrote
In situations where libdrm_amdgpu and mesa are installed to the same
location, the mesa installed headers will take precedence over the git
source headers.
This is due to the AMDGPU_CFLAGS containing the install directory.
This situation can cause build errors if the git version of a header is
ne
-by: Andres Rodriguez
---
src/amd/vulkan/Makefile.am | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am
index 4414881..b47109b 100644
--- a/src/amd/vulkan/Makefile.am
+++ b/src/amd/vulkan/Makefile.am
@@ -32,9 +32,6
The current message sounds like a small warning, clarify that it can
result in lack of presentation support and application crashes.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98263
Signed-off-by: Andres Rodriguez
---
src/vulkan/wsi/wsi_common_x11.c | 6 --
1 file changed, 4
The current message sounds like a small warning, clarify that it can
result in lack of presentation support and application crashes.
v2: add "if they do" (Bas)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98263
Signed-off-by: Andres Rodriguez
---
src/vulkan/wsi/wsi_common
On 1/19/2017 10:47 AM, Emil Velikov wrote:
On 18 January 2017 at 23:07, Andres Rodriguez wrote:
The current message sounds like a small warning, clarify that it can
result in lack of presentation support and application crashes.
v2: add "if they do" (Bas)
Bugzi
This is part of the spec and fixes CTS tests:
dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_*
---
src/amd/vulkan/radv_cmd_buffer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 0b090b7..a
This series implements the VK_KHR_maintenance1 extension. It is loosely
based on jekstrand's series for anv.
This series soft depends on one of Bas's patches that are not yet in master.
I'm not certain of protocol for this kind of situation. I've left them included
in this series, but if I should
Previously the z offset of the destination image was being ignored. It
should be taken into account when copying into a 3d target.
Also, img_extent_el.depth was being incorrectly clamped to 1 due to the
source image being VK_IMAGE_TYPE_2D. This would result in the blit
failing to iterate over all
From: Bas Nieuwenhuizen
We really use the depth block for the blits.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_formats.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
index e276432..f56f
---
src/amd/vulkan/radv_device.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 4aa6af2..7f68cdc 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -104,6 +104,10 @@ static const VkExtensionProp
101 - 200 of 248 matches
Mail list logo