Re: [Mesa-dev] [PATCH] radeon/uvd: fix field handling on R6XX style UVD

2014-08-26 Thread Alex Deucher
On Sun, Aug 24, 2014 at 8:32 AM, Christian König wrote: > From: Christian König > > The first UVD generation can only do frame based output. > > Signed-off-by: Christian König Can someone pick this up for stable? > --- > src/gallium/drivers/radeon/radeon_video.c | 7 +-- > 1 file changed,

Re: [Mesa-dev] [PATCH] u_vbuf: Make sure all caps are initialized

2014-08-28 Thread Alex Deucher
On Thu, Aug 28, 2014 at 1:52 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Pointed out by valgrind. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83148 > Signed-off-by: Michel Dänzer Reviewed-by: Alex Deucher > --- > src/gallium/auxi

Re: [Mesa-dev] [PATCH] r600g, radeonsi: Always use GTT again for PIPE_USAGE_STREAM buffers

2014-08-28 Thread Alex Deucher
On Thu, Aug 28, 2014 at 2:37 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Putting those in VRAM seems to cause (worse) stutter in Unigine Valley on > some systems. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82050 > Signed-off-by: Michel Dänzer Revi

Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-08-28 Thread Alex Deucher
fine RADEON_GEM_NO_BACKING_STORE (1 << 0) >> #define RADEON_GEM_GTT_UC (1 << 1) >> #define RADEON_GEM_GTT_WC (1 << 2) >> +/* BO is expected to be accessed by the CPU */ >> +#define RADEON_GEM_CPU_ACCESS (1 << 3) >> str

Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-09-08 Thread Alex Deucher
On Thu, Aug 28, 2014 at 9:46 PM, Michel Dänzer wrote: > On 29.08.2014 00:01, Alex Deucher wrote: >> On Thu, Aug 28, 2014 at 4:57 AM, Christian König >> wrote: >>> Am 28.08.2014 um 08:56 schrieb Michel Dänzer: >>> >>>> From: Michel Dänzer >>>

Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-09-09 Thread Alex Deucher
On Mon, Sep 8, 2014 at 9:15 PM, Michel Dänzer wrote: > On 09.09.2014 09:47, Michel Dänzer wrote: >> On 09.09.2014 02:36, Alex Deucher wrote: >>> >>> Updated version with comments integrated. >> >> [...] >> >>> @@ -314,10 +314,12 @@ int radeon_

Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-09-10 Thread Alex Deucher
On Wed, Sep 10, 2014 at 12:03 AM, Michel Dänzer wrote: > On 10.09.2014 01:28, Alex Deucher wrote: >> >> On Mon, Sep 8, 2014 at 9:15 PM, Michel Dänzer wrote: >>> >>> On 09.09.2014 09:47, Michel Dänzer wrote: >>>> >>>> On 09.09.2014 02:36, A

Re: [Mesa-dev] [PATCH] R600/SI: radeonsi: Program RASTER_CONFIG for harvested GPUs v3

2014-09-10 Thread Alex Deucher
On Tue, Sep 9, 2014 at 11:38 PM, Michel Dänzer wrote: > On 10.09.2014 05:08, Tom Stellard wrote: >> >> v2: >>- Write RASTER_CONFIG for all SEs. >> >> v3: >>- Set GRBM_GFX_INDEX.INSTANCE_BROADCAST_WRITES bit. >>- Set GRBM_GFX_INFEX.SH_BROADCAST_WRITES bit when done setting >> PA_SC

Re: [Mesa-dev] [PATCH] radeon/video: use more common buffer infrastructure

2014-09-10 Thread Alex Deucher
On Wed, Sep 10, 2014 at 2:23 PM, Christian König wrote: > From: Christian König > > This allows us to clear the video buffers using the gfx engine(s). > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeon/rad

Re: [Mesa-dev] [PATCH] llvmpipe: fix PIPE_FORMAT_Z24_UNORM_S8_UINT depth on big endian

2014-09-15 Thread Alex Deucher
On Mon, Sep 15, 2014 at 4:48 PM, Dave Airlie wrote: >> >> I never really looked at the big endian stuff so I have no idea if this >> is right. I thought though the channel shift thing now should work >> without endianness awareness if you fetch one 32bit number and then >> break it up into parts w

Re: [Mesa-dev] [PATCH] configure.ac: update libdrm amdgpu version requirement

2017-05-24 Thread Alex Deucher
On Wed, May 24, 2017 at 12:05 PM, Leo Liu wrote: > VCN decode has a new interface, and that depends on the latest libdrm > > Signed-off-by: Leo Liu Reviewed-by: Alex Deucher > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [Mesa-dev] Proposal to branch off old drivers

2017-05-26 Thread Alex Deucher
On Thu, May 25, 2017 at 8:45 PM, Timothy Arceri wrote: > Hi all, > > Following on from the discussion here: > > https://lists.freedesktop.org/archives/mesa-dev/2017-May/155971.html > > Back in 2011/12 despite various concerns old hardware would become useless, > dropping support for DRI1 drivers M

Re: [Mesa-dev] [st/va] change va max_entrypoints

2017-06-14 Thread Alex Deucher
On Wed, Jun 14, 2017 at 9:40 AM, Namburu, Chandu-babu wrote: > From: Chandu Babu N > > > > As encode support is added along with decode, > > now max_entrypoints are two. > > vaMaxNumEntrypoints will return correct value. > > > > Signed-off-by: Chandu Babu N This should probably got to stable as

Re: [Mesa-dev] [PATCH] radeonsi: remove unused field in the PCI ID table

2017-11-07 Thread Alex Deucher
sys.c | 2 +- > src/loader/pci_id_driver_map.h| 2 +- > 4 files changed, 232 insertions(+), 232 deletions(-) Been wanting to do that for a while. Reviewed-by: Alex Deucher > > diff --git a/include/pci_ids/radeonsi_pci_ids.h > b/include/pci_ids/radeons

Re: [Mesa-dev] [PATCH 01/18] radeon/vcn: add vcn encode interface

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:58 PM, wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc.h | 325 > > 1 file changed, 325 insertions(+) > create mode 100644 src/gallium/drivers/radeon/radeon_vcn_enc.h > > diff

Re: [Mesa-dev] [PATCH 04/18] winsys/amdgpu: add vcn enc cs support

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:58 PM, wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > --- > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > b/src/gallium/winsys/a

Re: [Mesa-dev] [PATCH 05/18] vl: add poc type

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang > Please add a better patch description. Why do you need this new element and what does it mean? Alex > Signed-off-by: Boyuan Zhang > --- > src/gallium/include/pipe/p_video_state.h | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [Mesa-dev] [PATCH 06/18] st/va: implement poc type

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang > Same comment as patch 5. Please provide some details as to what this is. Alex > Signed-off-by: Boyuan Zhang > --- > src/gallium/state_trackers/va/picture.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/sta

Re: [Mesa-dev] [PATCH 07/18] radeon/vcn: add common encode part

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang Better patch description please. Something like: Fill out a skeleton interface for video encode on vcn hardware. > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/Makefile.sources | 3 + > src/gallium/drivers

Re: [Mesa-dev] [PATCH 08/18] radeon/vcn: add ib implementations

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang > Better patch description please. Something like: Implement the command buffer submission interfaces for VCN encode. > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 292 > +

Re: [Mesa-dev] [PATCH 09/18] radeon/vcn: add encode header algorithms

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang Better patch description please. What are these for? Please provide a brief overview. > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc.h | 6 ++ > src/gallium/drivers/radeon/radeon_vcn_enc_1_

Re: [Mesa-dev] [PATCH 11/18] radeon/vcn: add encode begin frame

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang Same here :) Add implementation for begin_frame interface for VCN encode. Alex > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc.c | 23 ++- > 1 file changed, 22 insertions(+), 1

Re: [Mesa-dev] [PATCH] radeonsi: fix detection of DRAW_INDIRECT_MULTI on SI

2017-07-25 Thread Alex Deucher
t should still go in. > > Reported-by: Gustaw Smolarczyk > Cc: 17.2 Acked-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_pipe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_pipe.c > b/src/galliu

Re: [Mesa-dev] [PATCH] ac/surface: fix hybrid graphics where APU=GFX9, dGPU=older

2017-07-25 Thread Alex Deucher
On Tue, Jul 25, 2017 at 12:38 PM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 17.2 Reviewed-by: Alex Deucher > --- > src/amd/common/ac_surface.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_s

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-26 Thread Alex Deucher
On Wed, Jul 26, 2017 at 8:15 AM, Nicolai Hähnle wrote: > On 26.07.2017 08:29, Michel Dänzer wrote: >> >> On 25/07/17 05:28 PM, Nicolai Hähnle wrote: >>> >>> On 22.07.2017 14:00, Daniel Stone wrote: I don't have any great solution off the top of my head, but I'd be inclined to b

Re: [Mesa-dev] [PATCH 1/5] clover/memory: Copy data when creating buffers with CL_MEM_USE_HOST_PTR

2017-08-03 Thread Alex Deucher
On Thu, Aug 3, 2017 at 3:33 PM, Aaron Watry wrote: > On Thu, Aug 3, 2017 at 11:53 AM, Jan Vesely wrote: >> On Thu, 2017-08-03 at 00:28 -0500, Aaron Watry wrote: >>> / >>> >>> On Sat, Jul 22, 2017 at 2:27 PM, Jan Vesely wrote: >>> > On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote: >>> > > Fi

Re: [Mesa-dev] AMD RXxxx/Vega: amd-staging-4.12 or amd-staging-drm-next

2017-08-08 Thread Alex Deucher
On Tue, Aug 8, 2017 at 5:48 PM, Dieter Nützel wrote: > Hello Alex, > > which is the 'right' way to switch to (from amd-staging-4.11)? > 4.13-rx UP (like Phoronix 'found';-)) show nice improvements. amd-staging-4.12 is our current internal development branch. amd-staging-drm-next, is just the amd-

Re: [Mesa-dev] [PATCH libdrm] tests/amdgpu: add uvd encode unit tests

2017-08-11 Thread Alex Deucher
On Thu, Aug 10, 2017 at 2:02 PM, wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang Acked-by: Alex Deucher > --- > tests/amdgpu/Makefile.am | 1 + > tests/amdgpu/amdgpu_test.c | 6 + > tests/amdgpu/amdgpu_test.h | 15 ++ > tests/amdg

Re: [Mesa-dev] [PATCH] radeonsi: apply the tess+GS hang workaround to Polaris12 as well

2017-05-05 Thread Alex Deucher
On Fri, May 5, 2017 at 11:14 AM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 17.1 Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeo

[Mesa-dev] [PATCH] radeonsi: add new vega10 pci ids

2017-05-10 Thread Alex Deucher
Cc: 17.1 Signed-off-by: Alex Deucher --- include/pci_ids/radeonsi_pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index 1058682..a20a936 100644 --- a/include/pci_ids/radeonsi_pci_ids.h +++ b/include/pci_ids

Re: [Mesa-dev] GPU (and system) monitoring

2017-11-20 Thread Alex Deucher
On Mon, Nov 20, 2017 at 7:25 AM, Nicolai Hähnle wrote: > This kind of system-level monitoring is typically the domain of the kernel, > not Mesa. > > I know you can get GPU clocks and temperature from there (e.g. umr does that > for the amdgpu kernel module), I don't know about power consumption th

Re: [Mesa-dev] GPU (and system) monitoring

2017-11-20 Thread Alex Deucher
On Mon, Nov 20, 2017 at 5:10 PM, Dieter Nützel wrote: > Am 20.11.2017 18:17, schrieb Alex Deucher: >> >> On Mon, Nov 20, 2017 at 7:25 AM, Nicolai Hähnle >> wrote: >>> >>> This kind of system-level monitoring is typically the domain of the >>> kern

Re: [Mesa-dev] 10-bit Mesa/Gallium support

2017-11-27 Thread Alex Deucher
On Mon, Nov 27, 2017 at 5:01 PM, Adam Jackson wrote: > On Thu, 2017-11-23 at 18:35 +0100, Marek Olšák wrote: >> Hi everybody, >> >> Mario, feel free to push your patches if you haven't yet. (except the >> workaround) >> >> For AMD, I applied Mario's patches (except Wayland - that didn't >> apply)

Re: [Mesa-dev] GBM and the Device Memory Allocator Proposals

2017-11-30 Thread Alex Deucher
On Thu, Nov 30, 2017 at 2:10 PM, Nicolai Hähnle wrote: > On 30.11.2017 19:52, Rob Clark wrote: >> >> On Thu, Nov 30, 2017 at 4:21 AM, Nicolai Hähnle >> wrote: >>> >>> On 30.11.2017 01:09, Miguel Angel Vico wrote: >> >> >> It seems to me that $new_thing should grow as a separate thing

Re: [Mesa-dev] [PATCH 2/2] ac/sid.h: don't use parentheses in PKT3_RELEASE_MEM definition

2017-06-16 Thread Alex Deucher
On Fri, Jun 16, 2017 at 8:30 AM, Marek Olšák wrote: > From: Marek Olšák > > The parses skips the line if it contains parentheses. Series is: Reviewed-by: Alex Deucher > --- > src/amd/common/sid.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH] radeonsi: add new polaris12 pci id

2017-06-16 Thread Alex Deucher
Signed-off-by: Alex Deucher Cc: 17.0 17.1 --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index 50f638f..9453c1c 100644 --- a/include/pci_ids/radeonsi_pci_ids.h +++ b/include

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-29 Thread Alex Deucher
On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: > I want to remove vc4's dependency on headers from libdrm as well, but > storing multiple copies of drm_fourcc.h in our tree would be silly. > > v2: Update Android.mk as well, move distcheck drm*.h references to > top-level noinst_HEADERS.

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 12:02 PM, Eric Anholt wrote: > Alex Deucher writes: > >> On Thu, Jun 29, 2017 at 11:42 AM, Eric Anholt wrote: >>> I want to remove vc4's dependency on headers from libdrm as well, but >>> storing multiple copies of drm_fourcc.h in

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 12:40 PM, Lionel Landwerlin wrote: > On 30/06/17 17:14, Alex Deucher wrote: >> >> On Fri, Jun 30, 2017 at 12:02 PM, Eric Anholt wrote: >>> >>> Alex Deucher writes: >>> >>>> On Thu, Jun 29, 2017 at 11:42 AM,

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 3:02 PM, Eric Anholt wrote: > Alex Deucher writes: > >> On Fri, Jun 30, 2017 at 12:40 PM, Lionel Landwerlin >> wrote: >>> On 30/06/17 17:14, Alex Deucher wrote: >>>> >>>> On Fri, Jun 30, 2017 at 12:02 PM, E

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

2017-07-06 Thread Alex Deucher
On Thu, Jul 6, 2017 at 1:13 PM, Jan Vesely wrote: > On Thu, 2017-07-06 at 12:09 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> Use family, but only set xnack+ for gfx9. >> >> Signed-off-by: Dave Airlie >> --- >> src/amd/common/ac_llvm_util.c | 4 +++- >> 1 file changed, 3 insertions(+), 1

Re: [Mesa-dev] [st/va] Fix leak in VAAPI subpictures

2017-07-06 Thread Alex Deucher
On Thu, Jul 6, 2017 at 2:37 PM, Andres Gomez wrote: > It looks like we could want this into -stable (?) Yes, I think so. Alex > > On Thu, 2017-07-06 at 21:10 +0300, Andres Gomez wrote: >> On Thu, 2017-06-22 at 09:25 +, Namburu, Chandu-babu wrote: >> > From: Chandu Babu N >> > Subject: [PAT

Re: [Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

2017-07-06 Thread Alex Deucher
On Thu, Jul 6, 2017 at 4:56 PM, Marek Olšák wrote: > On Thu, Jul 6, 2017 at 8:12 PM, Alex Deucher wrote: >> On Thu, Jul 6, 2017 at 1:13 PM, Jan Vesely wrote: >>> On Thu, 2017-07-06 at 12:09 +1000, Dave Airlie wrote: >>>> From: Dave Airlie >>>> >

Re: [Mesa-dev] [PATCH 6/6] st/dri: list __DRI2_FENCE extension only where needed

2017-07-07 Thread Alex Deucher
-off-by: Emil Velikov Not really an expert, but the series seems sane to me: Reviewed-by: Alex Deucher > --- > src/gallium/state_trackers/dri/dri2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/state_trackers/dri/dri2.c > b/src/gallium/state_trackers/dri/

Re: [Mesa-dev] [PATCH] amd/addrlib: fix typo in api name.

2017-07-12 Thread Alex Deucher
On Wed, Jul 12, 2017 at 9:18 AM, Nicolai Hähnle wrote: > On 09.07.2017 21:31, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This fixes the misspelling of ALIGNMENTS in addrlib. >> >> Signed-off-by: Dave Airlie > > > Yay, divergence from the internal copy. But it's the right thing to do, > so.

Re: [Mesa-dev] [PATCH 2/2] r600: fix textureSize queries with tbos

2017-12-27 Thread Alex Deucher
On Wed, Dec 27, 2017 at 7:51 PM, Dave Airlie wrote: > On 23 December 2017 at 17:19, wrote: >> From: Roland Scheidegger >> >> piglit doesn't care, but I'm quite confident that the size actually bound >> as range should be reported and not the base size of the resource. >> Also, the array in the

Re: [Mesa-dev] [PATCH] radeonsi: make init_config indirect buffer read-only in GPUVM

2018-01-04 Thread Alex Deucher
On Thu, Jan 4, 2018 at 1:49 PM, Marek Olšák wrote: > From: Marek Olšák > Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_pm4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_pm4.c &g

Re: [Mesa-dev] [PATCH] amdgpu/soc15: make the pcie index/data registers constant.

2017-09-29 Thread Alex Deucher
Dave Airlie Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 8 > drivers/gpu/drm/amd/amdgpu/nbio_v6_1.h | 2 +- > drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c | 8 > drivers/gpu/drm/amd/amdgpu/nbio_v7_0.h | 2 +- > drivers/gpu/dr

Re: [Mesa-dev] [PATCH 2/2] va: call texture_get_handle while the mutex is being held

2017-01-04 Thread Alex Deucher
On Wed, Jan 4, 2017 at 5:47 AM, Marek Olšák wrote: > From: Marek Olšák > > The context may be used by texture_get_handle. The the omx state tracker need this as well? Alex > --- > src/gallium/state_trackers/va/buffer.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --

Re: [Mesa-dev] [PATCH] gallium/radeon: use the internal clear_buffer callback to fix r600g

2017-01-06 Thread Alex Deucher
On Fri, Jan 6, 2017 at 4:26 PM, Marek Olšák wrote: > From: Marek Olšák > > r600g doesn't set pipe_context::clear_buffer. Mention the bug report here: https://bugs.freedesktop.org/show_bug.cgi?id=99303 With that: Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeo

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Alex Deucher
On Tue, Jan 10, 2017 at 4:50 AM, Nayan Deshmukh wrote: > On Fri, Jan 6, 2017 at 2:20 AM, Andy Furniss wrote: >> Christian König wrote: >>> >>> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: dri3 allows us to send handle of a texture directly to X so this patch allows a state tracke

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Alex Deucher
On Tue, Jan 10, 2017 at 12:56 PM, Andy Furniss wrote: > Alex Deucher wrote: >> >> On Tue, Jan 10, 2017 at 4:50 AM, Nayan Deshmukh >> wrote: >>> >>> On Fri, Jan 6, 2017 at 2:20 AM, Andy Furniss wrote: >>>> >>>> Christian Köni

Re: [Mesa-dev] [PATCH 15/17] gallium/radeon: remove r600_common_context::max_db

2017-01-26 Thread Alex Deucher
On Thu, Jan 26, 2017 at 12:39 PM, Gustaw Smolarczyk wrote: > 2017-01-26 17:04 GMT+01:00 Marek Olšák : >> From: Marek Olšák >> >> this cleanup is based on the vulkan driver, which seems to do the same thing > > Is this also ok for r600g? If I'm right, the amdgpu-pro Vulkan driver > doesn't have an

Re: [Mesa-dev] [PATCH 6/9] gallium: decrease the size of pipe_box - 24 -> 16 bytes

2017-04-03 Thread Alex Deucher
On Sun, Apr 2, 2017 at 2:00 PM, Marek Olšák wrote: > From: Marek Olšák > > Also: > > pipe_transfer: 48 -> 40 bytes. > pipe_blit_info = 176 -> 160 bytes. > --- > src/gallium/include/pipe/p_state.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/include

[Mesa-dev] [PATCH] radeonsi: add new polaris10 pci id

2017-04-05 Thread Alex Deucher
Cc: 13.0 17.0 Signed-off-by: Alex Deucher --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index f4139ea..1058682 100644 --- a/include/pci_ids/radeonsi_pci_ids.h +++ b/include

Re: [Mesa-dev] [PATCH 00/53] i965: Eat libdrm_intel for breakfast

2017-04-05 Thread Alex Deucher
On Wed, Apr 5, 2017 at 2:03 PM, Emil Velikov wrote: > On 5 April 2017 at 18:55, Daniel Vetter wrote: >> On Wed, Apr 05, 2017 at 04:38:25PM +0100, Emil Velikov wrote: >>> Hi Ken, >>> >>> On 5 April 2017 at 01:09, Kenneth Graunke wrote: >>> > Hello, >>> > >>> > This series imports libdrm_intel int

Re: [Mesa-dev] [PATCH 00/53] i965: Eat libdrm_intel for breakfast

2017-04-05 Thread Alex Deucher
On Wed, Apr 5, 2017 at 2:27 PM, Kristian Høgsberg wrote: > On Wed, Apr 5, 2017 at 11:11 AM, Jason Ekstrand wrote: >> On Wed, Apr 5, 2017 at 11:03 AM, Emil Velikov >> wrote: >>> >>> On 5 April 2017 at 18:55, Daniel Vetter wrote: >>> > On Wed, Apr 05, 2017 at 04:38:25PM +0100, Emil Velikov wrote:

Re: [Mesa-dev] [PATCH] gallium/radeon: fix typo in radeon_winsys.h

2017-04-06 Thread Alex Deucher
On Thu, Apr 6, 2017 at 8:27 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeon/radeon_winsys.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeon/radeon

Re: [Mesa-dev] [PATCH] virgl: increase command size buffer a bit for constant buffers.

2018-06-15 Thread Alex Deucher
On Thu, Jun 14, 2018 at 11:13 PM, Dave Airlie wrote: > From: Dave Airlie > > If we want to upload 16k 32-bit consts we need a bit of overhead > to faciliate that. > > Fixes crash in: > KHR-GL44.geometry_shader.limits.max_uniform_components > --- > src/gallium/drivers/virgl/virgl_winsys.h | 2 +-

Re: [Mesa-dev] OpenCL Support on older AMD GPUs

2018-08-23 Thread Alex Deucher
On Thu, Aug 23, 2018 at 11:30 AM Benson Muite wrote: > > Hi, > > Is there likely to be support for OpenCL on older AMD GPUs? I have tried > running an OpenCL benchmark (https://github.com/mpicbg-scicomp/gearshifft) on > an AMD A6-6420K APU running Fedora 28. The code seems to partially run, but

Re: [Mesa-dev] [PATCH] radv: don't expose linear depth surfaces on SI/CIK/VI either.

2018-08-30 Thread Alex Deucher
On Fri, Aug 31, 2018 at 1:57 AM Dave Airlie wrote: > > From: Dave Airlie > > ac_surface.c: gfx6_compute_surface says > /* DB doesn't support linear layouts. */ I think r100 was the last chip to support linear depth surfaces. Alex > > Now if we expose linear depth and create a linear depth imag

Re: [Mesa-dev] Introduction to Community and Queries Regarding Task : Unit and performance tests for VA-API

2018-09-02 Thread Alex Deucher
On Sat, Sep 1, 2018 at 9:02 AM Iti Shree wrote: > > Good morning, > > I am Iti Shree currently pursuing B.Tech degree in Information and > Technology. I was browsing through some project and saw Xorg project ideas. > Many of them are indeed interesting, though they have precise hardware > requi

[Mesa-dev] [PATCH] pci_ids: add new polaris pci id

2018-09-19 Thread Alex Deucher
Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index c8d30597230..dd2fc3b8f25 100644 --- a/include/pci_ids

Re: [Mesa-dev] Lets talk about autotools

2018-11-29 Thread Alex Deucher
On Thu, Nov 29, 2018 at 8:26 PM Eric Anholt wrote: > > Emil Velikov writes: > > > Hi all, > > > > I can see why people may opt to not use or maintain the autotools build. > > Although I would kindly ask that we do not remove it just yet. > > > > In Mesa, we have different parts not used by differ

Re: [Mesa-dev] Lets talk about autotools

2018-11-29 Thread Alex Deucher
On Thu, Nov 29, 2018 at 9:19 PM Jason Ekstrand wrote: > > On November 29, 2018 19:49:33 Alex Deucher wrote: > > > On Thu, Nov 29, 2018 at 8:26 PM Eric Anholt wrote: > >> > >> Emil Velikov writes: > >> > >>> Hi all, > >>> >

[Mesa-dev] [PATCH 1/2] pci_ids: add new vega10 pci ids

2018-12-07 Thread Alex Deucher
Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- include/pci_ids/radeonsi_pci_ids.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index 35ea3559b02..f7defc4197a 100644 --- a

[Mesa-dev] [PATCH 2/2] pci_ids: add new vega20 pci id

2018-12-07 Thread Alex Deucher
Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index f7defc4197a..a2bc9213207 100644 --- a/include/pci_ids

Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Alex Deucher
No offense, but if someone did bring up a need for autotools would it really make a difference? I believe the majority has spoken. Alex On Mon, Dec 10, 2018 at 6:11 PM Dylan Baker wrote: > > Meson 0.49.0 has been out for a couple of days now, and I'd like to make the > final call for autotools.

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Alex Deucher
On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset wrote: > > Personally, I will continue to use the list, at least for a simplicity > point of view. I'm not sure if using a new tool will improve quality and > code review process. > > Though, if the majority reports that is really nice to use, I will

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Alex Deucher
On Thu, Dec 13, 2018 at 11:41 AM Jason Ekstrand wrote: > > On Thu, Dec 13, 2018 at 9:56 AM Ilia Mirkin wrote: >> >> On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher wrote: >> > >> > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset >> > wrote: >>

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Alex Deucher
On Fri, Dec 14, 2018 at 11:32 AM Matt Turner wrote: > > On Fri, Dec 14, 2018 at 4:12 AM Gert Wollny wrote: > > I second that, I voiced my concerns in a former thread, especially that > > so far this upcoming change has not been officially announced in the > > release notes or on mesa-user, and th

Re: [Mesa-dev] [PATCH 1/2] pci_ids: add new vega10 pci ids

2018-12-14 Thread Alex Deucher
Ping? Alex On Fri, Dec 7, 2018 at 4:11 PM Alex Deucher wrote: > > Signed-off-by: Alex Deucher > Cc: mesa-sta...@lists.freedesktop.org > --- > include/pci_ids/radeonsi_pci_ids.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/pc

[Mesa-dev] [PATCH] pci_ids: add new VegaM pci id

2018-12-20 Thread Alex Deucher
Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index a2bc9213207..75ac7761bb4 100644 --- a/include/pci_ids

Re: [Mesa-dev] [PATCH] pci_ids: add new VegaM pci id

2018-12-21 Thread Alex Deucher
Ping? On Thu, Dec 20, 2018 at 10:13 AM Alex Deucher wrote: > > Signed-off-by: Alex Deucher > Cc: mesa-sta...@lists.freedesktop.org > --- > include/pci_ids/radeonsi_pci_ids.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/pci_ids/radeonsi_pci_id

Re: [Mesa-dev] Mesamatrix donator message

2018-02-21 Thread Alex Deucher
On Wed, Feb 21, 2018 at 11:12 AM, Romain Failliot wrote: > Hi! > > I received a donation on Mesamatrix with this message with it: > >> Please fix long-standing bug, not allowing to properly >> recognize my Bonaire XT card with glxinfo tool; for now, >> it reports Bonaire. See my WineHQ bug: #38921

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-02-21 Thread Alex Deucher
On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace wrote: > On Thu 21 Dec 2017, Daniel Vetter wrote: >> On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen >> wrote: >>> On Wed, Dec 20, 2017 at 12:41 PM, Miguel Angel Vico >>> wrote: On Wed, 20 Dec 2017 11:54:10 -0800 Kristian Høgsberg

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-02-22 Thread Alex Deucher
On Thu, Feb 22, 2018 at 1:49 PM, Bas Nieuwenhuizen wrote: > On Thu, Feb 22, 2018 at 7:04 PM, Kristian Høgsberg > wrote: >> On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: >> >>> On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace >> wrote: >>>

Re: [Mesa-dev] [PATCH] radeonsi: fix radeon create encoder return

2018-02-27 Thread Alex Deucher
On Tue, Feb 27, 2018 at 5:43 PM, wrote: > From: Boyuan Zhang > > Previous patch missed a "return" when trying to modify the create encoder > function, which made the whole logic fail. Therefore, add the return back. > > Signed-off-by: Boyuan Zhang Reviewed-by:

Re: [Mesa-dev] [PATCH 3/5] winsys/amdgpu: pad compute rings

2018-03-07 Thread Alex Deucher
On Wed, Mar 7, 2018 at 3:34 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > index d9a95c0..9cd334

Re: [Mesa-dev] [PATCH 3/5] winsys/amdgpu: pad compute rings

2018-03-08 Thread Alex Deucher
On Thu, Mar 8, 2018 at 11:51 AM, Marek Olšák wrote: > From: Marek Olšák > > v2: pad with PKT2 NOPs on SI Reviewed-by: Alex Deucher > --- > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/g

Re: [Mesa-dev] [PATCH 1/5] radeonsi: align command buffer starting address to fix some Raven hangs

2018-03-08 Thread Alex Deucher
On Wed, Mar 7, 2018 at 3:34 PM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 17.3 18.0 Reviewed-by: Alex Deucher > --- > src/amd/common/ac_gpu_info.c | 21 - > src/amd/common/ac_gpu_info.h | 1 + > src/gal

Re: [Mesa-dev] [PATCH 2/5] radeonsi: expand constbuf 0 address correctly to fix Vega10 hangs

2018-03-08 Thread Alex Deucher
On Wed, Mar 7, 2018 at 3:34 PM, Marek Olšák wrote: > From: Marek Olšák > > This is only required with the latest libdrm. > > This fixes 32-bit support with high addresses. > (and possibly 64-bit support too because the high bits need to be masked out) Acked-by: Alex Deuc

Re: [Mesa-dev] [PATCH 4/5] winsys/amdgpu: query GDS info

2018-03-08 Thread Alex Deucher
On Wed, Mar 7, 2018 at 3:34 PM, Marek Olšák wrote: > From: Marek Olšák > Reviewed-by: Alex Deucher > --- > src/amd/common/ac_gpu_info.c | 11 +++ > src/amd/common/ac_gpu_info.h | 2 ++ > 2 files changed, 13 insertions(+) > > diff --git a/src/amd/common/ac_gpu

Re: [Mesa-dev] [PATCH] st/dri: fix OpenGL-OpenCL interop for GL_TEXTURE_BUFFER

2018-03-08 Thread Alex Deucher
On Wed, Mar 7, 2018 at 3:35 PM, Marek Olšák wrote: > From: Marek Olšák > > Tested by our OpenCL team. > > Fixes: 9c499e6759b26c5e "st/mesa: don't invoke st_finalize_texture & > st_convert_sampler for TBOs" Acked-by: Alex Deucher > --- >

Re: [Mesa-dev] [PATCH 5/5] radeonsi: remove chip_class parameter from si_lower_nir

2018-03-08 Thread Alex Deucher
On Wed, Mar 7, 2018 at 3:34 PM, Marek Olšák wrote: > From: Marek Olšák > > We can get it from si_screen. Acked-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_compute.c | 3 +-- > src/gallium/drivers/radeonsi/si_shader.h| 4 +--- > src/gal

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

2018-03-09 Thread Alex Deucher
On Fri, Mar 9, 2018 at 11:04 AM, Jason Ekstrand wrote: > On March 9, 2018 00:35:06 Michel Dänzer wrote: > >> On 2018-03-08 07:53 PM, Jason Ekstrand wrote: >>> >>> On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker >> > wrote: >>> >>> > I know we've always given a lot of f

Re: [Mesa-dev] [PATCH] r600: don't do stack workarounds for hemlock

2018-02-01 Thread Alex Deucher
ed. > (Discovered by accident.) Acked-by: Alex Deucher > --- > src/gallium/drivers/r600/sb/sb_bc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/r600/sb/sb_bc.h > b/src/gallium/drivers/r600/sb/sb_bc.h > index b35671bf0f..a249395474 100644

Re: [Mesa-dev] [PATCH 5/8] drivers/radeon:add uvd hevc enc functions

2018-02-05 Thread Alex Deucher
On Mon, Feb 5, 2018 at 12:16 PM, James Zhu wrote: > Implement UVD hevc encode functions > > Signed-off-by: James Zhu > --- > 1 | 21 ++ > src/gallium/drivers/radeon/radeon_uvd_enc.c | 340 > > 2 files changed, 361 insertion

Re: [Mesa-dev] [PATCH v2 0/8] The 2nd version for UVD HEVC encode

2018-02-08 Thread Alex Deucher
On Thu, Feb 8, 2018 at 5:28 PM, Mark Thompson wrote: > On 06/02/18 20:05, James Zhu wrote: >> The whole series are the updated version. Changes are made mainly based >> on the comments from prevous code review from Alex, Leo and Boyuan >> >> James Zhu (8): >> amd/common:add uvd hevc enc support

Re: [Mesa-dev] [PATCH] amd/common: fix ASICREV_IS_POLARIS11_M for Polaris12

2017-02-28 Thread Alex Deucher
On Tue, Feb 28, 2017 at 3:09 PM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 17.0 Reviewed-by: Alex Deucher > --- > src/amd/common/amdgpu_id.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/common/amdgpu_id.h b/src/amd/common/amd

[Mesa-dev] [PATCH] radeonsi: add new polaris12 pci id

2017-03-17 Thread Alex Deucher
Cc: 17.0 Signed-off-by: Alex Deucher --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index fca47b0..b14291d 100644 --- a/include/pci_ids/radeonsi_pci_ids.h +++ b/include/pci_ids

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI v2

2017-03-20 Thread Alex Deucher
On Sun, Mar 19, 2017 at 9:49 AM, Christian König wrote: > Hi Peter, > > Adding Michel and Marek for the Mesa interop side and Harry for the display > side. > > How do you want us to display the decoded surfaces? > > Well to make a long story short: I don't have the slightest idea. Ideally we > wou

Re: [Mesa-dev] [PATCH 136/140] radeon/vce: add support for firmware 53.14.4

2017-03-21 Thread Alex Deucher
On Tue, Mar 21, 2017 at 9:46 AM, Marek Olšák wrote: > On Tue, Mar 21, 2017 at 7:49 AM, Christian König > wrote: >> Am 20.03.2017 um 23:49 schrieb Marek Olšák: >>> >>> From: Leo Liu >>> >>> Signed-off-by: Leo Liu >>> Acked-by: Alex Deuch

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-22 Thread Alex Deucher
On Thu, Mar 16, 2017 at 5:25 PM, Dylan Baker wrote: > Why bother, and why would we want this? >│~ > > First it's written in python, which means the potential developer base > is massive. And it provides a recursive view for humans, but

Re: [Mesa-dev] [RFC 00/11] GL_ARB_gpu_shader_fp64

2017-03-23 Thread Alex Deucher
On Thu, Mar 23, 2017 at 11:51 AM, tournier.elie wrote: > Hello, > > It's seems impossible to expose all the drivers to soft fp64 with one > piece of code. > So what do you think about landing this series (with some fix) for r600? > > The other drivers will use the NIR version of soft fp64. > BTW,

Re: [Mesa-dev] [PATCH 0/6] Add support for GL_NV_fill_rectangle

2017-03-23 Thread Alex Deucher
On Thu, Mar 23, 2017 at 2:18 PM, Marek Olšák wrote: > Is there any user of this extension? Based on the spec, it seems like it would be useful for glamor. No idea is anyone has code to use it yet. Alex > > Marek > > On Thu, Mar 23, 2017 at 4:27 PM, Lyude wrote: >> This adds basic support for

Re: [Mesa-dev] [PATCH 0/6] Add support for GL_NV_fill_rectangle

2017-03-23 Thread Alex Deucher
On Thu, Mar 23, 2017 at 2:57 PM, Ilia Mirkin wrote: > On Thu, Mar 23, 2017 at 2:45 PM, Lyude Paul wrote: >> On Thu, 2017-03-23 at 14:22 -0400, Alex Deucher wrote: >>> On Thu, Mar 23, 2017 at 2:18 PM, Marek Olšák >>> wrote: >>> > Is there any user of this e

Re: [Mesa-dev] [PATCH 1/2] gallium: Add PIPE_CAP_USER_MEMORY_PAGE_SIZE for page size of user pointers

2017-08-16 Thread Alex Deucher
On Wed, Aug 16, 2017 at 10:39 PM, Michel Dänzer wrote: > On 17/08/17 10:52 AM, Aaron Watry wrote: >> PIPE_CAP_RESOURCE_FROM_USER_MEMORY says that size must be page aligned, >> but doesn't necessarily say anything about the size of those pages. > > Is there any case known so far where it's not the

Re: [Mesa-dev] [PATCH 1/2] gallium: Add PIPE_CAP_USER_MEMORY_PAGE_SIZE for page size of user pointers

2017-08-16 Thread Alex Deucher
On Wed, Aug 16, 2017 at 11:34 PM, Michel Dänzer wrote: > On 17/08/17 12:33 PM, Aaron Watry wrote: >> On Wed, Aug 16, 2017 at 9:48 PM, Alex Deucher wrote: >>> On Wed, Aug 16, 2017 at 10:39 PM, Michel Dänzer wrote: >>>> On 17/08/

Re: [Mesa-dev] [PATCH 1/2] gallium: Add PIPE_CAP_USER_MEMORY_PAGE_SIZE for page size of user pointers

2017-08-17 Thread Alex Deucher
On Thu, Aug 17, 2017 at 2:17 PM, Jan Vesely wrote: > Hi, > > thanks a lot for these answers. > > On Thu, 2017-08-17 at 15:01 +0200, Christian König wrote: >> Am 17.08.2017 um 13:54 schrieb Jan Vesely: >> > On Thu, 2017-08-17 at 11:54 +0200, Christian König wrote: >> > > [SNIP] >> > > In general AT

<    1   2   3   4   5   6   7   8   9   >