On Wed, Dec 27, 2017 at 7:51 PM, Dave Airlie <airl...@gmail.com> wrote: > On 23 December 2017 at 17:19, <srol...@vmware.com> wrote: >> From: Roland Scheidegger <srol...@vmware.com> >> >> piglit doesn't care, but I'm quite confident that the size actually bound >> as range should be reported and not the base size of the resource. >> Also, the array in the constant buffer looks overallocated by a factor of 4. >> For eg, also decrease the size by another factor of 2 by using the same >> constant slot for both buffer size (required for txq for TBOs) and the number >> of layers for cube arrays, as these are mutually exclusive. Could of course >> use >> some more logic and only actually do this for the samplers/images/buffers >> where >> it's required rather than for all, but ah well... >> (FWIW I believe the txq for TBOs would be fixable on EG without using a >> constant buffer by using the GET_BUFFER_RESINFO vc fetch, but for cube map >> arrays we'd still need the buffer as it's unfixable since the hw requires >> always 0 unfortunately.) > > For the series: > > Reviewed-by: Dave Airlie <airl...@redhat.com> > from previous experiments the hw doesn't work at all using vc fetch or > otherwise.
vc vs tc fetch just determines which cache is used. vc was slower than tc and was not present on some asics and was eventually removed altogether. Alex > > Dave. > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
