:
Rob Herring
- Drop patch:
android: Change gralloc_handle_t format from Android format to fourcc
Robert Foss (5):
android: Move gralloc handle struct to libdrm
android: Add version variable to gralloc_handle_t
android: Mark gralloc_handle_t magic variable as const
android: Remove member
The version variable will be used for versioning of this
struct and the corresponding accessor functions.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
android/gralloc_handle.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/android/gralloc_handle.h b
: Robert Foss
Reviewed-by: Rob Herring
---
Changes since v2:
Suggested by Rob Herring:
- Switch to gbm_gralloc copyright statement as a base
Changes since v1:
Suggested by Rob Herring:
- Fixed copyright statement
- Moved FDs to be first in handle
- Initialize native_handle_t using
The name member of gralloc_handle_t is no longer needed and has been removed.
The version field has also been bumped.
Signed-off-by: Robert Foss
Reviewed-by: Rob Herring
---
android/gralloc_handle.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/android/gralloc_handle.h
:01 AM, Tomasz Figa wrote:
Hi Rob,
On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss wrote:
uint32_t (*get_fd)(buffer_handle_t handle, uint32_t plane);
uint64_t (*get_modifier)(buffer_handle_t handle, uint32_t
plane);
uint32_t (*get_offsets)(buffer_handle_t handle, uint32_t plane
The is_color_attachement variable is later read when handling two
separate error cases, where only one of the cases results in the
variable being initialized.
This can be avoided by giving the variable a safe default value.
Coverity-Id: 1398631
Signed-off-by: Robert Foss
---
src/mesa/main
The is_color_attachement variable is later read when handling two
separate error cases, where only one of the cases results in the
variable being initialized.
This can be avoided by giving the variable a safe default value.
Coverity-Id: 1398631
Signed-off-by: Robert Foss
Reviewed-by: Ilia
From: Gustavo Padovan
Following the support for fences on the virtio driver add support
for native fence on virgl. This was somewhat based on the freedeno one.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
Retransmission: Missed CC-ing mesa-dev
Linux virtgpu fences branch
Following the support for fences on the virtio driver add support
for native fence on virgl. This was somewhat based on the freedeno one.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
This patch has been tested using Qemu & Virglrenderer.
Linux virtgpu fences branch:
h
Following the support for fences on the virtio driver add support
for native fence on virgl. This was somewhat based on the freedeno one.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Sorry about the spam, but I realized Emils r-b wasn't
includ
Hey Emil,
I just pushed v5 upstream. Let me spin a cleanup patch and send that to the ML.
Rob.
On 2018-11-16 14:03, Emil Velikov wrote:
Hi Rob,
I've spotted a couple of nitpicks, but I don't feel too strongly either way.
On Thu, 15 Nov 2018 at 13:28, Robert Foss wrote:
Remove a dead variable, an unneeded int->bool conversion
and some whitespace changes.
Signed-off-by: Robert Foss
---
Sorry about the spam, and this not being included in
v5 which was upstreamed. But nevertheless it should be fixed,
and here's the commit.
src/gallium/drive
Build kms_swrast for the Android platform
Robert Foss (3):
egl/android: Add Android property for forcing kms_swrast
platform/android: Enable kms_swrast fallback
DEBUG
Tomeu Vizoso (1):
st/dri: Allow kms_swrast to work without a device FD
src/egl/drivers/dri2/egl_dri2.c
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
---
src/egl/main/egldriver.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/egl/main/egldriver.c b/sr
From: Tomeu Vizoso
A KMS device isn't strictly needed for the kms_swrast to work, so stop
failing to init if the FD is -1. Also don't call DRM_IOCTL_GET_CAP in
that case.
This allows the driver to be used in machines where no KMS device at all
is present.
Signed-off-by: Tomeu Vizoso
---
src/g
From: Rob Herring
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
---
src/gallium/Android.mk | 2 +-
src/gallium/auxiliary/pipe-loader/Android.mk | 1 +
src/gallium/drivers/softpipe/Android.mk | 4 +--
src/gallium/state_trackers/dri/Android.mk| 1
ned-off-by: Robert Foss
---
src/egl/drivers/dri2/platform_android.c | 26 +
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_android.c
b/src/egl/drivers/dri2/platform_android.c
index 92b2d2b343e..bc644c25bf9 100644
--- a/src/egl/dr
Signed-off-by: Robert Foss
---
src/egl/drivers/dri2/egl_dri2.c | 29 +++
src/egl/drivers/dri2/platform_android.c | 27 +
src/egl/main/egldriver.c | 8 -
src/gallium/auxiliary/Android.mk | 5
src
Hey Eric!
On 05/07/18 12:35, Eric Engestrom wrote:
On Thursday, 2018-07-05 12:07:36 +0200, Robert Foss wrote:
From: Tomeu Vizoso
A KMS device isn't strictly needed for the kms_swrast to work, so stop
failing to init if the FD is -1. Also don't call DRM_IOCTL_GET_CAP in
that c
+ Wu Zhen
On 05/07/18 12:07, Robert Foss wrote:
This series is an early draft a kms_swrast implementation for the Android
platform.
It's available here:
https://gitlab.collabora.com/robertfoss/mesa/tree/kms_swrast_rfc
The current state isn't entirely functional, but the driver l
Hey Tomasz,
On 05/07/18 15:07, Tomasz Figa wrote:
Hi Emil, Robert,
On Thu, Jul 5, 2018 at 9:57 PM Emil Velikov wrote:
On 5 July 2018 at 12:32, Robert Foss wrote:
Hey Eric!
On 05/07/18 12:35, Eric Engestrom wrote:
On Thursday, 2018-07-05 12:07:36 +0200, Robert Foss wrote:
From: Tomeu
Hey Tomasz,
On 05/07/18 16:16, Tomasz Figa wrote:
On Thu, Jul 5, 2018 at 7:07 PM Robert Foss wrote:
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
---
sr
Hey Emil,
On 05/07/18 15:13, Emil Velikov wrote:
Hi Rob,
On 5 July 2018 at 11:07, Robert Foss wrote:
@@ -511,7 +515,7 @@ dri2_open_driver(_EGLDisplay *disp)
char path[PATH_MAX], *search_paths, *next, *end;
char *get_extensions_name;
const __DRIextension **(*get_extensions
Hey Tomasz,
On 05/07/18 16:26, Tomasz Figa wrote:
Hi Rob,
On Thu, Jul 5, 2018 at 7:07 PM Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to a non-zero value.
kms_swra
On 05/07/18 17:50, Robert Foss wrote:
Hey Emil,
On 05/07/18 15:13, Emil Velikov wrote:
Hi Rob,
On 5 July 2018 at 11:07, Robert Foss wrote:
@@ -511,7 +515,7 @@ dri2_open_driver(_EGLDisplay *disp)
char path[PATH_MAX], *search_paths, *next, *end;
char *get_extensions_name
Hey Emil,
On 05/07/18 15:04, Emil Velikov wrote:
Hi Rob,
On 5 July 2018 at 11:07, Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to a non-zero value.
kms_swrast is also
From: Rob Herring
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Added r-b
src/gallium/Android.mk | 2 +-
src/gallium/auxiliary/pipe-loader/Android.mk | 1 +
src/gallium/drivers/softpipe/Android.mk
ned-off-by: Robert Foss
---
Changes since RFC:
- Removed whitespace change
- Switched variable type from int to EGLBoolean
- Removed software renderer fallback from platform_android, since
it is already implemented in _eglMatchDriver()
src/egl/drivers/dri2/platform_andr
ssues
Rob.
Rob Herring (1):
android: Build kms_swrast for the Android platform
Robert Foss (2):
egl/android: Add Android property for forcing software rendering
platform/android: Enable kms_swrast fallback
src/egl/drivers/dri2/platform_android.c | 19 ++-
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Fixed EGLBoolean comparison
- Added r-b
src/egl/main/egldri
Hey Eric,
Thanks for the quick reviews!
On 09/07/18 15:45, Eric Engestrom wrote:
On Monday, 2018-07-09 13:01:49 +0200, Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to
Hey Mauro,
On 09/07/18 14:27, Mauro Rossi wrote:
Hi Robert,
Il giorno lun 9 lug 2018 alle ore 13:01 Robert Foss <mailto:robert.f...@collabora.com>> ha scritto:
NOTE: This series has not been tested successfully, and I'm seeing a
segfault
during the boot proc
Hey,
On 2018-07-09 13:01, Robert Foss wrote:
NOTE: This series has not been tested successfully, and I'm seeing a segfault
during the boot process. Which I'm currently looking into.
Tracking down the segfault I've been seeing through mesa and aosp and
bootanimation.
ned-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
Changes since v1:
- Added r-b
- Removed local variable
Changes since RFC:
- Removed whitespace change
- Switched variable type from int to EGLBoolean
- Removed software renderer fallback from platform_android, since
it
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Fixed EGLBoolean comparison
- Added r-b
src/egl/main/egldri
"st/dri: Allow kms_swrast to work without a device FD"
- Removed software renderer fallback from platform_android
- Fixed various smaller issues
Rob Herring (1):
android: Build kms_swrast for the Android platform
Robert Foss (3):
softpipe: Add assert verifying successful pipe_transf
From: Rob Herring
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Added r-b
src/gallium/Android.mk | 2 +-
src/gallium/auxiliary/pipe-loader/Android.mk | 1 +
src/gallium/drivers/softpipe/Android.mk
This failure mode is a bit tricky to debug and manifests itself
later as a null pointer dereference, for which finding the origin
is needlessly tricky.
Signed-off-by: Robert Foss
---
Changes since v1:
- Patch added
src/gallium/drivers/softpipe/sp_tile_cache.c | 1 +
1 file changed, 1
Hey Eric,
On 2018-07-17 12:48, Eric Engestrom wrote:
On Tuesday, 2018-07-17 12:32:59 +0200, Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to a non-zero value.
kms_swra
Hey Eric,
Thanks for the review, adding you r-b.
On 2018-07-17 12:48, Eric Engestrom wrote:
On Tuesday, 2018-07-17 12:32:59 +0200, Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
pro
Thanks Brian!
On 2018-07-17 16:18, Brian Paul wrote:
On 07/17/2018 04:32 AM, Robert Foss wrote:
This failure mode is a bit tricky to debug and manifests itself
later as a null pointer dereference, for which finding the origin
is needlessly tricky.
Signed-off-by: Robert Foss
---
Changes
Hey Rob,
On 2018-07-18 15:30, Rob Herring wrote:
On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote:
This series implements kms_swrast support for the Android
platform. And since having to debug a null pointer dereference,
simplify that process for the next guy.
So is this working for you
Hey Rob,
On 2018-07-19 09:26, Tomasz Figa wrote:
On Thu, Jul 19, 2018 at 12:08 AM Robert Foss wrote:
Hey Rob,
On 2018-07-18 15:30, Rob Herring wrote:
On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote:
This series implements kms_swrast support for the Android
platform. And since having
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
Reviewed-by: Eric Engestrom
---
Changes since RFC:
- Fixed EGLBoolean comparison
- Added
This failure mode is a bit tricky to debug and manifests itself
later as a null pointer dereference, for which finding the origin
is needlessly tricky.
Signed-off-by: Robert Foss
Reviewed-by: Brian Paul
---
Changes since v2:
- Added r-b
Changes since v1:
- Patch added
src/gallium
ned-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
Changes since v2:
- Further remove variable/argument that is just a copy of other variable
Changes since v1:
- Added r-b
- Removed local variable
Changes since RFC:
- Removed whitespace change
- Switched variable type from int to
ixed various smaller issues
Rob Herring (1):
android: Build kms_swrast for the Android platform
Robert Foss (3):
softpipe: Add assert verifying successful pipe_transfer_map
egl/android: Add Android property for forcing software rendering
platform/android: Enable kms_swrast fallback
From: Rob Herring
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Added r-b
src/gallium/Android.mk | 2 +-
src/gallium/auxiliary/pipe-loader/Android.mk | 1 +
src/gallium/drivers/softpipe/Android.mk
Hey Mauro,
This looks good to me.
Signed-off-by: Robert Foss
On 2018-07-22 10:14, Mauro Rossi wrote:
Android build system will try to compile vk_format_table.c
as a shipped source, but at compile time it will be missing,
we move it to generated source, where it belongs
Signed-off-by: Mauro
Hey Mauro,
This looks good to me.
Signed-off-by: Robert Foss
On 2018-07-22 10:14, Mauro Rossi wrote:
Patch changes radv entrypoints generator to not skip this extension even
though it is set as disabled in the vk.xml
Reference: 63525ba730 ("android: enable VK_ANDROID_native_buffer&qu
Hey Mauro,
This looks good to me.
Reviewed-by: Robert Foss
On 2018-07-22 10:15, Mauro Rossi wrote:
src/amd/Android.mk requires to include src/amd/vulkan/Android.mk
to enable the build of vulkan.radv module
Signed-off-by: Mauro Rossi
---
src/amd/Android.mk | 1 +
1 file changed, 1
Hey Rob,
On 2018-07-18 15:30, Rob Herring wrote:
On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote:
This series implements kms_swrast support for the Android
platform. And since having to debug a null pointer dereference,
simplify that process for the next guy.
So is this working for you
ay to go since vitio-gpu
support landed in libdrm.
Reviewed-by: Robert Foss
Cc: Robert Foss
Cc: Tomasz Figa
Signed-off-by: Emil Velikov
---
If using VGEM the following patch is needed [1]. It's been on the list
for ages - will double-check and commmit it to drm-misc.
Hey Emil,
On 13/08/2018 16.44, Emil Velikov wrote:
From: Emil Velikov
Replace the manual handling of /dev/dri in famour of the drmDevice API.
The latter provides a consistent way of enumerating the devices,
providing device details as needed.
Cc: Robert Foss
Cc: Tomasz Figa
Signed-off-by
Hey again
On 13/08/2018 21.01, Robert Foss wrote:
Hey Emil,
On 13/08/2018 16.44, Emil Velikov wrote:
From: Emil Velikov
Replace the manual handling of /dev/dri in famour of the drmDevice API.
The latter provides a consistent way of enumerating the devices,
providing device details as needed
alloc.
If we are going to support the drm_gralloc usecase and this patch is needed
to do so, I'm all for it.
With the above suggestion fixed:
Reviewed-by: Robert Foss
Rob.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
/show_bug.cgi?id=95203
Fixes: b87856d25d1 ("st/omx: Fix resource leak on OMX_ErrorNone")
Cc: Andy Furniss
Cc: Robert Foss
Signed-off-by: Emil Velikov
---
What an embarassing bug - missing brackets. Andy can you confirm that it
resolves the issue ?
---
src/gallium/state_trackers/omx
From: Robert Foss
Make sure that memory allocated is free'd.
Previously only the contents of the variable
galliumvm was free'd, not the actual memory
it points to.
Coverity: 1358907
Signed-off-by: Robert Foss
---
src/gallium/drivers/swr/swr_shader.cpp | 1 +
1 file changed, 1
From: Robert Foss
The return variable was not set for failure paths.
It has now been changed to VK_ERROR_INITIALIZATION_FAILED
for failure paths.
Coverity: 1358944
Signed-off-by: Robert Foss
---
src/intel/vulkan/anv_wsi_wayland.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions
From: Robert Foss
The return variable was not set for failure paths.
It has now been changed to VK_ERROR_INITIALIZATION_FAILED
for failure paths.
Coverity: 1358944
Signed-off-by: Robert Foss
---
Changes since v1:
- Started using vk_error().
src/intel/vulkan/anv_wsi_wayland.c | 8 ++--
1
From: Robert Foss
The return variable was not set for failure paths.
It has now been changed to VK_ERROR_INITIALIZATION_FAILED
for failure paths.
Coverity: 1358944
Reviewed-by: Eric Engestrom
Signed-off-by: Robert Foss
---
Changes since v1:
- Started using vk_error().
Changes since v2
g into it.
Rob.
On May 3, 2016, at 5:45 PM, robert.f...@collabora.com wrote:
From: Robert Foss
Make sure that memory allocated is free'd.
Previously only the contents of the variable
galliumvm was free'd, not the actual memory
it points to.
Coverity: 1358907
Signed-off-by: Robe
Hey,
I've started looking into removing the gralloc method
GRALLOC_MODULE_PERFORM_GET_DRM_FD.
The issues around this seems to be two parts:
1) Finding the right device to open
2) Sharing the device between components
Finding the right device to open
Using a
Hey Tomasz,
On 03/22/2018 09:27 AM, Tomasz Figa wrote:
Hi Stefan,
On Thu, Mar 22, 2018 at 8:42 AM, Stefan Schake wrote:
Hey Robert,
On Wed, Mar 21, 2018 at 4:16 PM, Robert Foss wrote:
Hey,
I've started looking into removing the gralloc method
GRALLOC_MODULE_PERFORM_GET_DRM_FD.
Hey Chih-Wei,
On 03/23/2018 03:43 AM, Chih-Wei Huang wrote:
2018-03-22 16:23 GMT+08:00 Tomasz Figa :
Hi Chih-Wei,
On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote:
2018-02-21 3:03 GMT+08:00 Rob Herring :
Perhaps worth revisiting. Given we've failed to progress at all since
then may ch
Hey,
On 03/23/2018 06:21 PM, Emil Velikov wrote:
On 23 March 2018 at 16:20, Tomasz Figa wrote:
On Sat, Mar 24, 2018 at 12:55 AM, Emil Velikov wrote:
On 23 March 2018 at 13:15, Tomasz Figa wrote:
Perhaps we could try to use drmOpenWithType() [2]. We could have one
property that would be p
201 - 266 of 266 matches
Mail list logo
