Re: [Mesa-dev] [PATCH] ac: fix WAITCNT flags for GFX9

2018-08-22 Thread Samuel Pitoiset
Thanks! Reviewed-by: Samuel Pitoiset On 8/22/18 3:19 AM, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_llvm_build.h| 6 ++ src/amd/common/ac_nir_to_llvm.c | 4 src/gallium/drivers/radeonsi/si_shader_internal.h | 5 - 3 file

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush

2018-08-22 Thread Tomasz Figa
Hi Michel, On Thu, Aug 16, 2018 at 6:43 PM Michel Dänzer wrote: > > On 2018-08-16 11:34 AM, Tomasz Figa wrote: > > If there is no last fence, due to no rendering happening yet, just > > create a new signaled fence and return it, to match the expectations of > > the EGL sync fence API. > > > > Fix

[Mesa-dev] [Bug 107610] Dolphin emulator mis-renders shadow overlay in Super Mario Sunshine

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107610 --- Comment #7 from Samuel Pitoiset --- Thanks for trace, apparently the issue can't be reproduced with mesa 18.1.6 so it's likely a regression. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact f

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-22 Thread Alejandro Piñeiro
On 21/08/18 11:42, Vadym Shovkoplias wrote: > Hi Timothy, Alejandro, > > Thanks for the review comments!  > I'd just like to mention that the same approach is already used > in link_varyings.cpp file in > function cross_validate_outputs_to_inputs(). Here is a code snippet:  > > if (*input->data

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-22 Thread Vadym Shovkoplias
I agree that this comment is obsolete now. I'll update the patch, thanks! On Wed, Aug 22, 2018 at 12:09 PM, Alejandro Piñeiro wrote: > On 21/08/18 11:42, Vadym Shovkoplias wrote: > > Hi Timothy, Alejandro, > > Thanks for the review comments! > I'd just like to mention that the same approach is a

[Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-22 Thread vadym.shovkoplias
From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: "Only the input variables that are actually read need to be written by the previous stage; it is allowed to have superfluous declarations of input variables." Fixes: * interstage-multiple-shader-objects.shader_test v2: Remove

[Mesa-dev] [PATCH] radv: remove dead variables after splitting per member structs

2018-08-22 Thread Samuel Pitoiset
Otherwise, nir_lower_clip_cull_distance_arrays might report wrong number of output clips/culls because it relies on shader output variables and some of them might be dead. This fixes a rendering issue with Dolphin and Super Mario Sunshine. Fixes: b0c643d8f5 ("spirv: Use NIR per-member splitting")

[Mesa-dev] [Bug 107610] Dolphin emulator mis-renders shadow overlay in Super Mario Sunshine

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107610 --- Comment #8 from Samuel Pitoiset --- https://patchwork.freedesktop.org/series/48549/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

[Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Vetter
I picked up a bunch of the pieces from wayland's version: https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md The weston one is fairly similar. Then I rather massively trimmed it down since in reality libdrm is a bit a dumping ground with very few real rules. The commit rig

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Stone
On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote: > +See the gitlab project owners for contact details of the libdrm maintainers. Think this should be 'See MAINTAINERS' ... ? The rest looks good to me, though I would encourage linking to Patchwork so people can find patches from others, as well

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 12:55 PM, Daniel Stone wrote: > On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote: >> +See the gitlab project owners for contact details of the libdrm maintainers. > > Think this should be 'See MAINTAINERS' ... ? Hm right. Originally it was, but then I got a bit confused

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Eric Engestrom
On Wednesday, 2018-08-22 12:51:39 +0200, Daniel Vetter wrote: > I picked up a bunch of the pieces from wayland's version: > > https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md > > The weston one is fairly similar. Then I rather massively trimmed it > down since in reality

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 1:07 PM, Daniel Vetter wrote: > On Wed, Aug 22, 2018 at 12:55 PM, Daniel Stone wrote: >> On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote: >>> +See the gitlab project owners for contact details of the libdrm >>> maintainers. >> >> Think this should be 'See MAINTAINERS'

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 1:08 PM, Eric Engestrom wrote: > On Wednesday, 2018-08-22 12:51:39 +0200, Daniel Vetter wrote: >> I picked up a bunch of the pieces from wayland's version: >> >> https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md >> >> The weston one is fairly simila

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Eric Engestrom
On Wednesday, 2018-08-22 13:10:42 +0200, Daniel Vetter wrote: > On Wed, Aug 22, 2018 at 1:08 PM, Eric Engestrom > wrote: > > On Wednesday, 2018-08-22 12:51:39 +0200, Daniel Vetter wrote: > >> I picked up a bunch of the pieces from wayland's version: > >> > >> https://gitlab.freedesktop.org/wayland

[Mesa-dev] [Bug 101247] Mesa fails to link GLSL programs with unused output blocks

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101247 --- Comment #2 from vadym --- Patch: https://patchwork.freedesktop.org/patch/245518/ -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] [PATCH v4] anv: add VK_EXT_sampler_filter_minmax support

2018-08-22 Thread Lionel Landwerlin
And pushed. Thanks! On 21/08/2018 04:43, He, Yunchao wrote: Thanks for your review, Lionel. With the help from Clayton Craft to run the CI, this patch can pass CI: http://otc-mesa-ci.jf.intel.com/job/Richard_Yunchao/1/ Regards Yunchao -Original Message- From: Landwerlin, Lionel G Sen

[Mesa-dev] [Bug 107610] Dolphin emulator mis-renders shadow overlay in Super Mario Sunshine

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107610 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] meson: Run the install script with Python 3

2018-08-22 Thread Mathieu Bridon
The script was being run directly as an executable, and it has a Python 2 shebang. --- src/gallium/targets/dri/meson.build | 1 + src/gallium/targets/va/meson.build| 1 + src/gallium/targets/vdpau/meson.build | 1 + src/gallium/targets/xvmc/meson.build | 1 + src/mesa/drivers/dri/meson.buil

Re: [Mesa-dev] [PATCH] i965: enable EXT_render_snorm

2018-08-22 Thread Andres Gomez
Tapani, this is causing some new regressions in OpenGLES CTS: https://bugs.freedesktop.org/show_bug.cgi?id=107658 On Thu, 2018-08-02 at 14:14 +0300, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/mesa/drivers/dri/i965/intel_extensions.c | 1 + > 1 file changed, 1 insertion(+) >

[Mesa-dev] [Bug 106980] Basemark GPU vulkan benchmark fails.

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106980 --- Comment #6 from Samuel Pitoiset --- The following patch fixes a crash on GFX8: https://patchwork.freedesktop.org/series/48560/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [PATCH] ac/nir: fix getting GLSL type of array of samplers for TG4

2018-08-22 Thread Samuel Pitoiset
This fixes a crash in build_tex_intrinsic() when trying to launch the Basemark GPU benchmark on GFX8. It looks like there is still something wrong because some frames are black. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106980 CC: 18.2 Signed-off-by: Samuel Pitoiset --- src/amd/com

[Mesa-dev] [PATCH] glsl: Do not propagate 'precise' and 'invariant' on read-only variables

2018-08-22 Thread Danylo Piliaiev
Read-only variables could be considered inherently invariant and precise since no expression in shader affects them. Explicitly marking them as such is unnecessary and can cause issues, e.g. uniform marked as invariant may require the same uniform in other stage to be invariant too but uniforms can

Re: [Mesa-dev] [PATCH] i965: enable EXT_render_snorm

2018-08-22 Thread Tapani Pälli
On 22.08.2018 15:20, Andres Gomez wrote: Tapani, this is causing some new regressions in OpenGLES CTS: https://bugs.freedesktop.org/show_bug.cgi?id=107658 OK will check, I did not realize CTS had some more tests on this than dEQP. On Thu, 2018-08-02 at 14:14 +0300, Tapani Pälli wrote: Sig

[Mesa-dev] [Bug 106980] Basemark GPU vulkan benchmark fails.

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106980 --- Comment #7 from Samuel Pitoiset --- The crash on GFX8 should be fixed with https://cgit.freedesktop.org/mesa/mesa/commit/?id=4c43ec461de4f122d5d6566361d064c816e4ef69 Next step is to test with GFX9. -- You are receiving this mail because:

[Mesa-dev] [Bug 106980] Basemark GPU vulkan benchmark hangs on GFX9

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106980 Samuel Pitoiset changed: What|Removed |Added Summary|Basemark GPU vulkan |Basemark GPU vulkan

Re: [Mesa-dev] [PATCH 2/8] anv: add from/to helpers with android and vulkan formats

2018-08-22 Thread Jason Ekstrand
On Tue, Aug 21, 2018 at 3:27 AM Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/intel/vulkan/vk_format_info.h | 43 > +++ > 1 file changed, 43 insertions(+) > > diff --git a/src/intel/vulkan/vk_format_info.h > b/src/intel/vulkan/vk_format_info.h

Re: [Mesa-dev] [PATCH] meson: Run the install script with Python 3

2018-08-22 Thread Emil Velikov
On 22 August 2018 at 13:09, Mathieu Bridon wrote: > The script was being run directly as an executable, and it has a > Python 2 shebang. Please drop the execute bit and shebang - be that with this or a separate patch. As-is the patch is: Reviewed-by: Emil Velikov -Emil _

Re: [Mesa-dev] [PATCH 3/8] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

2018-08-22 Thread Jason Ekstrand
On Tue, Aug 21, 2018 at 3:27 AM Tapani Pälli wrote: > When adding YUV support, we need to figure out implementation-defined > external format identifier. > > Signed-off-by: Tapani Pälli > --- > src/intel/vulkan/anv_android.c | 99 > ++ > 1 file changed, 9

Re: [Mesa-dev] [PATCH 5/8] anv/android: support import/export of AHardwareBuffer objects

2018-08-22 Thread Jason Ekstrand
On Tue, Aug 21, 2018 at 3:27 AM Tapani Pälli wrote: > v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB) > v3: properly handle usage bits when creating from image > > Signed-off-by: Tapani Pälli > --- > src/intel/vulkan/anv_android.c | 149 >

Re: [Mesa-dev] [PATCH 6/8] anv/android: add ahardwarebuffer external memory properties

2018-08-22 Thread Jason Ekstrand
On Wed, Aug 22, 2018 at 12:54 AM Tapani Pälli wrote: > > > On 21.08.2018 11:27, Tapani Pälli wrote: > > v2: have separate memory properties for android, set usage > > flags for buffers correctly > > > > Signed-off-by: Tapani Pälli > > --- > > src/intel/vulkan/anv_formats.c | 71 >

Re: [Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-22 Thread Mathieu Bridon
I just learned I was supposed to send this :) Reviewed-by: Mathieu Bridon On Fri, 2018-08-17 at 11:07 -0700, Dylan Baker wrote: > v2: - explicitly decode the output of subprocesses > - handle bytes and string types consistently rather than relying > on > python 2's coercion for bytes a

Re: [Mesa-dev] [PATCH v3 2/2] meson: Use python3 to run glsl tests

2018-08-22 Thread Mathieu Bridon
Reviewed-by: Mathieu Bridon On Fri, 2018-08-17 at 11:07 -0700, Dylan Baker wrote: > --- > src/compiler/glsl/tests/meson.build | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/src/compiler/glsl/tests/meson.build > b/src/compiler/glsl/tests/meson.build > index

[Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc4

2018-08-22 Thread Andres Gomez
Hello list, The forth release candidate for the Mesa 18.2.0 is now available. As per the issue tracker [1] we still have a number of outstanding bugs blocking the release. [1] https://bugs.freedesktop.org/show_bug.cgi?id=107457 Currently we have: - 18 queued - 3 nominated (outstanding) - and

[Mesa-dev] [Bug 107654] Account request Kevin Rogovin

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107654 Brian Paul changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes

Re: [Mesa-dev] [PATCH] meson: Run the install script with Python 3

2018-08-22 Thread Mathieu Bridon
On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote: > On 22 August 2018 at 13:09, Mathieu Bridon > wrote: > > The script was being run directly as an executable, and it has a > > Python 2 shebang. > > Please drop the execute bit and shebang - be that with this or a > separate patch. That woul

Re: [Mesa-dev] [PATCH 7/8] anv/android: support creating images from external format

2018-08-22 Thread Jason Ekstrand
On Tue, Aug 21, 2018 at 3:28 AM Tapani Pälli wrote: > Since we don't know the exact format at creation time, some initialization > is done only when bound with memory in vkBindImageMemory. > > v2: demand dedicated allocation in vkGetImageMemoryRequirements2 if > image has external format > >

Re: [Mesa-dev] [PATCH] meson: Run the install script with Python 3

2018-08-22 Thread Eric Engestrom
On Wednesday, 2018-08-22 16:42:26 +0200, Mathieu Bridon wrote: > On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote: > > On 22 August 2018 at 13:09, Mathieu Bridon > > wrote: > > > The script was being run directly as an executable, and it has a > > > Python 2 shebang. > > > > Please drop the

Re: [Mesa-dev] [PATCH] travis: SWR requires LLVM 6.0

2018-08-22 Thread Emil Velikov
On 21 August 2018 at 11:35, Juan A. Suarez Romero wrote: > Cc: Dylan Baker > Cc: Eric Engestrom > --- With the Fixes tag (thank Eric) and trivial clarification on the question below: Reviewed-by: Emil Velikov > .travis.yml | 24 ++-- > 1 file changed, 10 insertions(+), 14

Re: [Mesa-dev] [PATCH] meson: Run the install script with Python 3

2018-08-22 Thread Emil Velikov
On 22 August 2018 at 15:42, Mathieu Bridon wrote: > On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote: >> On 22 August 2018 at 13:09, Mathieu Bridon >> wrote: >> > The script was being run directly as an executable, and it has a >> > Python 2 shebang. >> >> Please drop the execute bit and she

Re: [Mesa-dev] [PATCH 05/12] amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled

2018-08-22 Thread Kai Wasserbäch
Hey Marek, Marek Olšák wrote on 8/22/18 3:13 AM: > Get you send me a "git fetch" line that I can use to download your patches? sure. I rebased them on top of the current master and pushed the five patches to a new branch fix-warnings2-addrlibv2 on the FDO GitLab. Find the pull request for that bel

Re: [Mesa-dev] [PATCH v2 05/11] nir: Add a structure splitting pass

2018-08-22 Thread Jason Ekstrand
On Mon, Aug 20, 2018 at 6:41 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > On Sat, Jul 28, 2018 at 10:44:36PM -0700, Jason Ekstrand wrote: > > This pass doesn't really do much now because nir_lower_vars_to_ssa can > > already see through structures and considers them to be

Re: [Mesa-dev] [PATCH 05/12] amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled

2018-08-22 Thread Kai Wasserbäch
Kai Wasserbäch wrote on 8/22/18 5:19 PM: > Hey Marek, > Marek Olšák wrote on 8/22/18 3:13 AM: >> Get you send me a "git fetch" line that I can use to download your patches? > > sure. I rebased them on top of the current master and pushed the five patches > to > a new branch fix-warnings2-addrlibv

Re: [Mesa-dev] [PATCH] meson: Run the install script with Python 3

2018-08-22 Thread Eric Engestrom
On Wednesday, 2018-08-22 16:18:20 +0100, Emil Velikov wrote: > On 22 August 2018 at 15:42, Mathieu Bridon wrote: > > On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote: > >> On 22 August 2018 at 13:09, Mathieu Bridon > >> wrote: > >> > The script was being run directly as an executable, and it

Re: [Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-22 Thread Dylan Baker
Thanks! I was going to push these today if someone didn't give me an r-b, but I wanted to give people proper time. Dylan Quoting Mathieu Bridon (2018-08-22 07:35:39) > I just learned I was supposed to send this :) > > Reviewed-by: Mathieu Bridon > > On Fri, 2018-08-17 at 11:07 -0700, Dylan Bak

Re: [Mesa-dev] [PATCH] glsl: Do not propagate 'precise' and 'invariant' on read-only variables

2018-08-22 Thread Jason Ekstrand
I think this would be correct to do and would fix the bug at hand but there may be other bugs lurking deeper. In particular, if you have multiple shaders for the same stage that share some global variables and get linked together, I think you could run into the same issue only with a read-write gl

Re: [Mesa-dev] [PATCH v2 07/11] intel/nir: Use the new structure and array splitting passes

2018-08-22 Thread Jason Ekstrand
On Mon, Aug 20, 2018 at 7:57 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > On Sat, Jul 28, 2018 at 10:44:38PM -0700, Jason Ekstrand wrote: > > Shader-db results on Kaby Lake: > > > > total instructions in shared programs: 15177605 -> 15177605 (0.00%) > > instruction

Re: [Mesa-dev] [PATCH v2 08/11] nir: Add a array-of-vector variable shrinking pass

2018-08-22 Thread Jason Ekstrand
On Tue, Aug 21, 2018 at 8:09 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > On Tue, Aug 21, 2018 at 06:15:20PM -0500, Jason Ekstrand wrote: > > On Tue, Aug 21, 2018 at 5:55 PM Caio Marcelo de Oliveira Filho < > > caio.olive...@intel.com> wrote: > > > > > Hi, > > > > > > On S

[Mesa-dev] mesa 18.1.7 Notice

2018-08-22 Thread Dylan Baker
Hi everyone, Just a friendly reminder that the plan is to have the mesa 18.1.7 release this Friday (the 24th) at or around 10am PDT. The patches currently in the staging/18.1 branch represent what will be in the release, barring any critical nominations between then and now. Dylan signature.asc

Re: [Mesa-dev] [PATCH 6/5] egl/android: continue to next device if dri2_create_screen fails

2018-08-22 Thread Emil Velikov
Hi Tomasz, On 21 August 2018 at 14:54, Tomasz Figa wrote: > Hi Emil, > > On Tue, Aug 14, 2018 at 2:05 AM Emil Velikov wrote: >> >> From: Emil Velikov >> >> Unlike the other platforms, here we aim do guess if the device that we >> somewhat arbitrarily picked, is supported or not. >> >> It seems

Re: [Mesa-dev] [PATCH v2 07/11] intel: tools: aub_mem: reuse already mapped ppgtt buffers

2018-08-22 Thread Rafael Antognolli
On Wed, Aug 08, 2018 at 11:11:11PM +0100, Lionel Landwerlin wrote: > On 08/08/18 20:07, Rafael Antognolli wrote: > > On Tue, Aug 07, 2018 at 06:35:18PM +0100, Lionel Landwerlin wrote: > > > When we map a PPGTT buffer into a continous address space of aubinator > > > to be able to inspect it, we cur

Re: [Mesa-dev] [PATCH v2 10/11] nir: Add an array copy optimization

2018-08-22 Thread Jason Ekstrand
On Tue, Aug 21, 2018 at 7:49 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > On Sat, Jul 28, 2018 at 10:44:41PM -0700, Jason Ekstrand wrote: > > This peephole optimization looks for a series of load/store_deref or > > copy_deref instructions that copy an array from one variab

Re: [Mesa-dev] [PATCH] meson: Run the install script with Python 3

2018-08-22 Thread Mathieu Bridon
On Wed, 2018-08-22 at 16:18 +0100, Emil Velikov wrote: > On 22 August 2018 at 15:42, Mathieu Bridon > wrote: > > On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote: > > > On 22 August 2018 at 13:09, Mathieu Bridon > > > wrote: > > > > The script was being run directly as an executable, and it

Re: [Mesa-dev] ANDROID: eglCreateImageKHR missing modifiers

2018-08-22 Thread Emil Velikov
Hi all, Pardon for dropping in so late. I've seems to have missed this. On 24 July 2018 at 14:24, Martin Fuzzey wrote: > Hi Thomasz, > > thanks for your reply > > On 21/07/18 04:27, Tomasz Figa wrote: >> >> >> As you noticed, this adds back the dependency on gralloc handle >> structure. Moreover

[Mesa-dev] [PATCH] python: Remove shebang and executable bit

2018-08-22 Thread Mathieu Bridon
Since the script is never executed directly, but launched by Meson as an argument to the Python interpreter, those are not needed any more. In addition, they are the reason this script was missed when I moved the Meson buildsystem to Python 3, so removing them helps avoiding future confusion. ---

[Mesa-dev] [PATCH v4 12/49] meson: don't build glx or dri by default on windows

2018-08-22 Thread Dylan Baker
Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 1af610573d5..5102ffe0c7c 100644 --- a/meson.build +++ b/meson.build @@ -264,8 +264,12 @@ if with_glx == 'auto' elif w

[Mesa-dev] [PATCH v4 08/49] glsl: fix general_ir_test with mingw

2018-08-22 Thread Dylan Baker
Somewhere down in the depths of the mingw headers 'interface' is defined, change it to iface like a similar patch did. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/compiler/glsl/tests/general_ir_test.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff -

[Mesa-dev] [PATCH v4 22/49] meson: fix gallium-osmesa to build for windows

2018-08-22 Thread Dylan Baker
v2: - set so_version to '' (only affects windows) - always set lib prefix to 'lib', even on msvc --- src/gallium/state_trackers/osmesa/meson.build | 12 ++-- src/gallium/targets/osmesa/meson.build| 11 ++- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/

[Mesa-dev] [PATCH v4 44/49] meson: maintain names of shared API libraries

2018-08-22 Thread Dylan Baker
Mesa uses the lib prefix, and doesn't use a version for it's dynamic libraries, which meson defaults to. v2: - this patch --- src/mapi/es1api/meson.build | 2 ++ src/mapi/es2api/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 ++ 3 files changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH v4 01/49] move u_math to src/util

2018-08-22 Thread Dylan Baker
Currently we have two sets of functions for bit counts, one in gallium and one in core mesa. The ones in core mesa are header only in many cases, since they reduce to "#define _mesa_bitcount popcount", but they provide a fallback implementation. This is important because 32bit msvc doesn't have pop

[Mesa-dev] [PATCH v4 48/49] appveyor: Add a wrap for llvm

2018-08-22 Thread Dylan Baker
The appveyor build has a copy of llvm 5.0.1 that scons uses, meson can also use this to build llvm pipe (though not swr, which requires 6.0.0) as well. This requires a plain buildtype, since we need to compile single threaded to link with the provided LLVM, as well as a 32 bit build for the same r

[Mesa-dev] [PATCH v4 21/49] meson: build graw-gdi target

2018-08-22 Thread Dylan Baker
--- src/gallium/meson.build | 4 ++- src/gallium/targets/graw-gdi/meson.build | 36 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 src/gallium/targets/graw-gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.bui

[Mesa-dev] [PATCH v4 09/49] meson: fix dl detection on non cygwin windows

2018-08-22 Thread Dylan Baker
v4: - Don't run checks on Windows that will always fail Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt (v3) Reviewed-by: Eric Engestrom --- meson.build | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 9298c5ecce6..a5cb5b

[Mesa-dev] [PATCH v4 32/49] meson: add switches for SWR with MSVC

2018-08-22 Thread Dylan Baker
--- src/gallium/drivers/swr/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index b95c8bc1bf8..ec4d80e4bb2 100644 --- a/src/gallium/drivers/swr/meson.build +++ b/src/gallium/drivers/swr/mes

[Mesa-dev] [PATCH v4 14/49] meson: add windows compiler checks and libraries

2018-08-22 Thread Dylan Baker
v4: - Fix typo in warning code (4246 -> 4267) - Copy comments from scons for what MSVC warnings codes do - Merge linker argument changes into this commit --- meson.build | 155 +++- 1 file changed, 106 insertions(+), 49 deletions(-) diff --g

[Mesa-dev] [PATCH v4 30/49] meson: for incluse of inttypes.h for glcpp with msvc

2018-08-22 Thread Dylan Baker
Because we provide a copy if MSVC doesn't, and we need it to make flex do what we want. --- src/compiler/glsl/glcpp/meson.build | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index 76940

[Mesa-dev] [PATCH v4 06/49] meson: add a expat subproject

2018-08-22 Thread Dylan Baker
For Windows Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build| 2 +- subprojects/expat.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/expat.wrap diff --git a/meson.build b/meson.build index d75762295ac..9298

[Mesa-dev] [PATCH v4 43/49] tests/vma: fix build with MSVC

2018-08-22 Thread Dylan Baker
--- src/util/tests/vma/vma_random_test.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/util/tests/vma/vma_random_test.cpp b/src/util/tests/vma/vma_random_test.cpp index 1f194fcdf92..9246176cbf2 100644 --- a/src/util/tests/vma/vma_random_test.cpp +++ b/src/util/tests/vma/vma_ra

[Mesa-dev] [PATCH v4 18/49] meson: build gallium gdi winsys

2018-08-22 Thread Dylan Baker
Reviewed-by: Eric Anholt --- src/gallium/meson.build | 6 ++ src/gallium/winsys/sw/gdi/meson.build | 27 +++ 2 files changed, 33 insertions(+) create mode 100644 src/gallium/winsys/sw/gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/m

[Mesa-dev] [PATCH v4 11/49] meson: Add a platform for windows

2018-08-22 Thread Dylan Baker
This mirrors the haiku build which uses a platform. v2: - Fix some rebase problems Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 8 ++-- meson_options.txt | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index a5c

[Mesa-dev] [PATCH v4 05/49] meson: add a zlib subproject

2018-08-22 Thread Dylan Baker
To help windows build Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 2 +- subprojects/zlib.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/zlib.wrap diff --git a/meson.build b/meson.build index 1b3dfa221c

[Mesa-dev] [PATCH v4 07/49] glapi: export glapi_destroy_multithread when building shared-glapi on windows

2018-08-22 Thread Dylan Baker
Which will allow meson to build a shared glapi build with mingw. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/mapi/glapi/glapi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/glapi.h b/src/mapi/glapi/glapi.h index d5d4e0a03a6..cbdef2e4c5a 1006

[Mesa-dev] [PATCH v4 49/49] appveyor: cache pip packages

2018-08-22 Thread Dylan Baker
--- appveyor.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/appveyor.yml b/appveyor.yml index 2c45f534ec3..2cb520b9604 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -36,6 +36,7 @@ clone_depth: 100 cache: - llvm-5.0.1-msvc2015-mtd.7z - subprojects\packagecache +- '%LOCALAPPDATA%\pip\C

[Mesa-dev] [PATCH v4 00/49] Meson for Windows

2018-08-22 Thread Dylan Baker
This is the 4th iteration of my meson for windows series. It includes (hopefully) all of the review feedback I got on the v3, as well as a few new fixes and features, namely the appveyor build now uses the same LLVM as scons to build LLVMPipe (I would like to build SWR, but that requires LLVM 6.0.0

[Mesa-dev] [PATCH v4 03/49] meson: always define libglapi

2018-08-22 Thread Dylan Baker
This allows the identifier to be used even if shared-glapi isn't build, which simplifies a bunch of things. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/mapi/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/meson.build b/src/mapi/meson.build index 798586

[Mesa-dev] [PATCH v4 02/49] Replace uses of _mesa_bitcount with util_bitcount

2018-08-22 Thread Dylan Baker
and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem in nir for platforms that don't have popcount or popcountll, such as 32bit msvc. v4: - add this patch --- src/compiler/glsl/ir_constant_expression.cpp | 2 +- src/compiler/glsl/ir_expression_operation.py | 2 +- src/compi

[Mesa-dev] [PATCH v4 20/49] meson: build libgl-gdi target

2018-08-22 Thread Dylan Baker
v4: - Fix check for broken mingw (should be for x86 not x86_64) - Add comment about why check is needed --- src/gallium/meson.build | 1 + src/gallium/targets/libgl-gdi/meson.build | 46 +++ 2 files changed, 47 insertions(+) create mode 100644 src/galliu

[Mesa-dev] [PATCH v4 19/49] meson: build wgl state tracker

2018-08-22 Thread Dylan Baker
v4: - Handle enable gles properly - Add comments about what various #defines do Reviewed-by: Eric Anholt --- src/gallium/meson.build| 3 ++ src/gallium/state_trackers/wgl/meson.build | 57 ++ 2 files changed, 60 insertions(+) create mode 100644 src/g

[Mesa-dev] [PATCH v4 24/49] meson: Add support for wrapping llvm

2018-08-22 Thread Dylan Baker
For building on Windows (when not using cygwin), the assumption is that LLVM will have to be handled via a binary wrap. In this case the user wanting to use LLVM is this way will need to create a directory in subprojects (any name is fine), and pass that name via the -Dllvm-wrap option (for example

[Mesa-dev] [PATCH v4 15/49] meson: Make shader-cache a trillean instead of boolean

2018-08-22 Thread Dylan Baker
So that it can be implicitly disabled on windows, where it doesn't compile. v2: - Use an auto-option rather than automagic. - fix shader_cache check (== -> !=) v4: - Use new with_shader_cache instead of get_option('shader-cache') elsewhere in the meson build --- meson.build | 18 +

[Mesa-dev] [PATCH v4 23/49] meson: Don't check for posix_memalign on windows

2018-08-22 Thread Dylan Baker
There's a mingw bug for this, it exports __builtin_posix_memalign but not posix_memalign, so the check will succeed, but compiling will fail. --- meson.build | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 0f37117e3fc..c89b805e71f

[Mesa-dev] [PATCH v4 04/49] add a git ignore for subprojects

2018-08-22 Thread Dylan Baker
Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- subprojects/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 subprojects/.gitignore diff --git a/subprojects/.gitignore b/subprojects/.gitignore new file mode 100644 index 000..68a882edba6 --- /dev/null +++ b

[Mesa-dev] [PATCH v4 25/49] util/xmlconfig: include strndup.h for windows

2018-08-22 Thread Dylan Baker
--- src/util/xmlconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/xmlconfig.c b/src/util/xmlconfig.c index 5264f2598b4..51cc5f3dd87 100644 --- a/src/util/xmlconfig.c +++ b/src/util/xmlconfig.c @@ -39,6 +39,7 @@ #include #include #include +#include "strndup.h" #include "x

[Mesa-dev] [PATCH v4 26/49] meson: fix pipe-loader compilation for windows

2018-08-22 Thread Dylan Baker
v2: - Add missing D to pound define - Simply define the variable rather than set it to 1 (mirrors android.mk not scons) --- src/gallium/auxiliary/pipe-loader/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/pipe-loader/meson.b

[Mesa-dev] [PATCH v4 16/49] meson: Add windows defines to glapi

2018-08-22 Thread Dylan Baker
These are needed to control the export or symbols due to differences between the way windows and *nix handle symbol exports. Reviewed-by: Eric Anholt --- src/mapi/es1api/meson.build | 10 +- src/mapi/es2api/meson.build | 10 +- src/mapi/glapi/meson.build| 13 +

[Mesa-dev] [PATCH v4 13/49] meson: don't allow glvnd on windows

2018-08-22 Thread Dylan Baker
Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5102ffe0c7c..32a731e2024 100644 --- a/meson.build +++ b/meson.build @@ -356,7 +356,9 @@ endif with_glvnd = get_option('glv

[Mesa-dev] [PATCH v4 39/49] meson: don't build gallium trivial tests on windows

2018-08-22 Thread Dylan Baker
They require the pipe-loaders, which require xmlconfig, which doesn't build with msvc. --- src/gallium/tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 0ee04350c87..15b9f549647 100644 --- a

[Mesa-dev] [PATCH v4 34/49] meson: Add idep_getopt for tests

2018-08-22 Thread Dylan Baker
There are quite a few tests that require getopt, when using MSVC we need to use the bundled version of getopt since there isn't a system version. --- src/compiler/glsl/glcpp/meson.build | 2 +- src/compiler/glsl/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff -

[Mesa-dev] [PATCH v4 41/49] meson: disable graw tests on mingw

2018-08-22 Thread Dylan Baker
I can't figure out why symbols are being exposed that shouldn't. --- src/gallium/tests/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 15b9f549647..1d08da2ac10 100644 --- a/src/gallium/tests/me

[Mesa-dev] [PATCH v4 10/49] meson: build getopt when using msvc

2018-08-22 Thread Dylan Baker
v4: - Don't wrap a single file in a list to match mesa style - Use null_dep instead of empty list Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt (v3) Reviewed-by: Eric Engestrom --- src/getopt/meson.build | 29 + src/meson.build| 5 + 2 files c

[Mesa-dev] [PATCH v4 45/49] appveyor: Add support for meson as well as scons

2018-08-22 Thread Dylan Baker
v4: - Rebase on python3 generators - Cache meson wraps - Build x86 instead of x86_64, since that's what the pre-build LLVM is --- appveyor.yml | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index

[Mesa-dev] [PATCH v4 40/49] meson: Fix gtest linkage on msvc

2018-08-22 Thread Dylan Baker
We need to add an extra flag (/SUBSYSTEM:CONSOLE) to get the msvc linker to find main() in a static library. --- src/gtest/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gtest/meson.build b/src/gtest/meson.build index 91a49240416..ed0d6974bd3 100644 --- a/src/gtest/meso

[Mesa-dev] [PATCH v4 37/49] glsl/tests: define ssize_t on windows

2018-08-22 Thread Dylan Baker
--- src/compiler/glsl/tests/blob_test.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/tests/blob_test.c b/src/compiler/glsl/tests/blob_test.c index 1cc97236e7e..21b8b1efdc1 100644 --- a/src/compiler/glsl/tests/blob_test.c +++ b/src/compiler/glsl/tests/blob_test.c @@ -2

[Mesa-dev] [PATCH v4 46/49] appveyor: use chocolatey (cinst) to install winflexbison

2018-08-22 Thread Dylan Baker
v2: - fix typos in commit message --- appveyor.yml | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 15a31da9411..b26a3c624e8 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -34,7 +34,6 @@ branches: clone_depth: 100 cache: -- win_flex_bi

[Mesa-dev] [PATCH v4 35/49] util/tests: Use define instead of VLA

2018-08-22 Thread Dylan Baker
To allow the this test to be built with MSVC, which doesn't support VLAs. --- src/util/tests/hash_table/clear.c | 13 +++-- src/util/tests/hash_table/delete_management.c | 13 +++-- src/util/tests/hash_table/insert_many.c | 11 ++- src/util/tests/hash_tabl

[Mesa-dev] [PATCH v4 28/49] meson: Add support for using win_flex and win_bison on windows

2018-08-22 Thread Dylan Baker
--- meson.build | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 9de29b832a0..c5baaf60c68 100644 --- a/meson.build +++ b/meson.build @@ -1364,8 +1364,31 @@ endif # pthread stubs. Lets not and say we didn't -prog_b

[Mesa-dev] [PATCH v4 29/49] meson: make nm binary optional

2018-08-22 Thread Dylan Baker
This makes nm not required, but used if found. In general I imagine that this means that on windows nm wont be found, and on other platforms it will. v2: - fix gbm and egl symbols check tests to only be run if nm is found - reword commit message to reflect the code change --- meson.build

[Mesa-dev] [PATCH v4 47/49] appveyor: use msbuild instead of ninja

2018-08-22 Thread Dylan Baker
I think that most windows users probably find using msbuild more interesting than ninja, even if ninja is faster. I've left the ninja build in case someone wants to look at it. - v4: Add /m switch to make build somewhat faster --- appveyor.yml | 8 1 file changed, 4 insertions(+), 4 dele

[Mesa-dev] [PATCH v4 36/49] meson: Don't build glsl cache_test for windows

2018-08-22 Thread Dylan Baker
v2: - Use new with_shader_cache variable instead of host_machine.system() == 'windows' --- src/compiler/glsl/tests/meson.build | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.buil

[Mesa-dev] [PATCH v4 31/49] meson: disable sse4.1 optimizations with msvc

2018-08-22 Thread Dylan Baker
There isn't an obvious command line switch here, /arch:AVX *might* be the right thing, but meson doesn't know what to do here either and leaves the -msse4.1 and -mstackrealign. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 05a03

  1   2   >