On Wednesday, 2018-08-22 16:18:20 +0100, Emil Velikov wrote: > On 22 August 2018 at 15:42, Mathieu Bridon <boche...@daitauha.fr> wrote: > > On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote: > >> On 22 August 2018 at 13:09, Mathieu Bridon <boche...@daitauha.fr> > >> wrote: > >> > The script was being run directly as an executable, and it has a > >> > Python 2 shebang. > >> > >> Please drop the execute bit and shebang - be that with this or a > >> separate patch. > > > > That would require modifying the other build systems as well, so it's > > probably better to wait for your AM_PATH_PYTHON patches to be merged. > > > Not quite - the script is used solely by meson, and the AM_PATH_PYTHON > stuff is for autoconf ;-)
Huh, I could've sworn autotools moved to that python script as well, but you're right; it's still doing its own thing in src/mesa/drivers/dri/Makefile.am Mathieu, my r-b still applies, but I agree that the executable bit and shebang should be removed; can be a follow up, but it would really belong in this patch :) > > -Emil > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
