[Mesa-dev] [Bug 105807] [Regression, bisected]: 3D Rendering not working correctly in Warhammer 40k: Dawn of War II

https://bugs.freedesktop.org/show_bug.cgi?id=105807 Timothy Arceri changed: What|Removed |Added Component|Mesa core |Drivers/DRI/i965 QA Contact|me

[Mesa-dev] [PATCH] ac/nir: Use an array instead of hashtable for SSA defs.

Saves about 2% of compile time for F1 2017, as well as reduce code size of an optimized libvulkan_radeon.so by about 1 KiB. This still keeps the hashtable, as we also stored blocks in there. --- src/amd/common/ac_nir_to_llvm.c | 22 +- 1 file changed, 13 insertions(+), 9 delet

[Mesa-dev] [PATCH] egl/x11: Handle both depth 30 formats for eglCreateImage(). (v2)

We need to distinguish if the backing storage of a pixmap is XRGB2101010 or XBGR2101010, as different gpu hw supports different formats. NVidia hw prefers XBGR, whereas AMD and Intel are happy with XRGB. Use the red channel mask of the first depth 30 visual of the x-screen to distinguish which hw

[Mesa-dev] [PATCH v2] dri3: Prevent multiple freeing of buffers.

Commit 3160cb86aa92 adds optimization with flag 'reallocate'. Processing of flag causes buffers freeing while pointer is still hold in caller stack and than again used to be freed. Fixes: 3160cb86aa92 "egl/x11: Re-allocate buffers if format is suboptimal" v2: used flag 'busy' instead of introduc

Re: [Mesa-dev] [PATCH] ac/nir: Use an array instead of hashtable for SSA defs.

Reviewed-by: Samuel Pitoiset On 04/10/2018 09:33 AM, Bas Nieuwenhuizen wrote: Saves about 2% of compile time for F1 2017, as well as reduce code size of an optimized libvulkan_radeon.so by about 1 KiB. This still keeps the hashtable, as we also stored blocks in there. --- src/amd/common/ac_n

[Mesa-dev] [Bug 105942] Graphical artefacts after update to mesa 18.0.0-2

https://bugs.freedesktop.org/show_bug.cgi?id=105942 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

On 2018-04-10 08:38 AM, Gert Wollny wrote: > Am Montag, den 09.04.2018, 17:26 -0400 schrieb Marek Olšák: >> On Mon, Apr 9, 2018 at 5:19 PM, Gert Wollny >> wrote: >>> >>> There is another option: Check at configuration time whether the >>> bit field layout is like the low or the high endian layout

Re: [Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

On Mon, Apr 9, 2018 at 11:19 PM, Gert Wollny wrote: > Am Montag, den 09.04.2018, 14:03 -0400 schrieb Marek Olšák: > > On Mon, Apr 9, 2018 at 10:51 AM, Bas Vermeulen > > wrote: > Which solution is better depends on what is done more often: reading > the index or writing to the bit fields. > The

Re: [Mesa-dev] [PATCH] docs/release-calendar: update to include 18.1 and 18.2

On Mon, 2018-04-09 at 19:02 +0100, Emil Velikov wrote: > From: Emil Velikov > > Dylan has kindly stepped up to help with 18.1.0, while I've taken the > liberty to nominate Andres for 18.2.0 ;-) > I would like to replace Andres for the 18.0.x releases. We already talked about that and both think

Re: [Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

On 2018-04-10 10:03 AM, Bas Vermeulen wrote: > On Mon, Apr 9, 2018 at 11:19 PM, Gert Wollny wrote: >> Am Montag, den 09.04.2018, 14:03 -0400 schrieb Marek Olšák: >>> On Mon, Apr 9, 2018 at 10:51 AM, Bas Vermeulen > >> There is another option: Check at configuration time whether the bit >> field

Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

Hello, i've updated patch simply, but that seems requires additional checking because in call *dri3_handle_present_event *potentially may happens reset of '*busy*' with condition '*buf->pixmap == ie->pixmap*' On Fri, Apr 6, 2018 at 9:03 PM, Thomas Hellstrom wrote: > Hi, > > > On 04/06/2018 04:51

Re: [Mesa-dev] [PATCH] ac/nir: Use an array instead of hashtable for SSA defs.

On 10/04/18 17:33, Bas Nieuwenhuizen wrote: Saves about 2% of compile time for F1 2017, as well as reduce code size of an optimized libvulkan_radeon.so by about 1 KiB. This still keeps the hashtable, as we also stored blocks in there. --- src/amd/common/ac_nir_to_llvm.c | 22 +---

Re: [Mesa-dev] [PATCH] ac/nir: Use an array instead of hashtable for SSA defs.

On 10/04/18 18:17, Timothy Arceri wrote: On 10/04/18 17:33, Bas Nieuwenhuizen wrote: Saves about 2% of compile time for F1 2017, as well as reduce code size of an optimized libvulkan_radeon.so by about 1 KiB. This still keeps the hashtable, as we also stored blocks in there. ---   src/amd/c

Re: [Mesa-dev] [PATCH 3/3] egl/x11: Handle both depth 30 formats for eglCreateImage().

On 04/09/2018 12:12 PM, Michel Dänzer wrote: On 2018-04-06 08:56 PM, Mario Kleiner wrote: On 04/06/2018 06:41 PM, Michel Dänzer wrote: On 2018-04-06 06:18 PM, Mario Kleiner wrote: On Fri, Apr 6, 2018 at 12:01 PM, Michel Dänzer wrote: On 2018-03-27 07:53 PM, Daniel Stone wrote: On 12 March 2

Re: [Mesa-dev] [PATCH v4 6/6] i965: gl_BaseVertex must be zero for non-indexed draw calls

On 07/04/18 08:21, Jason Ekstrand wrote: On Fri, Apr 6, 2018 at 2:53 PM, Ian Romanick > wrote: From: Antia Puentes mailto:apuen...@igalia.com>> We keep 'firstvertex' as it is and move gl_BaseVertex to the drawID vertex element. The previous Vertex Eleme

[Mesa-dev] [PATCH] i965: Remove brw_bo_alloc_tiled_2d from intel_detect_swizzling.

I'd like to drop this pre-isl function. This drops one of the two uses. --- src/mesa/drivers/dri/i965/intel_screen.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 29cb7

Re: [Mesa-dev] [PATCH 3/3] egl/x11: Handle both depth 30 formats for eglCreateImage().

On 2018-04-10 10:22 AM, Mario Kleiner wrote: > On 04/09/2018 12:12 PM, Michel Dänzer wrote: >> On 2018-04-06 08:56 PM, Mario Kleiner wrote: >> >> I'm interested in the full xdpyinfo *at screen depth 30*, in particular >> whether it lists only one variant of depth 30 visuals. If so, one >> possibili

Re: [Mesa-dev] [PATCH] i965: Remove brw_bo_alloc_tiled_2d from intel_detect_swizzling.

Reviewed-by: Iago Toral Quiroga On Tue, 2018-04-10 at 01:33 -0700, Kenneth Graunke wrote: > I'd like to drop this pre-isl function. This drops one of the two > uses. > --- > src/mesa/drivers/dri/i965/intel_screen.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) > > dif

[Mesa-dev] [Bug 105952] radv causes GPU hang on SI

https://bugs.freedesktop.org/show_bug.cgi?id=105952 --- Comment #9 from Turo Lamminen --- Still happens in 4381be4648b9ebb15b0a06885489998d5daac482 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

[Mesa-dev] [Bug 105952] radv causes GPU hang on SI

https://bugs.freedesktop.org/show_bug.cgi?id=105952 --- Comment #10 from Turo Lamminen --- I did a little experiment, I rebased locally and removed the broken commit (4ad7595f350462c704fbe5b2bd2ca406c904e78e) and then the followups (942fdfe357, f1d7c16e85, 04e609f1f8) because they no longer appli

Re: [Mesa-dev] [PATCH] radv: move save/restore operations close to the slow clears

Reviewed-by: Bas Nieuwenhuizen I'm wondering though, doesn't this result in more saves/restores, as we now do it for each part of a subpass clear separately? On Mon, Apr 9, 2018 at 11:10 PM, Samuel Pitoiset wrote: > This removes the emission of unnecessary states, for example > when performing

Re: [Mesa-dev] [PATCH 1/4] ac/surface: don't set the display flag for obviously unsupported cases (v2)

On 2018-04-06 07:12 PM, Marek Olšák wrote: > From: Marek Olšák > > This enables the tile swizzle for some cases of the displayable micro mode, > and it also fixes an addrlib assertion failure on Vega. [...] > diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c > index dd3189c

Re: [Mesa-dev] [PATCH v2] nv50/ir: make a copy of tex src if it's referenced multiple times

I guess this fixes a bug somewhere? On Tue, Apr 10, 2018 at 6:11 AM, Ilia Mirkin wrote: > For nv50 we coalesce the srcs and defs into a single node. As such, we > can end up with impossible constraints if the source is referenced > after the tex operation (which, due to the coalescing of values,

[Mesa-dev] [Bug 105832] radeonsi NIR missing bindless textures support

https://bugs.freedesktop.org/show_bug.cgi?id=105832 --- Comment #19 from Karol Herbst --- how can you make dow2 use bindless_textures? This kind of looks like a mesa issue and not really related to radeonsi at all (the shader compile fails) -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 105832] radeonsi NIR missing bindless textures support

https://bugs.freedesktop.org/show_bug.cgi?id=105832 --- Comment #20 from Karol Herbst --- (In reply to Karol Herbst from comment #19) > how can you make dow2 use bindless_textures? This kind of looks like a mesa > issue and not really related to radeonsi at all (the shader compile fails) ohh com

[Mesa-dev] [Bug 105832] radeonsi NIR missing bindless textures support

https://bugs.freedesktop.org/show_bug.cgi?id=105832 --- Comment #21 from Timothy Arceri --- (In reply to Karol Herbst from comment #19) > how can you make dow2 use bindless_textures? This kind of looks like a mesa > issue and not really related to radeonsi at all (the shader compile fails) DoW3

Re: [Mesa-dev] [PATCH 00/22] VP9 support

Nice work. Series is Acked-by: Christian König . Christian. Am 09.04.2018 um 18:35 schrieb Leo Liu: This series will enable VP9 support for profile0 and profile2 on VCN. It will support players with VP9 VA-API enabled. Leo Liu (22): vl: add VP9 profile0 and format vl: add VP9 picture des

[Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

Drivers that only support compat 3.0 were reporting GLSL 1.40 support. This fixes issues with the menu of Dawn of War II. Fixes: a0c8b49284ef "mesa: enable OpenGL 3.1 with ARB_compatibility" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105807 --- src/mesa/main/version.c | 8 ++-- 1

Re: [Mesa-dev] [PATCH v2] nv50/ir: make a copy of tex src if it's referenced multiple times

On Tue, Apr 10, 2018 at 6:08 AM, Karol Herbst wrote: > I guess this fixes a bug somewhere? Yeah... I describe it in the commit description, I thought. Here's the situation: %r1 = 5 %r2 = texsize %r1 %r3 = texsize %r1 Now, let's not worry about why those didn't get CSE'd. (Let's say they refer t

[Mesa-dev] [PATCH] radv: add shader BOs to the list at pipeline bind time

Otherwise, the shader BOs are not added to the list on SI because prefetching isn't supported. Calling radv_cs_add_buffer() in the prefetch codepath was a bad idea. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105952 Fixes: 4ad7595f35 ("radv: rename radv_emit_prefetch() to radv_emit_pref

Re: [Mesa-dev] [PATCH] radv: add shader BOs to the list at pipeline bind time

Reviewed-by: Bas Nieuwenhuizen On Tue, Apr 10, 2018 at 2:09 PM, Samuel Pitoiset wrote: > Otherwise, the shader BOs are not added to the list on SI because > prefetching isn't supported. Calling radv_cs_add_buffer() in the > prefetch codepath was a bad idea. > > Bugzilla: https://bugs.freedesktop

Re: [Mesa-dev] [PATCH] i965: Check result of make_surface() for miptree_create

CCing: Jason Ekstrand and Topi Pohjolainen. 2018-04-09 13:36 GMT+02:00 : > From: Andrea Azzarone > > Since make_surface() can fail we need to check the result before > dereferencing it. > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --

[Mesa-dev] [Bug 105846] Assertion failure @ st_atom_array.c:675 when playing Natural Selection 2

https://bugs.freedesktop.org/show_bug.cgi?id=105846 l...@protonmail.ch changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand wrote: > + A bunch of potentially interested parties. > > On Mon, Apr 9, 2018 at 4:25 PM, Caio Marcelo de Oliveira Filho > wrote: >> >> Hi, >> >> > typedef struct { >> > - nir_parameter_type param_type; >> > - const struct glsl_type *type; >> >

[Mesa-dev] [PATCH] radv: fix picking the method for resolve subpass

The source and destination image parameters were swapped. No CTS changes on Polaris10, but I suspect this might fix something. Fixes: 2a04f5481df ("radv/meta: select resolve paths") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_resolve.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [Mesa-dev] [PATCH] radv: move save/restore operations close to the slow clears

On 04/10/2018 11:20 AM, Bas Nieuwenhuizen wrote: Reviewed-by: Bas Nieuwenhuizen I'm wondering though, doesn't this result in more saves/restores, as we now do it for each part of a subpass clear separately? Yes, possibly. I'm actually not sure myself if it's the right thing to do. I will p

[Mesa-dev] [PATCH] glsl: properly handle bindless sampler and image parameters

fixes a piglit test I sent to the list: spec@arb_bindless_texture@execution@samplers@basic-arithmetic-func-call-uvec2-texture2D Signed-off-by: Karol Herbst --- src/compiler/glsl/opt_function_inlining.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/opt_fu

[Mesa-dev] [Bug 105807] [Regression, bisected]: 3D Rendering not working correctly in Warhammer 40k: Dawn of War II

https://bugs.freedesktop.org/show_bug.cgi?id=105807 Alan Swanson changed: What|Removed |Added Assignee|intel-3d-bugs@lists.freedes |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

What about GL 2.1 and 2.0 (and earlier where you could still have GLSL as an ext)? And does the GLSL version have to line up exactly for those? Or does this just need to be default: if (ctx->Version < 31) ctx->Const.GLSLVersion = MIN2(ctx->Const.GLSLVersion, 130) else ctx->Const.GLSLVersion =

[Mesa-dev] [PATCH v3 2/7] nir/spirv: Fix warning and add missing breaks.

--- src/compiler/spirv/spirv_to_nir.c | 2 ++ src/compiler/spirv/vtn_subgroup.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 78c1e9ff59..28274311c2 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compil

[Mesa-dev] [PATCH v3 6/7] ac: handle subgroup intrinsics

--- src/amd/common/ac_nir_to_llvm.c | 69 - 1 file changed, 40 insertions(+), 29 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 7c2bd5c0cc..3a3aa72988 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/

[Mesa-dev] [PATCH v3 4/7] ac: make ballot and umsb capable of 64bit inputs

Reviewed-by: Marek Olšák --- src/amd/common/ac_llvm_build.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 32d8a02f56..2fb8aeaac6 100644 --- a/src/amd/common/ac_llvm_buil

[Mesa-dev] [PATCH v3 0/7] radv: add support for new subgroup capabilities

Third version of the series: - rebased to master - lower_shuffle_to_32bit now only lowers shuffles and nothing else - removed constant values from quad intrinsics Previous Version can be found here https://lists.freedesktop.org/archives/mesa-dev/2018-March/189116.html Daniel Schürmann (7): nir:

[Mesa-dev] [PATCH v3 7/7] radv: enable subgroup capabilities

--- src/amd/vulkan/radv_device.c | 10 -- src/amd/vulkan/radv_shader.c | 7 ++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 4fc7392e65..e50b661cac 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/

[Mesa-dev] [PATCH v3 1/7] nir: adjust subgroups instructions for 64bit ballot sizes

--- src/compiler/nir/nir_lower_subgroups.c | 5 ++--- src/compiler/nir/nir_opcodes.py| 12 ++-- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/compiler/nir/nir_lower_subgroups.c b/src/compiler/nir/nir_lower_subgroups.c index 0d3c83b795..9dc7be7947 100644 --- a

[Mesa-dev] [PATCH v3 5/7] ac: add LLVM build functions for subgroup instrinsics

Co-authored-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 456 + src/amd/common/ac_llvm_build.h | 30 ++- 2 files changed, 485 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 2fb8aea

[Mesa-dev] [PATCH v3 3/7] nir: lower 64bit subgroup shuffle intrinsics

--- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_subgroups.c | 68 +++--- 2 files changed, 56 insertions(+), 13 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f33049d713..f3326e6df9 100644 --- a/src/compiler

[Mesa-dev] [Bug 105807] [Regression, bisected]: 3D Rendering not working correctly in Warhammer 40k: Dawn of War II

https://bugs.freedesktop.org/show_bug.cgi?id=105807 --- Comment #8 from b...@besd.de --- These are from shaderdumps (good thing I have the sha naming in place otherwise these would have been overwritten ;) When GLSL is not forced [require] GLSL >= 0.00 // this is generated by OpenGL so maybe so

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

On Tue, 2018-04-03 at 10:58 +0100, Alex Smith wrote: > I don't know exactly what's causing it, no. I noticed the issue was fixed on > master so just bisected to this. > > CC'ing stable to nominate: > 42627dabb4db3011825a022325be7ae9b51103d6 - (1/3) ac: add if/loop build > helpers > 6e1a142863b3

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: > On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand > wrote: > > + A bunch of potentially interested parties. > > > > On Mon, Apr 9, 2018 at 4:25 PM, Caio Marcelo de Oliveira Filho > > wrote: > >> > >> Hi, > >> > >> > typedef struct { > >> > -

[Mesa-dev] [PATCH v2 0/3] nir: add support for ARB_bindless_texture texture handles

With this it should be possible to add support for texture handles for backends using NIR. changes since v2: * dropped patch for image handles, still need to work on that Karol Herbst (3): nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars nir: add support for bindless_texture s

[Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

v2: fix assertion for bindless to non bindless assignments Signed-off-by: Karol Herbst --- src/compiler/nir/nir_split_var_copies.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_split_var_copies.c b/src/compiler/nir/nir_split_var_copies.c index b

[Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

If the bindless image is passed through a struct we ended up getting the glsl_type of the struct, not the image. variable_referenced points to the declaration of the struct, so it won't work for bindless images. So just drop it. Signed-off-by: Karol Herbst --- src/compiler/glsl/glsl_to_nir.cpp

[Mesa-dev] [PATCH v2 2/3] nir: add support for bindless_texture samplers

v2: add both texture and sampler handles Signed-off-by: Karol Herbst --- src/compiler/glsl/glsl_to_nir.cpp | 17 +++-- src/compiler/nir/nir.h| 2 ++ src/compiler/nir/nir_print.c | 6 ++ 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/compile

Re: [Mesa-dev] [PATCH v2 2/3] nir: add support for bindless_texture samplers

On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst wrote: > v2: add both texture and sampler handles > > Signed-off-by: Karol Herbst > --- > src/compiler/glsl/glsl_to_nir.cpp | 17 +++-- > src/compiler/nir/nir.h| 2 ++ > src/compiler/nir/nir_print.c | 6 ++ > 3 fil

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst wrote: > If the bindless image is passed through a struct we ended up getting the > glsl_type of the struct, not the image. > > variable_referenced points to the declaration of the struct, so it won't > work > for bindless images. So just drop it. > >

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

I still don't see anything to make nir_validate not fail out on you if it sees a read or a write to/from an IMAGE or SAMPLER. On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst wrote: > v2: fix assertion for bindless to non bindless assignments > > Signed-off-by: Karol Herbst > --- > src/compiler/n

Re: [Mesa-dev] [PATCH v3 1/7] nir: adjust subgroups instructions for 64bit ballot sizes

On Tue, Apr 10, 2018 at 7:37 AM, Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > --- > src/compiler/nir/nir_lower_subgroups.c | 5 ++--- > src/compiler/nir/nir_opcodes.py| 12 ++-- > 2 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/src/compiler

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: >> >> On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand >> wrote: >> > + A bunch of potentially interested parties. >> > >> > On Mon, Apr 9, 2018 at 4:25 PM, Caio Marcelo de Oliveira Filho >

Re: [Mesa-dev] [PATCH v3 2/7] nir/spirv: Fix warning and add missing breaks.

Reviewed-by: Jason Ekstrand On Tue, Apr 10, 2018 at 7:37 AM, Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 2 ++ > src/compiler/spirv/vtn_subgroup.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/src/compiler/spirv/spir

Re: [Mesa-dev] [PATCH] docs/release-calendar: update to include 18.1 and 18.2

On 10 April 2018 at 09:06, Juan A. Suarez Romero wrote: > On Mon, 2018-04-09 at 19:02 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Dylan has kindly stepped up to help with 18.1.0, while I've taken the >> liberty to nominate Andres for 18.2.0 ;-) >> > > I would like to replace Andres for

Re: [Mesa-dev] [PATCH 2/5] i965/tiled_memcpy: inline movntdqa loads in tiled_to_linear

Chris Wilson writes: > Quoting Chris Wilson (2018-04-05 20:54:54) > > Quoting Scott D Phillips (2018-04-03 21:05:42) [...] > > Ok, was hoping to see how you choose to use the streaming load, but I > > guess that's the next patch. > > > > Reviewed-by: Chris Wilson > > Oh, one point Eric Anholt

Re: [Mesa-dev] [PATCH v3 024/104] nir: Support deref instructions in lower_system_values

> I took another swing at it, and this one seems to make Jenkins happy: > > https://gitlab.freedesktop.org/jekstrand/mesa/commit/ad3cc9f301da3519d4f76767a6d9e98e5a5c118e Reviewed-by: Caio Marcelo de Oliveira Filho Thanks, Caio ___ mesa-dev mailing li

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand wrote: > I still don't see anything to make nir_validate not fail out on you if it > sees a read or a write to/from an IMAGE or SAMPLER. > what kind of glsl code are you talking about here? I wrote some tests and things just seem to work out. I wasn

Re: [Mesa-dev] [PATCH] radv: fix picking the method for resolve subpass

Reviewed-by: Bas Nieuwenhuizen On Tue, Apr 10, 2018 at 4:00 PM, Samuel Pitoiset wrote: > The source and destination image parameters were swapped. > > No CTS changes on Polaris10, but I suspect this might > fix something. > > Fixes: 2a04f5481df ("radv/meta: select resolve paths") > Signed-off-by

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On Tue, Apr 10, 2018 at 5:11 PM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst wrote: >> >> If the bindless image is passed through a struct we ended up getting the >> glsl_type of the struct, not the image. >> >> variable_referenced points to the declaration of the struct

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

On 10 April 2018 at 15:49, Juan A. Suarez Romero wrote: > On Tue, 2018-04-03 at 10:58 +0100, Alex Smith wrote: > > I don't know exactly what's causing it, no. I noticed the issue was > fixed on master so just bisected to this. > > > > CC'ing stable to nominate: > > 42627dabb4db3011825a022325be7ae

Re: [Mesa-dev] [PATCH v4 3/5] i965/miptree: Use cpu tiling/detiling when mapping

Chris Wilson writes: > Quoting Scott D Phillips (2018-04-03 21:05:43) >> Rename the (un)map_gtt functions to (un)map_map (map by >> returning a map) and add new functions (un)map_tiled_memcpy that >> return a shadow buffer populated with the intel_tiled_memcpy >> functions. >> >> Tiling/detiling

Re: [Mesa-dev] [PATCH v2 5/5] i965/miptree: Don't gtt map from map_depthstencil

Chris Wilson writes: > Quoting Scott D Phillips (2018-04-03 21:05:45) >> Instead of gtt mapping, call out to other map functions (map_map >> or map_tiled_memcpy) for the depth surface. Removes a place where >> gtt mapping is used. >> >> v2: add level, slice to debug print (Nanley) >> --- >> @@ -

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: > On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand > wrote: > > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: > >> > >> On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand > >> wrote: > >> > + A bunch of potentially interested parties. > >> > >

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

On Tue, Apr 10, 2018 at 8:35 AM, Karol Herbst wrote: > On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand > wrote: > > I still don't see anything to make nir_validate not fail out on you if it > > sees a read or a write to/from an IMAGE or SAMPLER. > > > > what kind of glsl code are you talking abo

Re: [Mesa-dev] [PATCH 2/5] i965/tiled_memcpy: inline movntdqa loads in tiled_to_linear

Quoting Scott D Phillips (2018-04-10 16:33:18) > Chris Wilson writes: > > > Quoting Chris Wilson (2018-04-05 20:54:54) > > > Quoting Scott D Phillips (2018-04-03 21:05:42) > > [...] > > > > Ok, was hoping to see how you choose to use the streaming load, but I > > > guess that's the next patch.

Re: [Mesa-dev] [PATCH v4 3/5] i965/miptree: Use cpu tiling/detiling when mapping

Quoting Scott D Phillips (2018-04-10 16:49:16) > Chris Wilson writes: > > > Quoting Scott D Phillips (2018-04-03 21:05:43) > >> Rename the (un)map_gtt functions to (un)map_map (map by > >> returning a map) and add new functions (un)map_tiled_memcpy that > >> return a shadow buffer populated with

[Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

From: Emil Velikov Virtually every driver that supports ATI_separate_stencil also supports EXT_stencil_two_side. Use the latter boolean for both extension. With that in mind we can drop the explicit true from the drivers and the nasty comment in compute_version(). Signed-off-by: Emil Velikov -

Re: [Mesa-dev] [PATCH v4 6/6] i965: gl_BaseVertex must be zero for non-indexed draw calls

On Tue, Apr 10, 2018 at 1:28 AM, Antia Puentes wrote: > On 07/04/18 08:21, Jason Ekstrand wrote: > > On Fri, Apr 6, 2018 at 2:53 PM, Ian Romanick wrote: > >> From: Antia Puentes >> >> We keep 'firstvertex' as it is and move gl_BaseVertex to the drawID >> vertex element. The previous Vertex Elem

Re: [Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

Yes, there is indeed plenty hw (all with d3d heritage, d3d10 doesn't support different ref/masks) which don't actually have full support for two-sided stencil. I think all drivers just cheat and fail though since they really want to expose GL 2 anyway. So I suppose that's ok, albeit I don't really

Re: [Mesa-dev] [PATCH] docs/release-calendar: update to include 18.1 and 18.2

On Tue, 2018-04-10 at 16:23 +0100, Emil Velikov wrote: > On 10 April 2018 at 09:06, Juan A. Suarez Romero wrote: > > On Mon, 2018-04-09 at 19:02 +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Dylan has kindly stepped up to help with 18.1.0, while I've taken the > > > liberty to

Re: [Mesa-dev] [PATCH 3/3] egl/x11: Handle both depth 30 formats for eglCreateImage().

On Tue, Apr 10, 2018 at 4:42 AM, Michel Dänzer wrote: > On 2018-04-10 10:22 AM, Mario Kleiner wrote: >> On 04/09/2018 12:12 PM, Michel Dänzer wrote: >>> On 2018-04-06 08:56 PM, Mario Kleiner wrote: >>> >>> I'm interested in the full xdpyinfo *at screen depth 30*, in particular >>> whether it lists

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

On 3/28/18, Emil Velikov wrote: > From: Emil Velikov > > Earlier commit enforced that we'll bail out if the number of terminators > is different than 2. With that in mind, the assert() will never trigger. > > Fixes: 56b867395de ("glsl: fix infinite loop caused by bug in loop > unrolling pass") >

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: >> >> On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand >> wrote: >> > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: >> >> >> >> On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand >> >>

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

On 10 April 2018 at 17:53, Ivan Kalvachev wrote: > On 3/28/18, Emil Velikov wrote: >> From: Emil Velikov >> >> Earlier commit enforced that we'll bail out if the number of terminators >> is different than 2. With that in mind, the assert() will never trigger. >> >> Fixes: 56b867395de ("glsl: fix

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

On Tue, Apr 10, 2018 at 10:05 AM, Emil Velikov wrote: > On 10 April 2018 at 17:53, Ivan Kalvachev wrote: > > On 3/28/18, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> Earlier commit enforced that we'll bail out if the number of terminators > >> is different than 2. With that in mind, t

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 9:59 AM, Rob Clark wrote: > On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand > wrote: > > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: > >> > >> On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand > >> wrote: > >> > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark > wrote:

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

On Tue, Apr 10, 2018 at 6:01 PM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 8:35 AM, Karol Herbst wrote: >> >> On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand >> wrote: >> > I still don't see anything to make nir_validate not fail out on you if >> > it >> > sees a read or a write to/from an

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

On Tue, Apr 10, 2018 at 10:20 AM, Karol Herbst wrote: > On Tue, Apr 10, 2018 at 6:01 PM, Jason Ekstrand > wrote: > > On Tue, Apr 10, 2018 at 8:35 AM, Karol Herbst > wrote: > >> > >> On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand > >> wrote: > >> > I still don't see anything to make nir_valida

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 1:17 PM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 9:59 AM, Rob Clark wrote: >> >> On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand >> wrote: >> > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: >> >> >> >> On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand >> >>

Re: [Mesa-dev] [PATCH v2 01/12] glsl/tests: reimplement warnings-test in python

Dylan Baker writes: > This reimplements the test in python with a shell script wrapper that > allows autotools to continue to run the test without realizing that > anything has changed. > > Using python has two advantages, first it's portable so this test can be > run on windows as well as Linux

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

This doesn't change TGSI. It only changes utilities around it. Marek On Mon, Apr 9, 2018 at 6:02 PM, Joe M. Kniss wrote: > Add support for glsl 'invariant' modifier for output data declarations. > Gallium drivers that use TGSI serialization currently loose invariant > modifiers in glsl shaders.

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

On Mon, Apr 9, 2018 at 5:37 PM, Dylan Baker wrote: > Are you building LLVM yourself, or is that a build that comes with your > distro? > Also, what is your distro? > Ubuntu 16.04. LLVM is in /usr/llvm/ bin is not in PATH by default, include is not in the include path by default, but lib is i

Re: [Mesa-dev] [PATCH v2 11/12] meson: build tests for gallium mesa state tracker

Dylan Baker writes: > Signed-off-by: Dylan Baker > --- > src/mesa/state_tracker/tests/meson.build | 40 +- > src/meson.build | 3 ++- > 2 files changed, 43 insertions(+) > create mode 100644 src/mesa/state_tracker/tests/meson.build > > diff --g

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

If I understand correctly, you don't disagree with the patch. Marek On Tue, Apr 10, 2018 at 2:03 PM, Marek Olšák wrote: > On Mon, Apr 9, 2018 at 5:37 PM, Dylan Baker wrote: > >> Are you building LLVM yourself, or is that a build that comes with your >> distro? >> Also, what is your distro? >>

Re: [Mesa-dev] [PATCH 04/11] gallium: Use Array._DrawVAO in st_atom_array.c.

Generally, if you have to loop over all arrays to find common vertex buffers, it's better not to do it. The default separate path is going to perform best, because it's straightforward and interleaved arrays are super rare. Marek On Mon, Apr 9, 2018 at 7:15 PM, Mathias Fröhlich wrote: > Hi Mare

Re: [Mesa-dev] [PATCH] RFC gallium: add 64 bit integer formats

On Mon, Apr 9, 2018 at 9:14 PM, Karol Herbst wrote: > On Tue, Apr 10, 2018 at 2:43 AM, Ilia Mirkin wrote: > > On Mon, Apr 9, 2018 at 8:39 PM, Karol Herbst wrote: > >> unsigneds are needed by ARB_bindless_texture 64 bit vertex attribs, > both for > >> NV_vertex_attrib_integer64. > >> > >> Fixes

Re: [Mesa-dev] [PATCH] i965/miptree: Initialize mcs buffer only until clear color

On Fri, Apr 06, 2018 at 07:04:01PM +0300, Pohjolainen, Topi wrote: > On Fri, Apr 06, 2018 at 08:53:39AM -0700, Jason Ekstrand wrote: > > On Fri, Apr 6, 2018 at 8:22 AM, Rafael Antognolli < > > rafael.antogno...@intel.com> wrote: > > > > > On Fri, Apr 06, 2018 at 06:07:52PM +0300, Topi Pohjolainen

Re: [Mesa-dev] [PATCH] intel/blorp/hiz: Emit CC viewport

On Tue, Apr 03, 2018 at 09:07:52PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 03, 2018 at 09:04:48PM +0300, Pohjolainen, Topi wrote: > > On Tue, Apr 03, 2018 at 07:40:34PM +0300, Topi Pohjolainen wrote: > > > Otherwise simulator for ICL complains that: > > > > > > B-spec CC_ViewPort Minimum Dep

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 1:50 PM, Rob Clark wrote: > On Tue, Apr 10, 2018 at 1:17 PM, Jason Ekstrand wrote: >> On Tue, Apr 10, 2018 at 9:59 AM, Rob Clark wrote: >>> >>> On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand >>> wrote: >>> > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: >>> >> >>>

Re: [Mesa-dev] [PATCH] intel/blorp/hiz: Emit CC viewport

On Tue, Apr 10, 2018 at 11:32:19AM -0700, Nanley Chery wrote: > On Tue, Apr 03, 2018 at 09:07:52PM +0300, Pohjolainen, Topi wrote: > > On Tue, Apr 03, 2018 at 09:04:48PM +0300, Pohjolainen, Topi wrote: > > > On Tue, Apr 03, 2018 at 07:40:34PM +0300, Topi Pohjolainen wrote: > > > > Otherwise simulat

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

Quoting Marek Olšák (2018-04-10 11:03:59) > On Mon, Apr 9, 2018 at 5:37 PM, Dylan Baker wrote: > > Are you building LLVM yourself, or is that a build that comes with your > distro? > Also, what is your distro? > > > Ubuntu 16.04. LLVM is in /usr/llvm/ bin is not in PATH by defau

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

Reviewed-by: Marek Olšák Marek On Tue, Apr 10, 2018 at 7:40 AM, Timothy Arceri wrote: > Drivers that only support compat 3.0 were reporting GLSL 1.40 > support. This fixes issues with the menu of Dawn of War II. > > Fixes: a0c8b49284ef "mesa: enable OpenGL 3.1 with ARB_compatibility" > > Bugzi

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=/usr/llvm/x86_64-linux-gnu -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" -DLLVM_ENABLE_ASSERTIONS=ON \ -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON \ -DLLVM_APPEND_VC_REV=OFF -DCMAKE_SHARED

  1   2   >