On Tue, Apr 10, 2018 at 11:32:19AM -0700, Nanley Chery wrote: > On Tue, Apr 03, 2018 at 09:07:52PM +0300, Pohjolainen, Topi wrote: > > On Tue, Apr 03, 2018 at 09:04:48PM +0300, Pohjolainen, Topi wrote: > > > On Tue, Apr 03, 2018 at 07:40:34PM +0300, Topi Pohjolainen wrote: > > > > Otherwise simulator for ICL complains that: > > > > > > > > B-spec CC_ViewPort Minimum Depth cannot be greater than Maximum Depth > > > > > > And it looks that there is real reason why even HIZ ops should > > > specify it. In Bspec: > > > > > > GT - 3D - vol2a.11 3D Pipeline - Windower - Depth Clear Value Format: > > > > > > The clear value must be between the min and max depth values > > > (inclusive) defined in the CC_VIEWPORT. > > > > And the same text is actually found in 3DSTATE_WM_HZ_OP_BODY - > > Depth Clear Value. > > > > Good find. Since this step isn't explicitly listed in the HZ OP > sequence, I think it would be helpful if we repeated what did for the > multisample packet and included a comment explaining why were updating > the viewport.
Sure, I'm happy to add a comment and bspec reference. > > With or without the comment, this patch is > Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > > > > > > > > > > > > CC: Jason Ekstrand <ja...@jlekstrand.net> > > > > CC: Kenneth Graunke <kenn...@whitecape.org> > > > > Signed-off-by: Topi Pohjolainen <topi.pohjolai...@intel.com> > > > > --- > > > > src/intel/blorp/blorp_genX_exec.h | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/src/intel/blorp/blorp_genX_exec.h > > > > b/src/intel/blorp/blorp_genX_exec.h > > > > index 992bc99..e16d10c 100644 > > > > --- a/src/intel/blorp/blorp_genX_exec.h > > > > +++ b/src/intel/blorp/blorp_genX_exec.h > > > > @@ -1570,6 +1570,7 @@ blorp_emit_gen8_hiz_op(struct blorp_batch *batch, > > > > * emit 3DSTATE_MULTISAMPLE. > > > > */ > > > > blorp_emit_3dstate_multisample(batch, params); > > > > + blorp_emit_cc_viewport(batch); > > > > > > > > /* If we can't alter the depth stencil config and multiple layers > > > > are > > > > * involved, the HiZ op will fail. This is because the op requires > > > > that a > > > > -- > > > > 2.7.4 > > > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
