[Mesa-dev] [PATCH] mesa: fix leaking ParameterValueOffset

2018-03-20 Thread Tapani Pälli
==15115== 48 bytes in 1 blocks are definitely lost in loss record 16 of 66 ==15115==at 0x4C2EC15: realloc (vg_replace_malloc.c:785) ==15115==by 0x8602C3E: _mesa_reserve_parameter_storage (prog_parameter.c:212) ==15115==by 0x8602D1E: _mesa_add_parameter (prog_parameter.c:252) ==15115==

[Mesa-dev] [Bug 105613] Compute shader locks up within nested "for" loop

2018-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105613 --- Comment #5 from Axel Davy --- Maybe related to: https://bugs.freedesktop.org/show_bug.cgi?id=105442 ? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [PATCH 2/2] meson: Don't build svga on ARM/AArch64

2018-03-20 Thread Daniel Stone
VMware has no (published) support for Arm-architecture guests. Signed-off-by: Daniel Stone Cc: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 88e90fe8119..24cad58c61e 100644 --- a/meson.build +++ b/meson.build @@ -

[Mesa-dev] [PATCH 1/2] meson: Add default DRI drivers for ARM/AArch64

2018-03-20 Thread Daniel Stone
On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as 'aarch64'), only build swrast for DRI drivers. The only classic drivers which could be used are r200 and NV20 cards, which seems unlikely enough that it shouldn't be the default. Signed-off-by: Daniel Stone Reported-by: Javier

[Mesa-dev] [PATCH] radv: only enable one channel when exporting prim id

2018-03-20 Thread Samuel Pitoiset
It's a 32-bit integer like the layer. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index ad046adfdb..c8d383e021 100644 --- a/src/amd/

Re: [Mesa-dev] [PATCH] mesa: fix leaking ParameterValueOffset

2018-03-20 Thread Timothy Arceri
Thanks! Reviewed-by: Timothy Arceri On 20/03/18 18:04, Tapani Pälli wrote: ==15115== 48 bytes in 1 blocks are definitely lost in loss record 16 of 66 ==15115==at 0x4C2EC15: realloc (vg_replace_malloc.c:785) ==15115==by 0x8602C3E: _mesa_reserve_parameter_storage (prog_parameter.c:212)

Re: [Mesa-dev] [PATCH 8/8] vc4: autotools: fix header inclusion in CFLAGS

2018-03-20 Thread Juan A. Suarez Romero
On Mon, 2018-03-19 at 18:51 +, Emil Velikov wrote: > On 19 March 2018 at 17:49, Juan A. Suarez Romero wrote: > > Load NIR compiler headers from srcdir, not builddir. > > --- > > src/gallium/drivers/vc4/Makefile.am | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a

[Mesa-dev] [Bug 105621] Build failure on GNOME Continuous

2018-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105621 Bug ID: 105621 Summary: Build failure on GNOME Continuous Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH v2] broadcom/vc4: add path to nir_builder.h

2018-03-20 Thread Juan A. Suarez Romero
As the other VC4 files do. Otherwise, it won't find nir_builder.h v2: add path in source code rather changing autotools (Emil) --- src/gallium/drivers/vc4/vc4_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/vc4/vc4_blit.c b/src/gallium/drivers/vc4/v

[Mesa-dev] [PATCH] radv: fix scanning output_usage_mask with structs

2018-03-20 Thread Samuel Pitoiset
To fix a regression in: dEQP-VK.spirv_assembly.instruction.graphics.variable_init.output.struct Fixes: f3275ca01c ("ac/nir: only enable used channels when exporting parameters") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader_info.c | 47 +-- 1

[Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Emil Velikov
From: Emil Velikov Stay consistent with the rest of the codebase, effectively fixing the autotools build. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105621 Fixes: ffa4bbe4665 ("st/nir/radeonsi: move nir_lower_uniforms_to_ubo() to the state tracker") Cc: Timothy Arceri Signed-off-by:

Re: [Mesa-dev] [PATCH] anv: off-by-one in GetDescriptorSetLayoutSupport

2018-03-20 Thread Lionel Landwerlin
On 19/03/18 22:39, Scott D Phillips wrote: Loop was accessing one more than bindingCount elements from pBindings, accessing uninitialized memory. Fixes: ddc4069122 ("anv: Implement VK_KHR_maintenance3") Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_descriptor_set.c | 2 +- 1 fi

[Mesa-dev] [Bug 105623] st_nir_lower_uniforms_to_ubo.c:32:17: fatal error: nir.h: No such file or directory

2018-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105623 Bug ID: 105623 Summary: st_nir_lower_uniforms_to_ubo.c:32:17: fatal error: nir.h: No such file or directory Product: Mesa Version: git Hardware: All OS: Li

Re: [Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Bas Nieuwenhuizen
is compiler/nir/nir.h the preferred way? I checked src/amd and we are using "nir/nir.h" all the time. On Tue, Mar 20, 2018 at 12:41 PM, Emil Velikov wrote: > From: Emil Velikov > > Stay consistent with the rest of the codebase, effectively fixing the > autotools build. > > Bugzilla: https://bug

Re: [Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 12:14, Bas Nieuwenhuizen wrote: > is compiler/nir/nir.h the preferred way? > > I checked src/amd and we are using "nir/nir.h" all the time. > Consistency within the subsystem is the key. Currently different subsystems have varying choices - language, formatting, coding style,..

[Mesa-dev] [Bug 105621] Build failure on GNOME Continuous

2018-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105621 --- Comment #1 from Emil Velikov --- Should be fixed with https://patchwork.freedesktop.org/patch/211459/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH 2/2] meson: Don't build svga on ARM/AArch64

2018-03-20 Thread Eric Engestrom
On Tuesday, 2018-03-20 08:54:25 +, Daniel Stone wrote: > VMware has no (published) support for Arm-architecture guests. > > Signed-off-by: Daniel Stone > Cc: Dylan Baker I would s/Don't build svga/Don't build svga by default/ in the commit title, but other than that nit, the series is: Revi

Re: [Mesa-dev] [PATCH v2] broadcom/vc4: add path to nir_builder.h

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 10:24, Juan A. Suarez Romero wrote: > As the other VC4 files do. Otherwise, it won't find nir_builder.h > > v2: add path in source code rather changing autotools (Emil) Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-

[Mesa-dev] [Bug 105621] Build failure on GNOME Continuous

2018-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105621 Emil Velikov changed: What|Removed |Added CC||pedretti.fa...@gmail.com --- Comment #2

[Mesa-dev] [Bug 105623] st_nir_lower_uniforms_to_ubo.c:32:17: fatal error: nir.h: No such file or directory

2018-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105623 Emil Velikov changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

Re: [Mesa-dev] [PATCH v6 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 04:40, Tomasz Figa wrote: > On Tue, Mar 20, 2018 at 2:55 AM, Emil Velikov > wrote: >> Hi Lepton, >> >> On 19 March 2018 at 17:33, Lepton Wu wrote: >>> If user calls map twice for kms_sw_displaytarget, the first mapped >>> buffer could get leaked. Instead of calling mmap ever

Re: [Mesa-dev] [PATCH 2/8] vulkan: autotools: build Wayland part conditionally

2018-03-20 Thread Eric Engestrom
On Monday, 2018-03-19 18:49:05 +0100, Juan A. Suarez Romero wrote: > Build vulkan/wsi/wayland if Wayland platform is enabled. > > CC: Daniel Stone > Fixes: bfa22266cd4d ("vulkan/wsi/wayland: Add support for zwp_dmabuf") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105211 > --- > conf

Re: [Mesa-dev] [PATCH] intel/blorp: Fix compiler warning about num_layers.

2018-03-20 Thread Lionel Landwerlin
On 16/03/18 22:20, Eric Anholt wrote: The compiler doesn't notice that the condition for num_layers to be undefined already defined it above (as our assert checked in a debug build). v2: Move the pair of assignments to one outside of the block. Cc: Jason Ekstrand Cc: Lionel Landwerlin Revie

[Mesa-dev] [PATCH] radv: optimize path when depth clamp is disabled

2018-03-20 Thread Samuel Pitoiset
Ported from AMVDVLK. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 89c5e69941..638c3074ec 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

Re: [Mesa-dev] [PATCH] radv: optimize path when depth clamp is disabled

2018-03-20 Thread Bas Nieuwenhuizen
On Tue, Mar 20, 2018 at 3:11 PM, Samuel Pitoiset wrote: > Ported from AMVDVLK. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c > inde

Re: [Mesa-dev] [PATCH v6 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

2018-03-20 Thread Tomasz Figa
On Tue, Mar 20, 2018 at 10:44 PM, Emil Velikov wrote: > On 20 March 2018 at 04:40, Tomasz Figa wrote: >> On Tue, Mar 20, 2018 at 2:55 AM, Emil Velikov >> wrote: >>> Hi Lepton, >>> >>> On 19 March 2018 at 17:33, Lepton Wu wrote: If user calls map twice for kms_sw_displaytarget, the first m

Re: [Mesa-dev] [PATCH v2 4/7] ac: make ballot and umsb capable of 64bit inputs

2018-03-20 Thread Marek Olšák
On Fri, Mar 16, 2018 at 5:50 AM, Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > Signed-off-by: Daniel Schürmann > --- > src/amd/common/ac_llvm_build.c | 33 - > 1 file changed, 24 insertions(+), 9 deletions(-) > > diff --git a/src/amd/common/ac

Re: [Mesa-dev] [PATCH] radv: optimize path when depth clamp is disabled

2018-03-20 Thread Samuel Pitoiset
On 03/20/2018 03:18 PM, Bas Nieuwenhuizen wrote: On Tue, Mar 20, 2018 at 3:11 PM, Samuel Pitoiset wrote: Ported from AMVDVLK. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline

Re: [Mesa-dev] [PATCH v2 2/8] intel: devinfo: store slice/subslice/eu masks

2018-03-20 Thread Lionel Landwerlin
On 19/03/18 23:56, Kenneth Graunke wrote: On Wednesday, March 14, 2018 10:19:08 AM PDT Lionel Landwerlin wrote: We want to store values coming from the kernel but as a first step, we can generate mask values out the numbers already stored in the gen_device_info masks. Signed-off-by: Lionel Land

Re: [Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

2018-03-20 Thread Nicolai Hähnle
Nice, did you actually get it to work entirely on a big endian machine? Bit fields aren't super portable, but this looks good enough. However, I think we should use the PIPE_ARCH_LITTLE_ENDIAN define from u_endian.h Cheers, Nicolai On 20.03.2018 15:21, Bas Vermeulen wrote: Using mesa OpenCL

Re: [Mesa-dev] [PATCH v2 5/7] ac: add LLVM build functions for subgroup instrinsics

2018-03-20 Thread Marek Olšák
On Fri, Mar 16, 2018 at 5:50 AM, Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > Co-authored-by: Connor Abbott > Signed-off-by: Daniel Schürmann > --- > src/amd/common/ac_llvm_build.c | 475 ++ > +++ > src/amd/common/ac_llvm_build.h | 33 +

Re: [Mesa-dev] [PATCH v2 4/7] ac: make ballot and umsb capable of 64bit inputs

2018-03-20 Thread Marek Olšák
Other than that, the patch is: Reviewed-by: Marek Olšák Marek On Tue, Mar 20, 2018 at 10:25 AM, Marek Olšák wrote: > On Fri, Mar 16, 2018 at 5:50 AM, Daniel Schürmann < > daniel.schuerm...@campus.tu-berlin.de> wrote: > >> Signed-off-by: Daniel Schürmann >> --- >> src/amd/common/ac_llvm_buil

Re: [Mesa-dev] [PATCH 2/8] vulkan: autotools: build Wayland part conditionally

2018-03-20 Thread Juan A. Suarez Romero
On Tue, 2018-03-20 at 13:58 +, Eric Engestrom wrote: > On Monday, 2018-03-19 18:49:05 +0100, Juan A. Suarez Romero wrote: > > Build vulkan/wsi/wayland if Wayland platform is enabled. > > > > CC: Daniel Stone > > Fixes: bfa22266cd4d ("vulkan/wsi/wayland: Add support for zwp_dmabuf") > > Bugzil

Re: [Mesa-dev] [PATCH 2/2] ac/nir_to_llvm: add frexp support

2018-03-20 Thread Marek Olšák
I think we should set READNONE on the intrinsic calls. Other than that: Reviewed-by: Marek Olšák Marek On Mon, Mar 19, 2018 at 10:09 PM, Timothy Arceri wrote: > Fixes CTS tests: > KHR-GL40.gpu_shader_fp64.builtin.frexp_double > KHR-GL40.gpu_shader_fp64.builtin.frexp_dvec2 > KHR-GL40.gpu_shad

[Mesa-dev] [PATCH] i965: fix autotools build

2018-03-20 Thread Lionel Landwerlin
In tree builds are failing because os.path.basename() doesn't seem to deal well with a relative path not containing any '/'. Fixes: 035cc7a12dc ("i965: perf: reduce i965 binary size") Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_oa.py | 5 - 1 file changed, 4 insertions

Re: [Mesa-dev] [PATCH] i965: fix autotools build

2018-03-20 Thread Lionel Landwerlin
On 20/03/18 14:48, Lionel Landwerlin wrote: In tree builds are failing because os.path.basename() doesn't seem to deal well with a relative path not containing any '/'. Fixes: 035cc7a12dc ("i965: perf: reduce i965 binary size") Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH v2] vulkan: autotools: build Wayland part conditionally

2018-03-20 Thread Juan A. Suarez Romero
Build vulkan/wsi/wayland if Wayland platform is enabled. v2: fix comparison with default fallback (Eric) CC: Daniel Stone Fixes: bfa22266cd4d ("vulkan/wsi/wayland: Add support for zwp_dmabuf") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105211 Reviewed-by: Emil Velikov squash! vulka

[Mesa-dev] [PATCH] i965: fix autotools/android build

2018-03-20 Thread Lionel Landwerlin
Autotools/android builds generate the header & code files in 2 steps, but the code generation requires the name of the header file to include it. This change generates both files in one command. Fixes: 035cc7a12dc ("i965: perf: reduce i965 binary size") Signed-off-by: Lionel Landwerlin --- src/

Re: [Mesa-dev] [PATCH 0/9] Clean up draw path state updates.

2018-03-20 Thread Brian Paul
On 03/15/2018 11:48 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Brian, This series mostly prepares the pushdown of gl_vertex_array use into the drivers. Once it is there we can fade that out for most of the drivers and change that on a per driver base. The series cleans up w

Re: [Mesa-dev] [PATCH 1/9] mesa: Make draw a first place driver method.

2018-03-20 Thread Brian Paul
Maybe change the subject: "mesa: move vbo draw functions into dd_function_table" On 03/15/2018 11:48 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Make drawing functions members of struct dd_function_table. What if not drawing, should be the major purpose of an OpenGL driver.

Re: [Mesa-dev] [PATCH 5/9] mesa: A change of gl_vertex_processing_mode needs an array update.

2018-03-20 Thread Brian Paul
On 03/15/2018 11:48 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Since arrays also handle the mapping of current values into the disabled array slots, we need to tell the array update code that this mapping has changed. Also mark only dirty if it has changed. "Also, only mark a

Re: [Mesa-dev] [PATCH 2/9] vbo: Move vbo_bind_arrays into a dd_driver_functions draw callback.

2018-03-20 Thread Brian Paul
On 03/15/2018 11:48 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Factor out that common call into the almost single place. Remove the _mesa_set_drawing_arrays call from vbo_{exec,save}_draw code paths as the fonction is now called through vbo_bind_arrays. "function" And prepa

Re: [Mesa-dev] [PATCH 3/9] mesa: Update vao internal state when setting the _DrawVAO.

2018-03-20 Thread Brian Paul
On 03/15/2018 11:48 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich We do care if the vao set as Array._DrawVAO is ready to draw not so much that the current Array.VAO in terms of the OpenGL api is fully up to date for drawing. Can you rephrase that? Also no driver looks at any

Re: [Mesa-dev] [PATCH 9/9] vbo: Remove now duplicate _DrawVAO notification.

2018-03-20 Thread Brian Paul
On 03/15/2018 11:48 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich The DriverFlags.NewArray bit is set into NewDriverState already on "The DriverFlags.NewArray bit is already set to NewDriverState in" _mesa_set_draw_vao since we have actually just above changed the VAOs conten

Re: [Mesa-dev] [PATCH] i965: fix autotools/android build

2018-03-20 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 20.03.2018 16:59, Lionel Landwerlin wrote: Autotools/android builds generate the header & code files in 2 steps, but the code generation requires the name of the header file to include it. This change generates both files in one command. Fixes: 035cc7a12dc ("i965:

[Mesa-dev] [PATCH] st/mesa: fix nir.h, nir_builder.h #includes to fix build

2018-03-20 Thread Brian Paul
Use compiler/nir/nir.h as we do in other places in the state tracker. I'm not sure why this just started to fail. The #includes have been there for a while. --- src/mesa/state_tracker/st_nir_lower_uniforms_to_ubo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/s

Re: [Mesa-dev] [PATCH v6 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 14:24, Tomasz Figa wrote: > On Tue, Mar 20, 2018 at 10:44 PM, Emil Velikov > wrote: >> On 20 March 2018 at 04:40, Tomasz Figa wrote: >>> On Tue, Mar 20, 2018 at 2:55 AM, Emil Velikov >>> wrote: Hi Lepton, On 19 March 2018 at 17:33, Lepton Wu wrote: > If

Re: [Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

2018-03-20 Thread Bas Vermeulen
I'm able to call clinfo without things crashing. Without this fix, clinfo results in a signal 11 because key.index is byte swapped. With it, I get the information I would expect. I'm working to test the OpenCL currently. I'll update the patch to use PIPE_ARCH_LITTLE_ENDIAN instead of my own #if.

[Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

2018-03-20 Thread Bas Vermeulen
Using mesa OpenCL failed on a big endian PowerPC machine because si_vgt_param_key is using bitfields and a 32 bit int for an index into an array. Fix si_vgt_param_key to work correctly on both little endian and big endian machines. Signed-off-by: Bas Vermeulen --- src/gallium/drivers/radeonsi/s

Re: [Mesa-dev] [PATCH] st/mesa: fix nir.h, nir_builder.h #includes to fix build

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 15:51, Brian Paul wrote: > Use compiler/nir/nir.h as we do in other places in the state tracker. > I'm not sure why this just started to fail. The #includes have been > there for a while. I've sent identical patch (+fixes/cc tags) a some hours ago [1]. Feel free to push eithe

[Mesa-dev] [PATCH] aubinator_error_decode: Compare only the class_name of the ring.

2018-03-20 Thread Rafael Antognolli
ring_name is " + " (e.g. rcs0). So we need to first compare the class name only, then get the instance id. Without this, INSTDONE is not being decoded. Signed-off-by: Rafael Antognolli Cc: Chris Wilson --- src/intel/tools/aubinator_error_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Brian Paul
On 03/20/2018 05:41 AM, Emil Velikov wrote: From: Emil Velikov Stay consistent with the rest of the codebase, effectively fixing the autotools build. Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D105621&d=DwIGaQ&c=uilaK90D4TOVoH58JNX

Re: [Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 16:15, Brian Paul wrote: > On 03/20/2018 05:41 AM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Stay consistent with the rest of the codebase, effectively fixing the >> autotools build. >> >> Bugzilla: >> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesk

Re: [Mesa-dev] [PATCH 2/2] meson: Don't build svga on ARM/AArch64

2018-03-20 Thread Dylan Baker
Quoting Daniel Stone (2018-03-20 01:54:25) > VMware has no (published) support for Arm-architecture guests. > > Signed-off-by: Daniel Stone > Cc: Dylan Baker > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 88e90fe81

[Mesa-dev] [PATCH] dri3: Fix typo in version check

2018-03-20 Thread Daniel Stone
The have-new-DRI3 codepaths would never actually properly trigger, since there was a typo in configure.ac which broke the version check. This went unnoticed but for an error in config.log if you looked closely enough. Signed-off-by: Daniel Stone Reported-by: Lukas F. Hartmann Fixes: 7aeef2d4efdc

Re: [Mesa-dev] [PATCH 2/2] meson: Don't build svga on ARM/AArch64

2018-03-20 Thread Daniel Stone
On 20 March 2018 at 16:16, Dylan Baker wrote: > Quoting Daniel Stone (2018-03-20 01:54:25) >> VMware has no (published) support for Arm-architecture guests. Pushed now with review and the new suggested title - thanks both for review! Cheers, Daniel ___

Re: [Mesa-dev] [PATCH] i965: fix autotools/android build

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 14:59, Lionel Landwerlin wrote: > Autotools/android builds generate the header & code files in 2 steps, > but the code generation requires the name of the header file to > include it. > > This change generates both files in one command. > > Fixes: 035cc7a12dc ("i965: perf: redu

Re: [Mesa-dev] [PATCH] dri3: Fix typo in version check

2018-03-20 Thread Dylan Baker
Quoting Daniel Stone (2018-03-20 09:17:21) > The have-new-DRI3 codepaths would never actually properly trigger, since > there was a typo in configure.ac which broke the version check. This > went unnoticed but for an error in config.log if you looked closely > enough. > > Signed-off-by: Daniel Sto

Re: [Mesa-dev] [PATCH v6 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

2018-03-20 Thread Tomasz Figa
On Wed, Mar 21, 2018 at 12:58 AM, Emil Velikov wrote: > On 20 March 2018 at 14:24, Tomasz Figa wrote: >> On Tue, Mar 20, 2018 at 10:44 PM, Emil Velikov >> wrote: >>> On 20 March 2018 at 04:40, Tomasz Figa wrote: On Tue, Mar 20, 2018 at 2:55 AM, Emil Velikov wrote: > Hi Lepton,

Re: [Mesa-dev] [PATCH] aubinator_error_decode: Compare only the class_name of the ring.

2018-03-20 Thread Chris Wilson
Quoting Rafael Antognolli (2018-03-20 16:13:08) > ring_name is " + " (e.g. rcs0). So we need to > first compare the class name only, then get the instance id. > > Without this, INSTDONE is not being decoded. > > Signed-off-by: Rafael Antognolli > Cc: Chris Wilson > --- > src/intel/tools/aubina

[Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-20 Thread Emil Velikov
From: Emil Velikov As of earlier commit, the --header was made a hard requirement when using --code. Hence - annotate both as required and drop a few no longer needed checks. Fixes: 035cc7a12dc0 ("i965: perf: reduce i965 binary size") Cc: Lionel Landwerlin Signed-off-by: Emil Velikov --- Tad

Re: [Mesa-dev] [PATCH] aubinator_error_decode: Compare only the class_name of the ring.

2018-03-20 Thread Lionel Landwerlin
On 20/03/18 16:30, Chris Wilson wrote: Quoting Rafael Antognolli (2018-03-20 16:13:08) ring_name is " + " (e.g. rcs0). So we need to first compare the class name only, then get the instance id. Without this, INSTDONE is not being decoded. Signed-off-by: Rafael Antognolli Cc: Chris Wilson ---

Re: [Mesa-dev] [PATCH] dri3: Fix typo in version check

2018-03-20 Thread Daniel Stone
On 20 March 2018 at 16:24, Dylan Baker wrote: > Quoting Daniel Stone (2018-03-20 09:17:21) >> The have-new-DRI3 codepaths would never actually properly trigger, since >> there was a typo in configure.ac which broke the version check. This >> went unnoticed but for an error in config.log if you loo

Re: [Mesa-dev] [PATCH] i965: fix autotools/android build

2018-03-20 Thread Lionel Landwerlin
On 20/03/18 16:23, Emil Velikov wrote: On 20 March 2018 at 14:59, Lionel Landwerlin wrote: Autotools/android builds generate the header & code files in 2 steps, but the code generation requires the name of the header file to include it. This change generates both files in one command. Fixes:

Re: [Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-20 Thread Dylan Baker
Quoting Emil Velikov (2018-03-20 09:29:00) [snip] > gens = [] > for xml_file in args.xml_files: > @@ -617,7 +610,7 @@ def main(): > > """)) > > -c("#include \"" + os.path.basename(args.header) + "\"") > +c("#include \"" + os.path.basename(header_file) + "\"") You're

Re: [Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-20 Thread Lionel Landwerlin
On 20/03/18 16:29, Emil Velikov wrote: From: Emil Velikov As of earlier commit, the --header was made a hard requirement when using --code. Hence - annotate both as required and drop a few no longer needed checks. Fixes: 035cc7a12dc0 ("i965: perf: reduce i965 binary size") Cc: Lionel Landwerl

Re: [Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 17:06, Lionel Landwerlin wrote: > On 20/03/18 16:29, Emil Velikov wrote: >> >> From: Emil Velikov >> >> As of earlier commit, the --header was made a hard requirement when >> using --code. >> >> Hence - annotate both as required and drop a few no longer needed >> checks. >> >>

Re: [Mesa-dev] [PATCH] radeonsi: correct si_vgt_param_key on big endian machines

2018-03-20 Thread Gert Wollny
Am Dienstag, den 20.03.2018, 15:33 +0100 schrieb Nicolai Hähnle: > Nice, did you actually get it to work entirely on a big endian > machine? > > Bit fields aren't super portable, [...] Indeed, the order of the bits in a bit field is compiler implementation dependent. To make sure that changing the

[Mesa-dev] [PATCH kmscube] cube-tex: make use of modifiers

2018-03-20 Thread Christian Gmeiner
Fixes rendering issues with mode rgba on etnaviv. I have applied the same change for nv12 variants but they are not supported on etnaviv. Signed-off-by: Christian Gmeiner --- cube-tex.c | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/cube-tex

Re: [Mesa-dev] [PATCH] aubinator_error_decode: Compare only the class_name of the ring.

2018-03-20 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-03-20 16:39:18) > On 20/03/18 16:30, Chris Wilson wrote: > > Quoting Rafael Antognolli (2018-03-20 16:13:08) > >> ring_name is " + " (e.g. rcs0). So we need to > >> first compare the class name only, then get the instance id. > >> > >> Without this, INSTDONE is not b

Re: [Mesa-dev] [PATCH v2 5/8] intel: devinfo: add helper functions to fill fusing masks values

2018-03-20 Thread Lionel Landwerlin
On 20/03/18 00:08, Kenneth Graunke wrote: On Wednesday, March 14, 2018 10:19:11 AM PDT Lionel Landwerlin wrote: There are a couple of ways we can get the fusing information from the kernel : - Through DRM_I915_GETPARAM with the SLICE_MASK/SUBSLICE_MASK parameters - Through the new D

[Mesa-dev] [Bug 105621] Build failure on GNOME Continuous

2018-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105621 Mark Janes changed: What|Removed |Added CC||mark.a.ja...@intel.com --- Comment #3 from

[Mesa-dev] [PATCH] i965: android: pass the correct header name to the python script

2018-03-20 Thread Emil Velikov
Fixes: 2d2b15fbcab ("i965: fix autotools/android build Cc: Lionel Landwerlin Cc: Clayton Craft Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/Android.mk b/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH v2] i965: android: pass the correct header name to the python script

2018-03-20 Thread Emil Velikov
v2: Pass the actual filename instead of $(word ...) magic Fixes: 2d2b15fbcab ("i965: fix autotools/android build Cc: Lionel Landwerlin Cc: Clayton Craft Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/

Re: [Mesa-dev] [PATCH 1/2] nir: Initial implementation of a nir_instr_worklist

2018-03-20 Thread Eric Anholt
Thomas Helland writes: > Make a simple worklist by basically just wrapping u_vector. > This is intended used in nir_opt_dce to reduce the number of calls > to ralloc, as we are currenlty spamming ralloc quite bad. It should > also give better cache locality and much lower memory usage. > --- > s

[Mesa-dev] [Bug 105621] Build failure on GNOME Continuous

2018-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105621 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH kmscube] cube-tex: make use of modifiers

2018-03-20 Thread Eric Engestrom
On Tuesday, 2018-03-20 19:02:00 +0100, Christian Gmeiner wrote: > Fixes rendering issues with mode rgba on etnaviv. I have applied > the same change for nv12 variants but they are not supported on > etnaviv. > > Signed-off-by: Christian Gmeiner LGTM! Reviewed-by: Eric Engestrom > --- > cube-t

Re: [Mesa-dev] [PATCH kmscube] cube-tex: make use of modifiers

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 18:02, Christian Gmeiner wrote: > Fixes rendering issues with mode rgba on etnaviv. I have applied > the same change for nv12 variants but they are not supported on > etnaviv. > > Signed-off-by: Christian Gmeiner > --- > cube-tex.c | 32 > 1 f

Re: [Mesa-dev] Releasing 18.0

2018-03-20 Thread Emil Velikov
On 15 March 2018 at 17:01, Marek Olšák wrote: > Hi, > > I'd like to have these in 18.0. People can fetch them here: >git://people.freedesktop.org/~mareko/mesa for-18.0 > > They are already in our AMD internal 18.0 branch, so they get quite a lot of > testing. > > pick 0554172 radeonsi: align c

[Mesa-dev] [PATCH] i965: fix out of tree autotools build

2018-03-20 Thread Lionel Landwerlin
Fixes: 2d2b15fbcab ("i965: fix autotools/android build") Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/Makefile.am | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index fe106b42

Re: [Mesa-dev] [PATCH v2] docs: add 17.3.{8, 9} in the release calendar

2018-03-20 Thread Emil Velikov
On 19 March 2018 at 15:28, Juan A. Suarez Romero wrote: > Mesa 18.0 series has not been released yet, so let's extend 17.3 lifetime. > Any moment now ;-) > v2: add 17.3.9 in the calendar (Andres Gomez) > > CC: Andres Gomez > CC: Emil Velikov > --- Reviewed-by: Emil Velikov -Emil _

[Mesa-dev] [PATCH v3] i965: android: pass the correct header name to the python script

2018-03-20 Thread Emil Velikov
v2: Pass the actual filename instead of $(word ...) magic v3: Drop duplicate $(i965_oa_xml_FILES) Fixes: 2d2b15fbcab ("i965: fix autotools/android build Cc: Lionel Landwerlin Cc: Clayton Craft Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/Android.mk | 2 +- 1 file changed, 1 insert

Re: [Mesa-dev] [PATCH] i965: fix out of tree autotools build

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 18:59, Lionel Landwerlin wrote: > Fixes: 2d2b15fbcab ("i965: fix autotools/android build") > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/Makefile.am | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/M

Re: [Mesa-dev] [PATCH] i965: fix out of tree autotools build

2018-03-20 Thread Mathias Fröhlich
Hi, Looks good and helps here a lot! Thanks! Reviewed-by: Mathias Fröhlich Mathias On Tuesday, 20 March 2018 19:59:00 CET Lionel Landwerlin wrote: > Fixes: 2d2b15fbcab ("i965: fix autotools/android build") > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/Makefile.am | 5 +

Re: [Mesa-dev] [PATCH v3] i965: android: pass the correct header name to the python script

2018-03-20 Thread Lionel Landwerlin
On 20/03/18 19:34, Emil Velikov wrote: v2: Pass the actual filename instead of $(word ...) magic v3: Drop duplicate $(i965_oa_xml_FILES) Fixes: 2d2b15fbcab ("i965: fix autotools/android build Cc: Lionel Landwerlin Cc: Clayton Craft Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/A

[Mesa-dev] [PATCH] i965/tiled_memcpy: realign rgba8_copy_aligned_dst stack in 32-bit builds

2018-03-20 Thread Scott D Phillips
When building intel_tiled_memcpy for i686, the stack will only be 4-byte aligned. This isn't sufficient for SSE temporaries which require 16-byte alignment. Use the force_align_arg_pointer function attribute in that case to ensure sufficient alignment. --- src/mesa/drivers/dri/i965/intel_tiled_me

Re: [Mesa-dev] [PATCH] i965/tiled_memcpy: realign rgba8_copy_aligned_dst stack in 32-bit builds

2018-03-20 Thread Chris Wilson
Quoting Scott D Phillips (2018-03-20 20:39:25) > When building intel_tiled_memcpy for i686, the stack will only be > 4-byte aligned. This isn't sufficient for SSE temporaries which > require 16-byte alignment. Use the force_align_arg_pointer > function attribute in that case to ensure sufficient a

Re: [Mesa-dev] [PATCH v3] i965/miptree: Use cpu tiling/detiling when mapping

2018-03-20 Thread Nanley Chery
On Wed, Mar 14, 2018 at 05:18:58PM +, Chris Wilson wrote: > Quoting Nanley Chery (2018-03-14 17:14:15) > > On Mon, Mar 12, 2018 at 10:52:55AM -0700, Scott D Phillips wrote: > > > Rename the (un)map_gtt functions to (un)map_map (map by > > > returning a map) and add new functions (un)map_tiled_m

[Mesa-dev] [PATCH] i965: fix android build

2018-03-20 Thread Lionel Landwerlin
This is the equivalent of commit 5770e1d89e0eb49eb3c9547e8657d636b6e7e5d7 for android. Signed-off-by: Lionel Landwerlin Fixes: 2d2b15fbcab ("i965: fix autotools/android build") --- src/mesa/drivers/dri/i965/Android.mk | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/me

[Mesa-dev] [PATCH v2] radv: fix scanning output_usage_mask with structs

2018-03-20 Thread Samuel Pitoiset
To fix a regression in: dEQP-VK.spirv_assembly.instruction.graphics.variable_init.output.struct v2: handle indirect array accesses (Dave) Fixes: f3275ca01c ("ac/nir: only enable used channels when exporting parameters") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader_info.c | 65

Re: [Mesa-dev] [PATCH v3] i965: android: pass the correct header name to the python script

2018-03-20 Thread Mark Janes
I tested this, and still got an error: FAILED: out/target/product/androidia_64/gen/SHARED_LIBRARIES/i965_dri_intermediates/brw_oa_metrics.c /bin/bash -c "python vendor/intel/external/android_ia/mesa/src/mesa/drivers/dri/i965/brw_oa.py --code=out/target/product/androidia_64/gen/SHARED_LIBRARIE

Re: [Mesa-dev] [PATCH v3] i965: android: pass the correct header name to the python script

2018-03-20 Thread Lionel Landwerlin
Thanks Mark, There is one thing I cannot explain why Emil's patch : How comes it is : --code=out/target/product/androidia_64/gen/SHARED_LIBRARIES/i965_dri_intermediates/brw_oa_metrics.c Yet : --header=out/target/common/obj/PACKAGING/boot-jars-package-check_intermediates/brw_oa_metrics.h T

[Mesa-dev] [PATCH] i965: android: pass the correct header path to brw_oa.py

2018-03-20 Thread Lionel Landwerlin
$(intermediates) is somehow different from $(dir $@). We were also passing the xml files twice :/ Fixes: 2d2b15fbcab ("i965: fix autotools/android build") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105634 Signed-off-by: Lionel Landwerlin Tested-by: Mark Janes --- src/mesa/drivers/d

Re: [Mesa-dev] [PATCH v4 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

2018-03-20 Thread Caio Marcelo de Oliveira Filho
Hi Iago, > Fixes: > dEQP-VK.multiview.readback_implicit_clear.* Applied locally and verified this. Thanks for fixing those. I have a couple of comments after reading the patch, feel free to take them only if make sense to you :-) > + /* When multiview is active, attachments with a renderpass

Re: [Mesa-dev] [PATCH 5/5] i965/miptree: Don't gtt map from map_depthstencil

2018-03-20 Thread Nanley Chery
On Tue, Jan 09, 2018 at 11:17:02PM -0800, Scott D Phillips wrote: > Instead of gtt mapping, call out to other map functions (map_map > or map_tiled_memcpy) for the depth surface. Removes a place where > gtt mapping is used. > --- > This is a bit icky, perhaps something like mapping z_mt with > BRW_

Re: [Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

2018-03-20 Thread Aaron Watry
ping. This is the last of the series that still needs review. --Aaron On Thu, Mar 1, 2018 at 1:39 PM, Aaron Watry wrote: > Use get_language_version to calculate default cl standard based on > device capabilities and -cl-std specified in build options. > > v4: Squash the __OPENCL_VERSION__ and C

Re: [Mesa-dev] [PATCH kmscube] cube-tex: make use of modifiers

2018-03-20 Thread Rob Clark
On Tue, Mar 20, 2018 at 2:45 PM, Emil Velikov wrote: > On 20 March 2018 at 18:02, Christian Gmeiner > wrote: >> Fixes rendering issues with mode rgba on etnaviv. I have applied >> the same change for nv12 variants but they are not supported on >> etnaviv. >> >> Signed-off-by: Christian Gmeiner >

[Mesa-dev] [PATCH 1/3] radeonsi/nir: fix scanning of multi-slot output varyings

2018-03-20 Thread Timothy Arceri
This fixes tcs/tes varying arrays where we dont lower indirects and therefore don't split arrays. Here we also fix useagemask for dual slot doubles. Fixes a number of arb_tessellation_shader piglit tests. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 236 ++- 1 file c

[Mesa-dev] [PATCH 2/3] st/glsl_to_nir: fix driver location for packed doubles

2018-03-20 Thread Timothy Arceri
--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index afb6120d9d..b01be622f7 100644 --- a/src/mesa/state_tracker/st_glsl_

[Mesa-dev] [PATCH 3/3] ac/nir_to_llvm: fix component packing for double outputs

2018-03-20 Thread Timothy Arceri
We need to wait until after the writemask is widened before we adjust it for component packing. Together with the previous patch this fixes a number of arb_enhanced_layouts component layout piglit tests. --- src/amd/common/ac_nir_to_llvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

  1   2   >