Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

2018-03-16 Thread Tomasz Figa
Hi Lepton, Please avoid top-posting in mailing lists in the future. It's against the netiquette. On Wed, Mar 14, 2018 at 10:20 AM, Lepton Wu wrote: [Message moved to bottom] > On Tue, Mar 13, 2018 at 8:41 AM, Emil Velikov > wrote: >> On 13 March 2018 at 11:46, Tomasz Figa wrote: >>> On Thu, M

Re: [Mesa-dev] [PATCH v3 2/2] gallium/winsys/kms: Add support for multi-planes

2018-03-16 Thread Tomasz Figa
On Wed, Mar 7, 2018 at 7:43 AM, Lepton Wu wrote: > Add a new struct kms_sw_plane which delegate a plane and use it > in place of sw_displaytarget. Multiple planes share same underlying > kms_sw_displaytarget. > > Change-Id: I0e9ca1d0ba0aa78c27dfdb50c30dc0c424fec172 > Signed-off-by: Lepton Wu > --

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Timothy Arceri
On 16/03/18 17:24, Jason Ekstrand wrote: Assuming the thing I typed in my phone actually works, r-b. :-). I'm a bit surprised we didn't already have that one. It seems so obvious in hindsight. Yeah it worked :) and picked up one more combo I missed. The previous patch only impacted Tomb Raide

Re: [Mesa-dev] [PATCH] radv: handle exporting view index to fragment shader.

2018-03-16 Thread Samuel Pitoiset
On 03/16/2018 06:58 AM, Dave Airlie wrote: From: Dave Airlie The fragment shader was trying to read this, but nothing was exporting it from the vertex shader. This handles it like the prim id export. Fixes: dEQP-VK.multiview.secondary_cmd_buffer.* dEQP-VK.multiview.index.fragment_shader.* S

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Samuel Pitoiset
shader stats? On 03/16/2018 06:48 AM, Timothy Arceri wrote: These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --- src/compiler/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compi

Re: [Mesa-dev] [PATCH] radv/query: handle multiview queries properly. (v2)

2018-03-16 Thread Samuel Pitoiset
On 03/16/2018 07:32 AM, Dave Airlie wrote: From: Dave Airlie For multiview we need to emit a number of sequential queries depending on the view mask. This avoids dEQP-VK.multiview.queries.15 waiting forever on the CPU for query results that are never coming. This doesn't make this test pass

[Mesa-dev] Create texture2D from NV12

2018-03-16 Thread Zong, Wei
Hello, May I ask a question? I got a NV12 image buffer and I want to render it with OpenGL. I know a method to do this is to bind Y/UV planes as two separate textures, then perform YUV to RGB conversion in fragment shader. But I want to know if Mesa provide APIs to create and bind a texture 2D

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Timothy Arceri
On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? I didn't bother posting them because they are misleading. There are a few instructions remove here and there but the main changes are due to loop unrolling. Totals from affected shaders: SGPRS: 640 -> 664 (3.75 %) VGPRS: 352 -> 368 (4.

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

2018-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105171 --- Comment #16 from Clemens Eisserer --- some here, on my Kaveri 7650k results with the patch are basically unchanged : amdgpu: 8557.942992 Ops/s; put composition (!); 32x32 should I test with radeon too? Dieter: Just to be curious, which va

Re: [Mesa-dev] [PATCH 1/2] nir: add nir_opt_move_load_ubo() optimization pass

2018-03-16 Thread Timothy Arceri
On 16/03/18 11:38, Timothy Arceri wrote: On 09/03/18 01:50, Samuel Pitoiset wrote: This pass moves load UBO operations just before their first use, loosely based on nir_opt_move_comparisons. Signed-off-by: Samuel Pitoiset ---   src/compiler/Makefile.sources    |   1 +   src/compile

Re: [Mesa-dev] [PATCH 1/2] nir: add nir_opt_move_load_ubo() optimization pass

2018-03-16 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri On 09/03/18 01:50, Samuel Pitoiset wrote: This pass moves load UBO operations just before their first use, loosely based on nir_opt_move_comparisons. Signed-off-by: Samuel Pitoiset --- src/compiler/Makefile.sources| 1 + src/compiler/nir/m

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Samuel Pitoiset
On 03/16/2018 09:15 AM, Timothy Arceri wrote: On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? I didn't bother posting them because they are misleading. There are a few instructions remove here and there but the main changes are due to loop unrolling. Totals from affected shaders:

Re: [Mesa-dev] [PATCH] radv/query: handle multiview queries properly. (v2)

2018-03-16 Thread Dave Airlie
On 16 March 2018 at 17:51, Samuel Pitoiset wrote: > > > On 03/16/2018 07:32 AM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> For multiview we need to emit a number of sequential queries >> depending on the view mask. >> >> This avoids dEQP-VK.multiview.queries.15 waiting forever >> on the CPU

Re: [Mesa-dev] [PATCH v2] egl/android: Implement the eglSwapinterval for Android.

2018-03-16 Thread Wu, Zhongmin
Thanks very much Tomasz. So, who can help to commit such patch. -Original Message- From: Tomasz Figa [mailto:tf...@chromium.org] Sent: Thursday, March 15, 2018 16:07 To: Wu, Zhongmin Cc: ML mesa-dev ; Rob Herring ; Emil Velikov ; Liu, Zhiquan ; Long, Zhifang ; Kondapally, Kalyan ; P

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Timothy Arceri
On 16/03/18 19:34, Samuel Pitoiset wrote: On 03/16/2018 09:15 AM, Timothy Arceri wrote: On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? I didn't bother posting them because they are misleading. There are a few instructions remove here and there but the main changes are due to lo

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Samuel Pitoiset
On 03/16/2018 09:58 AM, Timothy Arceri wrote: On 16/03/18 19:34, Samuel Pitoiset wrote: On 03/16/2018 09:15 AM, Timothy Arceri wrote: On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? I didn't bother posting them because they are misleading. There are a few instructions remove h

[Mesa-dev] [PATCH v2] i965: prevent using auxilary buffers when an astc5x5 texture is present

2018-03-16 Thread Tapani Pälli
From: Kevin Rogovin If ASTC5x5 textures are present, resolve all textures that the sampler accesses so that auxilary buffer is unneeded when the astc5x5 workaround is needed and also program the sampler state to not use the auxilary buffer as well. v2: call gen9_set_astc5x5_wa_mode directly in b

[Mesa-dev] [PATCH v2 0/7] radv: add support for the new subgroup capabilities

2018-03-16 Thread Daniel Schürmann
Second version of the series: - removed GroupNonUniformArithmetic from supported capabilites as we cannot guarantee that LLVM WWM liveness issues won't affect the behavior. - reworked and moved lowering of 64bit shuffle intrinsics to nir_lower_subgroups. - Quad shuffles use ds_swizzle on pre-VI h

[Mesa-dev] [PATCH v2 3/7] nir: lower 64bit subgroup shuffle intrinsics

2018-03-16 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_subgroups.c | 83 +++--- 2 files changed, 67 insertions(+), 17 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 6a51b7c4ab..0e3

[Mesa-dev] [PATCH v2 6/7] ac: handle subgroup intrinsics

2018-03-16 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/common/ac_nir_to_llvm.c | 66 +++-- 1 file changed, 37 insertions(+), 29 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index b0c0d76b47..403f75e88d 100644 --- a/src/amd/c

[Mesa-dev] [PATCH v2 7/7] radv: enable subgroup capabilities

2018-03-16 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/vulkan/radv_device.c | 10 -- src/amd/vulkan/radv_shader.c | 7 ++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 36ba0c3833..ebc63f2620 100644 --- a/src/am

[Mesa-dev] [PATCH v2 1/7] nir: adjust subgroups instructions for 64bit ballot sizes

2018-03-16 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/compiler/nir/nir_lower_subgroups.c | 5 ++--- src/compiler/nir/nir_opcodes.py| 12 ++-- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/compiler/nir/nir_lower_subgroups.c b/src/compiler/nir/nir_lower_subgroups.c index 0d

[Mesa-dev] [PATCH v2 4/7] ac: make ballot and umsb capable of 64bit inputs

2018-03-16 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/amd/common/ac_llvm_build.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 1ae2b9dd17..67d15d5cb3 100644 --- a/src/amd/common/ac_llv

[Mesa-dev] [PATCH v2 2/7] nir/spirv: propagate constants of GroupNonUniformQuad instructions, eliminate warning and fix breaks

2018-03-16 Thread Daniel Schürmann
Signed-off-by: Daniel Schürmann --- src/compiler/spirv/spirv_to_nir.c | 2 ++ src/compiler/spirv/vtn_subgroup.c | 8 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index f06dca90ef..4454c1aca3 100644 -

[Mesa-dev] [PATCH v2 5/7] ac: add LLVM build functions for subgroup instrinsics

2018-03-16 Thread Daniel Schürmann
Co-authored-by: Connor Abbott Signed-off-by: Daniel Schürmann --- src/amd/common/ac_llvm_build.c | 475 + src/amd/common/ac_llvm_build.h | 33 ++- 2 files changed, 507 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/com

Re: [Mesa-dev] Releasing 18.0

2018-03-16 Thread Michel Dänzer
On 2018-03-15 08:21 PM, Marek Olšák wrote: > On Thu, Mar 15, 2018 at 2:34 PM, Michel Dänzer > wrote: > > On 2018-03-15 07:25 PM, Marek Olšák wrote: > > On Thu, Mar 15, 2018 at 2:19 PM, Michel Dänzer > >

Re: [Mesa-dev] [PATCH v2] i965: prevent using auxilary buffers when an astc5x5 texture is present

2018-03-16 Thread Rogovin, Kevin
Hi, I will just pipe in on the scenario that needs to be checked and ways around the scenario as well. Firstly, What Tapani has below is what I first wrote as well when developing a v4, it is cleaner and from that point of view I prefer it as well. However, the following scenario made me have

Re: [Mesa-dev] [PATCH 03/11] spirv: add vtn_builder_create

2018-03-16 Thread Timothy Arceri
nit: can we rename it vtn_builder_create -> vtn_create_builder with that. Reviewed-by: Timothy Arceri On 08/03/18 19:19, Alejandro Piñeiro wrote: Refactored from spirv_to_nir, in order to be reused later. --- src/compiler/spirv/spirv_to_nir.c | 48 ++- sr

Re: [Mesa-dev] [PATCH 01/11] mesa: add gl_constants::SpirVCapabilities

2018-03-16 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 08/03/18 19:19, Alejandro Piñeiro wrote: From: Nicolai Hähnle For drivers to declare which SPIR-V features they support. v2: Don't use a pointer (Ian Romanick) --- src/mesa/main/mtypes.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/m

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Timothy Arceri
On 08/03/18 19:19, Alejandro Piñeiro wrote: ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a valid entry point for

Re: [Mesa-dev] [PATCH 05/11] mesa: Implement glSpecializeShaderARB

2018-03-16 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 08/03/18 19:19, Alejandro Piñeiro wrote: From: Nicolai Hähnle v2: * Use gl_spirv_validation instead of spirv_to_nir. This method just validates the shader. The conversion to NIR will happen later, during linking. (Alejandro Piñeiro) * Use gl_shade

Re: [Mesa-dev] [PATCH 08/11] mesa/program: Link SPIR-V shaders using the SPIR-V code-path

2018-03-16 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 08/03/18 19:19, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev --- src/mesa/program/ir_to_mesa.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 74089605029

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Alejandro Piñeiro
On 16/03/18 11:47, Timothy Arceri wrote: > On 08/03/18 19:19, Alejandro Piñeiro wrote: > >> ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new >> method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 >>     "Shader Specialization", error table: >> >>   INVALID_VALUE is ge

Re: [Mesa-dev] [PATCH] mesa: RGB9_E5 invalid for CopyTexSubImage* in GLES

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 08:02 +0200, Tapani Pälli wrote: > On 03/15/2018 02:04 PM, Juan A. Suarez Romero wrote: > > According to OpenGL ES 3.2, section 8.6, CopyTexSubImage* should return > > an INVALID_OPERATION if the internalformat of the texture is RGB9_E5. > > > > This fixes > > dEQP-GLES31.fun

[Mesa-dev] [Bug 96955] SSH Account Request for Mesa related development

2018-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96955 Daniel Stone changed: What|Removed |Added QA Contact||mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH v0] nir: mako all the intrinsics

2018-03-16 Thread Rob Clark
I haven't done anything to verify yet, but I was thinking along the same lines of just hacking up a .c program to compare both sets of tables. There are enough intrinsics, that somewhere I probably transcribed one wrong and visual inspection of the tables doesn't seem sane ;-) BR, -R On Fri, Mar

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Rob Clark
Just curious, how much different is this from what spirv-val does? We are going to end up using spirv-tools from clover, so if all of this is just to avoid a dependency on spirv-tools, is it worth it? BR, -R On Thu, Mar 8, 2018 at 3:19 AM, Alejandro Piñeiro wrote: > ARB_gl_spirv adds the abilit

Re: [Mesa-dev] [PATCH] mesa: RGB9_E5 invalid for CopyTexSubImage* in GLES

2018-03-16 Thread Tapani Pälli
On 03/16/2018 01:01 PM, Juan A. Suarez Romero wrote: On Fri, 2018-03-16 at 08:02 +0200, Tapani Pälli wrote: On 03/15/2018 02:04 PM, Juan A. Suarez Romero wrote: According to OpenGL ES 3.2, section 8.6, CopyTexSubImage* should return an INVALID_OPERATION if the internalformat of the texture is

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Timothy Arceri
On 16/03/18 21:58, Alejandro Piñeiro wrote: On 16/03/18 11:47, Timothy Arceri wrote: On 08/03/18 19:19, Alejandro Piñeiro wrote: ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1     "Shader Specialization", error

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Timothy Arceri
On 16/03/18 22:11, Rob Clark wrote: Just curious, how much different is this from what spirv-val does? We are going to end up using spirv-tools from clover, so if all of this is just to avoid a dependency on spirv-tools, is it worth it? It seems like a pretty simple bit of code that mostly re

Re: [Mesa-dev] [PATCH] mesa: RGB9_E5 invalid for CopyTexSubImage* in GLES

2018-03-16 Thread Tapani Pälli
On 03/16/2018 01:13 PM, Tapani Pälli wrote: On 03/16/2018 01:01 PM, Juan A. Suarez Romero wrote: On Fri, 2018-03-16 at 08:02 +0200, Tapani Pälli wrote: On 03/15/2018 02:04 PM, Juan A. Suarez Romero wrote: According to OpenGL ES 3.2, section 8.6, CopyTexSubImage* should return an INVALID_OP

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Alejandro Piñeiro
On 16/03/18 12:11, Rob Clark wrote: > Just curious, how much different is this from what spirv-val does? Well, spirv-val does a full validation of the SPIR-V binary. Here we are just doing the basic validation required by the method glSpecializeShadeARB, introduced by ARB_gl_spirv. That's the rea

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Alejandro Piñeiro
On 16/03/18 12:14, Timothy Arceri wrote: > > > On 16/03/18 21:58, Alejandro Piñeiro wrote: >> On 16/03/18 11:47, Timothy Arceri wrote: >>> On 08/03/18 19:19, Alejandro Piñeiro wrote: >>> ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenG

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Rob Clark
On Fri, Mar 16, 2018 at 7:27 AM, Alejandro Piñeiro wrote: > On 16/03/18 12:11, Rob Clark wrote: >> Just curious, how much different is this from what spirv-val does? > > Well, spirv-val does a full validation of the SPIR-V binary. Here we are > just doing the basic validation required by the metho

[Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 17.3.7 is now available. Currently we have: - 53 queued - 9 nominated (outstanding) - and 6 rejected patches In the current queue we have lot of fixes, as the latest two releases were emergency releases to fix major issues. The i965 receives quite a few

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Alejandro Piñeiro
On 16/03/18 12:39, Rob Clark wrote: > On Fri, Mar 16, 2018 at 7:27 AM, Alejandro Piñeiro > wrote: >> On 16/03/18 12:11, Rob Clark wrote: >>> Just curious, how much different is this from what spirv-val does? >> Well, spirv-val does a full validation of the SPIR-V binary. Here we are >> just doing

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 12:42 +0100, Juan A. Suarez Romero wrote: > Hello list, > > The candidate for the Mesa 17.3.7 is now available. Currently we have: > - 53 queued > - 9 nominated (outstanding) > - and 6 rejected patches > > > In the current queue we have lot of fixes, as the latest two re

Re: [Mesa-dev] [PATCH 0/6] Shader cache; transform feedback; i965 program-binary

2018-03-16 Thread Tapani Pälli
On 03/15/2018 11:07 AM, Tapani Pälli wrote: Patches 1-3: Reviewed-by: Tapani Pälli Make that the whole series! I tested also briefly with app that uses glProgramBinary to implement cache and verified result of GL_LINK_STATUS query with glGetProgramiv after glProgramBinary. (also verif

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
CCing Bas and Anuj. J.A. On Fri, 2018-03-16 at 12:49 +0100, Juan A. Suarez Romero wrote: > On Fri, 2018-03-16 at 12:42 +0100, Juan A. Suarez Romero wrote: > > Hello list, > > > > The candidate for the Mesa 17.3.7 is now available. Currently we have: > > - 53 queued > > - 9 nominated (

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Daniel Stone
Hi Juan, On 16 March 2018 at 11:42, Juan A. Suarez Romero wrote: > Trivial merge conflicts > --- > > [...] > > commit 5fd11359b66c8138d2c7ee29bd9740280b02d1e2 > Author: Daniel Stone > > egl/wayland: Fix ARGB/XRGB transposition in config map > > (cherry picked from com

Re: [Mesa-dev] [PATCH] mesa: RGB9_E5 invalid for CopyTexSubImage* in GLES

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 13:25 +0200, Tapani Pälli wrote: > > On 03/16/2018 01:13 PM, Tapani Pälli wrote: > > > > > > On 03/16/2018 01:01 PM, Juan A. Suarez Romero wrote: > > > On Fri, 2018-03-16 at 08:02 +0200, Tapani Pälli wrote: > > > > On 03/15/2018 02:04 PM, Juan A. Suarez Romero wrote: > > >

[Mesa-dev] [Bug 105551] Unable to compile on FreeBSD 9.x and therefore derivatives... undefined reference to `loader_get_extensions_name'

2018-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105551 Bug ID: 105551 Summary: Unable to compile on FreeBSD 9.x and therefore derivatives... undefined reference to `loader_get_extensions_name' Product: Mesa Version:

Re: [Mesa-dev] [PATCH] mesa: RGB9_E5 invalid for CopyTexSubImage* in GLES

2018-03-16 Thread Tapani Pälli
On 03/16/2018 02:10 PM, Juan A. Suarez Romero wrote: On Fri, 2018-03-16 at 13:25 +0200, Tapani Pälli wrote: On 03/16/2018 01:13 PM, Tapani Pälli wrote: On 03/16/2018 01:01 PM, Juan A. Suarez Romero wrote: On Fri, 2018-03-16 at 08:02 +0200, Tapani Pälli wrote: On 03/15/2018 02:04 PM, Juan

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Alex Smith
Hi Juan, On 16 March 2018 at 11:42, Juan A. Suarez Romero wrote: > Hello list, > > The candidate for the Mesa 17.3.7 is now available. Currently we have: > - 53 queued > - 9 nominated (outstanding) > - and 6 rejected patches > > > In the current queue we have lot of fixes, as the latest two r

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Emil Velikov
On 16 March 2018 at 12:17, Alex Smith wrote: > Hi Juan, > > On 16 March 2018 at 11:42, Juan A. Suarez Romero > wrote: >> >> Hello list, >> >> The candidate for the Mesa 17.3.7 is now available. Currently we have: >> - 53 queued >> - 9 nominated (outstanding) >> - and 6 rejected patches >> >> >

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 12:07 +, Daniel Stone wrote: > Hi Juan, > > On 16 March 2018 at 11:42, Juan A. Suarez Romero wrote: > > Trivial merge conflicts > > --- > > > > [...] > > > > commit 5fd11359b66c8138d2c7ee29bd9740280b02d1e2 > > Author: Daniel Stone > > > > egl/

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Emil Velikov
On 16 March 2018 at 12:07, Daniel Stone wrote: > Hi Juan, > > On 16 March 2018 at 11:42, Juan A. Suarez Romero wrote: >> Trivial merge conflicts >> --- >> >> [...] >> >> commit 5fd11359b66c8138d2c7ee29bd9740280b02d1e2 >> Author: Daniel Stone >> >> egl/wayland: Fix ARGB/XR

Re: [Mesa-dev] [PATCH v0] nir: mako all the intrinsics

2018-03-16 Thread Rob Clark
Ok, I came up with: https://hastebin.com/bulilojupo.cpp if you want to double check my methodology. It spotted a couple small mistakes, which I've fixed up locally. Will resend once I finish autotools build support.. hmm, and I guess there is scons too.. *sigh* Fwiw, one if the bugs was from

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 12:17 +, Alex Smith wrote: > Hi Juan, > > On 16 March 2018 at 11:42, Juan A. Suarez Romero wrote: > > Hello list, > > > > The candidate for the Mesa 17.3.7 is now available. Currently we have: > > - 53 queued > > - 9 nominated (outstanding) > > - and 6 rejected patch

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 12:36 +, Emil Velikov wrote: > On 16 March 2018 at 12:07, Daniel Stone wrote: > > Hi Juan, > > > > On 16 March 2018 at 11:42, Juan A. Suarez Romero > > wrote: > > > Trivial merge conflicts > > > --- > > > > > > [...] > > > > > > commit 5fd11359b66

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 13:40 +0100, Juan A. Suarez Romero wrote: > On Fri, 2018-03-16 at 12:17 +, Alex Smith wrote: > > Hi Juan, > > > > On 16 March 2018 at 11:42, Juan A. Suarez Romero > > wrote: > > > Hello list, > > > > > > The candidate for the Mesa 17.3.7 is now available. Currently we

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Rob Clark
On Fri, Mar 16, 2018 at 7:48 AM, Alejandro Piñeiro wrote: > On 16/03/18 12:39, Rob Clark wrote: >> On Fri, Mar 16, 2018 at 7:27 AM, Alejandro Piñeiro >> wrote: >>> On 16/03/18 12:11, Rob Clark wrote: Just curious, how much different is this from what spirv-val does? >>> Well, spirv-val does

[Mesa-dev] [Bug 104926] swrast: Mesa 17.3.3 produces: HW cursor for format 875713089 not supported

2018-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104926 --- Comment #4 from Stefan Dirsch --- https://lists.freedesktop.org/archives/mesa-dev/2018-March/189030.html -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Alex Smith
On 16 March 2018 at 12:46, Juan A. Suarez Romero wrote: > On Fri, 2018-03-16 at 13:40 +0100, Juan A. Suarez Romero wrote: > > On Fri, 2018-03-16 at 12:17 +, Alex Smith wrote: > > > Hi Juan, > > > > > > On 16 March 2018 at 11:42, Juan A. Suarez Romero > wrote: > > > > Hello list, > > > > > >

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Ilia Mirkin
On Fri, Mar 16, 2018 at 8:40 AM, Juan A. Suarez Romero wrote: > Nominated means that these patches does not enter in this release due they > arrived a bit late, but they are proposed to cherry-pick them for the next > release (in 1 or 2 weeks). > > The reason is that some days before this pre-anno

[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

2018-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105506 Turo Lamminen changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|REOPENED

Re: [Mesa-dev] [PATCH v2] egl/android: Implement the eglSwapinterval for Android.

2018-03-16 Thread Emil Velikov
On 16 March 2018 at 08:51, Wu, Zhongmin wrote: > Thanks very much Tomasz. > > So, who can help to commit such patch. > Fixed with s/dpy/disp/ (otherwise it won't even build) and pushed. Please go through the patches list and update it. I believe that all of those are superseded, do check them ove

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

2018-03-16 Thread Ian Romanick
On 03/16/2018 01:58 AM, Timothy Arceri wrote: > > > On 16/03/18 19:34, Samuel Pitoiset wrote: >> >> >> On 03/16/2018 09:15 AM, Timothy Arceri wrote: >>> On 16/03/18 18:45, Samuel Pitoiset wrote: shader stats? >>> >>> I didn't bother posting them because they are misleading. There are a >>> f

Re: [Mesa-dev] [PATCH] nir: add some comparison simplifications

2018-03-16 Thread Ian Romanick
I have basically the same patch setting in my simple-range-analysis tree. https://cgit.freedesktop.org/~idr/mesa/commit/?h=simple-range-analysis&id=e9d29d71304347f8ff904294450a398e5838f49a As Jason mentions, you don't need to explicitly mention the compares. You don't need the @bool either... the

[Mesa-dev] [Bug 96955] SSH Account Request for Mesa related development

2018-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96955 --- Comment #3 from Brian Paul --- It looks like Gwan-gyeong has authored nearly 30 patches in Mesa in 2016-17. OK be me, Daniel. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

Re: [Mesa-dev] [PATCH] st/dri: don't set queryDmaBufFormats/queryDmaBufModifiers if the driver does not implement it

2018-03-16 Thread Emil Velikov
Cc-ing the author of the 'offending' commit - Nicolai On 15 March 2018 at 16:27, Michal Srb wrote: > This is equivalent to commit a65db0ad1c3, but for dri_kms_init_screen. Without > this gbm_dri_is_format_supported always returns false. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=1

Re: [Mesa-dev] [PATCH] loader: Include include/drm-uapi in the autotools build

2018-03-16 Thread Emil Velikov
On 15 March 2018 at 21:29, Jason Ekstrand wrote: > We're already including it in the meson build. This fixes build issues > on systems which have a drm_fourcc.h that doesn't have modifiers. > --- > src/loader/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/loader/Makefil

[Mesa-dev] [PATCH 0/2] i965: reduce driver binary size through metrics code reuse

2018-03-16 Thread Lionel Landwerlin
Hi, Here is a v2 with a fixup commit from Emil. I've also fix another issue related to hashing of normalization equations. Cheers, Lionel Landwerlin (2): i965: perf: fix a counter return type on hsw i965: perf: reduce i965 binary size src/mesa/drivers/dri/i965/Android.mk | 11

[Mesa-dev] [PATCH 1/2] i965: perf: fix a counter return type on hsw

2018-03-16 Thread Lionel Landwerlin
The equation code computes a float (percentage) yet the return type was an uint64_t. Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_oa_hsw.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_oa_hsw.xml b/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 2/2] i965: perf: reduce i965 binary size

2018-03-16 Thread Lionel Landwerlin
Performance metric numbers are calculated the following way : - out of the 256 bytes long OA reports, we accumulate the deltas into an array of uint64_t - the equations' generated code reads the accumulated uint64_t deltas and normalizes them for a particular platforms Our hardwa

Re: [Mesa-dev] [PATCH 2/2] i965: perf: reduce i965 binary size

2018-03-16 Thread Lionel Landwerlin
On 16/03/18 15:03, Lionel Landwerlin wrote: Here are the savings in a meson build : Before : $ du -h ./build/src/mesa/drivers/dri/libmesa_dri_drivers.so ./build/src/mesa/drivers/dri/libmesa_dri_drivers.so.old 43M ./build/src/mesa/drivers/dri/libmesa_dri_drivers.so 47M ./build/src/me

Re: [Mesa-dev] [PATCH 0/3] Meson patches for FreeBSD

2018-03-16 Thread Emil Velikov
On 16 March 2018 at 02:39, Matt Turner wrote: > On Tue, Mar 6, 2018 at 11:16 AM, Greg V wrote: >> Hi! Here's a few more patches that let me successfully build, package >> and install fully working Meson-built Mesa-git on my FreeBSD box. >> >> Greg V (3): >> meson: Use system_has_kms_drm in defa

[Mesa-dev] [Bug 96955] SSH Account Request for Mesa related development

2018-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96955 Daniel Stone changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v0] nir: mako all the intrinsics

2018-03-16 Thread Emil Velikov
On 16 March 2018 at 12:41, Rob Clark wrote: > Ok, I came up with: > > https://hastebin.com/bulilojupo.cpp > > if you want to double check my methodology. > > It spotted a couple small mistakes, which I've fixed up locally. Will > resend once I finish autotools build support.. hmm, and I guess t

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 13:27 +, Alex Smith wrote: > On 16 March 2018 at 12:46, Juan A. Suarez Romero wrote: > > On Fri, 2018-03-16 at 13:40 +0100, Juan A. Suarez Romero wrote: > > > On Fri, 2018-03-16 at 12:17 +, Alex Smith wrote: > > > > Hi Juan, > > > > > > > > On 16 March 2018 at 11:42,

Re: [Mesa-dev] [PATCH] nir: add some comparison simplifications

2018-03-16 Thread Ian Romanick
On 03/16/2018 07:37 AM, Ian Romanick wrote: > I have basically the same patch setting in my simple-range-analysis tree. > > https://cgit.freedesktop.org/~idr/mesa/commit/?h=simple-range-analysis&id=e9d29d71304347f8ff904294450a398e5838f49a > > As Jason mentions, you don't need to explicitly mentio

Re: [Mesa-dev] [PATCH 0/3] Meson patches for FreeBSD

2018-03-16 Thread Matt Turner
On Fri, Mar 16, 2018 at 8:07 AM, Emil Velikov wrote: > On 16 March 2018 at 02:39, Matt Turner wrote: >> On Tue, Mar 6, 2018 at 11:16 AM, Greg V wrote: >>> Hi! Here's a few more patches that let me successfully build, package >>> and install fully working Meson-built Mesa-git on my FreeBSD box. >

Re: [Mesa-dev] [PATCH v2 8/8] i965: add performance query support on CNL

2018-03-16 Thread Emil Velikov
On 14 March 2018 at 17:19, Lionel Landwerlin wrote: > v2: Add brw_oa_cnl.xml to EXTRA_DIST (Emil) > > Signed-off-by: Lionel Landwerlin > --- This and 4/8 are Reviewed-by: Emil Velikov It will cause some trivial conflicts with your other patch in the area. FWIW I'd recommend landing that work fi

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Ilia Mirkin
On Fri, Mar 16, 2018 at 11:27 AM, Juan A. Suarez Romero wrote: > On Fri, 2018-03-16 at 09:51 -0400, Ilia Mirkin wrote: >> On Fri, Mar 16, 2018 at 8:40 AM, Juan A. Suarez Romero >> wrote: >> > Nominated means that these patches does not enter in this release due they >> > arrived a bit late, but t

Re: [Mesa-dev] [PATCH 0/3] Meson patches for FreeBSD

2018-03-16 Thread Daniel Stone
Hi, On 16 March 2018 at 15:23, Matt Turner wrote: > On Fri, Mar 16, 2018 at 8:07 AM, Emil Velikov > wrote: >> On 16 March 2018 at 02:39, Matt Turner wrote: >>> All of your messages are going to spam on gmail: >>> >> Setting up a filter for 'list:"mesa-dev.lists.freedesktop.org"' will help >>

Re: [Mesa-dev] [PATCH v0] nir: mako all the intrinsics

2018-03-16 Thread Rob Clark
On Fri, Mar 16, 2018 at 11:18 AM, Emil Velikov wrote: > On 16 March 2018 at 12:41, Rob Clark wrote: >> Ok, I came up with: >> >> https://hastebin.com/bulilojupo.cpp >> >> if you want to double check my methodology. >> >> It spotted a couple small mistakes, which I've fixed up locally. Will >>

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 11:38 -0400, Ilia Mirkin wrote: > On Fri, Mar 16, 2018 at 11:27 AM, Juan A. Suarez Romero > wrote: > > On Fri, 2018-03-16 at 09:51 -0400, Ilia Mirkin wrote: > > > On Fri, Mar 16, 2018 at 8:40 AM, Juan A. Suarez Romero > > > wrote: > > > > Nominated means that these patches d

[Mesa-dev] [PATCH mesa 2/3] egl: align the formatting of Haiku section of eglplatform.h with Khronos'

2018-03-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- include/EGL/eglplatform.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/include/EGL/eglplatform.h b/include/EGL/eglplatform.h index 8a78a9eaddd2f47ff2c0..b0541d52aed6584c63f2 100644 --- a/include/EGL/eglplatform.h +++ b/include/EG

[Mesa-dev] [PATCH mesa 1/3] egl: add Ozone section to eglplatform.h

2018-03-16 Thread Eric Engestrom
This pulls in commit a93f559e9c11fa53fb5f1cc255b8f75433f85d2a "Add Ozone section to eglplatform.h" from Khronos [1] added by Brian Anderson [2] a few months ago. [1] https://github.com/KhronosGroup/EGL-Registry/commit/a93f559e9c11fa53fb5f1cc255b8f75433f85d2a [2] https://github.com/KhronosGroup/EG

[Mesa-dev] [PATCH mesa 3/3] egl: pull update from Khronos and drop local define

2018-03-16 Thread Eric Engestrom
Added in Khronos in 2b6bb4ee45cc46c89d4a "EGL_MESA_drm_image: add EGL_DRM_BUFFER_USE_CURSOR_MESA to egl.xml" [1] as part of PR #36 [2]. [1] https://github.com/KhronosGroup/EGL-Registry/commit/2b6bb4ee45cc46c89d4a4349f2ca94e80d77cd97 [2] https://github.com/KhronosGroup/EGL-Registry/pull/36 Signed

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 09:51 -0400, Ilia Mirkin wrote: > On Fri, Mar 16, 2018 at 8:40 AM, Juan A. Suarez Romero > wrote: > > Nominated means that these patches does not enter in this release due they > > arrived a bit late, but they are proposed to cherry-pick them for the next > > release (in 1 or

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Ilia Mirkin
On Fri, Mar 16, 2018 at 11:52 AM, Juan A. Suarez Romero wrote: > On Fri, 2018-03-16 at 11:38 -0400, Ilia Mirkin wrote: >> On Fri, Mar 16, 2018 at 11:27 AM, Juan A. Suarez Romero >> wrote: >> > On Fri, 2018-03-16 at 09:51 -0400, Ilia Mirkin wrote: >> > > On Fri, Mar 16, 2018 at 8:40 AM, Juan A. Su

Re: [Mesa-dev] [PATCH v2 2/7] nir/spirv: propagate constants of GroupNonUniformQuad instructions, eliminate warning and fix breaks

2018-03-16 Thread Jason Ekstrand
On Fri, Mar 16, 2018 at 2:50 AM, Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > Signed-off-by: Daniel Schürmann > --- > src/compiler/spirv/spirv_to_nir.c | 2 ++ > src/compiler/spirv/vtn_subgroup.c | 8 ++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --gi

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Juan A. Suarez Romero
On Fri, 2018-03-16 at 12:03 -0400, Ilia Mirkin wrote: > On Fri, Mar 16, 2018 at 11:52 AM, Juan A. Suarez Romero > wrote: > > On Fri, 2018-03-16 at 11:38 -0400, Ilia Mirkin wrote: > > > On Fri, Mar 16, 2018 at 11:27 AM, Juan A. Suarez Romero > > > wrote: > > > > On Fri, 2018-03-16 at 09:51 -0400,

[Mesa-dev] [Bug 105232] piglit regressions and crashes from gbm alpha masks

2018-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105232 --- Comment #2 from Daniel Stone --- (In reply to Ilia Mirkin from comment #1) > Theory: The tests didn't run prior to this commit because of the format > matching fail, since the original commit that broke argb8 formats, > 2ed344645d65. They ha

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Gert Wollny
Am Freitag, den 16.03.2018, 12:42 +0100 schrieb Juan A. Suarez Romero: > > Gert Wollny (1): > c7cadcbda4 r600: Take ALU_EXTENDED into account when evaluating > jump offsets > Reason: The commit requires earlier commit a03d456f5a41 which did not > land in branch. This seems to be odd, a03d456

Re: [Mesa-dev] [PATCH v2 3/7] nir: lower 64bit subgroup shuffle intrinsics

2018-03-16 Thread Jason Ekstrand
On Fri, Mar 16, 2018 at 2:50 AM, Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > Signed-off-by: Daniel Schürmann > --- > src/compiler/nir/nir.h | 1 + > src/compiler/nir/nir_lower_subgroups.c | 83 > +++--- > 2 files changed, 67 ins

[Mesa-dev] [Bug 105208] [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell

2018-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105208 Yanko Kaneti changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Mark Janes
"Juan A. Suarez Romero" writes: > On Fri, 2018-03-16 at 12:03 -0400, Ilia Mirkin wrote: >> On Fri, Mar 16, 2018 at 11:52 AM, Juan A. Suarez Romero >> wrote: >> > On Fri, 2018-03-16 at 11:38 -0400, Ilia Mirkin wrote: >> > > On Fri, Mar 16, 2018 at 11:27 AM, Juan A. Suarez Romero >> > > wrote: >>

Re: [Mesa-dev] [PATCH 0/6] Shader cache; transform feedback; i965 program-binary

2018-03-16 Thread Jordan Justen
On 2018-03-16 04:52:55, Tapani Pälli wrote: > > > On 03/15/2018 11:07 AM, Tapani Pälli wrote: > > Patches 1-3: > > Reviewed-by: Tapani Pälli > > Make that the whole series! Thanks! > I tested also briefly with app that uses glProgramBinary to implement > cache and verified result of GL_LINK_

  1   2   >