Hi,
For those interested, I made a version of the series that does not change
intel_miptree_texture_aux_usage(), but instead restores the disable_aux
argument to intel_miptree_prepare_texture() and uses that. What I do not like
is that it forced one to have several little things tweaked here a
Hi,
On 13.02.2018 03:26, Dongwon Kim wrote:
extraction of linked binary program to a file using glGetProgramBinary.
This file is intended to be loaded by glProgramBinary in the graphic
application running on the target system.
A new option, '--out=' is available to be used for specifying
the ou
On Sunday, February 11, 2018 6:26:39 PM PST Gustavo Lima Chaves wrote:
> I've been seeking to add this extension support on my free time and
> have now come to a point where some input could really help.
Hi Gustavo!
Welcome to the Mesa community :) Thanks for taking a shot at this!
> At vtn_get
On Sunday, February 11, 2018 6:26:41 PM PST Gustavo Lima Chaves wrote:
> ---
> src/intel/vulkan/anv_extensions.py | 1 +
> src/intel/vulkan/anv_pipeline.c| 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_extensions.py
> b/src/intel/vulkan/anv_extensions.py
> ind
https://bugs.freedesktop.org/show_bug.cgi?id=103142
Gert Wollny changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
On Saturday, February 3, 2018 1:58:58 PM PST Jordan Justen wrote:
> Signed-off-by: Jordan Justen
> Reviewed-by: Timothy Arceri
> ---
> docs/relnotes/18.1.0.html | 1 +
> src/mesa/drivers/dri/i965/brw_disk_cache.c | 3 ---
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> di
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index c7b07e16f8..4ec697aee4 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src
Although meta shaders don't use any vertex buffers, there is no
behaviour change but I think it's better to do this. Though,
this saves two user SGPRs for push constants inlining or
something else.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_shader_info.c | 12 +++-
1 file chang
Hi,
On 13 February 2018 at 22:15, Jason Ekstrand wrote:
> On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone wrote:
>> On 9 February 2018 at 23:43, Jason Ekstrand wrote:
>> For actual scanout, the kernel very specifically demands that if the
>> BO is X-tiled, then set_tiling be called with TILING_X
https://bugs.freedesktop.org/show_bug.cgi?id=105090
Bug ID: 105090
Summary: shader compilation leaks glsl_type instances
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: normal
https://bugs.freedesktop.org/show_bug.cgi?id=105090
Tapani Pälli changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=105090
--- Comment #2 from Simon Hausmann ---
Ah yes, bug #104884 is exactly what I'm looking for - I came to the same
conclusion.
--
You are receiving this mail because:
You are the assignee for the bug.__
We were only resolving the first.
Fixes new CTS tests for multisampled layered rendering:
dEQP-VK.renderpass.multisample_resolve.layers_*
---
src/intel/vulkan/anv_blorp.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp
Hi,
On 13 February 2018 at 22:29, Jason Ekstrand wrote:
> On Tue, Feb 13, 2018 at 10:55 AM, Daniel Stone wrote:
>> > + uint64_t modifiers[] = {
>> > + DRM_FORMAT_MOD_LINEAR,
>> > + I915_FORMAT_MOD_X_TILED,
>> > + I915_FORMAT_MOD_Y_TILED,
>> > + I915_FORMAT_MOD_Y_TILED_CCS,
On Tuesday, 2018-02-13 16:31:20 -0800, Keith Packard wrote:
> This extension adds the ability to borrow an X RandR output for
> temporary use directly by a Vulkan application. For DRM, we use the
> Linux resource leasing mechanism.
>
> Signed-off-by: Keith Packard
> ---
> configure.ac
From: Brendan King
Don't assume the screen supports OpenGL when creating a new context,
use an API that the screen supports.
Signed-off-by: Brendan King
Reviewed-by: Eric Engestrom
[Eric: rebased on current git HEAD]
Signed-off-by: Eric Engestrom
---
src/mesa/drivers/dri/common/dri_util.c |
Fixes: db5f4221696a
(i965: fix tessellation regressions with gl_state_index16)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105088
Signed-off-by: Andriy Khulap
Signed-off-by: Vadym Shovkoplias
---
src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 3 ++-
1 file changed, 2 insertio
Same fix was sent by Jason earlier :) See:
https://lists.freedesktop.org/archives/mesa-dev/2018-February/185446.html
On 14.02.2018 15:37, Andriy Khulap wrote:
Fixes: db5f4221696a
(i965: fix tessellation regressions with gl_state_index16)
Bugzilla: https://bugs.freedesktop.org/show_bug.c
Sorry for duplicate, but I've searched the mail thread for bug-id to check
if this one is already fixed. So missed it.
*Andriy Khulap | Software Engineer*
P +380.57.766.7667 M +380.67.607.2780 S a.khulap
www.globallogic.com
http://www.globallogic.com/email_disclaimer.txt
On Wed, Feb 14, 2018 at 3
On 9 February 2018 at 16:02, Daniel Stone wrote:
> Hi Emil,
>
> On 8 February 2018 at 21:56, Emil Velikov wrote:
>> On 8 February 2018 at 14:05, Daniel Stone wrote:
>>> Extend the visual map from only containing names and bitmasks, to also
>>> carrying the three format enums we need. These are t
On Wed, Feb 14, 2018 at 7:57 AM, Kenneth Graunke wrote:
> On Tuesday, February 13, 2018 2:57:07 PM PST Jason Ekstrand wrote:
>> This fixes the build in clang
>> ---
>> src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/
On Feb 14, 2018 7:38 AM, "Eric Engestrom" wrote:
From: Brendan King
Don't assume the screen supports OpenGL when creating a new context,
use an API that the screen supports.
Signed-off-by: Brendan King
Reviewed-by: Eric Engestrom
[Eric: rebased on current git HEAD]
Signed-off-by: Eric Engest
It makes no sense to compact before, and the description of
nir_compact_varyings() confirms that.
Polaris10:
Totals from affected shaders:
SGPRS: 106000 -> 105600 (-0.38 %)
VGPRS: 70704 -> 70640 (-0.09 %)
Spilled SGPRs: 892 -> 878 (-1.57 %)
Code Size: 2826240 -> 2812476 (-0.49 %) bytes
Max Waves:
Reviewed-by: Bas Nieuwenhuizen
On Wed, Feb 14, 2018 at 12:03 PM, Samuel Pitoiset wrote:
> Although meta shaders don't use any vertex buffers, there is no
> behaviour change but I think it's better to do this. Though,
> this saves two user SGPRs for push constants inlining or
> something else.
>
On Wed, Feb 14, 2018 at 11:58 AM, Samuel Pitoiset wrote:
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_nir_to_llvm.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_
> llvm.c
> index c7
Fixes: db5f4221696a
(i965: fix tessellation regressions with gl_state_index16)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105088
Signed-off-by: Andriy Khulap
Signed-off-by: Vadym Shovkoplias
---
src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 3 ++-
1 file changed, 2 insertio
On 14 February 2018 at 11:39, Daniel Stone wrote:
> On 13 February 2018 at 22:15, Jason Ekstrand wrote:
>> On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone wrote:
>>> On 9 February 2018 at 23:43, Jason Ekstrand wrote:
>>> For actual scanout, the kernel very specifically demands that if the
>>> BO
Am Mittwoch, den 14.02.2018, 17:18 +1000 schrieb Dave Airlie:
> From: Dave Airlie
>
> A bunch of CTS tests led me to write
> tests/shaders/ssa/fs-while-loop-rotate-value.shader_test
> which r600/sb always fell over on.
>
> This patch fixes it, but I'll probably never be 100% sure why.
Unfortuna
On Wed, Feb 14, 2018 at 1:18 AM, Kenneth Graunke
wrote:
> On Sunday, February 11, 2018 6:26:41 PM PST Gustavo Lima Chaves wrote:
> > ---
> > src/intel/vulkan/anv_extensions.py | 1 +
> > src/intel/vulkan/anv_pipeline.c| 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/src/intel
On Wed, Feb 14, 2018 at 4:13 AM, Daniel Stone wrote:
> Hi,
>
> On 13 February 2018 at 22:29, Jason Ekstrand wrote:
> > On Tue, Feb 13, 2018 at 10:55 AM, Daniel Stone
> wrote:
> >> > + uint64_t modifiers[] = {
> >> > + DRM_FORMAT_MOD_LINEAR,
> >> > + I915_FORMAT_MOD_X_TILED,
> >> > +
On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone wrote:
> Hi,
>
> On 13 February 2018 at 22:15, Jason Ekstrand wrote:
> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone
> wrote:
> >> On 9 February 2018 at 23:43, Jason Ekstrand
> wrote:
> >> For actual scanout, the kernel very specifically demands
On Tue, Feb 13, 2018 at 11:06 PM, Kenneth Graunke
wrote:
> On Monday, February 12, 2018 7:35:05 PM PST Jason Ekstrand wrote:
> > ---
> > src/intel/vulkan/genX_pipeline.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vu
Reviewed-by: Jason Ekstrand
On Sun, Feb 11, 2018 at 6:26 PM, Gustavo Lima Chaves <
gustavo.lima.cha...@intel.com> wrote:
> ---
> src/compiler/shader_info.h | 1 +
> src/compiler/spirv/spirv_to_nir.c | 4
> src/compiler/spirv/vtn_variables.c | 4
> 3 files changed, 9 insertion
On 14 February 2018 at 16:21, Jason Ekstrand wrote:
> On Wed, Feb 14, 2018 at 4:13 AM, Daniel Stone wrote:
>> Suggested fixup: https://hastebin.com/zaheyoriwa
>>
>> This makes sure we only try to allocate with modifiers when _both_
>> winsys and driver support it.
>
> Ok, we clearly have differen
On 14 February 2018 at 16:27, Jason Ekstrand wrote:
> On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone wrote:
>> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone
>> > wrote:
>> >> For actual scanout, the kernel very specifically demands that if the
>> >> BO is X-tiled, then set_tiling be called wi
This was quite wrong.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_shader_info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/common/ac_shader_info.c b/src/amd/common/ac_shader_info.c
index 3b0887995d..2708f6a9c0 100644
--- a/src/amd/common/ac_shader_info.c
In theory this might lead to corruption if we bind a descriptor
set which is unused, because LLVM is smart and it can re-use
unused user SGPRs. In practice, this doesn't seem to fix
anything.
As a side effect, this will reduce the number of emitted
SH_REG packets.
Signed-off-by: Samuel Pitoiset
On Wed, Feb 14, 2018 at 8:43 AM, Daniel Stone wrote:
> On 14 February 2018 at 16:27, Jason Ekstrand wrote:
> > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone
> wrote:
> >> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone
> wrote:
> >> >> For actual scanout, the kernel very specifically demands
On 14 February 2018 at 17:23, Jason Ekstrand wrote:
> On Wed, Feb 14, 2018 at 8:43 AM, Daniel Stone wrote:
>> Linear is unchanged as it's implicit. X tiling has to take the
>> workaround, in case anyone wants to display it.
>
> I'm not sure I buy that. From a userspace perspective, you shouldn't
Reviewed-by: Marek Olšák
Marek
On Wed, Feb 14, 2018 at 7:29 AM, Timothy Arceri wrote:
> ---
> src/amd/common/ac_nir_to_llvm.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 8d1eed241f..a0c5680205
Reviewed-by: Marek Olšák
Marek
On Mon, Feb 12, 2018 at 11:35 PM, Timothy Arceri wrote:
> Fixes cts test:
> KHR-GL46.shader_ballot_tests.ShaderBallotFunctionBallot
> ---
> src/gallium/drivers/radeonsi/si_shader_nir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/g
Reviewed-by: Marek Olšák
Marek
On Wed, Feb 14, 2018 at 7:29 AM, Timothy Arceri wrote:
> Fixes glsl-1.30/execution/isinf-and-isnan* piglit tests for
> radeonsi and should fix SPIRV errors when LLVM optimises away
> the workarounds in vtn_handle_alu() for handling ordered
> comparisons.
>
> Bugzi
Reviewed-by: Marek Olšák
Marek
On Mon, Feb 12, 2018 at 11:43 PM, Timothy Arceri wrote:
> Fixes cts test:
> KHR-GL44.shader_image_size.advanced-changeSize
> ---
> src/amd/common/ac_nir_to_llvm.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/src/amd/common/a
Reviewed-by: Marek Olšák
Marek
On Tue, Feb 13, 2018 at 7:01 AM, Timothy Arceri wrote:
> Fixes cts test:
> KHR-GL45.shader_texture_image_samples_tests.image_functional_test
> ---
> src/amd/common/ac_nir_to_llvm.c | 23 +++
> 1 file changed, 23 insertions(+)
>
> diff --git a/
Reviewed-by: Marek Olšák
Marek
On Wed, Feb 14, 2018 at 2:22 AM, Timothy Arceri wrote:
> We were incorrectly using the input info for outputs.
> ---
> src/gallium/drivers/radeonsi/si_shader.c | 13 +++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/dri
On Wed, Feb 14, 2018 at 04:43:15PM +, Daniel Stone wrote:
> On 14 February 2018 at 16:27, Jason Ekstrand wrote:
> > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone wrote:
> >> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone
> >> > wrote:
> >> >> For actual scanout, the kernel very specifical
For the series:
Reviewed-by: Marek Olšák
Marek
On Tue, Feb 13, 2018 at 4:27 AM, Timothy Arceri wrote:
> ---
> src/mesa/state_tracker/st_context.c | 15 +--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_context.c
> b/src/mesa/state_t
On Wed, Feb 14, 2018 at 9:42 AM, Ville Syrjälä <
ville.syrj...@linux.intel.com> wrote:
> On Wed, Feb 14, 2018 at 04:43:15PM +, Daniel Stone wrote:
> > On 14 February 2018 at 16:27, Jason Ekstrand
> wrote:
> > > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone
> wrote:
> > >> > On Tue, Feb 13, 2
On Wed, Feb 14, 2018 at 8:35 AM, Daniel Stone wrote:
> On 14 February 2018 at 16:21, Jason Ekstrand wrote:
> > On Wed, Feb 14, 2018 at 4:13 AM, Daniel Stone
> wrote:
> >> Suggested fixup: https://hastebin.com/zaheyoriwa
> >>
> >> This makes sure we only try to allocate with modifiers when _both
On Wednesday, February 14, 2018 8:28:54 AM PST Jason Ekstrand wrote:
> On Tue, Feb 13, 2018 at 11:06 PM, Kenneth Graunke
> wrote:
>
> > On Monday, February 12, 2018 7:35:05 PM PST Jason Ekstrand wrote:
> > > ---
> > > src/intel/vulkan/genX_pipeline.c | 2 +-
> > > 1 file changed, 1 insertion(+),
On 14 February 2018 at 17:58, Jason Ekstrand wrote:
> I've added the following to the top of wsi_create_native_image:
>
> + /* If we don't support modifiers, the winsys code shouldn't be asking
> for
> +* an image with modifiers.
> +*/
> + assert(wsi->supports_modifiers || num_modifier
On Wednesday, February 14, 2018 6:05:22 AM PST Marek Olšák wrote:
> On Wed, Feb 14, 2018 at 7:57 AM, Kenneth Graunke
> wrote:
> > On Tuesday, February 13, 2018 2:57:07 PM PST Jason Ekstrand wrote:
> >> This fixes the build in clang
> >> ---
> >> src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 3
On Wed, Feb 14, 2018 at 10:12 AM, Kenneth Graunke
wrote:
> On Wednesday, February 14, 2018 6:05:22 AM PST Marek Olšák wrote:
> > On Wed, Feb 14, 2018 at 7:57 AM, Kenneth Graunke
> wrote:
> > > On Tuesday, February 13, 2018 2:57:07 PM PST Jason Ekstrand wrote:
> > >> This fixes the build in clang
On Wednesday, February 14, 2018 10:17:07 AM PST Jason Ekstrand wrote:
> On Wed, Feb 14, 2018 at 10:12 AM, Kenneth Graunke
> wrote:
>
> > On Wednesday, February 14, 2018 6:05:22 AM PST Marek Olšák wrote:
> > > On Wed, Feb 14, 2018 at 7:57 AM, Kenneth Graunke
> > wrote:
> > > > On Tuesday, Februar
https://bugs.freedesktop.org/show_bug.cgi?id=105098
Bug ID: 105098
Summary: [RADV] GPU freeze with simple Vulkan App
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity
Cc: mesa-sta...@lists.freedesktop.org
---
src/intel/isl/isl.c | 20
src/intel/isl/isl.h | 3 +++
2 files changed, 23 insertions(+)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 59f512f..f4b0502 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -269
---
src/intel/vulkan/genX_cmd_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 8b1816a..a16b742 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -33
Cannonlake hardware adds a new resolve type in 3DSTATE_PS called
FAST_CLEAR_0 which does an ambiguate. Now that the hardware can do it
directly, we should use that instead of binding the CCS as a render
target and doing it manually. This was tested with a full Vulkan CTS
run on Cannonlake.
---
s
This is another version of my patch series to rework subpass clears and
transitions. It's fairly similar to the other one I sent out except that
it's been rebased on top of the resolve reworks and has some fixes from
Nanley. There are also two patches on the front side to remove some
potential no
Previously, we just used all the channels regardless of the format.
This is less than ideal because some channels may have undefined values
and this should be ok from the client's perspective. Even though the
driver should do the correct thing regardless of what is in the
undefined value, it makes
This seems slightly more correct because it means that the flushes
happen before any clears or resolves implied by the subpass transition.
Reviewed-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/vulkan
This doesn't really change much now but it will give us more/better
control over clears in the future. The one interesting functional
change here is that we are now re-emitting 3DSTATE_DEPTH_BUFFERS and
friends for each clear. However, this only happens at begin_subpass
time so it shouldn't be su
---
src/intel/vulkan/anv_blorp.c | 242 -
src/intel/vulkan/anv_private.h | 17 ++-
src/intel/vulkan/genX_cmd_buffer.c | 68 ++-
3 files changed, 186 insertions(+), 141 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan
This unifies things a bit because we now handle depth and stencil at the
same time.
Reviewed-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 78 --
1 file changed, 33 insertions(+), 45 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/
This moves the decision out of begin_subpass and into BeginRenderPass
like the decision for color clears. We use a similar name for the
function for depth/stencil as for color even though no aux usage is
really getting computed.
v2 (Jason Ekstrand):
- Don't always disable HiZ clears by accident
These are the same as pending clear aspects only for the "load"
operation.
Reviewed-by: Nanley Chery
---
src/intel/vulkan/anv_private.h | 1 +
src/intel/vulkan/genX_cmd_buffer.c | 22 --
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/src/intel/vulkan/anv
Having begin/end_subpass is a bit nicer than the begin/next/end hooks
that Vulkan gives us.
Reviewed-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 55 +-
1 file changed, 31 insertions(+), 24 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buff
This is quite a bit cleaner because we now sync the clear values at the
same time as we do the fast clear. For loading the clear values into
the surface state, we now do it once when we handle the LOAD_OP_LOAD
instead of every subpass.
---
src/intel/vulkan/genX_cmd_buffer.c | 148
This is a bit less awkward than passing in the subpass because it means
we don't have to extract the subpass id from the subpass.
Reviewed-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/intel/vulkan/gen
Reviewed-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 50 ++
1 file changed, 29 insertions(+), 21 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 793f590..310c01f 100644
--- a/src/intel/vulk
This is similar to blorp_gen8_hiz_clear_attachments except that it takes
actual images instead of trusting in the already set depth state.
Reviewed-by: Nanley Chery
---
src/intel/blorp/blorp.h | 11 +
src/intel/blorp/blorp_clear.c | 53 +++
2
Previously, we would always apply the layout transition at the beginning
of the subpass and then do the clear whether fast or slow. This meant
that there were some cases, specifically when the initial layout is
VK_IMAGE_LAYOUT_UNDEFINED, where we would end up doing a fast-clear or
ambiguate follow
Reviewed-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 220 +++--
1 file changed, 88 insertions(+), 132 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 310c01f..7f06441 100644
--- a/src/intel/vul
This requires us to ditch the VkAttachmentReference struct in favor of
an anv-specific struct. However, we can now easily identify from just
the subpass attachment what kind of an attachment it is. This will make
iteration over anv_subpass::attachments a little easier in some case.
Reviewed-by:
This fixes a few Piglit transform feedback regressions caused by
commit 7a1401938b351.
In that change I moved the moved svga_update_state() into the loops,
after the calls to svga_hwtnl_set_flatshade(). But
svga_hwtnl_set_flatshade() actually depends on some derived shader
state. This patch move
If we fail to compile the normal VS or FS we fall back to a simple/
dummy shader. We need to rescan the the shader to update the shader
info. Otherwise, this can lead to further translations failures
because the shader info doesn't match the actual shader.
Found by adding some extra debug assert
Move the calls to svga_hwtnl_set_fillmode() and svga_hwtnl_set_flatshade()
out of the two retry_draw_*() functions to the svga_draw_vbo() function.
---
src/gallium/drivers/svga/svga_pipe_draw.c | 30 ++
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/src
https://bugs.freedesktop.org/show_bug.cgi?id=105098
Bas Nieuwenhuizen changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #1 from Bas Ni
This series implements version 7 of the EXT_shader_framebuffer_fetch
specification, which includes a number of changes I had originally
planned for a MESA extension but which ended up queued for inclusion
into an EXT extension after months-long discussion with several
Khronos members. The most imp
---
src/mesa/main/barrier.c | 17 +++--
src/mesa/main/barrier.h | 3 +++
src/mesa/main/tests/dispatch_sanity.cpp | 6 ++
3 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/barrier.c b/src/mesa/main/barrier.c
index 0f0b0a2
This requires passing an extra argument to the lowering pass because
the KHR_blend_equation_advanced specification doesn't seem to define
any mechanism for the implementation to determine at compile-time
whether coherent blending can ever be used (not even an "#extension
KHR_blend_equation_advanced
This reverts two bogus and seemingly useless changes from the commits
referenced below, which broke KHR_blend_equation_advanced (and
EXT_shader_framebuffer_fetch_non_coherent which wasn't exposed yet)
for any kind of render target surface that would cause the
get_isl_surf() call in brw_emit_surface
This can be used to specify that a C++ conversion operator is not
meant to be used for implicit conversions, which can lead to
unintended loss of information in some cases. Implemented as a macro
in order to keep old GCC versions happy.
---
src/util/macros.h | 10 ++
1 file changed, 10 in
Desktop GL is now supported, and there is an additional entry-point
for EXT_shader_framebuffer_fetch_non_coherent.
---
src/mapi/glapi/gen/es_EXT.xml | 5 -
src/mapi/glapi/gen/gl_API.xml | 6 ++
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/mapi/glapi/gen/es_EXT.xml b/s
The changes I had originally planned for the MESA_shader_framebuffer_fetch
extension have been merged into the EXT spec, there's no point in keeping
MESA_shader_framebuffer_fetch extension enables.
---
src/mesa/drivers/dri/i965/brw_draw.c | 2 +-
src/mesa/drivers/dri/i965/brw_program.c
EXT_shader_framebuffer_fetch_non_coherent requires layout qualifiers
even on GL(ES) 2.
---
src/compiler/glsl/glsl_lexer.ll | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler/glsl/glsl_lexer.ll
index 4b36574b73a..2c2098129fd 100644
-
This allows the application to request framebuffer fetch coherency
with per-fragment output granularity. Coherent framebuffer fetch
outputs (which is the default if no qualifier is present for
compatibility with older versions of the EXT_shader_framebuffer_fetch
extension) will have ir_variable_da
This GL entry point was renamed to glFramebufferFetchBarrier() in the
EXT extension on request from Khronos members. Update the Mesa
codebase to match the latest spec.
---
src/mesa/drivers/dri/i965/brw_program.c | 4 ++--
src/mesa/main/barrier.c | 2 +-
src/mesa/main/d
Framebuffer fetch outputs are implicitly initialized upon entry to the
fragment shader.
---
src/compiler/glsl/ast_to_hir.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index 5acbaa321a9..badfbe6816f 100644
--- a/src/compi
---
src/compiler/glsl/glsl_parser_extras.cpp | 1 +
src/compiler/glsl/glsl_parser_extras.h | 9 +++--
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/compiler/glsl/glsl_parser_extras.cpp
b/src/compiler/glsl/glsl_parser_extras.cpp
index 57589843776..68ad54db8ab 100644
---
At the same point where it is initialized on GL(ES) 3.0+ so we can
implement some common layout qualifier handling in a future commit.
Until now the fb_fetch_output flag would be inherited from the
original implicit gl_LastFragData declaration at a later point in the
AST to GLSL IR translation.
---
---
docs/relnotes/18.1.0.html| 2 ++
src/mesa/main/extensions_table.h | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/docs/relnotes/18.1.0.html b/docs/relnotes/18.1.0.html
index b8a0cd0d02c..f5564e9b8fe 100644
--- a/docs/relnotes/18.1.0.html
+++ b/docs/relnotes/18.1.
---
src/util/bitset.h | 114 ++
1 file changed, 114 insertions(+)
diff --git a/src/util/bitset.h b/src/util/bitset.h
index 2404ce7f630..7bb5f3c83cf 100644
--- a/src/util/bitset.h
+++ b/src/util/bitset.h
@@ -132,4 +132,118 @@ __bitset_next_set(un
This should end the drought of bits in the ast_type_qualifier object.
The bitset_t type works pretty much as a drop-in replacement for the
current uint64_t bitset.
The only catch is that the bitset_t type as defined in the previous
commit doesn't have a trivial constructor (because it has a
user-d
---
src/gallium/drivers/svga/svga_tgsi.c| 3 ++-
src/gallium/drivers/svga/svga_tgsi.h| 5 +++--
src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_tgsi.c
b/src/gallium/drivers/svga/svga_t
Looks good.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, February 14, 2018 1:53:52 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: s/unsigned/enum pipe_shader_type/
---
src/gallium/driv
On 15/02/18 01:10, Samuel Pitoiset wrote:
It makes no sense to compact before, and the description of
nir_compact_varyings() confirms that.
Reviewed-by: Timothy Arceri
Your right this seems to be in the wrong place. There was a lot of
restructuring around the time this landed so it seems to
On Tue, Feb 13, 2018 at 4:25 PM, Kenneth Graunke wrote:
> On Tuesday, February 13, 2018 11:15:14 AM PST Anuj Phogat wrote:
>> On gen11+ AUX_HIZ is not a supported value for surfaces being
>> sampled by the 3D sampler.
>>
>> Signed-off-by: Anuj Phogat
>> ---
>> src/mesa/drivers/dri/i965/intel_mip
These only existed to avoid making people update libdrm for new uABI
headers. A while ago we imported those headers into the Mesa repo,
so the dependency is gone and these are no longer useful.
---
src/mesa/drivers/dri/i965/brw_bufmgr.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/me
On Wed, Feb 14, 2018 at 12:16:19PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
We should probabably add:
Fixes: de3be618016 "anv/cmd_buffer: Rework aux tracking"
This patch is
Reviewed-by: Nanley Chery
> di
1 - 100 of 143 matches
Mail list logo
