[Mesa-dev] [PATCH] autotools: Don't redefine EXTRA_DIST for freedreno

2018-01-25 Thread Daniel Stone
The EXTRA_DIST of meson.build accidentally stomps another Freedreno file which should be disted. Change = to +=. Signed-off-by: Daniel Stone Fixes: 436ed65d38d4 ("autotools: include meson build files in tarball") Cc: Dylan Baker Cc: Eric Engestrom Cc: Emil Velikov --- src/gallium/drivers/free

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-25 Thread Eric Engestrom
On Wednesday, 2018-01-24 22:02:42 +0100, Marc Dietrich wrote: > Btw, there is still some strange problem in PACKAGE_BUGREPORT as it > includes a "$" in the url. I don't know where this comes from. Where do you see this "$"? I've looked at the code and it looks all good to me. _

Re: [Mesa-dev] [PATCH] vulkan: Update the XML and headers to 1.0.68

2018-01-25 Thread Samuel Pitoiset
Acked-by: Samuel Pitoiset On 01/25/2018 04:05 AM, Jason Ekstrand wrote: --- include/vulkan/vulkan.h| 54 --- src/vulkan/registry/vk.xml | 91 +- 2 files changed, 130 insertions(+), 15 deletions(-) diff --git a/include/

Re: [Mesa-dev] [PATCH] configure.ac: add missing llvm dependencies to .pc files

2018-01-25 Thread Eric Engestrom
On Wednesday, 2018-01-24 15:10:35 -0500, Chuck Atkins wrote: > CC: > Signed-of-by: Chuck Atkins > --- > configure.ac | 12 > 1 file changed, 12 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 7c1fbe0ed1..e1be7b78e4 100644 > --- a/configure.ac > +++ b/configure.ac

[Mesa-dev] [PATCH] ac/nir: add break statements in needs_view_index_sgpr()

2018-01-25 Thread Samuel Pitoiset
Previous code is correct but as the first case statement uses a break, keep it consistent. CID: 1428579 Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

Re: [Mesa-dev] [PATCH] autotools: Don't redefine EXTRA_DIST for freedreno

2018-01-25 Thread Eric Engestrom
On Thursday, 2018-01-25 08:25:02 +, Daniel Stone wrote: > The EXTRA_DIST of meson.build accidentally stomps another Freedreno file > which should be disted. Change = to +=. > > Signed-off-by: Daniel Stone > Fixes: 436ed65d38d4 ("autotools: include meson build files in tarball") Oops :/ Thank

[Mesa-dev] [PATCH mesa] egl: keep extension list sorted, per comment at the top

2018-01-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/main/egldisplay.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/egldisplay.h b/src/egl/main/egldisplay.h index addf430ffed59937f147..7eac96ed0526fd038cf9 100644 --- a/src/egl/main/egldisplay.h +++ b/src/egl/main/egldispl

[Mesa-dev] [PATCH mesa] loader: let compiler figure out the length of the string

2018-01-25 Thread Eric Engestrom
Basically, turn comment into code Signed-off-by: Eric Engestrom --- src/loader/loader.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/loader/loader.c b/src/loader/loader.c index 3c67f9dc2448a34dbf8e..913b3dcac032b3c9cd0a 100644 --- a/src/loader/loader.c +++ b/src/load

Re: [Mesa-dev] [PATCH 0/2] Small fixes for the meson build

2018-01-25 Thread Eric Engestrom
On Wednesday, 2018-01-24 14:31:08 -0800, Dylan Baker wrote: > ping Both patches are correct: Reviewed-by: Eric Engestrom > > Quoting Dylan Baker (2018-01-12 11:57:34) > > Here's a few things I've caught as I've started trying to add the meson > > build to our CI system. > > > > Dylan Baker (2)

Re: [Mesa-dev] [PATCH 1/2] meson: set proper pkg-config version for libdrm_freedreno

2018-01-25 Thread Emil Velikov
Hi Dylan, To make it easier to spot these, do set the git subject prefix to PATCH libdrm. See autogen.sh for an example. On 12 January 2018 at 19:57, Dylan Baker wrote: > Copy and paste error from exynos. > > Signed-off-by: Dylan Baker > --- > freedreno/meson.build | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH] radv: don't enable tc compat for d32s8 + 4/8 samples (v1.1)

2018-01-25 Thread Samuel Pitoiset
Thanks, that way we might be able to remember. :-) Reviewed-by: Samuel Pitoiset On 01/25/2018 12:29 AM, Dave Airlie wrote: From: Dave Airlie This seems to be broken, at least the cts tests fail. This fixes: dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_4 dEQP-VK.re

Re: [Mesa-dev] [PATCH mesa] loader: let compiler figure out the length of the string

2018-01-25 Thread Emil Velikov
On 25 January 2018 at 10:19, Eric Engestrom wrote: > Basically, turn comment into code > Not sure why I didn't do it from the start. Reviewed-by: Emil Velikov Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedeskto

Re: [Mesa-dev] [PATCH 3/4] ac/nir: set amdgpu.uniform and invariant.load for UBOs

2018-01-25 Thread Alex Smith
Tested-by: Alex Smith This fixes a regression seen after 41c36c45 ("amd/common: use ac_build_buffer_load() for emitting UBO loads"). On 24 January 2018 at 22:26, Samuel Pitoiset wrote: > UBOs are constants buffers. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c |

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: add missing llvm dependencies to .pc files

2018-01-25 Thread Emil Velikov
On 25 January 2018 at 09:44, Eric Engestrom wrote: > On Wednesday, 2018-01-24 15:10:35 -0500, Chuck Atkins wrote: >> CC: >> Signed-of-by: Chuck Atkins >> --- >> configure.ac | 12 >> 1 file changed, 12 insertions(+) >> >> diff --git a/configure.ac b/configure.ac >> index 7c1fbe0ed1

Re: [Mesa-dev] [PATCH] autotools: Don't redefine EXTRA_DIST for freedreno

2018-01-25 Thread Emil Velikov
On 25 January 2018 at 08:25, Daniel Stone wrote: > The EXTRA_DIST of meson.build accidentally stomps another Freedreno file > which should be disted. Change = to +=. > > Signed-off-by: Daniel Stone > Fixes: 436ed65d38d4 ("autotools: include meson build files in tarball") > Cc: Dylan Baker > Cc:

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/build-id: Fix address comparison for binaries with LOAD vaddr > 0

2018-01-25 Thread Emil Velikov
On 24 January 2018 at 14:13, Stephan Gerhold wrote: > build_id_find_nhdr_for_addr() fails to find the build-id if the first LOAD > segment has a virtual address other than 0x0. > > For most shared libraries, the first LOAD segment has vaddr=0x0: > > Type Offset VirtAddr PhysAddr

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Reset the register file to VGRF in lower_integer_multiplication

2018-01-25 Thread Emil Velikov
On 16 December 2017 at 01:12, Jason Ekstrand wrote: > 18fde36ced4279f2577097a1a7d31b55f2f5f141 changed the way temporary > registers were allocated in lower_integer_multiplication so that we > allocate regs_written(inst) space and keep the stride of the original > destination register. This was t

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/pipeline: Don't look at blend state unless we have an attachment

2018-01-25 Thread Emil Velikov
On 18 January 2018 at 01:16, Jason Ekstrand wrote: > Without this, we may end up dereferencing blend before we check for > binding->index != UINT32_MAX. However, Vulkan allows the blend state to > be NULL so long as you don't have any color attachments. This fixes a > segfault when running The T

Re: [Mesa-dev] [PATCH 1/2] svga: fix context alloc error handling

2018-01-25 Thread Emil Velikov
On 23 January 2018 at 18:02, Brian Paul wrote: > On 01/22/2018 03:41 PM, Grazvydas Ignotas wrote: >> >> 'cleanup' path is dereferencing 'svga' a lot, 'done' is a better choice. >> Found by Coccinelle. >> >> Signed-off-by: Grazvydas Ignotas >> --- >> src/gallium/drivers/svga/svga_context.c | 2 +

Re: [Mesa-dev] [PATCH] radv: fix sample_mask_in loading. (v3)

2018-01-25 Thread Emil Velikov
On 23 January 2018 at 23:00, Dave Airlie wrote: > From: Dave Airlie > > This is ported from radeonsi and fixes: > dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* > > v2: don't call this path for radeonsi, it does it in the epilog. > use the radeonsi code path. > v3: handle NULL pCre

Re: [Mesa-dev] [PATCH v4] i965: Avoid problems from referencing orphaned BOs after growing.

2018-01-25 Thread Emil Velikov
On 18 January 2018 at 07:36, Kenneth Graunke wrote: > Growing the batch/state buffer is a lot more dangerous than I thought. > > A number of places emit multiple state buffer sections, and then write > data to the returned pointer, or save a pointer to brw->batch.state.bo > and then use it in relo

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

2018-01-25 Thread Emil Velikov
On 24 January 2018 at 19:12, Dylan Baker wrote: > Quoting Emil Velikov (2018-01-24 11:00:04) >> On 24 January 2018 at 18:19, Dylan Baker wrote: >> > Quoting Emil Velikov (2018-01-24 03:53:35) >> >> On 24 January 2018 at 10:39, Marc Dietrich wrote: >> >> > Hi Dylan, >> >> > >> >> > Am Dienstag, 2

Re: [Mesa-dev] [PATCH v3 00/12] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

2018-01-25 Thread Emil Velikov
On 24 January 2018 at 18:02, Greg V wrote: > meson: updated with suggestions from review. > > anon_file: added a debug_name argument for anv, removed posix_fallocate > and retry loops that were copy-pasted from weston, etc. > > SWR: since there's an environment variable KNOB_MAX_WORKER_THREADS tha

Re: [Mesa-dev] [PATCH] ac/nir: add break statements in needs_view_index_sgpr()

2018-01-25 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jan 25, 2018 at 10:49 AM, Samuel Pitoiset wrote: > Previous code is correct but as the first case statement uses > a break, keep it consistent. > > CID: 1428579 > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 2 ++ > 1 file cha

Re: [Mesa-dev] [PATCH 1/4] ac/nir: set the noalias attribute on input pointers

2018-01-25 Thread Bas Nieuwenhuizen
Patch 1, 3, 4 are Reviewed-by: Bas Nieuwenhuizen On Wed, Jan 24, 2018 at 11:26 PM, Samuel Pitoiset wrote: > This attribute is similar to the definition of restrict in > C99 and it might help LLVM. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 1 + > 1 file chan

Re: [Mesa-dev] [PATCH] autotools: Don't redefine EXTRA_DIST for freedreno

2018-01-25 Thread Daniel Stone
Hi Emil, On 25 January 2018 at 11:14, Emil Velikov wrote: > I've got slightly different version [1], any objections if we opt for that? > Seems like I git branched a second too soon, omitting the fixes from > master and 'detaching' 18.0-branchpoint. Sure, that one is: Reviewed-by: Daniel Stone

[Mesa-dev] [PATCH 1/4] anv/descriptor_set: add reference counting for descriptor set layouts

2018-01-25 Thread Iago Toral Quiroga
The spec states that descriptor set layouts can be destroyed almost at any time: "VkDescriptorSetLayout objects may be accessed by commands that operate on descriptor sets allocated using that layout, and those descriptor sets must not be updated with vkUpdateDescriptorSets after th

[Mesa-dev] [PATCH 4/4] anv/pipeline: remove the pipeline layout field from anv_pipeline

2018-01-25 Thread Iago Toral Quiroga
It no longer has any users. Suggested-by: Jason Ekstrand --- src/intel/vulkan/anv_pipeline.c | 2 -- src/intel/vulkan/anv_private.h | 1 - src/intel/vulkan/genX_pipeline.c | 1 - 3 files changed, 4 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c in

[Mesa-dev] [PATCH 2/4] anv/pipeline: don't take the layout from the pipeline to compile shaders

2018-01-25 Thread Iago Toral Quiroga
The Vulkan spec states that VkPipelineLayout objects must not be destroyed while any command buffer that uses them is in the recording state, but it permits them to be destroyed otherwise. This means that applications are allowed to free pipeline layouts after command recording is finished even if

[Mesa-dev] [PATCH 3/4] anv/cmd_buffer: add the pipeline layout to the pipeline state

2018-01-25 Thread Iago Toral Quiroga
We need to access the pipeline layout to compute correct dynamic offsets for dyamic UBO/SSBO descriptors when we emit draw commands. Instead of taking it from the pipeline object, store the layout in the command buffer pipeline state. Suggested-by: Jason Ekstrand --- src/intel/vulkan/anv_cmd_buf

Re: [Mesa-dev] [PATCH v2] swr/rast: support llvm 3.9 type declarations

2018-01-25 Thread Cherniak, Bruce
v2 is Reviewed-by: Bruce Cherniak > On Jan 24, 2018, at 2:43 PM, George Kyriazis > wrote: > > LLVM 3.9 was not taken into account in initial check-in. > > Fixes: 01ab218bbc ("swr/rast: Initial work for debugging support.") > cc: mesa-sta...@lists.freedesktop.org > Bugzilla: https://bugs.free

[Mesa-dev] [PATCH 0/7] freedreno: a2xx improvements

2018-01-25 Thread Wladimir J. van der Laan
While working on a205 support for i.MX51/53, I've also written some patches that are not specific to a20x but should apply to the whole a2xx range. As I'm figuring out how to handle backward compatibility to other a2xx, I think it makes sense to send these upstream already to reduce the patch stac

[Mesa-dev] [PATCH 5/7] freedreno: a2xx: Compressed textures support

2018-01-25 Thread Wladimir J. van der Laan
Add support for: - PIPE_FORMAT_ETC1_RGB8 - PIPE_FORMAT_DXT1_RGB - PIPE_FORMAT_DXT1_RGBA - PIPE_FORMAT_DXT3_RGBA - PIPE_FORMAT_DXT5_RGBA Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/

[Mesa-dev] [PATCH 1/7] freedreno: a2xx: Update rnndb header

2018-01-25 Thread Wladimir J. van der Laan
Also update BLEND_ to BLEND2_ opcodes to accomodate. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/a2xx.xml.h | 33 +++ src/gallium/drivers/freedreno/a2xx/fd2_gmem.c | 4 ++-- 2 files changed, 15 insertions(+), 22 deletions(-) diff --git

[Mesa-dev] [PATCH 3/7] freedreno: a2xx: Prevent crash in emit_texture if view is not set

2018-01-25 Thread Wladimir J. van der Laan
Textures will sometimes be updated if texture view state was un-set, without this change that causes an assertion crash or segfault. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff -

[Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

2018-01-25 Thread Wladimir J. van der Laan
Denormalized texture coordinates are required for text rendering in GALLIUM_HUD. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 + src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 1 +

[Mesa-dev] [PATCH 2/7] freedreno: a2xx: Fix fd2_tex_swiz

2018-01-25 Thread Wladimir J. van der Laan
Compose swizzles using util_format_compose_swizzles instead of the custom code (which somehow had a bug). This makes the GL_ALPHA internal format work. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +- 1 file changed, 9 insertions

[Mesa-dev] [PATCH 7/7] freedreno: a2xx: Implement DP2 instruction

2018-01-25 Thread Wladimir J. van der Laan
Use DOT2ADDv instruction with 0.0f constant add. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_compiler.c b/src/gallium/drivers/freed

[Mesa-dev] [PATCH 6/7] freedreno: a2xx: implement SEQ/SNE instructions

2018-01-25 Thread Wladimir J. van der Laan
Extend translate_sge_slt to emit these, in analogous fashion but using CNDEv. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/freedreno/a

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: add missing llvm dependencies to .pc files

2018-01-25 Thread Chuck Atkins
> Should be used only for gallium-xlib based glx, since it embeds the > swr/llvmpipe driver. > ... ... > There is no LLVM specific code in these - ^^ should not be needed. > Correct. This was initially to address the problem for OSMesa but I realized it was likely an issue for more than just OSM

Re: [Mesa-dev] [Freedreno] [PATCH 1/7] freedreno: a2xx: Update rnndb header

2018-01-25 Thread Ilia Mirkin
On Thu, Jan 25, 2018 at 8:29 AM, Wladimir J. van der Laan wrote: > Also update BLEND_ to BLEND2_ opcodes to accomodate. Are you saying this doesn't compile right now? I would have expected the accompanying change to a2xx.xml.h for that. Perhaps this landed into the wrong commit? Also it's odd th

Re: [Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

2018-01-25 Thread Ilia Mirkin
Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's called... I forget.) On Thu, Jan 25, 2018 at 8:29 AM, Wladimir J. van der Laan wrote: > Denormalized texture coordinates are required for text rendering in > GALLIUM_HUD. > > Signed-off-by: Wladimir J. van der Laan > --- > src

Re: [Mesa-dev] [Freedreno] [PATCH 1/7] freedreno: a2xx: Update rnndb header

2018-01-25 Thread Wladimir J. van der Laan
On Thu, Jan 25, 2018 at 08:40:00AM -0500, Ilia Mirkin wrote: > On Thu, Jan 25, 2018 at 8:29 AM, Wladimir J. van der Laan > wrote: > > Also update BLEND_ to BLEND2_ opcodes to accomodate. > > Are you saying this doesn't compile right now? I would have expected > the accompanying change to a2xx.xml

Re: [Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

2018-01-25 Thread Wladimir J. van der Laan
On Thu, Jan 25, 2018 at 08:41:11AM -0500, Ilia Mirkin wrote: > Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's > called... I forget.) Yes, good point, will add that. Wladimir ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH v2] configure.ac: add missing llvm dependencies to .pc files

2018-01-25 Thread Chuck Atkins
v2: Only add as dependencies for gallium-osmesa and gallium-xlib CC: Signed-of-by: Chuck Atkins --- configure.ac | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure.ac b/configure.ac index 7c1fbe0ed1..448bd3a6ba 100644 --- a/configure.ac +++ b/configure.ac @@ -2780,6 +2780,12 @@

[Mesa-dev] [PATCH 2/2] radv: fix RADV_DEBUG=syncshaders on GFX9

2018-01-25 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index ba5fd92f2a1..b694174de68 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++

[Mesa-dev] [PATCH 1/2] radv: fix a GPU hang with RADV_DEBUG=syncshaders

2018-01-25 Thread Samuel Pitoiset
The GPU hangs when the driver forces a PS_PARTIAL_FLUSH after a dispatch call (and vice versa for graphics). Something has changed in the kernel driver because it used to work. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 15 +++ 1 file changed, 7 insertions(

Re: [Mesa-dev] [PATCH] gallivm: fix crash with seamless cube filtering with different min/mag filter

2018-01-25 Thread Jose Fonseca
Looks great. Reviewed-by: Jose Fonseca On 25/01/18 03:33, srol...@vmware.com wrote: From: Roland Scheidegger We are not allowed to modify the incoming coords values, or things may crash (as we may be inside a llvm conditional and the values may be used in another branch). I recently broke t

[Mesa-dev] [PATCH] radv: emit a cache flush before enabling predication

2018-01-25 Thread Matthew Nicholls
Otherwise cache flushes could get conditionally disabled while still clearing the flush_bits, and thus flushes due to application pipeline barriers may never get executed. Cc: mesa-sta...@lists.freedesktop.org --- src/amd/vulkan/radv_meta_fast_clear.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/build-id: Fix address comparison for binaries with LOAD vaddr > 0

2018-01-25 Thread Stephan Gerhold
On Thu, Jan 25, 2018 at 11:22:10AM +, Emil Velikov wrote: > On 24 January 2018 at 14:13, Stephan Gerhold wrote: > > build_id_find_nhdr_for_addr() fails to find the build-id if the first LOAD > > segment has a virtual address other than 0x0. > > > > For most shared libraries, the first LOAD seg

Re: [Mesa-dev] [PATCH] mesa: simplify _mesa_delete_list() a bit, add some assertions

2018-01-25 Thread Brian Paul
On 01/24/2018 09:41 PM, Roland Scheidegger wrote: Am 25.01.2018 um 00:19 schrieb Brian Paul: All but two cases of the switch did the same n += InstSize[n[0].opcode] instruction. Just move it after the switch. Add some sanity check assertions. --- src/mesa/main/dlist.c | 39 +++---

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-25 Thread Eric Engestrom
On Thursday, 2018-01-25 10:31:12 +0100, Marc Dietrich wrote: > Am Donnerstag, 25. Januar 2018, 10:28:26 CET schrieb Marc Dietrich: > > Am Donnerstag, 25. Januar 2018, 10:18:16 CET schrieb Eric Engestrom: > > > On Wednesday, 2018-01-24 22:02:42 +0100, Marc Dietrich wrote: > > > > Btw, there is still

[Mesa-dev] [PATCH] mesa: Correctly print glTexImage dimensions

2018-01-25 Thread Elie Tournier
texture_format_error_check_gles() displays error like "glTexImage%dD". This patch just replace the %d by the correct dimension. Signed-off-by: Elie Tournier --- src/mesa/main/teximage.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/teximage.c b/s

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

2018-01-25 Thread Michel Dänzer
On 2018-01-24 05:38 PM, Juan A. Suarez Romero wrote: > This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5. > --- > src/mesa/main/fbobject.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index d23916d1ad7..c72204e11a0 100644

Re: [Mesa-dev] [PATCH 2/3] anv/gen10: Ignore push constant packets during context restore.

2018-01-25 Thread Rafael Antognolli
On Wed, Jan 24, 2018 at 05:08:54PM -0800, Jason Ekstrand wrote: > On Wed, Jan 24, 2018 at 4:33 PM, Rafael Antognolli > > wrote: > > Similar to the GL driver, ignore 3DSTATE_CONSTANT_* packets when doing a > context restore. > > Signed-off-by: Rafael Antognolli > Cc: Jason Ekstr

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

2018-01-25 Thread Brian Paul
On 01/24/2018 09:06 PM, Roland Scheidegger wrote: Am 25.01.2018 um 00:19 schrieb Brian Paul: The newest version of WSI Fusion makes several glDrawPixels calls per frame. By caching more than one image, we get better performance when panning/zomming the map. zooming --- src/mesa/state_track

[Mesa-dev] [PATCH] radeonsi: Export signalled sync file instead of -1.

2018-01-25 Thread Bas Nieuwenhuizen
-1 is considered an error for EGL_ANDROID_native_fence_sync, so we need to actually create a sync file. Fixes: f536f45250 "radeonsi: implement sync_file import/export" --- src/gallium/drivers/radeon/radeon_winsys.h | 5 + src/gallium/drivers/radeonsi/si_fence.c| 2 ++ src/gallium/winsys

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: add missing llvm dependencies to .pc files

2018-01-25 Thread Emil Velikov
On 25 January 2018 at 14:43, Chuck Atkins wrote: > v2: Only add as dependencies for gallium-osmesa and gallium-xlib > > CC: > Signed-of-by: Chuck Atkins Reviewed-by: Emil Velikov > --- > configure.ac | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/configure.ac b/configure.ac >

[Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

2018-01-25 Thread Brian Paul
The newest version of WSI Fusion makes several glDrawPixels calls per frame. By caching more than one image, we get better performance when panning/zomming the map. v2: move pixel unpack param checking out of cache search loop, per Roland --- src/mesa/state_tracker/st_cb_drawpixels.c | 196 +

Re: [Mesa-dev] [PATCH mesa] egl: keep extension list sorted, per comment at the top

2018-01-25 Thread Adam Jackson
On Thu, 2018-01-25 at 10:14 +, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-25 Thread Robert Foss
Hey Tomasz, On 01/24/2018 11:04 AM, Tomasz Figa wrote: Hi Robert, On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss wrote: This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, since at least 4 implementations exist, and share a lot of contents. The idea is to keep the common stuff d

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: add missing llvm dependencies to .pc files

2018-01-25 Thread Chuck Atkins
> > > +if test "x$enable_glx" == xgallium-xlib; then > > +GL_PC_LIB_PRIV="$GL_PC_LIB_PRIV $LLVM_LIBS" > > +fi > > +if test "x$enable_gallium_osmesa" = xyes; then > > +OSMESA_PC_LIB_PRIV="$OSMESA_PC_LIB_PRIV $LLVM_LIBS" > > +fi > I'm itching to add a comment above the

[Mesa-dev] [PATCH 2/3] mesa: include mtypes.h in varray.h

2018-01-25 Thread Brian Paul
We actually use some of the types from mtypes.h so include it directly instead of relying on indirectly including it via bufferobj.h --- src/mesa/main/varray.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/varray.h b/src/mesa/main/varray.h index 6dcf1db..03d8

[Mesa-dev] [PATCH 1/3] mesa: s/gl_vertex_attrib_array/gl_array_attributes/ in comments

2018-01-25 Thread Brian Paul
The structure type was renamed some time ago, but some comments were not updated. --- src/mesa/main/arrayobj.c | 2 +- src/mesa/main/mtypes.h | 2 +- src/mesa/main/varray.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.

[Mesa-dev] [PATCH 3/3] mesa: whitespace fixes in varray.h

2018-01-25 Thread Brian Paul
--- src/mesa/main/varray.h | 55 ++ 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/src/mesa/main/varray.h b/src/mesa/main/varray.h index 03d81d0..93f2f47 100644 --- a/src/mesa/main/varray.h +++ b/src/mesa/main/varray.h @@ -44,9 +44,1

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

2018-01-25 Thread Roland Scheidegger
Am 25.01.2018 um 16:30 schrieb Michel Dänzer: > On 2018-01-24 05:38 PM, Juan A. Suarez Romero wrote: >> This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5. >> --- >> src/mesa/main/fbobject.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/src/mesa/main/fbobject.c b/src/mesa/mai

[Mesa-dev] [Bug 104710] [swrast] piglit draw-batch regression

2018-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104710 --- Comment #1 from Emil Velikov --- Vinson I'm suspecting that this should be fixed with 365a48abddcabf6596c2e34a784d91c8ab929918. Can you please confirm? -- You are receiving this mail because: You are the assignee for the bug. You are the Q

Re: [Mesa-dev] [PATCH 3/3] mesa: whitespace fixes in varray.h

2018-01-25 Thread Charmaine Lee
For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, January 25, 2018 8:48:00 AM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee; Roland Scheidegger Subject: [PATCH 3/3] mesa: whitespace fixes in varray.h --- sr

[Mesa-dev] [Bug 104749] rasterizer/jitter/JitManager.cpp:252:91: error: no matching function for call to ‘llvm::DIBuilder::createBasicType(const char [8], int, llvm::dwarf::TypeKind)’

2018-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104749 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

2018-01-25 Thread Roland Scheidegger
Am 25.01.2018 um 16:55 schrieb Brian Paul: > The newest version of WSI Fusion makes several glDrawPixels calls > per frame. By caching more than one image, we get better performance > when panning/zomming the map. Still zooming :-) > > v2: move pixel unpack param checking out of cache search

Re: [Mesa-dev] [PATCH 1/2] radv: fix a GPU hang with RADV_DEBUG=syncshaders

2018-01-25 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jan 25, 2018 at 3:46 PM, Samuel Pitoiset wrote: > The GPU hangs when the driver forces a PS_PARTIAL_FLUSH after > a dispatch call (and vice versa for graphics). Something has > changed in the kernel driver because it used to work. > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 2/2] radv: fix RADV_DEBUG=syncshaders on GFX9

2018-01-25 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jan 25, 2018 at 3:46 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulk

Re: [Mesa-dev] [PATCH] configure.ac: correct driglx-direct help text

2018-01-25 Thread Emil Velikov
On 20 December 2017 at 17:34, Emil Velikov wrote: > From: Emil Velikov > > The default was toggled a while back, but the text wasn't updated. > > Fixes: bd526ec9e1b ("configure: Always default to > --enable-driglx-direct") > Cc: Jon TURNEY > Signed-off-by: Emil Velikov > --- > configure.ac | 2

Re: [Mesa-dev] [PATCH 3/3] mesa: whitespace fixes in varray.h

2018-01-25 Thread Neha Bhende
Looks good. For the series, Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Thursday, January 25, 2018 8:48:00 AM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee; Roland Scheidegger Subject: [PATCH 3/3] mesa: whitespace fixes

Re: [Mesa-dev] [PATCH 1/5] configure.ac: add Wundef to the build flags

2018-01-25 Thread Emil Velikov
On 24 November 2017 at 18:26, Eric Engestrom wrote: > On Friday, 2017-11-24 18:14:41 +, Emil Velikov wrote: >> On 24 November 2017 at 14:32, Eric Engestrom >> wrote: >> > On Friday, 2017-11-24 14:25:02 +, Emil Velikov wrote: >> >> From: Emil Velikov >> >> >> >> From the manual: >> >>

Re: [Mesa-dev] [PATCH] configure.ac: correct driglx-direct help text

2018-01-25 Thread Daniel Stone
On 20 December 2017 at 17:34, Emil Velikov wrote: > The default was toggled a while back, but the text wasn't updated. Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mes

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

2018-01-25 Thread Gustaw Smolarczyk
2018-01-25 18:02 GMT+01:00 Roland Scheidegger : > Am 25.01.2018 um 16:55 schrieb Brian Paul: > > The newest version of WSI Fusion makes several glDrawPixels calls > > per frame. By caching more than one image, we get better performance > > when panning/zomming the map. > Still zooming :-) > > > >

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

2018-01-25 Thread Roland Scheidegger
Am 25.01.2018 um 17:56 schrieb Roland Scheidegger: > Am 25.01.2018 um 16:30 schrieb Michel Dänzer: >> On 2018-01-24 05:38 PM, Juan A. Suarez Romero wrote: >>> This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5. >>> --- >>> src/mesa/main/fbobject.c | 3 +++ >>> 1 file changed, 3 insertions(+)

Re: [Mesa-dev] [PATCH] i965/fs: Reset the register file to VGRF in lower_integer_multiplication

2018-01-25 Thread Matt Turner
On Fri, Dec 15, 2017 at 5:12 PM, Jason Ekstrand wrote: > 18fde36ced4279f2577097a1a7d31b55f2f5f141 changed the way temporary > registers were allocated in lower_integer_multiplication so that we > allocate regs_written(inst) space and keep the stride of the original > destination register. This wa

[Mesa-dev] [PATCH v3 1/8] i965: allocate a SGVS element when VertexID or InstanceID are read

2018-01-25 Thread Antia Puentes
From: Iago Toral Quiroga Although on gen8+ platforms we can in theory use 3DSTATE_VF_SGVS to put these beyond the last vertex element it seems that we still need to allocate the SVGS element, otherwise we have observed cases where we end up reading garbage. Specifically, the CTS test mentioned be

[Mesa-dev] [PATCH v3 4/8] intel: Handle firstvertex in an identical way to BaseVertex

2018-01-25 Thread Antia Puentes
Until we set gl_BaseVertex to zero for non-indexed draw calls both have an identical value. The Vertex Elements are kept like that: * VE 1: * VE 2: --- src/intel/compiler/brw_nir.c | 3 +++ src/intel/compiler/brw_vec4.cpp | 1 + src/mesa/drivers/dri/i965/brw_con

[Mesa-dev] [PATCH v3 7/8] nir: Offset vertex_id by first_vertex instead of base_vertex

2018-01-25 Thread Antia Puentes
From: Neil Roberts base_vertex will be zero for non-indexed calls and in that case we need vertex_id to be offset by the ‘first’ parameter instead. That is what we get with first_vertex. This is true for both GL and Vulkan. The freedreno driver is also setting vertex_id_zero_based on nir_options

[Mesa-dev] [PATCH v3 5/8] spirv: Lower BaseVertex to FIRST_VERTEX instead of BASE_VERTEX

2018-01-25 Thread Antia Puentes
From: Neil Roberts The base vertex in Vulkan is different from GL in that for non-indexed primitives the value is taken from the firstVertex parameter instead of being set to zero. This coincides with the new SYSTEM_VALUE_FIRST_VERTEX instead of BASE_VERTEX. --- src/compiler/spirv/vtn_variables.

[Mesa-dev] [PATCH v3 6/8] i965: Don't request GLSL IR lowering of gl_VertexID

2018-01-25 Thread Antia Puentes
From: Ian Romanick Let the lowering in NIR handle it instead. This hurts one shader that occurs twice in shader-db (SynMark GSCloth) on IVB and HSW. No other shaders or platforms were affected. total cycles in shared programs: 253438422 -> 253438426 (0.00%) cycles in affected programs: 412 ->

[Mesa-dev] [PATCH v3 3/8] intel/compiler: Add a uses_firstvertex flag

2018-01-25 Thread Antia Puentes
From: Neil Roberts Reviewed-by: Kenneth Graunke --- src/intel/compiler/brw_compiler.h | 1 + src/intel/compiler/brw_vec4.cpp | 4 2 files changed, 5 insertions(+) diff --git a/src/intel/compiler/brw_compiler.h b/src/intel/compiler/brw_compiler.h index b1086bbcee5..0afe5757945 100644 --

[Mesa-dev] [PATCH v3 2/8] compiler: Add SYSTEM_VALUE_FIRST_VERTEX and instrinsics

2018-01-25 Thread Antia Puentes
This VS system value will contain the value passed as for indexed draw calls or the value passed as for non-indexed draw calls. It can be used to calculate the gl_VertexID as SYSTEM_VALUE_VERTEX_ID_ZERO_BASE plus SYSTEM_VALUE_FIRST_VERTEX. From the OpenGL 4.6 spec, 10.4 "Drawing Commands Using V

[Mesa-dev] [PATCH v3 8/8] i965: gl_BaseVertex must be zero for non-indexed draw calls

2018-01-25 Thread Antia Puentes
We keep 'firstvertex' as it is and move gl_BaseVertex to the drawID vertex element. The previous Vertex Elements order was: * VE 1: * VE 2: and now it is: * VE 1: * VE 2: To move the BaseVertex keeping VE1 as it is, allows to keep pointing the vertex buffer associated to VE 1 to the

[Mesa-dev] [Bug 104710] [swrast] piglit draw-batch regression

2018-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104710 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 104141] include/c11/threads_posix.h:96: undefined reference to `pthread_once'

2018-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104141 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/5] swr/rast: Support USE_SIMD16_FRONTEND=0 for EarlyRast

2018-01-25 Thread Cherniak, Bruce
Series Reviewed-by: Bruce Cherniak > On Jan 24, 2018, at 9:31 AM, George Kyriazis > wrote: > > Early Rasterization did not initially work with USE_SIMD16_FRONTEND=0. > Fix it so it works there, too. Please note that the default setting > is USE_SIMD16_FRONTEND=1. > --- > .../drivers/swr/rast

Re: [Mesa-dev] [PATCH] vulkan: Update the XML and headers to 1.0.68

2018-01-25 Thread Chad Versace
On Wed 24 Jan 2018, Jason Ekstrand wrote: > --- > include/vulkan/vulkan.h| 54 --- > src/vulkan/registry/vk.xml | 91 > +- > 2 files changed, 130 insertions(+), 15 deletions(-) Acked-by: Chad Versace ___

[Mesa-dev] [PATCH] svga: s/Bool/SVGA3dBool/ in SVGA3dDevCapResult

2018-01-25 Thread Brian Paul
And fix whitespace. To sync up with in-house code. --- src/gallium/drivers/svga/include/svga3d_devcaps.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/include/svga3d_devcaps.h b/src/gallium/drivers/svga/include/svga3d_devcaps.h index ade210b..

Re: [Mesa-dev] [PATCH 04/10] swrast: remove non-applicable GLX_SWAP_COPY_OML comment

2018-01-25 Thread Emil Velikov
On 12 December 2017 at 00:19, Ian Romanick wrote: > On 12/07/2017 09:07 AM, Emil Velikov wrote: >> From: Emil Velikov >> >> Noticed while skimming for GLX_ instances i the dri codebase. > > in > > With that fixed, this patch is also > > Reviewed-by: Ian

Re: [Mesa-dev] [PATCH] svga: s/Bool/SVGA3dBool/ in SVGA3dDevCapResult

2018-01-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, January 25, 2018 10:38:51 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: s/Bool/SVGA3dBool/ in SVGA3dDevCapResult And fix whitespace. To sync up wi

Re: [Mesa-dev] [PATCH] swr/rast: Optimize DumpToFile output size

2018-01-25 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jan 24, 2018, at 2:50 PM, George Kyriazis > wrote: > > Modify DumpToFile to only dump the function, not the entire module. > Reduces file sizes and speeds up the dumping. > --- > src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 3 +-- > 1 file changed,

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: add missing llvm dependencies to .pc files

2018-01-25 Thread Chuck Atkins
Hi Emil, I'll squash it before pushing >> > > Thanks! Hopefully once my new account goes through I can push on my own. > It looks like my account finally went through so I can just take care of pushing it myself. - Chuck ___ mesa-dev mailing list mes

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-25 Thread Rob Herring
On Thu, Jan 25, 2018 at 10:21 AM, Robert Foss wrote: > Hey Tomasz, > > On 01/24/2018 11:04 AM, Tomasz Figa wrote: >> >> Hi Robert, >> >> On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss >> wrote: >>> >>> This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, >>> since at least 4 implemen

Re: [Mesa-dev] [PATCH] radv: emit a cache flush before enabling predication

2018-01-25 Thread Dave Airlie
On 26 Jan. 2018 01:10, "Matthew Nicholls" wrote: Otherwise cache flushes could get conditionally disabled while still clearing the flush_bits, and thus flushes due to application pipeline barriers may never get executed. I wonder would we better not predicating flushes. I added that as an extra

[Mesa-dev] [PATCH] mesa: Fix function pointers initialization in status tracker

2018-01-25 Thread Eleni Maria Stea
We assigned the function that gets the device uuid to the GetDriverUuid function pointer and the function that gets the driver uuid to the GetDeviceUuid function pointer inside the state tracker. Exchanged the pointers. --- src/mesa/state_tracker/st_context.c | 4 ++-- 1 file changed, 2 insertions

Re: [Mesa-dev] [PATCH] mesa: Fix function pointers initialization in status tracker

2018-01-25 Thread Brian Paul
On 01/25/2018 01:09 PM, Eleni Maria Stea wrote: We assigned the function that gets the device uuid to the GetDriverUuid function pointer and the function that gets the driver uuid to the GetDeviceUuid function pointer inside the state tracker. Exchanged the pointers. --- src/mesa/state_tracker/

  1   2   >