Re: [Mesa-dev] [PATCH v3 20/48] intel/fs: Protect opt_algebraic from OOB BROADCAST indices

2017-10-27 Thread Iago Toral
On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > --- >  src/intel/compiler/brw_fs.cpp | 10 -- >  1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/intel/compiler/brw_fs.cpp > b/src/intel/compiler/brw_fs.cpp > index 1c4351b..52079d3 100644 > --- a/src/intel/com

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-27 Thread Iago Toral
This sounds good to me, but I guess it is not really fixing anything, right? I ask because the subject claims that this patch does something that the original code was already supposed to be doing. On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > Before, we bailing in assign_constant_loc

Re: [Mesa-dev] [PATCH v3 00/10] glsl_to_tgsi: Further improvement of lifetime tracking for register merge

2017-10-27 Thread Gert Wollny
Am Donnerstag, den 26.10.2017, 17:28 +0100 schrieb Emil Velikov: > > >  .../tests/test_glsl_to_tgsi_lifetime.cpp   | 1278 > > +++- > > JFYI you'd want to explicitly undef NDEBUG in the test. > git grep -10 "#undef NDEBUG" -  for examples > > Otherwise the asserts will not

Re: [Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor

2017-10-27 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 10/27/2017 01:48 AM, Mauro Rossi wrote: Having moved gallium_dri.so library to /vendor/lib/dri also symlinks need to be coherently created using TARGET_OUT_VENDOR insted of TARGET_OUT or all non Intel drivers will not be loaded with Android N and earlier, thus caus

Re: [Mesa-dev] [PATCH v3 25/48] intel/cs: Drop max_dispatch_width checks from compile_cs

2017-10-27 Thread Iago Toral
On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > The only things that adjust fs_visitor::max_dispatch_width are render > target writes which don't happen in compute shaders so they're > pointless. > --- >  src/intel/compiler/brw_fs.cpp | 6 ++ >  1 file changed, 2 insertions(+), 4 dele

Re: [Mesa-dev] [PATCH v2] radeonsi: update hack for HTILE corruption in ARK: Survival Evolved

2017-10-27 Thread Samuel Pitoiset
Pushed with "clear_db_cache_before_clear", Thanks Marek. On 10/26/2017 10:42 PM, Marek Olšák wrote: Please "clear_db_cache_before_clear" and the option too. With that, the patch is: Reviewed-by: Marek Olšák Thanks, Marek On Thu, Oct 26, 2017 at 6:08 PM, Samuel Pitoiset wrote: It appears th

Re: [Mesa-dev] [PATCH] i965: unref push_const_bo in intelDestroyContext

2017-10-27 Thread Emil Velikov
On 27 October 2017 at 07:52, Tapani Pälli wrote: > Valgrind shows that leak is caused by gen6_upload_push_constant, add > unref push_const_bo per stage to destructor to fix this (like done for > scratch_bo). > >==10952== 144 bytes in 1 blocks are definitely lost in loss record 44 of 66 >==

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-27 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > Previously, brw_nir_lower_intrinsics added the param and then emitted > a > load_uniform intrinsic to load it directly.  This commit switches > things > over to use a specific NIR intrinsic for the thread id.  The one > thing I > don't like

[Mesa-dev] [PATCH] formatquery: use correct target check for IMAGE_FORMAT_COMPATIBILITY_TYPE

2017-10-27 Thread Alejandro Piñeiro
From the spec: "IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the resource when used as an image textures is returned in . This is equivalent to calling GetTexParameter" So we would need to return None for any target not supported by GetTexParameter. By mistake, we were

Re: [Mesa-dev] [PATCH] formatquery: use correct target check for IMAGE_FORMAT_COMPATIBILITY_TYPE

2017-10-27 Thread Antia Puentes
Thanks for fixing this. Reviewed-by: Antia Puentes On 27/10/17 11:18, Alejandro Piñeiro wrote: From the spec: "IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the resource when used as an image textures is returned in . This is equivalent to calling GetTexParamet

[Mesa-dev] [PATCH 2/2] i965: unref push_const_bo in intelDestroyContext

2017-10-27 Thread Tapani Pälli
Valgrind shows that leak is caused by gen6_upload_push_constant, add unref push_const_bo per stage to destructor to fix this (like done for scratch_bo). ==10952== 144 bytes in 1 blocks are definitely lost in loss record 44 of 66 ==10952==at 0x4C30A1E: calloc (vg_replace_malloc.c:711)

[Mesa-dev] [PATCH 1/2] i965: remove if conditions from scratch_bo unref

2017-10-27 Thread Tapani Pälli
brw_bo_unreference handles NULL case Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_context.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index c8de074638..

Re: [Mesa-dev] [PATCH] i965: unref push_const_bo in intelDestroyContext

2017-10-27 Thread Kenneth Graunke
On Friday, October 27, 2017 2:08:36 AM PDT Emil Velikov wrote: > On 27 October 2017 at 07:52, Tapani Pälli wrote: > > Valgrind shows that leak is caused by gen6_upload_push_constant, add > > unref push_const_bo per stage to destructor to fix this (like done for > > scratch_bo). > > > >==10952=

Re: [Mesa-dev] [PATCH v3 30/48] intel/cs: Re-run final NIR optimizations for each SIMD size

2017-10-27 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > With the advent of SPIR-V subgroup operations, compute shaders will > have > to be slightly different depending on the SIMD size at which they > execute.  In order to allow us to do dispatch-width specific things > in > NIR, we re-run the f

Re: [Mesa-dev] [PATCH] i965: unref push_const_bo in intelDestroyContext

2017-10-27 Thread Tapani Pälli
On 10/27/2017 12:57 PM, Kenneth Graunke wrote: On Friday, October 27, 2017 2:08:36 AM PDT Emil Velikov wrote: On 27 October 2017 at 07:52, Tapani Pälli wrote: Valgrind shows that leak is caused by gen6_upload_push_constant, add unref push_const_bo per stage to destructor to fix this (like do

Re: [Mesa-dev] [PATCH] intel/compiler/gen9: Pixel shader header only workaround

2017-10-27 Thread Kenneth Graunke
On Wednesday, October 25, 2017 10:37:37 AM PDT Topi Pohjolainen wrote: > Fixes intermittent GPU hangs on Broxton with an Intel internal > test case. > > There are plenty of similar fragment shaders in piglit that do > not use any varyings and any uniforms. According to the > documentation special

Re: [Mesa-dev] [PATCH v3 31/48] intel/cs: Re-run final NIR optimizations for each SIMD size

2017-10-27 Thread Iago Toral
This should be squashed into the previous commit On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > With the advent of SPIR-V subgroup operations, compute shaders will > have > to be slightly different depending on the SIMD size at which they > execute.  In order to allow us to do dispatch

Re: [Mesa-dev] [PATCH 1/2] i965: remove if conditions from scratch_bo unref

2017-10-27 Thread Kenneth Graunke
On Friday, October 27, 2017 2:56:45 AM PDT Tapani Pälli wrote: > brw_bo_unreference handles NULL case > > Signed-off-by: Tapani Pälli > --- > src/mesa/drivers/dri/i965/brw_context.c | 16 ++-- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH v4 1/2] glsl: allow any l-value of an input variable as interpolant in interpolateAt*

2017-10-27 Thread Timothy Arceri
I meant to review this a while ago. Sorry for the delay. Reviewed-by: Timothy Arceri On 10/10/17 23:09, Nicolai Hähnle wrote: From: Nicolai Hähnle The intended rule has been clarified in GLSL 4.60, Section 8.13.2 (Interpolation Functions): "For all of the interpolation functions, interp

Re: [Mesa-dev] [PATCH v4 2/2] glsl: fix interpolateAtXxx(some_vec[idx], ...) with dynamic idx

2017-10-27 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 10/10/17 23:09, Nicolai Hähnle wrote: From: Nicolai Hähnle The dynamic index of a vector (not array!) is lowered to a sequence of conditional assignments. However, the interpolate_at_* expressions require that the interpolant is an l-value of a shader input. So

Re: [Mesa-dev] [PATCH v3 34/48] intel/fs: Rework zero-length URB write handling

2017-10-27 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > Originally we tried to handle this case based on > slots_valid.  However, > there are a number of ways that this can go wrong.  For one, we throw > away any trailing slots which either aren't written or are set to > VARYING_SLOT_PAD.  I do

Re: [Mesa-dev] [PATCH 1/2] i965: remove if conditions from scratch_bo unref

2017-10-27 Thread Emil Velikov
For the series Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 9/9] meson: build gallium based osmesa

2017-10-27 Thread Eric Engestrom
On Thursday, 2017-10-26 13:55:35 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2017-10-26 02:40:20) > > On Wednesday, 2017-10-25 15:58:23 -0700, Dylan Baker wrote: > > > This has been tested with the osdemo from mesa-demos > > > > > > Signed-off-by: Dylan Baker > > > --- > > > meson.build

Re: [Mesa-dev] [PATCH 1/7] svga: Use __asm__ instead of asm

2017-10-27 Thread Emil Velikov
On 27 October 2017 at 00:57, Dylan Baker wrote: > Which allows the code to be compiled with c99 instead of gnu99. > > A little history. This code is guarded by #ifdef __GNUC__, so it's only > compiled with autotools on *nix, SCons with MSVC wont hit that code. > However, meson is going to build bo

Re: [Mesa-dev] [PATCH] intel/compiler/gen9: Pixel shader header only workaround

2017-10-27 Thread Pohjolainen, Topi
On Fri, Oct 27, 2017 at 03:02:59AM -0700, Kenneth Graunke wrote: > On Wednesday, October 25, 2017 10:37:37 AM PDT Topi Pohjolainen wrote: > > Fixes intermittent GPU hangs on Broxton with an Intel internal > > test case. > > > > There are plenty of similar fragment shaders in piglit that do > > not

Re: [Mesa-dev] [PATCH] intel/compiler/gen9: Pixel shader header only workaround

2017-10-27 Thread Kenneth Graunke
On Friday, October 27, 2017 4:26:32 AM PDT Pohjolainen, Topi wrote: > On Fri, Oct 27, 2017 at 03:02:59AM -0700, Kenneth Graunke wrote: > > On Wednesday, October 25, 2017 10:37:37 AM PDT Topi Pohjolainen wrote: > > > Fixes intermittent GPU hangs on Broxton with an Intel internal > > > test case. > >

Re: [Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor

2017-10-27 Thread Emil Velikov
On 26 October 2017 at 23:48, Mauro Rossi wrote: > Having moved gallium_dri.so library to /vendor/lib/dri > also symlinks need to be coherently created using TARGET_OUT_VENDOR insted of > TARGET_OUT > or all non Intel drivers will not be loaded with Android N and earlier, > thus causing SurfaceFli

Re: [Mesa-dev] [PATCH v3 38/48] intel/fs: Don't use automatic exec size

2017-10-27 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > The automatic exec size inference can accidentally mess things up if > we're not careful.  For instance, if we have > > add(4)g38.2<4>Dg38.1<8,2,4>Dg38.2<8,2,4>D > > then the destination register will end up having a width of

[Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

2017-10-27 Thread Erik Faye-Lund
This avoids the following build-error when building with emtpy vulkan-drivers and without glx=dri: Meson encountered an error in file src/vulkan/wsi/meson.build, line 30, column 2: Unknown variable "dep_xcb". Signed-off-by: Erik Faye-Lund --- src/meson.build | 4 +++- 1 file changed, 3 insertio

Re: [Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

2017-10-27 Thread Iago Toral
I dropped a few more comments on patches 18-20, 23, 25, 29-31, 34 and 38 but nothing major in general. I have doubts that patch 20 isn't working around some other bug and 38 scares me a little bit but I guess if Jenkins is happy I shouldn't worry too much. Otherwise, patches 16-38 are: Reviewed-

Re: [Mesa-dev] [PATCH v3 35/48] intel/eu: Make automatic exec sizes a configurable option

2017-10-27 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > We have had a feature in codegen for some time that tries to > automatically infer the execution size of an instruction from the > width > of its destination.  For things such as fixed function GS, clipper, > and > SF programs, this is very

Re: [Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor

2017-10-27 Thread Rob Herring
On Fri, Oct 27, 2017 at 6:41 AM, Emil Velikov wrote: > On 26 October 2017 at 23:48, Mauro Rossi wrote: >> Having moved gallium_dri.so library to /vendor/lib/dri >> also symlinks need to be coherently created using TARGET_OUT_VENDOR insted >> of TARGET_OUT >> or all non Intel drivers will not be

Re: [Mesa-dev] [PATCH] formatquery: use correct target check for IMAGE_FORMAT_COMPATIBILITY_TYPE

2017-10-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Oct 27, 2017 at 11:18 AM, Alejandro Piñeiro wrote: > From the spec: >"IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the > resource when used as an image textures is returned in > . This is equivalent to calling GetTexParameter"

Re: [Mesa-dev] [PATCH] Android: egl: add dependency on libnativewindow

2017-10-27 Thread Emil Velikov
On 26 October 2017 at 20:18, Rob Herring wrote: > system/window.h is no longer available by default and is part of > libnativewindow, so add it to the shared libraries. It has to be conditional > because the library is only present in O and later. > > Really, we should only be depending on vndk/wi

Re: [Mesa-dev] [PATCH] formatquery: use correct target check for IMAGE_FORMAT_COMPATIBILITY_TYPE

2017-10-27 Thread Ilia Mirkin
On Fri, Oct 27, 2017 at 5:18 AM, Alejandro Piñeiro wrote: > From the spec: >"IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the > resource when used as an image textures is returned in > . This is equivalent to calling GetTexParameter" > > So we would need to return Non

[Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Tapani Pälli
Patch uses mem_ctx for allocation to ensure param array gets freed later, in blorp clear case this happens in blorp_params_get_clear_kernel. ==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of 193 ==6164==at 0x4C2EB6B: malloc (vg_replace_malloc.c:299) ==6164==by 0x12E31C

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 27/10/17 13:55, Tapani Pälli wrote: Patch uses mem_ctx for allocation to ensure param array gets freed later, in blorp clear case this happens in blorp_params_get_clear_kernel. ==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of 193 ==6164==

[Mesa-dev] [PATCH v3] radv: Implement VK_AMD_shader_info

2017-10-27 Thread Alex Smith
This allows an app to query shader statistics and get a disassembly of a shader. RenderDoc git has support for it, so this allows you to view shader disassembly from a capture. When this extension is enabled on a device (or when tracing), we now disable pipeline caching, since we don't get the sha

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Emil Velikov
On 27 October 2017 at 13:55, Tapani Pälli wrote: > Patch uses mem_ctx for allocation to ensure param array gets freed > later, in blorp clear case this happens in blorp_params_get_clear_kernel. > > ==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of 193 > ==6164==at 0x4C2EB6

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Lionel Landwerlin
On 27/10/17 14:46, Emil Velikov wrote: On 27 October 2017 at 13:55, Tapani Pälli wrote: Patch uses mem_ctx for allocation to ensure param array gets freed later, in blorp clear case this happens in blorp_params_get_clear_kernel. ==6164== 48 bytes in 1 blocks are definitely lost in loss record

[Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

2017-10-27 Thread Juan A. Suarez Romero
This patch is mostly a patch done by Ilia Mirkin. It fixes KHR-GL45.enhanced_layouts.varying_structure_locations. CC: Ilia Mirkin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103098 Signed-off-by: Juan A. Suarez Romero --- src/compiler/glsl/linker.cpp | 36 +++

Re: [Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

2017-10-27 Thread Ilia Mirkin
On Fri, Oct 27, 2017 at 10:03 AM, Juan A. Suarez Romero wrote: > This patch is mostly a patch done by Ilia Mirkin. > > It fixes KHR-GL45.enhanced_layouts.varying_structure_locations. > > CC: Ilia Mirkin > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103098 > Signed-off-by: Juan A. Suare

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

2017-10-27 Thread Emil Velikov
On 27 October 2017 at 14:53, Lionel Landwerlin wrote: > On 27/10/17 14:46, Emil Velikov wrote: >> >> On 27 October 2017 at 13:55, Tapani Pälli wrote: >>> >>> Patch uses mem_ctx for allocation to ensure param array gets freed >>> later, in blorp clear case this happens in blorp_params_get_clear_ke

Re: [Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

2017-10-27 Thread Eric Engestrom
On Thursday, 2017-10-26 10:10:19 -0700, Dylan Baker wrote: > I have a few tiny nits, but otherwise this seems fine: > Reviewed-by: Dylan Baker > > Quoting Eric Engestrom (2017-10-26 08:40:56) > > Suggested-by: Jordan Justen > > Signed-off-by: Eric Engestrom > > --- > > bin/git_sha1_gen.py

[Mesa-dev] [PATCH mesa] meson: wire up egl/android

2017-10-27 Thread Eric Engestrom
Cc: Rob Herring Cc: Tomasz Figa Signed-off-by: Eric Engestrom --- Completely untested! It's a step in the right direction though; doesn't hurt non-android, and gets android closer to building on meson :) --- meson.build | 13 +++-- src/egl/meson.build | 5 - 2 files changed

Re: [Mesa-dev] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

2017-10-27 Thread Andres Gomez
Bas, this patch looks like it should have been marked as fixing 6ce550453f1 instead of e38685cc62e (?). In any case, I was wondering whether it would be interesting to bring them both to the 17.2 stable queue and whether we would also want Timothy's preceding patch: 087e010b2b3dd83a539f97203909d6

Re: [Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

2017-10-27 Thread Juan A. Suarez Romero
On Fri, 2017-10-27 at 10:27 -0400, Ilia Mirkin wrote: > On Fri, Oct 27, 2017 at 10:03 AM, Juan A. Suarez Romero > wrote: > > This patch is mostly a patch done by Ilia Mirkin. > > > > It fixes KHR-GL45.enhanced_layouts.varying_structure_locations. > > > > CC: Ilia Mirkin > > Bugzilla: https://bu

Re: [Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

2017-10-27 Thread Ilia Mirkin
On Fri, Oct 27, 2017 at 11:07 AM, Juan A. Suarez Romero wrote: > On Fri, 2017-10-27 at 10:27 -0400, Ilia Mirkin wrote: >> On Fri, Oct 27, 2017 at 10:03 AM, Juan A. Suarez Romero >> wrote: >> > This patch is mostly a patch done by Ilia Mirkin. >> > >> > It fixes KHR-GL45.enhanced_layouts.varying_s

Re: [Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

2017-10-27 Thread Eric Engestrom
On Friday, 2017-10-27 13:55:25 +0200, Erik Faye-Lund wrote: > This avoids the following build-error when building with emtpy > vulkan-drivers and without glx=dri: > > Meson encountered an error in file src/vulkan/wsi/meson.build, line 30, > column 2: > Unknown variable "dep_xcb". > > Signed-off-b

Re: [Mesa-dev] [PATCH 1/7] svga: Use __asm__ instead of asm

2017-10-27 Thread Brian Paul
On 10/27/2017 05:21 AM, Emil Velikov wrote: On 27 October 2017 at 00:57, Dylan Baker wrote: Which allows the code to be compiled with c99 instead of gnu99. A little history. This code is guarded by #ifdef __GNUC__, so it's only compiled with autotools on *nix, SCons with MSVC wont hit that cod

[Mesa-dev] [PATCH] radv: disable depth writes when depth test is not enabled

2017-10-27 Thread Samuel Pitoiset
Found by inspection. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index c25642c966..f5ebcda883 100644 --- a/src/amd/vulkan/radv_pipeline

Re: [Mesa-dev] [PATCH 1/7] util: move futex helpers into futex.h

2017-10-27 Thread Marek Olšák
For patches 1-4, 6, 7, assuming you fix the double unlock in patch 7: Reviewed-by: Marek Olšák Marek On Sun, Oct 22, 2017 at 8:33 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/util/Makefile.sources | 1 + > src/util/futex.h | 51 > +

[Mesa-dev] [PATCH] intel: common: silence compiler warning

2017-10-27 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 395ff02908a..55e7305117c 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/common

[Mesa-dev] [PATCH] util: hashtable: make hashing prototypes match

2017-10-27 Thread Lionel Landwerlin
It seems nobody's using the string hashing function. If you try to pass it directly to the hashtable creation function, you'll get compiler warning for non matching prototypes. Let's make them match. Signed-off-by: Lionel Landwerlin --- src/util/hash_table.c | 3 ++- src/util/hash_table.h | 2 +-

Re: [Mesa-dev] [PATCH] radv: disable depth writes when depth test is not enabled

2017-10-27 Thread Marek Olšák
The hw disables depth writes automatically. Marek On Fri, Oct 27, 2017 at 6:27 PM, Samuel Pitoiset wrote: > Found by inspection. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vul

Re: [Mesa-dev] [PATCH] radv: disable depth writes when depth test is not enabled

2017-10-27 Thread Samuel Pitoiset
On 10/27/2017 06:49 PM, Marek Olšák wrote: The hw disables depth writes automatically. Okay, good to know. Thanks! Marek On Fri, Oct 27, 2017 at 6:27 PM, Samuel Pitoiset wrote: Found by inspection. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 8 +++- 1 fi

Re: [Mesa-dev] [PATCH] util: hashtable: make hashing prototypes match

2017-10-27 Thread Kenneth Graunke
On Friday, October 27, 2017 9:43:45 AM PDT Lionel Landwerlin wrote: > It seems nobody's using the string hashing function. If you try to > pass it directly to the hashtable creation function, you'll get > compiler warning for non matching prototypes. Let's make them match. > > Signed-off-by: Lione

[Mesa-dev] [PATCH] meson: Add a dependency on nir_opcodes_h for freedreno

2017-10-27 Thread Dylan Baker
This fixes a race condition in the build. cc: Rob Clark Signed-off-by: Dylan Baker --- src/gallium/drivers/freedreno/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/meson.build b/src/gallium/drivers/freedreno/meson.build index 028be

Re: [Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

2017-10-27 Thread Dylan Baker
This just papers over the actual problem, that dep_xcb isn't declared as an empty list with the other glx dependencies. Dylan Quoting Erik Faye-Lund (2017-10-27 04:55:25) > This avoids the following build-error when building with emtpy > vulkan-drivers and without glx=dri: > > Meson encountered

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

2017-10-27 Thread Kenneth Graunke
On Thursday, October 26, 2017 11:16:06 AM PDT Eric Anholt wrote: > Gwan-gyeong Mun writes: > > > Hi, > > > > These Patch v5 series modified with new helper function series [1]. > > > > These series only have mesa for tizen feature. > > > > [1] https://patchwork.freedesktop.org/series/32577/ > >

[Mesa-dev] [PATCH] meson: declare an empty xcb dependency

2017-10-27 Thread Dylan Baker
This is needed in cases where xcb isn't actually needed as a dependency, but may still be included somewhere. cc: Erik Faye-Lund cc: Eric Engestrom Signed-off-by: Dylan Baker --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 875f9d4d294..102b75

Re: [Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

2017-10-27 Thread Erik Faye-Lund
Yeah, I kinda got that feeling. Your approach seems better. On Oct 27, 2017 19:22, "Dylan Baker" wrote: This just papers over the actual problem, that dep_xcb isn't declared as an empty list with the other glx dependencies. Dylan Quoting Erik Faye-Lund (2017-10-27 04:55:25) > This avoids the f

Re: [Mesa-dev] [PATCH mesa] meson: wire up egl/android

2017-10-27 Thread Dylan Baker
Whooo! Thanks for doing this! Quoting Eric Engestrom (2017-10-27 07:40:17) > Cc: Rob Herring > Cc: Tomasz Figa > Signed-off-by: Eric Engestrom > --- > Completely untested! > It's a step in the right direction though; doesn't hurt non-android, > and gets android closer to building on meson :) >

Re: [Mesa-dev] [PATCH] meson: Add a dependency on nir_opcodes_h for freedreno

2017-10-27 Thread Mark Janes
Reviewed-by: Mark Janes Dylan Baker writes: > This fixes a race condition in the build. > > cc: Rob Clark > Signed-off-by: Dylan Baker > --- > src/gallium/drivers/freedreno/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/freedreno/meso

[Mesa-dev] Mesa 17.2.4 release candidate

2017-10-27 Thread Andres Gomez
Hello list, The candidate for the Mesa 17.2.4 is now available. Currently we have: - 21 queued - 10 nominated (outstanding) - and 6 rejected patches In the current queue we have: In Mesa Core we have included a change to prevent KOTOR from breaking when in combination with the ATI fragment s

Re: [Mesa-dev] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

2017-10-27 Thread Bas Nieuwenhuizen
On Fri, Oct 27, 2017 at 5:03 PM, Andres Gomez wrote: > Bas, this patch looks like it should have been marked as fixing > 6ce550453f1 instead of e38685cc62e (?). Well my reasoning was that the bug got "visible" when we enabled Vega. The patch you refer to fixed part of it, but not all of it, and t

[Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1

2017-10-27 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index 4ccfd48919..b6e800aa90 100644 --- a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 2/2] i965/gen10: Don't set Antialiasing Enable in 3DSTATE_RASTER if num_samples > 1

2017-10-27 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index b6e800aa90..2fb6420cee 100644 --- a/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] meson: declare an empty xcb dependency

2017-10-27 Thread Eric Engestrom
On Friday, 2017-10-27 10:25:33 -0700, Dylan Baker wrote: > This is needed in cases where xcb isn't actually needed as a dependency, > but may still be included somewhere. > > cc: Erik Faye-Lund > cc: Eric Engestrom better indeed :) Reviewed-by: Eric Engestrom > Signed-off-by: Dylan Baker > -

Re: [Mesa-dev] [PATCH 2/2] i965/gen10: Don't set Antialiasing Enable in 3DSTATE_RASTER if num_samples > 1

2017-10-27 Thread Anuj Phogat
On Fri, Oct 27, 2017 at 10:50 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > b/src/mesa/drivers/dri/i965/genX_state_upl

Re: [Mesa-dev] [PATCH 9/9] meson: build gallium based osmesa

2017-10-27 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-27 02:28:05) > On Thursday, 2017-10-26 13:55:35 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-10-26 02:40:20) > > > On Wednesday, 2017-10-25 15:58:23 -0700, Dylan Baker wrote: > > > > +if with_shared_glapi > > > > + osmesa_link_with += libglapi > > > >

Re: [Mesa-dev] Mesa 17.2.4 release candidate

2017-10-27 Thread Ilia Mirkin
On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: > Rejected (6) > > > Ilia Mirkin (1): > glsl: fix derived cs variables > > Reason: Commit is too big for stable at this point. The issue it fixes in regular compute shaders is slightly difficult to hit (but there are piglits

[Mesa-dev] [PATCH] meson: Add threads dependencies to glsl_compiler executable

2017-10-27 Thread Dylan Baker
Fixes compiling the optional standalone glsl compiler. Reported-by: DrNick (on irc) Signed-off-by: Dylan Baker --- This is not compiled by default, but can be built by: meson build ninja -C build src/compiler/glsl/glsl_compiler src/compiler/glsl/meson.build | 2 +- 1 file changed, 1 insertion(

[Mesa-dev] [AppVeyor] mesa master #5967 failed

2017-10-27 Thread AppVeyor
Build mesa 5967 failed Commit f121a669c7 by Dylan Baker on 10/24/2017 10:52 PM: meson: build gallium based osmesa\n\nThis has been tested with the osdemo from mesa-demos\n\nv2: - Add SELinux dependency\n- fix typo GALLIUM_LLVM -> GALLIUM_LLVMPIPE\n\nSigned-

Re: [Mesa-dev] [PATCH] meson: declare an empty xcb dependency

2017-10-27 Thread Erik Faye-Lund
On Fri, Oct 27, 2017 at 7:25 PM, Dylan Baker wrote: > This is needed in cases where xcb isn't actually needed as a dependency, > but may still be included somewhere. > > cc: Erik Faye-Lund > cc: Eric Engestrom > Signed-off-by: Dylan Baker Tested-by: Erik Faye-Lund

Re: [Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor

2017-10-27 Thread Mauro Rossi
2017-10-27 14:28 GMT+02:00 Rob Herring : > On Fri, Oct 27, 2017 at 6:41 AM, Emil Velikov > wrote: > > On 26 October 2017 at 23:48, Mauro Rossi wrote: > >> Having moved gallium_dri.so library to /vendor/lib/dri > >> also symlinks need to be coherently created using TARGET_OUT_VENDOR > insted of T

Re: [Mesa-dev] [PATCH] meson: declare an empty xcb dependency

2017-10-27 Thread Dylan Baker
Well, I went to push this, apparently this was in one of the osmesa patches as an unrelated change.. :/ So it's fixed. Dylan Quoting Dylan Baker (2017-10-27 10:25:33) > This is needed in cases where xcb isn't actually needed as a dependency, > but may still be included somewhere. > > cc: Er

Re: [Mesa-dev] [PATCH v3 18/48] i965/fs/nir: Minor refactor of store_output

2017-10-27 Thread Jason Ekstrand
On Thu, Oct 26, 2017 at 11:35 PM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > Stop retyping the output of shuffle_64bit_data_for_32bit_write. It's > > always BRW_REGISTER_TYPE_D which is perfectly fine for writing out. > > Also, when we change get_nir_src to

Re: [Mesa-dev] [PATCH v3 19/48] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

2017-10-27 Thread Jason Ekstrand
On Thu, Oct 26, 2017 at 11:53 PM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > --- > > src/intel/compiler/brw_fs_nir.cpp | 33 +-- > > -- > > 1 file changed, 21 insertions(+), 12 deletions(-) > > > > diff --git a/src/intel/compiler/

[Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

2017-10-27 Thread Nanley Chery
Only use CCS_E to render to a texture that is CCS_E-compatible with the original texture's miptree (linear) format. This prevents render operations from writing data that can't be decoded with the original miptree format. On Gen10, with the new CCS_E-enabled formats handled, this enables the drive

[Mesa-dev] [RFC 1/2] intel/isl: Disable some gen10 CCS_E formats for now

2017-10-27 Thread Nanley Chery
CannonLake additionally supports R11G11B10_FLOAT and four 10-10-10-2 formats with CCS_E. None of these formats fit within the current blorp_copy framework so disable them until support is added. Signed-off-by: Nanley Chery Cc: Jason Ekstrand --- Jason, do you think we modify blorp instead of mo

Re: [Mesa-dev] [PATCH v3 20/48] intel/fs: Protect opt_algebraic from OOB BROADCAST indices

2017-10-27 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 12:09 AM, Iago Toral wrote: > > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > --- > > src/intel/compiler/brw_fs.cpp | 10 -- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/src/intel/compiler/brw_fs.cpp > > b/src/intel/compi

[Mesa-dev] [PATCH v2 0/3] Fix for PerVertexValidation CTS test

2017-10-27 Thread Neil Roberts
Hi, Here is a v2 of Eduardo’s patches to fix the PerVertexValidation CTS test. They were originally posted here: https://lists.freedesktop.org/archives/mesa-dev/2017-March/146667.html The patches needed a non-trivial rebase. The previous discussion was left with a note saying that there are more

[Mesa-dev] [PATCH v2 1/3] glsl_parser_extra: Add utility to copy symbols between symbol tables

2017-10-27 Thread Neil Roberts
From: Eduardo Lima Mitev Some symbols gathered in the symbols table during parsing are needed later for the compile and link stages, so they are moved along the process. Currently, only functions and non-temporary variables are copied between symbol tables. However, the built-in gl_PerVertex inte

[Mesa-dev] [PATCH v2 3/3] glsl/linker: Check that re-declared, inter-shader built-in blocks match

2017-10-27 Thread Neil Roberts
From: Eduardo Lima Mitev >From GLSL 4.5 spec, section "7.1 Built-In Language Variables", page 130 of the PDF states: "If multiple shaders using members of a built-in block belonging to the same interface are linked together in the same program, they must all redeclare the built-in

[Mesa-dev] [PATCH v2 2/3] glsl: Use the utility function to copy symbols between symbol tables

2017-10-27 Thread Neil Roberts
From: Eduardo Lima Mitev This effectively factorizes a couple of similar routines. v2 (Neil Roberts): Non-trivial rebase on master Signed-off-by: Eduardo Lima Mitev Signed-off-by: Neil Roberts --- src/compiler/glsl/glsl_parser_extras.cpp | 25 +++-- src/compiler/glsl/link

Re: [Mesa-dev] [PATCH v3 25/48] intel/cs: Drop max_dispatch_width checks from compile_cs

2017-10-27 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 1:18 AM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > The only things that adjust fs_visitor::max_dispatch_width are render > > target writes which don't happen in compute shaders so they're > > pointless. > > --- > > src/intel/compiler

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-27 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 2:11 AM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > Previously, brw_nir_lower_intrinsics added the param and then emitted > > a > > load_uniform intrinsic to load it directly. This commit switches > > things > > over to use a specific

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-27 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 12:35 AM, Iago Toral wrote: > This sounds good to me, but I guess it is not really fixing anything, > right? I ask because the subject claims that this patch does something > that the original code was already supposed to be doing. > This patch is a bit of an artifact of

Re: [Mesa-dev] [PATCH v3 38/48] intel/fs: Don't use automatic exec size

2017-10-27 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 4:47 AM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > The automatic exec size inference can accidentally mess things up if > > we're not careful. For instance, if we have > > > > add(4)g38.2<4>Dg38.1<8,2,4>Dg38.2<8,2,4>D > >

Re: [Mesa-dev] [PATCH v3 31/48] intel/cs: Re-run final NIR optimizations for each SIMD size

2017-10-27 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 3:03 AM, Iago Toral wrote: > This should be squashed into the previous commit > Oops... Fixed. > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > With the advent of SPIR-V subgroup operations, compute shaders will > > have > > to be slightly different depend

Re: [Mesa-dev] [PATCH 1/2] intel/genxml: Fix decoding of groups with fields smaller than a DWord.

2017-10-27 Thread Jordan Justen
On 2017-10-25 21:17:13, Kenneth Graunke wrote: > Groups containing fields smaller than a DWord were not being decoded > correctly. For example: > > > > > > gen_field_iterator_next would properly walk over each element of the > array, incrementing group_iter, and calling iter_gro

Re: [Mesa-dev] [RFC 1/2] intel/isl: Disable some gen10 CCS_E formats for now

2017-10-27 Thread Jason Ekstrand
Thanks for doing this in isl_format_supports_ccs_e instead of changing the table! Reviewed-by: Jason Ekstrand On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery wrote: > CannonLake additionally supports R11G11B10_FLOAT and four 10-10-10-2 > formats with CCS_E. None of these formats fit within the

Re: [Mesa-dev] [PATCH] intel: common: silence compiler warning

2017-10-27 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2017-10-27 09:44:14, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/common/gen_decoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c > index

Re: [Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

2017-10-27 Thread Jason Ekstrand
On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery wrote: > Only use CCS_E to render to a texture that is CCS_E-compatible with the > original texture's miptree (linear) format. This prevents render > operations from writing data that can't be decoded with the original > miptree format. > > On Gen10,

[Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor (v2)

2017-10-27 Thread Mauro Rossi
Having moved gallium_dri.so library to /vendor/lib/dri also symlinks need to be coherently created using TARGET_OUT_VENDOR instead of TARGET_OUT or all non Intel drivers will not be loaded with Android N and earlier, thus causing SurfaceFlinger SIGABRT (v2) simplification of post install command

[Mesa-dev] [PATCH] gallium; s/unsigned/enum pipe_prim_type/

2017-10-27 Thread Brian Paul
In the vbuf_render::set_primitive() functions. --- src/gallium/auxiliary/draw/draw_vbuf.h | 3 ++- src/gallium/drivers/i915/i915_prim_vbuf.c| 2 +- src/gallium/drivers/llvmpipe/lp_setup_vbuf.c | 2 +- src/gallium/drivers/nouveau/nv30/nv30_draw.c | 2 +- src/gallium/drivers/r300/r300_rend

[Mesa-dev] [PATCH] scons: fix scons build to find generated glapitable.h

2017-10-27 Thread Brian Paul
Fixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path" --- src/mapi/glapi/SConscript | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mapi/glapi/SConscript b/src/mapi/glapi/SConscript index 994778a..08fed6c 100644 --- a/src/mapi/glapi/SConscript +++ b/src/mapi/glapi/SConscri

Re: [Mesa-dev] [PATCH v2] i965 : optimized bucket index calculation

2017-10-27 Thread Ian Romanick
On 10/24/2017 02:42 AM, Muthukumar, Aravindan wrote: >> -Original Message- >> From: Ian Romanick [mailto:i...@freedesktop.org] >> Sent: Friday, October 20, 2017 9:51 AM >> To: Muthukumar, Aravindan ; mesa- >> d...@lists.freedesktop.org >> Cc: J Karanje, Kedar ; Tamminen, Eero T >> >> Subje

Re: [Mesa-dev] [PATCH] gallium; s/unsigned/enum pipe_prim_type/

2017-10-27 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Am 27.10.2017 um 23:16 schrieb Brian Paul: > In the vbuf_render::set_primitive() functions. > --- > src/gallium/auxiliary/draw/draw_vbuf.h | 3 ++- > src/gallium/drivers/i915/i915_prim_vbuf.c| 2 +- > src/gallium/drivers/llvmpipe/lp_setup_vbuf.c | 2 +- >

  1   2   >