Re: [Mesa-dev] [PATCH 1/4] i965: Convert brw_bufmgr to use C11 mutexes instead of pthreads.

2017-09-26 Thread Timothy Arceri
On 25/09/17 03:37, Kenneth Graunke wrote: On Sunday, September 24, 2017 7:36:17 AM PDT Jason Ekstrand wrote: On September 24, 2017 01:02:21 Kenneth Graunke wrote: There's no real advantage or disadvantage here, it's just for stylistic consistency with the rest of the codebase. Didn't Kristia

[Mesa-dev] [PATCH] i965: Convert brw->*_program into a brw->programs[i] array.

2017-09-26 Thread Kenneth Graunke
This makes it easier to loop over programs. --- src/mesa/drivers/dri/i965/brw_binding_tables.c| 6 +-- src/mesa/drivers/dri/i965/brw_context.h | 7 +-- src/mesa/drivers/dri/i965/brw_cs.c| 6 ++- src/mesa/drivers/dri/i965/brw_curbe.c | 12 +++-- src/mesa

[Mesa-dev] [Bug 102852] Scons: Support the new Scons 3.0.0

2017-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102852 Alex Granni changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH] vc4: Fix infinite retry in vc4_bo_alloc()

2017-09-26 Thread Boris Brezillon
cleared_and_retried is always reset to false when jumping to the retry label, thus leading to an infinite retry loop. Fix that by moving the cleared_and_retried variable definitions at the beginning of the function. While we're at it, move the create variable with the other local variables and exp

[Mesa-dev] [PATCH] i965: skip reading clip distances from the URB for the FS if possible

2017-09-26 Thread Iago Toral Quiroga
we can skip these slots when they are not read in the fragment shader and they are positioned right after a VUE header that we are already skipping. We also need to ensure that we are passing at least one other varying, since that is a hardware requirement. This helps alleviate a problem introduce

Re: [Mesa-dev] [PATCH v2 7/7] i965: make use of nir linking

2017-09-26 Thread Kenneth Graunke
On Monday, September 25, 2017 6:23:13 PM PDT Timothy Arceri wrote: > For now linking is just removing unused varyings between stages. > > shader-db results BDW: > > total instructions in shared programs: 13198288 -> 13191693 (-0.05%) > instructions in affected programs: 48325 -> 41730 (-13.65%) >

Re: [Mesa-dev] [PATCH 05/22] i965: correctly assign SamplerCount of INTERFACE_DESCRIPTOR_DATA

2017-09-26 Thread Kenneth Graunke
On Monday, September 25, 2017 5:46:32 AM PDT Lionel Landwerlin wrote: > I'm genuinely surprised we didn't noticed this problem before :| > > Fixes: 71bfb44005bf ("i965: Port brw_cs_state tracked state to genxml.") > Reviewed-by: Lionel Landwerlin > Cc: "17.2" I'm not - these fields are just use

Re: [Mesa-dev] MESA and KOTOR

2017-09-26 Thread Federico Dossena
Hello everyone, you may remember that a few months ago I was trying to fix KOTOR to work with Mesa to use the Gallium llvmpipe software renderer. Well, it's been a while and I'm happy to see that things are a bit better with Mesa 17.2. The game still crashes, but we're closer to fixing it.

Re: [Mesa-dev] [PATCH] i965: Convert brw->*_program into a brw->programs[i] array.

2017-09-26 Thread Alejandro Piñeiro
On 26/09/17 09:39, Kenneth Graunke wrote: > This makes it easier to loop over programs. > --- > src/mesa/drivers/dri/i965/brw_binding_tables.c| 6 +-- > src/mesa/drivers/dri/i965/brw_context.h | 7 +-- > src/mesa/drivers/dri/i965/brw_cs.c| 6 ++- > src/mesa/drive

[Mesa-dev] [PATCH 2/2] anv: add an assertion in genX(BeginCommandBuffer)

2017-09-26 Thread Gwan-gyeong Mun
To check a valid usage requirement. Signed-off-by: Mun Gwan-gyeong --- src/intel/vulkan/genX_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index fbc1995709..3559399019 100644 --- a/src/intel/vulkan/genX_c

[Mesa-dev] [PATCH 1/2] radv: add an assertion in radv_BeginCommandBuffer()

2017-09-26 Thread Gwan-gyeong Mun
To check a valid usage requirement. CID: 1401616 Signed-off-by: Mun Gwan-gyeong --- src/amd/vulkan/radv_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 1e0e366820..4db9d7628c 100644 --- a/src/amd/vulkan/r

Re: [Mesa-dev] [PATCH] glsl: Trigger precision mismatch error only if both symbols are used

2017-09-26 Thread Tomasz Figa
Hi Ian, An update on my testing inline. On Tue, Sep 26, 2017 at 7:13 AM, Tomasz Figa wrote: > On Tue, Sep 26, 2017 at 6:21 AM, Tomasz Figa wrote: >> Hi Ian, >> >> On Tue, Sep 26, 2017 at 5:59 AM, Ian Romanick wrote: >>> On 09/25/2017 02:53 AM, Tomasz Figa wrote: Commit 259fc505454ea6a67ae

[Mesa-dev] [PATCH] glsl: Allow precision mismatch on dead data with GLSL ES 1.00

2017-09-26 Thread Tomasz Figa
Commit 259fc505454ea6a67aeacf6cdebf1398d9947759 added linker error for mismatching uniform precision, as required by GLES 3.0 specification and conformance test-suite. Several Android applications, including Forge of Empires, have shaders which violate this rule, on a dead varying that will be eli

Re: [Mesa-dev] [PATCH 1/2] radv: add an assertion in radv_BeginCommandBuffer()

2017-09-26 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 09/26/2017 10:14 AM, Gwan-gyeong Mun wrote: To check a valid usage requirement. CID: 1401616 Signed-off-by: Mun Gwan-gyeong --- src/amd/vulkan/radv_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/v

Re: [Mesa-dev] [PATCH v2 7/7] i965: make use of nir linking

2017-09-26 Thread Timothy Arceri
On 26/09/17 17:50, Kenneth Graunke wrote: On Monday, September 25, 2017 6:23:13 PM PDT Timothy Arceri wrote: For now linking is just removing unused varyings between stages. shader-db results BDW: total instructions in shared programs: 13198288 -> 13191693 (-0.05%) instructions in affected p

Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

2017-09-26 Thread Eric Engestrom
On 25 September 2017 12:01:33 BST, Tomasz Figa wrote: > On Mon, Sep 25, 2017 at 7:21 PM, Eric Engestrom > wrote: > > On Saturday, 2017-09-23 13:37:29 +0900, Tomasz Figa wrote: > >> On Wed, Sep 20, 2017 at 7:47 PM, Eric Engestrom > >> wrote: > >> > On Tuesday, 2017-09-19 17:19:59 +, Emil Veli

Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

2017-09-26 Thread Tomasz Figa
On Tue, Sep 26, 2017 at 6:44 PM, Eric Engestrom wrote: > On 25 September 2017 12:01:33 BST, Tomasz Figa wrote: >> On Mon, Sep 25, 2017 at 7:21 PM, Eric Engestrom >> wrote: >> > On Saturday, 2017-09-23 13:37:29 +0900, Tomasz Figa wrote: >> >> On Wed, Sep 20, 2017 at 7:47 PM, Eric Engestrom >> >>

Re: [Mesa-dev] [PATCH v2 7/7] i965: make use of nir linking

2017-09-26 Thread Timothy Arceri
On 26/09/17 17:50, Kenneth Graunke wrote: On Monday, September 25, 2017 6:23:13 PM PDT Timothy Arceri wrote: For now linking is just removing unused varyings between stages. shader-db results BDW: total instructions in shared programs: 13198288 -> 13191693 (-0.05%) instructions in affected p

[Mesa-dev] [PATCH] etnaviv: Set up GC3000 states, fix point sprite rendering

2017-09-26 Thread Wladimir J. van der Laan
Set up new states that the blob started setting for GC3000 consistently. This makes sure that when another test or driver leaves the GPU in unpredictable state, these states are set up correctly for our rendering. Also, setting PA_VIEWPORT_UNK00A84 to fui(8192.0) is necessary to make point sprite

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-09-26 Thread Juan A. Suarez Romero
On Mon, 2017-05-01 at 12:11 -0400, Ilia Mirkin wrote: > On Mon, May 1, 2017 at 12:09 PM, Samuel Pitoiset > wrote: > > On 05/01/2017 05:59 PM, Ilia Mirkin wrote: > > > > > > I think this is off. It shouldn't matter what the code sequence is, > > > it's all representable. You need to teach replaceZ

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-09-26 Thread Samuel Pitoiset
On 09/26/2017 12:29 PM, Juan A. Suarez Romero wrote: On Mon, 2017-05-01 at 12:11 -0400, Ilia Mirkin wrote: On Mon, May 1, 2017 at 12:09 PM, Samuel Pitoiset wrote: On 05/01/2017 05:59 PM, Ilia Mirkin wrote: I think this is off. It shouldn't matter what the code sequence is, it's all represe

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] anv: Stop racing relocation offsets

2017-09-26 Thread Juan A. Suarez Romero
On Mon, 2017-06-26 at 22:39 +0300, Andres Gomez wrote: > Jason, it doesn't seem like this patch has landed in master. Are you in > need of review or is it that this has been superseded? > Gently ping to know what is the status for this patch. Thaks in advance. J.A. > Thanks! > > On

Re: [Mesa-dev] [PATCH] i965: skip reading clip distances from the URB for the FS if possible

2017-09-26 Thread Ilia Mirkin
Perhaps a debug message would be warranted in such a situation? I suspect it would be difficult to debug, esp if it came up in a regular application. On Sep 26, 2017 3:50 AM, "Iago Toral Quiroga" wrote: we can skip these slots when they are not read in the fragment shader and they are positioned

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-09-26 Thread Ilia Mirkin
On Tue, Sep 26, 2017 at 6:30 AM, Samuel Pitoiset wrote: > > > On 09/26/2017 12:29 PM, Juan A. Suarez Romero wrote: >> >> On Mon, 2017-05-01 at 12:11 -0400, Ilia Mirkin wrote: >>> >>> On Mon, May 1, 2017 at 12:09 PM, Samuel Pitoiset >>> wrote: On 05/01/2017 05:59 PM, Ilia Mirkin wrote: >

Re: [Mesa-dev] [PATCH 2/5] util: Add tests for the string buffer

2017-09-26 Thread Nicolai Hähnle
On 21.09.2017 21:13, Thomas Helland wrote: Fixed the missing newline at the end of this cpp file locally. This is the only patch left in the series without an RB. If there's no objections I plan on pushing this once I get an RB on this. Someone mind having a look at it? Sorry, I forgot to send

Re: [Mesa-dev] [PATCH 2/2] radeonsi: remove useless check in si_blit_decompress_color()

2017-09-26 Thread Nicolai Hähnle
Gert's suggestion makes sense. Apart from that, the series is Reviewed-by: Nicolai Hähnle On 22.09.2017 09:22, Samuel Pitoiset wrote: That's unnecessary to double-check that dcc_offset is not 0 because all callers already check that. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/

Re: [Mesa-dev] MESA and KOTOR

2017-09-26 Thread Nicolai Hähnle
On 25.09.2017 18:50, Federico Dossena wrote: Hello everyone, you may remember that a few months ago I was trying to fix KOTOR to work with Mesa to use the Gallium llvmpipe software renderer. Well, it's been a while and I'm happy to see that things are a bit better with Mesa 17.2. The game sti

Re: [Mesa-dev] [PATCH 2/2] gallium/util: use new util_vasprintf() function

2017-09-26 Thread Nicolai Hähnle
Thanks :) Both patches: Reviewed-by: Nicolai Hähnle On 25.09.2017 23:08, Brian Paul wrote: --- src/gallium/auxiliary/util/u_log.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_log.c b/src/gallium/auxiliary/util/u_log.c index 359b3e1..d

Re: [Mesa-dev] [PATCH 5/5] radeonsi: allow out-of-order rasterization in commutative blending cases

2017-09-26 Thread Nicolai Hähnle
On 21.09.2017 23:44, Matias N. Goldberg wrote: I'm reviewing the patch and there's something that confuses me about radeonsi_assume_no_z_fights (which got implemented in a later patch). It appears to be that part of the logic is flawed. Please correct me whenever you feel I misunderstood what

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-26 Thread Jose Fonseca
On 25/09/17 14:30, Eric Engestrom wrote: I pushed the rest of the series. See below for discussion on this patch. On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote: On 19/09/17 15:14, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- scons/custom.py | 2 +- 1 file change

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-26 Thread Ilia Mirkin
On Tue, Sep 26, 2017 at 7:07 AM, Jose Fonseca wrote: > On 25/09/17 14:30, Eric Engestrom wrote: >> >> I pushed the rest of the series. >> See below for discussion on this patch. >> >> >> On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote: >>> >>> On 19/09/17 15:14, Eric Engestrom wrote: >

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

2017-09-26 Thread Juan A. Suarez Romero
On Tue, 2017-09-26 at 06:45 -0400, Ilia Mirkin wrote: > On Tue, Sep 26, 2017 at 6:30 AM, Samuel Pitoiset > wrote: > > > > > > On 09/26/2017 12:29 PM, Juan A. Suarez Romero wrote: > > > > > > On Mon, 2017-05-01 at 12:11 -0400, Ilia Mirkin wrote: > > > > > > > > On Mon, May 1, 2017 at 12:09 PM,

Re: [Mesa-dev] [PATCH] glsl: Trigger precision mismatch error only if both symbols are used

2017-09-26 Thread Eero Tamminen
Hi, On 26.09.2017 11:33, Tomasz Figa wrote: An update on my testing inline. On Tue, Sep 26, 2017 at 7:13 AM, Tomasz Figa wrote: On Tue, Sep 26, 2017 at 6:21 AM, Tomasz Figa wrote: Hi Ian, On Tue, Sep 26, 2017 at 5:59 AM, Ian Romanick wrote: On 09/25/2017 02:53 AM, Tomasz Figa wrote: Com

Re: [Mesa-dev] [PATCH v2 7/7] i965: make use of nir linking

2017-09-26 Thread Eero Tamminen
Hi, On 26.09.2017 12:04, Timothy Arceri wrote: On 26/09/17 17:50, Kenneth Graunke wrote: [...] 2. It would be great to use this in anv as well, especially given that     it has no GLSL IR linking to do this sort of stuff.  Plus, the SPIR-V     might be compiled independently...and when you bui

Re: [Mesa-dev] MESA and KOTOR

2017-09-26 Thread Nicolai Hähnle
On 26.09.2017 12:59, Federico Dossena wrote: The crash is in GLU, and I'm 99% sure that it has to do with the format of that texture. So how about a backtrace? It would be really valuable to have a simple stand-alone reproduction. Cheers, Nicolai I saw a patch from Miklòs Màté a while ago t

Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

2017-09-26 Thread Eric Engestrom
On Tuesday, 2017-09-19 17:19:59 +, Emil Velikov wrote: > From: Emil Velikov > > In order to build EGL, one has to use shared glapi - libglapi.so. > > Thus the dlopen/dlsym dance is no longer needed and we can link to the > library directly. > > This allows us to remove a handful of platform

Re: [Mesa-dev] [PATCH 2/2] radeonsi: remove useless check in si_blit_decompress_color()

2017-09-26 Thread Samuel Pitoiset
On 09/26/2017 12:45 PM, Nicolai Hähnle wrote: Gert's suggestion makes sense. Apart from that, the series is Yeah, I will add an assert over there, thanks! Reviewed-by: Nicolai Hähnle On 22.09.2017 09:22, Samuel Pitoiset wrote: That's unnecessary to double-check that dcc_offset is not 0

Re: [Mesa-dev] [PATCH 2/2] anv: add an assertion in genX(BeginCommandBuffer)

2017-09-26 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Sep 26, 2017 at 1:14 AM, Gwan-gyeong Mun wrote: > To check a valid usage requirement. > > Signed-off-by: Mun Gwan-gyeong > --- > src/intel/vulkan/genX_cmd_buffer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c >

Re: [Mesa-dev] [PATCH] [rfc] spirv/nir: handle casting in OpSampledImage

2017-09-26 Thread Jason Ekstrand
On Mon, Sep 25, 2017 at 7:36 PM, Dave Airlie wrote: > From: Dave Airlie > > %9903 = OpImageSampleDrefExplicitLod %float %14616 %14315 %16081 Lod > %float_0 > %14616 = OpSampledImage %510 %8499 %13137 > > %278 = OpTypeImage %float 2D 1 0 0 1 Unknown > %510 = OpTypeSampledImage %278 > > %8499 = Op

Re: [Mesa-dev] [PATCH v2 7/7] i965: make use of nir linking

2017-09-26 Thread Jason Ekstrand
On September 26, 2017 4:05:04 AM Timothy Arceri wrote: On 26/09/17 17:50, Kenneth Graunke wrote: On Monday, September 25, 2017 6:23:13 PM PDT Timothy Arceri wrote: For now linking is just removing unused varyings between stages. shader-db results BDW: total instructions in shared programs:

Re: [Mesa-dev] [PATCH v3 1/2] etnaviv: fix varying interpolation

2017-09-26 Thread Wladimir J. van der Laan
Hello Lucas, On Fri, Sep 22, 2017 at 11:27:36AM +0200, Lucas Stach wrote: > It seems that newer cores don't use the PA_ATTRIBUTES to decide if the > varying should bypass the flat shading, but derive this from the component > use. This fixes flat shading on GC880+. > > VARYING_COMPONENT_USE_POINT

Re: [Mesa-dev] [PATCH 00/11] glsl, tgsi, radeonsi: ldexp and frexp bug fixes and features

2017-09-26 Thread Nicolai Hähnle
Ping. On 16.09.2017 13:23, Nicolai Hähnle wrote: Hi all, This series was motivated by radeonsi failing some ldexp tests due to not handling denorms correctly and not handling overflows (which GLSL doesn't require, but GLSL ES does). The first patch fixes the GLSL IR lowering of ldexp() to hand

[Mesa-dev] [PATCH 2/3] amd/common: remove ac_shader_abi::chip_class

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle Redundant with the recently added ac_llvm_context::chip_class. --- src/amd/common/ac_nir_to_llvm.c | 21 ++--- src/amd/common/ac_shader_abi.h | 2 -- src/gallium/drivers/radeonsi/si_shader.c | 2 -- 3 files changed, 10 insertions(+), 15 d

[Mesa-dev] [PATCH 3/3] radeonsi: move descriptor logs to after corresponding draw/compute packet

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle It has to happen after descriptor uploads since otherwise we'll print out the wrong GPU list / incorrectly claim descriptor corruption. --- src/gallium/drivers/radeonsi/si_compute.c| 7 +++ src/gallium/drivers/radeonsi/si_state_draw.c | 7 +++ 2 files changed, 6

[Mesa-dev] [PATCH 1/3] gallium/radeon: fix a comment

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeon/cayman_msaa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/cayman_msaa.c b/src/gallium/drivers/radeon/cayman_msaa.c index 33f1040185a..ec6c49bafa0 100644 --- a/src/gallium/drivers/radeon/cayman

[Mesa-dev] [PATCH 0/5] st/mesa,radeonsi: various compiler fixes

2017-09-26 Thread Nicolai Hähnle
Hi all, There isn't much of a theme to this series, except that all those patches are vaguely compiler-related. Please review! Thanks, Nicolai -- src/amd/common/ac_llvm_build.c| 17 + .../drivers/radeonsi/si_state_shaders.c | 8 +--- src/mesa/state_tra

[Mesa-dev] [PATCH 4/5] amd/common: save an instruction in the build_cube_select sequence

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle Avoid a v_cndmask: the absolute value is free due to input modifiers. --- src/amd/common/ac_llvm_build.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 8c050f31a76..71468df

[Mesa-dev] [PATCH 2/5] st/glsl_to_tgsi: fix conditional assignments to packed shader outputs

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle Overriding the default (no-op) swizzle is clearly counter-productive, since the whole point is putting the destination register as one of the source operands so that it remains unmodified when the assignment condition is false. Fragment depth and stencil outputs are a specia

[Mesa-dev] [PATCH 1/5] st/glsl_to_tgsi: fix a use-after-free in merge_two_dsts

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle Found by address sanitizer. The loop here tries to be safe, but in doing so, it ends up doing exactly the wrong thing: the safe foreach is for when the loop variable (inst) could be deleted and nothing else. However, this particular can delete inst's successor, but not inst

[Mesa-dev] [PATCH 5/5] radeonsi/gfx9: fix geometry shaders without output vertices

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle Not that those are super common or useful, but hey! Fun corner cases of the API... Fixes dEQP-GLES31.functional.geometry_shading.emit.* Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_state_shaders.c | 8 +--- 1 file changed, 5 insertions(+),

[Mesa-dev] [PATCH 3/5] amd/common: fix build_cube_select

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle Fix the custom cube coord selection sequence to be identical to the hardware v_cubesc/tc and OpenGL spec. Affects texture sampling with user-provided derivatives. Fixes dEQP-GLES3.functional.shaders.texture_functions.texturegrad.* Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 3/3] radeonsi: fix border color translation for integer textures

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle This fixes the extremely unlikely case that an application uses 0x8000 or 0x3f80 as border color for an integer texture and helps in the also, but perhaps slightly less, unlikely case that 1 is used as a border color. --- src/gallium/drivers/radeonsi/si_descriptors.c

[Mesa-dev] [PATCH 2/3] radeonsi: clamp border colors for upgraded depth textures

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle The hardware does this automatically for unorm formats, but we need to do it manually for unorm depth formats that have been upgraded to Z32_FLOAT. Fixes dEQP-GLES31.functional.texture.border_clamp.range_clamp.nearest_unorm_depth and others. Fixes: d4d9ec55c589 ("radeonsi:

[Mesa-dev] [PATCH 0/3] radeonsi: depth texture clamping and border color fixes

2017-09-26 Thread Nicolai Hähnle
Hi all, radeonsi can transparently upgrade unorm depth textures to float, which means that some of the depth value clamping that is usually performed in hardware must be done manually. Also, setting the border color for integer textures properly requires doing it slightly differently. This is som

[Mesa-dev] [PATCH 1/3] radeonsi: clamp depth comparison value only for fixed point formats

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle The hardware usually does this automatically. However, we upgrade depth to Z32_FLOAT to enable TC-compatible HTILE, which means the hardware no longer clamps the comparison value for us. The only way to tell in the shader whether a clamp is required seems to be to communicat

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_indirect_parameters

2017-09-26 Thread Manolova, Plamena
Hi Ken, Thank you so much for reviewing and helping me out with this! I'll make the changes you suggested to both patches and resubmit. Thanks, Pam On Tue, Sep 26, 2017 at 3:32 AM, Kenneth Graunke wrote: > On Tuesday, August 29, 2017 9:24:01 AM PDT Plamena Manolova wrote: > > We can implement A

[Mesa-dev] [PATCH] radv: fix saved compute state when doing statistics/occlusion queries

2017-09-26 Thread Samuel Pitoiset
We are pushing 16-bytes of constants, so we have to save/restore the same amount of data to avoid data corruption. Signed-off-by: Samuel Pitoiset Cc: 17.2 --- src/amd/vulkan/radv_query.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_query.c b/src/am

[Mesa-dev] [PATCH] st/va: use pipe transfer_map to upload mapped buffer

2017-09-26 Thread Leo Liu
The function pipe_buffer_map() is only for linear pipe buffer, with height as 0, and it's not for any 2D textures. Signed-off-by: Leo Liu Cc: mesa-sta...@lists.freedesktop.org Cc: Mark Thompson --- src/gallium/state_trackers/va/buffer.c | 12 +--- 1 file changed, 9 insertions(+), 3 dele

[Mesa-dev] [PATCH] glsl: do not set the 'smooth' qualifier by default on ES shaders

2017-09-26 Thread Nicolai Hähnle
From: Nicolai Hähnle It leads to surprising states with integer inputs and outputs on vertex processing stages (e.g. geometry stages). Instead, rely on the driver to choose smooth interpolation by default. We still allow varyings to match when one stage declares it as smooth and the other declar

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-26 Thread Jose Fonseca
On 26/09/17 12:20, Ilia Mirkin wrote: On Tue, Sep 26, 2017 at 7:07 AM, Jose Fonseca wrote: On 25/09/17 14:30, Eric Engestrom wrote: I pushed the rest of the series. See below for discussion on this patch. On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote: On 19/09/17 15:14, Eric

Re: [Mesa-dev] MESA and KOTOR

2017-09-26 Thread Federico Dossena
The crash is in GLU, and I'm 99% sure that it has to do with the format of that texture. I saw a patch from Miklòs Màté a while ago that changed something in src/mesa/state_tracker/st_atom_sampler.c to fix this (link: https://patchwork.freedesktop.org/patch/68298/). It never made it to master,

Re: [Mesa-dev] [PATCH v2 7/7] i965: make use of nir linking

2017-09-26 Thread Kenneth Graunke
On Tuesday, September 26, 2017 2:54:28 AM PDT Timothy Arceri wrote: > On 26/09/17 17:50, Kenneth Graunke wrote: > > A couple more thoughts: > > > > 1. We're calling brw_nir_optimize even more now...it might make sense to > > drop it from brw_preprocess_nir, drop it here, and put it once in the

Re: [Mesa-dev] [PATCH] i965: Convert brw->*_program into a brw->programs[i] array.

2017-09-26 Thread Kenneth Graunke
On Tuesday, September 26, 2017 1:13:18 AM PDT Alejandro Piñeiro wrote: > On 26/09/17 09:39, Kenneth Graunke wrote: > > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > > b/src/mesa/drivers/dri/i965/genX_state_upload.c > > index 612761601a2..2a99376e3c2 100644 > > --- a/src/mesa/drivers

[Mesa-dev] [PATCH v3 4/4] meson: build "radv" vulkan driver for radeon hardware

2017-09-26 Thread Dylan Baker
This builds and installs, but I haven't had a chance to test it yet. v2: - enable radv by default - add shader cache support and enforce that it's built for radv v3: - Fix typo in meson_options (Nicholas) - strip trailing 'svn' from llvm version before setting the version preprocesso

[Mesa-dev] [PATCH v3 1/4] intel: use a flag instead of setting PYTHONPATH

2017-09-26 Thread Dylan Baker
Meson doesn't allow setting environment variables for custom targets, so we either need to not pass this as an environment variable or use a shell script to wrap the invocation. The chosen solution has the advantage of working for both autotools and meson. v2: - put rules back in top scope (Ken)

[Mesa-dev] [PATCH v3 2/4] util/ralloc: Don't define assert with magic member without DEBUG

2017-09-26 Thread Dylan Baker
It is possible to have DEBUG disabled but asserts on (NDEBUG(, which cannot build because these asserts work on members that are only present when DEBUG is on. Reviewed-by: Kenneth Graunke Signed-off-by: Dylan Baker --- src/util/ralloc.c | 8 1 file changed, 8 insertions(+) diff --git

[Mesa-dev] [PATCH v3 3/4] meson: Add build Intel "anv" vulkan driver

2017-09-26 Thread Dylan Baker
This allows building and installing the Intel "anv" Vulkan driver using meson and ninja, the driver has been tested against the CTS and has seems to pass the same series of tests (they both segfault when the CTS tries to run wayland wsi tests). There are still a mess of TODO, XXX, and FIXME commen

Re: [Mesa-dev] [Mesa-stable] [PATCH] meta: Fix BlitFramebuffer temp texture setup

2017-09-26 Thread Juan A. Suarez Romero
On Tue, 2017-07-11 at 15:42 +0300, Ville Syrjälä wrote: > On Mon, Jul 10, 2017 at 11:42:18PM +0300, Andres Gomez wrote: > > Ville, has this patch fallen through the cracks ? > > Nope. I've still been looking into the issue whenever I've had a > few minutes to spare. I think I have it more or les f

Re: [Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

2017-09-26 Thread Thomas Helland
I've now pushed the series, so feel free to rebase =) 2017-09-22 16:10 GMT+02:00 Ian Romanick : > This patch is > > Reviewed-by: Ian Romanick > > I have a couple patches that go on top of this particular patch, and I'd > rather rebase before I send them out for review. :) > > On 09/14/2017 03:39

Re: [Mesa-dev] [PATCH] glx: use correct table offset for glAreTexturesResidentEXT

2017-09-26 Thread Juan A. Suarez Romero
On Tue, 2017-07-25 at 11:43 +0100, Emil Velikov wrote: > On 25 July 2017 at 09:12, Nicolai Hähnle wrote: > > On 21.07.2017 16:57, Emil Velikov wrote: > > > > > > From: Emil Velikov > > > > > > The correct offset is 322 as opposed to 332. > > > Broken since the rework of GET_DISPATCH back in ~20

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix border color translation for integer textures

2017-09-26 Thread Gustaw Smolarczyk
2017-09-26 16:46 GMT+02:00 Nicolai Hähnle : > From: Nicolai Hähnle > > This fixes the extremely unlikely case that an application uses > 0x8000 or 0x3f80 as border color for an integer texture and > helps in the also, but perhaps slightly less, unlikely case that 1 is > used as a border co

[Mesa-dev] XDC 2017 feedback

2017-09-26 Thread Daniel Vetter
Hi all, First again big thanks to Stéphane and Jennifer for organizing a great XDC. Like last year we'd like to hear feedback on how this year's XDC went, both the good (and what you'd like to see more of) and the not so good. Talk selection, organization, location, scheduling of talks, anything

Re: [Mesa-dev] [RFC PATCH] radeonsi: flush DB caches when a Z/stencil buffer is attached

2017-09-26 Thread Juan A. Suarez Romero
On Tue, 2017-07-25 at 17:56 +0200, Samuel Pitoiset wrote: > > On 07/25/2017 05:51 PM, Nicolai Hähnle wrote: > > On 25.07.2017 15:29, Samuel Pitoiset wrote: > > > This is a workaround which fixes a rendering issue with Dawn > > > Of War III in full bindless mode because a depth texture most > > > l

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] egl/drm: set the VISUAL_TYPE alongside the VISUAL_ID

2017-09-26 Thread Juan A. Suarez Romero
On Tue, 2017-08-22 at 09:20 +0100, Daniel Stone wrote: > Hi, > > On 21 August 2017 at 18:30, Emil Velikov wrote: > > On 21 August 2017 at 15:44, Daniel Stone wrote: > > > My take on it is that the visual types are defined by the platform, > > > and 0 is a perfectly sensible visual type for a pla

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-09-26 Thread Juan A. Suarez Romero
On Wed, 2017-09-06 at 15:07 +0100, Emil Velikov wrote: > On 5 August 2017 at 00:25, Emil Velikov wrote: > > From: Emil Velikov > > > > As mentioned in previous commit the negative tests in dEQP expect the > > arguments to be evaluated in particular order. > > > > Namely - first the dpy, then th

Re: [Mesa-dev] [RFC PATCH] radeonsi: flush DB caches when a Z/stencil buffer is attached

2017-09-26 Thread Samuel Pitoiset
On 09/26/2017 06:57 PM, Juan A. Suarez Romero wrote: On Tue, 2017-07-25 at 17:56 +0200, Samuel Pitoiset wrote: On 07/25/2017 05:51 PM, Nicolai Hähnle wrote: On 25.07.2017 15:29, Samuel Pitoiset wrote: This is a workaround which fixes a rendering issue with Dawn Of War III in full bindless m

Re: [Mesa-dev] [Mesa-stable] [RFC PATCH] radeonsi: flush DB caches when a Z/stencil buffer is attached

2017-09-26 Thread Juan A. Suarez Romero
On Tue, 2017-09-26 at 19:11 +0200, Samuel Pitoiset wrote: > > On 09/26/2017 06:57 PM, Juan A. Suarez Romero wrote: > > On Tue, 2017-07-25 at 17:56 +0200, Samuel Pitoiset wrote: > > > > > > On 07/25/2017 05:51 PM, Nicolai Hähnle wrote: > > > > On 25.07.2017 15:29, Samuel Pitoiset wrote: > > > > >

Re: [Mesa-dev] XDC 2017 feedback

2017-09-26 Thread Andres Rodriguez
Hi, A small piece of feedback from those of us watching remotely. It would be nice to have a simple to access index for the long livestream videos. I think the XDC 2017 wiki page would be a good place for this information. A brief example: Presentation Title | Presenter Name | Link with tim

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

2017-09-26 Thread Juan A. Suarez Romero
On Thu, 2017-09-21 at 10:39 -0500, Ian Romanick wrote: > On 09/20/2017 03:12 AM, Juan A. Suarez Romero wrote: > > On Sat, 2017-07-08 at 02:03 +0300, Andres Gomez wrote: > > > Ian, it looks like we could want this patch (and the others from the > > > series when they land) in -stable (?) > > > > >

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-09-26 Thread Juan A. Suarez Romero
On Mon, 2017-09-25 at 16:25 +0900, Tomasz Figa wrote: > On Fri, Aug 11, 2017 at 1:31 PM, Tomasz Figa wrote: > > On Fri, Aug 11, 2017 at 2:29 AM, Emil Velikov > > wrote: > > > On 10 August 2017 at 14:59, Tomasz Figa wrote: > > > > dri2_fallback_swap_interval() currently used to stub out swap int

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix border color translation for integer textures

2017-09-26 Thread Nicolai Hähnle
On 26.09.2017 18:55, Gustaw Smolarczyk wrote: 2017-09-26 16:46 GMT+02:00 Nicolai Hähnle : From: Nicolai Hähnle This fixes the extremely unlikely case that an application uses 0x8000 or 0x3f80 as border color for an integer texture and helps in the also, but perhaps slightly less, unlik

[Mesa-dev] [PATCH] glx: Be slightly more tolerant in glXImportContext

2017-09-26 Thread Adam Jackson
Ugh the GLX code. __GLX_MAX_CONTEXT_PROPS is 3 because glxproto.h is just a pile of ancient runes, so when the server begins sending more than 3 context properties this code refuses to work _at all_. This extension is pretty obscure, so this probably isn't a big deal (if it was we'd need to hack t

Re: [Mesa-dev] [PATCH 1/2] swr: Handle resource across context changes

2017-09-26 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Sep 25, 2017, at 5:28 PM, George Kyriazis > wrote: > > Swr caches fb contents in tiles. Those tiles are stored on a per-context > basis. > > When switching contexts that share resources we need to make sure that > the tiles of the old context are being store

Re: [Mesa-dev] [PATCH 2/2] swr: Remove unneeeded comparison

2017-09-26 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Sep 25, 2017, at 5:28 PM, George Kyriazis > wrote: > > No need to check if screen->pipe != pipe, so we can just assign it. Just do > it. > --- > src/gallium/drivers/swr/swr_state.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/

Re: [Mesa-dev] [PATCH] vc4: Fix infinite retry in vc4_bo_alloc()

2017-09-26 Thread Eric Engestrom
On Tuesday, 2017-09-26 07:48:37 +, Boris Brezillon wrote: > cleared_and_retried is always reset to false when jumping to the retry > label, thus leading to an infinite retry loop. > > Fix that by moving the cleared_and_retried variable definitions at the > beginning of the function. Reviewed-

Re: [Mesa-dev] [PATCH 2/5] st/glsl_to_tgsi: fix conditional assignments to packed shader outputs

2017-09-26 Thread Ian Romanick
I'm hoping to land my patch series that removes ir_assignment::condition either today or tomorrow. I believe that series deletes all of this code... but this patch would still be useful for stable. On 09/26/2017 07:42 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Overriding the default (

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

2017-09-26 Thread Ian Romanick
On 09/26/2017 10:27 AM, Juan A. Suarez Romero wrote: > On Thu, 2017-09-21 at 10:39 -0500, Ian Romanick wrote: >> On 09/20/2017 03:12 AM, Juan A. Suarez Romero wrote: >>> On Sat, 2017-07-08 at 02:03 +0300, Andres Gomez wrote: Ian, it looks like we could want this patch (and the others from the

Re: [Mesa-dev] XDC 2017 feedback

2017-09-26 Thread Manasi Navare
Hi, XDC was a really great conference and loved the fact that it was in just one room which kept all the hallway conversations in that room resulting into more networking. But I agree with Andres that for the videos, it would be great to split the huge youtube video stream per presentation and hav

Re: [Mesa-dev] [PATCH v3 3/4] meson: Add build Intel "anv" vulkan driver

2017-09-26 Thread Eric Anholt
Dylan Baker writes: > This allows building and installing the Intel "anv" Vulkan driver using > meson and ninja, the driver has been tested against the CTS and has > seems to pass the same series of tests (they both segfault when the CTS > tries to run wayland wsi tests). > > There are still a me

Re: [Mesa-dev] [PATCH] glx: Be slightly more tolerant in glXImportContext

2017-09-26 Thread Eric Anholt
Adam Jackson writes: > Ugh the GLX code. __GLX_MAX_CONTEXT_PROPS is 3 because glxproto.h is > just a pile of ancient runes, so when the server begins sending more > than 3 context properties this code refuses to work _at all_. > > This extension is pretty obscure, so this probably isn't a big dea

Re: [Mesa-dev] [PATCH] glsl: Allow precision mismatch on dead data with GLSL ES 1.00

2017-09-26 Thread Kenneth Graunke
This seems reasonable to me, and gets myReviewed-by: Kenneth Graunke but I would wait to hear back from Ian since he's been looking at this too.Thanks for researching this carefully!___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.fr

Re: [Mesa-dev] [PATCH v3 4/4] meson: build "radv" vulkan driver for radeon hardware

2017-09-26 Thread Nirbheek Chauhan
On Tue, Sep 26, 2017 at 9:46 PM, Dylan Baker wrote: > This builds and installs, but I haven't had a chance to test it yet. > > v2: - enable radv by default > - add shader cache support and enforce that it's built for radv > v3: - Fix typo in meson_options (Nicholas) > - strip trailing 'svn

Re: [Mesa-dev] [PATCH 2/5] st/glsl_to_tgsi: fix conditional assignments to packed shader outputs

2017-09-26 Thread Nicolai Hähnle
On 26.09.2017 20:34, Ian Romanick wrote: I'm hoping to land my patch series that removes ir_assignment::condition either today or tomorrow. I believe that series deletes all of this code... but this patch would still be useful for stable. Yep, that series is much appreciated. If it weren't for

Re: [Mesa-dev] [PATCH v3 4/4] meson: build "radv" vulkan driver for radeon hardware

2017-09-26 Thread Dylan Baker
Quoting Nirbheek Chauhan (2017-09-26 12:29:30) > On Tue, Sep 26, 2017 at 9:46 PM, Dylan Baker wrote: > > This builds and installs, but I haven't had a chance to test it yet. > > > > v2: - enable radv by default > > - add shader cache support and enforce that it's built for radv > > v3: - Fix t

Re: [Mesa-dev] [PATCH v3 4/4] meson: build "radv" vulkan driver for radeon hardware

2017-09-26 Thread Nirbheek Chauhan
On Wed, Sep 27, 2017 at 1:11 AM, Dylan Baker wrote: > Quoting Nirbheek Chauhan (2017-09-26 12:29:30) >> On Tue, Sep 26, 2017 at 9:46 PM, Dylan Baker wrote: >> > This builds and installs, but I haven't had a chance to test it yet. >> > >> > v2: - enable radv by default >> > - add shader cache

Re: [Mesa-dev] [PATCH v3 3/4] meson: Add build Intel "anv" vulkan driver

2017-09-26 Thread Dylan Baker
Quoting Eric Anholt (2017-09-26 11:46:50) > Dylan Baker writes: > > > This allows building and installing the Intel "anv" Vulkan driver using > > meson and ninja, the driver has been tested against the CTS and has > > seems to pass the same series of tests (they both segfault when the CTS > > tri

Re: [Mesa-dev] [PATCH v3 4/4] meson: build "radv" vulkan driver for radeon hardware

2017-09-26 Thread Dylan Baker
Quoting Nirbheek Chauhan (2017-09-26 12:58:12) > On Wed, Sep 27, 2017 at 1:11 AM, Dylan Baker wrote: > > Quoting Nirbheek Chauhan (2017-09-26 12:29:30) > >> On Tue, Sep 26, 2017 at 9:46 PM, Dylan Baker wrote: > >> > This builds and installs, but I haven't had a chance to test it yet. > >> > > >>

Re: [Mesa-dev] [PATCH] glx: Be slightly more tolerant in glXImportContext

2017-09-26 Thread Adam Jackson
On Tue, 2017-09-26 at 11:59 -0700, Eric Anholt wrote: > Instead of magic numbers, couldn't we just malloc the proplist here and > free it after the loop? Fine. You tyrant. Actually I have a better idea. We've buffered the entire reply by this point, we can just read two dwords at a time until we

Re: [Mesa-dev] [PATCH 00/22] RFC: Batchbuffer Logger for Intel GPU

2017-09-26 Thread Chris Wilson
Quoting Rogovin, Kevin (2017-09-26 10:35:44) > Hi, > > Attached to this message are the following: > 1. a file giving example usage of the tool with a modified apitrace to > produce json output > > 2. the patches to apitrace to make it BatchbufferLogger aware > > 3. the JSON fi

[Mesa-dev] [Bug 103002] string_buffer_test.cpp:43: error: ISO C++ forbids initialization of member ‘str1’

2017-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103002 Bug ID: 103002 Summary: string_buffer_test.cpp:43: error: ISO C++ forbids initialization of member ‘str1’ Product: Mesa Version: git Hardware: Other OS: Al

  1   2   >