Re: [Mesa-dev] [Mesa-stable] [PATCH] Revert "glsl: don't reference shader prog data during cache fallback"

On Thu, 2017-06-01 at 10:09 +1000, Timothy Arceri wrote: > On 01/06/17 07:30, Juan A. Suarez Romero wrote: > > On Tue, 2017-05-16 at 20:40 +0200, Nicolai Hähnle wrote: > > > From: Nicolai Hähnle > > > > > > This reverts commit 0e9991f957e296f46cfff40a94ffba0adf2a58e1. > > > > > > At least when w

Re: [Mesa-dev] [PATCH] i965: Reject unsupported formats in glEGLImageTargetTexture2D()

On Wednesday, May 31, 2017 4:54:59 PM PDT Chad Versace wrote: > If the EGLImage's format is not a supported texture format according to > brw_surface_formats.c, then refuse to create the miptree. This follows > the precedent in glEGLImageRenderbufferStorage (implemented by > intel_image_target_rend

Re: [Mesa-dev] [PATCH 0/1] r600g: work around shaders allocating too many superflous temporaries

Hello, I should probably add that I don't have write access to the mesa-git. Best,  Gert Am Dienstag, den 30.05.2017, 14:14 +0200 schrieb Gert Wollny: > Dear all, > > like I pointed out yesterday I've got a workaround for shaders that > allocate > too many temporaries after the TGSI pass th

Re: [Mesa-dev] [PATCH 00/30] i965: Overhaul resolves

On Wed, May 31, 2017 at 04:09:00PM +0300, Pohjolainen, Topi wrote: > On Tue, May 30, 2017 at 11:48:15AM +0300, Pohjolainen, Topi wrote: > > On Fri, May 26, 2017 at 04:30:04PM -0700, Jason Ekstrand wrote: > > > This patch series does a complete overhaul of the current resolve handling > > > framewor

Re: [Mesa-dev] [PATCH] nvc0: Clean up unnecessary includes from gallium/auxiliary/vl/

Pushed, thanks! On 06/01/2017 12:48 AM, Rhys Kidd wrote: Signed-off-by: Rhys Kidd --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index f2

Re: [Mesa-dev] [PATCH 08/11] intel/isl: Add a new layout for HiZ and stencil on Sandy Bridge

On Tue, May 30, 2017 at 05:55:17PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 162 > ++-- > src/intel/isl/isl.h | 40 + > 2 files changed, 197 insertions(+), 5 deletions(-) > > diff --git a/src/intel/isl/isl.c b/src/int

[Mesa-dev] [PATCH] util/rand_xor: add missing include statements

Fixes for: src/util/rand_xor.c:60:13: error: implicit declaration of function 'open' [-Werror=implicit-function-declaration] int fd = open("/dev/urandom", O_RDONLY); ^~~~ src/util/rand_xor.c:60:34: error: 'O_RDONLY' undeclared (first use in this function) int fd = open("/dev

Re: [Mesa-dev] [PATCH 11/11] intel/blorp: Handle gen6 stencil/HiZ offsets in the back-end

On Tue, May 30, 2017 at 05:55:20PM -0700, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_genX_exec.h| 32 - > src/intel/isl/isl_emit_depth_stencil.c | 1 + > src/mesa/drivers/dri/i965/brw_blorp.c| 61 > > src/mesa/dr

Re: [Mesa-dev] [PATCH 00/11] intel/isl: Add support for HiZ and stencil on gen6

On Tue, May 30, 2017 at 05:55:09PM -0700, Jason Ekstrand wrote: > This little series adds support to ISL for gen6 HiZ ans stencil via a new > isl_dim_layout enum value. Unfortunately, I couldn't easily add the new > layout without doing a little refactoring. The way ISL likes to calculate > surfa

[Mesa-dev] [PATCH v2] egl/android: support for EGL_KHR_partial_update

This patch adds support for the EGL_KHR_partial_update extension for android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. 1 test not supported. v2: add fallback for eglSetDamageRegionKHR (Tapani) Signed-off-by: Harish Krupo --- src/egl/drivers/dri2/egl_dri2.c | 12

[Mesa-dev] [PATCH] dri3/GLX: Fix drawable invalidation

A number of internal VMware apitrace traces image comparisons fail with dri3 because the viewport transformation becomes incorrect after an X drawable resize. The incorrect viewport transformation sometimes persist until the second draw-call after a swapBuffer. Comparing with the dri2 glx code the

[Mesa-dev] [ANNOUNCE] mesa 17.0.7

Mesa 17.0.7 is now available. Note: this is the final anticipated release in the 17.0 series. Users are encouraged to migrate to the 17.1 series in order to obtain future fixes. In this release we have: The mesa GLVND GLX library now handles glXGetDriverConfig, as used by driconf. For EGL the e

Re: [Mesa-dev] [PATCH] Revert "egl/display: remove unnecessary code and make it easier to read"

On Thursday, 2017-06-01 02:58:17 +0300, Grazvydas Ignotas wrote: > This reverts commit 7adb9b094894a512c019b3378eb9e3c69d830edc. > > The "No functional change" claim is wrong, after that commit, the > _eglGetNativePlatformFromEnv() function is now called every time instead > of just once it was ca

[Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

If the detections methods ever become able to return different results for different threads, the if chain might make threads go back and forth between invalid and valid platforms. Solve this by doing the detection in a local var and only overwriting the global one at the end, if no other thread ha

[Mesa-dev] [PATCH mesa 1/2] egl/display: only detect the platform once

My refactor missed the fact that `native_platform` is static. Add the proper guard before the first detection method, as it might not be necessary, and only print the debug message when a detection was actually performed. Reported-by: Grazvydas Ignotas Fixes: 7adb9b094894a512c019 ("egl/display: r

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

On Thu, Jun 1, 2017 at 2:15 PM, Eric Engestrom wrote: > If the detections methods ever become able to return different results > for different threads, the if chain might make threads go back and forth > between invalid and valid platforms. > Solve this by doing the detection in a local var and on

[Mesa-dev] [Bug 101252] eglGetDisplay() is not thread safe

https://bugs.freedesktop.org/show_bug.cgi?id=101252 Emre Ucan changed: What|Removed |Added CC||eu...@de.adit-jv.com -- You are receiving

[Mesa-dev] [PATCH 03/21] mesa: add KHR_no_error support for glBindVertexBuffers()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_multi_bind.xml | 2 +- src/mesa/main/varray.c| 13 + src/mesa/main/varray.h| 5 + 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_multi_bind.xml b/src

[Mesa-dev] [PATCH 02/21] mesa: add KHR_no_error support for glVertexArrayVertexBuffers()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/varray.c | 15 +++ src/mesa/main/varray.h | 6 ++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi

[Mesa-dev] [PATCH 00/21] mesa: Some more KHR_no_error support patches

Hi, Found after profiling "Dawn Of War 3" with Sysprof. This series should save few CPU cycles for this not yet released game. Please review, Thanks! Samuel Pitoiset (21): mesa: add vertex_array_vertex_buffers_err() helper mesa: add KHR_no_error support for glVertexArrayVertexBuffers() mes

[Mesa-dev] [PATCH 04/21] mesa: add invalidate_buffer_subdata() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9e656a4c98..08f5a9e59b 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj

[Mesa-dev] [PATCH 01/21] mesa: add vertex_array_vertex_buffers_err() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/varray.c | 108 - 1 file changed, 61 insertions(+), 47 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 47528ba2a7..c2c771c173 100644 --- a/src/mesa/main/varray.c +++ b

[Mesa-dev] [PATCH 05/21] mesa: add KHR_no_error support for glInvalidateBufferSubData()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_invalidate_subdata.xml | 2 +- src/mesa/main/bufferobj.c | 10 ++ src/mesa/main/bufferobj.h | 5 + 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_

[Mesa-dev] [PATCH 06/21] mesa: add KHR_no_error support for glInvalidateBufferData()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_invalidate_subdata.xml | 2 +- src/mesa/main/bufferobj.c | 9 + src/mesa/main/bufferobj.h | 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_invali

[Mesa-dev] [PATCH 07/21] mesa: add KHR_no_error support for glBindBuffer()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/bufferobj.c | 10 ++ src/mesa/main/bufferobj.h | 3 +++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 8f933

[Mesa-dev] [PATCH 08/21] mesa: make _mesa_blit_framebuffer() static

Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 29 ++--- src/mesa/main/blit.h | 8 2 files changed, 14 insertions(+), 23 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index e739130f98..2c0300eab3 100644 --- a/src/mesa/main/blit

[Mesa-dev] [PATCH 11/21] mesa: add validate_color_buffer() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 164 +++ 1 file changed, 86 insertions(+), 78 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index 455a9a647f..95f97ed559 100644 --- a/src/mesa/main/blit.c +++ b/src/m

[Mesa-dev] [PATCH 09/21] mesa: add validate_stencil_buffer() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 111 +++ 1 file changed, 58 insertions(+), 53 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index 2c0300eab3..207ce7d501 100644 --- a/src/mesa/main/blit.c +++ b/src/m

[Mesa-dev] [PATCH 12/21] mesa: add 'no_error' parameter to blit_framebuffer()

The whole GLES3 block has been moved before the buffer validation checks. Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 177 ++- 1 file changed, 90 insertions(+), 87 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c

[Mesa-dev] [PATCH 10/21] mesa: add validate_depth_buffer() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 105 +++ 1 file changed, 56 insertions(+), 49 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index 207ce7d501..455a9a647f 100644 --- a/src/mesa/main/blit.c +++ b/src/m

[Mesa-dev] [PATCH 13/21] mesa: add KHR_no_error support for glBlitFramebuffer()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +- src/mesa/main/blit.c | 15 +++ src/mesa/main/blit.h | 6 ++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/ge

[Mesa-dev] [PATCH 14/21] mesa: add KHR_no_error support for glBlitNamedFramebuffer()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/blit.c | 30 ++ src/mesa/main/blit.h | 9 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/s

[Mesa-dev] [PATCH 16/21] mesa: add prepare_target() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/copyimage.c | 24 1 file changed, 24 insertions(+) diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyimage.c index 07c2359dda..6a74f7a1a8 100644 --- a/src/mesa/main/copyimage.c +++ b/src/mesa/main/copyimage.c @@ -

[Mesa-dev] [PATCH 15/21] mesa: rename prepare_target() to prepare_target_err()

Signed-off-by: Samuel Pitoiset --- src/mesa/main/copyimage.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyimage.c index cf25159e88..07c2359dda 100644 --- a/src/mesa/main/copyimage.c +++ b/src

[Mesa-dev] [PATCH 17/21] mesa: add copy_image_subdata() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/copyimage.c | 78 --- 1 file changed, 47 insertions(+), 31 deletions(-) diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyimage.c index 6a74f7a1a8..16a8132544 100644 --- a/src/mesa/main/copyimag

[Mesa-dev] [PATCH 18/21] mesa: add KHR_no_error support for glCopyImageSubData()

--- src/mapi/glapi/gen/ARB_copy_image.xml | 2 +- src/mesa/main/copyimage.c | 23 +++ src/mesa/main/copyimage.h | 7 +++ 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_copy_image.xml b/src/mapi/glapi/gen/ARB_

[Mesa-dev] [PATCH 19/21] mesa: rename texsubimage() to texsubimage_err()

Signed-off-by: Samuel Pitoiset --- src/mesa/main/teximage.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index fed1dad262..9285a96b68 100644 --- a/src/mesa/main/teximage.c +++ b/src/mes

[Mesa-dev] [PATCH 20/21] mesa: add texsubimage() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/teximage.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 9285a96b68..ca8090f653 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3282,6 +328

[Mesa-dev] [PATCH 21/21] mesa: add KHR_no_error support for glTexSubImage*D()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 6 +++--- src/mesa/main/teximage.c | 43 +++ src/mesa/main/teximage.h | 18 ++ 3 files changed, 64 insertions(+), 3 deletions(-) diff --git a/src/mapi/glapi/gen/g

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

Hi guys, On 1 June 2017 at 12:56, Grazvydas Ignotas wrote: > On Thu, Jun 1, 2017 at 2:15 PM, Eric Engestrom > wrote: >> If the detections methods ever become able to return different results >> for different threads, the if chain might make threads go back and forth >> between invalid and valid

Re: [Mesa-dev] [PATCH] util/rand_xor: add missing include statements

On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote: > Fixes for: > > src/util/rand_xor.c:60:13: error: implicit declaration of function 'open' > [-Werror=implicit-function-declaration] > int fd = open("/dev/urandom", O_RDONLY); > ^~~~ > src/util/rand_xor.c:60:34: erro

Re: [Mesa-dev] [RFC] some glsl->tgsi optimisations

Hi Dave, Can you rebase your series on top of master because it doesn't apply. I'm fine with the general idea. Note that I have a shader which spends 5s in copy_propagate()... That's huge! Looks like this series might improve the situation here, but needs more testing. Thanks! On 05/30/2017

Re: [Mesa-dev] [PATCH 4/4] st_glsl_to_tgsi: replace variables tracking list with a hash table

On 05/30/2017 07:52 AM, Dave Airlie wrote: From: Dave Airlie This removes the linear search which is fail when number of variables goes up to 3 or so. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 44 +- 1 file changed, 31 insertions(+), 13 deletions(-)

Re: [Mesa-dev] [PATCH 1/4] st_glsl_to_tgsi: bump index back up to 32-bit

Reviewed-by: Samuel Pitoiset On 05/30/2017 07:52 AM, Dave Airlie wrote: From: Dave Airlie with some of the fp64 emulation, we are seeing shaders coming in with 32K temps, they go out with 40 or so used, but while doing register renumber we need to store a lot of them. So bump this fields b

Re: [Mesa-dev] [PATCH 09/21] mesa: add validate_stencil_buffer() helper

This time, send it to the list too. Gustaw 1 cze 2017 15:45 "Gustaw Smolarczyk" napisał(a): 1 cze 2017 15:07 "Samuel Pitoiset" napisał(a): Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 111 +++--- - 1 file changed, 58 insertions(+), 53

Re: [Mesa-dev] [PATCH 09/21] mesa: add validate_stencil_buffer() helper

Yeah, will fix locally, thanks! On 06/01/2017 03:47 PM, Gustaw Smolarczyk wrote: This time, send it to the list too. Gustaw 1 cze 2017 15:45 "Gustaw Smolarczyk" > napisał(a): 1 cze 2017 15:07 "Samuel Pitoiset" mailto:samuel.pitoi...@gmail.com>> napisał(a):

Re: [Mesa-dev] [PATCH 10/21] mesa: add validate_depth_buffer() helper

Same problem as in the previous patch. Regards, Gustaw 1 cze 2017 15:07 "Samuel Pitoiset" napisał(a): Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 105 +++--- - 1 file changed, 56 insertions(+), 49 deletions(-) diff --git a/src/mesa/m

[Mesa-dev] [PATCH mesa] tree-wide: remove trailing backslash

Simple search for a backslash followed by two newlines. If one of the newlines were to be removed, this would cause issues, so let's just remove these trailing backslashes. Signed-off-by: Eric Engestrom --- I can split the patch by module if you want, but this seems trivial enough? A simple ack

Re: [Mesa-dev] [PATCH] glsl: fix bounds check in blob_overwrite_bytes

Reviewed-by: Iago Toral Quiroga On Wed, 2017-05-31 at 19:14 -0500, Rob Herring wrote: > clang gives a warning in blob_overwrite_bytes because offset type is > size_t which is unsigned: > > src/compiler/glsl/blob.c:110:15: warning: comparison of unsigned > expression < 0 is always false [-Wtautol

[Mesa-dev] [PATCH mesa] configure.ac: simplify --enable-libunwind=auto check

Signed-off-by: Eric Engestrom --- configure.ac | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index b57be07e24..5caf316089 100644 --- a/configure.ac +++ b/configure.ac @@ -1066,16 +1066,12 @@ AC_SUBST([LLVM_INCLUDEDIR]) dnl dnl libunwind

Re: [Mesa-dev] [PATCH] util/rand_xor: add missing include statements

On Thu, Jun 1, 2017 at 3:27 PM, Eric Engestrom wrote: > On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote: >> Fixes for: >> >> src/util/rand_xor.c:60:13: error: implicit declaration of function 'open' >> [-Werror=implicit-function-declaration] >> int fd = open("/dev/urandom", O_R

Re: [Mesa-dev] Status of Clover (AMDGPU)

> I'd suggest that you check out the recently-open-sourced OpenCL > conformance test suite [0] or my slightly-more-linux-build-friendly > fork [1] and give it a run on top of mesa/clover. It'll give you a > good list of things to work on. Thanks, I took a quick look. Yeah, shame they didn't put in

Re: [Mesa-dev] [PATCH 01/21] mesa: add vertex_array_vertex_buffers_err() helper

On Jun 1, 2017 15:06, "Samuel Pitoiset" wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/varray.c | 108 -- --- 1 file changed, 61 insertions(+), 47 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 47528ba2a7..c2

Re: [Mesa-dev] [PATCH v2] egl/android: support for EGL_KHR_partial_update

Hi Harish On 1 June 2017 at 11:27, Harish Krupo wrote: > This patch adds support for the EGL_KHR_partial_update extension for > android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. > 1 test not supported. > > v2: add fallback for eglSetDamageRegionKHR (Tapani) > AFAICT the

Re: [Mesa-dev] [PATCH mesa] configure.ac: simplify --enable-libunwind=auto check

On 1 June 2017 at 15:10, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > configure.ac | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/configure.ac b/configure.ac > index b57be07e24..5caf316089 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

On Thu, Jun 1, 2017 at 4:23 PM, Emil Velikov wrote: > Hi guys, > > On 1 June 2017 at 12:56, Grazvydas Ignotas wrote: >> On Thu, Jun 1, 2017 at 2:15 PM, Eric Engestrom >> wrote: >>> If the detections methods ever become able to return different results >>> for different threads, the if chain migh

Re: [Mesa-dev] [PATCH] util/rand_xor: add missing include statements

On 1 June 2017 at 15:15, Nicolas Dechesne wrote: > On Thu, Jun 1, 2017 at 3:27 PM, Eric Engestrom > wrote: >> On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote: >>> Fixes for: >>> >>> src/util/rand_xor.c:60:13: error: implicit declaration of function 'open' >>> [-Werror=implicit-fun

Re: [Mesa-dev] [PATCH] util/rand_xor: add missing include statements

On Thursday, 2017-06-01 16:15:41 +0200, Nicolas Dechesne wrote: > On Thu, Jun 1, 2017 at 3:27 PM, Eric Engestrom > wrote: > > On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote: > >> Fixes for: > >> > >> src/util/rand_xor.c:60:13: error: implicit declaration of function 'open' > >> [-

Re: [Mesa-dev] [PATCH 08/11] intel/isl: Add a new layout for HiZ and stencil on Sandy Bridge

On Thu, Jun 1, 2017 at 2:40 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, May 30, 2017 at 05:55:17PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.c | 162 ++ > -- > > src/intel/isl/isl.h | 40 + > >

[Mesa-dev] [PATCH] automake: Link all libGL.so variants with -Bsymbolic.

We were linking src/glx with -Bsymbolic, but not the classic/gallium X11 libGL.so. But it's always a good idea to build all libGL.so and all DRI drivers with -Bsymbolic, otherwise they might resolve symbols from the 3rd party application executable or shared libraries, which is _never_ what we wan

Re: [Mesa-dev] [PATCH 11/11] intel/blorp: Handle gen6 stencil/HiZ offsets in the back-end

On Thu, Jun 1, 2017 at 3:17 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, May 30, 2017 at 05:55:20PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp_genX_exec.h| 32 - > > src/intel/isl/isl_emit_depth_stencil.c | 1 + > >

Re: [Mesa-dev] [PATCH] automake: Link all libGL.so variants with -Bsymbolic.

On 06/01/2017 09:46 AM, Jose Fonseca wrote: We were linking src/glx with -Bsymbolic, but not the classic/gallium X11 libGL.so. But it's always a good idea to build all libGL.so and all DRI drivers with -Bsymbolic, otherwise they might resolve symbols from the 3rd party application executable or

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #18 from joeri.exelm...@gmail.com --- Created attachment 131644 --> https://bugs.freedesktop.org/attachment.cgi?id=131644&action=edit vdpauinfo -- You are receiving this mail because: You are on the CC list for the bug.

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #19 from joeri.exelm...@gmail.com --- Sorry, ignore the 'vdpau' attachment I just uploaded, this belongs to another bug (wrong browser tab!) -- You are receiving this mail because: You are on the CC list for the bug._

Re: [Mesa-dev] [PATCH 5/5] r100: Silence numerous unused this or that warnings

For the series: Reviewed-by: Marek Olšák About your r100-r200 coding style question, I don't have a specific answer. It's up to you what you wanna do with it. Marek On Wed, May 31, 2017 at 2:40 AM, Ian Romanick wrote: > From: Ian Romanick > > radeon_fbo.c: In function ‘radeon_map_renderbuff

[Mesa-dev] [Bug 101071] compiling glsl fails with undefined reference to `pthread_create'

https://bugs.freedesktop.org/show_bug.cgi?id=101071 --- Comment #10 from war...@o2.pl --- Emil, Unfortunately minimizing build options doesn't help me with successful bisecting. I'm always failing in the middle with following erorr: //home/piotro/minimyth-dev/images/build/bin/bash ../../libtool

Re: [Mesa-dev] [PATCH V2] i965: Rename brw_format variable names to isl_format

On Tue, May 23, 2017 at 2:35 PM, Anuj Phogat wrote: > This patch makes non functional changes. Renaming is just to > make the code more readable. > > V2: update the types to "enum isl_format" Jason, do you have any other questions ? r-b ? > > Signed-off-by: Anuj Phogat > Cc: Jason Ekstrand > ---

Re: [Mesa-dev] [PATCH V2] i965: Rename brw_format variable names to isl_format

On Thu, Jun 1, 2017 at 9:41 AM, Anuj Phogat wrote: > On Tue, May 23, 2017 at 2:35 PM, Anuj Phogat > wrote: > > This patch makes non functional changes. Renaming is just to > > make the code more readable. > > > > V2: update the types to "enum isl_format" > Jason, do you have any other questions

Re: [Mesa-dev] [PATCH] automake: Link all libGL.so variants with -Bsymbolic.

On 1 June 2017 at 16:46, Jose Fonseca wrote: > We were linking src/glx with -Bsymbolic, but not the classic/gallium X11 > libGL.so. > > But it's always a good idea to build all libGL.so and all DRI drivers > with -Bsymbolic, otherwise they might resolve symbols from the 3rd party > application exe

[Mesa-dev] [PATCH 2/2] gallium/u_threaded: remove 16 bytes from tc_batch

From: Marek Olšák All other sentinels occupy what is otherwise unused space. --- src/gallium/auxiliary/util/u_threaded_context.c | 2 -- src/gallium/auxiliary/util/u_threaded_context.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_threaded_context.c b/src/gal

[Mesa-dev] [PATCH] st/mesa: don't load cached TGSI shaders on demand

From: Marek Olšák This fixes a performance issue with the shader cache that delayed Gallium shader create calls until draw calls. I'd like this in stable, but it's not a showstopper. Cc: 17.1 --- src/mesa/state_tracker/st_shader_cache.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[Mesa-dev] [PATCH] tgsi/scan: fix scanning fragment shaders with PrimID and Position/Face

From: Marek Olšák Not relevant to radeonsi, because Position/Face are system values with radeonsi, while this codepath is for drivers where Position and Face are ordinary inputs. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-)

[Mesa-dev] [PATCH 1/2] gallium/u_threaded: align batches and call slots to 16 bytes

From: Marek Olšák not sure if this helps --- src/gallium/auxiliary/util/u_threaded_context.c | 11 +-- src/gallium/auxiliary/util/u_threaded_context.h | 9 - 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_threaded_context.c b/src/ga

[Mesa-dev] [PATCH 03/11] radeonsi: decrease the number of compiler threads to num CPUs - 1

From: Marek Olšák Reserve one core for other things (like draw calls). --- src/gallium/drivers/radeonsi/si_pipe.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index de4e5da..4704304 100644

[Mesa-dev] [PATCH 05/11] radeonsi: use a compiler queue with a low priority for optimized shaders

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 31 + src/gallium/drivers/radeonsi/si_pipe.h | 3 +++ src/gallium/drivers/radeonsi/si_state_shaders.c | 8 +++ 3 files changed, 34 insertions(+), 8 deletions(-) diff --git a/src/galliu

[Mesa-dev] [PATCH 01/11] util/u_queue: add a way to remove a job when we just want to destroy it

From: Marek Olšák --- src/util/u_queue.c | 50 -- src/util/u_queue.h | 2 ++ 2 files changed, 46 insertions(+), 6 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 8db09b0..3834b6f 100644 --- a/src/util/u_queue.c +++ b/src/u

[Mesa-dev] [PATCH 00/11] RadeonSI: Shader compiler queue improvements & GFX9 fixes

Hi, The beginning of this series improves our shader compiler queues, mainly the optimized compilations now run at the lowest thread priority so as not to affect rendering performance. It's followed by cleanups, and then fixes for GFX9. Please review. Thanks, Marek _

[Mesa-dev] [PATCH 06/11] radeonsi: move handling of DBG_NO_OPT_VARIANT into si_shader_selector_key

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 5a22add..55e881c 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 04/11] util/u_queue: add an option to set the minimum thread priority

From: Marek Olšák --- src/gallium/auxiliary/util/u_threaded_context.c | 2 +- src/gallium/drivers/freedreno/freedreno_batch.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.c| 2 +- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 +- src/gallium/winsys/radeon/drm/radeon_d

[Mesa-dev] [PATCH 07/11] radeonsi: remove dead code in declare_input_fs

From: Marek Olšák Colors are interpolated in the PS prolog. This was never used. --- src/gallium/drivers/radeonsi/si_shader.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 3a86c0b..5c7deeb 100644

[Mesa-dev] [PATCH 08/11] radeonsi: move streamout state update out of si_update_shaders

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 40 +++-- 2 files changed, 25 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.h b/src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH 02/11] radeonsi: drop unfinished shader compilations when destroying shaders

From: Marek Olšák If we enqueue too many jobs and destroy the GL context, it may take several seconds before the jobs finish. Just drop them instead. --- src/gallium/drivers/radeonsi/si_compute.c | 3 ++- src/gallium/drivers/radeonsi/si_state_shaders.c | 5 +++-- src/util/u_queue.c

[Mesa-dev] [PATCH 10/11] radeonsi/gfx9: wait for main part compilation of 1st shaders or merged shaders

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 631272e..727bf4b 100644 --- a/src/gallium/drivers/radeonsi/si_sta

[Mesa-dev] [PATCH 11/11] radeonsi/gfx9: prevent a race when the previous shader's main part is missing

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 727bf4b..08d647b 100644 --- a/src/gallium/drivers/radeonsi/si_state

[Mesa-dev] [PATCH 09/11] radeonsi/gfx9: fix LS scratch buffer support without TCS for GFX9

From: Marek Olšák LS is merged into TCS. If there is no TCS, LS is merged into fixed-func TCS. The problem is the fixed-func TCS was ignored by scratch update functions, so LS didn't have the scratch buffer set up. Note that Mesa 17.1 doesn't have merged shaders. --- src/gallium/drivers/radeons

[Mesa-dev] [Bug 101071] compiling glsl fails with undefined reference to `pthread_create'

https://bugs.freedesktop.org/show_bug.cgi?id=101071 --- Comment #11 from Emil Velikov --- (In reply to warpme from comment #10) > Emil, > Unfortunately minimizing build options doesn't help me with successful > bisecting. Minimising the build options was aimed to a) reduce the surface area and b)

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #34 from Stefan Dirsch --- (In reply to intermedi...@hotmail.com from comment #33) > Hi Stefan sorry for asking this small ot, > how is the situation there on RadeonSi Mesa EGL? > here on Qoriq and on PowerMac G5 glamor crashes if

Re: [Mesa-dev] [PATCH 11/12] i965/cnl: Properly handle l3 configuration

On Thu, May 11, 2017 at 8:31 AM, Ben Widawsky wrote: > On 17-05-02 11:51:28, Francisco Jerez wrote: >> >> Anuj Phogat writes: >> >>> On Mon, Apr 24, 2017 at 9:15 PM, Ben Widawsky wrote: >>> On 17-04-18 18:18:39, Francisco Jerez wrote: Most, if not all of the unrelated changes that

Re: [Mesa-dev] [Mesa-stable] [PATCH 6/6] i965/dri: Fix bad GL error in intel_create_winsys_renderbuffer()

On Wed 31 May 2017, Ian Romanick wrote: > On 05/31/2017 04:43 PM, Chad Versace wrote: > > This function never occurs in the callchain of a GL function. It occurs > > only in the callchain of eglCreate*Surface and the analogous paths for > > GLX. Therefore, even if a thread does have a bound GL co

Re: [Mesa-dev] [PATCH V2] i965: Rename brw_format variable names to isl_format

On Thu 01 Jun 2017, Jason Ekstrand wrote: > On Thu, Jun 1, 2017 at 9:41 AM, Anuj Phogat wrote: > > > On Tue, May 23, 2017 at 2:35 PM, Anuj Phogat > > wrote: > > > This patch makes non functional changes. Renaming is just to > > > make the code more readable. > > > > > > V2: update the types to "

Re: [Mesa-dev] [PATCH V2] i965: Rename brw_format variable names to isl_format

On Thu, Jun 1, 2017 at 12:00 PM, Chad Versace wrote: > On Thu 01 Jun 2017, Jason Ekstrand wrote: >> On Thu, Jun 1, 2017 at 9:41 AM, Anuj Phogat wrote: >> >> > On Tue, May 23, 2017 at 2:35 PM, Anuj Phogat >> > wrote: >> > > This patch makes non functional changes. Renaming is just to >> > > make

[Mesa-dev] [Bug 100988] glXGetCurrentDisplay() no longer works for FakeGLX contexts?

https://bugs.freedesktop.org/show_bug.cgi?id=100988 --- Comment #3 from Brian Paul --- (In reply to Tom Hudson from comment #2) > Awesome, unless I'm missing something this fixes all our tests, and is a lot > simpler than anything we'd tried. Great. I'll put Tested-by: Tom Hudson on the patch

Re: [Mesa-dev] [PATCH 4/6] i965: Replace 0 with ISL_FORMAT_UNSUPPORTED in format table

On Wed 31 May 2017, Jason Ekstrand wrote: > On May 31, 2017 9:32:23 PM Ian Romanick wrote: > > > Having the unsupported format value not be zero isn't very safe. The > > C99 rules say that any field missing an initializer is implicitly > > initialized to zero. If a MESA_FORMAT_ value is added b

[Mesa-dev] [PATCH] i965: Replace 0 with ISL_FORMAT_UNSUPPORTED in format table (v2)

From: Chad Versace When given an *unsupported* mesa_format, brw_isl_format_for_mesa_format() returned 0, a *valid* isl_format, ISL_FORMAT_R32G32B32A32_FLOAT. The problem is that brw_isl_format_for_mesa_format's inner table used 0 instead of ISL_FORMAT_UNSUPPORTED to indicate unsupported mesa for

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #35 from intermedi...@hotmail.com --- just for information here my story about with Michel Danze reply https://bugs.freedesktop.org/show_bug.cgi?id=99859#c19 But there are many post on many big Endian hardware, was only curious if

[Mesa-dev] [PATCH 2/2] i965: Simplify l3 way size computations

By making use of l3_banks field in gen_device_info struct l3_way_size for gen7+ = 2 * l3_banks. Suggested-by: Francisco Jerez Signed-off-by: Anuj Phogat Cc: Francisco Jerez --- src/intel/common/gen_l3_config.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff -

[Mesa-dev] [PATCH 1/2] i965: Add and initialize l3_banks field for gen7+

This new field helps simplify l3 way size computations in next patch. Suggested-by: Francisco Jerez Signed-off-by: Anuj Phogat Cc: Francisco Jerez --- src/intel/common/gen_device_info.c | 23 ++- src/intel/common/gen_device_info.h | 1 + 2 files changed, 23 insertions(+),

[Mesa-dev] [PATCH 1/1] automake: r600 should only depend on libamd_common if opencl is enabled

Signed-off-by: Jan Vesely --- Hi guys, this is the first step towards dropping libamd_common dependency. It's based on Emil's patches 3/5 and 4/5. Enabling opencl still falls back to the old way of requiring libamd_common. I'll try to address that in the next step (no time estimate, feel free to

Re: [Mesa-dev] [PATCH] i965: Replace 0 with ISL_FORMAT_UNSUPPORTED in format table (v2)

On Thu, Jun 1, 2017 at 12:55 PM, Chad Versace wrote: > From: Chad Versace > > When given an *unsupported* mesa_format, > brw_isl_format_for_mesa_format() returned 0, a *valid* isl_format, > ISL_FORMAT_R32G32B32A32_FLOAT. The problem is that > brw_isl_format_for_mesa_format's inner table used 0 i

Re: [Mesa-dev] [PATCH 1/1] automake: r600 should only depend on libamd_common if opencl is enabled

On Thu, Jun 1, 2017 at 3:28 PM, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > Hi guys, > > this is the first step towards dropping libamd_common dependency. > It's based on Emil's patches 3/5 and 4/5. > Enabling opencl still falls back to the old way of requiring libamd_common. > I'll tr

  1   2   >