On Wed 31 May 2017, Ian Romanick wrote: > On 05/31/2017 04:43 PM, Chad Versace wrote: > > This function never occurs in the callchain of a GL function. It occurs > > only in the callchain of eglCreate*Surface and the analogous paths for > > GLX. Therefore, even if a thread does have a bound GL context, > > emitting a GL error here is wrong. A misplaced GL error, when no GL > > call is made, can confuse clients. > > This seems right. What seems wrong, however, is that the callers ignore > the potentially NULL return. intelCreateBuffer (intel_screen.c) could > easily return false when it gets NULL, but it merrily plugs along.
Yes, that seems to be a problem throughout the DRI layer. iirc, some DRI vfunc signatures even lack return codes. I'll explore the intelCreateBuffer callgraph and reply with some follow-up patches. > This patch clearly makes things better, but I'd love to see a follow up > that fixes the other pre-existing problems. > > Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> Thanks. > > > > Cc: mesa-sta...@lists.freedesktop.org _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
