Noticed by inspection. The assert should have caught this already
but seems to have been incorrectly removed in b8939fd3d1544f.
---
I'm not overly familiar with this code but this seems to be how
it's intended to be used.
src/mesa/main/teximage.c | 10 ++
1 file changed, 6 insertions(
On 10.05.2017 03:01, Timothy Arceri wrote:
I made this same change a while back but found I couldn't really measure
any performance increase in practice. I suspect it's because we already
limit the max loops with (1 << s) <= prog[i]->SamplersUsed and there is
generally no big gaps in used samples
Reviewed-by: Lionel Landwerlin
On 10/05/17 01:12, Rafael Antognolli wrote:
Use an alias for this field on 3DSTATE_INDEX_BUFFER on gen6+, so we can set
the same value as the defines.
Signed-off-by: Rafael Antognolli
---
src/intel/genxml/gen6.xml | 1 +
src/intel/genxml/gen7.xml | 1 +
sr
Reviewed-by: Lionel Landwerlin
On 10/05/17 01:12, Rafael Antognolli wrote:
Several issues were caught on review after the original patch landed.
This commit fixes them.
v2:
- Fix padding (Topi)
- Remove .DestinationElementOffset change from this patch (Topi)
Signed-off-by: Rafael Anto
Reviewed-by: Lionel Landwerlin
On 10/05/17 01:12, Rafael Antognolli wrote:
Emit the respective commands using genxml code.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_state.h | 1 -
src/mesa/drivers/dri/i965/gen7_cs_state.c | 162 ---
Reviewed-by: Lionel Landwerlin
On 10/05/17 01:12, Rafael Antognolli wrote:
Also make the brw_get_index_type() function not shift its return, since that
is genxml's job now.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_context.h | 6 ++--
src/mesa/drivers/dri/i9
Reviewed-by: Lionel Landwerlin
On 10/05/17 01:12, Rafael Antognolli wrote:
With this last state ported, we can get rid of gen8_draw_upload.c.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/Makefile.sources| 1 -
src/mesa/drivers/dri/i965/brw_state.h | 1 -
sr
On Fri, May 05, 2017 at 12:33:54PM -0700, Jason Ekstrand wrote:
>On Fri, May 5, 2017 at 5:09 AM, Chris Wilson <[1]ch...@chris-wilson.co.uk>
>wrote:
>
> It is a requirement, not just of using the NO_RELOC mode, that all
> relocation values in the execobjects match their reloc.pres
From: Michel Dänzer
deregisterEHFrames doesn't take any parameters anymore.
Signed-off-by: Michel Dänzer
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
b/src/galli
On Tue, May 09, 2017 at 05:12:09PM -0700, Rafael Antognolli wrote:
> Use an alias for this field on 3DSTATE_INDEX_BUFFER on gen6+, so we can set
> the same value as the defines.
>
> Signed-off-by: Rafael Antognolli
> ---
> src/intel/genxml/gen6.xml | 1 +
> src/intel/genxml/gen7.xml | 1 +
> s
Ping?
On 05/05/2017 03:36 PM, Samuel Pitoiset wrote:
Similar to how image resources are handled. That way we are sure
that inst->resource.file is PROGRAM_SAMPLER for "bound" samplers.
Signed-off-by: Samuel Pitoiset
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 18 +-
1 fi
On 05/10/2017 03:01 AM, Timothy Arceri wrote:
I made this same change a while back but found I couldn't really measure
any performance increase in practice. I suspect it's because we already
limit the max loops with (1 << s) <= prog[i]->SamplersUsed and there is
generally no big gaps in used s
This fixes:
si_shader.c: In function ‘si_shader_dump_stats’:
si_shader.c:6704:31: warning: passing argument 1 of ‘si_get_max_workgroup_size’
discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
si_get_max_workgroup_size(shader);
^~
s
On 10 May 2017 at 00:10, Dave Airlie wrote:
> On 6 May 2017 at 02:35, Daniel Stone wrote:
>> Hi Emil,
>>
>> On 4 May 2017 at 15:14, Emil Velikov wrote:
>>> On 4 May 2017 at 14:43, Daniel Stone wrote:
IOW, there is no change as far as I can see, but perhaps for the
meantime, we could u
On 9 May 2017 at 21:18, Christian Gmeiner wrote:
> 2017-05-09 20:24 GMT+02:00 Eric Anholt :
>> vc4 was rejecting renderonly's import, because the offset field was
>> nonzero.
>
> Reviewed-by: Christian Gmeiner
>
Pretty sure we want this in -stable, right? Please add the following
before pushing.
On 10/05/17 20:06, Samuel Pitoiset wrote:
On 05/10/2017 03:01 AM, Timothy Arceri wrote:
I made this same change a while back but found I couldn't really
measure any performance increase in practice. I suspect it's because
we already
limit the max loops with (1 << s) <= prog[i]->SamplersUsed and
On 05/10/2017 12:30 PM, Timothy Arceri wrote:
On 10/05/17 20:06, Samuel Pitoiset wrote:
On 05/10/2017 03:01 AM, Timothy Arceri wrote:
I made this same change a while back but found I couldn't really
measure any performance increase in practice. I suspect it's because
we already
limit the max
https://bugs.freedesktop.org/show_bug.cgi?id=98974
William Bonnaventure changed:
What|Removed |Added
QA Contact|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop
On 10.05.2017 08:58, Axel Davy wrote:
Hi Nicolai and Marek,
Gallium nine associates to every d3d usage/index a generic unique index.
That should fit on a 16bits integer, but not for 32 values.
Hold on, you're saying the semantic index could be as high as 65535? I
guess you're saved by the fa
On 10.05.2017 12:04, Samuel Pitoiset wrote:
Ping?
On 05/05/2017 03:36 PM, Samuel Pitoiset wrote:
Similar to how image resources are handled. That way we are sure
that inst->resource.file is PROGRAM_SAMPLER for "bound" samplers.
Signed-off-by: Samuel Pitoiset
Reviewed-by: Nicolai Hähnle
On 10.05.2017 12:20, Samuel Pitoiset wrote:
This fixes:
si_shader.c: In function ‘si_shader_dump_stats’:
si_shader.c:6704:31: warning: passing argument 1 of ‘si_get_max_workgroup_size’
discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
si_get_max_workgroup_size(sh
On 10.05.2017 09:23, Timothy Arceri wrote:
Noticed by inspection. The assert should have caught this already
but seems to have been incorrectly removed in b8939fd3d1544f.
How on earth is there no piglit test that catches the texturesubimage
thing? Do you think you can add one?
---
I'm not
On 05/10/2017 01:45 PM, Nicolai Hähnle wrote:
On 10.05.2017 12:20, Samuel Pitoiset wrote:
This fixes:
si_shader.c: In function ‘si_shader_dump_stats’:
si_shader.c:6704:31: warning: passing argument 1 of
‘si_get_max_workgroup_size’ discards ‘const’ qualifier from pointer
target type [-Wdisca
On 10.05.2017 02:28, Eric Anholt wrote:
Timothy Arceri writes:
---
src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +-
src/mesa/main/fbobject.c | 31 +++
src/mesa/main/fbobject.h | 4
3 files changed, 36 insertions(+),
On 10/05/17 22:00, Nicolai Hähnle wrote:
On 10.05.2017 02:28, Eric Anholt wrote:
Timothy Arceri writes:
---
src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +-
src/mesa/main/fbobject.c | 31
+++
src/mesa/main/fbobject.h |
https://bugs.freedesktop.org/show_bug.cgi?id=100988
Bug ID: 100988
Summary: glXGetCurrentDisplay() no longer works for FakeGLX
contexts?
Product: Mesa
Version: 17.0
Hardware: Other
OS: All
Status
On Wednesday 10 May 2017, Nicolai Hähnle wrote:
> On 10.05.2017 09:23, Timothy Arceri wrote:
> > Noticed by inspection. The assert should have caught this already
> > but seems to have been incorrectly removed in b8939fd3d1544f.
>
> How on earth is there no piglit test that catches the texturesubi
https://bugs.freedesktop.org/show_bug.cgi?id=98833
--- Comment #16 from Eero Tamminen ---
(In reply to Pekka Paalanen from comment #14)
> Yes! I just installed Mesa git master and using Weston git master with your
> delay patch, and it produces a mighty glitchy animation indeed.
>
> I am on "GL
On 10 May 2017 at 03:22, Dave Airlie wrote:
> In order to pass CTS for 17.1 with llvm 4.0, radv needs some extra
> patches cherry-picked.
>
> 09034aab64c7a6022a2c508658fead1442f08576
> 3c730639740f9b1243e95d06e6608cb54649be9a
> a52470402515c46cd9f33a5d83dc8d2bc9f7bae9
> 83e58b036e1c34f26c99d04615d
Michel Dänzer wrote on 10.05.2017 10:27:
> From: Michel Dänzer
>
> deregisterEHFrames doesn't take any parameters anymore.
>
> Signed-off-by: Michel Dänzer
LGTM, CC stable?
> ---
> src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions
Mesa 17.1.0 is now available.
As always, there's dozens of notable changes and improvements, but the ones
that stand out in this release are:
- OpenGL 4.2 support for Intel Ivy Bridge chips.
With this final piece the Intel i965 is on par (and even surpases) relative to
the Windows, MacOS and And
On 05/10/2017 10:27 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> deregisterEHFrames doesn't take any parameters anymore.
>
> Signed-off-by: Michel Dänzer
> ---
> src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff -
Hi Jason,
Humble unrelated question.
On 9 May 2017 at 18:00, Jason Ekstrand wrote:
> + if (isl_surf_usage_is_depth(info->usage)) {
> + if (info->format == ISL_FORMAT_R16_UNORM) {
> + return isl_extent3d(8, 4, 1);
> + } else {
> + return isl_extent3d(4, 4, 1);
> +
On Wed, May 10, 2017 at 8:26 AM, Emil Velikov
wrote:
> Hi Jason,
>
> Humble unrelated question.
>
> On 9 May 2017 at 18:00, Jason Ekstrand wrote:
>
> > + if (isl_surf_usage_is_depth(info->usage)) {
> > + if (info->format == ISL_FORMAT_R16_UNORM) {
> > + return isl_extent3d(8, 4, 1
Cc: 17.1
Signed-off-by: Alex Deucher
---
include/pci_ids/radeonsi_pci_ids.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/pci_ids/radeonsi_pci_ids.h
b/include/pci_ids/radeonsi_pci_ids.h
index 1058682..a20a936 100644
--- a/include/pci_ids/radeonsi_pci_ids.h
+++ b/include/pci_ids/
Signed-off-by: Philipp Zabel
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index df3eb6b29a..5c460f43d5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -455,7 +455,7 @@ int main () {
CFLAGS=$save_CFLAGS
AC_ARG_ENABLE(pwr8,
-
On Wed, May 10, 2017 at 11:36:46AM +0300, Pohjolainen, Topi wrote:
> On Tue, May 09, 2017 at 05:12:09PM -0700, Rafael Antognolli wrote:
> > Use an alias for this field on 3DSTATE_INDEX_BUFFER on gen6+, so we can set
> > the same value as the defines.
> >
> > Signed-off-by: Rafael Antognolli
> > -
Use the proper pipe_resource_reference function instead of
rolling our own.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_texture.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_texture.c
b/src/gallium/drivers/
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_translate.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_translate.h
b/src/gallium/drivers/etnaviv/etnaviv_translate.h
index d0623db1472d..e8466d63ff10 100644
--- a/src/gallium/drivers
PIPE_BUFFER is a target enum, not a binding. This caused the driver to
up-align the height of buffer resources, leading to largely oversizing
those resources. This is especially bad, as the buffer resources used
by the upload manager are already 1MB in size. Height alignment meant
that those would
This way we can just test the feature bits and don't need to spread
the debug overrides to all locations touching a feature.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 6 ++
src/gallium/drivers/etnaviv/etnaviv_resource.c | 2 +-
src/gallium/drivers/
From: Philipp Zabel
Just increment the resource seqno instead of setting the texture
seqno to be lower by one than the resource seqno.
Signed-off-by: Philipp Zabel
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 6 +-
1 file changed, 1 insertion(+), 5 delet
Timothy Arceri writes:
> On 10/05/17 22:00, Nicolai Hähnle wrote:
>> On 10.05.2017 02:28, Eric Anholt wrote:
>>> Timothy Arceri writes:
>>>
---
src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +-
src/mesa/main/fbobject.c | 31
On 10 May 2017 at 16:38, Jason Ekstrand wrote:
> On Wed, May 10, 2017 at 8:26 AM, Emil Velikov
> wrote:
>>
>> Hi Jason,
>>
>> Humble unrelated question.
>>
>> On 9 May 2017 at 18:00, Jason Ekstrand wrote:
>>
>> > + if (isl_surf_usage_is_depth(info->usage)) {
>> > + if (info->format == ISL
Build mesa 4325 failed
Commit c334c7dd75 by Marek Olšák on 4/9/2017 11:17 AM:
st/mesa: don't call util_draw_init_info in st_draw_vbo
Configure your notification preferences
___
mesa-dev mailing list
mesa-de
Hi all,
So when I sent a previous patch for this, I learned that because of how
D3D9 works, Nine apparently potentially uses generic shader
inputs/outputs with very high indices.
Despite this, merging the bitfields should work out okay. It reduces the
number of generics that we track via outputs_
From: Nicolai Hähnle
---
src/gallium/drivers/radeonsi/si_shader.c| 2 +-
src/gallium/drivers/radeonsi/si_shader.h| 5 +
src/gallium/drivers/radeonsi/si_state_shaders.c | 4 ++--
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_sha
From: Nicolai Hähnle
OpenGL uses at most 32 generic outputs/inputs in any stage, and they always
have a shader IO index and therefore fit into the outputs_written/
inputs_read/kill_outputs fields.
However, Nine uses semantic indices more liberally. We support that
in VS-PS pipelines, except that
From: Nicolai Hähnle
This is a high as possible while still allowing to merge the bitfields
with the next commit.
For OpenGL, 32 would be sufficient. Nine apparently uses (much!) higher
indices than. Indices that are out of bound don't hurt for VS-PS
pipelines, except that the VS output kill opt
From: Nicolai Hähnle
By keeping track of fewer generics, everything can fit into 64 bits.
---
src/gallium/drivers/radeonsi/si_shader.c| 32 +++--
src/gallium/drivers/radeonsi/si_shader.h| 6 +
src/gallium/drivers/radeonsi/si_state_shaders.c | 22 +++--
From: Nicolai Hähnle
---
src/gallium/drivers/radeonsi/si_shader.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index 9829286..c12c8ea 100644
--- a/src/gallium/drivers/radeonsi/si_shader.c
+++ b/src/galliu
On 10.05.2017 17:42, Alex Deucher wrote:
Cc: 17.1
Signed-off-by: Alex Deucher
Reviewed-by: Nicolai Hähnle
---
include/pci_ids/radeonsi_pci_ids.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/pci_ids/radeonsi_pci_ids.h
b/include/pci_ids/radeonsi_pci_ids.h
index 1058682..a2
From: Ben Widawsky
Modifiers will be obtained or guessed by the client and passed in during
image creation/import.
As of this patch, the modifiers aren't plumbed all the way down, this
patch simply makes sure the interface level stuff is correct and keeps
interface versioning consistent.
v2: Do
From: Pekka Paalanen
The EGL_EXT_dma_buf_import_modifiers extension adds support for a
fourth plane, just like DRM KMS API does.
Bump maximum dma_buf plane count to four.
v2: prevent attribute tokens from being parsed if
EXT_image_dma_buf_import_modifiers is not suported. (Emil Velikov)
Si
From: Pekka Paalanen
add createImageFromDmaBufs2 function which accepts per-plane dmabuf
format modifiers.
Signed-off-by: Pekka Paalanen
Signed-off-by: Varad Gautam
---
include/GL/internal/dri_interface.h | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git
From: Varad Gautam
we currently ignore the plane count when converting from
__DRI_IMAGE_FORMAT* tokens to __DRI_IMAGE_FOURCC* for multiplanar
images, and only return the first plane's simplified fourcc.
this adds a fourcc to __DRI_IMAGE_FORMAT_* mapping to dri, allowing
us to return the correct
From: Varad Gautam
introduce modifier field in DRIimage and set it to
DRM_FORMAT_MOD_INVALID for now. support DRIimage modifier
queries.
Suggested-by: Daniel Stone
Signed-off-by: Varad Gautam
---
src/gallium/state_trackers/dri/dri2.c | 15 +++
src/gallium/state_trackers/dri/
From: Varad Gautam
support importing dmabufs into DRIimage while taking format modifiers
in account, as per DRIimage extension version 15.
bump __DRIimageExtension to 15.
v2: initialize winsys modifier to DRM_FORMAT_MOD_INVALID (Daniel Stone)
Signed-off-by: Varad Gautam
---
src/gallium/inclu
One more time, from the top!
Hi all,
The v3 diverges somewhat form v2 while building upon the suggestions
received on earlier patchsets, and hence warrants a resend. Here's a
breakdown of patches in this series, and the changes since v2.
01 slightly reworks the multi-plane YUV import path in st/
From: Varad Gautam
allow creating EGLImages with dmabuf format modifiers when target is
EGL_LINUX_DMA_BUF_EXT for EGL_EXT_image_dma_buf_import_modifiers.
v2:
- clear modifier assembling and error label name (Eric Engestrom)
v3:
- remove goto jumps within switch-case (Emil Velikov)
- treat zer
From: Pekka Paalanen
Rather than hardcoding 3, use a #define. Makes it easier to bump this
later to 4.
Signed-off-by: Pekka Paalanen
Signed-off-by: Varad Gautam
Reviewed-by: Eric Engestrom
---
src/egl/drivers/dri2/egl_dri2.c | 8
src/egl/main/eglimage.h | 8 +---
2 files
From: Varad Gautam
these allow querying the driver for supported dmabuf formats and
modifiers.
v2: move to __DRIimageExtension version 16.
v3: return GLBoolean for error reporting, document params better.
Signed-off-by: Varad Gautam
---
include/GL/internal/dri_interface.h | 42 +++
From: Varad Gautam
ask the driver for supported dmabuf formats
v2: rebase to master.
v3: return false on failure.
v4: use pscreen->is_format_supported instead of adding a new query.
(Lucas Stach)
Signed-off-by: Varad Gautam
---
src/gallium/state_trackers/dri/dri2.c | 91 +++
From: Varad Gautam
allow egl clients to query the dmabuf formats supported on this platform.
v2: rebase to master.
v3: return EGL_FALSE upon failure.
Signed-off-by: Louis-Francis Ratté-Boulianne
Signed-off-by: Varad Gautam
---
src/egl/drivers/dri2/egl_dri2.c | 18 ++
src/egl/
From: Varad Gautam
ask the driver for supported modifiers for a given format.
bump __DRIimageExtension to 16.
v2: move to __DRIimageExtension v16.
v3: fail if the supplied format is not supported by driver.
v4: purge PIPE_CAP_QUERY_DMABUF_ATTRIBS.
Signed-off-by: Varad Gautam
---
src/gallium/s
From: Varad Gautam
query and return supported dmabuf format modifiers for
EGL_EXT_image_dma_buf_import_modifiers.
v2: rebase to master.
v3: move format check to the driver instead of making format queries
from here and then checking.
Signed-off-by: Varad Gautam
---
src/egl/drivers/dri2/eg
From: Varad Gautam
format modifiers tokens are driver specific, and hence, need to come
in from the driver. this allows drivers to be queried for supported
format modifiers for EGL_EXT_image_dma_buf_import_modifiers.
v2: rebase to master.
v3: drivers must return false on query failure.
v4: use p
From: Varad Gautam
Signed-off-by: Varad Gautam
---
src/egl/drivers/dri2/egl_dri2.c | 6 ++
src/egl/main/eglapi.c | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 7f0edf6..853b6e5 100644
--- a/src/egl/driv
From: Marek Olšák
for some reason, only scons can build these.
---
src/gallium/tests/graw/fs-fragcoord.c| 2 +-
src/gallium/tests/graw/fs-frontface.c| 2 +-
src/gallium/tests/graw/fs-test.c | 2 +-
src/gallium/tests/graw/fs-write-z.c | 2 +-
src/gallium/tests/graw/gs-tes
Good catch!
Reviewed-By: Wladimir J. van der Laan
On Wed, May 10, 2017 at 06:01:04PM +0200, Lucas Stach wrote:
> PIPE_BUFFER is a target enum, not a binding. This caused the driver to
> up-align the height of buffer resources, leading to largely oversizing
> those resources. This is especially b
Reviewed-by: Marek Olšák
Marek
On Wed, May 10, 2017 at 10:27 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> deregisterEHFrames doesn't take any parameters anymore.
>
> Signed-off-by: Michel Dänzer
> ---
> src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 12 +---
> 1 file changed,
On Tue, May 02, 2017 at 05:01:23PM -0700, Jason Ekstrand wrote:
> On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> wrote:
>
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/blorp/blorp.h | 9 ++
> > src/intel/blorp/blorp_clear.c | 64 ++
> > ++
Yes, good idea to do this in one place.
Reviewed-By: Wladimir J. van der Laan
On Wed, May 10, 2017 at 06:01:06PM +0200, Lucas Stach wrote:
> This way we can just test the feature bits and don't need to spread
> the debug overrides to all locations touching a feature.
>
> Signed-off-by: Lucas St
On Tue, May 02, 2017 at 05:15:46PM -0700, Jason Ekstrand wrote:
> On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> wrote:
>
> > Make the function take in an image instead of an image view. This
> > enables us to record relocations for surfaces states created outside of
> > the anv_CreateImageView
On Tue, May 09, 2017 at 10:00:34AM -0700, Jason Ekstrand wrote:
> The Ivy Bridge PRM provides a nice table that handles most of the
> alignment cases in one place. For standard color buffers we have a
> little freedom of choice but for most depth, stencil and compressed it's
> hard-coded. Chad's
Seems more straightforward, but I don't know the rationale
why it was done the way it was.
Reviewed-By: Wladimir J. van der Laan
On Wed, May 10, 2017 at 06:01:08PM +0200, Lucas Stach wrote:
> From: Philipp Zabel
>
> Just increment the resource seqno instead of setting the texture
> seqno to
From: Marek Olšák
Cc: 17.1
Reviewed-by: Alex Deucher
Reviewed-by: Nicolai Hähnle
---
include/pci_ids/radeonsi_pci_ids.h| 2 ++
src/amd/common/amd_family.h | 1 +
src/gallium/drivers/radeon/r600_pipe_common.c | 2 ++
src/gallium/drivers/radeonsi/si_pipe.c|
From: Marek Olšák
Cc: 17.1
Reviewed-by: Alex Deucher
Reviewed-by: Nicolai Hähnle
---
src/amd/addrlib/gfx9/gfx9addrlib.cpp | 57
src/amd/addrlib/gfx9/gfx9addrlib.h | 8 +++--
src/amd/common/amdgpu_id.h | 10 +++
3 files changed, 72 insertio
On Wed, May 03, 2017 at 02:24:19PM -0700, Jason Ekstrand wrote:
> On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> wrote:
>
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/vulkan/genX_cmd_buffer.c | 93 ++
> >
> > 1 file changed, 93 insertions(+)
> >
>
This unifies the Gen4-5 and Gen6+ line width calculations.
I believe it also fixes a bug - we weren't rounding the line width
to the nearest integer. The GL 4.5 (and GL 2.1) specs "Wide Lines"
section says:
"The actual width of non-antialiased lines is determined by rounding
the supplied width
Modern GL specifications say that the point size should be 1.0 when
gl_PointSize is unwritten and the last enabled stage is a geometry
or tessellation shader. If it's a vertex shader, though, both the
GL specs and ES 3.0 spec say that it's undefined - so since Gen4-5
only support vertex shaders, t
This effectively reverts Robert Ellison's 2009 commit
cc8afbd3862fedfe42e51c3774960d1c7078ec53.
I'm not seeing any GL spec text indicating that UPPER won't work.
On Gen6+, this bit moved to 3DSTATE_WM as a single bit, controlling
UPPER_LEFT vs. UPPER_RIGHT. There is no way to request LOWER_RIGHT,
This updates the Gen4-5 code to use a line end cap width of 0.5
for non-smooth lines, and 1.0 for smooth lines - which is what we
do on Gen6+.
---
src/mesa/drivers/dri/i965/brw_sf_state.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_sf_stat
Apparently, Nanhai made the Gen4-5 point size calculations round to the
nearest integer in commit 8d5231a3582e4f2769ac0685cf0174e09750700e,
"according to spec". When Eric first ported the driver to Sandybridge,
he did not implement this rounding.
In the GL 2.1 and 3.0 specs "Basic Point Rasteriza
It's a U3.1. It became a U3.7 on Sandybridge.
---
src/intel/genxml/gen4.xml | 2 +-
src/intel/genxml/gen45.xml | 2 +-
src/intel/genxml/gen5.xml | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/intel/genxml/gen4.xml b/src/intel/genxml/gen4.xml
index d3a2f9264e1..f4d588
Build mesa 4329 failed
Commit 0f34b674ed by Kenneth Graunke on 5/8/2017 5:50 AM:
i965: Switch BRW_NEW_CURBE_OFFSETS to BRW_NEW_PUSH_CONSTANT_ALLOCATION.\n\nThe BRW_NEW_CURBE_OFFSETS dirty bit is signalled when changing the\npartitioning of the Constant Buffer U
This was used by the meta fast clear code. Now that we've switched
back to BLORP, it's always true.
We might want it back when we add a RECTLIST extension to GL, but
that's someday in the future...
---
src/mesa/drivers/dri/i965/brw_context.c | 1 -
src/mesa/drivers/dri/i965/brw_context.h
Reviewed-by: Kristian H. Kristensen
On Wed, May 10, 2017 at 12:01 PM, Kenneth Graunke wrote:
> This was used by the meta fast clear code. Now that we've switched
> back to BLORP, it's always true.
>
> We might want it back when we add a RECTLIST extension to GL, but
> that's someday in the futu
https://bugs.freedesktop.org/show_bug.cgi?id=100201
Anonymous Helper changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Hi Marek,
A comment below
Den 10 maj 2017 20:29 skrev "Marek Olšák" :
From: Marek Olšák
Cc: 17.1
Reviewed-by: Alex Deucher
Reviewed-by: Nicolai Hähnle
---
src/amd/addrlib/gfx9/gfx9addrlib.cpp | 57 ++
++
src/amd/addrlib/gfx9/gfx9addrlib.h | 8 +++--
src/a
On Wed, May 10, 2017 at 11:30 AM, Nanley Chery
wrote:
> On Wed, May 03, 2017 at 02:24:19PM -0700, Jason Ekstrand wrote:
> > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery
> > wrote:
> >
> > > Signed-off-by: Nanley Chery
> > > ---
> > > src/intel/vulkan/genX_cmd_buffer.c | 93
>
We use Instruction State Base Address on Ironlake, so we want KSP to be
an offset not an actual pointer. Gen4/G45 use pointers.
---
src/intel/genxml/gen5.xml | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml
This whole code is surrounded in #if GEN_GEN >= 6, and this code only
applies on Sandybridge. So, use GEN_GEN == 6 to reduce the delta in
the next patch, when we add Gen4-5 support.
---
src/mesa/drivers/dri/i965/genX_state_upload.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
d
It's actually not that much code.
---
src/intel/genxml/gen4.xml | 2 +-
src/intel/genxml/gen45.xml| 2 +-
src/intel/genxml/gen5.xml | 2 +-
src/mesa/drivers/dri/i965/Makefile.sources| 1 -
src/mesa/drivers/dri/i965/brw_vs_stat
Hi Lucas,
2017-05-10 18:01 GMT+02:00 Lucas Stach :
> Use the proper pipe_resource_reference function instead of
> rolling our own.
Would it make sense to convert all gallium drivers using this pattern?
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundclou
On Wed, May 10, 2017 at 9:36 PM, Nils Wallménius
wrote:
> Hi Marek,
>
> A comment below
>
> Den 10 maj 2017 20:29 skrev "Marek Olšák" :
>
> From: Marek Olšák
>
> Cc: 17.1
> Reviewed-by: Alex Deucher
> Reviewed-by: Nicolai Hähnle
> ---
> src/amd/addrlib/gfx9/gfx9addrlib.cpp | 57
>
You can always use a NULL BO but this is fine too.
Reviewed-by: Jason Ekstrand
On Wed, May 10, 2017 at 12:41 PM, Kenneth Graunke
wrote:
> We use Instruction State Base Address on Ironlake, so we want KSP to be
> an offset not an actual pointer. Gen4/G45 use pointers.
> ---
> src/intel/genxml
Signed-off-by: Leo Liu
Reviewed-by: Christian König
---
src/gallium/drivers/radeon/radeon_vcn_dec.c | 197 +++-
1 file changed, 193 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c
b/src/gallium/drivers/radeon/radeon_vcn_dec.c
index
Signed-off-by: Leo Liu
Reviewed-by: Christian König
---
src/gallium/drivers/radeon/radeon_vcn_dec.c | 51 +
1 file changed, 51 insertions(+)
diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c
b/src/gallium/drivers/radeon/radeon_vcn_dec.c
index 0323114..82dfa71
Signed-off-by: Leo Liu
Reviewed-by: Christian König
---
src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
index 3e92fff..97804e1 100644
1 - 100 of 157 matches
Mail list logo
