On 10 May 2017 at 00:10, Dave Airlie <airl...@gmail.com> wrote: > On 6 May 2017 at 02:35, Daniel Stone <dan...@fooishbar.org> wrote: >> Hi Emil, >> >> On 4 May 2017 at 15:14, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>> On 4 May 2017 at 14:43, Daniel Stone <dan...@fooishbar.org> wrote: >>>> IOW, there is no change as far as I can see, but perhaps for the >>>> meantime, we could use an unreachable() at the bottom of >>>> modifier_to_tiling(). Would that help? >>>> >>> Yes the default statement and return I915_TILING_NONE in >>> modifier_to_tiling() seem unreachable. >>> >>> unreachable or assert - I am leaning slightly towards the latter since >>> it will catch fallouts in the future. >>> I'll leave the decision to you and the Intel devs. >>> >>> In either case: >>> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> >> >> Cool, I've pushed these both now with an assert - thanks! > > unreachable() is causing compiler errors here. > > Need something inside the (). > Should be fixed with d4342b1398a001af1192497ca4db3a304f98c309 and I'll pick this for 17.1. Thanks for the shout out Dave!
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
