Re: [Mesa-dev] [PATCH] radv: allocate thin textures as linear.

2017-04-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Apr 13, 2017 at 6:14 AM, Dave Airlie wrote: > From: Dave Airlie > > This is ported from radeonsi, and avoids the bug in the > addrlib code. This should probably be something addrlib > does for us, but for now this fixes the regression without > changing ad

Re: [Mesa-dev] [PATCH] radv: fix stencil regression since new addrlib import

2017-04-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Apr 13, 2017 at 6:37 AM, Dave Airlie wrote: > From: Dave Airlie > > The addrlib import meant we'd return after we attempted > to setup the no stencil bits for an S8_UINT, now we break > and use the stencil level info when creating stencil DB > info. > > Si

Re: [Mesa-dev] [PATCH 2/9] radv: simplify if statement

2017-04-13 Thread Thomas H.P. Andersen
On Wed, Apr 12, 2017 at 12:50 AM, Bas Nieuwenhuizen wrote: > On Wed, Apr 12, 2017 at 12:48 AM, Dave Airlie wrote: >> On 12 April 2017 at 08:19, Bas Nieuwenhuizen >> wrote: >>> On Wed, Apr 12, 2017 at 12:04 AM, Thomas Hindoe Paaboel Andersen >>> wrote: --- src/amd/vulkan/radv_wsi.c |

[Mesa-dev] [PATCH] mesa/glthread: add async support to ARB_viewport_array functions

2017-04-13 Thread Bartosz Tomczyk
--- src/mapi/glapi/gen/ARB_viewport_array.xml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_viewport_array.xml b/src/mapi/glapi/gen/ARB_viewport_array.xml index ebd5b99c83..dbda1d8ad0 100644 --- a/src/mapi/glapi/gen/ARB_viewport_array.xml ++

Re: [Mesa-dev] [PATCH] swr: return true for PIPE_CAP_DOUBLES

2017-04-13 Thread Nicolai Hähnle
On 11.04.2017 18:53, Tim Rowley wrote: --- src/gallium/drivers/swr/swr_screen.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp index d737ddf..3d3d103 100644 --- a/src/gallium/drivers/swr/swr_screen.cpp +++ b/

Re: [Mesa-dev] [PATCH] gallium/docs: small correction about register files for atomics

2017-04-13 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 12.04.2017 17:52, Rob Clark wrote: These can operate on MEMORY[], in addition to BUFFER[] and IMAGE[] Signed-off-by: Rob Clark --- src/gallium/docs/source/tgsi.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/docs/source

Re: [Mesa-dev] [PATCH] mesa/glthread: add async support to ARB_viewport_array functions

2017-04-13 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 13.04.2017 10:47, Bartosz Tomczyk wrote: --- src/mapi/glapi/gen/ARB_viewport_array.xml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_viewport_array.xml b/src/mapi/glapi/gen/ARB_viewport_array.xml index ebd5

Re: [Mesa-dev] [PATCH 9/9] util/disk_cache: remove null check before free

2017-04-13 Thread Nicolai Hähnle
Patches 8 & 9: Reviewed-by: Nicolai Hähnle On 12.04.2017 00:04, Thomas Hindoe Paaboel Andersen wrote: --- src/util/disk_cache.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index d9de8ef..93fb1f5 100644 ---

Re: [Mesa-dev] [PATCH 02/14] mesa: add env var to force enable the KHR_no_error ctx flag

2017-04-13 Thread Nicolai Hähnle
On 13.04.2017 01:42, Timothy Arceri wrote: --- docs/envvars.html | 3 +++ src/mesa/main/context.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 6537365..0f321da 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -39,20 +39,23 @@

[Mesa-dev] [PATCH] i965/drm: Delete NULL check in brw_bo_unmap().

2017-04-13 Thread Kenneth Graunke
I accidentally moved the bo->bufmgr dereference above the NULL check when cleaning up this code. While passing NULL to free() is a common pattern...passing NULL to unmap seems pretty bad. You really ought to know whether you have a buffer or not. We don't want to paper over bugs like that. So,

Re: [Mesa-dev] [PATCH 05/14] mesa: add KHR_no_error support to glUniform*() functions

2017-04-13 Thread Nicolai Hähnle
On 13.04.2017 01:42, Timothy Arceri wrote: --- src/mesa/main/uniform_query.cpp | 76 - 1 file changed, 53 insertions(+), 23 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index e613898..7aa035a 100644 --- a/src

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-13 Thread Marek Olšák
On Apr 13, 2017 3:34 AM, "Markus Trippelsdorf" wrote: On 2017.04.12 at 20:45 +0100, Emil Velikov wrote: > On 12 April 2017 at 20:34, Constantine Kharlamov wrote: > > >> I suspect this breaks because r600 more often fails to > >> compile some shaders, > >> and the hw requires a fragment shader an

Re: [Mesa-dev] [PATCH 13/14] mesa/vbo: add KHR_no_error support to DrawElements*() functions

2017-04-13 Thread Nicolai Hähnle
On 13.04.2017 01:42, Timothy Arceri wrote: --- src/mesa/vbo/vbo_exec_array.c | 158 +++--- 1 file changed, 104 insertions(+), 54 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index 6e3cd5a..d85c7ad 100644 --- a/src/me

Re: [Mesa-dev] [PATCH 14/14] mesa: add KHR_no_error support to glVertexAttribDivisor()

2017-04-13 Thread Nicolai Hähnle
Patches 11, 12, & 14: Reviewed-by: Nicolai Hähnle On 13.04.2017 01:42, Timothy Arceri wrote: --- src/mesa/main/varray.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 3f61608..89a0984 100644 --- a/

Re: [Mesa-dev] [RFC PATCH 01/26] mesa: add ARB_bindless_texture to the extensions list

2017-04-13 Thread Nicolai Hähnle
On 12.04.2017 17:59, Marek Olšák wrote: On Tue, Apr 11, 2017 at 7:06 PM, Samuel Pitoiset wrote: On 04/11/2017 06:58 PM, Ilia Mirkin wrote: On Tue, Apr 11, 2017 at 12:48 PM, Samuel Pitoiset wrote: This is required for the following GLSL bits. Signed-off-by: Samuel Pitoiset --- src/mes

Re: [Mesa-dev] [PATCH] swr: return true for PIPE_CAP_DOUBLES

2017-04-13 Thread Rowley, Timothy O
On Apr 13, 2017, at 4:26 AM, Nicolai Hähnle mailto:nhaeh...@gmail.com>> wrote: On 11.04.2017 18:53, Tim Rowley wrote: --- src/gallium/drivers/swr/swr_screen.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp ind

Re: [Mesa-dev] Mesa 17.1.0 release plan

2017-04-13 Thread Emil Velikov
On 9 March 2017 at 15:52, Emil Velikov wrote: > Hi all, > > Here is the current tentative 17.1.0 release schedule. > > Apr 14 2017 - Feature freeze/Release candidate 1 > Apr 21 2017 - Release candidate 2 > Apr 28 2017 - Release candidate 3 > May 05 2017 - Release candidate 4/final release > Re

[Mesa-dev] [PATCH 1/3] etnaviv: Add chipMinorFeatures4 and 5

2017-04-13 Thread Wladimir J. van der Laan
Request chipMinorFeatures bitfields 4 and 5 from the drm driver. --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 src/gallium/drivers/etnaviv/etnaviv_screen.h | 4 +++- 2 files changed, 15 insertions(+), 1 deletion(-) Adds two further chipminorfeatures words - viv_chipMinorFe

[Mesa-dev] [PATCH 2/3] etnaviv: Update includes from rnndb

2017-04-13 Thread Wladimir J. van der Laan
Update to etna_viv commit 411bd69. --- src/gallium/drivers/etnaviv/hw/cmdstream.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/common.xml.h| 10 ++-- src/gallium/drivers/etnaviv/hw/isa.xml.h | 75 +- src/gallium/drivers/etnaviv/hw/state.xml.h | 10 ++-- src/gal

[Mesa-dev] [PATCH 3/3] etnaviv: SINGLE_BUFFER support on GC3000

2017-04-13 Thread Wladimir J. van der Laan
This patch adds support for the SINGLE_BUFFER feature on GC3000 GPUs, which allows rendering to a single buffer using multiple pixel pipes. This feature is always used when it is available, which means that multi-tiled formats are no longer being used in that case, and all buffers will be normal (

Re: [Mesa-dev] [PATCH 3/3] etnaviv: SINGLE_BUFFER support on GC3000

2017-04-13 Thread Christian Gmeiner
Hi 2017-04-13 16:05 GMT+02:00 Wladimir J. van der Laan : > This patch adds support for the SINGLE_BUFFER feature on GC3000 > GPUs, which allows rendering to a single buffer using multiple pixel > pipes. > > This feature is always used when it is available, which means that > multi-tiled formats a

Re: [Mesa-dev] [PATCH 3/3] etnaviv: SINGLE_BUFFER support on GC3000

2017-04-13 Thread Christian Gmeiner
And you forgot your Signed-off-by line! greets -- Christian Gmeiner, MSc https://www.youtube.com/user/AloryOFFICIAL https://soundcloud.com/christian-gmeiner 2017-04-13 16:25 GMT+02:00 Christian Gmeiner : > Hi > > 2017-04-13 16:05 GMT+02:00 Wladimir J. van der Laan : >> This patch adds support

Re: [Mesa-dev] [PATCH 3/3] etnaviv: SINGLE_BUFFER support on GC3000

2017-04-13 Thread Philipp Zabel
Hi Wladimir, On Thu, 2017-04-13 at 16:05 +0200, Wladimir J. van der Laan wrote: > This patch adds support for the SINGLE_BUFFER feature on GC3000 > GPUs, which allows rendering to a single buffer using multiple pixel > pipes. > > This feature is always used when it is available, which means that

Re: [Mesa-dev] [RFC PATCH 1/3] gallium: decrease the size of pipe_vertex_buffer - 24 -> 16 bytes

2017-04-13 Thread Marek Olšák
Actually, pipe_buffer_union is also used in pipe_draw_info::index, which replaces pipe_index_buffer::*buffer. Marek On Apr 12, 2017 12:00 PM, "Marek Olšák" wrote: > On Wed, Apr 12, 2017 at 5:59 AM, Brian Paul wrote: > > On 04/11/2017 02:15 PM, Marek Olšák wrote: > >> > >> From: Marek Olšák >

Re: [Mesa-dev] [PATCH] clover: Fix build against clang SVN >= r299965

2017-04-13 Thread Alan Swanson
On Thu, 2017-04-13 at 13:00 +0900, Michel Dänzer wrote: > On 13/04/17 03:15 AM, Francisco Jerez wrote: > > Michel Dänzer writes: > > > > > From: Michel Dänzer > > > > > > clang::LangAS::Offset is gone, the behaviour is as if it was 0. > > > Signed-off-by: Michel Dänzer > > > --- > > >  src/gal

Re: [Mesa-dev] [PATCH] swr: return true for PIPE_CAP_DOUBLES

2017-04-13 Thread Nicolai Hähnle
On 13.04.2017 14:20, Rowley, Timothy O wrote: On Apr 13, 2017, at 4:26 AM, Nicolai Hähnle mailto:nhaeh...@gmail.com>> wrote: On 11.04.2017 18:53, Tim Rowley wrote: --- src/gallium/drivers/swr/swr_screen.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/swr_screen.

[Mesa-dev] [RFC] nir: add pass to lower atomic counters to SSBO

2017-04-13 Thread Rob Clark
This is equivalent to what mesa/st does in glsl_to_tgsi. For most hw there isn't a particularly good reason to treat these differently. Signed-off-by: Rob Clark --- This is part of a larger patchset I'm working on to add SSBO and compute shader support in mesa/st glsl_to_nir path, and compute/SS

Re: [Mesa-dev] [PATCH 5/6] radeonsi: provide VS_STATE input to all VS variants

2017-04-13 Thread Nicolai Hähnle
On 12.04.2017 11:20, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_descriptors.c | 6 +- src/gallium/drivers/radeonsi/si_shader.c| 15 ++- src/gallium/drivers/radeonsi/si_shader.h| 13 + src/gallium/drivers/radeons

[Mesa-dev] [PATCH] radeonsi: add missing initialization for userptr buffers

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle Fix the accounting for memory usage of userptr buffers, which has been wrong forever (or at least for a long time). Also initialize flags. Without this initialization, the sparse buffer flag might end up being set, which leads to staging buffers being used unnecessarily (and

Re: [Mesa-dev] [RFC] nir: add pass to lower atomic counters to SSBO

2017-04-13 Thread Jason Ekstrand
Nice! This may let us delete some back-end code too. I'll review later. On Thu, Apr 13, 2017 at 8:23 AM, Rob Clark wrote: > This is equivalent to what mesa/st does in glsl_to_tgsi. For most hw > there isn't a particularly good reason to treat these differently. > > Signed-off-by: Rob Clark >

Re: [Mesa-dev] [RFC] nir: add pass to lower atomic counters to SSBO

2017-04-13 Thread Rob Clark
On Thu, Apr 13, 2017 at 11:44 AM, Jason Ekstrand wrote: > Nice! This may let us delete some back-end code too. I'll review later. I looked a bit at i965, and I think it could.. we may want to introduce ssbo_inc and ssbo_dec instructions so you can keep using hw inc/dec instructions (but then l

Re: [Mesa-dev] [PATCH v2 0/3] asynchronous pbo transfer with glthread

2017-04-13 Thread gregory hainaut
On Wed, 5 Apr 2017 12:52:03 +0200 Gregory Hainaut wrote: > > Still, I believe there is the following bug in the series: > > > glGenBuffers(1, &pbo); > > glBindBuffer(..., pbo); > > glDeleteBuffers(1, &pbo); > > glTexSubImage2D(...); // will be asynchronous, but refers to user memory > > because

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #15 from Dieter Nützel --- Michel and Christian, can we have this patch in 17.1 (final)? I have to apply it by hand on every build. Any further logs/debug needed? -- You are receiving this mail because: You are on the CC list for

[Mesa-dev] [PATCH v2] configure.ac: add --enable-sanitize option

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle Enable code sanitizers by adding -fsanitize=$foo flags for the compiler and linker. In addition, this also disables checking for undefined symbols: running the address sanitizer requires additional symbols which should be provided by a preloaded libasan.so (preloaded for hoo

Re: [Mesa-dev] [PATCH v2 0/3] asynchronous pbo transfer with glthread

2017-04-13 Thread Nicolai Hähnle
Hi Gregory, Sorry, this got dropped somehow. On 13.04.2017 17:49, gregory hainaut wrote: On Wed, 5 Apr 2017 12:52:03 +0200 Gregory Hainaut wrote: Still, I believe there is the following bug in the series: glGenBuffers(1, &pbo); glBindBuffer(..., pbo); glDeleteBuffers(1, &pbo); glTexSubIm

[Mesa-dev] [PATCH] clover: Add missing include to compat header

2017-04-13 Thread Jan Vesely
Fixes build failure with LLVM 4 Fixes: a981e68c26dc4079a335101da0033185030207f6 (clover: Fix build against clang SVN >= r299965) Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/compat.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers

Re: [Mesa-dev] [PATCH V3 2/2] glsl: don't run the GLSL pre-processor when we are skipping compilation

2017-04-13 Thread Dieter Nützel
Tested-by (v3): Dieter Nützel I'm running 'all the time' with this. Am 10.04.2017 03:48, schrieb Timothy Arceri: Improves Deus Ex start-up times with a warm cache from ~30 seconds to ~22 seconds. Also fixes the leaking of state. V2: fix indentation v3: add the value of MESA_EXTENSION_OVERRI

Re: [Mesa-dev] [PATCH v2 3/3] mapi/glthread: generate asynchronous code for PBO transfer

2017-04-13 Thread Nicolai Hähnle
On 05.04.2017 12:30, Gregory Hainaut wrote: # Classify fixed and variable parameters. self.fixed_params = [] self.variable_params = [] for p in self.parameters: if p.is_padding: continue -if

[Mesa-dev] [PATCH] docs: Update MESA_shader_integer_functions spec to version 3.

2017-04-13 Thread Kenneth Graunke
When publishing this spec on the OpenGL ES registry, Jon Leech noticed that it didn't actually mention what the ES dependencies and interactions were. I looked at extensions_table.h and noted that we expose it in ES 3.0 contexts, and he added the obvious spec texts. The updated copy also contains

Re: [Mesa-dev] [PATCH v2 3/3] mapi/glthread: generate asynchronous code for PBO transfer

2017-04-13 Thread gregory hainaut
On Thu, 13 Apr 2017 18:31:06 +0200 Nicolai Hähnle wrote: > On 05.04.2017 12:30, Gregory Hainaut wrote: > > # Classify fixed and variable parameters. > > self.fixed_params = [] > > self.variable_params = [] > > for p in self.parameters: > >

Re: [Mesa-dev] [PATCH] docs: Update MESA_shader_integer_functions spec to version 3.

2017-04-13 Thread Matt Turner
Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 3/3] mapi/glthread: generate asynchronous code for PBO transfer

2017-04-13 Thread Nicolai Hähnle
On 13.04.2017 18:39, gregory hainaut wrote: On Thu, 13 Apr 2017 18:31:06 +0200 Nicolai Hähnle wrote: On 05.04.2017 12:30, Gregory Hainaut wrote: # Classify fixed and variable parameters. self.fixed_params = [] self.variable_params = [] for p

Re: [Mesa-dev] [PATCH] radeonsi: add missing initialization for userptr buffers

2017-04-13 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Apr 13, 2017 at 5:42 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fix the accounting for memory usage of userptr buffers, which has been wrong > forever (or at least for a long time). > > Also initialize flags. Without this initialization, the spa

Re: [Mesa-dev] [PATCH] swr: Align swr_context allocation to SIMD alignment.

2017-04-13 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Apr 12, 2017, at 6:43 PM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: The context now contains SIMD vectors which must be aligned (specifically samplePositions in the rastState in the derived state). Failure to align ca

Re: [Mesa-dev] [PATCH] swr: Removed unnecessary PIPE_BIND flags from swr_is_format_supported

2017-04-13 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Apr 12, 2017, at 6:53 PM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: Removed unnecessary and probably wrong PIPE_BIND_SCANOUT and PIPE_BIND_SHARED flags in favor of check on single PIPE_BIND_DISPLAY_TARGET flag. Refere

Re: [Mesa-dev] [PATCH v2 0/3] asynchronous pbo transfer with glthread

2017-04-13 Thread Dieter Nützel
Hello Gregory, do you have the v3 'ready'? v2 do NOT apply any longer since Samuel Pitoiset's changes for 'bind less'. I'm running with this on Turks XT since you've sent it. Greetings, Dieter Am 13.04.2017 17:49, schrieb gregory hainaut: On Wed, 5 Apr 2017 12:52:03 +0200 Gregory Hainaut wr

Re: [Mesa-dev] [PATCH] clover: Add missing include to compat header

2017-04-13 Thread Francisco Jerez
Jan Vesely writes: > Fixes build failure with LLVM 4 > > Fixes: a981e68c26dc4079a335101da0033185030207f6 > (clover: Fix build against clang SVN >= r299965) > > Signed-off-by: Jan Vesely Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/llvm/compat.hpp | 1 + > 1 fi

[Mesa-dev] [PATCH v4 0/3] asynchronous pbo transfer with glthread

2017-04-13 Thread Gregory Hainaut
Hello, Please find a new version to handle invalid buffer handles. Allow to handle this kind of case: genBuffer(&pbo); BindBuffer(pbo) DeleteBuffer(pbo); BindBuffer(rand_pbo) TexSubImage2D(user_memory_pointer); // Data transfer will be synchronous There are various subtely to hand

[Mesa-dev] [PATCH v4 2/3] mesa/glthread: add tracking of PBO binding

2017-04-13 Thread Gregory Hainaut
In gl core, buffer must be reserved first by CreateBuffers/GenBuffers to be valid. v4: update comments based on Nicolai review Signed-off-by: Gregory Hainaut --- src/mesa/main/marshal.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH v4 1/3] mesa/glthread: track buffer creation/destruction

2017-04-13 Thread Gregory Hainaut
It would be used in next commit to allow asynchronous PBO transfer. The tracking saves the buffer name into a hash. Saving pointer will be more complex as the buffer is created in BindBuffer due to IsBuffer insanity. Perf wise DeleteBuffers is now synchronous for robustness. Signed-off-by: Grego

[Mesa-dev] [PATCH v4 3/3] mapi/glthread: generate asynchronous code for PBO transfer

2017-04-13 Thread Gregory Hainaut
Improve speed on PCSX2 v2: Add ppbo/ubpo status in XML file Disable variable parameter (as the pointer would be a fixed offset) v3: split buffer tracking into separate patches. use 'goto fallback_to_sync' when asynchronous transfer isn't supported v4: add Nicolai comment to explain why ppbo isn'

[Mesa-dev] NINE updates for Mesa 17.1? - was: RCP was used incorrectly to support NINED3DSPSM_DW and NINED3DSPSM_DZ. src.x as used as input instead of src.w or src.z.

2017-04-13 Thread Dieter Nützel
Hello Axel, are your NINE updates for Mesa 17.1 coming? I'm running the above mentioned fix (my kinds ;-), so you have my Tested-by: Dieter Nützel Greetings, Dieter ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.or

[Mesa-dev] [PATCH v2] mesa/glthread: add async support to ARB_viewport_array functions

2017-04-13 Thread Bartosz Tomczyk
v2: fix attribute name, it is count_scale not scale_count --- src/mapi/glapi/gen/ARB_viewport_array.xml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_viewport_array.xml b/src/mapi/glapi/gen/ARB_viewport_array.xml index ebd5b99c83..be67912884

[Mesa-dev] [PATCH kmscube 1/6] drm: Provide a failure path when getting the fb

2017-04-13 Thread Ben Widawsky
This is helpful for debugging as you will bail early with an error message instead of a random SIGSEGV (or something more obscure). --- drm-atomic.c | 9 + drm-legacy.c | 8 2 files changed, 17 insertions(+) diff --git a/drm-atomic.c b/drm-atomic.c index 27c6b1e..c06e52f 100644 -

[Mesa-dev] [PATCH kmscube 3/6] common: include config.h

2017-04-13 Thread Ben Widawsky
--- common.h | 4 1 file changed, 4 insertions(+) diff --git a/common.h b/common.h index 2eceac7..f3d9d32 100644 --- a/common.h +++ b/common.h @@ -32,6 +32,10 @@ #include #include +#ifdef HAVE_CONFIG_H + #include "config.h" +#endif + #ifndef EGL_KHR_platform_gbm #define EGL_KHR_plat

[Mesa-dev] [PATCH kmscube 6/6] common: Give cmdline parameter for forcing modifiers

2017-04-13 Thread Ben Widawsky
--- common.c | 13 - common.h | 11 ++- kmscube.c | 14 +++--- 3 files changed, 29 insertions(+), 9 deletions(-) diff --git a/common.c b/common.c index e63bb39..eaaa9a4 100644 --- a/common.c +++ b/common.c @@ -31,9 +31,6 @@ static struct gbm gbm; -#ifndef DRM_FO

[Mesa-dev] [PATCH kmscube 5/6] common: Use libdrm AddFB with modifiers

2017-04-13 Thread Ben Widawsky
Note: nothing happens here yet since LINEAR == 0. --- configure.ac | 2 +- drm-common.c | 37 + 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 33167e4..f564ef3 100644 --- a/configure.ac +++ b/configure.ac @@ -3

[Mesa-dev] [PATCH kmscube 4/6] common: Use the create with modifiers interface

2017-04-13 Thread Ben Widawsky
--- common.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/common.c b/common.c index 4bf3c5a..e63bb39 100644 --- a/common.c +++ b/common.c @@ -31,10 +31,23 @@ static struct gbm gbm; +#ifndef DRM_FORMAT_MOD_LINEAR +#define DRM_FORMAT_MOD_LINEAR 0 +#endif +static int

[Mesa-dev] [PATCH kmscube 2/6] configure: Check for the GBM modifiers

2017-04-13 Thread Ben Widawsky
--- configure.ac | 16 1 file changed, 16 insertions(+) diff --git a/configure.ac b/configure.ac index aa0ef36..33167e4 100644 --- a/configure.ac +++ b/configure.ac @@ -49,5 +49,21 @@ if test "x$HAVE_GST" = "xyes"; then fi AM_CONDITIONAL(ENABLE_GST, [test "x$HAVE_GST" = "xyes"]

[Mesa-dev] [PATCH 1/2] gallium/ddebug: dump missing members of pipe_draw_info

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_dump_state.c | 5 + src/gallium/drivers/ddebug/dd_draw.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/util/u_dump_state.c b/src/gallium/auxiliary/util/u_dump_state.c index 06d5e78..105e5c4 100644 ---

[Mesa-dev] [PATCH 2/2] radeonsi: cope with missing disassembly

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle For robustness and testing purposes. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 78c7495..c5

[Mesa-dev] [PATCH] swr: update gallium driver docs

2017-04-13 Thread Tim Rowley
--- src/gallium/docs/source/drivers/openswr.rst | 2 +- src/gallium/docs/source/drivers/openswr/usage.rst | 9 +++-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/gallium/docs/source/drivers/openswr.rst b/src/gallium/docs/source/drivers/openswr.rst index 84aa51f..e2

[Mesa-dev] [Bug 100668] No pixel formats with WGL_SWAP_UNDEFINED_ARB && WGL_DOUBLE_BUFFER_ARB=true

2017-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100668 --- Comment #1 from Charles Huber --- Created attachment 130833 --> https://bugs.freedesktop.org/attachment.cgi?id=130833&action=edit Init WGL & show number of matching pixel formats -- You are receiving this mail because: You are the QA Con

[Mesa-dev] [PATCH] configure.ac: honour --disable-libunwind if the .pc file is present

2017-04-13 Thread Emil Velikov
From: Emil Velikov We should check the presence in order to determine if we should [implicitly] set the CFLAGS/LIBS Cc: Eric Anholt Reported-by: Eric Anholt Signed-off-by: Emil Velikov --- configure.ac | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure.ac b/con

[Mesa-dev] [PATCH 2/2] vc4: Use runtime CPU detection for whether NEON is available.

2017-04-13 Thread Eric Anholt
This will allow Raspbian's ARMv6 builds to take advantage of the new NEON code, and could prevent problems if vc4 ends up getting used on a v7 CPU without NEON. --- src/gallium/drivers/vc4/vc4_screen.c | 3 +++ src/gallium/drivers/vc4/vc4_tiling.h | 25 + 2 files changed,

[Mesa-dev] [PATCH 1/2] gallium: Enable ARM NEON/VFP CPU detection.

2017-04-13 Thread Eric Anholt
I wrote this code with reference to pixman, though I've only decided to cover Linux (what I'm testing) and Android (seems obvious enough). Linux has getauxval() as a cleaner interface to the /proc entry, but it's more glibc-specific and I didn't want to add detection for that. This will be used t

Re: [Mesa-dev] [PATCH] configure.ac: honour --disable-libunwind if the .pc file is present

2017-04-13 Thread Eric Anholt
Emil Velikov writes: > From: Emil Velikov > > We should check the presence in order to determine if we should > [implicitly] set the CFLAGS/LIBS > > Cc: Eric Anholt > Reported-by: Eric Anholt > Signed-off-by: Emil Velikov > --- > configure.ac | 5 - > 1 file changed, 4 insertions(+), 1 d

[Mesa-dev] [PATCH] swr: add linux to scons build

2017-04-13 Thread George Kyriazis
Make swr compile for both linux and windows. --- src/gallium/drivers/swr/SConscript| 7 +-- src/gallium/targets/libgl-xlib/SConscript | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/swr/SConscript b/src/gallium/drivers/swr/SConscript index ec

Re: [Mesa-dev] [PATCH 1/2] mesa: move glMultiDrawArray to vbo and fix error handling

2017-04-13 Thread Nicolai Hähnle
On 07.04.2017 19:05, Brian Paul wrote: On 04/07/2017 10:30 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle When any count[i] is negative, we must skip all draws. Moving to vbo makes the subsequent change easier. --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/api_validate.c | 38 +

[Mesa-dev] [PATCH v2 1/4] mesa: fix remaining xfb prims check for GLES with multiple instances

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle Found by inspection. --- src/mesa/main/api_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index af4f7cb..8f83432 100644 --- a/src/mesa/main/api_validate.c +++ b/src/mesa/main/api_vali

[Mesa-dev] [PATCH v2 2/4] mesa: extract need_xfb_remaining_prims_check

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle The same logic needs to be applied to glMultiDrawArrays. --- src/mesa/main/api_validate.c | 48 ++-- 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index 8f83

[Mesa-dev] [PATCH v2 4/4] vbo: fix gl_DrawID handling in glMultiDrawArrays

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes a bug in KHR-GL45.shader_draw_parameters_tests.ShaderMultiDrawArraysParameters. Reviewed-by: Marek Olšák --- src/mesa/vbo/vbo_exec_array.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/m

[Mesa-dev] [PATCH v2 3/4] mesa: move glMultiDrawArrays to vbo and fix error handling

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle When any count[i] is negative, we must skip all draws. Moving to vbo makes the subsequent change easier. v2: - provide the function in all contexts, including GLES - adjust validation accordingly to include the xfb check --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/

[Mesa-dev] [PATCH] radv: bump maxGeometryShaderInvocations.

2017-04-13 Thread Dave Airlie
From: Dave Airlie This bumps it to the same level as amdgpu-pro, it also moves a bunch of dEQP-VK.geometry.instanced.* from NotSupported to Pass. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_

Re: [Mesa-dev] [PATCH 12/14] mesa/vbo: add KHR_no_error support to vbo_exec_DrawArrays*()

2017-04-13 Thread Nicolai Hähnle
On second thought, there are a bunch of things that I think need to be answered here: On 13.04.2017 01:42, Timothy Arceri wrote: --- src/mesa/vbo/vbo_exec_array.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/src/mesa/vbo/vbo_ex

[Mesa-dev] [PATCH] radv: support S8_UINT as a depth/stencil format.

2017-04-13 Thread Dave Airlie
From: Dave Airlie This enables a bunch of NotSupported CTS tests. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index 9b21e04..07942e4 100644 --- a/s

Re: [Mesa-dev] [PATCH] radv: bump maxGeometryShaderInvocations.

2017-04-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Apr 13, 2017 at 9:29 PM, Dave Airlie wrote: > From: Dave Airlie > > This bumps it to the same level as amdgpu-pro, it also > moves a bunch of dEQP-VK.geometry.instanced.* from > NotSupported to Pass. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/

Re: [Mesa-dev] [PATCH] radv: support S8_UINT as a depth/stencil format.

2017-04-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Apr 13, 2017 at 9:35 PM, Dave Airlie wrote: > From: Dave Airlie > > This enables a bunch of NotSupported CTS tests. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_formats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

[Mesa-dev] [PATCH] swr: Add polygon stipple support

2017-04-13 Thread George Kyriazis
Add polygon stipple functionality to the fragment shader. Explicitly turn off polygon stipple for lines and points, since we do them using tris. --- src/gallium/drivers/swr/swr_context.h | 4 ++- src/gallium/drivers/swr/swr_shader.cpp | 56 ++ src/gallium/drivers

[Mesa-dev] [PATCH 2/5] tgsi: clarify TGSI_SEMANTIC_{LAYER, VIEWPORT_INDEX}

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle Depending on pipe caps they can be writable in all vertex processing stages, but only the output of the last stage counts. --- src/gallium/docs/source/tgsi.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs

[Mesa-dev] [PATCH 0/5] gallium, radeonsi: enable ARB_shader_viewport_layer_array

2017-04-13 Thread Nicolai Hähnle
Hi all, This is another small one, as the extension is mostly a merge of AMD_vertex_shader_layer and AMD_vertex_shader_viewport_index, and the core Mesa parts are done already. Tested with pending CTS tests. Please review! Thanks, Nicolai -- docs/features.txt| 2 +-

[Mesa-dev] [PATCH 1/5] gallium: add PIPE_CAP_TGSI_TES_LAYER_VIEWPORT

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 4/5] radeonsi: handle ignored LAYER and VIEWPORT_INDEX writes

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 20 1 file changed, 20 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 669fb3e..5b30ace 100644 --- a/src/gallium/drivers/radeonsi/si_sha

[Mesa-dev] [PATCH 3/5] st/mesa: enable ARB_shader_viewport_layer_array

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/mesa/state_tracker/st_extensions.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 8b62360..1df2ba7 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/stat

[Mesa-dev] [PATCH 5/5] radeonsi: enable ARB_shader_viewport_layer_array

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle --- docs/features.txt | 2 +- docs/relnotes/17.1.0.html | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index a2d7785..7ca5fd3 100644

[Mesa-dev] [PATCH 2/2] radv: Set descriptor set limits.

2017-04-13 Thread Bas Nieuwenhuizen
Properly and with comments this time. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 44 +--- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index f14b0fd4f4e

[Mesa-dev] [PATCH 1/2] radv: Increase integer sizes in descriptor sets.

2017-04-13 Thread Bas Nieuwenhuizen
Needed if we want to allow them taking more than 64 KiB. The calculations of these already used 32 bits. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_descriptor_set.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_descriptor_s

[Mesa-dev] [PATCH] r600g: update dirty_level_mask after the 1-st draw after FB change

2017-04-13 Thread Constantine Kharlamov
Ported from radeonsi. Testing with Kane&Lynch2 shows ≈1k skipped updates per frame on average. No piglit changes with tests/gpu.py, gbm mode. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_pipe.h | 1 + src/ga

Re: [Mesa-dev] [PATCH 1/5] gallium: add PIPE_CAP_TGSI_TES_LAYER_VIEWPORT

2017-04-13 Thread Ilia Mirkin
On Thu, Apr 13, 2017 at 4:30 PM, Nicolai Hähnle wrote: > +* ``PIPE_CAP_TGSI_TES_LAYER_VIEWPORT``: Whether ``TGSI_SEMANTIC_LAYER`` and > + ``TGSI_SEMANTIC_VIEWPORT_INDEX`` are supported as tessellation evaluation > + shader outputs. Not that I'm opposed, but is there hardware that can support it

[Mesa-dev] [PATCH v2 1/2] gallium: Enable ARM NEON/VFP CPU detection.

2017-04-13 Thread Eric Anholt
I wrote this code with reference to pixman, though I've only decided to cover Linux (what I'm testing) and Android (seems obvious enough). Linux has getauxval() as a cleaner interface to the /proc entry, but it's more glibc-specific and I didn't want to add detection for that. This will be used t

Re: [Mesa-dev] [PATCH 1/5] gallium: add PIPE_CAP_TGSI_TES_LAYER_VIEWPORT

2017-04-13 Thread Nicolai Hähnle
On 13.04.2017 23:05, Ilia Mirkin wrote: On Thu, Apr 13, 2017 at 4:30 PM, Nicolai Hähnle wrote: +* ``PIPE_CAP_TGSI_TES_LAYER_VIEWPORT``: Whether ``TGSI_SEMANTIC_LAYER`` and + ``TGSI_SEMANTIC_VIEWPORT_INDEX`` are supported as tessellation evaluation + shader outputs. Not that I'm opposed, but

Re: [Mesa-dev] [PATCH 1/2] radv: Increase integer sizes in descriptor sets.

2017-04-13 Thread Fredrik Höglund
On Thursday 13 April 2017, Bas Nieuwenhuizen wrote: > Needed if we want to allow them taking more than 64 KiB. The calculations > of these already used 32 bits. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/amd/vulkan/radv_descriptor_set.h | 16 > 1 file changed, 8 insertions

[Mesa-dev] [PATCH] radv: make sizes & offsets 32 bit in radv_descriptor_update_template_entry.

2017-04-13 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_private.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index 00190e7eee0..2afc0cbedfc 100644 --- a/src/amd/vulkan/radv_private.h +++ b/src/amd/v

[Mesa-dev] [PATCH v2] radv: make sizes & offsets 32 bit in radv_descriptor_update_template_entry.

2017-04-13 Thread Bas Nieuwenhuizen
v2: Also convert the calculations. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_descriptor_set.c | 4 ++-- src/amd/vulkan/radv_private.h| 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv

Re: [Mesa-dev] [PATCH v2] radv: make sizes & offsets 32 bit in radv_descriptor_update_template_entry.

2017-04-13 Thread Fredrik Höglund
On Thursday 13 April 2017, Bas Nieuwenhuizen wrote: > v2: Also convert the calculations. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/amd/vulkan/radv_descriptor_set.c | 4 ++-- > src/amd/vulkan/radv_private.h| 10 +- > 2 files changed, 7 insertions(+), 7 deletions(-) > > di

[Mesa-dev] [PATCH 2/3] radv: use push descriptors in meta

2017-04-13 Thread Fredrik Höglund
Use push descriptors instead of temp descriptor sets. Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_meta_blit.c | 51 +++--- src/amd/vulkan/radv_meta_blit2d.c | 94 +-- src/amd/vulkan/radv_meta_buffer.c | 122 ++ src/amd/vulkan/radv_meta_bufimage.c

[Mesa-dev] [PATCH 1/3] radv: add private push descriptors for meta

2017-04-13 Thread Fredrik Höglund
This allows meta to use push descriptors without disturbing user push descriptors. radv_meta_push_descriptor_set differs from vkCmdPushDescriptorSetKHR in that partial updates are not supported; all descriptors used in subsequent draw commands must be pushed at the same time. Signed-off-by: Fredr

[Mesa-dev] [PATCH 3/3] radv: remove the temp descriptor set infrastructure

2017-04-13 Thread Fredrik Höglund
It is no longer used. Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_descriptor_set.c | 94 +++- src/amd/vulkan/radv_private.h| 10 2 files changed, 28 insertions(+), 76 deletions(-) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/am

[Mesa-dev] [PATCH] st/mesa: add st_convert_sampler()

2017-04-13 Thread Samuel Pitoiset
Similar to st_convert_image(), will be useful for bindless. While we are at it, rename convert_sampler() to convert_sampler_from_unit() and make 'st' a const argument. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_atom_sampler.c | 42 +++- src/mesa/stat

[Mesa-dev] [PATCH] swr: Enable MSAA in OpenSWR software renderer

2017-04-13 Thread Bruce Cherniak
This patch enables multisample antialiasing in the OpenSWR software renderer. MSAA is a proof-of-concept/work-in-progress with bug fixes and performance on the way. We wanted to get the changes out now to allow several customers to begin experimenting with MSAA in a software renderer. So as not

  1   2   >